New submission from Bill Janssen :
Take a look at the first line of make_id(). What does that comment mean? Is
the wrong line commented out?
def make_id(str, add_num=True):
#str = str.replace(".", "_") # colons are allowed
--
components: Library (Lib), Wind
Bill Janssen added the comment:
Yes, I've tried that. No joy. Right now I'm trying an approach which
packages each top-level directory as a separate cab.
What I'm finding is that if I get up around 4200 files, it breaks,
regardless of the file sizes. Out of curiosity, how ma
Changes by Bill Janssen :
Removed file: http://bugs.python.org/file17118/unnamed
___
Python tracker
<http://bugs.python.org/issue8552>
___
___
Python-bugs-list mailin
Bill Janssen added the comment:
I've now been able to build my installer.
I applied Travis Oliphant's patch from http://bugs.python.org/issue2399 to
Lib/msilib/__init__.py, then added a __del__ method to the Directory class:
def __del__(self):
if self._numfiles_wo_
Bill Janssen added the comment:
Another bit of info. It's the frequent commits that seem to fix the problem;
when I comment those out of the __del__ method, it fails as before. I also
notice that the finished installer is about twice the size of the two data
files in it (the CAB fil
Bill Janssen added the comment:
Ah, found the size problem -- I was measuring something in 512 blocks not 1KB
blocks. Never mind.
--
___
Python tracker
<http://bugs.python.org/issue8
Bill Janssen added the comment:
I'm seeing the leaks on my Leopard machine. I haven't had a chance to look
into it yet.
On Dec 1, 2007 11:20 AM, Christian Heimes <[EMAIL PROTECTED]> wrote:
>
> Christian Heimes added the comment:
>
> Are you sure that the SSL te
Bill Janssen added the comment:
I'm still not sure what the problem is. This code was working fine when I
committed it, no leaks, so something else must have changed under the
covers. I don't believe that adding GC to the C code is the answer; it
should be automatically GC'd. S
Bill Janssen added the comment:
I think I've figured it out. My initial patch to socket.py and ssl.py
had an extra method defined on socket.socket, _real_close(), which did'
the cleanup work of deallocating the underlying socket, and in the SSL
subclass, of releasing the SSL conte
Bill Janssen added the comment:
So, what's the final status of __del__ in py3K? The other bit of leak
is due to _real_close() not being called when a socket is dropped on the
floor (say, you try to connect, fail, and raise the exception back to
the caller, without ever explicitly calling
Bill Janssen added the comment:
The other leak comes from this code:
s = ssl.wrap_socket(socket.socket(), ...)
s.connect((SOME BOGUS ADDRESS OR SERVER))
The connect() fails, and the SSLSocket "s"gets dropped on the floor,
but never seems to be GC'd, (or the GC never se
Bill Janssen added the comment:
gc.garbage is always empty.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1469>
__
___
Python-bugs-list mailing list
Unsubs
Bill Janssen added the comment:
Ah, I see what's going on. The revision of the socket code (nice job,
by the way) removed the distinction between the C socket object and the
Python socket object. The C SSLContext keeps a pointer to the C socket
object, which is now the Python socket objec
Bill Janssen added the comment:
I think Christian analysis is right, in that it takes a bit of GC
support, but not perhaps in the specifics of his approach. I've done
two things to fix this:
1) Put _real_close() back in socket.py, and then override it in
ssl.SSLSocket to releas
Bill Janssen added the comment:
Here's a patch -- take a look and let me know.
I also added a real asyncore server test.
Added file: http://bugs.python.org/file8919/a
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Bill Janssen added the comment:
I'm still getting this with the latest SSL module fixes. I'm guessing
this is a problem with the implementation of imaplib, but I haven't
looked into it yet.
__
Tracker <[EMAIL PROTECTED]>
<http://b
Bill Janssen added the comment:
Here's a fix for the 3K branch.
Added file: http://bugs.python.org/file8921/b
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1482>
__
b
Descrip
Changes by Bill Janssen:
--
keywords: +patch
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1482>
__
___
Python-bugs-list mailing list
Unsubs
Bill Janssen added the comment:
I'll close this when the fix gets into all the branches (right now it's
in the pre-2.6 code, and in the 3K code, but not yet in the 2.6 branch).
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.p
Bill Janssen added the comment:
Now, about the "confused signature" of SSLSocket.read().
I'm not sure how confused it is. It's sui generis; SSLSocket doesn't
inherit from some other class with a different read() method with a
different signature. But we could ch
Changes by Bill Janssen:
Removed file: http://bugs.python.org/file8919/a
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1469>
__
___
Python-bugs-list
Bill Janssen added the comment:
Unfortunately, hostname matching is one of those ideas that seemed
better when it was thought up than it actually proved to be in practice.
I've had extensive experience with this, and have found it to almost
always an application-specific decision. I th
Bill Janssen added the comment:
Yes, I think that's reasonable. And for pseudo-standards like https, which
calls for this, the implementation in the standard library should attempt to
do it automatically. Unfortunately, that means that client-side certificate
verification has to be done
Bill Janssen added the comment:
The mechanism is there for direct use of the SSL module, yes. But the
question is, what should indirect usage, like the httplib or urllib modules,
do? If they are going to check hostnames on use of an https: URL, they need
some way to pass a ca_certs file
Bill Janssen added the comment:
Good catch. I flipped a bit cleaning up the C code.
Here's a fixed patch.
Added file: http://bugs.python.org/file8949/patch-3
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Changes by Bill Janssen:
Removed file: http://bugs.python.org/file8922/patch-2
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1469>
__
___
Python-bugs-list
Bill Janssen added the comment:
The server isn't handling the close event properly. I'll fix that.
On Dec 13, 2007 9:06 PM, Guido van Rossum <[EMAIL PROTECTED]> wrote:
>
> Guido van Rossum added the comment:
>
> I spoke too soon. In a debug build, this hangs
Bill Janssen added the comment:
Here's an update version where the asyncore test server properly handles
the EOF race condition.
Added file: http://bugs.python.org/file8955/patch-4
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Changes by Bill Janssen:
Removed file: http://bugs.python.org/file8949/patch-3
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1469>
__
___
Python-bugs-list
Changes by Bill Janssen:
Removed file: http://bugs.python.org/file8954/unnamed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1469>
__
___
Python-bugs-list
Bill Janssen added the comment:
Done.
On Dec 14, 2007 9:44 AM, Guido van Rossum <[EMAIL PROTECTED]> wrote:
>
> Guido van Rossum added the comment:
>
> > Here's an update version where the asyncore test server properly handles
> > the EOF race con
Bill Janssen added the comment:
Considering that HTTPSConnection uses the exact same code as
HTTPConnection to interpret the specified address, I think we need more
diagnosis in order to determine whether this is a real issue or not. If
it is, what's going
Changes by Bill Janssen:
--
assignee: janssen ->
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1654>
__
___
Python-bugs-list mailing list
Uns
Changes by Bill Janssen:
--
resolution: -> invalid
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1654>
__
___
Python-bugs
Bill Janssen added the comment:
Well, if someone writes test case and verifies it, I'll look at it.
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue592703>
_
Bill Janssen added the comment:
Unfortunately, it uses the deprecated socket.ssl calls. Re-worked to
use the new SSL module, it would be OK.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Bill Janssen added the comment:
Sounds good. If you want to develop this with 2.5.1, you can get an
API-compliant version of the SSL module for 2.5.1 from
http://pypi.python.org/pypi/ssl/.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Bill Janssen added the comment:
Great, Ray.
I don't see any test cases for the nntp library in the Lib/test/ directory.
How can we make sure it works on the buildbots?
Bill
On Jan 25, 2008 12:49 PM, Ray Chason <[EMAIL PROTECTED]> wrote:
>
> Ray Chason added the comment:
Bill Janssen added the comment:
Yeah, it took me a couple of months to do a reasonable test case for the SSL
code.
Perhaps we could test against an existing NNTP server? Like Google's?
Bill
On Jan 27, 2008 6:59 PM, Ray Chason <[EMAIL PROTECTED]> wrote:
>
> Ray Chason
Bill Janssen added the comment:
Thanks for the patch.
I'm of two minds about this. It may well be an appropriate patch for
2.5.2 -- I seem to recall having to do something much like this in the
new SSL module -- but it patches the old SSL code which we are replacing
for 2.6. And I'd
Bill Janssen added the comment:
But that's issue 1210, which is still open. David, do you want to
submit a patch for 1210?
Meanwhile, do we still need this issue to be open?
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Bill Janssen added the comment:
IMAP doesn't really support multiple charsets (just looked at RFC 3501).
There are two places where character sets other than ASCII is used.
One is in the SEARCH command; there's an optional parameter which can
indicate that the search strings are in a
Bill Janssen added the comment:
I guess I'll check it in. There's no effective test case for the
imaplib module, though. So if it's broken, we won't know.
When I try connecting to my local IMAP server, I get
>>> c = imaplib.IMAP4("127.0.0.1")
Tr
Bill Janssen added the comment:
I've committed the patch.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1482>
__
___
Python-bugs-list mailing list
U
Bill Janssen added the comment:
I guess I'll check it in. There's no effective test case for the
imaplib module, though. So if it's broken, we won't know.
When I try connecting to my local IMAP server, I get
>>> c = imaplib.IMAP4("127.0.0.1")
Tr
Changes by Bill Janssen:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1482>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Bill Janssen added the comment:
OK, I'll read it more carefully and compare it to the 2.6 version of the
code.
Bill
On Feb 1, 2008 8:00 AM, Guido van Rossum <[EMAIL PROTECTED]> wrote:
>
> Guido van Rossum added the comment:
>
> I think it's worth applying this t
Bill Janssen added the comment:
Looks like Giampaolo has already submitted a patch for part of this, in
http://bugs.python.org/issue1641
--
nosy: +giampaolo.rodola, josiahcarlson
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Bill Janssen added the comment:
I should point out that I'm doing a big project with SSL and Python,
using Medusa, and asyncore. I've been re-working the 2.6 and 3.x SSL
support (with guidance from Giampolo :-) so that true async capability
is possible for SSL.
--
nosy
New submission from Bill Janssen:
I've been reading asyncore lately, and feel that it's showing its age.
Most loops of this sort (we developed something similar for ILU, about
15 years ago) contain handlers for timers and work tasks, in addition to
input handling. For timers, typical
New submission from Bill Janssen:
cookielib contains an implementation of FileCookieJar for Mozilla
Firefox, which will work with most of the various Mozilla browsers, but
no implementation for Internet Explorer, standard on Windows and used by
some 80% of computer users.
--
components
New submission from Bill Janssen:
cookielib has no FileCookieJar class for Safari, Apple's standard and
default browser for OS X.
--
components: Library (Lib)
messages: 62047
nosy: janssen
severity: normal
status: open
title: cookielib lacks FileCookieJar class for Safari
type: beh
Bill Janssen added the comment:
I have code to read Safari cookies, but no code to write them. I'll
have to look at the FileCookieJar interface.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Bill Janssen added the comment:
*I'm not sure to understand what do you mean by "work tasks".*
They're low-priority tasks that need to get run sometime, but aren't
associated with an input source. In ILU, we had a function called
"do_soon", and you could cal
Bill Janssen added the comment:
Yes, I saw that, but it doesn't really help. Batteries not included.
It suggests an approach to addressing this problem, though: see if the
author will contribute the code under an appropriate licence.
I intend to write an instance of FileCookieJar for S
Bill Janssen added the comment:
Yes, that's it exactly. So things without work tasks can still get done.
But timers are the important thing. With timers you can always implement
work tasks by yourself.
On Feb 6, 2008 12:49 PM, Giampaolo Rodola' <[EMAIL PROTECTED]> wrote
Bill Janssen added the comment:
Sorry, I meant to say, "so things without input FDs can make progress".
On Feb 6, 2008 8:08 PM, Bill Janssen <[EMAIL PROTECTED]> wrote:
> Yes, that's it exactly. So things without work tasks can still get done.
>
> But timers
Bill Janssen added the comment:
Yes, I think we're talking about the same thing, too.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue2006>
__
___
Python-
Changes by Bill Janssen:
--
nosy: +janssen
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1563>
__
___
Python-bugs-list mailing list
Unsubs
Bill Janssen added the comment:
This is a straightforward implementation of client-side use of SSL, but
it's missing a test case for evaluation. It should include a patch to
test_ftplib to test it.
Another thing to look at is what the useful arguments are to pass in for
TLS usage over FTP
New submission from Bill Janssen <[EMAIL PROTECTED]>:
The OS X linker now understands -R, but distutils continues to pass the
wrong flags back in
distutils.unixccompiler.runtime_library_dir_option(). I'm checking with
the Apple folks as to exactly what the right flag is.
Bill Janssen <[EMAIL PROTECTED]> added the comment:
Looking at this patch, I definitely agree with the need for
documentation.And a test case which uses the SafeTransport class.
But the patch itself also needs a bit more work. (It uses httplib.HTTPS
underneath, and that needs mor
Bill Janssen <[EMAIL PROTECTED]> added the comment:
I'm working on it. I'll close it when it's finished.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1251>
__
_
Bill Janssen <[EMAIL PROTECTED]> added the comment:
No test case. No provision for client validation of server certificate.
--
resolution: -> rejected
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.py
Bill Janssen <[EMAIL PROTECTED]> added the comment:
As you point out, the other classes should be fixed. The old client-side
protocol was never very well thought out, IMHO. Continuing to propagate it
would be a mistake.
Bill
On Wed, Mar 19, 2008 at 12:22 PM, Giampaolo Rodola&#x
Bill Janssen <[EMAIL PROTECTED]> added the comment:
Probably what I should do is fix httplib, that would provide an example we
could extend to the rest of the modules.
Bill
On Wed, Mar 19, 2008 at 1:46 PM, Giampaolo Rodola' <[EMAIL PROTECTED]>
wrote:
>
> Giampaolo Ro
Bill Janssen <[EMAIL PROTECTED]> added the comment:
Once I've got JCC working, and finished the SSL work for 2.6.
On Wed, Mar 19, 2008 at 1:46 PM, Giampaolo Rodola' <[EMAIL PROTECTED]>
wrote:
>
> Giampaolo Rodola' <[EMAIL PROTECTED]> added the comment:
&g
Changes by Bill Janssen <[EMAIL PROTECTED]>:
--
components: +Distutils
priority: -> high
type: -> crash
versions: +Python 2.3, Python 2.4, Python 2.5, Python 2.6, Python 3.0
__
Tracker <[EMAIL PROTECTED]>
<http://bugs
New submission from Bill Janssen <[EMAIL PROTECTED]>:
The distutils.unixcompiler.runtime_library_dirs() function, used when
compiling with MinGW or Cygwin on Windows, fails catastrophically
because the return result of sysconfig.get_config_var("CC") returns
None. It should prob
Bill Janssen <[EMAIL PROTECTED]> added the comment:
On Fri, Mar 21, 2008 at 5:43 AM, Robert E. <[EMAIL PROTECTED]> wrote:
>
> Robert E. <[EMAIL PROTECTED]> added the comment:
>
> Concerning the plain-text login. I think a FTPS class should default to
> encry
Bill Janssen <[EMAIL PROTECTED]> added the comment:
Fine with me. I don't have a checkout of the code handy, but I believe
this is obsolete test code. All the SSL tests are, or should be, in
test_ssl, for 2.6 and 3.x. The right fix is to remove it.
___
Bill Janssen <[EMAIL PROTECTED]> added the comment:
Here's what the OS X man page says:
The getsockname() function returns the value 0 if successful; otherwise
the value -1 is returned and the global variable errno is set to
indicate the error.
___
Bill Janssen <[EMAIL PROTECTED]> added the comment:
On Tue, Apr 22, 2008 at 12:15 PM, Trent Nelson <[EMAIL PROTECTED]>
wrote:
>
> Trent Nelson <[EMAIL PROTECTED]> added the comment:
>
> Hey, if we can get rid of it, that's great. You sound 95% certain
Bill Janssen <[EMAIL PROTECTED]> added the comment:
Sorry, didn't mean to be indeterminate. Sure, nuke it. The tests are now
all in test_ssl.py.
Bill
On Tue, Apr 22, 2008 at 2:47 PM, Bill Janssen <[EMAIL PROTECTED]>
wrote:
>
>
> On Tue, Apr 22, 2008 at 12:1
Bill Janssen <[EMAIL PROTECTED]> added the comment:
No, the problem is with your "ca_certs" argument on the client side.
You can't use a directory. You must use a file containing a number of
concatenated certificates. I'll beef up the documentation to make that
clear
New submission from Bill Janssen <[EMAIL PROTECTED]>:
Once again I'm reading through the ctypes documentation and finding it
wildly confusing/contradictory. For instance, there's no discussion of
how ctypes types interact with malloc and free. The tutorial section is
discurs
New submission from Bill Janssen <[EMAIL PROTECTED]>:
On OS X, dynamically loadable libraries come in several flavors:
.bundle (or, often, .so) a standard dynamically loadable module; .dylib,
a dynamically loadable module that is also a library that can be linked
against like a .
Bill Janssen <[EMAIL PROTECTED]> added the comment:
Victor, what kind of content have you tried this with? For instance, have
you passed unencoded (Content-Transfer-Encoding: binary) binary data through
it, by mailing a JPEG, for instance? These things are strings really only
Bill Janssen <[EMAIL PROTECTED]> added the comment:
Maybe the first thing to do is to expand the Lib/test/test_imaplib.py
file, which right now is pretty darn minimal. We really need an IMAP
server somewhere to test against, with a standard library of varied
messages.
Perhaps Python.
Bill Janssen <[EMAIL PROTECTED]> added the comment:
I agree, too.
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue3890>
___
___
Python-bugs
Changes by Bill Janssen <[EMAIL PROTECTED]>:
--
assignee: -> janssen
___
Python tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue4171>
___
___
Bill Janssen <[EMAIL PROTECTED]> added the comment:
Thanks for the patch. It looks pretty good to me, but I can't help
thinking that there must be a better way of handling the recv() case; I
don't like copying that buffer several times (from the SSL code to
Python, from the Pyth
Bill Janssen <[EMAIL PROTECTED]> added the comment:
Unrelated? OK, but in fact I fixed this in 3.0 by providing a different
internal API to _ssl.c. But you're right, that's an optimization.
___
Python tracker <[EMAIL PROTECTED]>
&
New submission from Bill Janssen :
The build script for a Mac OS installer, in
Mac/BuildScript/build-installer.py, currently requires OS 10.4 and
Python 2.3. At some point it will have to be ported to a newer version
of Python (and Mac OS). It uses a number of modules which are slated
for
Bill Janssen added the comment:
Actually, that's not quite true. Specifying TLSv1 or SSLv3 on the
server side will disable SSLv2. However, there's currently no way to
specify SSLv3 *or* TLSv1 *but not* SSLv2. This looks easy to fix; I'll
add another entry to the list of pr
Bill Janssen added the comment:
Well, maybe he found something -- never reported back. But it was a few
months ago... I'm in no hurry to close it, though.
___
Python tracker
<http://bugs.python.org/i
Bill Janssen added the comment:
Lorenzo, do we have test cases for this? I think you should try to add
some test cases. We may need to set up some test mail servers on
python.org to accommodate such tests.
--
nosy: +janssen
___
Python tracker
New submission from Bill Janssen :
The behavior when a write or send is interrupted is suboptimal. If the
write buffer moves before a retry is attempted in response to
SSL_ERROR_WANT_OUTPUT, OpenSSL rejects the retry attempt. See
http://www.mail-archive.com/openssl-us...@openssl.org/msg07806
Bill Janssen added the comment:
Looks like 1431 was closed by removing a line from the documentation, so
it's not surprising that it's not clear.
--
nosy: +janssen
___
Python tracker
<http://bugs.python.
Bill Janssen added the comment:
I wonder if there is any way to test this, aside from the tests that
are already in the test suite? The bug here is that the code effectively
does a blocking read on a non-blocking socket, and we can't tell the
difference. The fact that this patch passe
Bill Janssen added the comment:
On Tue, Sep 29, 2009 at 12:47 PM, Giampaolo Rodola'
wrote:
>
> Giampaolo Rodola' added the comment:
>
> Uhm... I'm sorry but actually I'm not sure about this patch anymore.
> Now that I look at ssl.py again I'm noticing t
Bill Janssen added the comment:
Martin, I'm thinking that the module object has a __del__ method, and we could
un-register the callbacks there. But I don't know if that method would ever
get called. How does the act of "unloading a library" interact with the
initialize
Bill Janssen added the comment:
I'd recommend running the whole suite of tests here. The issue is
mainly with httplib, as I recall it, which "closes" the socket before it
finishes reading from it.
___
Python tracker
<http://bugs.py
Bill Janssen added the comment:
No, Tarek, I don't have a MinGW machine right now. But it should be
easy to reproduce; just invoke that call I originally reported. The
distutils code is just making assumptions that it shouldn't be making.
Bill Janssen added the comment:
Tarek writes:
> Laurent, right. but we need to figure out how to get the CC name in
> MinGW/Cygwin environment.
> I am not familiar with them.
Since this bug is specifically about that environment, shouldn't it be
handled by someone who is fami
Bill Janssen added the comment:
Why can't we use python.org for tests? Do we need IMAP/POP servers
running? Let's send some mail to pydotorg to get that set up.
___
Python tracker
<http://bugs.python.
Bill Janssen added the comment:
Yes, the reason is that the supplied patch doesn't provide enough test
cases. This is a big patch; 2.5.x is a bug-fix release; a newer version
of the SSL code is available from PyPI as a work-around; I don't have
time right now to write more tests my
Bill Janssen added the comment:
I brought this up on pydotorg, and Barry suggests that someone put
together a Twisted environment which could be downloaded and run locally
on the test machine. It would provide IMAP and POP servers, perhaps
NNTP and others as well. Now, all we need is someone
Bill Janssen added the comment:
Looks good. The contrast is stark.
___
Python tracker
<http://bugs.python.org/issue4848>
___
___
Python-bugs-list mailing list
Unsub
New submission from Bill Janssen :
test_tk fails on OS X if test is run from a daemon process without the
privilege to access the window server, say a buildbot slave without anyone
logged in to the console. The Tk support needs to check whether it has access
rights to the window server
201 - 300 of 313 matches
Mail list logo
