Berker Peksag added the comment:
New changeset 39fcd9949832323b672f7ff05fd1498b8844a329 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-34329: Doc'd how to remove suffix of pathlib.Path() (GH-8655)
https://github.com/python/cpython/commit/39fcd9949832323b672f7ff05
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8161
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34171>
___
___
Py
Berker Peksag added the comment:
The documentation has been modernized in
https://github.com/python/cpython/commit/1d80a561734b9932961c546b0897405a3bfbf3e6
and the "Weak Reference Support" section has been updated to show the modern
way of adding weakref support:
https://
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
It would be nice to remove PyCObject_* entries from Doc/data/refcounts.dat.
+.. _documentation: http://py3c.readthedocs.org/en/latest/capsulethunk.html
Nit: We could the HTTPS link.
--
nosy: +berker.peksag
stage: -> patch review
t
Berker Peksag added the comment:
All changes (except PyUnicode_EncodeDecimal() which was deprecated in Python
3.3) have already been implemented in the following commits:
*
https://github.com/python/cpython/commit/c679227e31245b0e8dec74a1f7cc77710541d985
*
https://github.com/python/cpython
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8177
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Berker Peksag :
--
nosy: +berker.peksag
type: -> enhancement
versions: +Python 3.7, Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.org/issu
Berker Peksag added the comment:
PR 8590 only changes dbm.gnu. If we do this, we should update dbm.ndbm as well:
https://github.com/python/cpython/blob/4a745333406a4b9c5b0194bdac4a77d9fadd5457/Modules/_dbmmodule.c#L65
--
nosy: +berker.peksag
type: -> enhancement
versi
Berker Peksag added the comment:
Thanks for the report. wiki.python.org is maintained by the Python community,
not by Python core developers. You can fix those broken links by creating an
account and requesting edit access by emailing to pydotorg-...@python.org. See
https://wiki.python.org
Change by Berker Peksag :
--
pull_requests: +8187
___
Python tracker
<https://bugs.python.org/issue2122>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
New changeset e4dcbbd7f4ac18d01c0ec85f64ae98b8281ed403 by Berker Peksag in
branch 'master':
bpo-18540: Fix EAI_NONAME in imaplib.IMAP4*() (GH-8634)
https://github.com/python/cpython/commit/e4dcbbd7f4ac18d01c0ec85f64ae98
Berker Peksag added the comment:
New changeset 5799e5a84c78eac672e5f5f4f3fd2d903ba51a9d by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-18540: Fix EAI_NONAME in imaplib.IMAP4*() (GH-8634)
https://github.com/python/cpython/commit/5799e5a84c78eac672e5f5f4f3fd2d
Berker Peksag added the comment:
New changeset 671a13a7b6ff1022a6fd868e5842687123ab9fd1 by Berker Peksag (Miss
Islington (bot)) in branch '3.6':
bpo-18540: Fix EAI_NONAME in imaplib.IMAP4*() (GH-8634)
https://github.com/python/cpython/commit/671a13a7b6ff1022a6fd868e584268
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7, Python 3.8 -Python 3.4, Python 3.5
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
This is probably a regression from the Argument Clinic conversion.
Another docstring mismatches:
select(rlist, wlist, xlist, timeout=None, /)
Wait until one or more file descriptors are ready for some kind of I/O.
>>> select.select(ti
Berker Peksag added the comment:
New changeset 423d05f6f59b24c91b9ef6b2e4ac130316764382 by Berker Peksag in
branch 'master':
bpo-34333: Fix %-formatting in Path.with_suffix() (GH-8663)
https://github.com/python/cpython/commit/423d05f6f59b24c91b9ef6b2e4ac13
Berker Peksag added the comment:
New changeset c614121224a5a81d958643471720645b1cb3166e by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-34333: Fix %-formatting in Path.with_suffix() (GH-8663)
https://github.com/python/cpython/commit/c614121224a5a81d95864347172064
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.6
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset 84a13fbda0d79789e3c9efcc9f64752261ce1e8d by Berker Peksag in
branch 'master':
bpo-9372: Deprecate several __getitem__ methods (GH-8609)
https://github.com/python/cpython/commit/84a13fbda0d79789e3c9efcc9f6475
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Berker Peksag added the comment:
New changeset c8b0dbc4928a1fe4bd5abebd810b6849374c7af3 by Berker Peksag in
branch 'master':
bpo-26818: Add a test to make sure the bug is fixed (GH-8664)
https://github.com/python/cpython/commit/c8b0dbc4928a1fe4bd5abebd810b68
Berker Peksag added the comment:
New changeset c8b0dbc4928a1fe4bd5abebd810b6849374c7af3 by Berker Peksag in
branch 'master':
bpo-26818: Add a test to make sure the bug is fixed (GH-8664)
https://github.com/python/cpython/commit/c8b0dbc4928a1fe4bd5abebd810b68
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7, Python 3.8 -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset 8fc21c80af73226de875886132e0c32a4ffb32c5 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-26818: Add a test to make sure the bug is fixed (GH-8664)
https://github.com/python/cpython/commit/8fc21c80af73226de875886132e0c3
Berker Peksag added the comment:
New changeset 8fc21c80af73226de875886132e0c32a4ffb32c5 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-26818: Add a test to make sure the bug is fixed (GH-8664)
https://github.com/python/cpython/commit/8fc21c80af73226de875886132e0c3
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8225
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue34384>
___
___
Py
Berker Peksag added the comment:
I'd suggest adding a FAQ entry to the "Core Language" section at
https://docs.python.org/3/faq/programming.html#core-language then we can link
to it from the places (except pydoc docs) Zachary listed in msg223893.
--
nosy:
Change by Berker Peksag :
--
components: +Library (Lib) -Argument Clinic
nosy: +eric.smith -larry
___
Python tracker
<https://bugs.python.org/issue34387>
___
___
Berker Peksag added the comment:
Steve and/or Eryk, I was adding some tests for os.readlink() in PR 8740 and I
noticed that os.readlink() always returns str on Windows. However, the
documentation for os.readlink() says:
If the path is a bytes object (direct or indirectly), the result
Berker Peksag added the comment:
Issue 20055 was a duplicate of this one. Both tests have been adjusted in
https://github.com/python/cpython/commit/3f48ac98c04fc17f12c63dcf593dd0c19379c7df.
--
dependencies: -os.chmod() does not follow symlinks on Windows,
os.path.realpath on
Berker Peksag added the comment:
In msg235615 (Issue 9949), Zachary said using bytes paths on Windows is
deprecated, but I can't see the actual conversation because Rietveld seems to
be down: https://bugs.python.org/review/9949/#ps5077 I think the os.readlink()
documentation needs
Berker Peksag added the comment:
Thanks for the suggestions! I've updated PR 8740. I will submit separate PRs to
fix os.readlink() documentation in 3.6 and 3.7 branches.
--
___
Python tracker
<https://bugs.python.org/is
Berker Peksag added the comment:
ArgumentParser.parse_intermixed_arg() has been added in
https://github.com/python/cpython/commit/0f6b9d230674da784ca79a0cf1a03d2af5a8b6a8
(Issue 14191) and the "Upgrading optparse code" section now has the following
item:
Berker Peksag added the comment:
All PRs have been merged (commit message from the 3.6 branch doesn't listed
here but PR 7889 has been merged in
https://github.com/python/cpython/commit/8f8ad2c38237caf5ee48f690289e8c811d245455)
Closing this as 'fixed'. Please reopen if this
Change by Berker Peksag :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue34406>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
New changeset e0b5b2096ead4cc094a129ce7602ac5c0e998086 by Berker Peksag in
branch 'master':
bpo-34384: Fix os.readlink() on Windows (GH-8740)
https://github.com/python/cpython/commit/e0b5b2096ead4cc094a129ce7602ac
Berker Peksag added the comment:
Ammar's pull request looks good to me, but it would be nice to include the
item's title in the box. I will add my comments about the design and
implementation in the pull request.
--
resolution: t
Berker Peksag added the comment:
The list has been updated in
https://github.com/python/cpython/commit/bf9d317626eebcf79bd0756b4dd43df82d5cc186
(Issue 31810
Closing this as 'outdated'. Thanks for the report and for the patch.
--
nosy: +berker.peksag
resolution: ->
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Berker Peksag added the comment:
New changeset c53aaec793e018edef4e72a3edbd338b10db10aa by Berker Peksag
(Sebastian Rittau) in branch 'master':
bpo-34418: Fix HTTPErrorProcessor documentation (GH-8793)
https://github.com/python/cpython/commit/c53aaec793e018edef4e72a3edbd33
Berker Peksag added the comment:
New changeset 02c4d4b6dcd772ec3a7fdca517118f3fa53b0b88 by Berker Peksag (Miss
Islington (bot)) in branch '3.6':
bpo-34418: Fix HTTPErrorProcessor documentation (GH-8793)
https://github.com/python/cpython/commit/02c4d4b6dcd772ec3a7fdca517118f
Berker Peksag added the comment:
Thanks for the report and for the patch! 3.5 is in security-fix-only mode, so
it doesn't get documentation fixes anymore.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> behavior
versions: +P
Change by Berker Peksag :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue34420>
___
___
Berker Peksag added the comment:
Eryk, would you like to address Steve's comments and convert your patch to a
GitHub pull request? Let me know if you don't have time to prepare a new patch.
--
nosy: +berker.peksag
versions: -Python 3.6,
Berker Peksag added the comment:
Some parts of the patch have already been applied into master:
* PySys_GetObject():
https://github.com/python/cpython/commit/7a5457b6878db61910c81017d10579edb7c91512
* PyDict_SetItem():
https://github.com/python/cpython/commit
Berker Peksag added the comment:
All of the PyModule_AddIntMacro() changes have already been applied in
https://github.com/python/cpython/commit/6782b14bcba612e4a39e41992c77306217b91e30.
The remaining parts are:
-x = PyLong_FromLong((long)NSIG);
-if (!x || PyDict_SetItemString(d
Berker Peksag added the comment:
A variant of localemodule.patch without error checking for
PyModule_AddIntMacro() has been applied in
https://github.com/python/cpython/commit/ff4fddde57d5579dff3a83d99e20cd06366b10d6.
Christian, can this be closed or do we still need to add error checking
Berker Peksag added the comment:
Thanks for the report.
Looking at the Kernel source code, there doesn't seem to be any difference
between -1, -100, or -255:
https://github.com/torvalds/linux/blob/9bd553929f68921be0f2014dd06561e0c8249a0d/fs/eventpoll.c#L1747-L1761
Do you know any oth
Berker Peksag added the comment:
Thank you for your report.
Quoting from https://docs.python.org/3.6/library/functions.html#eval
This function can also be used to execute arbitrary code objects
(such as those created by compile()). In this case pass a code
object instead of a
Berker Peksag added the comment:
Ok, I think it would be a good idea to mention that the function accepts a code
object in the first sentence. I'd be happy to review such PR. The eval()
documentation is located at
https://github.com/python/cpython/blob/master/Doc/library/functions.rst
Change by Berker Peksag :
--
pull_requests: +8290
___
Python tracker
<https://bugs.python.org/issue22057>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
I like Martin's suggestion in msg282262 and I've just created PR 8812 to
implement it.
--
nosy: +berker.peksag
type: -> behavior
versions: +Python 3.8 -Python 3.5
___
Python tracker
<https:/
Berker Peksag added the comment:
Thank you for the report, Xavier.
This is a duplicate of issue 22057.
PR 8812 clarifies the behavior when a dictionary without a "__builtins__" key
is passed as *globals* to eval(). I think that makes the opposite case much
easier to understand.
Change by Berker Peksag :
--
resolution: -> out of date
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/
Berker Peksag added the comment:
New changeset 225b05548027d55aafb11b65f6a4a2bef2f5196f by Berker Peksag in
branch 'master':
bpo-22057: Clarify eval() documentation (GH-8812)
https://github.com/python/cpython/commit/225b05548027d55aafb11b65f6a4a2
Berker Peksag added the comment:
Thanks for the review, Martin, and thanks for the report, Alon!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<https://bugs.python.org/issue25810>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks for the report. In the title, you mentioned epoll.poll(), but you gave
the link to the poll.poll() documentation. Also, the part you quoted
If timeout is given, it specifies the length of time in milliseconds
which the system will wait for
Berker Peksag added the comment:
poll.modify() is documented in both Python 2 and Python 3 docs:
* https://docs.python.org/2/library/select.html#select.poll.modify
* https://docs.python.org/3/library/select.html#select.poll.modify
> I believe that should be "Modify a registe
Berker Peksag added the comment:
New changeset cdbf50cba1664f72ae6621a89c324a32fea70377 by Berker Peksag (Alexey
Izbyshev) in branch 'master':
bpo-34441: Fix ABC.__subclasscheck__ crash on classes with invalid
__subclasses__ (GH-8835)
https://github.com/python/cpyt
Berker Peksag added the comment:
New changeset e7d4b2f205c711d056bea73a0093e2e2b200544b by Berker Peksag in
branch 'master':
bpo-2122: Make mmap.flush() behave same on all platforms (GH-8692)
https://github.com/python/cpython/commit/e7d4b2f205c711d056bea73a0093e2e2b200544b
-
Berker Peksag added the comment:
Thanks for the suggestions and for the reviews!
--
assignee: brian.curtin ->
priority: high -> normal
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python
Berker Peksag added the comment:
New changeset c583919ffced0a3b6409766fc12f6e28bef4fac7 by Berker Peksag (Alexey
Izbyshev) in branch 'master':
bpo-34462: Add missing NULL check to _copy_raw_string() (GH-8863)
https://github.com/python/cpython/commit/c583919ffced0a3b6409766fc12f6e
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
New changeset 48ce4897f8f8d91d948ecd1241ffab002df2be9e by Berker Peksag
(Michael Osipov) in branch 'master':
bpo-34412: Make signal.strsignal() work on HP-UX (GH-8786)
https://github.com/python/cpython/commit/48ce4897f8f8d91d948ecd1241ffab
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
Personally I wouldn't bother fixing 2.7, but let's see what other core devs
think.
--
___
Python tracker
<https://bugs.python.o
Berker Peksag added the comment:
The message is a bit more descriptive if wchar_t isn't usable:
> checking whether wchar_t is signed... yes
> no usable wchar_t found
I'm not sure if it's worth to backport to 3.6, but it's a nice improvement for
3.7 and master bra
Change by Berker Peksag :
--
Removed message: https://bugs.python.org/msg323967
___
Python tracker
<https://bugs.python.org/issue34480>
___
___
Python-bugs-list m
Change by Berker Peksag :
--
status: -> open
___
Python tracker
<https://bugs.python.org/issue34480>
___
___
Python-bugs-list mailing list
Unsubscrib
Berker Peksag added the comment:
After triaging issue 34480, I realized that we can't simply remove the error()
method because the _markupbase.ParserBase() class still uses it. I've just
closed PR 8562.
--
___
Python track
Change by Berker Peksag :
--
stage: patch review -> test needed
___
Python tracker
<https://bugs.python.org/issue31844>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
Issue 34480 is another relevant issue. The HTMLParse method doesn't have an
error() method and it doesn't raise any exceptions, but its base class still
does. I think there is a compatibility problem between html.parser.HTMLPar
Change by Berker Peksag :
--
nosy: +berker.peksag
type: -> enhancement
versions: +Python 3.7, Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.org/issu
Change by Berker Peksag :
--
components: +Library (Lib)
nosy: +berker.peksag
___
Python tracker
<https://bugs.python.org/issue28069>
___
___
Python-bugs-list m
Berker Peksag added the comment:
New changeset 3738fadc670274ecc4649f51b52a93602820a375 by Berker Peksag
(Michael Osipov) in branch 'master':
bpo-34448: Improve output of usable wchar_t check (GH-8846)
https://github.com/python/cpython/commit/3738fadc670274ecc4649f51b52a93
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
The resolve() method already solves symlinks, but I think this is a reasonable
feature request. I've just reviewed PR 8285.
--
nosy: +berker.peksag, pitrou
versions: +Python 3.8 -Python 3.7
___
Python tr
Change by Berker Peksag :
--
type: enhancement -> crash
___
Python tracker
<https://bugs.python.org/issue33803>
___
___
Python-bugs-list mailing list
Un
Change by Berker Peksag :
--
keywords: +patch
pull_requests: +8502
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue29386>
___
___
Py
Berker Peksag added the comment:
New changeset 4e519377b1b84c9414a360961276993d24198825 by Berker Peksag
(Zackery Spytz) in branch 'master':
bpo-23855: Add missing NULL checks for malloc() in _msi.c (GH-9038)
https://github.com/python/cpython/commit/4e519377b1b84c9414a36096127699
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 2.7, Python 3.6
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
We always explicitly document what the context manager does even if it simply
calls an object's close() method. See
https://docs.python.org/3/library/fileinput.html#fileinput.input and
https://docs.python.org/3/library/shelve.html#shelve.Shelf for ex
Berker Peksag added the comment:
Personally, I find parent/child more descriptive if it can be used in the same
context with master/slave, so I'm in favor of replacing master/slave with
parent/child where applicable.
However, I agree that the code changes in PR 9100 are a bit excessiv
Berker Peksag added the comment:
I'm working on converting Modules/_sqlite/* to Argument Clinic.
--
nosy: +berker.peksag
versions: +Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.org/is
Berker Peksag added the comment:
> Should I remove or change this line as per Daniel's comment "Note that
> this does not automatically call :meth:`close` on the connection object."
I'd prefer to keep the current wording as-is.
--
Berker Peksag added the comment:
PR 9079 looks good to me.
I think we can use this as an opportunity to make the rest of the examples in
the sqlite3 documentation more consistent and add missing "conn.close()" calls.
--
___
Python track
Change by Berker Peksag :
--
resolution: -> wont fix
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
Welcome, Noah! Feel free to work on this issue, but please note that there is
no consensus on the best place to document / signatures, so you may need to
move your changes between locations (e.g. from Doc/faq/programming.rst to
Doc/gloassary.rst) before we
Berker Peksag added the comment:
New changeset b690b9b04729ba3d91c59bff1bb11c3dcc1b50fc by Berker Peksag in
branch 'master':
bpo-29386: Pass -1 to epoll_wait() when timeout is < -1 (GH-9040)
https://github.com/python/cpython/commit/b690b9b04729ba3d91c59bff1bb
Change by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.6, Python 3.7
___
Python tracker
<https://bugs.python.or
Berker Peksag added the comment:
Thanks for merging this, Petr. What do you think about backporting to 3.7?
--
components: -Documentation
versions: +Python 3.8
___
Python tracker
<https://bugs.python.org/issue26
Berker Peksag added the comment:
Ok, let's close this issue then.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.pyth
Berker Peksag added the comment:
New changeset 6f82bffd2df63a4072b3f0483cdbe93ddedb87e9 by Berker Peksag (Alexey
Izbyshev) in branch 'master':
bpo-34649: Add missing NULL checks to _encoded_const() (GH-9225)
https://github.com/python/cpython/commit/6f82bffd2df63a4072b3f0483cdbe9
Berker Peksag added the comment:
New changeset ec4d099b9f1951b08d1a53181c278173ff6a0cc1 by Berker Peksag (Miss
Islington (bot)) in branch '3.7':
bpo-34649: Add missing NULL checks to _encoded_const() (GH-9225)
https://github.com/python/cpython/commit/ec4d099b9f1951b08d1a53181c2781
Berker Peksag added the comment:
New changeset 6d726868cd1743623a28b8e048e31b9c3c52a399 by Berker Peksag (Miss
Islington (bot)) in branch '3.6':
bpo-34649: Add missing NULL checks to _encoded_const() (GH-9225)
https://github.com/python/cpython/commit/6d726868cd1743623a28b8e048e31b
Berker Peksag added the comment:
New changeset 669429fb583031c7c87392e30b065e99a2d8ccda by Berker Peksag (Miss
Islington (bot)) in branch '2.7':
bpo-34649: Add missing NULL checks to _encoded_const() (GH-9225)
https://github.com/python/cpython/commit/669429fb583031c7c87392e30b065e
Berker Peksag added the comment:
Thanks, Alexey!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
901 - 1000 of 3715 matches
Mail list logo
