[issue36329] use the right python "make -C Doc/ serve"

2019-05-01 Thread Berker Peksag
Berker Peksag added the comment: Yeah, we can add htmlview to devguide. I’ve even added it to Django after I discovered it in CPython :) -- --Berker -- ___ Python tracker <https://bugs.python.org/issue36

[issue27682] wsgiref BaseHandler / SimpleHandler can raise additional errors when handling an error

2019-05-01 Thread Berker Peksag
Berker Peksag added the comment: New changeset 3d37ea25dc97e4cb024045581979570835deb13c by Berker Peksag (Petter Strandmark) in branch 'master': bpo-27682: Handle client connection terminations in wsgiref (GH-9713) https://github.com/python/cpyt

[issue27682] wsgiref BaseHandler / SimpleHandler can raise additional errors when handling an error

2019-05-01 Thread Berker Peksag
Berker Peksag added the comment: New changeset 47ffc1a9f6fab1c17cdcc325d4af066317369ed7 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-27682: Handle client connection terminations in wsgiref (GH-9713) https://github.com/python/cpyt

[issue27682] wsgiref BaseHandler / SimpleHandler can raise additional errors when handling an error

2019-05-01 Thread Berker Peksag
Berker Peksag added the comment: Thank you! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5, Python 3.6 ___ Python tracker <https://bugs.python.or

[issue30271] Make sqlite3 statement cache optional

2019-05-08 Thread Berker Peksag
Berker Peksag added the comment: I'd prefer disabling statement cache implicitly when set_authorizer() is called. There's no need to expose this to end users. -- ___ Python tracker <https://bugs.python.o

[issue30271] Make sqlite3 statement cache optional

2019-05-09 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> rejected ___ Python tracker <https://bugs.python.org/issue30271> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue30262] Don't expose sqlite3 Cache and Statement

2019-05-09 Thread Berker Peksag
Berker Peksag added the comment: New changeset e6576248e5174ca5daa362cfd610c07e7eb3a2ae by Berker Peksag (Aviv Palivoda) in branch 'master': bpo-30262: Don't expose private objects in sqlite3 (GH-1440) https://github.com/python/cpython/commit/e6576248e5174ca5daa362cfd

[issue30262] Don't expose sqlite3 Cache and Statement

2019-05-09 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 -Python 3.7 ___ Python tracker <https://bugs.python.or

[issue36345] Deprecate Tools/scripts/serve.py in favour of python -m http.server -d

2019-05-10 Thread Berker Peksag
Berker Peksag added the comment: > I looked at other examples: they are nice but far from a "real application". You can use the same argument for pretty much every example in the stdlib documentation :) wsgiref is a low level module, users should use projects like WebOb inst

[issue35398] SQLite incorrect row count for UPDATE

2019-05-10 Thread Berker Peksag
Change by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <https://bugs.python.org/issue35398> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34916] Add create_window_function() to sqlite3.Connection

2019-05-11 Thread Berker Peksag
Berker Peksag added the comment: Issue 35360 will cover updating our Windows and macOS installers. I'm retargeting this issue to add a create_window_function() method to the Connection object. I already have a WIP branch and am going to submit a PR later this weekend. -- ass

[issue36865] FileInput does not allow 'rt' mode, but all its existing delegates do

2019-05-12 Thread Berker Peksag
Berker Peksag added the comment: Thank you for the report and the PR! I think accepting 'rt' mode is a good idea. However, it's a new feature and it can only go into 3.8. It seems to me that the root cause of the issue is that the fileinput module wasn't properly

[issue29344] sock_recv not detected a coroutine

2018-01-22 Thread Berker Peksag
Berker Peksag added the comment: Andrew, shouldn't we fix 3.6 documentation? sock_* methods still documented as coroutines. -- ___ Python tracker <https://bugs.python.org/is

[issue29344] sock_recv not detected a coroutine

2018-01-22 Thread Berker Peksag
Berker Peksag added the comment: > We only fixed it in 3.7 and the doc was updated. 3.6 stays as is. I'm not talking about fixing code in 3.6. In 3.6, sock_* methods still documented as coroutines but they are normal functions: * https://docs.python.org/3.6/library/asyncio-eventl

[issue29344] sock_recv not detected a coroutine

2018-01-22 Thread Berker Peksag
Berker Peksag added the comment: Well, the current status quo has already confused a user (see msg286011) > (so that people don't write code that expects them to be not coroutines in > 3.6) Even if people expect these methods to be coroutines, two functions of the asyncio

[issue32299] unittest.mock.patch.dict.__enter__ should return the dict

2018-01-23 Thread Berker Peksag
Change by Berker Peksag : -- nosy: +michael.foord, rbcollins versions: -Python 3.6, Python 3.8 ___ Python tracker <https://bugs.python.org/issue32299> ___ ___

[issue32664] Connector "|" missing between ImportError and LookupError

2018-01-25 Thread Berker Peksag
Change by Berker Peksag : -- keywords: +easy stage: -> needs patch versions: +Python 3.7 ___ Python tracker <https://bugs.python.org/issue32664> ___ ___ Py

[issue29248] os.readlink fails on Windows

2018-02-12 Thread Berker Peksag
Berker Peksag added the comment: New changeset 3c34aad4e7a95913ec7db8e5e948a8fc69047bf7 by Berker Peksag (SSE4) in branch 'master': bpo-29248: Fix os.readlink() on Windows (GH-5577) https://github.com/python/cpython/commit/3c34aad4e7a95913ec7db8e5e948a8

[issue29248] os.readlink fails on Windows

2018-02-12 Thread Berker Peksag
Change by Berker Peksag : -- versions: -Python 3.5 ___ Python tracker <https://bugs.python.org/issue29248> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29248] os.readlink fails on Windows

2018-02-12 Thread Berker Peksag
Berker Peksag added the comment: New changeset a1d33f742515dc70ae99bc3ea1c851729522afc3 by Berker Peksag (Miss Islington (bot)) in branch '3.6': bpo-29248: Fix os.readlink() on Windows (GH-5577) https://github.com/python/cpython/commit/a1d33f742515dc70ae99bc3ea1c851

[issue29248] os.readlink fails on Windows

2018-02-12 Thread Berker Peksag
Berker Peksag added the comment: Thank you, Craig and SSE4. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 ___ Python tracker <https://bugs.python.or

[issue32820] Add bits method to ipaddress

2018-02-13 Thread Berker Peksag
Berker Peksag added the comment: Eric, please delete the previous message when you reply by email. Keeping the previous message makes your comment harder to read. See https://bugs.python.org/issue32820#msg312050 on browser for example. -- nosy: +berker.peksag

[issue32820] Add bits method to ipaddress

2018-02-13 Thread Berker Peksag
Change by Berker Peksag : -- nosy: -berker.peksag ___ Python tracker <https://bugs.python.org/issue32820> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21196] Name mangling example in Python tutorial

2018-02-13 Thread Berker Peksag
Change by Berker Peksag : -- pull_requests: +5469 ___ Python tracker <https://bugs.python.org/issue21196> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27846] Base64 expansion factor is 4 to 3, not 6 to 4

2018-02-13 Thread Berker Peksag
Berker Peksag added the comment: New changeset 88c38a4049ded0e1f197fec3e76be7c0c0e83d7a by Berker Peksag (Zackery Spytz) in branch 'master': bpo-27846: Delete incorrect note in base64 docs (GH-5666) https://github.com/python/cpython/commit/88c38a4049ded0e1f197fec3e76be7

[issue27846] Base64 expansion factor is 4 to 3, not 6 to 4

2018-02-13 Thread Berker Peksag
Berker Peksag added the comment: New changeset 2e8d9003ed7a97955c36fa19a9ce7c43d9ec83e1 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-27846: Delete incorrect note in base64 docs (GH-5666) https://github.com/python/cpython/commit/2e8d9003ed7a97955c36fa19a9ce7c

[issue27846] Base64 expansion factor is 4 to 3, not 6 to 4

2018-02-13 Thread Berker Peksag
Berker Peksag added the comment: New changeset b93a52b136fd2285f2891eef91c50e3d36ea6f36 by Berker Peksag (Miss Islington (bot)) in branch '3.6': bpo-27846: Delete incorrect note in base64 docs (GH-5666) https://github.com/python/cpython/commit/b93a52b136fd2285f2891eef91c50e

[issue27846] Base64 expansion factor is 4 to 3, not 6 to 4

2018-02-13 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32732] LoggingAdapter ignores extra kwargs of Logger#log()

2018-02-28 Thread Berker Peksag
Change by Berker Peksag : -- nosy: +vinay.sajip ___ Python tracker <https://bugs.python.org/issue32732> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29623] configparser.ConfigParser.read() does not accept Pathlib path as a single argument.

2018-03-06 Thread Berker Peksag
Change by Berker Peksag : -- pull_requests: -594 ___ Python tracker <https://bugs.python.org/issue29623> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29623] configparser.ConfigParser.read() does not accept Pathlib path as a single argument.

2018-03-06 Thread Berker Peksag
Change by Berker Peksag : -- pull_requests: -966 ___ Python tracker <https://bugs.python.org/issue29623> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27645] Supporting native backup facility of SQLite

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: New changeset d7aed4102d2a40c74553240c7f03585624d27aea by Berker Peksag (Emanuele Gaifas) in branch 'master': bpo-27645: Add support for native backup facility of SQLite (GH-4238) https://github.com/python/cpyt

[issue27645] Supporting native backup facility of SQLite

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: New changeset e8a5a92037b1f27809806bb87c17976d2d48d3e9 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-27645: Add support for native backup facility of SQLite (GH-4238) https://github.com/python/cpyt

[issue27645] Supporting native backup facility of SQLite

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Lele. Note that Ned gave his permission to get this into 3.7.0b3 at https://github.com/python/cpython/pull/4238#issuecomment-371947334 We can, of course, still revert it before 3.7.0 final. -- resolution: -> fixed stage: patch rev

[issue27645] Supporting native backup facility of SQLite

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: >From http://buildbot.python.org/all/#/builders/13/builds/808 == FAIL: test_bad_target_in_transaction (sqlite3.test.backup.BackupTe

[issue27645] Supporting native backup facility of SQLite

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: >From test.pythoninfo: sqlite3.sqlite_version: 3.8.7.1 -- ___ Python tracker <https://bugs.python.org/issue27645> ___ ___ Py

[issue27645] Supporting native backup facility of SQLite

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: AppVeyor: sqlite3.sqlite_version: 3.21.0 (passed) Travis CI: sqlite3.sqlite_version: 3.8.2 (passed) http://buildbot.python.org/all/#/builders/88/builds/799 sqlite3.sqlite_version: 3.8.2 (passed) -- ___ Python

[issue27645] Supporting native backup facility of SQLite

2018-03-10 Thread Berker Peksag
Change by Berker Peksag : -- pull_requests: +5828 stage: resolved -> patch review ___ Python tracker <https://bugs.python.org/issue27645> ___ ___ Python-

[issue27645] Supporting native backup facility of SQLite

2018-03-10 Thread Berker Peksag
Change by Berker Peksag : -- stage: resolved -> patch review ___ Python tracker <https://bugs.python.org/issue27645> ___ ___ Python-bugs-list mailing list Un

[issue27645] Supporting native backup facility of SQLite

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: Test also passed on my MBP with SQLite 3.22.0 and the following line rc = _pysqlite_seterror(bck_conn, NULL); returns 1 (SQLITE_ERROR) with "SQL logic error" Looging at https://www.sqlite.org/src/artifact?ln=on&name=fa

[issue27645] Supporting native backup facility of SQLite

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: New changeset 7280a4eef5fbe17e8ac82afd71fe6e51843240a5 by Berker Peksag in branch 'master': bpo-27645: Skip test_bad_target_in_transaction if SQLite == 3.8.7.1 (GH-6067) https://github.com/python/cpython/commit/7280a4eef5fbe17e8ac82afd71fe6e

[issue27645] Supporting native backup facility of SQLite

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: New changeset c546a62c4d7b37ead10f986554a01d6d593227a1 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-27645: Skip test_bad_target_in_transaction if SQLite == 3.8.7.1 (GH-6067) https://github.com/python/cpyt

[issue33045] SSL Dcumentation Error

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: New changeset 9cf8c42f3231d3f066670d087a997bd1278482a0 by Berker Peksag (Matt Eaton) in branch 'master': bpo-33045: Fix typos in SSL documentation (GH-6065) https://github.com/python/cpython/commit/9cf8c42f3231d3f066670d087a997bd1278482a0 -

[issue33045] SSL Dcumentation Error

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: New changeset 17b6c19d39229619de649f5a9e28a46779ef1c51 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-33045: Fix typos in SSL documentation (GH-6065) https://github.com/python/cpython/commit/17b6c19d39229619de649f5a9e28a4

[issue33045] SSL Dcumentation Error

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: New changeset 3f439d14ad48f5d4f6017fc814326fb1f6237b53 by Berker Peksag (Miss Islington (bot)) in branch '3.6': bpo-33045: Fix typos in SSL documentation (GH-6065) https://github.com/python/cpython/commit/3f439d14ad48f5d4f6017fc814326f

[issue33045] SSL Dcumentation Error

2018-03-10 Thread Berker Peksag
Berker Peksag added the comment: Thank you, Matt (and welcome to Python development!) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: enhancement -> behavior ___ Python tracker <https://

[issue28788] ConfigParser should be able to write config to a given filename, not only into file object

2018-03-11 Thread Berker Peksag
Berker Peksag added the comment: I agree with Serhiy and Terry. Also, PR 5999 does not accept pathlib.Path() objects at the moment. This and Serhiy's following comment are good examples of why it shouldn't be added to the standard library in my opinion: > If combine ConfigParser

[issue28788] ConfigParser should be able to write config to a given filename, not only into file object

2018-03-11 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue27645] Supporting native backup facility of SQLite

2018-03-17 Thread Berker Peksag
Berker Peksag added the comment: FYI, I will have some time to debug the test failure this weekend. If I (or Lele or someone else) can't find the problem by Monday, I'm going to revert the patch from 3.7 branch (and probably from

[issue33086] pip: IndexError

2018-03-17 Thread Berker Peksag
Berker Peksag added the comment: The OP has also asked this on Stack Overflow: https://stackoverflow.com/questions/49329079/distutils-indexerror-tuple-index-out-of-range The problem was that they were passing a tuple to the url field. -- nosy: +berker.peksag resolution: -> not a

[issue27645] Supporting native backup facility of SQLite

2018-03-17 Thread Berker Peksag
Berker Peksag added the comment: New changeset bbf7bb7a636b3112ef6f6b31df385606d52517ce by Berker Peksag (Aviv Palivoda) in branch 'master': bpo-27645: Fix version number in 'database in transaction' fallback (GH-6131) https://github.com/p

[issue27645] Supporting native backup facility of SQLite

2018-03-17 Thread Berker Peksag
Berker Peksag added the comment: New changeset 429ca448d2a36040f229ad9edc67e31fc6d18bf4 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-27645: Fix version number in 'database in transaction' fallback (GH-6131) https://github.com/p

[issue27645] Supporting native backup facility of SQLite

2018-03-18 Thread Berker Peksag
Berker Peksag added the comment: Buildbots look happy, closing this one as 'fixed'. Thanks, Aviv! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs

[issue33034] urllib.parse.urlparse and urlsplit not raising ValueError for bad port

2018-03-19 Thread Berker Peksag
Berker Peksag added the comment: New changeset 2cb4661707818cfd92556e7fdf9068a993577002 by Berker Peksag (Matt Eaton) in branch 'master': bpo-33034: Improve exception message when cast fails for {Parse,Split}Result.port (GH-6078) https://github.com/python/cpyt

[issue33034] urllib.parse.urlparse and urlsplit not raising ValueError for bad port

2018-03-20 Thread Berker Peksag
Berker Peksag added the comment: The problem with adding a port_validation argument is that the port attribute is not the only thing that is computed lazily. There is also hostname, username, password attributes etc. I think the best way would be introducing a new API with more strict

[issue32287] Import of _pyio module failed on cygwin

2018-03-23 Thread Berker Peksag
Change by Berker Peksag : -- superseder: -> _pyio module broken on Cygwin / setmode not usable ___ Python tracker <https://bugs.python.org/issue32287> ___ _

[issue32358] json.dump: fp must be a text file object

2018-03-23 Thread Berker Peksag
Berker Peksag added the comment: This is already documented in the json.dump() documentation: The json module always produces str objects, not bytes objects. Therefore, fp.write() must support str input. Note that the traceback you've posted doesn't have anything to do wit

[issue32362] multiprocessing.connection.Connection misdocumented as multiprocessing.Connection

2018-03-23 Thread Berker Peksag
Change by Berker Peksag : -- keywords: +easy stage: -> needs patch type: -> behavior versions: -Python 3.4, Python 3.5 ___ Python tracker <https://bugs.python.org/i

[issue32798] mmap.flush() on Linux does not accept the "offset" and "size" args

2018-03-28 Thread Berker Peksag
Berker Peksag added the comment: By the way, there is a note in the "Change History" section of the msync() documentation at http://pubs.opengroup.org/onlinepubs/9699919799/ The second [EINVAL] error condition is made mandatory. The second EINVAL error condition they

[issue33287] "pip iinstall packageName.py" fails

2018-04-16 Thread Berker Peksag
Berker Peksag added the comment: There are two different problems here: 1. There is a possible networking issue. I'd try to use a proxy or something like that. 2. You are using a pip patched by Ubuntu/Debian developers. pip is normally a self-contained package and they use their own ve

[issue33295] ERROR: test_sites_no_connection_close (test.test_urllib2net.OtherNetworkTests)

2018-04-17 Thread Berker Peksag
Berker Peksag added the comment: I initially thought about using pythontest.net but I don't think it's possible to remove the Connection header at the nginx level: https://github.com/python/psf-salt/blob/master/salt/pythontest/config/nginx.pythontest.conf.jinja I think our only op

[issue991266] Cookie.py does not correctly quote Morsels

2018-04-19 Thread Berker Peksag
Berker Peksag added the comment: >>> from http.cookies import SimpleCookie >>> c = SimpleCookie() >>> c['name'] = 'value' >>> c['name']['comment'] = '\n' >>> c['name']['expires']

[issue991266] Cookie.py does not correctly quote Morsels

2018-04-20 Thread Berker Peksag
Change by Berker Peksag : -- pull_requests: +6251 ___ Python tracker <https://bugs.python.org/issue991266> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue991266] Cookie.py does not correctly quote Morsels

2018-04-22 Thread Berker Peksag
Berker Peksag added the comment: New changeset d5a2377c3d70e4143bcbee4a765b3434e21f683a by Berker Peksag in branch 'master': bpo-991266: Fix quoting of Comment attribute of SimpleCookie (GH-6555) https://github.com/python/cpython/commit/d5a2377c3d70e4143bcbee4a765b34

[issue991266] Cookie.py does not correctly quote Morsels

2018-04-22 Thread Berker Peksag
Berker Peksag added the comment: New changeset 9fc998d761591f2741d8e94f5b3009c56ae83882 by Berker Peksag (Miss Islington (bot)) in branch '3.7': bpo-991266: Fix quoting of Comment attribute of SimpleCookie (GH-6555) https://github.com/python/cpyt

[issue991266] Cookie.py does not correctly quote Morsels

2018-04-22 Thread Berker Peksag
Berker Peksag added the comment: New changeset 8a6f4b4bba950fb8eead1b176c58202d773f2f70 by Berker Peksag (Miss Islington (bot)) in branch '3.6': bpo-991266: Fix quoting of Comment attribute of SimpleCookie (GH-6555) https://github.com/python/cpyt

[issue33478] PEP 8 CapWords reference wrong?

2018-05-12 Thread Berker Peksag
Berker Peksag added the comment: 'CapWord' is a single word so string.capwords() works as documented: Split the argument into words using str.split(), capitalize each word using str.capitalize(), and join the capitalized words using str.join(). https://docs.python.org

[issue28167] remove platform.linux_distribution()

2018-05-15 Thread Berker Peksag
Berker Peksag added the comment: Adding Łukasz since he is the release manager of Python 3.8. -- components: +Library (Lib) nosy: +lukasz.langa type: -> enhancement versions: +Python 3.8 ___ Python tracker <https://bugs.python.org/issu

[issue32392] subprocess.run documentation does not have **kwargs

2018-05-16 Thread Berker Peksag
Berker Peksag added the comment: I agree with Xavier's comment, but I've bitten by this before so I think it would be better if we add more common arguments to the subprocess.run() signature. Adding **kwargs wouldn't be entirely correct since subprocess.run() doesn't pa

[issue32384] Generator tests is broken in non-CPython implementation

2018-05-16 Thread Berker Peksag
Change by Berker Peksag : -- versions: +Python 3.7, Python 3.8 ___ Python tracker <https://bugs.python.org/issue32384> ___ ___ Python-bugs-list mailing list Unsub

[issue32384] Generator tests is broken in non-CPython implementation

2018-05-16 Thread Berker Peksag
Berker Peksag added the comment: New changeset 4cc3eb48e1e8289df5153db1c701cae263a1ef86 by Berker Peksag (Isaiah Peng) in branch 'master': bpo-32384: Skip test when _testcapi isn't available (GH-4940) https://github.com/python/cpython/commit/4cc3eb48e1e8289df5153db1c

[issue33535] Consider quoting all values in Morsel objects

2018-05-16 Thread Berker Peksag
New submission from Berker Peksag : Continuing the discussion from bpo-991266. See msg315498 for Mark Williams' suggestion and https://github.com/python/cpython/pull/6555#discussion_r183176808 for another discussion between Alex and I on quoting all values unconditio

[issue991266] Cookie.py does not correctly quote Morsels

2018-05-16 Thread Berker Peksag
Berker Peksag added the comment: I've opened bpo-33535 to discuss Mark Williams' suggestion. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7 ___ Python tracker <h

[issue31661] Issues with request rate in robotparser

2017-10-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. Your analysis is correct and this is a duplicate of issue 31325. I'll take care of the PR 3259. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> req_rate is a namedtuple

[issue31736] PEP 485 tiny typo

2017-10-09 Thread Berker Peksag
Berker Peksag added the comment: Thank you for the report. Fixed in https://github.com/python/peps/commit/070dc7e037e5f66e4e17b661641503815a8bbe05 (By the way, you can report issues like this at https://github.com/python/peps/issues or send a PR directly.) -- nosy: +berker.peksag

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

2017-10-11 Thread Berker Peksag
Berker Peksag added the comment: New changeset 703ff381ffa946c23e7e25b0ae93a636a2607a40 by Berker Peksag (Cheryl Sabella) in branch 'master': bpo-28157: Improvements for the time module documentation (GH-928) https://github.com/python/cpython/commit/703ff381ffa946c23e7e25b0ae93a6

[issue28647] python --help: -u is misdocumented as binary mode

2017-10-11 Thread Berker Peksag
Change by Berker Peksag : -- pull_requests: +3929 ___ Python tracker <https://bugs.python.org/issue28647> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28647] python --help: -u is misdocumented as binary mode

2017-10-11 Thread Berker Peksag
Berker Peksag added the comment: Pull request for issue 30404 has been merged so we only need the documentation patch for the 3.6 branch (unfortunately 3.5 is now in security-fix-only mode) I've opened PR 3954. -- versions: -Python 3.5, Pytho

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

2017-10-11 Thread Berker Peksag
Berker Peksag added the comment: New changeset 764969a4b9ed7c6d2adbc04269f9b4fa392a1eed by Berker Peksag (Miss Islington (bot)) in branch '3.6': [3.6] bpo-28157: Improvements for the time module documentation (GH-928) https://github.com/python/cpyt

[issue28157] Document time module constants (timezone, tzname, etc.) as deprecated.

2017-10-11 Thread Berker Peksag
Berker Peksag added the comment: This issue can be closed now. Thank you, everyone! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <https://bugs.python

[issue28647] python --help: -u is misdocumented as binary mode

2017-10-11 Thread Berker Peksag
Berker Peksag added the comment: New changeset 5f908005ce16b06d5af7b413264009c4b062f33c by Berker Peksag in branch '3.6': bpo-28647: Update -u documentation (GH-3954) https://github.com/python/cpython/commit/5f908005ce16b06d5af7b413264009

[issue28647] python --help: -u is misdocumented as binary mode

2017-10-11 Thread Berker Peksag
Berker Peksag added the comment: Thank you for the patch, Gareth. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue23532] add example of 'first match wins' to regex "|" documentation?

2017-10-11 Thread Berker Peksag
Change by Berker Peksag : -- stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue23532> ___ ___ Python-bugs-list

[issue30767] logging must check exc_info correctly

2017-10-11 Thread Berker Peksag
Change by Berker Peksag : -- nosy: +vinay.sajip ___ Python tracker <https://bugs.python.org/issue30767> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue30404] Make stdout and stderr truly unbuffered when using -u option

2017-10-11 Thread Berker Peksag
Change by Berker Peksag : -- pull_requests: +3939 ___ Python tracker <https://bugs.python.org/issue30404> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28647] python --help: -u is misdocumented as binary mode

2017-10-11 Thread Berker Peksag
Change by Berker Peksag : -- pull_requests: +3938 stage: resolved -> patch review ___ Python tracker <https://bugs.python.org/issue28647> ___ ___ Python-

[issue28647] python --help: -u is misdocumented as binary mode

2017-10-11 Thread Berker Peksag
Berker Peksag added the comment: Good catch, I thought it was already fixed in master after bpo-30404. I've opened PR 3961. -- ___ Python tracker <https://bugs.python.org/is

[issue28647] python --help: -u is misdocumented as binary mode

2017-10-12 Thread Berker Peksag
Berker Peksag added the comment: I think it's better to be explicit and mention 'stdin' in this case. Plus, "stdin is always buffered" is quite short so potential of creating noise is quite minimal IMO. (FYI, I asked this question on GitHub: https://github.com

[issue28647] python --help: -u is misdocumented as binary mode

2017-10-12 Thread Berker Peksag
Berker Peksag added the comment: > -u doesn't affect stdin buffering, whatever that would mean. I think we need to document behavior of stdin somewhere, because current the sys.stdin documentation states: > When interactive, standard streams are line-buffered. Otherwise, they

[issue31567] Inconsistent documentation around decorators

2017-10-12 Thread Berker Peksag
Berker Peksag added the comment: Use of classmethod and staticmethod decorators as functions is still a valid use case. I think the old signatures should be kept. It should be possible to document both uses in same place: .. function:: classmethod(function) .. decorator:: classmethod

[issue31567] Inconsistent documentation around decorators

2017-10-12 Thread Berker Peksag
Berker Peksag added the comment: > That said, staticmethod as a non-decorator has an important use case for > function injection in tests (using self.func in TestCase classes that work > with > a C module and an equivalent Python version). Maybe this deserves an extra > exam

[issue30632] IDLE: add unittests to test_autocomplete

2017-10-12 Thread Berker Peksag
Change by Berker Peksag : -- superseder: -> IDLE: Add test_autocomplete unittest ___ Python tracker <https://bugs.python.org/issue30632> ___ ___ Python-

[issue28647] python --help: -u is misdocumented as binary mode

2017-10-13 Thread Berker Peksag
Berker Peksag added the comment: New changeset 7f580970836b0f6bc9c5db868d95bea81a3e1558 by Berker Peksag in branch 'master': bpo-28647: Update -u documentation after bpo-30404 (GH-3961) https://github.com/python/cpython/commit/7f580970836b0f6bc9c5db868d95be

[issue30404] Make stdout and stderr truly unbuffered when using -u option

2017-10-13 Thread Berker Peksag
Berker Peksag added the comment: New changeset 7f580970836b0f6bc9c5db868d95bea81a3e1558 by Berker Peksag in branch 'master': bpo-28647: Update -u documentation after bpo-30404 (GH-3961) https://github.com/python/cpython/commit/7f580970836b0f6bc9c5db868d95bea81a3e1558 -

[issue28647] python --help: -u is misdocumented as binary mode

2017-10-13 Thread Berker Peksag
Berker Peksag added the comment: Thank you for reviews, Serhiy and Victor. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue28647] python --help: -u is misdocumented as binary mode

2017-10-13 Thread Berker Peksag
Berker Peksag added the comment: Modules/main.c and Python.man is same in 3.6 branch. We could backport the change in Doc/library/sys.rst from 7f580970836b0f6bc9c5db868d95bea81a3e1558 but I didn't do it yet since it needs be manually backp

[issue31754] Documented type of parameter 'itemsize' to PyBuffer_FillContiguousStrides is incorrect.

2017-10-15 Thread Berker Peksag
Berker Peksag added the comment: New changeset 1b9e76ed3a055a53ca67397e928e1b408461900b by Berker Peksag (vyas45) in branch 'master': bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides (GH-3993) https://github.com/python/cpython/commit/1b9e76ed3a055a53ca67

[issue31754] Documented type of parameter 'itemsize' to PyBuffer_FillContiguousStrides is incorrect.

2017-10-15 Thread Berker Peksag
Change by Berker Peksag : -- type: -> behavior ___ Python tracker <https://bugs.python.org/issue31754> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue31754] Documented type of parameter 'itemsize' to PyBuffer_FillContiguousStrides is incorrect.

2017-10-15 Thread Berker Peksag
Berker Peksag added the comment: New changeset e881302b70ab36bafcf37e3917be118bbec97763 by Berker Peksag (Miss Islington (bot)) in branch '3.6': [3.6] bpo-31754: Fix type of 'itemsize' in PyBuffer_FillContiguousStrides (GH-3993) https://github.com/p

[issue31754] Documented type of parameter 'itemsize' to PyBuffer_FillContiguousStrides is incorrect.

2017-10-15 Thread Berker Peksag
Change by Berker Peksag : -- stage: patch review -> backport needed ___ Python tracker <https://bugs.python.org/issue31754> ___ ___ Python-bugs-list mai

<    1   2   3   4   5   6   7   8   9   10   >