[issue28624] Make the `cwd` argument to `subprocess.Popen` accept a `PathLike`

Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> needs patch ___ Python tracker <http://bugs.python.org/issue28624> ___ ___ Python-bugs-list mai

[issue6519] Reorder 'with' statement for files in Python Tutorial

Berker Peksag added the comment: The patch looks good to me. I think we can tweak the content a bit. I left some comments on Rietveld. Thanks! -- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.5, Python 3.6, Python 3.7 -Python 2.7, Python 3.2, Python

[issue6519] Reorder 'with' statement for files in Python Tutorial

Changes by Berker Peksag : -- versions: +Python 2.7 ___ Python tracker <http://bugs.python.org/issue6519> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8840] truncate() semantics changed in 3.1.2

Berker Peksag added the comment: The patch looks good to me, but perhaps we should make these docstrings shorter and refer people to the actual documentation for details? We recently did this in subprocess and venv modules. -- nosy: +berker.peksag, martin.panter stage: needs patch

[issue28623] Let `shlex.quote` accept a `PathLike` object

Berker Peksag added the comment: Agreed with David. Closing this as 'rejected'. Thanks for the report. -- nosy: +berker.peksag resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker <http://bugs

[issue28630] setup.py bdist_egg --without-source-files does not allow console_script to run as expected

Berker Peksag added the comment: console_script is a feature of setuptools. I'd suggest reporting this to https://github.com/pypa/setuptools We can reopen this if the problem is really in distutils. Thanks! -- nosy: +berker.peksag resolution: -> third party stage: -> reso

[issue25677] Syntax error caret confused by indentation

Berker Peksag added the comment: With patch applied: File "x.py", line 2 1 + 1 = 2 ^ SyntaxError: can't assign to operator Without patch: File "x.py", line 2 1 + 1 = 2 ^ SyntaxError: can't assign to operator The caret is located at th

[issue28088] Document Transport.set_protocol and get_protocol

Berker Peksag added the comment: I just removed self from method signatures (we don't usually include it) and updated the versionadded directives to 3.5.3 since it was also backported to 3.5 in f12a59311885. Please let me know if got the 3.5 version wrong, thanks! --

[issue28088] Document Transport.set_protocol and get_protocol

Changes by Berker Peksag : -- nosy: -larry priority: release blocker -> normal ___ Python tracker <http://bugs.python.org/issue28088> ___ ___ Python-bugs-lis

[issue28603] traceback module can't format/print unhashable exceptions

Berker Peksag added the comment: Thanks for the patch. Out of curiosity, how did you get an unhashable exception? Is there a way to reproduce this without creating a custom exception and set __hash__ to None? In other words, what's your use case? -- nosy: +berker.peksag

[issue28559] Unclear error message when raising wrong type of exceptions

Berker Peksag added the comment: Thanks for the patch, but I find your proposed message less clearer (including NoneType adds unnecessary confusion and people may ask "where did NoneType come from?") Python 2 is different because of historical reasons (pre-BaseException era) so I d

[issue21590] Systemtap and DTrace support

Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker <http://bugs.python.org/issue21590> ___ ___ Python-bugs-list mailing list Un

[issue24459] Mention PYTHONFAULTHANDLER in the man page

Berker Peksag added the comment: Thanks for the updated patch, Joshua. I will review and commit it this week. -- versions: +Python 3.7 ___ Python tracker <http://bugs.python.org/issue24

[issue28773] typing.FrozenSet missing in documentation.

Berker Peksag added the comment: Thanks for the patch, Manuel. Looks like FrozenSet is in PEP 484 and has been added to typing.__all__ in https://github.com/python/typing/pull/261 (already synced with the stdlib version of typing module) The patch looks good to me. Adding Guido to nosy list

[issue16026] csv.DictReader argument names documented incorrectly

Berker Peksag added the comment: James Salt's patch looks good to me, but it doesn't apply cleanly anymore. For the record, PyPy uses the same parameter name as Lib/csv.py: https://bitbucket.org/pypy/pypy/src/55a9404c80d6557854cac092addd92a6e0b683cc/lib-python/2.7/csv.py?at=default&

<    33   34   35   36   37   38