Changes by Berker Peksag :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28301>
___
___
Berker Peksag added the comment:
I found a similar problem in compile_dir() and fixed it in the commit.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Windows buildbots didn't like a6f0cc1820f4 :) Fix is incoming.
==
FAIL: test_compile_dir_pathlike (test.test_compileall.Compileall
Changes by Berker Peksag :
--
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue28319>
___
___
Python-bugs-list mailing list
Unsubscrib
Berker Peksag added the comment:
Thanks for the report!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.6
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
I agree with Martin. Closing this as 'out of date' for now, but we can reopen
if you could provide more information. Thanks!
--
resolution: -> out of date
stage: needs patch -> resolved
status: pending -> closed
Changes by Berker Peksag :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue28226>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue28227>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks for the review, Brett!
The next target is gzip module. Thanks for the all patches Ethan :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: enhancement -&
Changes by Berker Peksag :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> bz2 does not support pathlib
___
Python tracker
<http://bugs.python
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue28225>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks for the patch. I left some comments on Rietveld.
--
stage: test needed -> patch review
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
keywords: +easy -needs review
___
Python tracker
<http://bugs.python.org/issue9850>
___
___
Python-bugs-list mailing list
Unsub
Berker Peksag added the comment:
I can reproduce it with the following dependencies:
$ pip list
docutils (0.12)
pip (8.1.2)
setuptools (27.1.2)
The test was added in issue 23063. Since the purpose of the test was testing a
bug in _check_rst_data(), skipping it if pygments is
Berker Peksag added the comment:
Thanks for the patch, Dimitri. I think this is a reasonable improvement.
However, since we are changing the behavior of the netrc() class, I'm not sure
this can be considered as a bug fix.
In any case, 3.3 and 3.4 are in security-fix-only mode so I'
Berker Peksag added the comment:
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.6, Python 3.7 -Python 3.4
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
I've addressed all of Serhiy's review comments. Thanks!
--
Added file: http://bugs.python.org/file44926/issue28227_v2.diff
___
Python tracker
<http://bugs.python.o
Berker Peksag added the comment:
test_unpack_ex fails on several buildbots:
http://buildbot.python.org/all/builders/x86-64%20Ubuntu%2015.10%20Skylake%20CPU%203.6/builds/120/steps/test/logs/stdio
test test_unpack_ex failed
Berker Peksag added the comment:
You're right. I definitely missed that one. Here is an updated patch. Thanks
again!
--
Added file: http://bugs.python.org/file44927/issue28227_v3.diff
___
Python tracker
<http://bugs.python.org/is
Berker Peksag added the comment:
By the way, for some reason it doesn't show up at
https://bugs.python.org/review/28227/patch/18629/74286
--
___
Python tracker
<http://bugs.python.org/is
Berker Peksag added the comment:
Thanks Ethan and Serhiy.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Here's an updated patch.
--
Added file: http://bugs.python.org/file44937/issue28225_v2.diff
___
Python tracker
<http://bugs.python.org/is
Changes by Berker Peksag :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Berker Peksag:
Here's an updated patch that adds more tests and documentation changes.
--
components: +Library (Lib)
nosy: +berker.peksag
Added file: http://bugs.python.org/file44938/issue28229_v2.diff
___
Python tracker
Berker Peksag added the comment:
(As a result of the discussion at
http://psf.upfronthosting.co.za/roundup/meta/issue605, I started to re-triage
all easy issues.)
I don't think this is a suitable task for new contributors. It requires a) good
HTML and CSS knowledge b) familiarity with
Berker Peksag added the comment:
Thanks for the report. I think you need to run "make touch".
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.o
Berker Peksag added the comment:
Running
make distclean
make touch
should solve your problem. There isn't any significant change between 3.6.0b1
and 3.7.0a1 to cause build problems if I recall correctly.
--
___
Python tracker
Berker Peksag added the comment:
How did you get 3.7.0a1? I assumed you cloned it from hg.python.org. If you
clone it from the GitHub mirror, you can use the trick mentioned at
http://bugs.python.org/issue23404#msg275285
--
___
Python tracker
Changes by Berker Peksag :
--
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue28346>
___
___
Python-bugs-list mailing list
Unsubscrib
Berker Peksag added the comment:
Thanks for the new patch.
> I've uploaded the new patchset here.
We don't directly upload patches to Rietveld so you did the right thing :) See
https://docs.python.org/devguide/patch.html for details.
Can you also add a note about this new va
Berker Peksag added the comment:
Attaching a new patch that addresses Serhiy's comments. Thanks!
--
Added file: http://bugs.python.org/file44950/issue28229_v3.diff
___
Python tracker
<http://bugs.python.org/is
Changes by Berker Peksag :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue24065>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue2897>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
nosy: +steven.daprano
___
Python tracker
<http://bugs.python.org/issue28351>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
components: -asyncio
nosy: -goon369, gvanrossum, yselivanov
type: crash ->
versions: -Python 3.7
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
components: -Argument Clinic
nosy: -goon369, larry
resolution: -> not a bug
status: open -> closed
title: cakekup...@gmail.com -> Spam
type: behavior ->
versions: -Python 3.7
___
Python tr
Changes by Berker Peksag :
--
Removed message: http://bugs.python.org/msg278064
___
Python tracker
<http://bugs.python.org/issue28359>
___
___
Python-bugs-list m
Changes by Berker Peksag :
--
resolution: -> not a bug
status: open -> closed
title: Norton.Helpline +1-888-879-.0163 Norton Technical Support telePhone
number Norton phone Number -> Spam
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
components: -Argument Clinic
nosy: -goon369, larry
resolution: -> not a bug
status: open -> closed
title: **<<<<<<<1^888`879~O163>>>>>>>> Norton antivirus customer s
Changes by Berker Peksag :
--
Removed message: http://bugs.python.org/msg278065
___
Python tracker
<http://bugs.python.org/issue28360>
___
___
Python-bugs-list m
Changes by Berker Peksag :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
versions: +Python 3.6, Python 3.7
___
Python tracker
<http://bugs.python
Changes by Berker Peksag :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
It was rendered in a red box, because we were using an old Sphinx CSS file
(Doc/tools/static/basic.css) [1] We are using Sphinx defaults now and Python
specific tweaks are located at Doc/tools/pydoctheme/static/pydoctheme.css.
We usually prefer to use less
Berker Peksag added the comment:
Does Sphinx use a dummy HTML file like you did in the patch?
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue28
Berker Peksag added the comment:
I couldn't find any dummy HTML in the Sphinx codebase.
Wouldn't something like work without a dummy HTML?
from sphinx.locale import versionlabels, l_
versionlabels['cpythonimpldetail'] = l_('CPython implementation
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue28230>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
components: +Library (Lib)
nosy: +berker.peksag
versions: +Python 3.7
___
Python tracker
<http://bugs.python.org/issue28231>
___
___
Changes by Berker Peksag :
--
nosy: +berker.peksag
versions: +Python 3.6, Python 3.7 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue13631>
___
___
Berker Peksag added the comment:
This looks like a duplicate of issue 9066.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: needs patch -> resolved
status: open -> closed
superseder: -> Standard type codes for array.array, sa
Changes by Berker Peksag :
--
keywords: -easy
nosy: +davin
versions: +Python 3.7 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue12294>
___
___
Pytho
Berker Peksag added the comment:
Documentation changes look good to me. However, I'd prefer using
socket._GLOBAL_DEFAULT_TIMEOUT in the timeout parameter of FTP.connect().
--
keywords: +easy
nosy: +berker.peksag
versions: +Python 3.5, Python 3.6, Python 3.7 -Python 2.7, Pytho
Changes by Berker Peksag :
--
stage: test needed -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue12274>
___
___
Pyth
Berker Peksag added the comment:
Thanks for the patch, but the pickle CLI is not part of the public API and I
don't think these new options are going to be useful for general use.
Closing this as 'rejected'. Please re-open if Serhiy (or others) would find
this a reasona
Changes by Berker Peksag :
--
components: +Library (Lib)
___
Python tracker
<http://bugs.python.org/issue28230>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
type: -> behavior
versions: +Python 3.5, Python 3.6, Python 3.7
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
This has already been fixed in ea7b6a7827a4:
>>> import os
>>> os.fspath(None)
Traceback (most recent call last):
File "", line 1, in
TypeError: expected str, bytes or os.PathLike object, not NoneType
---
Berker Peksag added the comment:
It looks like the fspath protocol support has already been implemented in
b64f83d6ff24.
--
nosy: +berker.peksag
resolution: -> out of date
stage: -> resolved
status: open -> closed
type: -> enhancement
__
Berker Peksag added the comment:
Thanks for the report! How did you run the test? I think there is something
wrong with your installation (or you probably ran the test with the system
Python.)
$ ./python -m test.regrtest test_grammar
[1/1] test_grammar
1 test OK.
[48645 refs
Berker Peksag added the comment:
I think we can classify this one as a usability bug and improve the exception
message.
--
nosy: +ncoghlan
___
Python tracker
<http://bugs.python.org/issue21
Changes by Berker Peksag :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> struct.unpack('?', '\x02') returns (False,) on Mac OSX
___
Python tracker
&l
Berker Peksag added the comment:
Here's a patch to demonstrate what I meant in msg226047.
Example from the REPL:
>>> __import__('encodings', fromlist=[u'aliases'])
Traceback (most recent call last):
File "", line 1, in
TypeError: It
Berker Peksag added the comment:
Here's a patch. Changes in test_builtin might be redundant, but I added them
anyway.
--
keywords: +patch
nosy: +berker.peksag
stage: needs patch -> patch review
Added file: http://bugs.python.org/file45011/issue28
Berker Peksag added the comment:
Thanks for the report. Can you try the attached script?
--
nosy: +berker.peksag
Added file: http://bugs.python.org/file45014/proxy.py
___
Python tracker
<http://bugs.python.org/issue28
Berker Peksag added the comment:
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks. I guess your solution was similar to the attached patch?
--
keywords: +patch
stage: -> patch review
type: crash -> behavior
versions: +Python 3.6, Python 3.7 -Python 3.4
Added file: http://bugs.python.org/file45016/issue2838
Changes by Berker Peksag :
--
type: crash -> behavior
versions: +Python 3.6, Python 3.7 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue28389>
___
_
Changes by Berker Peksag :
--
stage: patch review -> resolved
versions: +Python 3.7
___
Python tracker
<http://bugs.python.org/issue26081>
___
___
Python-
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Berker Peksag:
Here's an updated patch with different tests and documentation changes. I
simplified Lib/tarfile.py a bit (see my review comments)
A slightly off-topic question: I had to update both docstrings and
documentation. Should we use this as an opportuni
Changes by Berker Peksag :
--
nosy: +vinay.sajip
___
Python tracker
<http://bugs.python.org/issue28404>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the patch! Do we still need to keep the last sentence? Is there any
other alternatives that can be used? Perhaps the word "spellings" can be
changed with "aliases" to make the sentence a little bit clearer.
--
nosy:
Berker Peksag added the comment:
Good catch, thanks Nick. Here's a Python 3 version of the patch. I excluded
Python/importlib.h from the patch to make review easier.
--
components: +Interpreter Core
versions: +Python 3.5, Python 3.6, Python 3.7
Added file: http://bugs.pytho
Berker Peksag added the comment:
> Should we file a separate issue regarding the similarly vague error message
> from hasattr() itself?
+1 from me. It would be good to show users a user friendly message :)
> BytesWarning: Comparison between bytes and string
How about raising a Typ
Changes by Berker Peksag :
--
resolution: -> third party
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue28421>
___
___
Python-bugs-
Berker Peksag added the comment:
Well, I find using a for loop is a bit verbose in this case :)
In Python 3.2:
>>> __import__('encodings', fromlist=[b'aliases'])
Traceback (most recent call last):
File "", line 1, in
TypeError: Item in ``from list'
Changes by Berker Peksag :
--
nosy: +jason.coombs
___
Python tracker
<http://bugs.python.org/issue28279>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks for the report. I'm marking this as an easy documentation issue.
BaseEventLoop is now AbstractEventLoop (87e3a58ed3c3) and the documentation of
AbstractEventLoop.create_unix_connection() can be found in
Doc/library/asyncio-eventloop.rst. Guido al
Berker Peksag added the comment:
It looks like this can also be fixed by issue 12486.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue23
Changes by Berker Peksag :
--
resolution: fixed -> out of date
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue28442>
___
___
Pyth
Changes by Berker Peksag :
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/issue28428>
___
___
Python-bugs-list mailing list
Unsubscrib
Berker Peksag added the comment:
Thanks.
--
nosy: +berker.peksag
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python
Berker Peksag added the comment:
Thanks for the reviews! I pushed the patch for 2.7.
Nick, what do you think about the case Serhiy mentioned in msg278515? Should we
fix it or is issue21720_python3.diff good to go?
--
___
Python tracker
<h
Berker Peksag added the comment:
Thanks! I removed the import statement and simplified the last sentence a bit.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.5, Python 3.6, Python 3.7 -P
Berker Peksag added the comment:
That's because the flush argument was added in Python 3.3 (after print() was
backported to 2.7 via a future import)
Thanks for the report.
--
nosy: +berker.peksag
resolution: -> not a bug
stage: -> resolved
status: ope
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python 3.7
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Thanks for the patch, Tim.
> Changed true -> :const:`True` in subprocess.rst.
This is out of scope for this issue and I actually prefer the current form.
Having method and class signatures in subprocess.__doc__ would make it less
maintainable. I&#x
Berker Peksag added the comment:
Moved to https://github.com/python/devguide/issues/70
--
nosy: +berker.peksag
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> out of date
stage: test needed -> resolved
___
Python tracker
<http://bugs.python.org/issue1520879>
___
___
Changes by Berker Peksag :
--
components: +Library (Lib)
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue28485>
___
___
Py
Berker Peksag added the comment:
This is a duplicate of issue 28393.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> Update encoding lookup docs wrt #27938
type: enhancement
Berker Peksag added the comment:
Thank you for the review, Andrew!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.7
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks. SilentGhost. I went with ".. highlight:: shell-session" to simplify the
patch a bit.
Łukasz, can we close this one and create new issues for further improvements
now?
--
___
Python trac
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue27860>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +ned.deily
___
Python tracker
<http://bugs.python.org/issue28555>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
It looks like this is now done in 0e69d97a408e (3.6) and be8b133d5d3e
(default). Please reopen if I'm missing something here.
--
nosy: +berker.peksag
resolution: -> fixed
stage: needs patch -> resolved
status: ope
Changes by Berker Peksag :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue28585>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
status: closed -> open
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue28615>
___
___
Python-bugs-list
Berker Peksag added the comment:
FWIW, I don't think the patch fixes the actual problem. With the patch applied,
the caret still placed at the wrong place. I'd prefer avoid pushing a patch
that fixes a bug by introducing another bug.
--
3601 - 3700 of 3715 matches
Mail list logo
