[issue27952] Finish converting fixcid.py from regex to re

2016-09-12 Thread Berker Peksag
Berker Peksag added the comment: Done. I'm going to pretend 2.7 doesn't exist :) -- nosy: +berker.peksag status: open -> closed ___ Python tracker <http://bugs.pytho

[issue28112] Add callback to functools.lru_cache

2016-09-12 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +ncoghlan, rhettinger stage: -> needs patch versions: -Python 3.3, Python 3.4, Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python.org/issu

[issue23102] distutils: isinstance checks fail with setuptools-monkeypatched Extension/Distribution

2016-09-12 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the updated patches. Since they both intend to fix the same problem, we can combine them in one patch file. -- stage: needs patch -> patch review ___ Python tracker <http://bugs.python.org/issu

[issue27322] test_compile_path fails when python has been installed

2016-09-12 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch that reuses the helper in CommandLineTests. -- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.5, Python 3.7 Added file: http://bugs.python.org/file44621/issue27322_v2.d

[issue28077] Fix find_empty_slot in dictobject

2016-09-13 Thread Berker Peksag
Berker Peksag added the comment: Victor committed the patch in msg276042 in 579141d6e353. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue28

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch with a test case. -- keywords: +patch nosy: +berker.peksag stage: -> patch review type: -> behavior Added file: http://bugs.python.org/file44647/issue28131.diff ___ Python tracker

[issue28131] assert statements missed when loaded by zipimporter

2016-09-13 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report and for the reviews! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue26171] heap overflow in zipimporter module

2016-09-13 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue28114] Crash in unicodeobject.c find_maxchar_surrogates on python-3.6.0b1 for Windows

2016-09-14 Thread Berker Peksag
Berker Peksag added the comment: Here's a patch for Unix. I will add Windows support when I get my Windows VM. > [...] (and add a test - test_crashers, presumably?) [...] Unfortunately, test_crashers doesn't run since 2011 (skipped in 481ad9129a0f.) parse_envlist() is only used

[issue28142] windows installer not adding PYTHONHOME

2016-09-14 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +steve.dower, zach.ware ___ Python tracker <http://bugs.python.org/issue28142> ___ ___ Python-bugs-list mailing list Unsub

[issue26830] Refactor Tools/scripts/google.py

2016-09-14 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 -Python 3.6 ___ Python tracker <http://bugs.python.or

[issue28147] Memory leak in new 3.6 dictionary resize

2016-09-14 Thread Berker Peksag
Berker Peksag added the comment: Can you wrap the test with @support.cpython_only decorator? The patch fixes the memory leak demonstrated in test-dict-pop.py. -- nosy: +berker.peksag, haypo, methane stage: -> patch review ___ Python tracker &l

[issue28151] testPythonOrg() of test_robotparser fails on validating python.org HTTPS certificate

2016-09-14 Thread Berker Peksag
Berker Peksag added the comment: Note that I'm planning to rewrite the test to use pythontest.net. -- nosy: +berker.peksag stage: -> needs patch type: -> enhancement versions: +Python 3.6 ___ Python tracker <http://bugs.python.

[issue28153] [Patch] selectmodule: Make kqueue()'s event filters optional

2016-09-14 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: +Python 3.7 ___ Python tracker <http://bugs.python

[issue28114] parse_envlist(): os.execve(), os.spawnve(), etc. crash in Python 3.6.0 when env contains byte strings

2016-09-14 Thread Berker Peksag
Berker Peksag added the comment: Eryk's patch looks good to me, thanks! I will wait for others to review the patch. -- ___ Python tracker <http://bugs.python.org/is

[issue28160] Python -V and --version output to stderr instead of stdout

2016-09-14 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. This was already done in Python 3.4. See https://docs.python.org/dev/whatsnew/3.4.html#changes-in-python-command-behavior and issue 18338 for details. Backporting this to 2.7 would break backwards compatibility so that means we can&#

[issue27973] urllib.urlretrieve() fails on second ftp transfer

2016-09-14 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue27973> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28167] remove platform.linux_distribution()

2016-09-15 Thread Berker Peksag
Berker Peksag added the comment: I think the current consensus is to keep old APIs around to make porting from Python 2 easier. That's why I opened issue 26041. See also msg256111 and "Deprecation policy PEP" proposed at https://mail.python.org/pipermail/python-committers/2016

[issue28156] [Patch] posixmodule: Make the presence of os.getpid() optional

2016-09-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker <http://bugs.python.or

[issue28114] parse_envlist(): os.execve(), os.spawnve(), etc. crash in Python 3.6.0 when env contains byte strings

2016-09-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Eryk! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

2016-09-15 Thread Berker Peksag
Changes by Berker Peksag : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue28176> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue28179] Segfault in test_recursionlimit_fatalerror

2016-09-16 Thread Berker Peksag
New submission from Berker Peksag: This is a follow-up from msg275748 in issue 27213 (Rework CALL_FUNCTION* opcodes). I believe the test_runpy failure I mentioned there is also the same error, but this one can be reproduced easily. test_recursionlimit_fatalerror in SysModuleTest (Lib/test

[issue28179] Segfault in test_recursionlimit_fatalerror

2016-09-16 Thread Berker Peksag
Changes by Berker Peksag : Added file: http://bugs.python.org/file44688/full_output.txt ___ Python tracker <http://bugs.python.org/issue28179> ___ ___ Python-bugs-list m

[issue25270] codecs.escape_encode systemerror on empty byte string

2016-09-16 Thread Berker Peksag
Berker Peksag added the comment: Here is an updated patch. -- versions: +Python 3.7 Added file: http://bugs.python.org/file44689/issue25270_v2.diff ___ Python tracker <http://bugs.python.org/issue25

[issue27415] regression: BaseEventLoop.create_server does not accept port=None

2016-09-16 Thread Berker Peksag
Berker Peksag added the comment: 3.4 is in security-fix-only mode so it doesn't get bugfix updates anymore. -- nosy: +berker.peksag resolution: -> out of date status: open -> closed versions: +Python 3.5 ___ Python tracker <http://b

[issue25270] codecs.escape_encode systemerror on empty byte string

2016-09-16 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the review, Serhiy. Here's an updated patch. -- Added file: http://bugs.python.org/file44691/issue25270_v3.diff ___ Python tracker <http://bugs.python.org/is

[issue25895] urllib.parse.urljoin does not handle WebSocket URLs

2016-09-16 Thread Berker Peksag
Berker Peksag added the comment: Thank you Gergely and Markus! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue25270] codecs.escape_encode systemerror on empty byte string

2016-09-16 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the reviews everyone! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue28151] testPythonOrg() of test_robotparser fails on validating python.org HTTPS certificate

2016-09-16 Thread Berker Peksag
Berker Peksag added the comment: Here's a patch that uses pythontest.net. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file44695/issue28151.diff ___ Python tracker <http://bugs.python.org

[issue28187] Check return value of _PyBytes_Resize

2016-09-17 Thread Berker Peksag
New submission from Berker Peksag: There are a couple of instances that don't check return value of _PyBytes_Resize in Modules/. I noticed this while working on issue 25270. Patch attached. -- components: Extension Modules files: pybytes_resize.diff keywords: patch messages: 2

[issue28187] Check return value of _PyBytes_Resize

2016-09-17 Thread Berker Peksag
Changes by Berker Peksag : Added file: http://bugs.python.org/file44711/pybytes_resize_regenerated.diff ___ Python tracker <http://bugs.python.org/issue28187> ___ ___

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

2016-09-17 Thread Berker Peksag
Berker Peksag added the comment: Would increasing timeout to 10.0 be sufficient? Should we wrap the test with @support.reap_threads? -- nosy: +berker.peksag status: pending -> open versions: +Python 3.5, Python 3.7 ___ Python tracker &l

[issue26149] Suggest PyCharm Community as an editor for Unix platforms

2016-09-17 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch. I left some comment on Rietveld: http://bugs.python.org/review/26149/#ps18589 -- stage: needs patch -> patch review versions: +Python 3.7 ___ Python tracker <http://bugs.python.org/issu

[issue28179] Segfault in test_recursionlimit_fatalerror

2016-09-17 Thread Berker Peksag
Berker Peksag added the comment: What do you mean by crash? I think the purpose of the test is to crash the interpreter: def test_recursionlimit_fatalerror(self): # A fatal error occurs if a second recursion limit is hit when recovering # from a first one

[issue28187] Check return value of _PyBytes_Resize

2016-09-17 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the review, Serhiy! Good point, closing this as 'not a bug'. -- resolution: -> not a bug stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs

[issue28075] os.stat fails when access is denied

2016-09-17 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Eryk. -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker <http://bugs.python.or

[issue21516] pathlib.Path(...).is_dir() crashes on some directories (Windows)

2016-09-17 Thread Berker Peksag
Berker Peksag added the comment: This is resolved by issue 28075. -- nosy: +berker.peksag resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue26384] UnboundLocalError in socket._sendfile_use_sendfile

2016-09-17 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Serhiy. Here's an updated patch. -- versions: +Python 3.7 Added file: http://bugs.python.org/file44720/issue26384_v2.diff ___ Python tracker <http://bugs.python.org/is

[issue26384] UnboundLocalError in socket._sendfile_use_sendfile

2016-09-17 Thread Berker Peksag
Changes by Berker Peksag : Added file: http://bugs.python.org/file44721/issue26384_v3.diff ___ Python tracker <http://bugs.python.org/issue26384> ___ ___ Python-bug

[issue26384] UnboundLocalError in socket._sendfile_use_sendfile

2016-09-17 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue16293] curses.ungetch raises OverflowError when given -1

2016-09-17 Thread Berker Peksag
Berker Peksag added the comment: This looks like a bug in ncurses 5.7 and a duplicate of issue 15037. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> curses.unget_wch and test_curses fail when linked with ncur

[issue28195] test_huntrleaks_fd_leak fails on Windows

2016-09-18 Thread Berker Peksag
New submission from Berker Peksag: >From >http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/11654/steps/test/logs/stdio == FAIL: test_huntrleaks_fd_leak (test.test_regrtest.ArgsTe

[issue28151] testPythonOrg() of test_robotparser fails on validating python.org HTTPS certificate

2016-09-18 Thread Berker Peksag
Berker Peksag added the comment: test_robotparser is now green. I've opened issue 28195 for test_huntrleaks_fd_leak. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http:

[issue28195] test_huntrleaks_fd_leak fails on Windows

2016-09-18 Thread Berker Peksag
Berker Peksag added the comment: It looks like http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/11581 is first time that the test was failed. Revisions (without documentation changes) in that build: * 378e000a68785fdb3d74b3a930bc4ac5f6a04ce5

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

2016-09-18 Thread Berker Peksag
Berker Peksag added the comment: For some reason, some tests fail randomly on FreeBSD buildbots. See also issue27784. I'm planning to apply the attached patch. -- keywords: +patch nosy: +koobs Added file: http://bugs.python.org/file44736/issue28176_skip_tests

[issue25400] robotparser doesn't return crawl delay for default entry

2016-09-18 Thread Berker Peksag
Berker Peksag added the comment: Here's an updated patch. -- versions: +Python 3.7 Added file: http://bugs.python.org/file44739/issue25400_v2.diff ___ Python tracker <http://bugs.python.org/is

[issue25400] robotparser doesn't return crawl delay for default entry

2016-09-18 Thread Berker Peksag
Changes by Berker Peksag : Added file: http://bugs.python.org/file44740/issue25400_v3.diff ___ Python tracker <http://bugs.python.org/issue25400> ___ ___ Python-bug

[issue25400] robotparser doesn't return crawl delay for default entry

2016-09-18 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue28203] complex() gives wrong error when the second argument has an invalid type

2016-09-19 Thread Berker Peksag
Berker Peksag added the comment: Please upload your patch from a Mercurial clone: * https://docs.python.org/devguide/setup.html#checkout * https://docs.python.org/devguide/patch.html Currently, if you pass a string as a second argument, you get: >>> complex(1, "1") Tracebac

[issue28198] heap-buffer-overflow in tok_nextc (Parser/tokenizer.c:954)

2016-09-19 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. This looks like a duplicate of issue 24022. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Python heap corruption issue __

[issue27482] heap-buffer-overflow on address 0x6250000078ff

2016-09-19 Thread Berker Peksag
Berker Peksag added the comment: I think the problem described in msg270181 is now fixed in issue 24022. Adding Benjamin to nosy list for the other case. -- nosy: +benjamin.peterson, berker.peksag ___ Python tracker <http://bugs.python.

[issue28204] Spam

2016-09-19 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: -SH4Y4N title: very useful information -> Spam ___ Python tracker <http://bugs.python.org/issue28204> ___ ___ Python-

[issue28195] test_huntrleaks_fd_leak fails on Windows

2016-09-19 Thread Berker Peksag
Berker Peksag added the comment: Thanks Victor! -- stage: needs patch -> resolved ___ Python tracker <http://bugs.python.org/issue28195> ___ ___ Python-bugs-lis

[issue26868] Document PyModule_AddObject's behavior on error

2016-09-19 Thread Berker Peksag
Berker Peksag added the comment: Serhiy, do you have further comments about issue26868_v2.diff? -- versions: +Python 3.7 ___ Python tracker <http://bugs.python.org/issue26

[issue28203] complex() gives wrong error when the second argument has an invalid type

2016-09-20 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch. We can't fix this in 3.4 because it's in security-fix-only mode: https://docs.python.org/devguide/index.html#status-of-python-branches -- versions: -Python 3.4 ___ Python trac

[issue28220] argparse's add_mutually_exclusive_group() should accept title and description

2016-09-20 Thread Berker Peksag
Berker Peksag added the comment: Unless I'm missing something, this is a duplicate of issue 17218 :) -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> support title and description in argparse add_mutuall

[issue25651] Confusing output for TestCase.subTest(0)

2016-09-21 Thread Berker Peksag
Berker Peksag added the comment: Fixed. I lost some time because of this today :) -- nosy: +berker.peksag resolution: -> fixed stage: test needed -> resolved status: open -> closed versions: +Python 3.7 -Python 3.4 ___ Python track

[issue28235] In xml.etree.ElementTree docs there is no parser argument in fromstring()

2016-09-21 Thread Berker Peksag
Berker Peksag added the comment: Instead of duplicating XML() documentation, I'd suggest changing fromstring() documentation to say something like "this is an alias for ElementTree.XML()." -- nosy: +berker.peksag versions: +Python

[issue28260] mock._Any and mock._Call implement __eq__ but not __hash__

2016-09-25 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue28260> ___ ___

[issue18893] invalid exception handling in Lib/ctypes/macholib/dyld.py

2016-09-26 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker <http://bugs.python.or

[issue10673] multiprocess.Process join method - timeout indistinguishable from success

2016-09-26 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Tom. -- components: -Library (Lib) resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker <http://bugs.python.or

[issue20100] epoll docs are not clear with regards to CLOEXEC.

2016-09-26 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue24098] Multiple use after frees in obj2ast_* methods

2016-09-26 Thread Berker Peksag
Berker Peksag added the comment: Please note that Python/Python-ast.c is automatically generated by Parser/asdl_c.py. -- nosy: +benjamin.peterson, berker.peksag ___ Python tracker <http://bugs.python.org/issue24

[issue21578] Misleading error message when ImportError called with invalid keyword args

2016-09-27 Thread Berker Peksag
Berker Peksag added the comment: Serhiy's patch looks good to me. It would be nice to add a test for multiple invalid keyword arguments: with self.assertRaisesRegex(TypeError, msg): ImportError('test', invalid='keyword', another=True) Using empty_tup

[issue28283] test_sock_connect_sock_write_race() of test.test_asyncio.test_selector_events fails randomly on FreeBSD

2016-09-27 Thread Berker Peksag
Berker Peksag added the comment: > If nobody fixes the unit test, I will revert the change. I attached a patch that skips the test in case of a timeout in issue 28176. Did you had a chance to take a look at it? -- nosy: +berker.peksag stage: -> needs patch type: -> behavior

[issue27873] multiprocessing.pool.Pool.map should take more than one iterable

2016-09-27 Thread Berker Peksag
Berker Peksag added the comment: I think we can add a note for starmap() in the following sentence: > [...] (it supports only one iterable argument though). (Quoted from https://docs.python.org/3/library/multiprocessing.html#multiprocessing.pool.Pool.map) Would you like to write a pa

[issue27777] cgi.FieldStorage can't parse simple body with Content-Length and no Content-Disposition

2016-09-27 Thread Berker Peksag
Berker Peksag added the comment: Thanks for triaging this, Bert. Would you like to propose a patch with a test case? Note that we can't fix this in 3.3 and 3.4 because they are in security-fix-only mode. See https://docs.python.org/devguide/index.html#status-of-python-branches for de

[issue27838] test_os.test_chown() random failure on "AMD64 FreeBSD CURRENT Debug 3.x" buildbot

2016-09-27 Thread Berker Peksag
Berker Peksag added the comment: Perhaps running a script like below on the host would help to identify the problem? import getpass import grp import pprint pprint.pprint(getpass.getuser()) pprint.pprint([(g.gr_gid, g.gr_name) for g in grp.getgrall()]) pprint.pprint([(g.gr_gid, g.gr_name

[issue28176] Fix callbacks race in asyncio.SelectorLoop.sock_connect

2016-09-27 Thread Berker Peksag
Berker Peksag added the comment: test_sock_connect_sock_write_race failure is being discussed in issue 28283. Closing this again. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue28283] test_sock_connect_sock_write_race() of test.test_asyncio.test_selector_events fails randomly on FreeBSD

2016-09-27 Thread Berker Peksag
Berker Peksag added the comment: Just saw http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.x%203.5/builds/1136/steps/test/logs/stdio and went ahead to remove the test. -- resolution: -> fixed stage: needs patch -> resolved status: open -&g

[issue27322] test_compile_path fails when python has been installed

2016-09-27 Thread Berker Peksag
Berker Peksag added the comment: Here's an updated patch. -- Added file: http://bugs.python.org/file44849/issue27322_v3.diff ___ Python tracker <http://bugs.python.org/is

[issue28288] Expose environment variable for Py_Py3kWarningFlag

2016-09-27 Thread Berker Peksag
Berker Peksag added the comment: +1 from me. This would help people to port their projects to Python 3. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue28

[issue11501] distutils.archive_util should handle absence of zlib module

2016-09-27 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: needs patch -> resolved status: pending -> closed ___ Python tracker <http://bugs.python.or

[issue27470] -3 commandline option documented differently via man

2016-09-27 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy nosy: +berker.peksag stage: -> needs patch type: -> behavior ___ Python tracker <http://bugs.python.org/i

[issue26869] unittest longMessage docs

2016-09-27 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag versions: +Python 3.7 ___ Python tracker <http://bugs.python.org/issue26869> ___ ___ Python-bugs-list mailin

[issue23155] unittest: object has no attribute '_removed_tests'

2016-09-27 Thread Berker Peksag
Berker Peksag added the comment: The culprit is the ``test_suite='nose.collector'`` line here. It looks like this has already been fixed in nose: https://github.com/nose-devs/nose/issues/759 -- nosy: +berker.peksag resolution: -> not a bug stage: -> resolved status

[issue27873] multiprocessing.pool.Pool.map should take more than one iterable

2016-09-27 Thread Berker Peksag
Berker Peksag added the comment: > What is the process? hg clone cpython, and make a patch from that and post it > here? Yes, it's exactly what you just described :) See https://docs.python.org/devguide/index.html for details. > Or is there some pull-request style process avail

[issue21903] ctypes documentation MessageBoxA example produces error

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report! I've now updated the example to use MessageBoxw. Eryk, do you find the second example (GetWindowRect) is useful? Can we make it more usable? Unless I'm missing something, we need to pass the return value of GetActiveWindow()

[issue28300] [PATCH] Fix misspelled "implemented" word

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: commit review -> resolved status: open -> closed versions: +Python 3.5 ___ Python tracker <http://bugs.python.or

[issue28303] [PATCH] Fix broken grammar in "pydoc3 unittest"

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: Good catch, thanks! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: +Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python

[issue27322] test_compile_path fails when python has been installed

2016-09-28 Thread Berker Peksag
Changes by Berker Peksag : -- versions: -Python 3.5 ___ Python tracker <http://bugs.python.org/issue27322> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23520] test_os failed (python-3.4.3, Linux SuSE)

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: This is a duplicate of issue 11341. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> test_os fails ___ Python tracker <http://bugs.python

[issue27565] Offer error context manager for code.interact

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: Hi Claudiu, thanks for the report, but I don't think this is a common use case that needs to be supported in the standard library. Other people may prefer to use different solutions in a similar case (e.g. using a debugger) Plus, it's not hard to

[issue12743] C API marshalling doc contains XXX

2016-09-28 Thread Berker Peksag
Changes by Berker Peksag : -- versions: +Python 3.7 Added file: http://bugs.python.org/file44871/issue12743_v2.diff ___ Python tracker <http://bugs.python.org/issue12

[issue27740] Fix doc of Py_CompileStringExFlags

2016-09-28 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker <http://bugs.python.or

[issue28304] Condition.wait() doesn't raise KeyboardInterrupt

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: Per Victor's comment in issue 8844 (http://bugs.python.org/issue8844#msg277640), I'm closing this as 'wont fix'. Thanks for the report! -- nosy: +berker.peksag resolution: -> wont fix stage: -> resol

[issue27322] test_compile_path fails when python has been installed

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: The buildbot is now green. Closing this as fixed. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue28306] incorrect output "int division or modulo by zero" in Handling Exceptions tutorial

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: Good catch! Thanks for the report. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.6, Python 3.7 ___ Python tracker <http://bugs.python.or

[issue20754] distutils should use SafeConfigParser

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, Alex. SafeConfigParser has been renamed to ConfigParser in Python 3.2 and distutils already uses ConfigParser in Python 3: >From Distribution.parse_config_files(): ... parser = ConfigParser() For 2.7, can you try it w

[issue22392] Clarify documentation of __getinitargs__

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: https://docs.python.org/2/library/pickle.html#object.__getinitargs__ states: "If it is desirable that the __init__() method be called on unpickling, an old-style class can define a method __getinitargs__(), which should return a tuple containing the argu

[issue22969] Compile fails with --without-signal-module

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, but --with(out)-signal-module option has been removed in d5bb5ad5a108. -- nosy: +berker.peksag resolution: -> out of date stage: -> resolved status: open -> closed ___ Python track

[issue23701] Drop extraneous comment from winreg.QueryValue's docstring

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report and for the patch, Claudiu. The part you mentioned has already been removed in 6e613ecd70f0. Here's the current version: "Values in the registry have name, type, and data components. This method retrieves the data for a key

[issue24274] erroneous comments in dictobject.c

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: Comments have been updated by the new dict implementation in 3.6+, but the 3.5 branch still needs to be updated. -- nosy: +berker.peksag, inada.naoki stage: -> needs patch type: enhancement -> behavior versions: +Pyth

[issue26224] Add "version added" for documentation of asyncio.timeout for documentation of python 3.4, 3.5, 3.6

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch. asyncio.timeout() has been removed in 73a28ad66bd9. -- nosy: +berker.peksag resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python track

[issue26224] Add "version added" for documentation of asyncio.timeout for documentation of python 3.4, 3.5, 3.6

2016-09-28 Thread Berker Peksag
Changes by Berker Peksag : -- type: -> behavior ___ Python tracker <http://bugs.python.org/issue26224> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue26550] documentation minor issue : "Step back: WSGI" section from "HOWTO Use Python in the web"

2016-09-28 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Alejandro. Doc/howto/webservers.rst has been removed in Python 3 so I just fixed 2.7. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: enhancement -> behavior versions: -Python 3.2

[issue28228] imghdr does not support pathlib

2016-09-29 Thread Berker Peksag
Berker Peksag added the comment: Here's a new patch that addresses Serhiy's comments. Let me know if you need a hand with review and commit these patches this weekend :) -- nosy: +berker.peksag Added file: http://bugs.python.org/file44884/issue282

[issue28226] compileall does not support pathlib

2016-09-29 Thread Berker Peksag
Berker Peksag added the comment: > Is there a fix for compileall missing from the patch? No, os.path.* functions have taken care of the conversion, but the output was in the following format: Compiling PosixPath('/tmp/tmp_nfh98lw/_test.py')... I fixed it, added a test

[issue28226] compileall does not support pathlib

2016-09-29 Thread Berker Peksag
Changes by Berker Peksag : Added file: http://bugs.python.org/file44887/issue28226_v3.diff ___ Python tracker <http://bugs.python.org/issue28226> ___ ___ Python-bug

[issue28277] ./Modules/_io/_iomodule.c build failure on AIX (beta1) while (a2) was fine.

2016-09-30 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

<    31   32   33   34   35   36   37   38   >