Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: test needed -> patch review
___
Python tracker
<http://bugs.python.org/issue1182143>
___
___
Python-
Changes by Berker Peksag :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue9517>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
Thanks for the report.
> Users should either be permitted to set debug on via an optional __init__
> parameter,
This is already possible via the debug attribute
(https://docs.python.org/3/library/shlex.html#shlex.shlex.debug), so I don't
think add
Changes by Berker Peksag :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue24113>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue2292>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
23796_fix_with_tests.patch LGTM. I'll apply it this weekend. Thanks for the
patch, John.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue23888>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
A minor comment about the __future__ changes: 3.5.0a1 should probably be
3.5.0b1.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue22
Berker Peksag added the comment:
In Lib/__future__.py:
+generator_stop = _Feature((3, 5, 0, "alpha", 1),
"alpha" needs to be changed to "beta".
--
stage: test needed -> commit review
___
Python tracker
&
Berker Peksag added the comment:
datetime.strptime is a classmethod, but the new date.strptime and time.strptime
methods are staticmethods. I think we should make the new methods classmethods
too.
--
stage: needs patch -> patch review
___
Pyt
Berker Peksag added the comment:
Buildbots are not happy:
[ 63/393] test_contextlib
Fatal Python error: Objects/frameobject.c:429 object at 0x200041abc28 has
negative ref count -2604246222170760230
Current thread 0x022c2500 (most recent call first):
File
"/mnt/9707/edelsohn/cp
Berker Peksag added the comment:
Thanks!
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue22906>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue22555>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
assignee: lemburg -> berker.peksag
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/
Berker Peksag added the comment:
Fixed. Thanks for the patch, John.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Éric, could you please take a look at issue19610_v4.diff? I'd like to commit
the patch this weekend. Thanks!
--
___
Python tracker
<http://bugs.python.org/is
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue22486>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue17849>
___
___
Python-
Changes by Berker Peksag :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.o
Berker Peksag added the comment:
Thanks for the patch, Vinod.
--
nosy: +berker.peksag
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: +Python 2.7, Python 3.4, Python 3.5
___
Python track
Changes by Berker Peksag :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue24065>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Berker Peksag :
--
stage: commit review -> resolved
___
Python tracker
<http://bugs.python.org/issue24064>
___
___
Python-bugs-list mailing list
Un
New submission from Berker Peksag:
It would be useful if we could change the logging format of assertLogs when we
use it:
with self.assertLogs('foo', level='INFO', format='%(message)s') as cm:
logging.getLogger('foo').info('first messa
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue17045>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue12816>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue24210>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
This is caused by issue 1322. I'll fix it.
--
assignee: -> berker.peksag
___
Python tracker
<http://bugs.python.org
Berker Peksag added the comment:
Since the patch has been reviewed by several core developers, I think you can
go ahead and commit it.
I'm +0 on the 2.7 version of the patch (the isinstance(e, types.ClassType) part
looks fine, but I haven't tested it). It's probably not
Berker Peksag added the comment:
Thanks Serhiy.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Interesting, I ran the test suite twice before commit the patch. I will take a
look, thanks!
--
___
Python tracker
<http://bugs.python.org/issue24
Berker Peksag added the comment:
Here is a patch.
An unrelated failure:
$ ./python -Werror -m test test_slice
[1/1] test_slice
test test_slice failed -- Traceback (most recent call last):
File "/home/berker/projects/cpython/default/Lib/test/test_slice.py", line 82,
in
Berker Peksag added the comment:
> But what to do with this code after 3.7? And why not to do this right now?
It's on my TODO list, but I'll probably won't have time to work on in it before
beta 1.
Thanks for the review!
--
resolution: -> fixed
stage: -&g
Berker Peksag added the comment:
Thanks for the report, Matthias.
> I can talk to Thomas Kluyver tomorrow about merging green tree snake into the
> devguide,
devguide isn't the correct place for such documentation.
> or maybe into ast docs. Would that be useful/more acceptabl
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue16544>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Just a suggestion: urlencode already has 5 parameters. We can make quote_via a
keyword-only parameter.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue13
Berker Peksag added the comment:
Thanks for the patch, Ville.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the patch, Ville.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Hi Yury,
Here is a post commit review. I've mostly removed some additional PEP 492
mentions and made a couple of trivial changes.
--
nosy: +berker.peksag
Added file: http://bugs.python.org/file39462/issue24180
Berker Peksag added the comment:
Another alternative is using assertWarnsRegex.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue24
Berker Peksag added the comment:
I'm not the ideal candidate to review the second patch since I'm not familiar
with the best practices of C :)
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.o
Berker Peksag added the comment:
Just a minor comment on the patch:
+warnings.warn("inspect.getargspec() is deprecated, "
+ "use inspect.signature() instead", DeprecationWarning)
Can you also add "stacklevel=2"?
-
Changes by Berker Peksag :
--
nosy: +berker.peksag
versions: -Python 3.5
___
Python tracker
<http://bugs.python.org/issue24209>
___
___
Python-bugs-list mailin
Berker Peksag added the comment:
I think we need to decide whether this is a documentation bug or a regression
in traceback module. See also issue 25573 for a similar report.
--
nosy: +berker.peksag, r.david.murray, rbcollins
stage: commit review -> patch rev
Berker Peksag added the comment:
> Do you mean in addition to the "Quick search" text that is already on the
> page or do you want to remove that?
The latter. All of the popular browsers (Chrome, Firefox, Edge and even Safari)
already support the placeholder attribute so I thi
Berker Peksag added the comment:
> I also found a regression in search.html.
Please ignore this. It doesn't have anything to do with your patch.
--
___
Python tracker
<http://bugs.python.org
Berker Peksag added the comment:
Thanks! The patch lacks a test case (you can add it into Lib/test/test_csv.py)
and a versionchanged notice in documentation (see
http://cpython-devguide.readthedocs.io/en/latest/documenting.html#paragraph-level-markup
for details.)
--
stage: needs
Changes by Berker Peksag :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue27866>
___
___
Python-bugs-list mailing list
Unsubscrib
Berker Peksag added the comment:
+1, thanks for working on this!
Two questions:
1. Should we check the system version of libffi and warn users (and probably
use the bundled version for now) if it was older than 3.1?
2. I know this isn't directly a user-facing feature, but should we
Berker Peksag added the comment:
Thanks for the patch, Alex!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
nosy: +lukasz.langa
___
Python tracker
<http://bugs.python.org/issue27984>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks for the report. This looks like a duplicate of issue 27629. Please
provide a reproducer if it's different problem than issue 27629.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> clo
Berker Peksag added the comment:
Did you look at the patch? It adds the following test case:
+s = socket.socket()
+sfd = s.fileno()
+# Create secure socket from fileno
+ss = ssl.SSLSocket(fileno=sfd)
+self.assertTrue(ss.fileno() == sfd)
Isn't that
Berker Peksag added the comment:
Great, closing this then.
> And the next release will include this patch?
Christian (one of our SSL module maintainers) just reviewed the patch so the
next step is to address his review comments and upload a new patch. If you
don't see any movem
Berker Peksag added the comment:
Here is an updated patch. I'd like to get this in before 3.6 beta 1.
--
Added file: http://bugs.python.org/file44437/issue10740_upstream_v2.diff
___
Python tracker
<http://bugs.python.org/is
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
type: -> behavior
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
I left some minor comments for Doc/whatsnew/3.6.rst on Rietveld.
In Lib/test/test_winconsoleio.py:
* self.assert_() (deprecated) can be replaced by self.assertTrue()
* We can add
if __name__ == '__main__':
unittest.main()
-
Changes by Berker Peksag :
--
nosy: -gukaar77
resolution: -> not a bug
stage: -> resolved
status: open -> closed
title: meditation -> Spam
___
Python tracker
<http://bugs.python
Changes by Berker Peksag :
--
Removed message: http://bugs.python.org/msg274956
___
Python tracker
<http://bugs.python.org/issue28012>
___
___
Python-bugs-list m
Changes by Berker Peksag :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue6766>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Berker Peksag :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue27877>
___
Berker Peksag added the comment:
Closing this as 'fixed'. Any further improvement can be discussed in separate
issues. Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Py
Berker Peksag added the comment:
Thanks for the patch, Claude.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> not a bug
stage: -> resolved
status: pending -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the patch, priyapappachan. Here is an updated patch. Since
EPOLL_CLOEXEC is the only value that can be passed to epoll_create1(), we can
also simplify the implementation a bit.
--
nosy: +berker.peksag
stage: needs patch -> patch rev
Berker Peksag added the comment:
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: enhancement -> behavior
versions: +Python 3.6 -Python 3.7
___
Python tracker
<http://bugs.python
New submission from Berker Peksag:
This looks like unused since years. Here's a patch that removes it.
--
components: Extension Modules
files: flush-statement-cache.diff
keywords: patch
messages: 275263
nosy: berker.peksag, ghaering
priority: normal
severity: normal
stage: patch r
New submission from Berker Peksag:
This is basically a backport of
https://github.com/ghaering/pysqlite/commit/9b79188edbc50faa24dc178afe24a10454f3fcad
except that Connection.in_transaction is exposed since Python 3.2.
--
components: Extension Modules
files: in_transaction.diff
Changes by Berker Peksag :
--
nosy: +haypo, methane
___
Python tracker
<http://bugs.python.org/issue28040>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue20885>
___
___
Python-bugs-list
Changes by Berker Peksag :
--
resolution: -> works for me
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
I'm getting segfaults with a77756e480c2 (thanks to 'hg bisect') on Ubuntu
12.04. I've checked buildbots, but they seem happy.
In test_sys:
test_recursionlimit_recovery (test.test_sys.SysModuleTest) ... Fatal Python
error: Segmentation
Berker Peksag added the comment:
> [...] please try a "make distclean" and make sure that all .pyc files are
> removed, and then recompile Python.
I forgot to mention that in my earlier comment. I usually run "make distclean"
before "./configure --with-pydebu
Berker Peksag added the comment:
Good catch, thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.5
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks, Serhiy.
test_recursionlimit_recovery in test_sys passed, but now I'm getting the
following failure:
FAIL: test_recursionlimit_fatalerror (test.test_sys.SysModuleTest)
I modified test_recursionlimit_fatalerror to use subTest() and it looks like
Berker Peksag added the comment:
>From
>http://buildbot.python.org/all/builders/s390x%20Debian%203.x/builds/1811/steps/compile/logs/stdio
> (I also saw the same compile error on another Linux boxes)
_freeze_importlib: Python/peephole.c:524: PyCode_Optimize: Assertion
`((codestr
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.5
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
I've now updated Lib/test/test_robotparser.py (issue 25497) Peter, do you have
time to update your patch? Thanks!
--
___
Python tracker
<http://bugs.python.org/is
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Here is an updated patch for Modules/selectmodule.c. It would be nice to get a
code review.
--
Added file: http://bugs.python.org/file44553/selectmodule.diff
___
Python tracker
<http://bugs.python.org/issue20
Changes by Berker Peksag :
--
nosy: +haypo
___
Python tracker
<http://bugs.python.org/issue28081>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
3.2 is now dead and it's probably not worth to backport tests to 2.7 in 2016 :)
Closing this as 'fixed'.
--
nosy: +berker.peksag
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: +Python 3.3
Berker Peksag added the comment:
Since PEP 442 has been implemented in 3.4 and e826940911c8 made Shelve.close()
more robust, I think this is no longer an issue.
--
nosy: +berker.peksag
resolution: -> out of date
stage: patch review -> resolved
status: open -&g
Changes by Berker Peksag :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Since we are going to move to GitHub, I think we can close this as 'wont fix'.
--
nosy: +berker.peksag
resolution: -> wont fix
stage: -> resolved
status: open -> closed
___
Python tracker
<
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Hi Tom, thanks for the patch! Issue 10673 is still open, is there a reason not
to attach your patch there?
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue28
Berker Peksag added the comment:
Thanks for the explanation. We usually handle situations like this in the same
issue so I'm closing this as a duplicate of issue 10673. Could you please
attach your patch to issue 10673? Thanks!
--
resolution: -> duplicate
stage: -> reso
Berker Peksag added the comment:
Tom's patch looks good to me. Davin, can you have a look at it?
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org
Berker Peksag added the comment:
Good catch, thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: enhancement -> behavior
versions: -Python 2.7, Python 3.3, Python 3.4, Python 3.7
___
Py
Berker Peksag added the comment:
This is a duplicate of issue 17232. Note that "This changes the filename
extension for compiled files from ``.pyc`` to ``.pyo``." part is no longer
true. See PEP 488 for details.
--
nosy: +berker.peksag
resolution: -> duplicate
stage:
Changes by Berker Peksag :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
The patch doesn't apply cleanly:
applying
http://bugs.python.org/file37554/distutils_accomodate_distribution_ducktypes.patch
patching file Lib/distutils/cmd.py
Hunk #1 FAILED at 51
1 out of 1 hunks FAILED -- saving rejects to file Lib/distutils/cmd.py.rej
Berker Peksag added the comment:
I think a Misc/NEWS entry is enough. We didn't use versionadded/versionchanged
directives for similar changes in the past (mimetypes.types_map for example)
Even if we decide to add an annotation it should be versionchanged, not
versionadded (the API is no
Berker Peksag added the comment:
Thanks for the patch, David!
--
components: +Interpreter Core
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
versions: +Python 3.5, Python 3.7
__
3401 - 3500 of 3715 matches
Mail list logo
