Berker Peksag added the comment:
Thanks for the report. This is a duplicate of issue 23487.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> argparse: add_subparsers 'action' broken
t
Changes by Berker Peksag :
--
nosy: +berker.peksag, spaceone
___
Python tracker
<http://bugs.python.org/issue23487>
___
___
Python-bugs-list mailing list
Unsub
Berker Peksag added the comment:
I think David's suggestion in msg239260 was good enough for now :) You'll need
to create a custom versionchanged directive to generate a valid and semantic
markup for the usage in http_cookies_morsel_deprecated_set_2.patch. I also left
a couple c
Changes by Berker Peksag :
--
nosy: +berker.peksag
versions: +Python 3.5 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue17305>
___
___
Python-bug
Berker Peksag added the comment:
LGTM. Added minor comments on Rietveld.
--
nosy: +berker.peksag
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
This looks like a duplicate of issue 21398. I can reproduce it with Python
3.4.1 (compiled myself) on Ubuntu 12.04.
>>> help(str)
Ctrl-C
:Traceback (most recent call last):
File "", line 1, in
File "/usr/local/lib/python3.4/_si
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> needs patch
type: -> enhancement
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
IMHO, it can stay as a historical document. We just need to add a note to point
out the correct documentation. So I think this can be handled on GitHub. I
can't update the content since I don't have edit rights, so please open a new
issue at https://
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue17909>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
resolution: -> not a bug
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue22500>
___
___
Python-bugs-list
Berker Peksag added the comment:
Thanks for the patch! I thought line 654-656 was already tested by
self.assertFailure('-L', 'en').
--
nosy: +berker.peksag, serhiy.storchaka
stage: -> patch review
versions: +Python 3.4
__
Changes by Berker Peksag :
--
components: -Tests
nosy: +berker.peksag
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issue19
Changes by Berker Peksag :
--
nosy: +berker.peksag, ghaering
stage: -> patch review
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue23810>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks for the patch, John.
> I'm under the impression that the final patch will need to include a test
> that confirms the patch worked,
Correct. You could convert the reproducers in msg239445 to a test case.
The patch looks good to me. I think
Berker Peksag added the comment:
> test_compileall
See issue 21264
I think this can be closed as a duplicate of issue 17750.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
UserDict_self_and_dict_keywords.patch looks good to me. Is there a reason not
to use assertWarnsRegex?
Also, there are already collections.UserDict() usages in the test file, so I'd
remove the "from collections import UserDict" import.
Berker Peksag added the comment:
Thanks for the report and the patch, Craig. Could you convert your reproducer
to a test case? imaplib tests are located in Lib/test/test_imaplib.py.
--
nosy: +berker.peksag
versions: +Python 3.5
___
Python tracker
Changes by Berker Peksag :
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> PyErr_Format in ctypes uses invalid parameter
type: crash -> behavior
___
Python tracker
<http
Changes by Berker Peksag :
--
nosy: +amaury.forgeotdarc, belopolsky, meador.inge
stage: -> patch review
type: crash -> behavior
versions: +Python 3.4, Python 3.5 -Python 3.6
___
Python tracker
<http://bugs.python.org/i
Changes by Berker Peksag :
--
nosy: +berker.peksag
type: behavior -> enhancement
___
Python tracker
<http://bugs.python.org/issue23484>
___
___
Python-bugs-lis
Changes by Berker Peksag :
--
resolution: -> duplicate
stage: -> resolved
superseder: -> argparse silently ignores arguments
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
doctype-remove.v3.patch LGTM.
--
nosy: +berker.peksag
stage: patch review -> commit review
versions: -Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
I use "enhancement" for non-trivial documentation patches.
Also, quoting from https://docs.python.org/devguide/triaging.html#type
"Also used for improvements in the documentation and test suite and for other
refactorings."
In this case
Berker Peksag added the comment:
Thanks for the patch, Bill. If you want to work on similar issues see also
issue 15948.
--
components: +Extension Modules -Interpreter Core
nosy: +berker.peksag, haypo, serhiy.storchaka
stage: -> patch review
versions: +Python
Changes by Berker Peksag :
--
dependencies: +Failure to check return value from lseek() in
Modules/mmapmodule.c
___
Python tracker
<http://bugs.python.org/issue15
Berker Peksag added the comment:
Here is a patch.
--
assignee: -> berker.peksag
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file38827/issue23027.diff
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
issue18383_remove_dups.patch looks good to me. A test would be nice.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue18
Changes by Berker Peksag :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue18553>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
stage: commit review -> resolved
versions: +Python 3.5 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue10838>
___
_
Berker Peksag added the comment:
Thanks for the review, Éric. New patch attached.
> When running a setup.py that uses a tuple for classifiers, is the error
> message in the terminal user-friendly, or do we get a full traceback?
A full traceback:
Traceback (most recent call last):
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue23883>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
keywords: +easy
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue23883>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
HTTPError.__str__ already provides useful information: ``'HTTP Error %s: %s' %
(self.code, self.msg)``, but since the change is minimal and useful, here is a
patch.
--
components: +Library (Lib)
keywords: +patch
nosy: +berker.peksag
stage:
Berker Peksag added the comment:
Removing issue 18383 from dependencies since the bug is also reproducible on
the 3.4 branch. This issue only applies to the default branch.
--
dependencies: -test_warnings modifies warnings.filters when running with "-W
default"
resolution:
Berker Peksag added the comment:
Fixed. Thank you all (and sorry for my late commit, Davin).
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> out of date
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue23807>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
I think makeopcodetargets.py should still be compatible with Python 2 (2.6 or
2.7 at least) since it uses the system Python.
I'd suggest closing this as "rejected" (or just commit the ``with open(...):``
part of the patch and update the o
Changes by Berker Peksag :
--
nosy: +yselivanov
___
Python tracker
<http://bugs.python.org/issue23898>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Fixed. Thanks for the patch, James.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.4, Python 3.5 -Python 3.6
___
Python tracker
<http://bug
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
type: -> enhancement
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Patch looks good to me. Thanks! :)
I left a couple of comments on Rietveld: http://bugs.python.org/review/23921/
We can probably ignore the following type of changes too:
- if pid == 0: # In a child process
+ if pid == 0: # In a child process
Berker Peksag added the comment:
Great patch. Thanks Martin.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks Maciej. I left a couple of comments on Rietveld:
http://bugs.python.org/review/16914/
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue16
Berker Peksag added the comment:
The new constant should probably be added to
https://docs.python.org/3/library/socket.html#constants (with a ..
versionadded:: 3.5 directive)
--
nosy: +berker.peksag
stage: -> commit review
___
Python trac
Berker Peksag added the comment:
Hi Lita, my review comments are at http://bugs.python.org/review/21815/ (sorry,
I forgot to add a comment here after I made the review)
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue21
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
type: performance -> enhancement
versions: +Python 3.5 -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Thanks for the patches, Ilia. The one for 2.7 looks good.
Reviewing 20362_py35.patch:
* Looks almost identical to issue20362.diff except style changes and the two
comments below, right?
* -self.assertIn("'kot'", e.args[0])
Berker Peksag added the comment:
Thanks for the patch, but I think the current link is correct. Contributors
will need to read the whole page anyway :)
If you want to mention
https://docs.python.org/devguide/setup.html#version-control-setup in index.rst,
I'd suggest something like thi
Berker Peksag added the comment:
* +.. method:: TarFile.extractall(path=".", members=None, numeric_owner=False)
numeric_owner can be a keyword-only argument.
* TarFile.extract and TarFile.extractall docs need a versionchanged directive.
* It would be nice to add an entry to Doc/wh
Berker Peksag added the comment:
Thanks Piotr.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.4
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue12652>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
I left a couple of comments of Rietveld.
--
nosy: +berker.peksag
stage: needs patch -> patch review
type: behavior -> enhancement
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Thank you Alex.
--
nosy: +berker.peksag
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the patch! I've reviewed it on Rietveld:
http://bugs.python.org/review/9859/
--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python 3.5 -Python 3.2
___
Python tracke
Berker Peksag added the comment:
I've added a couple of comments about the test:
http://bugs.python.org/review/9859/
--
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Thanks :)
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue9859>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
Some small comments:
* diff_bytes needs to be documented in the difflib docs and in
Doc/whatsnew/3.5.rst.
* diff_bytes needs to be added to difflib.__all__
* This looks like a new feature to me, so it would be better to just commit it
to the default branch
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue22278>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Alternatively, you can import public functions from support/script_helper.py in
support/__init__.py.
Then you can do
from test.support import assert_python_ok
--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python 3.5 -Pyt
Berker Peksag added the comment:
Reviewing iss9517_move_script_helpers_py.patch:
* Can you move script_helper.py by using "hg mv"?
--
___
Python tracker
<http://bugs.python.
New submission from Berker Peksag:
I was reading pty docs after watching a PyCon talk and the example in
https://docs.python.org/3/library/pty.html#example looked a bit outdated to me.
Here is a patch to update it.
Changes:
* Fixed a ResourceWarning warning
* Used argparse instead of getopt
Berker Peksag added the comment:
Thanks! The patch looks good to me. Some review comments:
http://bugs.python.org/review/22829/
--
components: +Library (Lib)
nosy: +berker.peksag
stage: -> patch review
type: -> enhancement
___
Python t
Berker Peksag added the comment:
Thanks, looks great. Two trivial comments about the documentation:
* Needs ``.. versionadded:: 3.5``
* *dfunc(a, b, fromfile, tofile, fromfiledate, tofiledate, n, lineterm)* ->
``dfunc(a, b, fromfile, tofile, fromfiledate, tofiledate, n, linet
Berker Peksag added the comment:
Thanks! The patch doesn't address msg182641 and I think this is a Sphinx bug(or
perhaps a feature request?). tocdepth should not change the heading numbers. I
couldn't find any similar report on the Sphinx issue tracker. So I suggest
opening an issue
Berker Peksag added the comment:
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
versions: -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Perhaps a NodeVisitor subclass (something like Armin Ronacher's codegen module
https://github.com/berkerpeksag/astor/blob/master/astor/codegen.py#L54 can be
added to the ast module.
--
nosy: +berker.p
Changes by Berker Peksag :
--
components: +Extension Modules, Interpreter Core
nosy: +berker.peksag
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue8
Berker Peksag added the comment:
That document is 10 years old :) I don't think it's worth to change now. Also,
"what's new" documents shouldn't be used as a tutorial. There are many
tutorials about writing decorators on the internet.
(Thanks for the
Changes by Berker Peksag :
--
nosy: +berker.peksag
resolution: fixed ->
___
Python tracker
<http://bugs.python.org/issue23994>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
stage: commit review -> resolved
___
Python tracker
<http://bugs.python.org/issue17445>
___
___
Python-bugs-list mailing list
Un
New submission from Berker Peksag:
urllib.urlretrieve is already documented at
https://docs.python.org/2.7/library/urllib.html#urllib.urlretrieve Can you
please give us more information about your problem with the urllib.urlretrieve
documentation?
--
nosy: +berker.peksag
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue24019>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks Claudiu.
--
nosy: +berker.peksag
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Here is a patch for Python 3.5.
--
components: +Interpreter Core -Documentation
keywords: +patch
nosy: +berker.peksag, serhiy.storchaka
type: -> behavior
versions: +Python 3.5 -Python 3.2, Python 3.3
Added file: http://bugs.python.org/file39
Berker Peksag added the comment:
issue 15657 is actually a duplicate of this issue, but since there's more
information there I'm closing this. Please take a look the patch at issue
15657. Thank you all!
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resol
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue15216>
___
___
Python-
Berker Peksag added the comment:
Thanks Isaac.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
I don't have a strong opinion on this, but here is a patch to make () = [] a
valid assignment.
--
keywords: +patch
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.5
Added file: http://bugs.python.org/file39165/issue23
Berker Peksag added the comment:
Just saw this on x86 Tiger 3.x:
==
FAIL: test_imap_unordered_handle_iterable_exception
(test.test_multiprocessing_fork.WithProcessesTestPool
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue23887>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
LGTM
--
nosy: +berker.peksag
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue24031>
___
_
Berker Peksag added the comment:
Thanks for the patch, Christie. Review comments:
http://bugs.python.org/review/9517/
> (still looks in the patch like the file was deleted and re-added, not sure if
> that's expected).
I don't know if it's important. I'm using a ver
Berker Peksag added the comment:
LGTM
--
assignee: docs@python -> berker.peksag
nosy: +berker.peksag
stage: -> commit review
type: performance -> enhancement
versions: +Python 3.5
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
stage: commit review -> resolved
___
Python tracker
<http://bugs.python.org/issue9951>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
stage: commit review -> resolved
___
Python tracker
<http://bugs.python.org/issue23342>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
Thanks py.user.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
keywords: +easy
stage: -> needs patch
title: document urllib.urlretrieve -> Add docstring to urllib.urlretrieve
type: -> enhancement
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bug
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue23852>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
Here is a patch. I'm not familiar with this part of the CPython source. So
please tell me if there is a better way to do it. I only updated
Doc/whatsnew/3.5, but other places in the documentation needs to be updated.
--
keywords: +patch
Berker Peksag added the comment:
Thanks for the patch, July.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: -Python 3.6
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue21354>
___
___
Python-bugs-list mailing list
Un
New submission from Berker Peksag:
Looks like READ_RESTRICTED, PY_WRITE_RESTRICTED and RESTRICTED flags were used
for "restricted mode" [1] in Python 2. "restricted mode" has been deprecated in
Python 2.3. Also, the current documentation is outdated. WRIT
Berker Peksag added the comment:
> 1. I find exit(EXIT_FAILURE) much clearer than exit(1).
import sys
exit(sys.EXIT_FAILURE)
or
import sys
sys.exit(sys.EXIT_FAILURE)
don't look too clear to me. On the other hand, these constants may helpful to
people who came from
Berker Peksag added the comment:
Here is a patch with a test.
--
components: +Interpreter Core
keywords: +patch
nosy: +berker.peksag
stage: needs patch -> patch review
Added file: http://bugs.python.org/file39224/issue24056.diff
___
Python trac
Changes by Berker Peksag :
--
nosy: +brett.cannon, eric.snow, ncoghlan
___
Python tracker
<http://bugs.python.org/issue24081>
___
___
Python-bugs-list mailin
3301 - 3400 of 3715 matches
Mail list logo