[issue23777] argparse subcommand action can't be specified

2015-03-25 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. This is a duplicate of issue 23487. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> argparse: add_subparsers 'action' broken t

[issue23487] argparse: add_subparsers 'action' broken

2015-03-25 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag, spaceone ___ Python tracker <http://bugs.python.org/issue23487> ___ ___ Python-bugs-list mailing list Unsub

[issue2211] Cookie.Morsel interface needs update

2015-03-25 Thread Berker Peksag
Berker Peksag added the comment: I think David's suggestion in msg239260 was good enough for now :) You'll need to create a custom versionchanged directive to generate a valid and semantic markup for the usage in http_cookies_morsel_deprecated_set_2.patch. I also left a couple c

[issue17305] IDNA2008 encoding missing

2015-03-25 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag versions: +Python 3.5 -Python 3.4 ___ Python tracker <http://bugs.python.org/issue17305> ___ ___ Python-bug

[issue23775] Fix pprint of OrderedDict

2015-03-25 Thread Berker Peksag
Berker Peksag added the comment: LGTM. Added minor comments on Rietveld. -- nosy: +berker.peksag stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issu

[issue23792] help crash leaves terminal in raw mode

2015-03-27 Thread Berker Peksag
Berker Peksag added the comment: This looks like a duplicate of issue 21398. I can reproduce it with Python 3.4.1 (compiled myself) on Ubuntu 12.04. >>> help(str) Ctrl-C :Traceback (most recent call last): File "", line 1, in File "/usr/local/lib/python3.4/_si

[issue23794] http package should support HTTP/2

2015-03-27 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> needs patch type: -> enhancement versions: +Python 3.6 ___ Python tracker <http://bugs.python.org/i

[issue23762] python.org page on new-style classes should be updated

2015-03-27 Thread Berker Peksag
Berker Peksag added the comment: IMHO, it can stay as a historical document. We just need to add a note to point out the correct documentation. So I think this can be handled on GitHub. I can't update the content since I don't have edit rights, so please open a new issue at https://

[issue17909] Autodetecting JSON encoding

2015-03-27 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue17909> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22500] Argparse always stores True for positional arguments

2015-03-29 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> not a bug stage: -> resolved ___ Python tracker <http://bugs.python.org/issue22500> ___ ___ Python-bugs-list

[issue23807] Improved test coverage for calendar.py command line

2015-03-29 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch! I thought line 654-656 was already tested by self.assertFailure('-L', 'en'). -- nosy: +berker.peksag, serhiy.storchaka stage: -> patch review versions: +Python 3.4 __

[issue19023] ctypes docs: Unimplemented and undocumented features

2015-03-29 Thread Berker Peksag
Changes by Berker Peksag : -- components: -Tests nosy: +berker.peksag versions: +Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/issue19

[issue23758] Improve documenation about num_params in sqlite3 create_function and create_aggregate

2015-03-29 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag, ghaering stage: -> patch review versions: +Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/issu

[issue23810] Suboptimal stacklevel of deprecation warnings for formatter and imp modules

2015-03-30 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue23810> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23796] BufferedReader.peek() crashes if closed

2015-03-30 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, John. > I'm under the impression that the final patch will need to include a test > that confirms the patch worked, Correct. You could convert the reproducers in msg239445 to a test case. The patch looks good to me. I think

[issue23774] Test failures when unable to write to install location

2015-03-30 Thread Berker Peksag
Berker Peksag added the comment: > test_compileall See issue 21264 I think this can be closed as a duplicate of issue 17750. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issu

[issue22609] Constructors of some mapping classes don't accept `self` keyword argument

2015-03-30 Thread Berker Peksag
Berker Peksag added the comment: UserDict_self_and_dict_keywords.patch looks good to me. Is there a reason not to use assertWarnsRegex? Also, there are already collections.UserDict() usages in the test file, so I'd remove the "from collections import UserDict" import.

[issue23779] imaplib authenticate raises TypeError if authenticator tries to abort

2015-03-30 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report and the patch, Craig. Could you convert your reproducer to a test case? imaplib tests are located in Lib/test/test_imaplib.py. -- nosy: +berker.peksag versions: +Python 3.5 ___ Python tracker

[issue23663] Crash on failure in ctypes on Cygwin

2015-03-30 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> duplicate stage: patch review -> resolved status: open -> closed superseder: -> PyErr_Format in ctypes uses invalid parameter type: crash -> behavior ___ Python tracker <http

[issue23338] PyErr_Format in ctypes uses invalid parameter

2015-03-30 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +amaury.forgeotdarc, belopolsky, meador.inge stage: -> patch review type: crash -> behavior versions: +Python 3.4, Python 3.5 -Python 3.6 ___ Python tracker <http://bugs.python.org/i

[issue23484] SemLock acquire() keyword arg 'blocking' is invalid

2015-03-30 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag type: behavior -> enhancement ___ Python tracker <http://bugs.python.org/issue23484> ___ ___ Python-bugs-lis

[issue23555] behavioural change in argparse set_defaults in python 2.7.9

2015-03-31 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> duplicate stage: -> resolved superseder: -> argparse silently ignores arguments ___ Python tracker <http://bugs.python.or

[issue19176] DeprecationWarning for doctype() method when subclassing _elementtree.XMLParser

2015-03-31 Thread Berker Peksag
Berker Peksag added the comment: doctype-remove.v3.patch LGTM. -- nosy: +berker.peksag stage: patch review -> commit review versions: -Python 3.4 ___ Python tracker <http://bugs.python.org/issu

[issue23484] SemLock acquire() keyword arg 'blocking' is invalid

2015-04-01 Thread Berker Peksag
Berker Peksag added the comment: I use "enhancement" for non-trivial documentation patches. Also, quoting from https://docs.python.org/devguide/triaging.html#type "Also used for improvements in the documentation and test suite and for other refactorings." In this case

[issue23860] Failure to check return value from lseek() in Modules/mmapmodule.c

2015-04-04 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Bill. If you want to work on similar issues see also issue 15948. -- components: +Extension Modules -Interpreter Core nosy: +berker.peksag, haypo, serhiy.storchaka stage: -> patch review versions: +Python

[issue15948] Unchecked return value of I/O functions

2015-04-04 Thread Berker Peksag
Changes by Berker Peksag : -- dependencies: +Failure to check return value from lseek() in Modules/mmapmodule.c ___ Python tracker <http://bugs.python.org/issue15

[issue23027] test_warnings fails with -Werror

2015-04-04 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch. -- assignee: -> berker.peksag keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file38827/issue23027.diff ___ Python tracker <http://bugs.python.org/i

[issue18383] test_warnings modifies warnings.filters when running with "-W default"

2015-04-04 Thread Berker Peksag
Berker Peksag added the comment: issue18383_remove_dups.patch looks good to me. A test would be nice. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue18

[issue18553] os.isatty() is not Unix only

2015-04-05 Thread Berker Peksag
Changes by Berker Peksag : -- stage: needs patch -> resolved ___ Python tracker <http://bugs.python.org/issue18553> ___ ___ Python-bugs-list mailing list Un

[issue10838] subprocess __all__ is incomplete

2015-04-07 Thread Berker Peksag
Changes by Berker Peksag : -- stage: commit review -> resolved versions: +Python 3.5 -Python 3.2 ___ Python tracker <http://bugs.python.org/issue10838> ___ _

[issue19610] Give clear error messages for invalid types used for setup.py params (e.g. tuple for classifiers)

2015-04-07 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the review, Éric. New patch attached. > When running a setup.py that uses a tuple for classifiers, is the error > message in the terminal user-friendly, or do we get a full traceback? A full traceback: Traceback (most recent call last):

[issue23883] __all__ lists are incomplete

2015-04-07 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue23883> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23883] __all__ lists are incomplete

2015-04-08 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch ___ Python tracker <http://bugs.python.org/issue23883> ___ ___ Python-bugs-list mai

[issue23887] HTTPError doesn't have a good "repr" representation

2015-04-08 Thread Berker Peksag
Berker Peksag added the comment: HTTPError.__str__ already provides useful information: ``'HTTP Error %s: %s' % (self.code, self.msg)``, but since the change is minimal and useful, here is a patch. -- components: +Library (Lib) keywords: +patch nosy: +berker.peksag stage:

[issue23027] test_warnings fails with -Werror

2015-04-08 Thread Berker Peksag
Berker Peksag added the comment: Removing issue 18383 from dependencies since the bug is also reproducible on the 3.4 branch. This issue only applies to the default branch. -- dependencies: -test_warnings modifies warnings.filters when running with "-W default" resolution:

[issue23400] Inconsistent behaviour of multiprocessing.Queue() if sem_open is not implemented

2015-04-08 Thread Berker Peksag
Berker Peksag added the comment: Fixed. Thank you all (and sorry for my late commit, Davin). -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue23021] Get rid of references to PyString in Modules/

2015-04-08 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue23807] Improved test coverage for calendar.py command line

2015-04-08 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker <http://bugs.python.org/issue23807> ___ ___ Python-bugs-list mailing list Un

[issue20021] "modernize" makeopcodetargets.py

2015-04-09 Thread Berker Peksag
Berker Peksag added the comment: I think makeopcodetargets.py should still be compatible with Python 2 (2.6 or 2.7 at least) since it uses the system Python. I'd suggest closing this as "rejected" (or just commit the ``with open(...):`` part of the patch and update the o

[issue23898] inspect() changes in Python3.4 are not compatible with objects that implement special __bool__, __eq__

2015-04-09 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +yselivanov ___ Python tracker <http://bugs.python.org/issue23898> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23912] Inconsistent whitespace/formatting in docs/reference/datamodel/Special Method Lookup

2015-04-11 Thread Berker Peksag
Berker Peksag added the comment: Fixed. Thanks for the patch, James. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.4, Python 3.5 -Python 3.6 ___ Python tracker <http://bug

[issue10289] Document magic methods called by built-in functions

2015-04-12 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review type: -> enhancement ___ Python tracker <http://bugs.python.org/i

[issue23921] Standardize documentation whitespace, formatting

2015-04-12 Thread Berker Peksag
Berker Peksag added the comment: Patch looks good to me. Thanks! :) I left a couple of comments on Rietveld: http://bugs.python.org/review/23921/ We can probably ignore the following type of changes too: - if pid == 0: # In a child process + if pid == 0: # In a child process

[issue12955] urllib.request example should use "with ... as:"

2015-04-12 Thread Berker Peksag
Berker Peksag added the comment: Great patch. Thanks Martin. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue16914] timestamping in smtplib.py to help troubleshoot server timeouts/delays

2015-04-13 Thread Berker Peksag
Berker Peksag added the comment: Thanks Maciej. I left a couple of comments on Rietveld: http://bugs.python.org/review/16914/ -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue16

[issue22631] Feature Request CAN_RAW_FD_FRAMES

2015-04-13 Thread Berker Peksag
Berker Peksag added the comment: The new constant should probably be added to https://docs.python.org/3/library/socket.html#constants (with a .. versionadded:: 3.5 directive) -- nosy: +berker.peksag stage: -> commit review ___ Python trac

[issue21815] imaplib truncates some untagged responses

2015-04-13 Thread Berker Peksag
Berker Peksag added the comment: Hi Lita, my review comments are at http://bugs.python.org/review/21815/ (sorry, I forgot to add a comment here after I made the review) -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue21

[issue10612] StopTestRun exception to halt test run

2015-04-13 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review type: performance -> enhancement versions: +Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.org/i

[issue20362] longMessage attribute is ignored in unittest.TestCase.assertRegexpMatches etc

2015-04-13 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patches, Ilia. The one for 2.7 looks good. Reviewing 20362_py35.patch: * Looks almost identical to issue20362.diff except style changes and the two comments below, right? * -self.assertIn("'kot'", e.args[0])

[issue23931] Update DevGuide link in Quickstart Step 1

2015-04-13 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, but I think the current link is correct. Contributors will need to read the whole page anyway :) If you want to mention https://docs.python.org/devguide/setup.html#version-control-setup in index.rst, I'd suggest something like thi

[issue23193] Please support "numeric_owner" in tarfile

2015-04-13 Thread Berker Peksag
Berker Peksag added the comment: * +.. method:: TarFile.extractall(path=".", members=None, numeric_owner=False) numeric_owner can be a keyword-only argument. * TarFile.extract and TarFile.extractall docs need a versionchanged directive. * It would be nice to add an entry to Doc/wh

[issue23943] Misspellings in a few files

2015-04-13 Thread Berker Peksag
Berker Peksag added the comment: Thanks Piotr. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.4 ___ Python tracker <http://bugs.python.or

[issue12652] Keep test.support docs out of the global docs index

2015-04-14 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker <http://bugs.python.org/issue12652> ___ ___ Python-bugs-list mailing list Un

[issue21271] reset_mock needs parameters to also reset return_value and side_effect

2015-04-14 Thread Berker Peksag
Berker Peksag added the comment: I left a couple of comments of Rietveld. -- nosy: +berker.peksag stage: needs patch -> patch review type: behavior -> enhancement ___ Python tracker <http://bugs.python.org/i

[issue23811] Python py_compile error message inconsistent and missing newline

2015-04-14 Thread Berker Peksag
Berker Peksag added the comment: Thank you Alex. -- nosy: +berker.peksag resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch! I've reviewed it on Rietveld: http://bugs.python.org/review/9859/ -- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.5 -Python 3.2 ___ Python tracke

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Berker Peksag
Berker Peksag added the comment: I've added a couple of comments about the test: http://bugs.python.org/review/9859/ -- ___ Python tracker <http://bugs.python.org/i

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Berker Peksag
Berker Peksag added the comment: Thanks :) -- stage: patch review -> resolved ___ Python tracker <http://bugs.python.org/issue9859> ___ ___ Python-bugs-list mai

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-15 Thread Berker Peksag
Berker Peksag added the comment: Some small comments: * diff_bytes needs to be documented in the difflib docs and in Doc/whatsnew/3.5.rst. * diff_bytes needs to be added to difflib.__all__ * This looks like a new feature to me, so it would be better to just commit it to the default branch

[issue22278] urljoin duplicate slashes

2015-04-15 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker <http://bugs.python.org/issue22278> ___ ___ Python-bugs-list mailing list Un

[issue23703] urljoin() with no directory segments duplicates filename

2015-04-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-16 Thread Berker Peksag
Berker Peksag added the comment: Alternatively, you can import public functions from support/script_helper.py in support/__init__.py. Then you can do from test.support import assert_python_ok -- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.5 -Pyt

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-16 Thread Berker Peksag
Berker Peksag added the comment: Reviewing iss9517_move_script_helpers_py.patch: * Can you move script_helper.py by using "hg mv"? -- ___ Python tracker <http://bugs.python.

[issue23983] Update example in the pty documentation

2015-04-16 Thread Berker Peksag
New submission from Berker Peksag: I was reading pty docs after watching a PyCon talk and the example in https://docs.python.org/3/library/pty.html#example looked a bit outdated to me. Here is a patch to update it. Changes: * Fixed a ResourceWarning warning * Used argparse instead of getopt

[issue22829] Add --prompt option to venv

2015-04-16 Thread Berker Peksag
Berker Peksag added the comment: Thanks! The patch looks good to me. Some review comments: http://bugs.python.org/review/22829/ -- components: +Library (Lib) nosy: +berker.peksag stage: -> patch review type: -> enhancement ___ Python t

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-16 Thread Berker Peksag
Berker Peksag added the comment: Thanks, looks great. Two trivial comments about the documentation: * Needs ``.. versionadded:: 3.5`` * *dfunc(a, b, fromfile, tofile, fromfiledate, tofiledate, n, lineterm)* -> ``dfunc(a, b, fromfile, tofile, fromfiledate, tofiledate, n, linet

[issue17227] devguide: buggy heading numbers

2015-04-18 Thread Berker Peksag
Berker Peksag added the comment: Thanks! The patch doesn't address msg182641 and I think this is a Sphinx bug(or perhaps a feature request?). tocdepth should not change the heading numbers. I couldn't find any similar report on the Sphinx issue tracker. So I suggest opening an issue

[issue15566] tarfile.TarInfo.frombuf documentation is out of date

2015-04-18 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: commit review -> resolved status: open -> closed versions: -Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.or

[issue24002] Add un-parse function to ast

2015-04-18 Thread Berker Peksag
Berker Peksag added the comment: Perhaps a NodeVisitor subclass (something like Armin Ronacher's codegen module https://github.com/berkerpeksag/astor/blob/master/astor/codegen.py#L54 can be added to the ast module. -- nosy: +berker.p

[issue8706] accept keyword arguments on most base type methods and builtins

2015-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- components: +Extension Modules, Interpreter Core nosy: +berker.peksag versions: +Python 3.5 -Python 3.3 ___ Python tracker <http://bugs.python.org/issue8

[issue24005] Documentation Error: Extra line Break

2015-04-19 Thread Berker Peksag
Berker Peksag added the comment: That document is 10 years old :) I don't think it's worth to change now. Also, "what's new" documents shouldn't be used as a tutorial. There are many tutorials about writing decorators on the internet. (Thanks for the

[issue23994] argparse fails to detect program name when there is a slash at the end of the program's path

2015-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag resolution: fixed -> ___ Python tracker <http://bugs.python.org/issue23994> ___ ___ Python-bugs-list mai

[issue17445] Handle bytes comparisons in difflib.Differ

2015-04-20 Thread Berker Peksag
Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker <http://bugs.python.org/issue17445> ___ ___ Python-bugs-list mailing list Un

[issue24021] document urllib.urlretrieve

2015-04-21 Thread Berker Peksag
New submission from Berker Peksag: urllib.urlretrieve is already documented at https://docs.python.org/2.7/library/urllib.html#urllib.urlretrieve Can you please give us more information about your problem with the urllib.urlretrieve documentation? -- nosy: +berker.peksag

[issue24019] str/unicode encoding kwarg causes exceptions

2015-04-21 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue24019> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16574] clarify policy on updates to final peps

2015-04-21 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue23917] please fall back to sequential compilation when concurrent doesn't exist

2015-04-21 Thread Berker Peksag
Berker Peksag added the comment: Thanks Claudiu. -- nosy: +berker.peksag resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue15657] Error in Python 3 docs for PyMethodDef

2015-04-22 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch for Python 3.5. -- components: +Interpreter Core -Documentation keywords: +patch nosy: +berker.peksag, serhiy.storchaka type: -> behavior versions: +Python 3.5 -Python 3.2, Python 3.3 Added file: http://bugs.python.org/file39

[issue11587] METH_KEYWORDS alone gives "METH_OLDARGS is no longer supported!"

2015-04-22 Thread Berker Peksag
Berker Peksag added the comment: issue 15657 is actually a duplicate of this issue, but since there's more information there I'm closing this. Please take a look the patch at issue 15657. Thank you all! -- nosy: +berker.peksag resolution: -> duplicate stage: -> resol

[issue15216] Support setting the encoding on a text stream after creation

2015-04-22 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review ___ Python tracker <http://bugs.python.org/issue15216> ___ ___ Python-

[issue21483] Skip os.utime() test on NFS?

2015-04-22 Thread Berker Peksag
Berker Peksag added the comment: Thanks Isaac. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue23275] Can assign [] = (), but not () = []

2015-04-22 Thread Berker Peksag
Berker Peksag added the comment: I don't have a strong opinion on this, but here is a patch to make () = [] a valid assignment. -- keywords: +patch nosy: +berker.peksag stage: -> patch review versions: +Python 3.5 Added file: http://bugs.python.org/file39165/issue23

[issue23713] intermittent failure of multiprocessing unit test test_imap_unordered_handle_iterable_exception

2015-04-22 Thread Berker Peksag
Berker Peksag added the comment: Just saw this on x86 Tiger 3.x: == FAIL: test_imap_unordered_handle_iterable_exception (test.test_multiprocessing_fork.WithProcessesTestPool

[issue23887] HTTPError doesn't have a good "repr" representation

2015-04-22 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker <http://bugs.python.org/issue23887> ___ ___ Python-bugs-list mailing list Un

[issue24031] Add git support to make patchcheck

2015-04-22 Thread Berker Peksag
Berker Peksag added the comment: LGTM -- nosy: +berker.peksag stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issue24031> ___ _

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-22 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Christie. Review comments: http://bugs.python.org/review/9517/ > (still looks in the patch like the file was deleted and re-added, not sure if > that's expected). I don't know if it's important. I'm using a ver

[issue23356] In argparse docs simplify example about argline

2015-04-24 Thread Berker Peksag
Berker Peksag added the comment: LGTM -- assignee: docs@python -> berker.peksag nosy: +berker.peksag stage: -> commit review type: performance -> enhancement versions: +Python 3.5 ___ Python tracker <http://bugs.python.or

[issue13567] HTTPError interface changes / breaks depending on what was passed to constructor

2015-04-25 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.org/issu

[issue9951] introduce bytes.hex method (also for bytearray and memoryview)

2015-04-26 Thread Berker Peksag
Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker <http://bugs.python.org/issue9951> ___ ___ Python-bugs-list mailing list Un

[issue23342] run() - unified high-level interface for subprocess

2015-04-26 Thread Berker Peksag
Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker <http://bugs.python.org/issue23342> ___ ___ Python-bugs-list mailing list Un

[issue23356] In argparse docs simplify example about argline

2015-04-26 Thread Berker Peksag
Berker Peksag added the comment: Thanks py.user. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue24021] Add docstring to urllib.urlretrieve

2015-04-26 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch title: document urllib.urlretrieve -> Add docstring to urllib.urlretrieve type: -> enhancement versions: +Python 3.4, Python 3.5 ___ Python tracker <http://bug

[issue23852] Wrong computation of max_fd on OpenBSD

2015-04-26 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker <http://bugs.python.org/issue23852> ___ ___ Python-bugs-list mailing list Un

[issue24064] Make the property doctstring writeable

2015-04-27 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch. I'm not familiar with this part of the CPython source. So please tell me if there is a better way to do it. I only updated Doc/whatsnew/3.5, but other places in the documentation needs to be updated. -- keywords: +patch

[issue24062] links to os.stat() in documentation lead to stat module instead

2015-04-27 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, July. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: -Python 3.6 ___ Python tracker <http://bugs.python.or

[issue21354] PyCFunction_New no longer exposed by python DLL breaking bdist_wininst installers

2015-04-27 Thread Berker Peksag
Changes by Berker Peksag : -- stage: needs patch -> resolved ___ Python tracker <http://bugs.python.org/issue21354> ___ ___ Python-bugs-list mailing list Un

[issue24065] Outdated *_RESTRICTED flags in structmember.h

2015-04-27 Thread Berker Peksag
New submission from Berker Peksag: Looks like READ_RESTRICTED, PY_WRITE_RESTRICTED and RESTRICTED flags were used for "restricted mode" [1] in Python 2. "restricted mode" has been deprecated in Python 2.3. Also, the current documentation is outdated. WRIT

[issue24053] Define EXIT_SUCCESS and EXIT_FAILURE constants in sys

2015-04-27 Thread Berker Peksag
Berker Peksag added the comment: > 1. I find exit(EXIT_FAILURE) much clearer than exit(1). import sys exit(sys.EXIT_FAILURE) or import sys sys.exit(sys.EXIT_FAILURE) don't look too clear to me. On the other hand, these constants may helpful to people who came from

[issue24056] Expose closure & generator status in function repr()

2015-04-28 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch with a test. -- components: +Interpreter Core keywords: +patch nosy: +berker.peksag stage: needs patch -> patch review Added file: http://bugs.python.org/file39224/issue24056.diff ___ Python trac

[issue24081] Obsolete caveat in reload() docs

2015-04-30 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +brett.cannon, eric.snow, ncoghlan ___ Python tracker <http://bugs.python.org/issue24081> ___ ___ Python-bugs-list mailin

<    29   30   31   32   33   34   35   36   37   38   >