[issue25077] Compiler warnings: initialization from incompatible pointer type

Berker Peksag added the comment: libffi warnings have already been fixed in upstream libffi. See issue 23085 for updating our libffi copy. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue25

[issue25413] ctypes (libffi) fails to compile on Solaris X86

Changes by Berker Peksag : -- nosy: +doko ___ Python tracker <http://bugs.python.org/issue25413> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18383] test_warnings modifies warnings.filters when running with "-W default"

Berker Peksag added the comment: LGTM -- stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issue18383> ___ ___ Python-bugs-lis

[issue27089] I think this is a small bug in urlparse.py

Berker Peksag added the comment: > 4. Personally, Given a wrong formated url, It is the responsibility of the > module to correct it ? It's not the responsibility of the library to correct (or make a guess on) user input. -- nosy: +berker.peksag resolution: -> n

[issue27104] enable-framework

Changes by Berker Peksag : -- resolution: rejected -> not a bug stage: -> resolved ___ Python tracker <http://bugs.python.org/issue27104> ___ ___ Pyth

[issue27032] Remove deprecated html.parser.HTMLParser.unescape()

Berker Peksag added the comment: It was removed before and added back with a deprecation warning (because someone was using it). A little bit off-topic, but it would be great to have a "deprecated APIs in Python 3" list somewhere in the Python documentation (

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Berker Peksag added the comment: This is a duplicate of issue 16509, but I'm going to keep this open since there is a patch attached here. -- nosy: +berker.peksag stage: -> needs patch versions: +Python 3.5 ___ Python tracke

[issue16509] sqlite3 docs do not explain check_same_thread

Berker Peksag added the comment: Issue 27113 has a patch and more detailed description so I'm going to close this one as a 'duplicate'. Thanks for the report! -- nosy: +berker.peksag resolution: -> duplicate stage: needs patch -> resolved status: open

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

Changes by Berker Peksag : -- stage: needs patch -> patch review ___ Python tracker <http://bugs.python.org/issue27113> ___ ___ Python-bugs-list mailing list Un

[issue27097] ceval: Wordcode follow up, explicit unsigned short read

Berker Peksag added the comment: Debug builds are broken after eda3716d6425: http://buildbot.python.org/all/builders/AMD64%20FreeBSD%209.x%203.x/builds/4332/steps/compile/logs/stdio -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.

[issue23498] Expose http.cookiejar.split_header_words()

Changes by Berker Peksag : -- nosy: +berker.peksag, orsenthil, r.david.murray ___ Python tracker <http://bugs.python.org/issue23498> ___ ___ Python-bugs-list m

[issue20482] smtplib.SMTP.sendmail: improve exception message

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue20482> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23511] Broken code example in email module documentation

Berker Peksag added the comment: LGTM. -- nosy: +berker.peksag, r.david.murray stage: -> commit review versions: +Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/issu

[issue23511] Broken code example in email module documentation

Berker Peksag added the comment: Thanks for the patch, Baptiste. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <http://bugs.python

[issue22435] socketserver.TCPSocket leaks socket to garbage collector if server_bind() fails

Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue23262] webbrowser module broken with Firefox 36+

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue23262> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23525] isbuiltin, isroutine, etc.

Changes by Berker Peksag : -- nosy: +yselivanov ___ Python tracker <http://bugs.python.org/issue23525> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23138] cookiejar parses cookie value as int with empty name-value pair and Expires

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue23138> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23304] Unused Superclass in calendar.py

Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker <http://bugs.python.org/issue23304> ___ ___ Python-bugs-list mailing list Un

[issue23062] test_argparse --version test cases

Berker Peksag added the comment: > Why the test class is moved? Just wanted to group all TestHelp* tests together. -- ___ Python tracker <http://bugs.python.org/issu

[issue23542] Update PEP 476 for using urllib2.build_opener()

Changes by Berker Peksag : -- nosy: +alex, christian.heimes, dstufft, giampaolo.rodola, janssen, pitrou ___ Python tracker <http://bugs.python.org/issue23

[issue23387] test_urllib2 fails with HTTP Error 502: Bad Gateway

Changes by Berker Peksag : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue20521] Cleanup for "dis" module documentation

Berker Peksag added the comment: Thanks for the patch, Sven. Most of the changes in your patch have already been fixed in issue 22845. Just committed the "``TOS`` -> TOS" part of the patch. -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> re

[issue23477] Increase coverage for wsgiref module

Berker Peksag added the comment: Thanks for the patch, Alex. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <http://bugs.python

[issue23527] test_smtpnet uses incorrect port for STARTTLS

Berker Peksag added the comment: Good catch. The test is skipped as "Resource 'smtp.gmail.com' is not available" on my machine. See https://support.google.com/mail/answer/13287 for reference. Thanks for the patch. -- nosy: +berker.peksag resolution: -> fi

[issue23004] mock_open() should allow reading binary data

Berker Peksag added the comment: LGTM. -- components: +Library (Lib) stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issu

[issue23504] Add __all__ into types

Berker Peksag added the comment: LGTM. -- nosy: +berker.peksag stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issue23504> ___ _

[issue22933] Misleading sentence in doc for shutil.move

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue22933> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23568] unittest.mock.MagicMock doesn't support __rdivmod__

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue23568> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23572] functools.singledispatch fails when "not BaseClass" is True

Changes by Berker Peksag : -- nosy: +lukasz.langa ___ Python tracker <http://bugs.python.org/issue23572> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23577] Add tests for wsgiref.validate

Changes by Berker Peksag : -- nosy: +berker.peksag, pje stage: -> patch review type: -> enhancement versions: +Python 3.4 ___ Python tracker <http://bugs.python.org/i

[issue20059] Inconsistent urlparse/urllib.parse handling of invalid port values?

Berker Peksag added the comment: > I think it is worth to be applied to maintained releases. I'd commit this only to the default branch. Changing the return value from None to an exception after three 3.4 bugfix releases(3.4.1, 3.4.2 and 3.4.3 -- also since 3.4.3 was released in

[issue23400] Inconsistent behaviour of multiprocessing.Queue() if sem_open is not implemented

Berker Peksag added the comment: LGTM -- stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issue23400> ___ ___ Python-bugs-lis

[issue23581] unittest.mock.MagicMock doesn't support matmul (@) operator

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue23581> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23582] multiprocessing.Queue.get is not getting all the items in the queue

Changes by Berker Peksag : -- nosy: +davin, sbt ___ Python tracker <http://bugs.python.org/issue23582> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19771] runpy should check ImportError.name before wrapping it

Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.5 -Python 3.3 ___ Python tracker <http://bugs.python.org/issu

[issue23596] gzip argparse interface

Berker Peksag added the comment: Thanks for the patch, but we need to add tests for the current CLI to make sure that we don't break anything when we apply gzip-argparse-cli.patch. See Lib/test/test_tarfile.py and Lib/test/test_calendar.py for example CLI tests. --

[issue21750] mock_open data is visible only once for the life of the class

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue21750> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23400] Inconsistent behaviour of multiprocessing.Queue() if sem_open is not implemented

Berker Peksag added the comment: > If not, I am tempted to bend on my instinctive reaction here and go with > Serhiy's style. +1 to Serhiy's suggestion. -- ___ Python tracker <http://bugs.py

[issue23432] Duplicate content in SystemExit documentation

Berker Peksag added the comment: Thank you for your suggestion, Martin. Here is an updated patch. -- Added file: http://bugs.python.org/file38365/systemexit_v2.diff ___ Python tracker <http://bugs.python.org/issue23

[issue19610] setup.py does not allow a tuple for classifiers

Berker Peksag added the comment: > Does current code work with None or empty tuple? Yes, it works with both None and (). -- ___ Python tracker <http://bugs.python.org/issu

[issue21793] httplib client/server status refactor

Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker <http://bugs.python.org/issue21793> ___ ___ Python-bugs-list mailing list Un

[issue23581] unittest.mock.MagicMock doesn't support matmul (@) operator

Berker Peksag added the comment: Looks good. I'll tweak the patch and commit it. Thanks Håkan. -- stage: -> patch review type: behavior -> enhancement ___ Python tracker <http://bugs.python.

[issue22227] Simplify tarfile iterator

Changes by Berker Peksag : -- stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issue7> ___ ___ Python-bugs-list mai

[issue23003] traceback.{print_exc, print_exception, format_exc, format_exception}: Potential AttributeError

Berker Peksag added the comment: This is no longer an issue after issue 17911. -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue18173] Add MixedTypeKey to reprlib

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue18173> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23491] PEP 441 - Improving Python Zip Application Support

Berker Peksag added the comment: I left a couple of minor comments on Rietveld. -- nosy: +berker.peksag stage: -> patch review ___ Python tracker <http://bugs.python.org/issu

[issue12916] Add inspect.splitdoc

Berker Peksag added the comment: pydoc doesn't have public API other than its CLI and the help() function. I'd cleanup or even rewrite pydoc before declare anything public in it. On the other hand, there are already functions related to splitdoc() in the inspect mod

[issue21610] load_module not closing opened files

Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review ___ Python tracker <http://bugs.python.org/issue21610> ___ ___ Python-bugs-list mai

[issue23432] Duplicate content in SystemExit documentation

Berker Peksag added the comment: Thanks for the review, Martin. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue23631] 3.5 (a2) traceback regression snarls Idle

Changes by Berker Peksag : -- nosy: +rbcollins ___ Python tracker <http://bugs.python.org/issue23631> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue2211] Cookie.Morsel interface needs update

Berker Peksag added the comment: Serhiy already reviewed the latest patch. Just one more comment: The deprecated API should be documented in Doc/whatsnew/3.5.rst and Doc/library/http.cookies.rst. -- ___ Python tracker <http://bugs.python.

[issue23526] Silence resource warnings in test_httplib

Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker <http://bugs.python.org/issue23526> ___ ___ Python-bugs-list mailing list Un

[issue23641] Got rid of bad dunder names

Berker Peksag added the comment: > Also added support for __matmul__ and __getnewargs_ex__ in unittest.mock [...] See issue 23581 for __matmul__ support. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issu

[issue23642] Interaction of ModuleSpec and C Extension Modules

Changes by Berker Peksag : -- nosy: +brett.cannon, eric.snow, ncoghlan ___ Python tracker <http://bugs.python.org/issue23642> ___ ___ Python-bugs-list mailin

[issue10967] move regrtest over to using more unittest infrastructure

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue10967> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue20617] test_ssl does not use mock

Berker Peksag added the comment: Thanks Xavier and Mark. -- components: +Tests -Library (Lib) nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.4 ___ Python tracker <http://bug

[issue23581] unittest.mock.MagicMock doesn't support matmul (@) operator

Berker Peksag added the comment: Thanks for the patch, Håkan. If you want to add tests for other magic methods, please open a new issue. Thanks for the report, Zygmunt. -- resolution: -> fixed stage: commit review -> resolved status: open -&g

[issue23651] Typo in argparse allow_abrev

Berker Peksag added the comment: Good catch, Nathan. Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue23641] Got rid of bad dunder names

Berker Peksag added the comment: > Do you want first commit the patch in issue23581 Berker? I just committed it. Thanks for the review :) -- ___ Python tracker <http://bugs.python.org/issu

[issue23654] infinite loop in faulthandler._stack_overflow

Changes by Berker Peksag : -- nosy: +haypo ___ Python tracker <http://bugs.python.org/issue23654> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22154] ZipFile.open context manager support

Berker Peksag added the comment: Thanks for the patch, Mike. -- nosy: +berker.peksag resolution: -> fixed stage: needs patch -> resolved status: open -> closed type: behavior -> enhancement versions: +Python 3.4 ___ Python tr

[issue17403] Robotparser fails to parse some robots.txt

Berker Peksag added the comment: Yes, this doesn't look like a security issue to me. Too late for 3.2. Closing this as "fixed". -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> close

[issue23081] Document PySequence_List(o) as equivalent to list(o)

Berker Peksag added the comment: Thanks for the report and the patch, Lars. -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.4 ___ Python tracker <http://bugs.python.or

[issue2052] Allow changing difflib._file_template character encoding.

Berker Peksag added the comment: Here is an updated patch. Thanks for the review, Serhiy. I will open a new issue for the HTML 5 part of the patch. -- Added file: http://bugs.python.org/file38474/issue2052_v2.diff ___ Python tracker <h

[issue9679] unicode DNS names in urllib, urlopen

Changes by Berker Peksag : -- nosy: +berker.peksag versions: +Python 3.5 -Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python.org/issue9679> ___ ___

[issue2052] Allow changing difflib._file_template character encoding.

Changes by Berker Peksag : Added file: http://bugs.python.org/file38483/issue2052_v3.diff ___ Python tracker <http://bugs.python.org/issue2052> ___ ___ Python-bugs-list m

[issue2052] Allow changing difflib._file_template character encoding.

Changes by Berker Peksag : Added file: http://bugs.python.org/file38484/issue2052_v4.diff ___ Python tracker <http://bugs.python.org/issue2052> ___ ___ Python-bugs-list m

[issue2052] Allow changing difflib._file_template character encoding.

Berker Peksag added the comment: Thanks Serhiy. -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.o

[issue23664] Modernize HTML output of difflib.HtmlDiff.make_file()

New submission from Berker Peksag: This is a split off from issue 2052. issue2052_html5_v2.diff (from issue 2052) needs to be updated. -- assignee: berker.peksag components: Library (Lib) messages: 238106 nosy: berker.peksag priority: normal severity: normal stage: needs patch status

[issue19541] ast.dump(indent=True) prettyprinting

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue19541> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23568] unittest.mock.MagicMock doesn't support __rdivmod__

Berker Peksag added the comment: Thanks to both of you for the report and the patch. -- resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.4, Python 3.5 -Python 3.3 ___ Python tracker <http://bug

[issue21112] 3.4 regression: unittest.expectedFailure no longer works on TestCase subclasses

Changes by Berker Peksag : -- assignee: -> berker.peksag ___ Python tracker <http://bugs.python.org/issue21112> ___ ___ Python-bugs-list mailing list Un

[issue23571] Raise SystemError if a function returns a result with an exception set

Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker <http://bugs.python.org/issue23571> ___ ___ Python-bugs-list mailing list Un

[issue23682] distutils docs still talk about compatibility with Python 2.2

Berker Peksag added the comment: I also removed it in my patch for issue 19610. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue23

[issue23682] distutils docs still talk about compatibility with Python 2.2

Changes by Berker Peksag : -- assignee: docs@python -> berker.peksag stage: -> commit review ___ Python tracker <http://bugs.python.org/issue23682> ___ ___

[issue23682] distutils docs still talk about compatibility with Python 2.2

Berker Peksag added the comment: Thanks Thomas! -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue23681] Have -b warn when directly comparing ints and bytes

Berker Peksag added the comment: > [...] fixes existing bugs in the stdlib and tests. These changes should probably be backported to 3.4. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issu

[issue23631] 3.5 (a2) traceback regression snarls Idle

Changes by Berker Peksag : -- stage: needs patch -> resolved ___ Python tracker <http://bugs.python.org/issue23631> ___ ___ Python-bugs-list mailing list Un

[issue23550] Add to unicodedata a function to query the "Quick_Check" property for a character

Changes by Berker Peksag : -- stage: -> patch review ___ Python tracker <http://bugs.python.org/issue23550> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue23550] Add to unicodedata a function to query the "Quick_Check" property for a character

Berker Peksag added the comment: Thanks for the patch, Hammerite. Did you see the review comments on Rietveld? -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue23

[issue23703] urljoin() with no directory segments duplicates filename

Changes by Berker Peksag : -- nosy: +orsenthil ___ Python tracker <http://bugs.python.org/issue23703> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22634] importing _ctypes failed: undefined symbol: ffi_call_win32

Changes by Berker Peksag : -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue22634> ___ ___

[issue12006] strptime should implement %G, %V and %u directives

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue12006> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23539] Content-length not set for HTTP methods expecting body when body is None

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue23539> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22831] Use "with" to avoid possible fd leaks

Berker Peksag added the comment: Looks good. A couple of comments: * Doc/includes/email-* changes have already been committed. * There is a commented-out line in Tools/scripts/nm2def.py: -f.close() +# f.close() * The patch is huge, I'd commit Tools/ and Lib/test/ parts separ

[issue22826] Support context management protocol in bkfile

Changes by Berker Peksag : -- assignee: -> serhiy.storchaka stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issue22826> ___ __

[issue23342] run() - unified high-level interface for subprocess

Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review ___ Python tracker <http://bugs.python.org/issue23342> ___ ___ Python-bugs-list mai

[issue22832] Tweak parameter names for fcntl module

Berker Peksag added the comment: > I object to dropping the brackets from the function signatures. Now it gives > the impression that the functions accept keyword arguments: See issue 21488 for a similar confusion. -- nosy: +berker.

[issue23571] Raise SystemError if a function returns a result with an exception set

Berker Peksag added the comment: Can we add a note (probably with an example) to the Porting to Python 3.5 section of https://docs.python.org/3.5/whatsnew/3.5.html#porting-to-python-3-5 I believe that this patch exposes some subtle bugs in Django (see https://gist.github.com/berkerpeksag

[issue23725] update tempfile docs to say that TemporaryFile is secure

Berker Peksag added the comment: Thanks for the patch, Zbyszek. For future reference, please send patches from the Mercurial repository. It will make the patch review process easier. See also devguide. +:func:`TemporaryDirectory`, :func:`SpooledTemporaryFile`, which can be Both

[issue23411] Update urllib.parse.__all__

Berker Peksag added the comment: *Result and *ResultBytes classes are documented at https://docs.python.org/3/library/urllib.parse.html#urllib.parse.DefragResult +1 for adding them to __all__. -- nosy: +berker.peksag ___ Python tracker <h

[issue23378] argparse.add_argument action parameter should allow value extend

Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> needs patch versions: -Python 3.4, Python 3.6 ___ Python tracker <http://bugs.python.org/issu

[issue19610] setup.py does not allow a tuple for classifiers

Berker Peksag added the comment: Here is a new patch. I didn't touched provides, requires and obsoletes fields since they are not used much in the setuptools era. Distribution.finalize_options() already converts string types to lists for platforms and keywords fields. I didn't ch

[issue22560] New SSL implementation based on ssl.MemoryBIO

Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker <http://bugs.python.org/issue22560> ___ ___ Python-bugs-list mailing list Un

[issue21511] Thinko in Lib/quopri.py, decoding b"==" to b"="

Changes by Berker Peksag : -- keywords: +easy ___ Python tracker <http://bugs.python.org/issue21511> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23703] urljoin() with no directory segments duplicates filename

Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue23703> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18828] urljoin behaves differently with custom and standard schemas

Berker Peksag added the comment: > Yet another option, similar to my “any_scheme=True” flag, might be to change > from the “uses_relative” white-list to a “not_relative” black-list of URL > schemes, [...] I think this looks like a good solution. -- versions: -P

[issue21717] Exclusive mode for ZipFile and TarFile

Berker Peksag added the comment: LGTM. I left two minor comments on Rietveld. Sorry for the delay. -- stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issu

[issue23776] Don't use assert for checking arguments in pprint

Berker Peksag added the comment: Looks good. Two things: * I'd apply this only to the default branch. Changing exceptions from AssertionError to ValueError in bugfix releases may break third party code. I couldn't find a similar bug report in the tracker, so it's probably not

<    28   29   30   31   32   33   34   35   36   37   >