[issue21069] test_fileno of test_urllibnet intermittently fails

2016-04-09 Thread Berker Peksag
Berker Peksag added the comment: I saw test_fileno failure again on the Gentoo buildbot: http://buildbot.python.org/all/builders/x86%20Gentoo%20Installed%20with%20X%203.x/builds/459/steps/test/logs/stdio rewrite-fileno.patch looks good to me. -- nosy: +berker.peksag stage: patch

[issue22659] SyntaxError in the configure_ctypes

2016-04-11 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. I think this is a problem in your dev environment (wrong path or something like that). For some reason, you are trying to run Python 3 setup.py in Python 2. -- nosy: +berker.peksag resolution: -> not a bug stage: -> re

[issue26737] csv.DictReader throws generic error when fieldnames is accessed for non-text file

2016-04-12 Thread Berker Peksag
Berker Peksag added the comment: > The scenario is a web application allowing people to upload csv files, but > they can upload any files they like. This looks like a potential security flaw in the application. The application should reject any non-CSV files from being uploaded (inst

[issue24136] document PEP 448: unpacking generalization

2016-04-12 Thread Berker Peksag
Berker Peksag added the comment: supriyanto maftuh,st, please don't play with tracker items. -- components: -Benchmarks, Build, IO, Unicode, Windows, XML, email versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker

[issue24136] document PEP 448: unpacking generalization

2016-04-12 Thread Berker Peksag
Changes by Berker Peksag : -- Removed message: http://bugs.python.org/msg263250 ___ Python tracker <http://bugs.python.org/issue24136> ___ ___ Python-bugs-list m

[issue24557] Refactor LibreSSL / EGD detection

2016-04-12 Thread Berker Peksag
Changes by Berker Peksag : -- components: -2to3 (2.x to 3.x conversion tool), Argument Clinic, Benchmarks, Build, Cross-Build, Demos and Tools, Devguide, Distutils, Documentation, Extension Modules, IDLE, IO, Installation, Interpreter Core, Macintosh, Regular Expressions, Tests

[issue19217] Calling assertEquals for moderately long list takes too long

2016-04-12 Thread Berker Peksag
Changes by Berker Peksag : -- components: -Build, Documentation, Unicode, Windows, XML nosy: -supriyanto maftuh, supriyantomaftuh versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.

[issue19217] Calling assertEquals for moderately long list takes too long

2016-04-12 Thread Berker Peksag
Changes by Berker Peksag : -- Removed message: http://bugs.python.org/msg263252 ___ Python tracker <http://bugs.python.org/issue19217> ___ ___ Python-bugs-list m

[issue26639] Tools/i18n/pygettext.py: replace deprecated imp module with importlib

2016-04-12 Thread Berker Peksag
Changes by Berker Peksag : -- components: -Benchmarks, Unicode stage: -> patch review type: compile error -> enhancement versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/i

[issue26639] Tools/i18n/pygettext.py: replace deprecated imp module with importlib

2016-04-12 Thread Berker Peksag
Berker Peksag added the comment: pygettext_imp.patch looks good to me. I left a comment on Rietveld. -- ___ Python tracker <http://bugs.python.org/issue26

[issue20767] Some python extensions can't be compiled with clang 3.4

2016-04-12 Thread Berker Peksag
Changes by Berker Peksag : -- components: -Build, Extension Modules, Interpreter Core, Tkinter, Unicode, Windows, XML stage: -> patch review versions: -Python 3.2, Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python.org/issu

[issue15984] Wrong documentation for PyUnicode_FromObject() and PyUnicode_FromEncodedObject()

2016-04-12 Thread Berker Peksag
Changes by Berker Peksag : -- components: -Build, Tests, Unicode, Windows, XML ___ Python tracker <http://bugs.python.org/issue15984> ___ ___ Python-bugs-list m

[issue26749] Update devguide to include Fedora's DNF

2016-04-14 Thread Berker Peksag
Berker Peksag added the comment: Committed in 0ed2497e5aa4. Thanks for the patch, Luiz. -- components: +Devguide -Documentation nosy: +berker.peksag, ezio.melotti, willingc resolution: -> fixed stage: -> resolved status: open -> closed _

[issue26755] Update version{added,changed} docs in devguide

2016-04-14 Thread Berker Peksag
New submission from Berker Peksag: This is a follow-up from issue 26366: "the original intention was to use "versionadded" where the API item is completely new. So "The parameter x was added" in a function is using "versionchanged" because only an asp

[issue26747] types.InstanceType only for old style class only in 2.7

2016-04-14 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue19444] mmap.mmap() allocates a file descriptor that isn't CLOEXEC

2016-04-15 Thread Berker Peksag
Changes by Berker Peksag : -- assignee: docs@python -> components: -Documentation versions: -Python 3.3 ___ Python tracker <http://bugs.python.org/issu

[issue26766] Redundant check in bytearray_mod

2016-04-15 Thread Berker Peksag
New submission from Berker Peksag: I noticed this while looking at issue 26764. bytearray_mod() and bytearray_format() both have checks for PyByteArray_Check(v). The check in bytearray_format() looks redundant to me. Here is a patch. -- components: Interpreter Core files

[issue26358] mmap.mmap.__iter__ is broken (yields bytes instead of ints)

2016-04-15 Thread Berker Peksag
Berker Peksag added the comment: I don't think we can change this in 3.5 since it would break backward compatibility. > Similarly the `in` operator seems to be broken; one could search for space > using `32 in bytesobj`, which would work for slices but not for the whole > mmap

[issue26766] Redundant check in bytearray_mod

2016-04-15 Thread Berker Peksag
Berker Peksag added the comment: Do you have an example code? It returns bytearray for me in both 3.5 and 3.6. use_bytearray parameter of _PyBytes_FormatEx() is 1 in bytearray_mod(). -- ___ Python tracker <http://bugs.python.org/issue26

[issue26768] Fix instructions at WindowsCompilers for MSVC/SDKs

2016-04-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the detailed report and for the patch, Ivan. But since https://wiki.python.org/moin/WindowsCompilers is a wiki document, you can edit it yourself. Please send an email to pydotorg-...@python.org with your account name. See https://wiki.python.org

[issue26766] Redundant check in bytearray_mod

2016-04-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks! More examples: Python 3.6: >>> bytearray(b'hello %b') % b"world" bytearray(b'hello world') >>> bytearray(b'hello %b') % b"wor" b'hello wor' Python 3.5: >>> bytearr

[issue4709] Mingw-w64 and python on windows x64

2016-04-15 Thread Berker Peksag
Changes by Berker Peksag : -- Removed message: http://bugs.python.org/msg263480 ___ Python tracker <http://bugs.python.org/issue4709> ___ ___ Python-bugs-list m

[issue4709] Mingw-w64 and python on windows x64

2016-04-15 Thread Berker Peksag
Changes by Berker Peksag : -- Removed message: http://bugs.python.org/msg263481 ___ Python tracker <http://bugs.python.org/issue4709> ___ ___ Python-bugs-list m

[issue26763] Update PEP-8 regarding binary operators

2016-04-15 Thread Berker Peksag
Berker Peksag added the comment: Please don't create a pull request on GitHub (python/peps is read-only). Attaching wrap-before-binary-operator.patch is enough. -- nosy: +berker.peksag stage: -> patch review ___ Python tracke

[issue26766] The result type of bytearray formatting is not stable

2016-04-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the reviews! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue24922] assertWarnsRegex doesn't allow multiple warning messages

2016-04-16 Thread Berker Peksag
Changes by Berker Peksag : -- components: +Library (Lib) -Interpreter Core type: behavior -> enhancement versions: -Python 3.5 ___ Python tracker <http://bugs.python.org/issu

[issue20739] PEP 463 (except expression) implementation

2016-04-16 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue21274] define PATH_MAX for GNU/Hurd in Python/pythonrun.c

2016-04-16 Thread Berker Peksag
Berker Peksag added the comment: Python 3.4 is in security-fix-only mode so we can close this now. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue24922] assertWarnsRegex doesn't allow multiple warning messages

2016-04-16 Thread Berker Peksag
Berker Peksag added the comment: Agreed. Let's close this then. -- nosy: +berker.peksag resolution: -> rejected stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.pyth

[issue23029] test_warnings produces extra output in quiet mode

2016-04-16 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue25989] documentation version switcher is broken fro 2.6, 3.2, 3.3

2016-04-16 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, but as I said in the GitHub issue, the version switcher works as expected (we don't build docs of security-only-fix branches). -- nosy: +berker.peksag resolution: -> not a bug stage: -> resolved status: ope

[issue13340] list.index does not accept None as start or stop

2016-04-16 Thread Berker Peksag
Berker Peksag added the comment: See http://thread.gmane.org/gmane.comp.python.devel/127502 for the python-dev thread. -- nosy: +berker.peksag versions: +Python 3.6 -Python 3.4 ___ Python tracker <http://bugs.python.org/issue13

[issue15933] flaky test in test_datetime

2016-04-16 Thread Berker Peksag
Berker Peksag added the comment: The assert was changed (somewhat similar to issue15933.diff) in bc67e8d39164. I've checked last 18 builds (from 800 to 818) on http://buildbot.python.org/all/builders/x86%20OpenIndiana%203.5 and test_today wasn't one of the failed tests. I'm

[issue24173] curses HOWTO/implementation disagreement

2016-04-16 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report! 3.x docs have already been updated. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior ___ Python tracker <http://

[issue7694] DeprecationWarnings in distutils are pointless

2016-04-16 Thread Berker Peksag
Berker Peksag added the comment: > [...] I think the DeprecationWarnings in distutils should just be removed, as > they serve no useful purpose. There are no DeprecationWarning warnings (only four PendingDeprecationWarning warnings -- two of them are for 'check_metadata

[issue25642] Setting maxsize breaks asyncio.JoinableQueue/Queue

2016-04-16 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> resolved status: open -> closed type: crash -> behavior ___ Python tracker <http://bugs.python.org/issue25642> ___ ___

[issue19791] test_pathlib should use can_symlink or skip_unless_symlink from test.support

2016-04-16 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review type: behavior -> enhancement versions: +Python 3.6 -Python 3.5 ___ Python tracker <http://bugs.python.org/i

[issue22873] Re: SSLsocket.getpeercert - return ALL the fields of the certificate.

2016-04-18 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> ssl.getpeercert() should include extensions ___ Python tracker <http://bugs.python

[issue26615] Missing entry in WRAPPER_ASSIGNMENTS in update_wrapper's doc

2016-04-18 Thread Berker Peksag
Berker Peksag added the comment: __qualname__ was added to WRAPPER_ASSIGNMENTS in 963e98f5ad31 (issue 13544). Thanks for the patch! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions:

[issue26755] Update version{added,changed} docs in devguide

2016-04-18 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue18591] threading.Thread.run returning a result

2016-04-18 Thread Berker Peksag
Berker Peksag added the comment: What is your use case? I think this can easily be implemented by subclassing the threading.Thread class: class MyThread(threading.Thread): def run(self): # skip try...finally to make the example shorter result = None

[issue17233] http.client header debug output format

2016-04-18 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy nosy: +berker.peksag stage: -> needs patch versions: +Python 3.5, Python 3.6 -Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python.org/issu

[issue23251] mention in time.sleep() docs that it does not block other Python threads

2016-04-18 Thread Berker Peksag
Changes by Berker Peksag : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue23251> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue13826] Having a shlex example in the subprocess.Popen docs is confusing

2016-04-18 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch versions: +Python 3.5, Python 3.6 -Python 2.7, Python 3.2, Python 3.3 ___ Python tracker <http://bugs.python.org/issu

[issue24838] tarfile.py: fix GNU and USTAR formats to properly handle paths with special characters that are encoded with more than one byte each

2016-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed ___ Python tracker <http://bugs.python.org/issue24838> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch versions: +Python 3.5 ___ Python tracker <http://bugs.python.org/issue26805> ___ ___ Py

[issue23710] C API doc for PyObject_HEAD is outdated

2016-04-19 Thread Berker Peksag
Berker Peksag added the comment: Docs of PyObject_HEAD and friends have already been fixed in 760c5cfacbaa. https://docs.python.org/3/extending/newtypes.html still needs to be updated to mention ob_base: This is what a Noddy object will contain—in this case, nothing more than what every

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2016-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker <http://bugs.python.org/issue9014> ___ ___ Python-bugs-list mailing list Un

[issue11233] clarifying Availability: Unix

2016-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review type: -> enhancement versions: +Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python.org/i

[issue22297] 2.7 json encoding broken for enums

2016-04-19 Thread Berker Peksag
Berker Peksag added the comment: -1 from me, too. -- nosy: +berker.peksag stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue13876] Sporadic failure in test_socket: testRecvmsgEOF

2016-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue13876> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue4260] ctypes.xFUNCTYPE are decorators.

2016-04-19 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy nosy: +berker.peksag stage: -> needs patch versions: +Python 3.5, Python 3.6 -Python 3.0 ___ Python tracker <http://bugs.python.org/iss

[issue1612012] builtin compile() doc needs PyCF_DONT_IMPLY_DEDENT

2016-04-19 Thread Berker Peksag
Berker Peksag added the comment: A similar request (issue 12207 - "Document ast.PyCF_ONLY_AST") was rejected in 2012. -- nosy: +berker.peksag resolution: -> rejected stage: -> resolved status: open -> closed ___ Py

[issue26805] Refer to types.SimpleNamespace in namedtuple documentation

2016-04-19 Thread Berker Peksag
Berker Peksag added the comment: Or if you don't want to use any hg extension: hg update 3.5 hg import --no-c http://bugs.python.org/file42520/collections.patch hg commit hg update default hg merge 3.5 hg revert -ar default hg resolve -am hg commit (Null merge (hg merge 3.5 and later) is

[issue20001] pathlib inheritance diagram too large

2016-04-20 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch type: -> enhancement versions: +Python 3.5, Python 3.6 -Python 3.4 ___ Python tracker <http://bugs.python.org/i

[issue16577] Suspect test.test_codeccallbacks.test_mutatingdecodehandler

2016-04-20 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> needs patch type: -> enhancement versions: +Python 3.6 ___ Python tracker <http://bugs.python.org/issue16577> ___ __

[issue26750] Mock autospec does not work with subclasses of property()

2016-04-21 Thread Berker Peksag
Changes by Berker Peksag : -- components: +Library (Lib) -Tests nosy: +berker.peksag stage: -> patch review type: enhancement -> behavior versions: +Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python.org/i

[issue12743] C API marshalling doc contains XXX

2016-04-21 Thread Berker Peksag
Berker Peksag added the comment: Since 4059e871e74e, PyMarshal_ReadLongFromFile and PyMarshal_ReadShortFromFile can return -1 on error. Return values of those functions were already documented in acb4d43955f6. Some of the usages also check return value of PyErr_Occurred(): https

[issue9317] Incorrect coverage file from trace test_pickle.py

2016-04-21 Thread Berker Peksag
Berker Peksag added the comment: A patch similar to issue9317.2.patch has been applied in 0aa46b9ffba3. However, I noticed a regression and created issue 26818. I can confirm that this issue is fixed with the patch from issue 26818 applied. -- nosy: +berker.peksag resolution

[issue26818] trace CLI doesn't respect -s option

2016-04-21 Thread Berker Peksag
New submission from Berker Peksag: I noticed this while triaging issue 9317. Using traceme.py from that issue, $ ./python -m trace -c -s traceme.py returns nothing. It seems like it's a regression caused by https://github.com/python/cpython/commit/17e5da46a733a1a05072a277bc81ffa885f

[issue7275] CoverageResult fails to merge input file with non-empty callers in trace.py

2016-04-21 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report and for the patch, Christian. Here is a patch with a test. -- nosy: +berker.peksag title: CoverageResult fails to merge input file with non-empty callers in trace.py (patch) -> CoverageResult fails to merge input file with

[issue26830] Refactor Tools/scripts/google.py

2016-04-22 Thread Berker Peksag
New submission from Berker Peksag: I don't think google.py is useful anymore. I'd prefer to just remove it from the cpython repository. -- components: +Demos and Tools nosy: +berker.peksag stage: -> patch review ___ Python t

[issue7567] Messed up terminal after calling curses.initscr() twice.

2016-04-22 Thread Berker Peksag
Changes by Berker Peksag : -- stage: test needed -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue7567> ___ ___ Pyth

[issue20077] Format of TypeError differs between comparison and arithmetic operators

2016-04-22 Thread Berker Peksag
Berker Peksag added the comment: The exception message has been updated to "TypeError: '<' not supported between instances of 'Color' and 'Color'" in 0238eafb68da. Closing this as 'out of date'. -- nosy: +berker.peksag resolut

[issue12640] test_ctypes seg fault (test_callback_register_double); armv7; gcc 4.5.1

2016-04-22 Thread Berker Peksag
Berker Peksag added the comment: 2.7 now uses libffi 3.1 and our ARM buildbots are quite healthy so I think we can now close this 'out of date'. -- nosy: +berker.peksag resolution: -> out of date stage: -> resolved status

[issue23806] documentation for no_proxy is missing from the python3 urllib documentation

2016-04-22 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy versions: +Python 3.6 -Python 3.4 ___ Python tracker <http://bugs.python.org/issue23806> ___ ___ Python-bugs-list m

[issue23516] pip: urllib3 does not encode userinfo section of URL with authentication credentials

2016-04-23 Thread Berker Peksag
Berker Peksag added the comment: This was reported on urllib3 issue tracker: https://github.com/shazow/urllib3/issues/814 -- nosy: +berker.peksag resolution: -> third party stage: -> resolved status: open -> closed ___ Python track

[issue14713] PEP 414 installation hook fails with an AssertionError

2016-04-23 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue14713> ___ ___

[issue11645] "Expand 10 after" on rietveld shows a duplicate line

2016-04-23 Thread Berker Peksag
Berker Peksag added the comment: I can't reproduce this with Chrome 49.0.2623.112 (64-bit). I guess this has already been fixed since 2011 (our fork's commit logs can be found at https://hg.python.org/tracker/rietveld/shortlog/bugs.python.org) -- nosy: +berker.peksag st

[issue20112] The documentation for http.server error_message_format is inadequate.

2016-04-23 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Anastasia. -- nosy: +berker.peksag resolution: -> fixed stage: needs patch -> resolved status: open -> closed versions: +Python 3.5, Python 3.6 -Python 3.3, Python 3.4 ___ Python track

[issue26089] Duplicated keyword in distutils metadata

2016-04-23 Thread Berker Peksag
Berker Peksag added the comment: I just committed Ezio's patch. Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.pyth

[issue21382] Signal module doesnt raises ValueError Exception

2016-04-23 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.6 -Python 3.4 ___ Python tracker <http://bugs.python.or

[issue18353] PyUnicode_WRITE_CHAR macro definition missing

2016-04-23 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report Wolf and thanks for the patch Corey. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: compile error -> behavior versions: +Python 3.5, Python 3.6

[issue18572] Remove redundant note about surrogates in string escape doc

2016-04-23 Thread Berker Peksag
Berker Peksag added the comment: I removed the sentence in 3.5 and default branches. -- nosy: +berker.peksag resolution: -> fixed stage: needs patch -> resolved status: open -> closed versions: +Python 3.5, Python 3.6 -Python 3.3, P

[issue20572] subprocess.Popen.wait() undocumented "endtime" parameter

2016-04-23 Thread Berker Peksag
Berker Peksag added the comment: Do we still want to remove the endtime parameter? -- nosy: +berker.peksag status: open -> pending ___ Python tracker <http://bugs.python.org/issu

[issue19731] Fix copyright footer

2016-04-23 Thread Berker Peksag
Berker Peksag added the comment: 2001 is also appears in python.org footer. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: +Python 3.5, Python 3.6 -Python 3.3

[issue26041] Update deprecation messages of platform.dist() and platform.linux_distribution()

2016-04-23 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue23277] Cleanup unused and duplicate imports in tests

2016-04-23 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Jon. I only removed sys and os since they were the most unused modules. -- resolution: -> fixed status: open -> closed versions: +Python 3.6 -Python 3.4, Python 3.5 ___ Python tracker

[issue23277] Cleanup unused and duplicate imports in tests

2016-04-24 Thread Berker Peksag
Berker Peksag added the comment: LGTM -- ___ Python tracker <http://bugs.python.org/issue23277> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26841] Hidden test in ctypes tests

2016-04-24 Thread Berker Peksag
Berker Peksag added the comment: This is a duplicate of issue 19113. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> duplicate test names in Lib/ctypes/test/test_functions.py __

[issue26840] Hidden test in test_heapq

2016-04-24 Thread Berker Peksag
Berker Peksag added the comment: This is a duplicate of issue 19119. -- nosy: +berker.peksag resolution: -> duplicate stage: needs patch -> resolved status: open -> closed superseder: -> duplicate test name in Lib/test/test_heapq.py __

[issue12305] Building PEPs doesn't work on Python 3

2016-04-24 Thread Berker Peksag
Berker Peksag added the comment: peps repo is now Python 3 compatible. Related commits: * https://github.com/python/peps/commit/88f9f6da5d51a36d0f6a1bb833a6e8c85763c7d2 * https://github.com/python/peps/commit/3e5cad857053e0c15b2621dae728f32b4099c1a5 -- nosy: +berker.peksag resolution

[issue23961] IDLE autocomplete window does not automatically close when selection is made

2016-04-24 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> resolved status: open -> closed superseder: -> IDLE code completion window can hang or misbehave with mouse ___ Python tracker <http://bugs.python.or

[issue24331] *** Error in `/usr/bin/python': double free or corruption (!prev): 0x0000000000f5c760 *** when cloning hg repository into directory on cifs

2016-04-24 Thread Berker Peksag
Berker Peksag added the comment: Agreed, this is unlikely an issue with Python. Please report it to Mercurial developers. -- nosy: +berker.peksag resolution: -> third party stage: -> resolved status: open -> closed ___ Python track

[issue24114] ctypes.utils uninitialized variable 'paths'

2016-04-24 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy versions: +Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python.org/issue24114> ___ ___ Python-bugs-list m

[issue23662] Cookie.domain is undocumented

2016-04-24 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch type: -> enhancement versions: +Python 3.6 -Python 3.2, Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python.org/i

[issue9456] Apparent memory leak in PC/bdist_wininst/install.c

2016-04-25 Thread Berker Peksag
Berker Peksag added the comment: install_c.diff looks good to me. Attaching a fresh version of it. There is a comment in PC/bdist_wininst/install.c saying IMPORTANT NOTE: IF THIS FILE IS CHANGED, PCBUILD\BDIST_WININST.VCXPROJ MUST BE REBUILT AS WELL. I don't have Windows so I can&#x

[issue23662] Cookie.domain is undocumented

2016-04-25 Thread Berker Peksag
Berker Peksag added the comment: Actually, it's already documented at https://docs.python.org/3.5/library/http.cookies.html#http.cookies.Morsel. I just added a note about the default value of domain. -- nosy: +berker.peksag resolution: -> fixed stage: needs patch -> reso

[issue7504] Same name cookies

2016-04-25 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Improper handling of duplicate cookies ___ Python tracker <http://bugs.pytho

[issue991266] Cookie.py does not correctly quote Morsels

2016-04-25 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch for Python 3. -- nosy: +berker.peksag versions: +Python 3.5, Python 3.6 -Python 3.1, Python 3.2 Added file: http://bugs.python.org/file42589/issue991266.diff ___ Python tracker <http://bugs.python.

[issue26848] asyncio.subprocess's communicate() method mishandles empty input bytes

2016-04-25 Thread Berker Peksag
Berker Peksag added the comment: python/cpython is a semi-official read-only mirror of hg.python.org/cpython. We haven't switched to GitHub yet. You may want to open a pull request to https://github.com/python/asyncio See https://github.com/python/asyncio/wiki/Contributing for de

[issue23275] Can assign [] = (), but not () = []

2016-04-26 Thread Berker Peksag
Berker Peksag added the comment: I missed Martin's comment about the documentation. I will update my patch. -- ___ Python tracker <http://bugs.python.org/is

[issue20598] argparse docs: '7'.split() is confusing magic

2016-04-26 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker <http://bugs.python.org/issue20598> ___ ___ Python-bugs-list mailing list Un

[issue26862] SYS_getdents64 does not need to be defined on android API 21

2016-04-26 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +gregory.p.smith ___ Python tracker <http://bugs.python.org/issue26862> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26536] Add the SIO_LOOPBACK_FAST_PATH option to socket.ioctl

2016-04-26 Thread Berker Peksag
Berker Peksag added the comment: Thanks for pinging, Daniel. I'm not a Windows user so I can't test the patch, but I left some review comments on Rietveld: http://bugs.python.org/review/26536/ -- components: +Extension Modules -IO, Windows nosy: +ber

[issue26536] Add the SIO_LOOPBACK_FAST_PATH option to socket.ioctl

2016-04-26 Thread Berker Peksag
Changes by Berker Peksag : -- components: +Windows ___ Python tracker <http://bugs.python.org/issue26536> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24933] socket.recv(size, MSG_TRUNC) returns more than size bytes

2016-04-26 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> needs patch versions: +Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python.org/issu

[issue25452] Add __bool__() method to subprocess.CompletedProcess

2016-04-26 Thread Berker Peksag
Berker Peksag added the comment: The idea sounds good to me. -- nosy: +berker.peksag stage: -> needs patch versions: +Python 3.6 -Python 3.5 ___ Python tracker <http://bugs.python.org/issu

[issue24147] Dialect class defaults are not documented.

2016-04-26 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue24147> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26868] Incorrect check for return value of PyModule_AddObject in _csv.c

2016-04-26 Thread Berker Peksag
New submission from Berker Peksag: This is probably harmless, but Modules/_csv.c has the following code: Py_INCREF(&Dialect_Type); if (PyModule_AddObject(module, "Dialect", (PyObject *)&Dialect_Type)) return NULL; However, PyModule_AddObject returns only

<    26   27   28   29   30   31   32   33   34   35   >