[issue26366] Use “.. versionadded” over “.. versionchanged” where appropriate

2016-02-16 Thread Berker Peksag
Berker Peksag added the comment: I agree with Georg and Ezio. We should update the devguide. Tony, would you like to propose a patch? The repo is at https://hg.python.org/devguide -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.

[issue24911] Context manager of socket.socket is not documented

2016-02-16 Thread Berker Peksag
Berker Peksag added the comment: socket-context.patch looks good to me. There is no need to add a NEWS entry for this. -- nosy: +berker.peksag stage: patch review -> commit review versions: -Python 3.4 ___ Python tracker <http://bugs.pyth

[issue16915] mode of socket.makefile is more limited than documentation suggests

2016-02-18 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report and for the patch. I would prefer to keep the code simple so I just applied documentation changes with a minor tweak. -- assignee: -> docs@python components: +Documentation -Library (Lib) nosy: +berker.peksag, docs@pyt

[issue26384] UnboundLocalError in socket._sendfile_use_sendfile

2016-02-18 Thread Berker Peksag
New submission from Berker Peksag: I noticed this while working on issue 16915: Traceback (most recent call last): ... File "/home/berker/projects/cpython/default/Lib/socket.py", line 262, in _sendfile_use_sendfile raise _GiveupOnSendfile(err) # not a regular file Unbound

[issue25532] infinite loop when running inspect.unwrap over unittest.mock.call

2016-02-18 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> needs patch type: -> behavior ___ Python tracker <http://bugs.python.org/issue25532> ___ ___ Python-bugs-list

[issue23430] socketserver.BaseServer.handle_error() should not catch exiting exceptions

2016-02-19 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issue23430> ___ ___ Python-bugs-list mai

[issue26401] Error in documentation for "compile" built-in function

2016-02-21 Thread Berker Peksag
Berker Peksag added the comment: It would be good to add a versionchanged note. Something like: .. versionchanged:: 3.5 Previously, a :exc:`TypeError` was raised [...] -- nosy: +berker.peksag stage: -> patch review ___ Python trac

[issue26401] Error in documentation for "compile" built-in function

2016-02-21 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue26403] Don't call sendto in socketserver.DatagramRequestHandler if there is nothing to send

2016-02-21 Thread Berker Peksag
Berker Peksag added the comment: This looks like a duplicate of issue 5824. See msg259969 for Martin's analysis in that issue. There is also a similar patch for 2.7 in issue 1767511: http://bugs.python.org/file9271/DatagramServer.diff -- nosy: +berker.peksag, martin.panter -ned.

[issue25080] The example-code for making XML-RPC requests through proxy, fail!

2016-02-22 Thread Berker Peksag
Berker Peksag added the comment: This has been fixed in cf842a8ccb77. Thank you for reporting this, Kostis! -- nosy: +berker.peksag resolution: -> out of date stage: needs patch -> resolved status: open -> closed versions: -Python 3.4 _

[issue26335] Make mmap.write return the number of bytes written like other write methods

2016-02-22 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Jakub. I don't use mmap module much so I don't have an opinion about the feature, but it sounds reasonable. I left some review comments on Rietveld: http://bugs.python.org/review/26335/ -- components: +Extension M

[issue26426] email examples: incorrect use of email.headerregistry.Address

2016-02-24 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. This is a duplicate of issue 26176. Would you like to send a patch? -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> EmailMessage example

[issue21042] ctypes.util.find_library() should return full pathname instead of filename in linux

2016-02-27 Thread Berker Peksag
Berker Peksag added the comment: I don't think we need an entry in whatsnew/3.6.rst for this (we already have documented the change in a versionchanged directive and a Misc/NEWS item) -- nosy: +berker.peksag ___ Python tracker

[issue13573] csv.writer uses str() for floats instead of repr()

2016-02-27 Thread Berker Peksag
Berker Peksag added the comment: csv.writer() documentation says: "All other non-string data are stringified with str() before being written." https://docs.python.org/2.7/library/csv.html#csv.writer I guess adding a sentence to document the special case for floats wou

[issue23041] csv needs more quoting rules

2016-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.6 -Python 3.5 ___ Python tracker <http://bugs.python.org/issu

[issue13573] csv.writer uses str() for floats instead of repr()

2016-02-28 Thread Berker Peksag
Changes by Berker Peksag : -- stage: needs patch -> resolved ___ Python tracker <http://bugs.python.org/issue13573> ___ ___ Python-bugs-list mailing list Un

[issue17231] Mark __del__ not being called in cycles as an impl detail

2016-02-29 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue17231> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17232] Improve -O docs

2016-02-29 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue17232> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24823] ctypes.create_string_buffer does not add NUL if len(init) == size

2016-02-29 Thread Berker Peksag
Changes by Berker Peksag : -- components: -Devguide ___ Python tracker <http://bugs.python.org/issue24823> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17580] ctypes: ARM hardfloat argument corruption calling functions with many float arguments

2016-03-01 Thread Berker Peksag
Berker Peksag added the comment: > Which patch? Looks like the patch can be found at https://github.com/atgreen/libffi/pull/34/ and it has been released in libffi 3.1: https://github.com/atgreen/libffi/blob/17ffc3655a531c116e9eb9cc933e50bb1e5c47f8/ChangeLog.libffi-3.1#L481 (It's

[issue22176] update internal libffi copy to 3.1, introducing AArch64 and POWER ELF ABIv2

2016-03-02 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue22176> ___

[issue25660] tabs don't work correctly in python repl

2016-03-02 Thread Berker Peksag
Changes by Berker Peksag : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue25660> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue13492] ./configure --with-system-ffi=LIBFFI-PATH

2016-03-02 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue17873] _ctypes/libffi missing bits for aarch64 support

2016-03-02 Thread Berker Peksag
Berker Peksag added the comment: This has been fixed as part of updating libffi in issue 22176: https://github.com/python/cpython/blob/master/Modules/_ctypes/libffi/fficonfig.py.in#L20 Thanks for the report and for the patch, Andreas! -- nosy: +berker.peksag resolution: -> out

[issue26335] Make mmap.write return the number of bytes written like other write methods

2016-03-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Jakub! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue26246] Code output toggle button uses removed jQuery method

2016-03-02 Thread Berker Peksag
Berker Peksag added the comment: Good catch, thanks! -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue26246> ___ ___ Python-bugs-list mailin

[issue23041] csv needs more quoting rules

2016-03-02 Thread Berker Peksag
Berker Peksag added the comment: I was thinking adding a more flexible API like: ... spamwriter = csv.writer(csvfile, quoting_callable=lambda field: field is not None) ... But that would require too much change in the csv module (or at least its implementation wouldn't be tr

[issue25907] Documentation i18n: Added trans tags in sphinx templates

2016-03-04 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: -> resolved ___ Python tracker <http://bugs.python.org/issue25907> ___ ___ Python-bugs-list

[issue20397] distutils --record option does not validate existence of byte-compiled files

2016-03-05 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag versions: -Python 3.2, Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python.org/issue20397> ___ ___

[issue26485] Missing newline, raising a warning, in /Doc/license.rst

2016-03-05 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Julien! For the record, here is the warning: Doc/license.rst:350: WARNING: Literal block ends without a blank line; unexpected unindent. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: en

[issue17940] extra code in argparse.py

2016-03-05 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 -Python 3.4 ___ Python tracker <http://bugs.python.or

[issue26490] Leading “0” allowed, only for decimal zero

2016-03-06 Thread Berker Peksag
Changes by Berker Peksag : -- superseder: -> Deprecate 0 as a synonym for 0 ___ Python tracker <http://bugs.python.org/issue26490> ___ ___ Python-bugs-lis

[issue2202] urllib2 fails against IIS 6.0 (No support for MD5-sess auth)

2016-03-06 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Mathieu! I went with a simpler approach to test the code. -- keywords: -needs review nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed type: enhancement -&

[issue26489] dictionary unpacking operator in dict expression

2016-03-06 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch! Could you please sign the contributor's agreement at https://www.python.org/psf/contrib/contrib-form/ ? -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: ope

[issue21034] Python docs reference the Distribute package which has been deprecated in favor of Setuptools

2016-03-06 Thread Berker Peksag
Berker Peksag added the comment: I think it would be better to just remove the following part from the documentation: "Of course, you need to install them into the venv first: this could be done by running ez_setup.py with the venv activated, followed by running easy_install

[issue15948] Unchecked return value of I/O functions

2016-03-06 Thread Berker Peksag
Changes by Berker Peksag : -- dependencies: +Missing sanity checks for various C library function calls... ___ Python tracker <http://bugs.python.org/issue15

[issue26497] Documentation - HOWTO Use Python in the web paragraph on TurboGears still mentions it's based on Pylons

2016-03-06 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. Actually, the whole document is outdated. I think we can mark this as a duplicate of issue 24852. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Python 3.5

[issue24852] Python 3.5.0rc1 "HOWTO Use Python in the web" needs fix

2016-03-06 Thread Berker Peksag
Berker Peksag added the comment: See issue 26497 for another report about this. I will remove Doc/howto/webservers.rst. -- versions: -Python 3.4 ___ Python tracker <http://bugs.python.org/issue24

[issue7370] BaseHTTPServer reinventing rfc822 date formatting

2016-03-07 Thread Berker Peksag
Berker Peksag added the comment: There is an up-to-date patch for Python 3 in issue 747320. Closing this as a duplicate. -- nosy: +berker.peksag resolution: -> duplicate stage: test needed -> resolved status: open -> closed superseder: -> rfc2822 formatdate functionality

[issue21034] Python docs reference the Distribute package which has been deprecated in favor of Setuptools

2016-03-07 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, Jurko. > +1 from me for just removing the bootstrapping instructions from this note. Thanks, Nick. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed __

[issue24852] Python 3.5.0rc1 "HOWTO Use Python in the web" needs fix

2016-03-07 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue26502] traceback.extract_tb breaks compatibility by returning FrameSummary

2016-03-08 Thread Berker Peksag
Berker Peksag added the comment: This is basically a duplicate of issue 25573. We need to add the examples in traceback module documentation to test_traceback.py. > Should __len__ be added as well? IMO, the new FrameSummary API (and its friends) shouldn't change the return valu

[issue26518] AttributeError: 'module' object has no attribute '_handlerList'

2016-03-09 Thread Berker Peksag
Berker Peksag added the comment: This doesn't look like an issue with the Python standard library. I think you should report this to pip. Also, why are you installing logging module on Python 2.7? The PyPI version of logging module is very old (last updated 2005). --

[issue26443] cross building extensions picks up host headers

2016-03-09 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> resolved superseder: -> setup.py: do not add invalid header locations ___ Python tracker <http://bugs.python.org/i

[issue20589] pathlib.owner() and pathlib.group() raise ImportError on Windows

2016-03-11 Thread Berker Peksag
Berker Peksag added the comment: I've changed the exception to raise NotImplementedError. I'm not sure about using the ctypes solution in the stdlib. Perhaps we should wrap Windows GetSecurity* APIs (similar to what we did for UNIX/POSIX APIs) first then we can use it

[issue26542] Wrongly formatted doctest block in difflib documentation

2016-03-11 Thread Berker Peksag
Berker Peksag added the comment: Good catch, Dmitry. Thanks for the patch! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue20589] pathlib.owner() and pathlib.group() raise ImportError on Windows

2016-03-11 Thread Berker Peksag
Berker Peksag added the comment: Thanks Victor. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/issue20589> ___ __

[issue26323] Add assert_called() and assert_called_once() methods for mock objects

2016-03-11 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue26323> ___

[issue747320] rfc2822 formatdate functionality duplication

2016-03-12 Thread Berker Peksag
Berker Peksag added the comment: -now = time.time() -year, month, day, hh, mm, ss, x, y, z = time.localtime(now) -s = "%02d/%3s/%04d %02d:%02d:%02d" % ( -day, self.monthname[month], year, hh, mm, ss) +s = time.strftime("%d

[issue16181] cookielib.http2time raises ValueError for invalid date.

2016-03-13 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 -Python 3.4 ___ Python tracker <http://bugs.python.or

[issue747320] rfc2822 formatdate functionality duplication

2016-03-13 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org

[issue5505] sys.stdin.read() doesn't return after first EOF on Windows

2016-03-14 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue5505> ___ ___

[issue26560] Error in assertion in wsgiref.handlers.BaseHandler.start_response

2016-03-16 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. Can you give us a bit more information about the issue? Did you get a traceback? Or just noticed it while reading the source code? If you want to write a patch, please read the devguide. -- nosy: +berker.peksag priority: normal

[issue26560] Error in assertion in wsgiref.handlers.BaseHandler.start_response

2016-03-19 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Peter! I've simplified the test a bit and commit it. -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.pyth

[issue18787] Misleading error from getspnam function of spwd module

2016-03-19 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue19265] Increased test coverage for datetime pickling

2016-03-19 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Colin! -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.5, Python 3.6 -Python 3.4 ___ Python track

[issue26580] Documentation for ftplib still references ftpmirror.py

2016-03-19 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python tracker <http://bug

[issue26579] Support pickling slots in subclasses of common classes

2016-03-19 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue26579> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue22758] Regression in Python 3.2 cookie parsing

2016-03-19 Thread Berker Peksag
Berker Peksag added the comment: I will commit this to the 3.2 branch today. -- status: closed -> open ___ Python tracker <http://bugs.python.org/issu

[issue26593] silly typo in logging cookbook

2016-03-20 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Andrew. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4 ___ Python track

[issue26267] UUID docs should say how to get "standard form"

2016-03-20 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch versions: +Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python.org/issu

[issue19164] Update uuid.UUID TypeError exception: integer should not be an argument.

2016-03-20 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 -Python 2.7, Python 3.4 ___ Python tracker <http://bugs.python.or

[issue12813] uuid4 is not tested if a uuid4 system routine isn't present

2016-03-20 Thread Berker Peksag
Berker Peksag added the comment: Since 756d040aa8e8, uuid.uuid4() no longer depends on ctypes. I'll remove the 'requires ctypes' condition from test_uuid4. -- nosy: +berker.peksag versions: +Python 3.5, Python 3.6 -Python 3.3 ___

[issue12813] uuid4 is not tested if a uuid4 system routine isn't present

2016-03-20 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Matt! -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue24459] Mention PYTHONFAULTHANDLER in the man page

2016-03-21 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch type: -> enhancement versions: +Python 3.6 ___ Python tracker <http://bugs.python.org/i

[issue24887] Sqlite3 has no option to provide open flags

2016-03-23 Thread Berker Peksag
Changes by Berker Peksag : -- dependencies: +Migrate sqlite3 module to _v2 API to enhance performance stage: -> needs patch type: -> enhancement ___ Python tracker <http://bugs.python.org/i

[issue26625] SELECT-initiated transactions can cause "database is locked" in sqlite

2016-03-23 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> resolved superseder: -> sqlite3 SELECT does not BEGIN a transaction, but should according to spec ___ Python tracker <http://bugs.python.org/i

[issue26616] A bug in datetime.astimezone() method

2016-03-23 Thread Berker Peksag
Berker Peksag added the comment: 3.3 and 3.4 are in security-fix-only mode: https://docs.python.org/devguide/devcycle.html#summary So this can be fixed in 3.5 and default branches. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.

[issue20021] "modernize" makeopcodetargets.py

2016-03-25 Thread Berker Peksag
Berker Peksag added the comment: Victor went with a different solution in f682b620c64d. -- nosy: +haypo resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue24887] Sqlite3 has no option to provide open flags

2016-03-27 Thread Berker Peksag
Berker Peksag added the comment: URI filename support has been added in f13bb1e40fbc (Python 3.4+). db = sqlite3.connect('file:path/to/database?mode=ro', uri=True) Here is a patch that adds a new flags parameter to sqlite3.connect(). -- dependencies: -Migrate sqlite3

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

2016-03-27 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag type: performance -> enhancement ___ Python tracker <http://bugs.python.org/issue9303> ___ ___ Python-

[issue26651] Deprecate register_adapter() and register_converter() in sqlite3

2016-03-27 Thread Berker Peksag
New submission from Berker Peksag: In issue 19065: Gerhard says: "I'm -1 because I believe that ultimately, adapters and converters were a mistake to add to pysqlite. That's why I deprecated them in pysqlite 2.8.0." Here is a patch (based on commit from pysqlite proje

[issue19065] sqlite3 timestamp adapter chokes on timezones

2016-03-27 Thread Berker Peksag
Berker Peksag added the comment: > Do you know what would be the correct step to propose a deprecation in the > sqlite3 module of Python proper? I've opened issue 26651 (patch included) to deprecate them. -- nosy: +berker.peksag resolution: -> rejected stage: needs pat

[issue15117] Please document top-level sqlite3 module variables

2016-03-27 Thread Berker Peksag
Berker Peksag added the comment: *_version_* attributes OP mentioned have already been documented in b8b26feb3e1a. -- nosy: +berker.peksag resolution: -> out of date stage: -> resolved status: open -> closed ___ Python track

[issue9297] SMTP with Sqlite3 file attached problem

2016-03-27 Thread Berker Peksag
Berker Peksag added the comment: > Unless someone can reproduce the issue, I recommend that we close this ticket. I couldn't reproduce it either. -- nosy: +berker.peksag status: open -> closed ___ Python tracker <http://bugs.python

[issue18691] sqlite3.Cursor.execute expects sequence as second argument.

2016-03-27 Thread Berker Peksag
Berker Peksag added the comment: I think the name "parameters" causes a confusion here. It basically means def execute(sql, parameters): not def execute(sql, *parameters): So ``con.execute('insert into foo values (?, ?)', (4, 5))`` is the correct usage of the AP

[issue23758] Improve documenation about num_params in sqlite3 create_function and create_aggregate

2016-03-27 Thread Berker Peksag
Berker Peksag added the comment: Thank you Cédric. I also added tests to verify the behavior of num_params=-1. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 -Python 3.4 ___ Python track

[issue25195] mock.ANY doesn't match mock.MagicMock() object

2016-03-27 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- keywords: +3.5regression -patch resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue25195] mock.ANY doesn't match mock.MagicMock() object

2016-03-27 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +patch ___ Python tracker <http://bugs.python.org/issue25195> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26130] redundant local copy of a char pointer in classify in Parser\parser.c

2016-03-27 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Oren! -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5 ___ Python tracker <http://bugs.python.or

[issue15859] PyUnicode_EncodeFSDefault win32 inconsistancy.

2016-03-28 Thread Berker Peksag
Berker Peksag added the comment: shanzhengcheng: Please don't update closed issues. gns3-1.4.5 is not part of the Python standard library. You'll get better support by using the gns3 support channels. If you still think that this is a bug in Python, please file a new issue by usin

[issue15859] PyUnicode_EncodeFSDefault win32 inconsistancy.

2016-03-28 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: -paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker <http://bugs.python.org/issue15859> ___ ___ Python-bug

[issue10740] sqlite3 module breaks transactions and potentially corrupts data

2016-03-28 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch. It contains the following commits: * https://github.com/ghaering/pysqlite/commit/f254c534948c41c0ceb8cbabf0d4a2f547754739 * https://github.com/ghaering/pysqlite/commit/796b3afe38cfdac5d7d5ec260826b0a596554631 * https://github.com/ghaering

[issue26687] Use Py_RETURN_NONE in sqlite3 module

2016-04-01 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +patch Added file: http://bugs.python.org/file42345/py_return_none_macro.diff ___ Python tracker <http://bugs.python.org/issue26

[issue26687] Use Py_RETURN_NONE in sqlite3 module

2016-04-01 Thread Berker Peksag
New submission from Berker Peksag: The attached patch replaces all "Py_INCREF(Py_None); return Py_None;" lines with the Py_RETURN_NONE macro in sqlite3 module. -- components: Extension Modules messages: 262754 nosy: berker.peksag priority: normal severity: normal stage: pa

[issue26688] unittest2 referenced in unittest.mock documentation

2016-04-01 Thread Berker Peksag
Berker Peksag added the comment: Good catch, thanks Ashley! 3.3 and 3.4 are in security-fix-only mode so we don't fix documentation issues in those branches. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior v

[issue26679] curses: Descripton of KEY_NPAGE and KEY_PPAGE inverted

2016-04-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Robert and SilentGhost. I verified the patch with the following script: import curses def main(stdscr): while True: c = stdscr.getch() if c == curses.KEY_PPAGE: stdscr.addstr('Page Up')

[issue5901] missing meta-info in documentation pdf

2016-04-01 Thread Berker Peksag
Berker Peksag added the comment: I get the following output when I try Python 3.5.1 docs: $ pdfinfo using.pdf Title: Subject: Keywords: Author: Creator:LaTeX with hyperref package Producer: pdfTeX-1.40.14 CreationDate: Sat Apr 2 00:17:54 2016

[issue13952] mimetypes doesn't recognize .csv

2016-04-01 Thread Berker Peksag
Berker Peksag added the comment: I will commit issue13952.patch this weekend to 2.7, 3.5 and default. -- nosy: +berker.peksag stage: needs patch -> patch review versions: -Python 3.2, Python 3.3, Python 3.4 ___ Python tracker &l

[issue23371] mimetypes initialization fails on Windows because of TypeError

2016-04-01 Thread Berker Peksag
Berker Peksag added the comment: This is a duplicate of issue 22028 (fixed in 2.7 in 7c4c4e43c452). -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Python 3.4.1 Installer ended prematurely

[issue21718] sqlite3 cursor.description seems to rely on incomplete statement parsing for detection

2016-04-02 Thread Berker Peksag
Berker Peksag added the comment: I adapted the reproducer in msg220263 and added more tests. -- nosy: +berker.peksag stage: test needed -> patch review versions: -Python 3.4 Added file: http://bugs.python.org/file42354/issue21718_tests.d

[issue6953] readline documentation needs work

2016-04-04 Thread Berker Peksag
Berker Peksag added the comment: readline-doc.v3.patch looks good to me. -- stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/iss

[issue18820] json.dump() ignores its 'default' option when serializing dictionary keys

2016-04-08 Thread Berker Peksag
Changes by Berker Peksag : -- assignee: docs@python -> components: -Documentation versions: -Python 3.4 ___ Python tracker <http://bugs.python.org/issu

[issue26713] Change f-literal grammar so that escaping isn’t possible or necessary

2016-04-08 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +eric.smith ___ Python tracker <http://bugs.python.org/issue26713> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue23397] PEP 431 implementation

2016-04-08 Thread Berker Peksag
Berker Peksag added the comment: Closing this since the PEP has been withdrawn. See https://www.python.org/dev/peps/pep-0431/#withdrawal for details. -- resolution: -> postponed stage: needs patch -> resolved status: open -> closed _

[issue26687] Use Py_RETURN_NONE in sqlite3 module

2016-04-08 Thread Berker Peksag
Berker Peksag added the comment: Thanks Victor and Serhiy. Сoccinelle looks like a useful tool, but I'm not planning to touch modules that I don't know well enough. -- resolution: -> fixed stage: patch review -> resolved status

[issue19377] Backport SVG mime type to Python 2

2016-04-08 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag resolution: -> fixed status: open -> closed versions: -Python 2.6 ___ Python tracker <http://bugs.python.org/i

[issue16329] mimetypes does not support webm type

2016-04-08 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 2.7, Python 3.6 ___ Python tracker <http://bugs.python.or

[issue13952] mimetypes doesn't recognize .csv

2016-04-08 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Geoff. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue17264] Update Building C and C++ Extensions with distutils documentation

2016-04-08 Thread Berker Peksag
Berker Peksag added the comment: bad92d696866 has already been removed all Python 1.4 and 2.0 references. I fixed a markup error and two broken references. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> behavior versions: +Python

<    25   26   27   28   29   30   31   32   33   34   >