[issue23883] __all__ lists are incomplete

2015-11-11 Thread Berker Peksag
Berker Peksag added the comment: I like Martin's support.expected_module_api() suggestion in msg247167. I still find passing self to a function just to use assertCountEqual a bit weird, but I can live with that. -- ___ Python tracker

[issue23883] __all__ lists are incomplete

2015-11-12 Thread Berker Peksag
Berker Peksag added the comment: > The reason why I prefer the current API over my support.expected_module_api() > idea is it requires the extra assertCountEqual() boilerplate at each call > site. I personally find explicit assert* calls in a test case more readable(e.g. I don&

[issue25017] htmllib deprecated: Which library to use? Missing sane default in docs

2015-11-12 Thread Berker Peksag
Berker Peksag added the comment: htmllib_deprecation_warning_3.patch looks good to me. -- stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issu

[issue3353] make built-in tokenizer available via Python C API

2015-11-14 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag versions: +Python 3.6 -Python 3.5 ___ Python tracker <http://bugs.python.org/issue3353> ___ ___ Python-bug

[issue25704] Update the devguide to 3.5

2015-11-23 Thread Berker Peksag
Berker Peksag added the comment: I don't think most of the version numbers are very important here and I wouldn't change them unless there is a valid reason. > -3.4 and 3.5, first fix it in ``3.4`` and then merge ``3.4`` into ``default`` > -(which holds the future 3.5). >

[issue25704] Update the devguide to 3.5

2015-11-23 Thread Berker Peksag
Changes by Berker Peksag : -- versions: -Python 3.6 ___ Python tracker <http://bugs.python.org/issue25704> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25704] Update the devguide to 3.5

2015-11-23 Thread Berker Peksag
Berker Peksag added the comment: > My first opinion when I have read the documentation was "but this doc is out > of date". Yes, some parts of the devguide is outdated and I already gave +1 to update those parts. But most of the other changes are use 3.4 as an example so ch

[issue21475] Support the Sitemap extension in robotparser

2015-11-23 Thread Berker Peksag
Berker Peksag added the comment: Peter didn't write a test because issue 25497 (test_robotparser rewrite) needs to be committed first. See msg253016 in issue 25400 for more information. -- stage: needs patch -> patch review ___ Python tracke

[issue21240] Add an abstactmethod directive to the Python ReST domain

2015-12-08 Thread Berker Peksag
Berker Peksag added the comment: Thanks for reminding me of this issue, Brett. I have also updated numbers and selectors docs to use the new directive. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 -P

[issue1322] Deprecate platform.dist() and platform.linux_distribution() functions

2015-12-08 Thread Berker Peksag
Berker Peksag added the comment: We should probably delete the "will be removed in Python 3.7" part from the deprecation message to make porting from Python 2 easier. For example, we will add inspect.getargspec() back in 3.6. See i

[issue25677] Syntax error caret confused by indentation

2015-12-10 Thread Berker Peksag
Berker Peksag added the comment: With the latest patch applied, the output is File "z.py", line 2 1 + 2 = 3 ^ SyntaxError: can't assign to operator I think the caret is still in wrong place. I would expect the following output: File "z.py&qu

[issue24595] InteractiveInterpreter always prints to stdout

2015-12-10 Thread Berker Peksag
Berker Peksag added the comment: I agree with David. I've added a "stream" attribute to InteractiveInterpreter. I don't have a strong preference between a getstream method and a stream attribute(or something different) so I will add documentation changes and tests later.

[issue25614] Lib/code.py: InteractiveConsole.raw_input writes prompt to stdout

2015-12-10 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report! Unfortunately, self.write(prompt) return input() is not equivalent of ``return input(prompt)``. Could you give more information about your use case? -- nosy: +berker.peksag

[issue25755] Test test_property failed if run twice

2015-12-11 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Nan. I've updated your patch to apply Serhiy's advice. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.5 ___ Py

[issue25757] Subclasses of property lose docstring

2015-12-11 Thread Berker Peksag
Berker Peksag added the comment: Thanks for fix_repetitions.diff, Torsten. The test_property failure was discussed in issue 25755. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue25

[issue25822] Add docstrings to fields of urllib.parse results

2015-12-11 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Swati. I left a few comments on Rietveld: http://bugs.python.org/review/25822/ A test wouldn't hurt, but you can wait for further review comments to avoid updating tests each time you get a comment. -- nosy: +berker.p

[issue25730] invisible sidebar content with code snippets

2015-12-11 Thread Berker Peksag
Berker Peksag added the comment: This can be reproduced at https://docs.python.org/3/faq/windows.html You can find the CSS file at Doc/tools/pydoctheme/static/pydoctheme.css. You can override .highlight there, but the actual problem is that Sphinx creates the outer highlight-python3 div with

[issue6478] time.tzset does not reset _strptime's locale time cache

2015-12-11 Thread Berker Peksag
Berker Peksag added the comment: Thanks Serhiy. Can we close this now? -- ___ Python tracker <http://bugs.python.org/issue6478> ___ ___ Python-bugs-list mailin

[issue25757] Subclasses of property lose docstring

2015-12-11 Thread Berker Peksag
Berker Peksag added the comment: fix_repetitions.diff was unrelated to this issue so subprop_doc_r2.diff still needs to be reviewed. -- ___ Python tracker <http://bugs.python.org/issue25

[issue5501] Update multiprocessing docs re: freeze_support

2015-12-11 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +davin ___ Python tracker <http://bugs.python.org/issue5501> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19771] runpy should check ImportError.name before wrapping it

2015-12-11 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issue19771> ___ ___ Python-bugs-list mai

[issue24203] Deprecate threading.Thread.isDaemon etc

2015-12-12 Thread Berker Peksag
Berker Peksag added the comment: +1 for deprecating them. Removing them would make porting code from Python 2 harder so I think it's better to keep them for a while. -- components: +Library (Lib) keywords: +patch nosy: +berker.peksag stage: -> patch review title: De

[issue21436] Consider leaving importlib.abc.Loader.load_module()

2015-12-12 Thread Berker Peksag
Changes by Berker Peksag : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue21436> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue13033] Add shutil.chowntree

2015-12-13 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review versions: +Python 3.6 -Python 3.3 ___ Python tracker <http://bugs.python.org/issu

[issue25859] EOFError in test_nntplib.NetworkedNNTPTests.test_starttls()

2015-12-15 Thread Berker Peksag
Berker Peksag added the comment: > Would it be appropriate to change this test so that instead of connecting to > a remote server, we connect to a local server running in a background thread? +1. We can host it at pythontest.net if needed. The repo is here: https://hg.pyth

[issue17055] ftplib.ftpcp test

2015-12-15 Thread Berker Peksag
Berker Peksag added the comment: ftpcp is undocumented and not part of the public API. It was added(changeset https://hg.python.org/cpython/rev/63cdfbb4a2bb#l1.433) in 1996 and it looks like its code was only touched for whitespace and PEP 8 fixes. I think we need to decide whether we want

[issue25610] Add typing.Awaitable

2015-12-15 Thread Berker Peksag
Berker Peksag added the comment: Can we close this now? -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue25610> ___ ___ Python-bugs-list m

[issue25794] __setattr__ does not always overload operators

2015-12-15 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review versions: -Python 3.4 ___ Python tracker <http://bugs.python.org/issue25794> ___ _

[issue23788] test_urllib2_localnet.test_bad_address fails: OSError not raised by urlopen

2015-12-15 Thread Berker Peksag
Berker Peksag added the comment: bad_address.patch looks good to me. -- nosy: +berker.peksag stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issu

[issue12484] The Py_InitModule functions no longer exist, but remain in the docs

2015-12-23 Thread Berker Peksag
Berker Peksag added the comment: The patch looks good to me. _PyImport_FixupExtension does not exist in Python 3, but it's still documented in Doc/c-api/import.rst. We need to remove it, too. (Or we could document _PyImport_FixupExtensionObject since there are already documented int

[issue25950] svn.python.org SSL certificate expired, causing test failures

2015-12-25 Thread Berker Peksag
Berker Peksag added the comment: Thanks koobs, this is a duplicate of issue 25940. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> SSL tests failed due to expired svn.python.org SSL

[issue25930] Document that os.remove is semantically identical to os.unlink

2015-12-25 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch ___ Python tracker <http://bugs.python.org/issue25930> ___ ___ Python-bugs-list mai

[issue25935] OrderedDict prevents garbage collection if a circulary referenced class is used as key

2015-12-28 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +eric.snow, serhiy.storchaka ___ Python tracker <http://bugs.python.org/issue25935> ___ ___ Python-bugs-list mailing list Unsub

[issue19475] Add timespec optional flag to datetime isoformat() to choose the precision

2015-12-29 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Alessandro. I left some comments about documentation part of the patch, but I can fix them myself if you don't have time. -- stage: commit review -> patch review ___ Python tracke

[issue25977] Typo fixes in Lib/tokenize.py

2015-12-29 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, John. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue25813] co_flags section of inspect module docs out of date

2016-01-02 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> needs patch status: closed -> open type: -> enhancement versions: +Python 3.5 ___ Python tracker <http://bugs.python.or

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-02 Thread Berker Peksag
Berker Peksag added the comment: Thank you Ezio, I'll commit this tomorrow. -- assignee: jhylton -> berker.peksag ___ Python tracker <http://bugs.python.or

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-05 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.o

[issue25802] Finish deprecating load_module()

2016-01-05 Thread Berker Peksag
Berker Peksag added the comment: issue25802.diff looks good to me (just added a minor comment on Rietveld) -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue25

[issue25917] Fixing howto links in docs

2016-01-05 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed ___ Python tracker <http://bugs.python.org/issue25917> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue6500] urllib2 maximum recursion depth exceeded

2016-01-05 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Senthil. I've just reverted fbea8ff8db5e. Sorry for the noise! -- resolution: fixed -> stage: resolved -> needs patch status: closed -> open ___ Python tracker <http://bugs.pyt

[issue25486] Resurrect inspect.getargspec() in 3.6

2016-01-09 Thread Berker Peksag
Berker Peksag added the comment: Perhaps we can also add it back in 3.5.2 since 3.5 is in early stages of its maintenance period? -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue25

[issue26030] Use PEP8 in documentation examples

2016-01-09 Thread Berker Peksag
Changes by Berker Peksag : -- stage: needs patch -> resolved ___ Python tracker <http://bugs.python.org/issue26030> ___ ___ Python-bugs-list mailing list Un

[issue26063] Update copyright in the devguide

2016-01-09 Thread Berker Peksag
Berker Peksag added the comment: I'd prefer a more general solution similar to the one has been used in Doc/conf.py copyright = u'1990-%s, Python Software Foundation' % time.strftime('%Y') -- nosy: +berker.peksag

[issue26074] Add a method to pip.. pip.require("package_name")

2016-01-10 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, but this should be discussed either at https://groups.google.com/forum/#!forum/pypa-dev or https://github.com/pypa/pip/issues -- nosy: +berker.peksag resolution: -> third party stage: -> resolved status: open -&g

[issue26069] Remove the Deprecated API in trace module

2016-01-11 Thread Berker Peksag
Berker Peksag added the comment: I couldn't find exact references, but I think we've reached an agreement that we want to keep old APIs in the stdlib to make porting from Python 2 easier. So you might want to revert this :) -- nosy: +ber

[issue22642] trace module: convert to argparse

2016-01-13 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Senthil. My comment was for Vajrasky's patch, not for the whole argparse switch. We need to add tests for the old getopt code first to avoid regressions. After 0aa46b9ffba3, if we add tests we won't be able to test the old interface. My othe

[issue23762] python.org page on new-style classes should be updated

2016-01-13 Thread Berker Peksag
Berker Peksag added the comment: I've now added a warning to the document. -- stage: needs patch -> resolved status: pending -> closed ___ Python tracker <http://bugs.python.

[issue24203] Deprecate threading.Thread.isDaemon etc

2016-01-13 Thread Berker Peksag
Berker Peksag added the comment: The docs for old API already say: Old getter/setter API for name; use it directly as a property instead. https://docs.python.org/3.5/library/threading.html#threading.Thread.getName Users don't read the documentation every six or fifteen months so it

[issue26069] Remove the Deprecated API in trace module

2016-01-13 Thread Berker Peksag
Berker Peksag added the comment: Sorry, I don't have much time investigate this further, but here is a few references from my bookmarks: * http://bugs.python.org/msg253473 (from issue 20438) * https://hg.python.org/peps/rev/570913685f49 (this doesn't mention old APIs, but I th

[issue26149] Suggest PyCharm Community as an editor for Unix platforms

2016-01-18 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. It would be better to refer to https://wiki.python.org/moin/PythonEditors and https://wiki.python.org/moin/IntegratedDevelopmentEnvironments instead of maintaining duplicate and outdated lists. -- keywords: +easy nosy

[issue20556] Use specific asserts in threading tests

2016-01-18 Thread Berker Peksag
Berker Peksag added the comment: test_threading_asserts_2.patch looks good to me. -- nosy: +berker.peksag stage: patch review -> commit review versions: -Python 3.4 ___ Python tracker <http://bugs.python.org/issu

[issue25366] test_venv fails with --without-threads

2016-01-18 Thread Berker Peksag
Berker Peksag added the comment: Fixed. Thanks for the report, Arfrever -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: -Python 3.4 ___ Python tracker <http://

[issue5626] misleading comment in socket.gethostname() documentation

2016-01-19 Thread Berker Peksag
Berker Peksag added the comment: I agree with Chris and Ned. I will apply issue5626_v1.diff today. -- stage: -> commit review type: -> behavior versions: +Python 3.5, Python 3.6 -Python 2.6, Python 3.0, Python 3.1 ___ Python tracker

[issue26157] Typo in asyncio documentation

2016-01-19 Thread Berker Peksag
Berker Peksag added the comment: Thanks! I noticed another typo in the same file and fixed it. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: -Python 3.4 ___ Python tracker <http://bug

[issue10367] "python setup.py sdist upload --show-response" can fail with "UnboundLocalError: local variable 'result' referenced before assignment"

2016-01-19 Thread Berker Peksag
Berker Peksag added the comment: This has been fixed in issue 12853. The relevant line is here: https://hg.python.org/cpython/file/2.7/Lib/distutils/command/upload.py#l179 Closing this one as a duplicate. -- nosy: +berker.peksag resolution: -> duplicate stage: needs patch -> re

[issue5626] misleading comment in socket.gethostname() documentation

2016-01-19 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.o

[issue19225] lack of PyExc_BufferError doc

2016-01-19 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch type: behavior -> enhancement versions: +Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python.org/i

[issue21776] distutils.upload uses the wrong order of exceptions

2016-01-20 Thread Berker Peksag
Berker Peksag added the comment: Lib/distutils/command/upload.py has changed a bit after d86214c98a9c. Here is an updated patch. -- nosy: +berker.peksag stage: -> patch review versions: +Python 3.6 Added file: http://bugs.python.org/file41669/issue21776_v2.d

[issue18858] dummy_threading lacks threading.get_ident() equivalent

2016-01-20 Thread Berker Peksag
Berker Peksag added the comment: dummy_threading.get_ident() works for me: >>> import dummy_threading as dt >>> dt.get_ident() -1 >>> import threading >>> threading.get_ident() 140498493105920 Here is a patch to compare t

[issue26170] pip Crash on Unpacking in get_platform() line 119

2016-01-20 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> resolved type: crash -> behavior ___ Python tracker <http://bugs.python.org/issue26170> ___ ___ Python-bugs-list

[issue25704] Update the devguide to 3.5

2016-01-20 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Stéphane! Ned applied most of your patch in f53eac8da0b8. I left "sudo apt-get build-dep python3.4" as is since python3.5 is not available in the latest LTS release of Ubuntu. -- resolution: -> fixed stage: patch review ->

[issue22872] multiprocessing.Queue raises AssertionError

2016-01-20 Thread Berker Peksag
Berker Peksag added the comment: See issue 5001 for more general cleanup in multiprocessing. > [...] (2) altering the behavior in a new release version (perhaps 3.6 when it > comes) and documenting that change appropriately there. +1. We can also document AssertionError in older

[issue5001] Remove assertion-based checking in multiprocessing

2016-01-21 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag type: -> enhancement versions: +Python 3.6 -Python 2.7, Python 3.4, Python 3.5 ___ Python tracker <http://bugs.python.org/iss

[issue11551] test_dummy_thread.py test coverage improvement

2016-01-21 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Denver. Two things: 1. MockFunction needs to be replaced with unittest.mock.Mock. 2. Comments from Sandro and Ezio needs to be addressed. -- nosy: +berker.peksag stage: patch review -> needs patch versions: +Python 3.5, Python

[issue8690] multiprocessing.dummy.Queue does not expose same interface as multiprocessing.Queue

2016-01-21 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> needs patch type: -> enhancement versions: +Python 3.6 -Python 2.6, Python 2.7, Python 3.1, Python 3.2 ___ Python tracker <http://bugs.python.org/

[issue18620] multiprocessing page leaves out important part of Pool example

2016-01-21 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Davin. I tweaked code style a bit and removed trailing whitespaces. -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -P

[issue25830] _TypeAlias: Discrepancy between docstring and behavior

2016-01-21 Thread Berker Peksag
Berker Peksag added the comment: Looks like the docstring is a bit misleading. ``isinstance(m, Match)`` behavior is already tested in the test suite: https://hg.python.org/cpython/file/default/Lib/test/test_typing.py#l1297 -- nosy: +berker.peksag, gvanrossum

[issue21949] Document the Py_SIZE() macro.

2016-01-22 Thread Berker Peksag
Berker Peksag added the comment: Thanks for triaging! The relevant commit is 760c5cfacbaa. -- nosy: +berker.peksag resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bug

[issue25296] Simple End-of-life guide covering all unsupported versions

2016-01-24 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue25296> ___

[issue26034] venv documentation out of date

2016-01-27 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, Dan. Most of the docs has already been updated in c3c188a0325a. I've updated the remaining ones. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type

[issue26199] fix broken link to hamcrest.library.integration.match_equality in unittest.mock "getting started" documentation

2016-01-28 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Raphael! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: -Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python.or

[issue21201] Uninformative error message in multiprocessing.Manager()

2016-01-28 Thread Berker Peksag
Berker Peksag added the comment: Looks good to me. Perhaps we can use utils.info() to print the exception. -- nosy: +berker.peksag, davin stage: -> patch review versions: +Python 3.6 -Python 3.4 ___ Python tracker <http://bugs.python.org/issu

[issue26230] Cookies do not correct if cookiename includes [ or ]

2016-01-28 Thread Berker Peksag
Changes by Berker Peksag : -- stage: test needed -> resolved superseder: -> Regression in cookie parsing with brackets and quotes ___ Python tracker <http://bugs.python.org/i

[issue16731] xxlimited/xxmodule docstrings ambiguous

2016-01-28 Thread Berker Peksag
Berker Peksag added the comment: I think the difference between xxlimited and xxmodule is still a bit ambiguous. I would expect a mention of PEP 384 or a link to https://docs.python.org/3/c-api/stable.html to explain what Py_LIMITED_API really is. +#ifndef Py_LIMITED_API +# error "This

[issue24841] Some test_ssl network tests fail if svn.python.org is not accessible.

2016-01-28 Thread Berker Peksag
Berker Peksag added the comment: > although they will need updating since the Issue 24841 changeover to > pythontest.net. I think you meant issue 25940, right? :) Do you want me to wait for issue 25940? -- versions: -Python 3.4 ___ Python t

[issue24705] sysconfig._parse_makefile doesn't expand ${} vars appearing before $() vars

2016-01-28 Thread Berker Peksag
Berker Peksag added the comment: I've added a test case for ef84d21f5292. I think this can be closed now. Please reopen if not. -- nosy: +berker.peksag resolution: -> fixed stage: test needed -> resolved status: open -> closed ___

[issue26199] fix broken link to hamcrest.library.integration.match_equality in unittest.mock "getting started" documentation

2016-01-28 Thread Berker Peksag
Berker Peksag added the comment: 3.3 and 3.4 are in security-fix-only mode, which means they won't get bugfix and documentation updates anymore. See https://docs.python.org/devguide/devcycle.html for details. -- ___ Python tracker

[issue12912] xmlrpclib.__version__ not bumped with updates

2016-01-29 Thread Berker Peksag
Berker Peksag added the comment: xmlrpc.client.__version__ is used by Transport.user_agent and it has been changed to use sys.version[:3] in 197d703fb23e. It's too late for 2.7 so I think this can be closed now. Thanks for the report, Rob! -- nosy: +berker.peksag resolution: -

[issue26125] Incorrect error message in the module asyncio.selector_events.

2016-01-29 Thread Berker Peksag
Berker Peksag added the comment: https://github.com/python/asyncio/pull/313 has been merged. Do we need to commit this patch to the CPython repo or will it be merged with the next sync? (e.g. f4fe55dd5659) -- nosy: +berker.peksag ___ Python tracker

[issue26222] Missing code in linux_distribution python 2.7.11

2016-01-30 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue26222> ___ ___

[issue23076] list(pathlib.Path().glob("")) fails with IndexError

2016-01-30 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Thomas! > Though I've been reading the developer guide, I'm a bit unfamiliar with the > process here so I'm not totally sure I'm doing this right. You did everything right :) I just tweaked the test a bit. >

[issue26209] TypeError in smtpd module with string arguments

2016-01-30 Thread Berker Peksag
Berker Peksag added the comment: There is a strong change that smtpd is going to be deprecated in Python 3.6. See issue 25008 for details. +1 for improving documentation. -- assignee: -> docs@python components: +Documentation -Library (Lib) keywords: +easy nosy: +berker.peksag, d

[issue26242] reST formatting error in Doc/library/importlib.rst

2016-01-30 Thread Berker Peksag
Berker Peksag added the comment: I just fixed a similar one in 23cc4b894caf :) Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker <http://bug

[issue26245] AttributeError (GL_READ_WRITE) when importing OpenGL.GL

2016-01-31 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, Yoha. Your third example shows that this is either an error in PyOpenGL or there is something wrong in your PyOpenGL installation. Please report this to their issue tracker. -- nosy: +berker.peksag resolution: -> third pa

[issue26173] test_ssl.bad_cert_test() exception handling

2016-01-31 Thread Berker Peksag
Berker Peksag added the comment: Looks good to me. Thanks Martin. -- nosy: +berker.peksag stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issu

[issue26125] Incorrect error message in the module asyncio.selector_events.

2016-02-01 Thread Berker Peksag
Berker Peksag added the comment: Victor committed this in 97c80e317ab8 (3.5) and c7f1acdd8be1 (default). Closing as "fixed". -- resolution: -> fixed stage: commit review -> resolved status: open -> closed type: -> behavior versions: +Python 3.5,

[issue25788] fileinput.hook_encoded has no way to pass arguments to codecs

2016-02-02 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review ___ Python tracker <http://bugs.python.org/issue25788> ___ ___ Python-

[issue26243] zlib.compress level as keyword argument

2016-02-02 Thread Berker Peksag
Berker Peksag added the comment: There is an outdated patch in issue 16764 for zlib.compress(), zlib.decompress(), zlib.flush() and other functions. Perhaps we can close it as a duplicate of this one. -- nosy: +berker.peksag ___ Python tracker

[issue25660] tabs don't work correctly in python repl

2016-02-03 Thread Berker Peksag
Berker Peksag added the comment: With rlcompleter.patch applied, I see the same behavior on my OS X (with libedit) and Ubuntu (with readline) systems. Thanks! -- nosy: +berker.peksag stage: patch review -> commit review ___ Python tracker &l

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

2016-02-03 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue13501> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25660] tabs don't work correctly in python repl

2016-02-03 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Yury! Look like we forgot to update test_rcompleter: == FAIL: test_complete (test.test_rlcompleter.TestRlcompleter

[issue25660] tabs don't work correctly in python repl

2016-02-04 Thread Berker Peksag
Berker Peksag added the comment: Windows issue is a blocker so I suggest reverting 64417e7a1760. We could apply the same fix in readline.c for 3.5.x but it would probably be a bit hackish. -- ___ Python tracker <http://bugs.python.org/issue25

[issue6953] readline documentation needs work

2016-02-04 Thread Berker Peksag
Berker Peksag added the comment: Looks good to me. I left a comment on Rietveld. -- nosy: +berker.peksag versions: -Python 3.4 ___ Python tracker <http://bugs.python.org/issue6

[issue25195] mock.ANY doesn't match mock.MagicMock() object

2016-02-07 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +serhiy.storchaka ___ Python tracker <http://bugs.python.org/issue25195> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue25195] mock.ANY doesn't match mock.MagicMock() object

2016-02-07 Thread Berker Peksag
Berker Peksag added the comment: Looks like _Call is a subclass of tuple. Checks in the test could be written as "self.assertIs(a == b, True)". -- nosy: +berker.peksag stage: -> patch review versions: +Python 3.6 ___ Python t

[issue26198] PyArg_ParseTuple with format "et#" and "es#" detects overflow by raising TypeError instead of ValueError

2016-02-07 Thread Berker Peksag
Berker Peksag added the comment: test_datetime is broken on 3.5 and default: == FAIL: test_format (test.datetimetester.TestSubclassDateTime) -- TypeError

[issue26339] Python rk0.3b1 KeyError: 'config_argparse_rel_path'

2016-02-11 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, but both rk and configobj are not part of the Python standard library. Please use their issue tracker to report your problem. -- nosy: +berker.peksag resolution: -> not a bug stage: -> resolved status: open -&g

[issue19841] ConfigParser PEP issues

2016-02-14 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Ivailo. The following changes are going to break the public API: -def get(self, section, option, raw=False, vars=None): +def get(self, section, option, raw=False, vvars=None): -def items(self, section, raw=False

[issue26364] pip uses colour in messages that does not work on white terminals

2016-02-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, but this needs to be reported to the pip issue tracker: https://github.com/pypa/pip/issues For the record, I found a similar report at https://github.com/pypa/pip/issues/2449 -- nosy: +berker.peksag resolution: -> third pa

<    24   25   26   27   28   29   30   31   32   33   >