Berker Peksag added the comment:
I like Martin's support.expected_module_api() suggestion in msg247167. I still
find passing self to a function just to use assertCountEqual a bit weird, but I
can live with that.
--
___
Python tracker
Berker Peksag added the comment:
> The reason why I prefer the current API over my support.expected_module_api()
> idea is it requires the extra assertCountEqual() boilerplate at each call
> site.
I personally find explicit assert* calls in a test case more readable(e.g. I
don&
Berker Peksag added the comment:
htmllib_deprecation_warning_3.patch looks good to me.
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
nosy: +berker.peksag
versions: +Python 3.6 -Python 3.5
___
Python tracker
<http://bugs.python.org/issue3353>
___
___
Python-bug
Berker Peksag added the comment:
I don't think most of the version numbers are very important here and I
wouldn't change them unless there is a valid reason.
> -3.4 and 3.5, first fix it in ``3.4`` and then merge ``3.4`` into ``default``
> -(which holds the future 3.5).
>
Changes by Berker Peksag :
--
versions: -Python 3.6
___
Python tracker
<http://bugs.python.org/issue25704>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
> My first opinion when I have read the documentation was "but this doc is out
> of date".
Yes, some parts of the devguide is outdated and I already gave +1 to update
those parts. But most of the other changes are use 3.4 as an example so
ch
Berker Peksag added the comment:
Peter didn't write a test because issue 25497 (test_robotparser rewrite) needs
to be committed first. See msg253016 in issue 25400 for more information.
--
stage: needs patch -> patch review
___
Python tracke
Berker Peksag added the comment:
Thanks for reminding me of this issue, Brett. I have also updated numbers and
selectors docs to use the new directive.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6 -P
Berker Peksag added the comment:
We should probably delete the "will be removed in Python 3.7" part from the
deprecation message to make porting from Python 2 easier. For example, we will
add inspect.getargspec() back in 3.6. See i
Berker Peksag added the comment:
With the latest patch applied, the output is
File "z.py", line 2
1 + 2 = 3
^
SyntaxError: can't assign to operator
I think the caret is still in wrong place.
I would expect the following output:
File "z.py&qu
Berker Peksag added the comment:
I agree with David. I've added a "stream" attribute to InteractiveInterpreter.
I don't have a strong preference between a getstream method and a stream
attribute(or something different) so I will add documentation changes and tests
later.
Berker Peksag added the comment:
Thanks for the report!
Unfortunately,
self.write(prompt)
return input()
is not equivalent of ``return input(prompt)``. Could you give more information
about your use case?
--
nosy: +berker.peksag
Berker Peksag added the comment:
Thanks for the patch, Nan. I've updated your patch to apply Serhiy's advice.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.5
___
Py
Berker Peksag added the comment:
Thanks for fix_repetitions.diff, Torsten. The test_property failure was
discussed in issue 25755.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue25
Berker Peksag added the comment:
Thanks, Swati. I left a few comments on Rietveld:
http://bugs.python.org/review/25822/
A test wouldn't hurt, but you can wait for further review comments to avoid
updating tests each time you get a comment.
--
nosy: +berker.p
Berker Peksag added the comment:
This can be reproduced at https://docs.python.org/3/faq/windows.html
You can find the CSS file at Doc/tools/pydoctheme/static/pydoctheme.css. You
can override .highlight there, but the actual problem is that Sphinx creates
the outer highlight-python3 div with
Berker Peksag added the comment:
Thanks Serhiy. Can we close this now?
--
___
Python tracker
<http://bugs.python.org/issue6478>
___
___
Python-bugs-list mailin
Berker Peksag added the comment:
fix_repetitions.diff was unrelated to this issue so subprop_doc_r2.diff still
needs to be reviewed.
--
___
Python tracker
<http://bugs.python.org/issue25
Changes by Berker Peksag :
--
nosy: +davin
___
Python tracker
<http://bugs.python.org/issue5501>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue19771>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
+1 for deprecating them. Removing them would make porting code from Python 2
harder so I think it's better to keep them for a while.
--
components: +Library (Lib)
keywords: +patch
nosy: +berker.peksag
stage: -> patch review
title: De
Changes by Berker Peksag :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue21436>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.6 -Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
> Would it be appropriate to change this test so that instead of connecting to
> a remote server, we connect to a local server running in a background thread?
+1. We can host it at pythontest.net if needed. The repo is here:
https://hg.pyth
Berker Peksag added the comment:
ftpcp is undocumented and not part of the public API. It was added(changeset
https://hg.python.org/cpython/rev/63cdfbb4a2bb#l1.433) in 1996 and it looks
like its code was only touched for whitespace and PEP 8 fixes.
I think we need to decide whether we want
Berker Peksag added the comment:
Can we close this now?
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue25610>
___
___
Python-bugs-list m
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: -Python 3.4
___
Python tracker
<http://bugs.python.org/issue25794>
___
_
Berker Peksag added the comment:
bad_address.patch looks good to me.
--
nosy: +berker.peksag
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
The patch looks good to me.
_PyImport_FixupExtension does not exist in Python 3, but it's still documented
in Doc/c-api/import.rst. We need to remove it, too.
(Or we could document _PyImport_FixupExtensionObject since there are already
documented int
Berker Peksag added the comment:
Thanks koobs, this is a duplicate of issue 25940.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> SSL tests failed due to expired svn.python.org SSL
Changes by Berker Peksag :
--
keywords: +easy
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue25930>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
nosy: +eric.snow, serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue25935>
___
___
Python-bugs-list mailing list
Unsub
Berker Peksag added the comment:
Thanks for the patch, Alessandro. I left some comments about documentation part
of the patch, but I can fix them myself if you don't have time.
--
stage: commit review -> patch review
___
Python tracke
Berker Peksag added the comment:
Thanks for the patch, John.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
stage: -> needs patch
status: closed -> open
type: -> enhancement
versions: +Python 3.5
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thank you Ezio, I'll commit this tomorrow.
--
assignee: jhylton -> berker.peksag
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.o
Berker Peksag added the comment:
issue25802.diff looks good to me (just added a minor comment on Rietveld)
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue25
Changes by Berker Peksag :
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/issue25917>
___
___
Python-bugs-list mailing list
Unsubscrib
Berker Peksag added the comment:
Thanks, Senthil. I've just reverted fbea8ff8db5e. Sorry for the noise!
--
resolution: fixed ->
stage: resolved -> needs patch
status: closed -> open
___
Python tracker
<http://bugs.pyt
Berker Peksag added the comment:
Perhaps we can also add it back in 3.5.2 since 3.5 is in early stages of its
maintenance period?
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue25
Changes by Berker Peksag :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue26030>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
I'd prefer a more general solution similar to the one has been used in
Doc/conf.py
copyright = u'1990-%s, Python Software Foundation' % time.strftime('%Y')
--
nosy: +berker.peksag
Berker Peksag added the comment:
Thanks for the report, but this should be discussed either at
https://groups.google.com/forum/#!forum/pypa-dev or
https://github.com/pypa/pip/issues
--
nosy: +berker.peksag
resolution: -> third party
stage: -> resolved
status: open -&g
Berker Peksag added the comment:
I couldn't find exact references, but I think we've reached an agreement that
we want to keep old APIs in the stdlib to make porting from Python 2 easier. So
you might want to revert this :)
--
nosy: +ber
Berker Peksag added the comment:
Thanks, Senthil. My comment was for Vajrasky's patch, not for the whole
argparse switch. We need to add tests for the old getopt code first to avoid
regressions. After 0aa46b9ffba3, if we add tests we won't be able to test the
old interface.
My othe
Berker Peksag added the comment:
I've now added a warning to the document.
--
stage: needs patch -> resolved
status: pending -> closed
___
Python tracker
<http://bugs.python.
Berker Peksag added the comment:
The docs for old API already say:
Old getter/setter API for name; use it directly as a property instead.
https://docs.python.org/3.5/library/threading.html#threading.Thread.getName
Users don't read the documentation every six or fifteen months so it
Berker Peksag added the comment:
Sorry, I don't have much time investigate this further, but here is a few
references from my bookmarks:
* http://bugs.python.org/msg253473 (from issue 20438)
* https://hg.python.org/peps/rev/570913685f49 (this doesn't mention old APIs,
but I th
Berker Peksag added the comment:
Thanks for the report. It would be better to refer to
https://wiki.python.org/moin/PythonEditors and
https://wiki.python.org/moin/IntegratedDevelopmentEnvironments instead of
maintaining duplicate and outdated lists.
--
keywords: +easy
nosy
Berker Peksag added the comment:
test_threading_asserts_2.patch looks good to me.
--
nosy: +berker.peksag
stage: patch review -> commit review
versions: -Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Fixed. Thanks for the report, Arfrever
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
versions: -Python 3.4
___
Python tracker
<http://
Berker Peksag added the comment:
I agree with Chris and Ned. I will apply issue5626_v1.diff today.
--
stage: -> commit review
type: -> behavior
versions: +Python 3.5, Python 3.6 -Python 2.6, Python 3.0, Python 3.1
___
Python tracker
Berker Peksag added the comment:
Thanks! I noticed another typo in the same file and fixed it.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: -Python 3.4
___
Python tracker
<http://bug
Berker Peksag added the comment:
This has been fixed in issue 12853. The relevant line is here:
https://hg.python.org/cpython/file/2.7/Lib/distutils/command/upload.py#l179
Closing this one as a duplicate.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: needs patch -> re
Changes by Berker Peksag :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.o
Changes by Berker Peksag :
--
keywords: +easy
stage: -> needs patch
type: behavior -> enhancement
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Lib/distutils/command/upload.py has changed a bit after d86214c98a9c. Here is
an updated patch.
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.6
Added file: http://bugs.python.org/file41669/issue21776_v2.d
Berker Peksag added the comment:
dummy_threading.get_ident() works for me:
>>> import dummy_threading as dt
>>> dt.get_ident()
-1
>>> import threading
>>> threading.get_ident()
140498493105920
Here is a patch to compare t
Changes by Berker Peksag :
--
stage: -> resolved
type: crash -> behavior
___
Python tracker
<http://bugs.python.org/issue26170>
___
___
Python-bugs-list
Berker Peksag added the comment:
Thanks, Stéphane! Ned applied most of your patch in f53eac8da0b8. I left "sudo
apt-get build-dep python3.4" as is since python3.5 is not available in the
latest LTS release of Ubuntu.
--
resolution: -> fixed
stage: patch review ->
Berker Peksag added the comment:
See issue 5001 for more general cleanup in multiprocessing.
> [...] (2) altering the behavior in a new release version (perhaps 3.6 when it
> comes) and documenting that change appropriately there.
+1. We can also document AssertionError in older
Changes by Berker Peksag :
--
nosy: +berker.peksag
type: -> enhancement
versions: +Python 3.6 -Python 2.7, Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/iss
Berker Peksag added the comment:
Thanks for the patch, Denver.
Two things:
1. MockFunction needs to be replaced with unittest.mock.Mock.
2. Comments from Sandro and Ezio needs to be addressed.
--
nosy: +berker.peksag
stage: patch review -> needs patch
versions: +Python 3.5, Python
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> needs patch
type: -> enhancement
versions: +Python 3.6 -Python 2.6, Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/
Berker Peksag added the comment:
Thanks for the patch, Davin. I tweaked code style a bit and removed trailing
whitespaces.
--
nosy: +berker.peksag
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -P
Berker Peksag added the comment:
Looks like the docstring is a bit misleading. ``isinstance(m, Match)`` behavior
is already tested in the test suite:
https://hg.python.org/cpython/file/default/Lib/test/test_typing.py#l1297
--
nosy: +berker.peksag, gvanrossum
Berker Peksag added the comment:
Thanks for triaging! The relevant commit is 760c5cfacbaa.
--
nosy: +berker.peksag
resolution: -> out of date
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bug
Changes by Berker Peksag :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue25296>
___
Berker Peksag added the comment:
Thanks for the report, Dan. Most of the docs has already been updated in
c3c188a0325a. I've updated the remaining ones.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type
Berker Peksag added the comment:
Thanks for the patch, Raphael!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: -Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Looks good to me. Perhaps we can use utils.info() to print the exception.
--
nosy: +berker.peksag, davin
stage: -> patch review
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
stage: test needed -> resolved
superseder: -> Regression in cookie parsing with brackets and quotes
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
I think the difference between xxlimited and xxmodule is still a bit ambiguous.
I would expect a mention of PEP 384 or a link to
https://docs.python.org/3/c-api/stable.html to explain what Py_LIMITED_API
really is.
+#ifndef Py_LIMITED_API
+# error "This
Berker Peksag added the comment:
> although they will need updating since the Issue 24841 changeover to
> pythontest.net.
I think you meant issue 25940, right? :)
Do you want me to wait for issue 25940?
--
versions: -Python 3.4
___
Python t
Berker Peksag added the comment:
I've added a test case for ef84d21f5292. I think this can be closed now. Please
reopen if not.
--
nosy: +berker.peksag
resolution: -> fixed
stage: test needed -> resolved
status: open -> closed
___
Berker Peksag added the comment:
3.3 and 3.4 are in security-fix-only mode, which means they won't get bugfix
and documentation updates anymore. See
https://docs.python.org/devguide/devcycle.html for details.
--
___
Python tracker
Berker Peksag added the comment:
xmlrpc.client.__version__ is used by Transport.user_agent and it has been
changed to use sys.version[:3] in 197d703fb23e. It's too late for 2.7 so I
think this can be closed now.
Thanks for the report, Rob!
--
nosy: +berker.peksag
resolution: -
Berker Peksag added the comment:
https://github.com/python/asyncio/pull/313 has been merged. Do we need to
commit this patch to the CPython repo or will it be merged with the next sync?
(e.g. f4fe55dd5659)
--
nosy: +berker.peksag
___
Python tracker
Changes by Berker Peksag :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue26222>
___
___
Berker Peksag added the comment:
Thanks for the patch, Thomas!
> Though I've been reading the developer guide, I'm a bit unfamiliar with the
> process here so I'm not totally sure I'm doing this right.
You did everything right :) I just tweaked the test a bit.
>
Berker Peksag added the comment:
There is a strong change that smtpd is going to be deprecated in Python 3.6.
See issue 25008 for details.
+1 for improving documentation.
--
assignee: -> docs@python
components: +Documentation -Library (Lib)
keywords: +easy
nosy: +berker.peksag, d
Berker Peksag added the comment:
I just fixed a similar one in 23cc4b894caf :) Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.6
___
Python tracker
<http://bug
Berker Peksag added the comment:
Thanks for the report, Yoha. Your third example shows that this is either an
error in PyOpenGL or there is something wrong in your PyOpenGL installation.
Please report this to their issue tracker.
--
nosy: +berker.peksag
resolution: -> third pa
Berker Peksag added the comment:
Looks good to me. Thanks Martin.
--
nosy: +berker.peksag
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Victor committed this in 97c80e317ab8 (3.5) and c7f1acdd8be1 (default). Closing
as "fixed".
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
type: -> behavior
versions: +Python 3.5,
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue25788>
___
___
Python-
Berker Peksag added the comment:
There is an outdated patch in issue 16764 for zlib.compress(),
zlib.decompress(), zlib.flush() and other functions. Perhaps we can close it as
a duplicate of this one.
--
nosy: +berker.peksag
___
Python tracker
Berker Peksag added the comment:
With rlcompleter.patch applied, I see the same behavior on my OS X (with
libedit) and Ubuntu (with readline) systems.
Thanks!
--
nosy: +berker.peksag
stage: patch review -> commit review
___
Python tracker
&l
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue13501>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks, Yury!
Look like we forgot to update test_rcompleter:
==
FAIL: test_complete (test.test_rlcompleter.TestRlcompleter
Berker Peksag added the comment:
Windows issue is a blocker so I suggest reverting 64417e7a1760. We could apply
the same fix in readline.c for 3.5.x but it would probably be a bit hackish.
--
___
Python tracker
<http://bugs.python.org/issue25
Berker Peksag added the comment:
Looks good to me. I left a comment on Rietveld.
--
nosy: +berker.peksag
versions: -Python 3.4
___
Python tracker
<http://bugs.python.org/issue6
Changes by Berker Peksag :
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue25195>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Looks like _Call is a subclass of tuple. Checks in the test could be written as
"self.assertIs(a == b, True)".
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.6
___
Python t
Berker Peksag added the comment:
test_datetime is broken on 3.5 and default:
==
FAIL: test_format (test.datetimetester.TestSubclassDateTime)
--
TypeError
Berker Peksag added the comment:
Thanks for the report, but both rk and configobj are not part of the Python
standard library. Please use their issue tracker to report your problem.
--
nosy: +berker.peksag
resolution: -> not a bug
stage: -> resolved
status: open -&g
Berker Peksag added the comment:
Thanks for the patch, Ivailo.
The following changes are going to break the public API:
-def get(self, section, option, raw=False, vars=None):
+def get(self, section, option, raw=False, vvars=None):
-def items(self, section, raw=False
Berker Peksag added the comment:
Thanks for the report, but this needs to be reported to the pip issue tracker:
https://github.com/pypa/pip/issues
For the record, I found a similar report at
https://github.com/pypa/pip/issues/2449
--
nosy: +berker.peksag
resolution: -> third pa
2801 - 2900 of 3715 matches
Mail list logo