Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue23560>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue24292>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
This looks like a duplicate of issue 23810 (there is a patch for stdlib usages,
but it probably can be changed to a more general solution).
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue22852>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue24360>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue24270>
___
Berker Peksag added the comment:
Fixed! Thanks for the report, ramiro and thanks for the patch, Brandon.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.5, Python 3.6
___
Pytho
Berker Peksag added the comment:
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
The patch looks good to me, thanks! Could you also convert your test script to
a test case and add it in Lib/test/test_csv.py?
--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python
Changes by Berker Peksag :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue24391>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue14586>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks!
A few comments:
* New features like this can only go into Python 3.6 (the "default" branch)
* The CLI is partially tested (see Lib/test/test_webbrowser.py). You'll need to
add additional tests (e.g. add tests for the -t and -h options
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue24255>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks for the report. This is a duplicate of issue 20454.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> platform.linux_distribution() returns empty value on Archlinux
an
Changes by Berker Peksag :
--
nosy: +Nathan Ringo
___
Python tracker
<http://bugs.python.org/issue20454>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
stage: -> patch review
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue23981>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> needs patch
type: -> enhancement
___
Python tracker
<http://bugs.python.org/issue24416>
___
__
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue24420>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue24405>
___
___
Python-bugs-list mailing list
Unsubscrib
Berker Peksag added the comment:
Thanks Jaivish!
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the report, Chris.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Thanks for the reviews. Here is an updated patch.
--
Added file: http://bugs.python.org/file39703/issue23275_v2.diff
___
Python tracker
<http://bugs.python.org/issue23
Berker Peksag added the comment:
Ned is correct. I started to review the patch, but couldn't find time to do a
complete review. I'll take a look at it in a week or two. Thanks!
--
assignee: -> berker.peksag
___
Python t
Changes by Berker Peksag :
--
Removed message: http://bugs.python.org/msg245501
___
Python tracker
<http://bugs.python.org/issue24472>
___
___
Python-bugs-list m
Changes by Berker Peksag :
Removed file:
http://bugs.python.org/file39738/9F059BE32A3FC19A52978B2901172641.jpg
___
Python tracker
<http://bugs.python.org/issue24
Changes by Berker Peksag :
--
title: 石家庄小姐找上门全套服务 -> Spam
___
Python tracker
<http://bugs.python.org/issue24472>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
title: 南京小姐找上门全套服务 -> Spam
___
Python tracker
<http://bugs.python.org/issue24473>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Berker Peksag :
Removed file: http://bugs.python.org/file39739/12493721761041772378.jpg
___
Python tracker
<http://bugs.python.org/issue24473>
___
___
Pytho
Changes by Berker Peksag :
--
Removed message: http://bugs.python.org/msg245502
___
Python tracker
<http://bugs.python.org/issue24473>
___
___
Python-bugs-list m
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue4322>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python 3.6 -Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
LGTM. Added a minor question on Rietveld.
--
assignee: docs@python -> berker.peksag
nosy: +berker.peksag
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Thanks Martin.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the patch, Jakub. I've updated the patch to match ae1528beae67
(thanks Martin) and commit it.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Berker Peksag added the comment:
LGTM, too. I just left a comment on Rietveld.
Thanks!
--
___
Python tracker
<http://bugs.python.org/issue24420>
___
___
Pytho
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue18578>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
type: -> enhancement
versions: +Python 3.4, Python 3.5, Python 3.6 -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Thanks for the report, paul. Please do not ping an issue after a day.
Quoting from https://docs.python.org/devguide/patch.html?#reviewing
"If your patch has not received any notice from reviewers (i.e., no comment
made) after one month, first “ping” the
Changes by Berker Peksag :
--
assignee: -> berker.peksag
nosy: +takluyver
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue21697>
___
_
Berker Peksag added the comment:
Thanks for the report and the patch. This is a duplicate of issue 21697. Could
you please attach the patch in that issue?
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> shu
Berker Peksag added the comment:
Thanks for the report, Julien.
The up-to-date version of the document can be found at
https://docs.python.org/devguide/documenting.html
Also, Python 3.0.1 documentation is really old and I think the "The Python
documentation should follow the
Berker Peksag added the comment:
It would be nice to backport the patch to the 3.4 and 3.5 branches.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue23
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Thanks for the report, but openpyxl is not part of the Python standard library.
Please create an issue at https://bitbucket.org/openpyxl/openpyxl/issues
--
nosy: +berker.peksag
resolution: -> third party
stage: -> resolved
status: open -&g
Changes by Berker Peksag :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue24626>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue21750>
___
___
Python-bugs-list mailing list
Unsubscrib
Berker Peksag added the comment:
LGTM.
A minor comment:
+def test_mock_open_reuse_issue_21750(self):
We can also add an assert to check the data is actually "data" (e.g.
assertEqual(f1.read(), 'data')).
--
stage: patch rev
Berker Peksag added the comment:
> There are already explicit tests for that
Great, then the test is fine :) Thanks for writing the patch.
--
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
nosy: +berker.peksag
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issue21258>
___
___
Python-bugs-list mailin
Changes by Berker Peksag :
--
nosy: +kushal.das, ncoghlan, rbcollins
___
Python tracker
<http://bugs.python.org/issue24656>
___
___
Python-bugs-list mailin
Changes by Berker Peksag :
--
stage: commit review -> resolved
___
Python tracker
<http://bugs.python.org/issue24655>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
nosy: +yselivanov
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue24669>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
nosy: +berker.peksag
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue19667>
___
___
Python-bug
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue22123>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
I think we can commit documentation and tests separately. I just did a quick
review of the test changes and I will add some review comments later (sorry,
lack of time :)).
--
nosy: +berker.peksag
___
Python tracker
Berker Peksag added the comment:
Thank you all for your work and apologies for my lack of response.
I'm +1 on adding a check__all__ helper to test.support. But passing "self" to
it feels a bit weird. Perhaps the assertCountEqual part could be moved outside
of the helper. I
Changes by Berker Peksag :
--
assignee: -> berker.peksag
___
Python tracker
<http://bugs.python.org/issue23440>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
Thanks Martin and Demian.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
nosy: +rbcollins
___
Python tracker
<http://bugs.python.org/issue24695>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Here is a patch. I was pretty sure that I've already created an issue for this
but couldn't find it now.
--
keywords: +patch
nosy: +berker.peksag
stage: needs patch -> patch review
Added file: http://bugs.python.org/file40001/is
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue10708>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
stage: resolved -> needs patch
superseder: datetime: add ability to parse RFC 3339 dates and times ->
versions: +Python 3.6 -Python 3.5
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Fixed in 3.5 and default branches. Thank you for your review, Raymond.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Applied it with minor changes. Thanks for the great patch, Paul Anton Letnes.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Berker Peksag:
>From
>http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.x/builds/2436:
python: Python/pytime.c:633: pymonotonic_new: Assertion `!last_set || last <=
*tp' failed.
Fatal Python error: Aborted
Full log is here:
http://buildbot.
New submission from Berker Peksag:
Here is a patch that changes to use cls() instead of hardcoded
TracebackException.
Serhiy also suggested on IRC to use the from_exception() classmethod in
TracebackException's __init__ method.
--
components: Library (Lib)
files: classmethod
Berker Peksag added the comment:
Thanks for the report and the patch, Petr.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks Christie. I've kept get_output() and changed it to return
assert_python_ok().out.
--
components: +Tests
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> enhancement
vers
Berker Peksag added the comment:
Thanks Martin.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the patches and testing!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
This is a duplicate of issue 24272.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> PEP 484 docs
___
Python tracker
<http://bugs.python
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python 3.6
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Could you please share the link of the changelog you've mentioned? Unless I'm
missing something, this issue is already listed in the changelog:
https://hg.python.org/releasing/3.5/file/f65605b99cb4/Mis
Berker Peksag added the comment:
Here is a patch with a simple test case.
--
nosy: +berker.peksag
stage: commit review -> patch review
versions: +Python 3.6
Added file: http://bugs.python.org/file40032/issue23441.diff
___
Python tracker
&l
Berker Peksag added the comment:
Looks like a cache issue. I've just fixed it:
https://docs.python.org/3.5/whatsnew/changelog.html
--
___
Python tracker
<http://bugs.python.org/is
Berker Peksag added the comment:
Thanks Louis. If you are going to continue contributing patches, please sign
the PSF Contribution Agreement: https://www.python.org/psf/contrib/contrib-form/
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -&g
Berker Peksag added the comment:
Thanks for the patch Martin and thank you all for testing and reviewing patches!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
stage: commit review -> needs patch
___
Python tracker
<http://bugs.python.org/issue23931>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
Looks great! Thank you Tina and Carol :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue24735>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
Patch LGTM. Thanks Carol.
I will left this issue open in case someone wants to work on a git equivalent
of "make touch" as described by Ned in msg235514.
--
components: -Devguide
nosy: +berker.peksag
stage: patch review -> nee
Changes by Berker Peksag :
--
assignee: -> berker.peksag
___
Python tracker
<http://bugs.python.org/issue24360>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
Thanks for the patch, Matthias.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks Keith.
--
nosy: +berker.peksag
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
versions: +Python 3.6
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Applied, thanks!
--
nosy: +berker.peksag
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Thanks for the patch, Nick!
--
nosy: +berker.peksag
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
type: -> behavior
versions: +Python 3.5, Python 3.6 -Python 3.1, Python 3.2
__
Berker Peksag added the comment:
Also, I'd change the patch to use a note directive.
--
nosy: +berker.peksag
stage: commit review -> patch review
___
Python tracker
<http://bugs.python.org
Berker Peksag added the comment:
Here is an updated patch (against 3.4 branch). I've just made some small
cosmetic changes and split the test into two parts (filterwarnings and
simplefilter). Patch looks reasonable to me, but it would be nice to get a
second opinion.
--
Added
Berker Peksag added the comment:
Thanks, Alessandro! I left some additional comments on Rietveld:
https://bugs.python.org/review/19475/#ps15278
--
nosy: +berker.peksag
stage: needs patch -> patch review
___
Python tracker
<http://bugs.pyth
Berker Peksag added the comment:
Thanks for the report. Some functions like getrefcount in sys module are
specific to CPython. Other Python implementations like IronPython(it doesn't
use reference counting for example) may not implement or partially implement
those functions.
sys.getref
Berker Peksag added the comment:
Here is a patch for 2.7. I don't think backporting 9eceb618274a to 2.7 is
worth the effort for this, so I just fixed the __getattr__ method and added a
test.
--
keywords: +patch
nosy: +berker.peksag
stage: needs patch -> patch review
Added fi
Berker Peksag added the comment:
Sorry for my late response, Ilia. Your reply to my first question looks correct
to me. Please send your updated patch and I'll apply.
--
assignee: -> berker.peksag
versions: +Python 3.4, Python 3.6
__
Berker Peksag added the comment:
This is a duplicate of issue 24755.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> asyncio.wrap_future undocumented
___
Python tr
Changes by Berker Peksag :
--
assignee: -> berker.peksag
___
Python tracker
<http://bugs.python.org/issue23004>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
Thanks for the patch, Aaron(also thanks to Demian for reviews). I've fixed the
merge conflict and added more tests.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Berker Peksag added the comment:
data_as_list = read_data.splitlines(True)
is not actually the equivalent of
data_as_list = [l + sep for l in read_data.split(sep)]
It will change the behavior of the _iterate_read_data helper. See the comment
at
https://github.com/python/cpython/blob
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
type: -> behavior
versions: -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/i
2601 - 2700 of 3715 matches
Mail list logo