Berker Peksag added the comment:
+self.assertDictEqual(self.conn._tunnel_headers, tunnel_headers)
You could just use assertEqual. Quoting from docs:
"The list of type-specific methods automatically used by assertEqual() are
summarized in the following table. Note that it’s us
Berker Peksag added the comment:
LGTM.
--
___
Python tracker
<http://bugs.python.org/issue23300>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue21279>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
I've updated the patch for 3.5. I also have cleaned-up the documentation to
avoid duplicate content.
--
components: +Library (Lib) -XML
nosy: +berker.peksag
versions: +Python 3.5 -Python 3.4
Added file: http://bugs.python.org/file37860/issue1745722
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue11822>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue8796>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
versions: +Python 3.4, Python 3.5 -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issue15
Berker Peksag added the comment:
The second example was removed in
https://hg.python.org/cpython/rev/19ca70b463c5 It would be better to just
update the "see also" note in the token documentation.
--
keywords: +easy
nosy: +berker.peksag
stage: -> needs patch
versions:
Berker Peksag added the comment:
Fixed. Thanks for the patch!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue22671>
___
___
Python-
Berker Peksag added the comment:
Welcome, please go ahead and send a patch. Thanks!
--
___
Python tracker
<http://bugs.python.org/issue23322>
___
___
Python-bug
Berker Peksag added the comment:
Thanks for the updated patch. I will tweak the docs before I commit the patch.
--
___
Python tracker
<http://bugs.python.org/issue23
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue2504>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
issue19681_2.patch LGTM.
--
nosy: +berker.peksag
stage: patch review -> commit review
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Thanks for the patch! Could you revert unrelated changes (whitespaces, PEP 8
etc.) if you have time?
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue23334>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
resolution: -> duplicate
stage: -> resolved
superseder: -> cookies with square brackets in value
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Looks like "error" was unused since
https://hg.python.org/cpython/rev/acdc0b9a6c78#l2.48 (see also
https://hg.python.org/cpython/rev/6ee380349c84/ for time.gmtime()). LGTM.
--
nosy: +berker.peksag
stage: ->
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue18982>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue13330>
___
___
Python-bugs-list mailin
Berker Peksag added the comment:
Thanks! Apparently, we were working on the same issue simultaneously. I was
working on the HTML and CSS parts (didn't touch to Lib/pydoc.py yet). I can
combine our work, if you could
- create a separate branch (no need to be a Hg repo, I can create a
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue12707>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue18982>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
nosy: +berker.peksag
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issue20169>
___
___
Python-bug
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Thanks for the patch, Martin. I got the following failure on the 3.4 branch:
==
FAIL: test_all (test.test_socketserver.SimpleTests
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
type: -> enhancement
versions: +Python 3.4, Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Thanks for the report. This is a duplicate of issue 13051. The insert_mode
parameter was committed in issue 1048820.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Infinite
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue23254>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
nosy: +vinay.sajip
stage: -> patch review
versions: -Python 3.6
___
Python tracker
<http://bugs.python.org/issue23357>
___
_
Berker Peksag added the comment:
Thanks for the patch, Martin.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> snmp - mib error
___
Python tracker
<http://bugs.python
Berker Peksag added the comment:
Thanks for the patch, Demian. I've simplified the test code a bit and committed
it. Also, thanks for the report and for the initial patch Matt.
--
resolution: -> fixed
stage: commit review -> resolved
status: ope
Berker Peksag added the comment:
Thanks for the report, Jonathan. This is a website issue, so I've created a new
issue on GitHub: https://github.com/python/pythondotorg/issues/561
--
nosy: +berker.peksag
resolution: -> third party
stage: -> resolved
status: ope
New submission from Berker Peksag:
==
ERROR: test_issue16464 (test.test_urllib2.MiscTests)
--
Traceback (most recent call last):
File
"/ssd/bui
Berker Peksag added the comment:
I've opened https://github.com/python/pythondotorg/issues/561 to track the same
issue.
--
___
Python tracker
<http://bugs.python.org/is
Berker Peksag added the comment:
Here's an updated patch. Thank you Serhiy.
--
Added file: http://bugs.python.org/file38017/issue20289_v2.diff
___
Python tracker
<http://bugs.python.org/is
Berker Peksag added the comment:
The patch LGTM.
In Doc/library/argparse.rst:
- add_help=True)
+ allow_abbrev=True, add_help=True)
should be
add_help=True, allow_abbrev=True)
I'll add a release note and commit it. T
New submission from Berker Peksag:
I have an outdated and WIP patch to implement PEP 431 on GitHub:
https://github.com/berkerpeksag/cpython Hopefully, I will complete my work
before beta 1.
--
assignee: berker.peksag
components: Library (Lib)
messages: 235423
nosy: berker.peksag
Berker Peksag added the comment:
Thanks for the review, Serhiy!
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Here's an updated patch. Thanks Serhiy.
--
Added file: http://bugs.python.org/file38025/issue21717_v2.diff
___
Python tracker
<http://bugs.python.org/is
Changes by Berker Peksag :
--
nosy: +lregebro
___
Python tracker
<http://bugs.python.org/issue23397>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
LGTM.
--
nosy: +berker.peksag
stage: -> commit review
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Updated patch. Thanks again, Serhiy.
--
Added file: http://bugs.python.org/file38081/issue21717_tarfile_v3.diff
___
Python tracker
<http://bugs.python.org/issue21
New submission from Berker Peksag:
>From https://docs.python.org/3/library/exceptions.html#SystemExit
Also, this exception derives directly from BaseException and not Exception,
since it is not technically an error.
and
The exception inherits from BaseException instead of Except
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue1508475>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue23442>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Good catch, thanks! Do you have better wording for that part of the patch?
--
___
Python tracker
<http://bugs.python.org/issue23
Changes by Berker Peksag :
Added file: http://bugs.python.org/file38095/issue21717_tarfile_v4.diff
___
Python tracker
<http://bugs.python.org/issue21717>
___
___
Pytho
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
It's not that important in my opinion. Let's keep it simple for now :)
--
___
Python tracker
<http://bugs.python.o
Berker Peksag added the comment:
The change was suggested before PEP in issue 4718 (see msg78292), but PEP
says:
A server should allow read() to be called without an argument, and return
the remainder of the client's input stream.
https://www.python.org/dev/peps/pep-/#
Changes by Berker Peksag :
Added file: http://bugs.python.org/file38115/issue21717_tarfile_v5.diff
___
Python tracker
<http://bugs.python.org/issue21717>
___
___
Pytho
Berker Peksag added the comment:
I found another regression: In Python 3.4, 416 is
REQUESTED_RANGE_NOT_SATISFIABLE, but REQUEST_RANGE_NOT_SATISFIABLE in 3.5.
--
nosy: +berker.peksag
stage: -> patch review
___
Python tracker
<http://bugs.pyth
Berker Peksag added the comment:
Here is a test case.
==
FAIL: test_client_constants (test.test_httplib.OfflineTest)
(constant='REQUESTED_RANGE_NOT_SATISF
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue5053>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Fixed. Thanks Martin (also thanks to Demian for the review).
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the review, Serhiy. I'll take a look at the zipfile patch tomorrow.
--
___
Python tracker
<http://bugs.python.org/is
Berker Peksag added the comment:
Here is an updated patch. For InputWrapper.read(), see issue 18610.
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.4, Python 3.5 -Python 3.3
Added file: http://bugs.python.org/file38131/issue14652.d
Berker Peksag added the comment:
LGTM.
--
nosy: +berker.peksag
stage: -> commit review
versions: +Python 2.7, Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
I'm not sure this needs to be fixed in 2.7. I would only use demo_app to test
WSGI servers. Otherwise, you need to create your own application. However, the
code is correct in Python 3:
https://hg.python.org/cpython/file/default/Lib/wsgiref/simple_serv
Berker Peksag added the comment:
Committed. Thank you all for patches and reviews :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
The binascii documentation already says
``a2b_*`` functions accept Unicode strings containing only ASCII characters.
[...]
.. versionchanged:: 3.3
ASCII-only unicode strings are now accepted by the ``a2b_*`` functions.
I think we can just remove
Berker Peksag added the comment:
LGTM.
--
nosy: +berker.peksag
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue17753>
___
_
Changes by Berker Peksag :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue22735>
___
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue23399>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
keywords: +easy
stage: -> needs patch
type: -> enhancement
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/i
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue12955>
___
___
Python-
Changes by Berker Peksag :
--
components: +Library (Lib) -Extension Modules
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.o
Berker Peksag added the comment:
Thank you to both Vajrasky and Martin.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Can this be closed now?
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue15381>
___
___
Python-bugs-list m
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue20059>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue23430>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
Thanks for the patch, Davin. I left a couple of comments on Rietveld.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue23
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue23440>
___
_
Berker Peksag added the comment:
Thanks for the patch! I'm -1 to adding IDE/editor specific files to .hgignore.
You can create a global .hgignore instead.
--
nosy: +berker.peksag
resolution: -> wont fix
stage: patch review -> resolved
status: ope
New submission from Berker Peksag:
Config/plugin/readme files for Emacs and Vim in Misc have been deleted. The
only remaining ones are for Wing IDE. Here is a patch to remove these files.
--
files: wpr.diff
keywords: patch
messages: 236082
nosy: berker.peksag
priority: normal
severity
Berker Peksag added the comment:
Buildbots are not happy:
==
ERROR: test_write_filtered_python_package (test.test_zipfile.PyZipFileTests)
--
Traceback (most
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue22071>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue10818>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
pydocgui.pyw was removed in https://hg.python.org/cpython/rev/2e578b80c2f3.
msi.py was updated in issue 14512. Closing this as "out of date".
--
nosy: +berker.peksag
resolution: -> out of date
stage: -> resolved
status
Changes by Berker Peksag :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue14512>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
I thought this was fixed by issue 22484
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue23471>
___
___
Changes by Berker Peksag :
--
nosy: +larry
___
Python tracker
<http://bugs.python.org/issue23471>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue23410>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue23477>
___
_
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: test needed -> patch review
___
Python tracker
<http://bugs.python.org/issue2211>
___
___
Python-
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue3609>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Committed now. Thanks for the patch, Martin and thanks for the review, Demian.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
This is a different issue than #23439. BaseHTTPRequestHandler.headers
documentation mentions about parse_headers function, the function itself is not
documented. See
https://docs.python.org/3/library/http.server.html#http.server.BaseHTTPRequestHandler.headers
Berker Peksag added the comment:
> Terry, would you like to move this forward with the Python.org webmasters ?
This is now a content issue and can be handled on GitHub:
https://github.com/python/pythondotorg/issues
--
nosy: +berker.peksag
resolution: -> fixed
stage: needs
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue23350>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: -Python 3.6
___
Python tracker
<http://bugs.python.org/issue22928>
___
_
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: -Python 3.3, Python 3.6
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Fixed. Thanks to both of you :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
LGTM. I left a comment for Serhiy on Rietveld.
--
stage: needs patch -> commit review
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
nosy: +davin, sbt
___
Python tracker
<http://bugs.python.org/issue23489>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
resolution: -> duplicate
stage: needs patch -> resolved
status: open -> closed
superseder: -> PEP 489 -- Multi-phase extension module initialization
___
Python tracker
<http://bugs.python
2501 - 2600 of 3715 matches
Mail list logo