Berker Peksag added the comment:
Thanks for the patch, Thomas.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Berker Peksag:
This is similar to issue 21338.
It would be good to add a new option "-q" to the CLI interface and add a new
parameter "quiet" to py_compile.compile() (e.g. if doraise is False and quiet
is True, do not print anything).
--
ass
Berker Peksag added the comment:
+ self.assertTrue(socket.SocketType is _socket.socket)
You can use assertIs instead of assertTrue.
--
nosy: +berker.peksag
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issue20
Changes by Berker Peksag :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue21991>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue22645>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue22650>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
> 3.4.3 then? Are we still happy with the patch?
Please see msg218727. The patch is not ready yet.
--
nosy: +rbcollins
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
Added file: http://bugs.python.org/file36951/issue22596_v2.diff
___
Python tracker
<http://bugs.python.org/issue22596>
___
___
Python-bug
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> commit review
___
Python tracker
<http://bugs.python.org/issue22186>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue21417>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
The actual signature is now
socket.socket(family=AF_INET, type=SOCK_STREAM, proto=0, fileno=None)
but, the fileno argument still needs to be documented.
--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python 3.5 -Python
Berker Peksag added the comment:
Here is a patch. I also added SameFileError.
--
assignee: -> berker.peksag
keywords: +patch
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.5
Added file: http://bugs.python.org/file36969/issue2266
Berker Peksag added the comment:
Here is a patch for 2.7.
--
nosy: +berker.peksag
stage: needs patch -> patch review
Added file: http://bugs.python.org/file36970/issue16041_27.diff
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
Added file: http://bugs.python.org/file36971/issue16041_27.diff
___
Python tracker
<http://bugs.python.org/issue16041>
___
___
Python-bug
Changes by Berker Peksag :
Removed file: http://bugs.python.org/file36970/issue16041_27.diff
___
Python tracker
<http://bugs.python.org/issue16041>
___
___
Python-bug
Berker Peksag added the comment:
Thanks for the patch, Févry.
--
assignee: rhettinger -> berker.peksag
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
versions: +Python 3.4, Python 3.5
___
Python tr
Changes by Berker Peksag :
--
stage: needs patch -> patch review
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue22642>
___
___
Pyth
Changes by Berker Peksag :
--
stage: -> needs patch
type: performance -> enhancement
___
Python tracker
<http://bugs.python.org/issue21949>
___
___
Pyth
Changes by Berker Peksag :
--
components: +Interpreter Core -Library (Lib)
stage: -> patch review
type: -> enhancement
versions: +Python 3.5 -Python 3.4
___
Python tracker
<http://bugs.python.org/i
Changes by Berker Peksag :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue17401>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue11260>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
keywords: +easy
nosy: +berker.peksag
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue16863>
___
___
Python-
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue7559>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue22592>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue22695>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue22715>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
nosy: +berker.peksag, georg.brandl
___
Python tracker
<http://bugs.python.org/issue22723>
___
___
Python-bugs-list mailing list
Unsub
Berker Peksag added the comment:
Thanks for the patch, Buck.
--
assignee: docs@python -> berker.peksag
stage: -> resolved
type: -> enhancement
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue22723>
___
___
Python-bugs-list
Berker Peksag added the comment:
Thanks for the review, Ned. I didn't combine the patch with issue 22289,
because I couldn't reproduce that failure easily.
--
assignee: -> berker.peksag
resolution: -> fixed
stage: patch review -> resolved
sta
Berker Peksag added the comment:
There are two disabled tests in Lib/test/test_urllib2net.py:
* OtherNetworkTests.test_cnri:
# XXX Following test depends on machine configurations that are internal
# to CNRI. Need to set up a public server with the right authentication
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue10116>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Berker Peksag:
"Porting Extension Modules to Python 3" document mention about "PyString_*"
functions in Python 3. I think the correct prefix should be "PyUnicode_*".
>From https://docs.python.org/3/howto/cporting.html#str-unicode-
Changes by Berker Peksag :
--
nosy: +ezio.melotti, michael.foord
___
Python tracker
<http://bugs.python.org/issue22756>
___
___
Python-bugs-list mailing list
Unsub
Berker Peksag added the comment:
"verbose" was used by _call_external_zip() (see
https://hg.python.org/cpython/rev/a1d078b88247#l3.143), and
_call_external_zip() was removed in issue 20744 (see
https://hg.python.org/cpython/rev/681e20f8b717).
Perhaps we can deprecate "versio
Changes by Berker Peksag :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue22613>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
stage: -> patch review
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue22775>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
Thanks for the patch, Matt. Have you signed a contributor's agreement? You can
find it at https://www.python.org/psf/contrib/contrib-form/
--
assignee: -> berker.peksag
priority: release blocker -> normal
resolution: -> fixed
stage
Berker Peksag added the comment:
I agree with Martin. Plus, this method already used by other tests (see
Lib/test/test_nntplib.py and Lib/test/test_warnings.py for example).
--
___
Python tracker
<http://bugs.python.org/issue22
Berker Peksag added the comment:
Thanks for the report, Martin.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Updated patch. I've tweaked tests and documentation a bit. Alternatively, I can
leave Doc/distutils/setupscript.rst untouched and add a whatsnew entry to
Doc/whatsnew/3.5.rst.
--
Added file: http://bugs.python.org/file37097/issue19610_v2
Berker Peksag added the comment:
Attached patch should fix the deprecated-removed directive. I've tested it with
the following examples:
.. deprecated-removed:: 3.4 4.0
The ``'U'`` mode.
.. deprecated-removed:: 3.4 4.0
The ``'U'`` mode.
.. dep
Berker Peksag added the comment:
I think my patch is wrong.
test_weak_destroy_while_iterating and
test_weak_destroy_and_mutate_while_iterating tests were committed as part of
issue 7105 to 2.7 (see changeset
https://hg.python.org/cpython/rev/03fcc12282fc). But, those same tests(they
uses
Berker Peksag added the comment:
Here is a new patch. Thanks for the review, Serhiy.
--
Added file: http://bugs.python.org/file37105/issue22695_v2.diff
___
Python tracker
<http://bugs.python.org/issue22
Changes by Berker Peksag :
--
nosy: +berker.peksag
versions: +Python 3.5 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue9771>
___
___
Python-bug
Changes by Berker Peksag :
--
nosy: +paul.j3
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issue22317>
___
___
Python-bugs-list m
Berker Peksag added the comment:
Thanks for the suggestions.
> If you mean preserve order by default, then yes that would be a nice default.
issue21650_v3.diff implements this idea.
--
Added file: http://bugs.python.org/file37110/issue21650_v3.d
Changes by Berker Peksag :
Added file: http://bugs.python.org/file37119/issue21650_v4.diff
___
Python tracker
<http://bugs.python.org/issue21650>
___
___
Python-bug
Changes by Berker Peksag :
--
nosy: +berker.peksag, serhiy.storchaka
versions: +Python 3.4, Python 3.5 -Python 3.6
___
Python tracker
<http://bugs.python.org/issue22
Changes by Berker Peksag :
--
stage: -> patch review
versions: -Python 3.6
___
Python tracker
<http://bugs.python.org/issue22668>
___
___
Python-bugs-list mai
Changes by Berker Peksag :
--
components: +asyncio
nosy: +gvanrossum, haypo, yselivanov
stage: -> patch review
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
Removed message: http://bugs.python.org/msg230818
___
Python tracker
<http://bugs.python.org/issue22816>
___
___
Python-bugs-list m
Berker Peksag added the comment:
Committed. Thanks for the patch, Mark.
--
nosy: +berker.peksag
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Fixed. Thanks for the reviews.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue22824>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Here's a patch to use set literals and frozenset({'a'}) in reprlib.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file37163/issue22824.diff
___
Pyt
Berker Peksag added the comment:
Thanks for the review, Raymond. Patch updated:
- Updated the documentation
- Added two test cases for set literals
- Replaced old run_unittest calls with ``unittest.main()``
--
Added file: http://bugs.python.org/file37164/issue22824_v2.diff
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue22824>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
issue17554-urlfetch.diff LGTM.
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Thanks for the reviews.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Fixed. Thanks for the report, Jonathan.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
versions: -Python 3.6
___
Python tracker
<http://
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue21514>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +ncoghlan, serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue22849>
___
___
Python-bugs-list mailing list
Unsub
Changes by Berker Peksag :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
issue 13211 was about a bug in exception hierarchy of the urllib2 module(not an
addition to the public API - see msg147318 for detailed explanation). I don't
think we need to update documentation.
--
resolution: -> wont fix
stage: patc
Changes by Berker Peksag :
--
nosy: +paul.j3
___
Python tracker
<http://bugs.python.org/issue22848>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
stage: -> resolved
___
Python tracker
<http://bugs.python.org/issue22868>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue22536>
___
_
Berker Peksag added the comment:
Thanks for the report, but the signature is correct.
>From https://docs.python.org/devguide/documenting.html#information-units
"The signature should include the parameters, enclosing optional parameters
in brackets."
See also http://s
Changes by Berker Peksag :
--
nosy: +orsenthil
stage: -> patch review
title: [patch]: code removal from urllib.parse.urlsplit() -> code removal from
urllib.parse.urlsplit()
versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4, Pyth
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue20215>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
Can we close this and issue22176 then?
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue20885>
___
___
Changes by Berker Peksag :
--
stage: -> patch review
type: -> enhancement
___
Python tracker
<http://bugs.python.org/issue22914>
___
___
Python-bugs-list
Changes by Berker Peksag :
--
versions: +Python 3.4, Python 3.5
___
Python tracker
<http://bugs.python.org/issue21815>
___
___
Python-bugs-list mailing list
Unsub
Berker Peksag added the comment:
Thanks for the patch, but we don't backport new features to 2.7 unless they are
related to PEP 434 and PEP 466. Please send your patch to
https://bitbucket.org/ncoghlan/contextlib2
--
nosy: +berker.peksag
resolution: -> wont fix
stage: -&g
Changes by Berker Peksag :
--
components: +Library (Lib) -Build
___
Python tracker
<http://bugs.python.org/issue22925>
___
___
Python-bugs-list mailing list
Unsub
Berker Peksag added the comment:
Thanks for the patch, Joseph.
--
assignee: -> berker.peksag
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> enhancement
___
Python tracker
<http
Berker Peksag added the comment:
Thanks for the patch, Charles-Axel.
--
assignee: rhettinger -> berker.peksag
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Berker Peksag :
--
assignee: -> berker.peksag
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Berker Peksag :
--
nosy: +ncoghlan, pmoody
___
Python tracker
<http://bugs.python.org/issue22941>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Tutorial and FAQ: how to call a method on an int
___
Python tracker
<http://bugs.python
Changes by Berker Peksag :
--
nosy: +steve.dower
___
Python tracker
<http://bugs.python.org/issue22953>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +sbt
stage: -> patch review
type: behavior -> enhancement
versions: +Python 3.5 -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/i
Changes by Berker Peksag :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the report. This has already been reported at
https://github.com/python/pythondotorg/issues/510.
--
nosy: +berker.peksag
resolution: -> third party
stage: -> resolved
status: open -> closed
_
Changes by Berker Peksag :
--
nosy: +ncoghlan, pmoody
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issue22962>
___
___
Python-bugs-list mailin
Changes by Berker Peksag :
--
assignee: rhettinger -> berker.peksag
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> needs patch
type: -> enhancement
versions: +Python 3.5 -Python 3.4
___
Python tracker
<http://bugs.python.org/i
Changes by Berker Peksag :
--
stage: -> resolved
status: open -> closed
superseder: -> Argparse considers unknown optional arguments with spaces as a
known positional argument
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue22966>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
resolution: -> duplicate
stage: -> resolved
superseder: -> Possible implementation of negative limit for traceback
functions
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
+The workflow of a developer might look something like this:
"a core developer" or "a contributor"? It would be good to split core developer
and contributor workflows.
+# address review comments and merge
+git checkout master
+
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue14134>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
I left a couple of comments on Rietveld.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue16837>
___
___
Berker Peksag added the comment:
I left a couple of comments on Rietveld. Thanks for the patch, Demian.
--
___
Python tracker
<http://bugs.python.org/issue21
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue22768>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
+# address review comments and merge
You can remove the "and merge" part.
+# generate patch for submission
+git diff master..issueA > issueA.patch
Contributors may need to update their repos before this step. It would be good
to add
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue22914>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: -Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue22153>
___
___
Python-
2301 - 2400 of 3715 matches
Mail list logo