Berker Peksag added the comment:
Thanks! Is there a reason not to use inspect.isdatadescriptor() instead of
_is_data_descriptor()?
--
stage: commit review -> resolved
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Thanks, Sahil.
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
type: -> behavior
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python
Changes by Berker Peksag :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue26209>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
title: [Patch] Only use SOCK_RAW when defined -> Only use SOCK_RAW when defined
type: -> enhancement
___
Changes by Berker Peksag :
--
stage: needs patch -> patch review
versions: -Python 3.5
___
Python tracker
<http://bugs.python.org/issue26081>
___
___
Python-
Berker Peksag added the comment:
This looks pretty good to me, thanks! I have two minor suggestions:
1. It would be better to make "Quick search" a placeholder:
2. will add an unnecessary border in search page. I'd change
it to
Also,
+form.inli
Berker Peksag added the comment:
Thanks for the patch. Two things:
* We want to keep docstrings short so could you please revert the changes in
Lib/configparser.py?
* It would be better to just add an example of escaping these characters in the
"Interpolation of values" section (
Berker Peksag added the comment:
Could you also update documentation in Doc/distutils/apiref.rst?
Also, test_strtobool in Lib/distutils/tests/test_util.py doesn't test the
following case:
>>> from distutils.util import strtobool
>>> strtobool('x')
Berker Peksag added the comment:
Thank you for your detailed report! Would you like to propose a patch?
This behavior is already tested in testAttributes in
Lib/test/test_exceptions.py so we just need a documentation patch.
--
keywords: +easy
nosy: +berker.peksag
stage: -> ne
Changes by Berker Peksag :
--
nosy: +skrah
___
Python tracker
<http://bugs.python.org/issue27720>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks for the patch!
+.. exception:: DatabaseError
+
+Exception raised for errors that are related to the database. It
Indentation is not in line with other items:
+.. exception:: DatabaseError
+
+ Exception [...]
In Cursor.execute
Berker Peksag added the comment:
Raymond, please stop hijacking issues. This doesn't have anything to do with
multiprocessing and there are already four core developers in the nosy list. If
you really want to assign it to someone else, please at least wait for a month
or ask if they have
Berker Peksag added the comment:
Thanks for the patch, Matthew!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
> So I'll tweak that [...]
Hi Nick, could you also tweak the usage of versionchanged directive? :)
+.. versionchanged:: 3.6
+
+Long sequences of repeated frames are now abbreviated.
Description line needs to be indented:
.. versionchang
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
type: -> enhancement
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/i
Changes by Berker Peksag :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue27765>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue27789>
___
___
Pyth
Berker Peksag added the comment:
Here is an updated patch.
--
Added file:
http://bugs.python.org/file44141/issue27587_pystate_addmodule_v2.diff
___
Python tracker
<http://bugs.python.org/issue27
Berker Peksag added the comment:
Hi bananaapple, there are two things that need to be addressed:
1. We need to decide whether this is a bug in make_archive() implementation or
not. See msg223572 and msg223668 for details. I personally agree with David's
analysis in msg223668.
We can rep
Changes by Berker Peksag :
--
versions: +Python 3.5, Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue22021>
___
___
Python-bugs-list mailin
Berker Peksag added the comment:
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: commit review -> patch review
versions: -Python 2.7
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the report, Stefan!
--
___
Python tracker
<http://bugs.python.org/issue12946>
___
___
Python-bugs-list mailin
Berker Peksag added the comment:
Thanks for the report! update_lines_cols() was added in 132b5376bf34. I guess
we should just skip the test if update_lines_cols() is not available.
--
nosy: +berker.peksag
stage: -> needs patch
type: -> behavior
versions: +Pyth
Changes by Berker Peksag :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
I don't understand the second part of the patch.
*filename* is a filesystem encoding (:func:`os.fsdecode`) encoded string
[...]
Do you want to document that filename should be encoded by using
PyUnicode_EncodeFSDefault *before* passing
Berker Peksag added the comment:
pep_519_whatsnew.diff looks pretty good to me, thanks! It would be nice to add
a simple example to demonstrate the feature (like we did for PEP 498:
https://docs.python.org/3.6/whatsnew/3.6.html#pep-498-formatted-string-literals)
>>> import pathlib
Berker Peksag added the comment:
Yes, this can be closed as 'out of date'. I've just updated -O documentation to
remove the mention of .pyo extension. Thanks!
--
nosy: +berker.peksag
resolution: -> out of date
stage: needs patch -> resolved
s
Changes by Berker Peksag :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue27698>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Here is another one on koobs-freebsd10:
http://buildbot.python.org/all/builders/AMD64%20FreeBSD%2010.x%20Shared%203.x/builds/4809/steps/test/logs/stdio
test_handle_accept was fine this time.
And this one is from koobs-freebsd9
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue12029>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: -drkirkby
resolution: -> not a bug
stage: -> resolved
status: open -> closed
title: that is so great! -> Spam
___
Python tracker
<http://bugs.python
Changes by Berker Peksag :
--
Removed message: http://bugs.python.org/msg273550
___
Python tracker
<http://bugs.python.org/issue27849>
___
___
Python-bugs-list m
Berker Peksag added the comment:
It would be better to use support.swap_attr().
--
nosy: +berker.peksag
priority: normal -> low
stage: needs patch -> patch review
versions: +Python 3.6 -Python 3.5
___
Python tracker
<https://bugs.p
Berker Peksag added the comment:
In which case would the send_header method be absent?
--
___
Python tracker
<https://bugs.python.org/issue27414>
___
___
Pytho
Changes by Berker Peksag :
--
stage: commit review -> patch review
___
Python tracker
<https://bugs.python.org/issue6057>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
Thanks for the patch, Jaysinh and Stéphane! :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Berker Peksag added the comment:
Already fixed in 78c039440d6b, thanks!
--
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue6057>
___
_
Berker Peksag added the comment:
> I think it is pretty hard to miss "Never do this" when reading the code
> section.
I agree with David. However, I may be biased since I spend a lot of time
reading docs.python.org :) Here is a patch that moves the insecure example to a
sep
Berker Peksag added the comment:
Please report this to sfbulk developers. sfbuld is not part of the Python
standard library.
--
nosy: +berker.peksag
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracke
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> needs patch
type: -> crash
versions: +Python 3.6
___
Python tracker
<https://bugs.python.org/i
Berker Peksag added the comment:
Please split issue27861.patch into two patches.
It would be better if isolation_level wouldn't accept values other than None,
"" (empty string), "deferred", "immediate", "exclusive".
Berker Peksag added the comment:
Thanks for the report! This is a duplicate of issue 10513. I've pushed a patch
to fix this for 2.7 and 3.5+ in 030e100f048a and 81f614dd8136.
--
components: +Extension Modules
nosy: +berker.peksag
resolution: -> duplicate
stage: -> reso
Berker Peksag added the comment:
This is now fixed in 2.7 and 3.5+. Thank you all for your patience!
--
nosy: +berker.peksag
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.6 -Python 3.4
_
Berker Peksag added the comment:
sqlite_transaction_doc.patch looks good to me and applies cleanly to current
default branch. One minor note: It would be nice to document that the default
mode is "BEGIN DEFERRED" in Connection.isolation_level documentation.
--
nosy: +ber
Berker Peksag added the comment:
This is basically a duplicate of issue 10513.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> sqlite3.InterfaceError after commit
___
Python tra
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<https://bugs.python.org/issue21541>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
versions: +Python 3.5, Python 3.6 -Python 3.2, Python 3.3
___
Python tracker
<https://bugs.python.org/issue12
Berker Peksag added the comment:
test_path_t_converter failure looks similar to
http://bugs.python.org/issue27493#msg271047 (fixed by 5424252ce174.) I've
tested a fix on my Windows box and the test passed for me. Hopefully
8ec5a00e5d75 will fix the problem on buildbots too :)
--
Berker Peksag added the comment:
Builtbots look happy now:
* Windows 7 SP1:
http://buildbot.python.org/all/builders/AMD64%20Windows7%20SP1%203.x/builds/8177
* Windows 8:
http://buildbot.python.org/all/builders/AMD64%20Windows8%203.x/builds/2476
* Windows 10:
http://buildbot.python.org/all
Berker Peksag added the comment:
> If I'm not misreading your comment, this will change the original behavior,
> right?
Assuming you also change
ensure_ascii = not options.no_ensure_ascii
to
ensure_ascii = options.no_ensure_ascii
no, it won't change the original be
Changes by Berker Peksag :
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
New patch attached.
Changes:
* Addressed msg107402. I will update the C code if this implementation
is correct.
* Added more tests
* Converted classmethods to staticmethods
* Removed doctests
* Updated documentation
--
nosy: +berker.peksag
Added file
New submission from Berker Peksag:
See for the current version:
http://docs.python.org/devguide/docquality.html#helping-with-the-developer-s-guide
--
components: Devguide
files: devguide-highlight.diff
keywords: patch
messages: 182412
nosy: berker.peksag, ezio.melotti
priority: normal
New submission from Berker Peksag:
I have removed all mentions about Python 1.4 and 2.0 from the
Doc/extending/building.rst. The Demo/embed/demo.c file has been removed
in 3.x, so I used "_spammodule.c" convention in the examples. The patch
also fixes all the PEP 8 violations in th
Berker Peksag added the comment:
Patch attached with a test.
--
keywords: +patch
nosy: +berker.peksag
versions: +Python 3.3, Python 3.4
Added file: http://bugs.python.org/file29140/issue16181_v1.diff
___
Python tracker
<http://bugs.python.
New submission from Berker Peksag:
See for the current version:
http://docs.python.org/3.4/library/string.html#string.Template.template
--
assignee: docs@python
components: Documentation
files: string_template_highlight.diff
keywords: patch
messages: 182584
nosy: berker.peksag, docs
Changes by Berker Peksag :
--
keywords: +patch
nosy: +berker.peksag
Added file: http://bugs.python.org/file29263/issue16620.diff
___
Python tracker
<http://bugs.python.org/issue16
Changes by Berker Peksag :
--
keywords: +patch
nosy: +berker.peksag
Added file: http://bugs.python.org/file29291/issue13477.diff
___
Python tracker
<http://bugs.python.org/issue13
Berker Peksag added the comment:
> Patch looks good! Some minor comments on Rietveld.
Thanks for the review, Éric.
> Could you add tests?
Done.
Here's the new patch with Éric's comments addressed.
--
Added file: http://bugs.python.org/file29311/is
New submission from Berker Peksag:
Changes:
* Removed Python 2 specific code
* Re-enabled u'' tests (see PEP 414)
* Cosmetic fixes
--
components: Tests
files: test_print.diff
keywords: patch
messages: 183581
nosy: berker.peksag
priority: normal
severity: normal
status:
Berker Peksag added the comment:
I've converted Ezio's patch to Mercurial format, updated the lib2to3
documentation and added tests for assertRegexpMatches and assertRaisesRegexp
aliases[1].
[1] http://docs.python.org/3.4/library/unittest.html#deprecated-aliases
--
compone
Berker Peksag added the comment:
New patch(issue13477_v3.diff) attached.
Changes:
* Addressed comments from Serhiy
* Added "output" parameter to --extract option (from Ankur's patch)
* Updated tests and documentation
The current docstring of tarfile module does not give much
Changes by Berker Peksag :
Removed file: http://bugs.python.org/file29291/issue13477.diff
___
Python tracker
<http://bugs.python.org/issue13477>
___
___
Python-bugs-list m
Changes by Berker Peksag :
Removed file: http://bugs.python.org/file29346/issue13477_v3.diff
___
Python tracker
<http://bugs.python.org/issue13477>
___
___
Python-bug
Changes by Berker Peksag :
Added file: http://bugs.python.org/file29347/issue13477_v3.diff
___
Python tracker
<http://bugs.python.org/issue13477>
___
___
Python-bug
Berker Peksag added the comment:
+skip_if_dont_write_bytecode = unittest.skipIf(
+sys.dont_write_bytecode,
+"test meaningful only when writing bytecode")
Maybe this could be added to the test.support module?
--
nosy: +ber
Changes by Berker Peksag :
--
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue1154351>
___
___
Python-bugs-list mailin
Berker Peksag added the comment:
Should the documentation of the wave module be updated to match this change?
See issue 16808 for example.
The current wave.Wave_read.getparams documentation says:
"Returns a tuple (nchannels, sampwidth, framerate, nframes, comptype,
compname), equivale
Changes by Berker Peksag :
--
versions: -Python 2.6, Python 3.1, Python 3.5
___
Python tracker
<http://bugs.python.org/issue17514>
___
___
Python-bugs-list mailin
New submission from Berker Peksag:
(initially reported at
http://mail.python.org/pipermail/docs/2013-February/013331.html )
--
assignee: docs@python
components: Documentation
files: unittest-mock-example.diff
keywords: patch
messages: 185187
nosy: berker.peksag, docs@python
priority
Changes by Berker Peksag :
--
versions: +Python 3.4 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue5207>
___
___
Python-bugs-list mailing list
Unsub
Berker Peksag added the comment:
Thanks for the reviews. Patch updated.
Éric, since the test file is relatively small, I went ahead and made some
cosmetic fixes, but I can open a new issue for them :)
--
Added file: http://bugs.python.org/file29680/test_print_v2.diff
Changes by Berker Peksag :
Added file: http://bugs.python.org/file29686/issue13477_v4.diff
___
Python tracker
<http://bugs.python.org/issue13477>
___
___
Python-bug
Changes by Berker Peksag :
Removed file: http://bugs.python.org/file29311/issue13477_v2.diff
___
Python tracker
<http://bugs.python.org/issue13477>
___
___
Python-bug
New submission from Berker Peksag:
I saw a conversation about adding a @skip_on_windows decorator on #python-dev a
couple of months ago.
Attached a patch with a documentation update.
(Added the participants of the conversation to nosy list.)
--
components: Tests
files
Berker Peksag added the comment:
Is there a chance to get this into 3.3.2?
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue16163>
___
___
Changes by Berker Peksag :
--
versions: +Python 3.4
___
Python tracker
<http://bugs.python.org/issue17764>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
I think this needs to be discussed on python-ideas first.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue17
Berker Peksag added the comment:
I left comments on Rietveld. The patch also needs a documentation update.
--
nosy: +berker.peksag
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
nosy: +berker.peksag
resolution: fixed ->
Added file: http://bugs.python.org/file30003/issue16316_27.diff
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Probably duplicate of issue 15693?
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue17847>
___
___
Pytho
Berker Peksag added the comment:
> Could you also propose places in the test to use this?
Sure.
- Lib/test/test_py_compile.py
- Lib/test/test_cmd_line.py
- Lib/test/test_faulthandler.py
- Lib/test/test_subprocess.py
- Lib/test/test_fileio.py
- Lib/test/test_io.py
- Lib/test/test_logging
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
versions: +Python 3.4 -Python 3.3
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue17974>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Berker Peksag:
This issue is similar to issue 22289.
==
ERROR: test_ftp (test.test_urllib2net.OtherNetworkTests)
(url='ftp://ftp.debian.org/debian/R
Berker Peksag added the comment:
Thanks for the patch, Remi.
--
assignee: -> berker.peksag
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
versions: +Python 3.4
___
Python
Changes by Berker Peksag :
--
stage: test needed -> resolved
___
Python tracker
<http://bugs.python.org/issue21052>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
Good point. Patch updated. Thanks for the reviews!
--
Added file: http://bugs.python.org/file36874/issue22389_v3.diff
___
Python tracker
<http://bugs.python.org/issue22
Berker Peksag added the comment:
Here is a simple patch to correct the redirect_stdout documentation.
--
keywords: +patch
nosy: +berker.peksag
stage: -> patch review
Added file: http://bugs.python.org/file36877/issue21061.diff
___
Python trac
Changes by Berker Peksag :
--
stage: -> needs patch
___
Python tracker
<http://bugs.python.org/issue22594>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Berker Peksag :
--
stage: needs patch -> resolved
___
Python tracker
<http://bugs.python.org/issue15569>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
> Repr.repr_TYPE()
This is already fixed in issue 14824.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
stage: needs patch -> patch review
type: -> enhancement
versions: +Python 3.5 -Python 3.3
___
Python tracker
<http://bugs.python.org/i
Changes by Berker Peksag :
--
nosy: +db3l
___
Python tracker
<http://bugs.python.org/issue20981>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue20020>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue21855>
___
___
Python-bugs-list mai
2201 - 2300 of 3715 matches
Mail list logo