Berker Peksag added the comment:
> * The IPv[46]Network.hostmask property is wrongly called "host mask"
> (with a space!) in the docs
This one has already been fixed in 4f8ad9a4193f.
--
nosy: +berker.peksag
versions: +Python 3.5, Python 3.6 -Python
Changes by Berker Peksag :
--
title: some new stuff -> Spam
___
Python tracker
<http://bugs.python.org/issue27284>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
nosy: -drkirkby
___
Python tracker
<http://bugs.python.org/issue27284>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
It's actually deprecated in Python 3.6:
https://docs.python.org/dev/whatsnew/3.6.html#deprecated-features
--
keywords: +easy
nosy: +berker.peksag
stage: -> needs patch
versions: -Python 3.5
___
Python
Changes by Berker Peksag :
--
nosy: +brett.cannon
___
Python tracker
<http://bugs.python.org/issue27285>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Please use "hg import --no-commit" in the future. Since Mercurial doesn't keep
committer's information it's hard to see who actually committed the patch in
case of a problem.
--
nosy: +berker.peksag
_
Berker Peksag added the comment:
Thank you for the great patch Jon! :)
I rebased Jon's patch to current default with additional changes like fixing
typos and markup tweaks. I also removed the following item since it doesn't
seem to be crucial:
* It's probably a good idea t
Berker Peksag added the comment:
Good catch, thanks Arthur!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: enhancement -> behavior
versions: +Python 3.6
___
Python tracker
<http://
Berker Peksag added the comment:
Thanks for the report Chris. The patch in issue 18802 should solve this. It
would be great if you'd have time to take a look at it (should we add a note
that says we only support CIDR for IPv6?)
--
nosy: +berker.p
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
type: -> enhancement
versions: +Python 3.6 -Python 3.5
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
issue20900.patch looks good to me. We are already testing output of "python
-setup.py upload --show-response" in Lib/distutils/tests/test_upload.py so I
removed test_show_reponse and tweaked test_upload to test the whole line:
-self.asser
Berker Peksag added the comment:
Thanks for the patch ingrid!
--
assignee: eric.araujo ->
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python
Berker Peksag added the comment:
The looks good to me in general, but I'd suggest to refer to the new
algorithms_guaranteed and algorithms_available attributes in the following
paragraph:
+:func:`sha512`. The :func:`md5` is typically available, but will be
missing if
+Python has
New submission from Berker Peksag:
>From
>http://buildbot.python.org/all/builders/x86-64%20Ubuntu%2015.10%20Skylake%20CPU%203.5/builds/533/steps/test/logs/stdio
==
ERROR: test_ftp_timeout (test.test_urllib2net.Timeo
Berker Peksag added the comment:
Here is a patch to skip the test.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file43335/issue27289.diff
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Here is an updated patch that uses my proposal in msg219017. Since this is
already documented at
https://docs.python.org/3.5/library/ipaddress.html#ipaddress.IPv4Address.is_global
I think it should also go into 3.5.
--
versions: +Python 3.6
Added file
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue27233>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Add support for retrieving the certificate chain
___
Python tracker
<http://bugs.python
Berker Peksag added the comment:
Thank you Gareth. I will commit ipaddress.patch this weekend.
--
___
Python tracker
<http://bugs.python.org/issue20508>
___
___
Berker Peksag added the comment:
Thanks Roger!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: enhancement -> behavior
___
Python tracker
<http://bugs.python
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.5
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
type: compile error -> behavior
___
Python tracker
<http://bugs.python.org/issue16484>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
Can you please try without coveragepy?
./python -m test test_exceptions
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue27
Berker Peksag added the comment:
The API in Python 3 is very different and I'm not sure we can backport the
expected behavior without breaking other people's code (unless we treat this as
a security issue). Here is a naive backport for 2.7.
Known test failures: te
Berker Peksag added the comment:
Actually, we can remove the versionchanged directive. The attached script works
fine with the spawn start method in Python 3.4.
I will commit the following version:
Ensure that all arguments to :meth:`Process.__init__` are picklable.
Also, if you
Berker Peksag added the comment:
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
The documentation should mention that the __prepare__ method must be
implemented as a classmethod (see msg164697 for the reference.)
The example at
https://docs.python.org/dev/reference/datamodel.html#metaclass-example needs to
be linked from the "Prep
Berker Peksag added the comment:
Here is a list of exceptions that need to be documented: IntegrityError,
Warning, Error, ProgrammingError and DatabaseError.
--
nosy: +berker.peksag
priority: low -> normal
type: behavior -> enhancement
versions: +Python 3.5, Python 3.6 -Pyth
Berker Peksag added the comment:
Thanks for the patch Dave. I found a couple of more issues while reviewing the
patch and fixed them.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python track
Berker Peksag added the comment:
Thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.5
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the patch Alex. Some quick review comments:
* We need to skip SqliteOnConflictTests if the installed sqlite3 doesn't
support the feature
* There is no need to duplicate https://www.sqlite.org/lang_conflict.html in
every test. You can add
Berker Peksag added the comment:
I'm not sure if 17e78918f608 is relevant but test_gc is failing on several
buildbots:
* http://buildbot.python.org/all/builders/PPC64%20Fedora%203.5/builds/716
http://buildbot.python.org/all/builders/PPC64%20Fedora%203.5/builds/716/steps/test/logs/
Berker Peksag added the comment:
Just saw this again:
http://buildbot.python.org/all/builders/x86-64%20Ubuntu%2015.10%20Skylake%20CPU%203.5/builds/543/steps/test/logs/stdio
--
___
Python tracker
<http://bugs.python.org/issue27
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
> Then change the value of METH_KEYWORDS from 0x0002 to 0x0003 in 3.6.
Here is a patch.
--
Added file: http://bugs.python.org/file43364/issue15657_36.diff
___
Python tracker
<http://bugs.python.org/issu
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python 3.5, Python 3.6 -Python 3.2
___
Python tracker
<http://bugs.python.org/iss
Berker Peksag added the comment:
Looking at this again, I think we should fix this in issue 9625.
--
resolution: -> duplicate
stage: needs patch -> resolved
status: open -> closed
superseder: -> argparse: Problem with defaults for variable nargs when us
Berker Peksag added the comment:
I don't think a new API is needed. But we need to promote the policy keyword
better in docs. See https://twitter.com/aksiksi/status/741769504817045508 for
an example of confusion.
I don't know if it's a good idea or API but can we add a &
Berker Peksag added the comment:
> I think we just need to plumb a `policy` argument through to the ultimate base
> class, email.message.Message
That's already possible:
https://docs.python.org/dev/library/email.message.html#email.message.Message
It would be nice to be able t
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue24254>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> needs patch
type: crash -> behavior
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Thanks for the patch. From a quick look, the patch looks fine but we need a
test case. You can see Lib/test/test_cgi.py for existing tests.
--
stage: needs patch -> patch review
___
Python tracker
&l
Changes by Berker Peksag :
--
resolution: -> duplicate
stage: patch review -> resolved
status: open -> closed
superseder: -> cgi.FieldStorage can't parse multipart part headers with
Content-Length and no filename in Content-Disposition
_
Berker Peksag added the comment:
Thank you all!
--
nosy: +berker.peksag
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the patch, Alex.
--
nosy: +berker.peksag
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
CancelledError documentation needs to be updated to mention that it is an alias
for 'concurrent.futures.CancelledError'. We also need to update all
``:exc:`~concurrent.futures.CancelledError``` usages in
Doc/library/asyncio*.rst. I'd pref
Berker Peksag added the comment:
This is a duplicate of issue 13886.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> readline-related test_builtin failure
___
Python tr
New submission from Berker Peksag:
Quoting Barry's message msg268430 from issue 10839:
On Jun 13, 2016, at 06:38 AM, Berker Peksag wrote:
>I don't know if it's a good idea or API but can we add a 'policy' keyword
>argument to email.mime.base.MIMEBa
Berker Peksag added the comment:
> Right, that's what I meant by "plumb". :)
Sorry, apparently I can't read in the mornings :) I have just opened issue
27331 to implement this idea.
--
___
Python tracker
<http://
Berker Peksag added the comment:
Thanks for helping to triage this, Pedro. I think there is a typo in your
example: ``email.message_from_binary_file(fp)`` needs to be passed to
``bs.flatten()``.
With the following script I'm also unable to reproduce the issue in Python 3.4+:
import
Berker Peksag added the comment:
The review comments are at http://bugs.python.org/review/8/#ps12743 (you
can also click to the 'review' link above)
--
___
Python tracker
<http://bugs.python.o
Changes by Berker Peksag :
--
nosy: +martin.panter
___
Python tracker
<http://bugs.python.org/issue8>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Please attach the patch in unified diff format. See
https://docs.python.org/devguide/patch.html for details.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue24
Changes by Berker Peksag :
--
nosy: +serhiy.storchaka
___
Python tracker
<http://bugs.python.org/issue24424>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
You may also want to check that the method_name is "commit". A test case would
nice to have.
Note that the connection context manager will still fail cases like nested
context managers. See issue 16958.
--
nosy: +berker.peksag, ghae
Changes by Berker Peksag :
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
nosy: +ned.deily
___
Python tracker
<http://bugs.python.org/issue27337>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
nosy: +haypo
stage: -> patch review
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue27336>
___
___
Pyth
Berker Peksag added the comment:
The attached patch should fix this.
--
keywords: +patch
nosy: +berker.peksag
Added file: http://bugs.python.org/file43424/issue27336.diff
___
Python tracker
<http://bugs.python.org/issue27
Changes by Berker Peksag :
--
stage: patch review -> commit review
___
Python tracker
<http://bugs.python.org/issue27343>
___
___
Python-bugs-list mai
Berker Peksag added the comment:
Thanks for the report.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
I just saw the same test failures at
http://buildbot.python.org/all/builders/AMD64%20Debian%20root%203.5/builds/998/steps/test/logs/stdio
I'm attaching the test logs for future reference.
--
nosy: +berker.peksag
stage: -> needs pa
Berker Peksag added the comment:
It looks like SIO_LOOPBACK_FAST_PATH is also defined in older Windows versions.
I updated the test to skip if SIO_LOOPBACK_FAST_PATH is defined and
exc.winerror is WSAEOPNOTSUPP. Buildbot is now green:
http://buildbot.python.org/all/builders/AMD64%20Windows7
Berker Peksag added the comment:
> That'll handle the test fine, though I wonder whether we should try and
> conditionally define the constant at runtime?
+1. Is it safe to use IsWindows8OrGreater()?
--
___
Python tracker
<http://b
Changes by Berker Peksag :
Removed file: http://bugs.python.org/file43454/bugreport-2016-05-18-03-28-01.txt
___
Python tracker
<http://bugs.python.org/issue8>
___
___
Changes by Berker Peksag :
Removed file: http://bugs.python.org/file43455/bugreport-2016-05-18-03-28-01.txt
___
Python tracker
<http://bugs.python.org/issue8>
___
___
Changes by Berker Peksag :
Removed file: http://bugs.python.org/file43453/bugreport-2016-05-18-03-28-01.txt
___
Python tracker
<http://bugs.python.org/issue8>
___
___
Changes by Berker Peksag :
--
components: -Tests
nosy: -Daniel Griffin, Daniel Griffin, Daniel Griffin
___
Python tracker
<http://bugs.python.org/issue22
Changes by Berker Peksag :
--
Removed message: http://bugs.python.org/msg268808
___
Python tracker
<http://bugs.python.org/issue8>
___
___
Python-bugs-list m
Changes by Berker Peksag :
--
Removed message: http://bugs.python.org/msg268812
___
Python tracker
<http://bugs.python.org/issue8>
___
___
Python-bugs-list m
Changes by Berker Peksag :
--
Removed message: http://bugs.python.org/msg268809
___
Python tracker
<http://bugs.python.org/issue8>
___
___
Python-bugs-list m
Changes by Berker Peksag :
--
Removed message: http://bugs.python.org/msg268811
___
Python tracker
<http://bugs.python.org/issue8>
___
___
Python-bugs-list m
Changes by Berker Peksag :
--
nosy: -Daniel Griffin
resolution: -> not a bug
stage: -> resolved
status: open -> closed
title: Private -> Spam
___
Python tracker
<http://bugs.python
Berker Peksag added the comment:
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python
Changes by Berker Peksag :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue19756>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
I agree with Raymond. I doubt most of the unittest users would ever need a
builtin assertClose() method in unittest. I suggest closing this as 'rejected'.
--
nosy: +berker.peksag
___
Python trac
Berker Peksag added the comment:
Thanks for the report. \t is a tab character. You can use
'C:\\Users\\Anwender\\Desktop\\Test\\blub.txt'
or
r'C:\Users\Anwender\Desktop\Test\blub.txt'
or
'C:/Users/Anwender/Desktop/Test/blub.txt'
--
n
Berker Peksag added the comment:
This was discussed on python-ideas before:
* https://groups.google.com/forum/#!msg/python-ideas/MbvpK21nUNA/DwYpOFOVuYMJ
* https://groups.google.com/forum/#!msg/python-ideas/JVLuo-L0reU/zLNnBa9THqgJ
I don't think there was an agreement on the idea so I su
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
type: enhancement -> behavior
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.org/i
Changes by Berker Peksag :
--
components: +ctypes -Benchmarks
stage: -> resolved
superseder: -> ctypes: unions as arguments
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: -Python 2.7, Python 3.2, Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks, Julien.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the review, Martin.
--
components: +Tests
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.5, Python 3.6 -Python 2.7, Python 3.3, Python 3.4
_
Berker Peksag added the comment:
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
versions: +Python 3.5
___
Python tracker
<http://bugs.python
Berker Peksag added the comment:
Thanks for the updated patch. Some comments from a quick review:
* We need tests for the TypeError branches in both methods
* +'of type %s' % type(other)
type(other) -> type(other).__name__
* You can drop the XXX pa
Berker Peksag added the comment:
Thanks for the detailed report! Issue 24454 is actually a duplicate of this but
it has a patch and the idea was discussed by several core developers there. I'm
going to close this one.
--
nosy: +berker.peksag
resolution: -> duplicate
stag
Berker Peksag added the comment:
Thanks! 3.3 and 3.4 docs are not maintained anymore.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: enhancement -> behavior
versions: -Python 3.3, Python 3.4
__
Berker Peksag added the comment:
Thanks, Eryk. By the way, there is no need to change the state of 'resolution'
and 'stage' fields.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tra
Berker Peksag added the comment:
We don't re-open old issues (this was closed more than 3 years ago). Please
open a new issue and provide a minimal reproducer. Thanks!
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/is
Changes by Berker Peksag :
--
nosy: +steve.dower
___
Python tracker
<http://bugs.python.org/issue27410>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
The patch needs tests and documentation.
> +parser.add_argument('--no-ensure-ascii', action='store_true',
> default=False,
I'd go with ``action='store_false', default=True``.
--
nos
Berker Peksag added the comment:
Thanks.
--
nosy: +berker.peksag
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: enhancement -> behavior
___
Python tracker
<http://bugs.python
Berker Peksag added the comment:
Good catch, thanks for the report! 3.2, 3.3 and 3.4 are now in
security-fix-only so their docs won't be updated.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: enhancement -> behavior
v
Berker Peksag added the comment:
This is a duplicate of issue 26384.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> UnboundLocalError in socket._sendfile_use_sendfile
type:
Changes by Berker Peksag :
--
nosy: +neologix
___
Python tracker
<http://bugs.python.org/issue27436>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks for the patch. If you want to improve the examples in tkinter
documentation, I'd suggest to update Class.__init__(self, ...) to
super().__init__(...). There is no old-style classes in Python 3 anymore so
those examples could be updated safely.
Berker Peksag added the comment:
I think you also need to update the comment below:
/* It might be that the GetItem call fails even
though the key is present in the dictionary,
namely when this happens during a stack overflow. */
--
nosy: +berker.peksag, haypo
Berker Peksag added the comment:
Thanks for the updated patch. I noticed a typo in your test script. It works
for me if I update the super() line from
super().__init__(self, master)
to
super().__init__(master)
--
___
Python tracker
<h
Berker Peksag added the comment:
> which Berker says have been fixed in upstream libffi:
> https://bugs.python.org/issue25077#msg266068
Correct, here is the actual commit:
https://github.com/libffi/libffi/commit/4a677a425c18eda4bc5357b2485da57f133f908d
I have also sent a patch to up
Berker Peksag added the comment:
> I am using 'hg diff' with ~/.hgrc set to 'git = on' and this time, naively
> removed the '--git' from the output of 'hg diff' instead of commenting out
> 'git = on' in the config file :(
You don&#x
2001 - 2100 of 3715 matches
Mail list logo
