[issue29121] sqlite3 Controlling Transactions documentation not updated

2017-02-26 Thread Berker Peksag
Changes by Berker Peksag : -- pull_requests: +280 ___ Python tracker <http://bugs.python.org/issue29121> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29121] sqlite3 Controlling Transactions documentation not updated

2017-02-26 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Aviv! -- assignee: -> docs@python components: +Documentation nosy: +docs@python resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior ___ Python

[issue28518] execute("begin immediate") throwing OperationalError

2017-02-26 Thread Berker Peksag
Berker Peksag added the comment: Thank you everyone! This should be fixed now. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue29355] sqlite3: remove sqlite3_stmt_readonly()

2017-02-26 Thread Berker Peksag
Berker Peksag added the comment: The patch for issue 28518 has been merged and it doesn't contain any use of sqlite3_stmt_readonly(). Closing this as 'out of date'. Thanks again Ma! -- resolution: -> out of date stage: -> resolved s

[issue29098] document minimum sqlite version

2017-02-26 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, Carl! The patch for issue 28518 has been lifted the requirement for sqlite3_stmt_readonly() so you can now use and compile Python 3.6.1 without a warning at compile time. -- resolution: -> out of date stage: -> resolved

[issue28231] zipfile does not support pathlib

2017-02-26 Thread Berker Peksag
Changes by Berker Peksag : -- pull_requests: +283 ___ Python tracker <http://bugs.python.org/issue28231> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28231] zipfile does not support pathlib

2017-02-26 Thread Berker Peksag
Berker Peksag added the comment: PR 322 should make the example in msg284754 work: >>> import pathlib, zipfile >>> f = pathlib.Path('spam.zip') >>> with zipfile.ZipFile(f) as zf: ... zf.namelist() ... ['LICENSE'] It doesn't implement f

[issue28624] Make the `cwd` argument to `subprocess.Popen` accept a `PathLike`

2017-02-26 Thread Berker Peksag
Changes by Berker Peksag : -- pull_requests: +284 ___ Python tracker <http://bugs.python.org/issue28624> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28230] tarfile does not support pathlib

2017-02-26 Thread Berker Peksag
Berker Peksag added the comment: Serhiy's patch looks good to me, but it would be nice to document the support for PathLike objects in the tarfile documentation. -- ___ Python tracker <http://bugs.python.org/is

[issue28624] Make the `cwd` argument to `subprocess.Popen` accept a `PathLike`

2017-02-26 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Sayan! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue28911] Clarify the behaviour of assert_called_once_with

2017-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: -153957 resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue27840] functools.partial: don't copy keywoard arguments in partial_call()?

2017-02-27 Thread Berker Peksag
Berker Peksag added the comment: PR 253 has been merged. -- nosy: +berker.peksag resolution: -> rejected status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue29665] how to edit or delete issues created by me in bug tracker ?!

2017-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue29665> ___ ___

[issue27788] platform module's version number doesn't match its docstring

2017-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- pull_requests: +295 ___ Python tracker <http://bugs.python.org/issue27788> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue24241] webbrowser default browser detection and/or public API for _trylist.

2017-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- pull_requests: +296 ___ Python tracker <http://bugs.python.org/issue24241> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29455] Mention coverage.py in trace module documentation

2017-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> patch review versions: +Python 3.6, Python 3.7 ___ Python tracker <http://bugs.python.org/issue29455> ___ ___ Python-

[issue29414] Change 'the for statement is such an iterator' in Tutorial

2017-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> patch review type: -> enhancement ___ Python tracker <http://bugs.python.org/issue29414> ___ ___ Python-bugs-list

[issue22594] Add a link to the regex module in re documentation

2017-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue28598] RHS not consulted in `str % subclass_of_str` case.

2017-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- versions: -Python 2.7 ___ Python tracker <http://bugs.python.org/issue28598> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29655] Certain errors during IMPORT_STAR can leak a reference

2017-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- pull_requests: +300 ___ Python tracker <http://bugs.python.org/issue29655> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29655] Certain errors during IMPORT_STAR can leak a reference

2017-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- pull_requests: +301 ___ Python tracker <http://bugs.python.org/issue29655> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28231] zipfile does not support pathlib

2017-02-27 Thread Berker Peksag
Berker Peksag added the comment: Note that Ned gave us a permission to get this into 3.6.1. -- ___ Python tracker <http://bugs.python.org/issue28231> ___ ___ Pytho

[issue29655] Certain errors during IMPORT_STAR can leak a reference

2017-02-27 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed versions: -Python 2.7 ___ Python tracker <http://bugs.python.or

[issue29655] Certain errors during IMPORT_STAR can leak a reference

2017-02-27 Thread Berker Peksag
Berker Peksag added the comment: I ignored 2.7 because you know... it's 2.7 :) And you said [1] that it doesn't have a big effect on real applications. [1] https://github.com/python/cpython/pull/301#issuecomment-282789185 -- nosy: +ber

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

2017-03-03 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: postponed -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.o

[issue26187] sqlite3 trace callback prints duplicate line

2017-03-03 Thread Berker Peksag
Berker Peksag added the comment: It would be nice to add a test case to https://github.com/python/cpython/blob/86a670543ff97d52fd9b8ca0477f8b6d27ee946d/Lib/sqlite3/test/hooks.py#L204 before closing this. -- nosy: +berker.peksag stage: -> test needed versions: +Python 3.7 -Python

[issue9303] Migrate sqlite3 module to _v2 API to enhance performance

2017-03-03 Thread Berker Peksag
Berker Peksag added the comment: I will add commit information manually: https://github.com/python/cpython/commit/86a670543ff97d52fd9b8ca0477f8b6d27ee946d Thanks! -- ___ Python tracker <http://bugs.python.org/issue9

[issue26526] In parsermodule.c, replace over 2KLOC of hand-crafted validation code, with a DFA

2016-05-28 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue26526> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9327] doctest DocFileCase setUp/tearDown asymmetry

2016-05-28 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> doctest.DocTestCase fails when run repeatedly ___ Python tracker <http://bugs.pytho

[issue25592] distutils docs: data_files always uses sys.prefix

2016-05-28 Thread Berker Peksag
Changes by Berker Peksag : -- components: +Distutils nosy: +berker.peksag, dstufft, eric.araujo stage: -> patch review type: -> behavior versions: +Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python.org/i

[issue9363] data_files are not installed relative to sys.prefix

2016-05-28 Thread Berker Peksag
Berker Peksag added the comment: Issue 25592 is a duplicate of this and but it has a patch that almost ready to commit so I'm closing this one. -- nosy: +berker.peksag resolution: -> duplicate stage: test needed -> resolved status: open -> closed superseder: -&g

[issue27157] Unhelpful error message when one calls a subclass of type with a custom metaclass

2016-05-30 Thread Berker Peksag
Berker Peksag added the comment: Please don't mark your own patch as 'commit review'. -- nosy: +berker.peksag stage: commit review -> patch review ___ Python tracker <http://bugs.

[issue27157] Unhelpful error message when one calls a subclass of type with a custom metaclass

2016-05-30 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Emanuel. I left some comments about Sphinx markup on Rietveld. > Berker, I don't mind if people mark their own patches for commit review *when > they think it is ready for commit*. Is there any person who really thinks tha

[issue25570] urllib.request > Request.add_header("abcd", "efgh") fails with character ":" in first parameter string

2016-05-31 Thread Berker Peksag
Berker Peksag added the comment: add_header.patch looks good to me. Thanks Martin. -- nosy: +berker.peksag stage: patch review -> commit review versions: -Python 3.4 ___ Python tracker <http://bugs.python.org/issu

[issue20683] Add example to tutorial namespace doc, section 9.2

2016-05-31 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, Karl. Could you give more details about what's missing? The section gives some examples of namespaces: [...] the set of built-in names (containing functions such as abs(), and built-in exception names); the global names in a m

[issue20496] function definition tutorial encourages bad practice

2016-05-31 Thread Berker Peksag
Berker Peksag added the comment: I agree with Terry. The print example is also useful to show the implicit return value of fib(). Quoting from the same section: [...] In fact, even functions without a return statement do return a value, albeit a rather boring one. This value is called

[issue17383] Possibly ambiguous phrasing in tutorial/modules#more-on-modules

2016-05-31 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: patch review -> needs patch type: -> behavior versions: +Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python.org/i

[issue7769] SimpleXMLRPCServer.SimpleXMLRPCServer.register_function as decorator

2016-05-31 Thread Berker Peksag
Berker Peksag added the comment: Here's some quick review comments: * xmlrpc_register_decorator_py33.patch doesn't apply cleanly anymore. * -serv.register_function(my_function) +serv.register_function(_my_function, name='my_function'

[issue27174] Update URL to IPython in interactive.rst

2016-06-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, kulla. -- nosy: +berker.peksag resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue27172] Add skip_bound_arg argument to inspect.Signature.from_callable()

2016-06-01 Thread Berker Peksag
Changes by Berker Peksag : -- stage: test needed -> patch review ___ Python tracker <http://bugs.python.org/issue27172> ___ ___ Python-bugs-list mailing list Un

[issue23116] Python Tutorial 4.7.1: Improve ask_ok() to cover more input values

2016-06-01 Thread Berker Peksag
Berker Peksag added the comment: I agree with all of Carol's suggestions. Also, OSError could be replaced with a more appropriate exception such as ValueError. -- nosy: +berker.peksag stage: -> needs patch versions: +Python 3.5, Python 3.6 -Py

[issue23116] Python Tutorial 4.7.1: Improve ask_ok() to cover more input values

2016-06-01 Thread Berker Peksag
Berker Peksag added the comment: Here is a patch. -- keywords: +patch stage: needs patch -> patch review Added file: http://bugs.python.org/file43088/issue23116.diff ___ Python tracker <http://bugs.python.org/issu

[issue27178] Unconverted RST marking in interpreter tutorial

2016-06-01 Thread Berker Peksag
Berker Peksag added the comment: Good catch! Thanks for patch, Nathan. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: enhancement -> behavior ___ Python tracker <http://bugs.python

[issue12243] getpass.getuser works on OSX

2016-06-01 Thread Berker Peksag
Berker Peksag added the comment: See issue 11233 for the availability directive patch. Thanks for the patch, Bryce. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: +Python 3.6

[issue22374] Replace contextmanager example and improve explanation

2016-06-01 Thread Berker Peksag
Berker Peksag added the comment: We also have swap_attr() and swap_item() helpers in Lib/test/support/__init__.py. I've used a simplified version of swap_attr() in my patch. Since this is basically a document improvement I removed Python 2.7 from the versions field. -- key

[issue8519] doc: termios and ioctl reference links

2016-06-01 Thread Berker Peksag
Berker Peksag added the comment: +1 for using the manpage directives. -- keywords: +easy nosy: +berker.peksag stage: -> needs patch type: -> enhancement versions: +Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python.org/

[issue20693] Sidebar scrolls down 2x as fast as page content

2016-06-01 Thread Berker Peksag
Changes by Berker Peksag : -- status: pending -> closed ___ Python tracker <http://bugs.python.org/issue20693> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue18085] Verifying refcounts.dat

2016-06-01 Thread Berker Peksag
Berker Peksag added the comment: Can we now close this as a duplicate of issue 9755? -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue18

[issue18384] Add devhelp build instructions to the documentation makefile

2016-06-01 Thread Berker Peksag
Berker Peksag added the comment: I think we should avoid adding distro specific tools into CPython repository (and the another reason to reject this is that the other distros will probably want to add their tools). -- nosy: +berker.peksag resolution: -> rejected stage: patch rev

[issue27180] Doc/pathlib: Please describe the behaviour of Path().rename() is depends on the platform (same as os.rename())

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch versions: -Python 3.4 ___ Python tracker <http://bugs.python.org/issue27180> ___ ___ Py

[issue23116] Python Tutorial 4.7.1: Improve ask_ok() to cover more input values

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the review. I removed the "-=" part from the patch. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs

[issue21196] Name mangling example in Python tutorial

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: I think the text is fine, but the example is not needed. I've updated Chandan's patch to remove the example and tweak the text a bit. -- nosy: +berker.peksag versions: +Python 3.6 -Python 3.4 Added file: http://bugs.python.org/file43108/issue

[issue16192] ctypes - documentation example

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed versions: +Python 3.6 -Python 3.4 ___ Python tracker <http://bugs.python.or

[issue25160] Stop using deprecated imp module; imp should now emit a real DeprecationWarning

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: > - 2to3 replaces reload() calls with imp.reload There is an already open issue for this: Issue 21446. -- ___ Python tracker <http://bugs.python.org/issu

[issue21776] distutils.upload uses the wrong order of exceptions

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Claudiu. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue21864] Error in documentation of point 9.8 'Exceptions are classes too'

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: I think the "Exceptions Are Classes Too" section can be removed now. Users already learned that exceptions are classes in the previous chapter: https://docs.python.org/3/tutorial/errors.html I'm attaching a patch that removes the "Except

[issue16192] ctypes - documentation example

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue16192> ___

[issue27191] Add formatting around methods in PEP 8

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch. I'm not sure we can apply the patch to bugfix branches. You can use SQLITE_VERSION_NUMBER to check sqlite3 version. -- nosy: +berker.peksag stage: -> patch review versions: +Py

[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- components: +Extension Modules ___ Python tracker <http://bugs.python.org/issue27190> ___ ___ Python-bugs-list mailing list Unsub

[issue19489] move quick search box above TOC

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue19489> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue17352] Be clear that __prepare__ must be declared as a class method

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: This is a duplicate of issue 15243. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Misleading documentation for __prepare__ ___ Python tr

[issue15243] Misleading documentation for __prepare__

2016-06-02 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy versions: +Python 3.6 -Python 3.4 ___ Python tracker <http://bugs.python.org/issue15243> ___ ___ Python-bugs-list m

[issue11501] distutils.archive_util should handle absence of zlib module

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: Tests are already skipped if zlib is not available in 2.7. To backport test_make_zipfile_no_zlib we also need the 'patch' helper so I'm not sure it's worth it at this point. -- nosy: +berker.peksag sta

[issue20408] memoryview() constructor documentation error

2016-06-02 Thread Berker Peksag
Berker Peksag added the comment: I think the safest solution is to change 'obj' to 'object' in memoryview documentation. -- assignee: -> docs@python components: +Documentation -Interpreter Core keywords: +easy nosy: +berker.peksag, docs@python stage: patc

[issue25931] os.fork() command distributed in windows Python27 (in SocketServer module)

2016-06-03 Thread Berker Peksag
Changes by Berker Peksag : -- stage: commit review -> resolved ___ Python tracker <http://bugs.python.org/issue25931> ___ ___ Python-bugs-list mailing list Un

[issue24459] Mention PYTHONFAULTHANDLER in the man page

2016-06-03 Thread Berker Peksag
Berker Peksag added the comment: > Hi, I have alphabetized and [...] Can you please de-alphabetize the list to make patch review a little bit easier? Thanks! -- nosy: +berker.peksag stage: needs patch -> patch review ___ Python tracker

[issue24459] Mention PYTHONFAULTHANDLER in the man page

2016-06-03 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Joshua. I did a quick review and it looks good to me. I will review and test it more carefully later today. -- ___ Python tracker <http://bugs.python.org/issue24

[issue17888] docs: more information on documentation team

2016-06-03 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Laura. I will commit issue17888_2.patch later today. -- ___ Python tracker <http://bugs.python.org/issue17888> ___ ___

[issue27200] make doctest in CPython has failures

2016-06-04 Thread Berker Peksag
Berker Peksag added the comment: Thanks for all of these patches, but I'm -1 on committing them. We already have an extensive test suite and I'm pretty sure that all of these examples are already tested in Lib/test [*]. Learning reST is already hard for contributors and we shouldn

[issue16851] Hint about correct ismethod and isfunction usage

2016-06-04 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue13771] HTTPSConnection __init__ super implementation causes recursion error

2016-06-04 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue13771> ___ ___

[issue27202] make doctest fails on 2.7 release notes

2016-06-04 Thread Berker Peksag
Berker Peksag added the comment: Perhaps it would be better to exclude all files in Doc/whatsnew. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue27

[issue27200] make doctest in CPython has failures

2016-06-04 Thread Berker Peksag
Berker Peksag added the comment: I have also found some markup errors via 'make doctest' so I agree that this can be helpful :) -- ___ Python tracker <http://bugs.python.o

[issue27202] make doctest fails on 2.7 release notes

2016-06-04 Thread Berker Peksag
Berker Peksag added the comment: By the way, after this I'm getting the following warnings: /Users/berkerpeksag/projects/cpython/Doc/whatsnew/index.rst:11: WARNING: toctree contains reference to nonexisting document 'whatsnew/2.7' /Users/berkerpeksag/projects/cpython/Doc/whatsn

[issue17888] docs: more information on documentation team

2016-06-04 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patches Terry and Laura. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue24459] Mention PYTHONFAULTHANDLER in the man page

2016-06-04 Thread Berker Peksag
Berker Peksag added the comment: I left some review comments on Rietveld: http://bugs.python.org/review/24459/ -- ___ Python tracker <http://bugs.python.org/issue24

[issue27188] sqlite3 execute* methods return value not documented

2016-06-05 Thread Berker Peksag
Berker Peksag added the comment: Could you also change the function signatures from .. method:: execute(sql, [parameters]) to .. method:: execute(sql[, parameters]) and document that parameters should be list (or sequence or iterable -- I'm a the airport now so I can't che

[issue19234] socket.fileno() documentation

2016-06-06 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker <http://bugs.python.org/issue19234> ___ ___ Python-bugs-list mailing list Un

[issue27227] argparse fails to parse [] when using choices and nargs='*'

2016-06-06 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> needs patch versions: -Python 3.4 ___ Python tracker <http://bugs.python.org/issue27227> ___ _

[issue27221] multiprocessing documentation is outdated regarding method picklability

2016-06-07 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: -> patch review title: [multiprocessing] Doc is outdated regarding method picklability -> multiprocessing documentation is outdated regarding method picklability type: -> behavior versions: +P

[issue27186] add os.fspath()

2016-06-07 Thread Berker Peksag
Changes by Berker Peksag : -- stage: test needed -> resolved ___ Python tracker <http://bugs.python.org/issue27186> ___ ___ Python-bugs-list mailing list Un

[issue27247] telnetlib AttributeError: 'error' object has no attribute 'errno' (handling of select.error)

2016-06-07 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. This is a duplicate of issue 18035. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> telnetlib incorrectly assumes that select.error has an errn

[issue27180] Doc/pathlib: Please describe the behaviour of Path().rename() is depends on the platform (same as os.rename())

2016-06-07 Thread Berker Peksag
Berker Peksag added the comment: Could you please send your patch in unified diff format? See https://docs.python.org/devguide/patch.html for details. -- nosy: +berker.peksag stage: needs patch -> patch review ___ Python tracker &l

[issue27251] TypeError in logging.HTTPHandler.emit; possible python 2 to 3 conversion issue

2016-06-07 Thread Berker Peksag
Changes by Berker Peksag : -- stage: test needed -> resolved ___ Python tracker <http://bugs.python.org/issue27251> ___ ___ Python-bugs-list mailing list Un

[issue26446] Mention in the devguide that core dev stuff falls under the PSF CoC

2016-06-07 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch Evelyn. The patch looks good to me. I have a couple of suggestions: 1. It seems like https://docs.python.org/devguide/coredev.html#responsibilities is a better place to put this 2. Core committers -> Core developers 3. PSF CoC -&g

[issue20842] pkgutil docs should reference glossary terms not PEP 302

2016-06-08 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy versions: +Python 3.6 -Python 3.4 ___ Python tracker <http://bugs.python.org/issue20842> ___ ___ Python-bugs-list m

[issue12962] TitledHelpFormatter and IndentedHelpFormatter are not documented

2016-06-08 Thread Berker Peksag
Berker Peksag added the comment: optparse has been deprecated for years and I don't see any reason to document them now. Closing as rejected. -- assignee: -> docs@python components: +Documentation -Library (Lib) nosy: +berker.peksag, docs@python resolution: -> rej

[issue26437] asyncio create_server() not always accepts the 'port' parameter as str

2016-06-08 Thread Berker Peksag
Berker Peksag added the comment: After changeset 3ec208c01418 this is no longer an issue: >>> from asyncio import * >>> loop = get_event_loop() >>> coro = loop.create_server(Protocol(), '', '12345') >>> loop.run_until_complete(coro) >

[issue21593] Clarify re.search documentation first match

2016-06-08 Thread Berker Peksag
Berker Peksag added the comment: > This should also be applied to regex.search's docstring. Done. -- nosy: +berker.peksag resolution: -> fixed stage: commit review -> resolved status: open -> closed ___ Python tracker <ht

[issue26985] Information about CodeType in inspect documentation is outdated

2016-06-08 Thread Berker Peksag
Berker Peksag added the comment: I prefer to not duplicate the list in Lib/inspect.py. We did similar docstring cleanups in several modules (venv for example) recently. -- nosy: +berker.peksag stage: -> patch review type: -> behavior versions: +Pyth

[issue7063] Memory errors in array.array

2016-06-08 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.6 -Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python.org/iss

[issue27066] SystemError if custom opener returns -1

2016-06-08 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> resolved ___ Python tracker <http://bugs.python.org/issue27066> ___ ___ Python-bugs-list mailing list Un

[issue18027] distutils should access stat_result timestamps via .st_*time attributes

2016-06-09 Thread Berker Peksag
Berker Peksag added the comment: This is a duplicate of issue 13420. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> newer() function in dep_util.py discard changes in the

[issue26985] Information about CodeType in inspect documentation is outdated

2016-06-09 Thread Berker Peksag
Berker Peksag added the comment: "Return true if the object is a code object." should stay. We can add a short sentence to refer people to the inspect documentation for the list of co_* attributes. -- ___ Python tracker <http://bu

[issue27281] unpickling an xmlrpc.client.Fault raises TypeError

2016-06-09 Thread Berker Peksag
Berker Peksag added the comment: Looks good to me, thanks. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue27281> ___ ___ Python-bug

[issue20508] IndexError from ipaddress._BaseNetwork.__getitem__ has no message

2016-06-09 Thread Berker Peksag
Berker Peksag added the comment: +1 for "address index out of range". The current test only covers the first IndexError. We also need to add another one for the else branch. -- nosy: +berker.peksag versions: +Python 3.6 ___ Python trac

[issue26868] Document PyModule_AddObject's behavior on error

2016-06-09 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the review Serhiy. Here is an updated patch. -- Added file: http://bugs.python.org/file43328/issue26868_v2.diff ___ Python tracker <http://bugs.python.org/issue26

[issue15657] Error in Python 3 docs for PyMethodDef

2016-06-09 Thread Berker Peksag
Berker Peksag added the comment: I'm going to delete (but note that :const:`METH_KEYWORDS` alone is equivalent to ``METH_VARARGS | METH_KEYWORDS``) from Doc/c-api/structures.rst in 3.5. Then change the value of METH_KEYWORDS from 0x0002 to 0x0003 in 3.6. Thanks for the review S

<    15   16   17   18   19   20   21   22   23   24   >