Changes by Berker Peksag :
--
pull_requests: +280
___
Python tracker
<http://bugs.python.org/issue29121>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Thanks for the patch, Aviv!
--
assignee: -> docs@python
components: +Documentation
nosy: +docs@python
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
___
Python
Berker Peksag added the comment:
Thank you everyone! This should be fixed now.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
The patch for issue 28518 has been merged and it doesn't contain any use of
sqlite3_stmt_readonly(). Closing this as 'out of date'. Thanks again Ma!
--
resolution: -> out of date
stage: -> resolved
s
Berker Peksag added the comment:
Thanks for the report, Carl! The patch for issue 28518 has been lifted the
requirement for sqlite3_stmt_readonly() so you can now use and compile Python
3.6.1 without a warning at compile time.
--
resolution: -> out of date
stage: -> resolved
Changes by Berker Peksag :
--
pull_requests: +283
___
Python tracker
<http://bugs.python.org/issue28231>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
PR 322 should make the example in msg284754 work:
>>> import pathlib, zipfile
>>> f = pathlib.Path('spam.zip')
>>> with zipfile.ZipFile(f) as zf:
... zf.namelist()
...
['LICENSE']
It doesn't implement f
Changes by Berker Peksag :
--
pull_requests: +284
___
Python tracker
<http://bugs.python.org/issue28624>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Serhiy's patch looks good to me, but it would be nice to document the support
for PathLike objects in the tarfile documentation.
--
___
Python tracker
<http://bugs.python.org/is
Berker Peksag added the comment:
Thanks for the patch, Sayan!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
nosy: -153957
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
PR 253 has been merged.
--
nosy: +berker.peksag
resolution: -> rejected
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Changes by Berker Peksag :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue29665>
___
___
Changes by Berker Peksag :
--
pull_requests: +295
___
Python tracker
<http://bugs.python.org/issue27788>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
pull_requests: +296
___
Python tracker
<http://bugs.python.org/issue24241>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
stage: -> patch review
versions: +Python 3.6, Python 3.7
___
Python tracker
<http://bugs.python.org/issue29455>
___
___
Python-
Changes by Berker Peksag :
--
stage: -> patch review
type: -> enhancement
___
Python tracker
<http://bugs.python.org/issue29414>
___
___
Python-bugs-list
Changes by Berker Peksag :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
versions: -Python 2.7
___
Python tracker
<http://bugs.python.org/issue28598>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
pull_requests: +300
___
Python tracker
<http://bugs.python.org/issue29655>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
pull_requests: +301
___
Python tracker
<http://bugs.python.org/issue29655>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
Note that Ned gave us a permission to get this into 3.6.1.
--
___
Python tracker
<http://bugs.python.org/issue28231>
___
___
Pytho
Changes by Berker Peksag :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: -Python 2.7
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
I ignored 2.7 because you know... it's 2.7 :) And you said [1] that it doesn't
have a big effect on real applications.
[1] https://github.com/python/cpython/pull/301#issuecomment-282789185
--
nosy: +ber
Changes by Berker Peksag :
--
resolution: postponed -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.o
Berker Peksag added the comment:
It would be nice to add a test case to
https://github.com/python/cpython/blob/86a670543ff97d52fd9b8ca0477f8b6d27ee946d/Lib/sqlite3/test/hooks.py#L204
before closing this.
--
nosy: +berker.peksag
stage: -> test needed
versions: +Python 3.7 -Python
Berker Peksag added the comment:
I will add commit information manually:
https://github.com/python/cpython/commit/86a670543ff97d52fd9b8ca0477f8b6d27ee946d
Thanks!
--
___
Python tracker
<http://bugs.python.org/issue9
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue26526>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Berker Peksag :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> doctest.DocTestCase fails when run repeatedly
___
Python tracker
<http://bugs.pytho
Changes by Berker Peksag :
--
components: +Distutils
nosy: +berker.peksag, dstufft, eric.araujo
stage: -> patch review
type: -> behavior
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Issue 25592 is a duplicate of this and but it has a patch that almost ready to
commit so I'm closing this one.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: test needed -> resolved
status: open -> closed
superseder: -&g
Berker Peksag added the comment:
Please don't mark your own patch as 'commit review'.
--
nosy: +berker.peksag
stage: commit review -> patch review
___
Python tracker
<http://bugs.
Berker Peksag added the comment:
Thanks for the patch, Emanuel. I left some comments about Sphinx markup on
Rietveld.
> Berker, I don't mind if people mark their own patches for commit review *when
> they think it is ready for commit*.
Is there any person who really thinks tha
Berker Peksag added the comment:
add_header.patch looks good to me. Thanks Martin.
--
nosy: +berker.peksag
stage: patch review -> commit review
versions: -Python 3.4
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Thanks for the report, Karl. Could you give more details about what's missing?
The section gives some examples of namespaces:
[...] the set of built-in names (containing functions such as abs(), and
built-in exception names); the global names in a m
Berker Peksag added the comment:
I agree with Terry. The print example is also useful to show the implicit
return value of fib(). Quoting from the same section:
[...] In fact, even functions without a return statement do return a value,
albeit a rather boring one. This value is called
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: patch review -> needs patch
type: -> behavior
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.org/i
Berker Peksag added the comment:
Here's some quick review comments:
* xmlrpc_register_decorator_py33.patch doesn't apply cleanly anymore.
* -serv.register_function(my_function)
+serv.register_function(_my_function, name='my_function'
Berker Peksag added the comment:
Thanks for the report, kulla.
--
nosy: +berker.peksag
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
stage: test needed -> patch review
___
Python tracker
<http://bugs.python.org/issue27172>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
I agree with all of Carol's suggestions. Also, OSError could be replaced with a
more appropriate exception such as ValueError.
--
nosy: +berker.peksag
stage: -> needs patch
versions: +Python 3.5, Python 3.6 -Py
Berker Peksag added the comment:
Here is a patch.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file43088/issue23116.diff
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Good catch! Thanks for patch, Nathan.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: enhancement -> behavior
___
Python tracker
<http://bugs.python
Berker Peksag added the comment:
See issue 11233 for the availability directive patch. Thanks for the patch,
Bryce.
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> behavior
versions: +Python 3.6
Berker Peksag added the comment:
We also have swap_attr() and swap_item() helpers in
Lib/test/support/__init__.py. I've used a simplified version of swap_attr() in
my patch.
Since this is basically a document improvement I removed Python 2.7 from the
versions field.
--
key
Berker Peksag added the comment:
+1 for using the manpage directives.
--
keywords: +easy
nosy: +berker.peksag
stage: -> needs patch
type: -> enhancement
versions: +Python 3.5, Python 3.6
___
Python tracker
<http://bugs.python.org/
Changes by Berker Peksag :
--
status: pending -> closed
___
Python tracker
<http://bugs.python.org/issue20693>
___
___
Python-bugs-list mailing list
Unsubscrib
Berker Peksag added the comment:
Can we now close this as a duplicate of issue 9755?
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue18
Berker Peksag added the comment:
I think we should avoid adding distro specific tools into CPython repository
(and the another reason to reject this is that the other distros will probably
want to add their tools).
--
nosy: +berker.peksag
resolution: -> rejected
stage: patch rev
Changes by Berker Peksag :
--
keywords: +easy
stage: -> needs patch
versions: -Python 3.4
___
Python tracker
<http://bugs.python.org/issue27180>
___
___
Py
Berker Peksag added the comment:
Thanks for the review. I removed the "-=" part from the patch.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs
Berker Peksag added the comment:
I think the text is fine, but the example is not needed. I've updated Chandan's
patch to remove the example and tweak the text a bit.
--
nosy: +berker.peksag
versions: +Python 3.6 -Python 3.4
Added file: http://bugs.python.org/file43108/issue
Changes by Berker Peksag :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
> - 2to3 replaces reload() calls with imp.reload
There is an already open issue for this: Issue 21446.
--
___
Python tracker
<http://bugs.python.org/issu
Berker Peksag added the comment:
Thanks for the patch, Claudiu.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
I think the "Exceptions Are Classes Too" section can be removed now. Users
already learned that exceptions are classes in the previous chapter:
https://docs.python.org/3/tutorial/errors.html
I'm attaching a patch that removes the "Except
Changes by Berker Peksag :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue16192>
___
Berker Peksag added the comment:
Thanks!
--
nosy: +berker.peksag
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
Thanks for the patch. I'm not sure we can apply the patch to bugfix branches.
You can use SQLITE_VERSION_NUMBER to check sqlite3 version.
--
nosy: +berker.peksag
stage: -> patch review
versions: +Py
Changes by Berker Peksag :
--
components: +Extension Modules
___
Python tracker
<http://bugs.python.org/issue27190>
___
___
Python-bugs-list mailing list
Unsub
Changes by Berker Peksag :
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue19489>
___
___
Python-bugs-list mailing list
Unsubscribe:
Berker Peksag added the comment:
This is a duplicate of issue 15243.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Misleading documentation for __prepare__
___
Python tr
Changes by Berker Peksag :
--
keywords: +easy
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue15243>
___
___
Python-bugs-list m
Berker Peksag added the comment:
Tests are already skipped if zlib is not available in 2.7. To backport
test_make_zipfile_no_zlib we also need the 'patch' helper so I'm not sure it's
worth it at this point.
--
nosy: +berker.peksag
sta
Berker Peksag added the comment:
I think the safest solution is to change 'obj' to 'object' in memoryview
documentation.
--
assignee: -> docs@python
components: +Documentation -Interpreter Core
keywords: +easy
nosy: +berker.peksag, docs@python
stage: patc
Changes by Berker Peksag :
--
stage: commit review -> resolved
___
Python tracker
<http://bugs.python.org/issue25931>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
> Hi, I have alphabetized and [...]
Can you please de-alphabetize the list to make patch review a little bit
easier? Thanks!
--
nosy: +berker.peksag
stage: needs patch -> patch review
___
Python tracker
Berker Peksag added the comment:
Thanks for the patch, Joshua. I did a quick review and it looks good to me. I
will review and test it more carefully later today.
--
___
Python tracker
<http://bugs.python.org/issue24
Berker Peksag added the comment:
Thanks, Laura. I will commit issue17888_2.patch later today.
--
___
Python tracker
<http://bugs.python.org/issue17888>
___
___
Berker Peksag added the comment:
Thanks for all of these patches, but I'm -1 on committing them. We already have
an extensive test suite and I'm pretty sure that all of these examples are
already tested in Lib/test [*]. Learning reST is already hard for contributors
and we shouldn
Changes by Berker Peksag :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Berker Peksag :
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue13771>
___
___
Berker Peksag added the comment:
Perhaps it would be better to exclude all files in Doc/whatsnew.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue27
Berker Peksag added the comment:
I have also found some markup errors via 'make doctest' so I agree that this
can be helpful :)
--
___
Python tracker
<http://bugs.python.o
Berker Peksag added the comment:
By the way, after this I'm getting the following warnings:
/Users/berkerpeksag/projects/cpython/Doc/whatsnew/index.rst:11: WARNING:
toctree contains reference to nonexisting document 'whatsnew/2.7'
/Users/berkerpeksag/projects/cpython/Doc/whatsn
Berker Peksag added the comment:
Thanks for the patches Terry and Laura.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Berker Peksag added the comment:
I left some review comments on Rietveld: http://bugs.python.org/review/24459/
--
___
Python tracker
<http://bugs.python.org/issue24
Berker Peksag added the comment:
Could you also change the function signatures from
.. method:: execute(sql, [parameters])
to
.. method:: execute(sql[, parameters])
and document that parameters should be list (or sequence or iterable -- I'm a
the airport now so I can't che
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue19234>
___
___
Python-bugs-list mailing list
Un
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> needs patch
versions: -Python 3.4
___
Python tracker
<http://bugs.python.org/issue27227>
___
_
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: -> patch review
title: [multiprocessing] Doc is outdated regarding method picklability ->
multiprocessing documentation is outdated regarding method picklability
type: -> behavior
versions: +P
Changes by Berker Peksag :
--
stage: test needed -> resolved
___
Python tracker
<http://bugs.python.org/issue27186>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
Thanks for the report. This is a duplicate of issue 18035.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> telnetlib incorrectly assumes that select.error has an errn
Berker Peksag added the comment:
Could you please send your patch in unified diff format? See
https://docs.python.org/devguide/patch.html for details.
--
nosy: +berker.peksag
stage: needs patch -> patch review
___
Python tracker
&l
Changes by Berker Peksag :
--
stage: test needed -> resolved
___
Python tracker
<http://bugs.python.org/issue27251>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
Thanks for the patch Evelyn. The patch looks good to me. I have a couple of
suggestions:
1. It seems like https://docs.python.org/devguide/coredev.html#responsibilities
is a better place to put this
2. Core committers -> Core developers
3. PSF CoC -&g
Changes by Berker Peksag :
--
keywords: +easy
versions: +Python 3.6 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue20842>
___
___
Python-bugs-list m
Berker Peksag added the comment:
optparse has been deprecated for years and I don't see any reason to document
them now. Closing as rejected.
--
assignee: -> docs@python
components: +Documentation -Library (Lib)
nosy: +berker.peksag, docs@python
resolution: -> rej
Berker Peksag added the comment:
After changeset 3ec208c01418 this is no longer an issue:
>>> from asyncio import *
>>> loop = get_event_loop()
>>> coro = loop.create_server(Protocol(), '', '12345')
>>> loop.run_until_complete(coro)
>
Berker Peksag added the comment:
> This should also be applied to regex.search's docstring.
Done.
--
nosy: +berker.peksag
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<ht
Berker Peksag added the comment:
I prefer to not duplicate the list in Lib/inspect.py. We did similar docstring
cleanups in several modules (venv for example) recently.
--
nosy: +berker.peksag
stage: -> patch review
type: -> behavior
versions: +Pyth
Changes by Berker Peksag :
--
nosy: +berker.peksag
stage: needs patch -> patch review
versions: +Python 3.6 -Python 3.3, Python 3.4
___
Python tracker
<http://bugs.python.org/iss
Changes by Berker Peksag :
--
stage: patch review -> resolved
___
Python tracker
<http://bugs.python.org/issue27066>
___
___
Python-bugs-list mailing list
Un
Berker Peksag added the comment:
This is a duplicate of issue 13420.
--
nosy: +berker.peksag
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> newer() function in dep_util.py discard changes in the
Berker Peksag added the comment:
"Return true if the object is a code object." should stay. We can add a short
sentence to refer people to the inspect documentation for the list of co_*
attributes.
--
___
Python tracker
<http://bu
Berker Peksag added the comment:
Looks good to me, thanks.
--
nosy: +berker.peksag
___
Python tracker
<http://bugs.python.org/issue27281>
___
___
Python-bug
Berker Peksag added the comment:
+1 for "address index out of range". The current test only covers the first
IndexError. We also need to add another one for the else branch.
--
nosy: +berker.peksag
versions: +Python 3.6
___
Python trac
Berker Peksag added the comment:
Thanks for the review Serhiy. Here is an updated patch.
--
Added file: http://bugs.python.org/file43328/issue26868_v2.diff
___
Python tracker
<http://bugs.python.org/issue26
Berker Peksag added the comment:
I'm going to delete
(but note that :const:`METH_KEYWORDS` alone is equivalent to ``METH_VARARGS
| METH_KEYWORDS``)
from Doc/c-api/structures.rst in 3.5.
Then change the value of METH_KEYWORDS from 0x0002 to 0x0003 in 3.6.
Thanks for the review S
1901 - 2000 of 3715 matches
Mail list logo