[issue18039] dbm.open(..., flag="n") does not work and does not give a warning

2014-03-11 Thread Berker Peksag
Changes by Berker Peksag : -- stage: test needed -> patch review ___ Python tracker <http://bugs.python.org/issue18039> ___ ___ Python-bugs-list mailing list Un

[issue20763] old sys.path_hooks importer does not work with Python 3.4.0rc1

2014-03-13 Thread Berker Peksag
Changes by Berker Peksag : -- stage: commit review -> committed/rejected ___ Python tracker <http://bugs.python.org/issue20763> ___ ___ Python-bugs-list mai

[issue28714] Addition to Documentation of configparser.ConfigParser.write()

2016-11-23 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, George. Using 'r+' means that you don't have to reopen the same file if you want to both read and write to it but it's up to you to check where the cursor is before writing anything to it. Since the ConfigParser.wr

[issue28722] doctest example exit status

2016-11-23 Thread Berker Peksag
Berker Peksag added the comment: Hi Rajiv, thanks for the report, but this is already possible by default. I will use the factorial example from https://docs.python.org/3.5/library/doctest.html to demonstrate it: $ python -m doctest example.py $ echo $? 0 Now change the following

[issue28518] execute("begin immediate") throwing OperationalError

2016-11-25 Thread Berker Peksag
Berker Peksag added the comment: I haven't had a time to investigate this yet, but I don't think there is an issue with SQLite itself. Note that pysqlite behaves the same way since version 2.8.0 and I couldn't find a similar report in their issue tracker. Like Serhiy, I&

[issue28518] execute("begin immediate") throwing OperationalError

2016-11-25 Thread Berker Peksag
Berker Peksag added the comment: There is a patch in issue 8145 to improve that part of the documentation. It would be great if you could take a look at it :) -- ___ Python tracker <http://bugs.python.org/issue28

[issue8145] Documentation about sqlite3 isolation_level

2016-11-25 Thread Berker Peksag
Berker Peksag added the comment: The patch needs to be updated to address changes in issue 10740 so I'm moving the stage field back to 'patch review'. -- stage: commit review -> patch review versions: +Python 3.7 ___ Pyt

[issue28793] Copy-paste error in collections.abc docs for AsyncGenerator

2016-11-25 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- assignee: -> docs@python components: +Documentation nosy: +berker.peksag, docs@python resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior ___ Python

[issue28796] FIX warnings in documentation build

2016-11-25 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior ___ Python tracker <http://bugs.python

[issue28803] Python 3.6.0b4 Reports ncurses present in Cygwin but fails to build for Cygwin

2016-11-25 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Python 3.6.0b4 Reports ncurses present in Cygwin but fails to build for cygwin ___ Python tracker <http://bugs.python

[issue28738] Document SIGBREAK as argument for signal() under Windows.

2016-11-25 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report and for the patch, Wojtek! -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.5 ___ Python tracker <http://bug

[issue28733] Show how to use mock_open in modules other that __main__

2016-11-25 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report and for the patch. I think expanding the "Where to patch" [1] section would be better. We can then refer to it from the mock_open() documentation. [1] https://docs.python.org/3.6/library/unittest.mock.html#where-to-patch -

[issue28288] Expose environment variable for Py_Py3kWarningFlag

2016-11-25 Thread Berker Peksag
Berker Peksag added the comment: Roy's patch looks good to me in general. Benjamin, as the RM of 2.7, do you have any objections? -- nosy: +benjamin.peterson ___ Python tracker <http://bugs.python.org/is

[issue28802] Python 3.6.0b4 Reports ncurses present in Cygwin but fails to build for cygwin

2016-11-25 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Fix curses module compilation with ncurses6 ___ Python tracker <http://bugs.python

[issue27777] cgi.FieldStorage can't parse simple body with Content-Length and no Content-Disposition

2016-11-26 Thread Berker Peksag
Changes by Berker Peksag : -- stage: needs patch -> patch review ___ Python tracker <http://bugs.python.org/issue2> ___ ___ Python-bugs-list mailing list Un

[issue28821] generate_opcode_h.py crash when run with python2

2016-11-28 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +haypo ___ Python tracker <http://bugs.python.org/issue28821> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28288] Expose environment variable for Py_Py3kWarningFlag

2016-11-28 Thread Berker Peksag
Berker Peksag added the comment: > PYTHON3WARNINGS looks as Python 3 variant of PYTHONWARNINGS. Sadly, I can't think of a better name. Do you have a suggestion? > Yes, I suppose this falls under the general exemption in 2.x for -3 warning changes. Thank

[issue28288] Expose environment variable for Py_Py3kWarningFlag

2016-11-28 Thread Berker Peksag
Berker Peksag added the comment: I can commit the patch this week if there are no objections to the name of the variable. I like Brett's PY3KWARNINGS suggestion, but I'm fine with either of the suggested names. -- ___ Python trac

[issue28820] Typo in section 6 of the Python 3.4 documentation

2016-11-30 Thread Berker Peksag
Berker Peksag added the comment: Ned can correct me if I'm wrong, but you can push documentation patches without waiting for 3.6.0rc1. -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/is

[issue28873] test_unittest failures when refleak hunting

2016-12-05 Thread Berker Peksag
Changes by Berker Peksag : -- stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/issue28873> ___ ___ Pyth

[issue28875] test fails and freezes

2016-12-05 Thread Berker Peksag
Berker Peksag added the comment: Please do not reopen this one. You already opened issue 28874. -- nosy: +berker.peksag stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.org/i

[issue28878] datetime should not be a subclass of date

2016-12-05 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> not a bug ___ Python tracker <http://bugs.python.org/issue28878> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue28089] asyncio: Document that TCP_NODELAY is now used by default

2016-12-05 Thread Berker Peksag
Berker Peksag added the comment: +.. versionchanged:: 3.6.0 3.6.0 -> 3.6 + The socket option TCP_NODELAY is now set by default. TCP_NODELAY -> ``TCP_NODELAY`` -- nosy: +berker.peksag stage: needs patch -> patch review ___ Python track

[issue28895] Two suggestions for windows.html

2016-12-07 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +steve.dower ___ Python tracker <http://bugs.python.org/issue28895> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28810] Document bytecode changes in 3.6

2016-12-07 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue28810> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28904] add more format conversion flags eg. "len" and "id"

2016-12-08 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: fixed -> rejected stage: -> resolved ___ Python tracker <http://bugs.python.org/issue28904> ___ ___ Python-bugs-

[issue28922] Add fixer for "import exceptions"

2016-12-09 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report and for the patch! This is a duplicate of issue 2350. Note that we accept patches from hg.python.org, not standalone Python files. See http://cpython-devguide.readthedocs.io/en/latest/patch.html for details. -- nosy

[issue28935] distutils use ConfigParser in Python 3.x and fails to parse setup.cfg with percent sign

2016-12-12 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report! This looks similar to issue 20754. Disabling string interpolation would break existing code (but probably just Python 3 only code) Would using %% instead of % be possible for you? (3.3 and 3.4 are in security-fix-only mode so I removed

[issue28946] AttributeError: module 'signal' has no attribute 'SIGALRM'

2016-12-12 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> resolved ___ Python tracker <http://bugs.python.org/issue28946> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue28935] distutils use ConfigParser in Python 3.x and fails to parse setup.cfg with percent sign

2016-12-12 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> resolved superseder: -> Distribution.parse_config_files uses interpolation since Python 3 ___ Python tracker <http://bugs.python.org/i

[issue20754] Distribution.parse_config_files uses interpolation since Python 3

2016-12-12 Thread Berker Peksag
Berker Peksag added the comment: Thanks! We also need a test case for the new behavior. -- stage: resolved -> patch review ___ Python tracker <http://bugs.python.org/issu

[issue28919] Simplify `_copy_func_details` in unittest.mock

2016-12-12 Thread Berker Peksag
New submission from Berker Peksag: Thanks for the patch. I only did a quick review, but it looks good to me. -- nosy: +berker.peksag, michael.foord stage: -> patch review ___ Python tracker <http://bugs.python.org/issu

[issue28923] Nonexisting encoding specified in Tix.py

2016-12-12 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +serhiy.storchaka, terry.reedy stage: -> patch review type: compile error -> behavior ___ Python tracker <http://bugs.python.org/i

[issue28932] Fail compile Python 3.6.0rc1 on OpenBSD 6.0

2016-12-12 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +haypo stage: -> patch review versions: +Python 3.7 ___ Python tracker <http://bugs.python.org/issue28932> ___ ___ Python-

[issue28512] PyErr_SyntaxLocationEx() and PyErr_SyntaxLocationObject() always set the offset attribute to None

2016-12-12 Thread Berker Peksag
Berker Peksag added the comment: Hi Serhiy, there are two commented-out lines in https://hg.python.org/cpython/rev/ea1c49ea8136#l3.10 (only in 3.5) +#with self.assertRaises(AssertionError): +#support.check_syntax_error(self, "x=1") -- nosy: +ber

[issue28919] Simplify `_copy_func_details` in unittest.mock

2016-12-13 Thread Berker Peksag
Berker Peksag added the comment: I will commit your patch today if Michael doesn't beat me to it. -- ___ Python tracker <http://bugs.python.org/is

[issue28963] Use-after-free in _asynciomodule.c

2016-12-13 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +inada.naoki ___ Python tracker <http://bugs.python.org/issue28963> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28919] Simplify `_copy_func_details` in unittest.mock

2016-12-14 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Jiajun! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue28944] A lack of line 6

2016-12-14 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, woo woo. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: +Python 3.6, Python 3.7 ___ Python tracker <http://

[issue28961] unittest.mock._Call ignores `name` parameter

2016-12-14 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Jiajun. The _Call class is tested in CallTest (located in Lib/unittest/test/testmock/testhelpers.py) Would it be possible to add a test case to make sure that we actually fixed the bug? -- nosy: +berker.peksag stage: commit review

[issue28954] Incorrect EBNF rule of keywords_arguments

2016-12-14 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +martin.panter ___ Python tracker <http://bugs.python.org/issue28954> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28794] inspect.isasyncgen and inspect.isasyncgenfunction aren't documented

2016-12-15 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, but these two functions have already been documented in 78c8f450b84c. Closing this as 'out of date'. -- nosy: +berker.peksag resolution: -> out of date stage: commit review -> resolved status: open -> closed ty

[issue28985] sqlite3 authorizer codes constants not up to date

2016-12-15 Thread Berker Peksag
Berker Peksag added the comment: Looks good to me. Thanks for the patch, Dingyuan. Since this is an enhancement request, we can only commit your patch to the default branch so I updated the versions field accordingly. -- nosy: +berker.peksag stage: -> patch review versions: -Pyt

[issue13051] Infinite recursion in curses.textpad.Textbox

2016-12-16 Thread Berker Peksag
Berker Peksag added the comment: The patch doesn't apply cleanly anymore so the next step would be to provide an updated patch. By the way, I can reproduce the first bug, but not the second one. If the second bug can't be reproducible anymore, we might need a simpler patch. -

[issue28987] Remove typo in whats new entry on Descriptor Protocol Enhancements

2016-12-16 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +Elvis.Pranskevichus, yselivanov ___ Python tracker <http://bugs.python.org/issue28987> ___ ___ Python-bugs-list mailin

[issue28957] undefined symbol: PyUnicodeUCS2_FromUnicode when executing any command with pip2.7

2016-12-16 Thread Berker Peksag
Berker Peksag added the comment: I think there are two different Python installations in your $PATH (the one you compiled with UCS4 and the other one is compiled with UCS2 - probably the system Python) Anyway, like Terry said, this is out of scope for this tracker. -- nosy

[issue29007] Virus detected when attempting to download numpy-1.11.3-cp35-none-win32.whl

2016-12-18 Thread Berker Peksag
Changes by Berker Peksag : -- assignee: christian.heimes -> resolution: -> third party stage: -> resolved status: open -> closed type: security -> ___ Python tracker <http://bugs.pyt

[issue29022] Aritmetic error

2016-12-20 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report, but it works as expected. Please see https://docs.python.org/2/tutorial/floatingpoint.html for more information. -- nosy: +berker.peksag resolution: -> not a bug stage: -> resolved status: open -&g

[issue29052] Detect Windows platform 32bit/64bit automatically

2016-12-23 Thread Berker Peksag
Berker Peksag added the comment: Thanks, it looks like a reasonable request to me, but the issue tracker for python.org is located at https://github.com/python/pythondotorg/issues Please open a new issue there (or send a pull request) -- nosy: +berker.peksag resolution: -> th

[issue29047] Where are the test results stored?

2016-12-24 Thread Berker Peksag
Changes by Berker Peksag : -- stage: -> resolved ___ Python tracker <http://bugs.python.org/issue29047> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue29047] Where are the test results stored?

2016-12-24 Thread Berker Peksag
Changes by Berker Peksag : -- versions: -Python 3.7 ___ Python tracker <http://bugs.python.org/issue29047> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29070] Integration tests for pty.spawn on Linux and all other platforms

2016-12-26 Thread Berker Peksag
Changes by Berker Peksag : -- components: -Cross-Build stage: -> patch review versions: +Python 3.6 ___ Python tracker <http://bugs.python.org/issu

[issue29056] logging.Formatter doesn't respect more than one formatException()

2016-12-26 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +vinay.sajip ___ Python tracker <http://bugs.python.org/issue29056> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29069] Default PyPI URL in docs is not what is really in code

2016-12-27 Thread Berker Peksag
Berker Peksag added the comment: Thanks! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: +Python 3.5, Python 3.6 ___ Python tracker <http://bugs.python

[issue20486] msilib: can't close opened database

2016-12-27 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, 12345. Steve knows better, but I think the method should be named "Close" instead of "close" like _msi.View's Close method. Also, I couldn't apply your patch: $ hg imp http://bugs.python.org/file45971/Add_

[issue29003] sqlite3: can't run VACUUM on Python 3.6

2016-12-29 Thread Berker Peksag
Berker Peksag added the comment: Thanks for trying pre-release versions of Python 3.6, Ma Lin. This has already been reported in issue 28518 so I'm closing this as a duplicate. -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -&g

[issue29115] distutils.core.setup does not let people set 'bugtrack_url'.

2016-12-30 Thread Berker Peksag
Berker Peksag added the comment: Marc-Andre is correct. bugtrack_url is a distribute/setuptools specific option. Please report your problem to them. -- nosy: +berker.peksag resolution: -> not a bug stage: -> resolved status: open -&g

[issue29115] distutils.core.setup does not let people set 'bugtrack_url'.

2016-12-30 Thread Berker Peksag
Berker Peksag added the comment: Again, this is not a distutils bug and it has already been reported to the setuptools maintainers: https://github.com/pypa/setuptools/issues/29 Quoting from the original report: > Currently setuptools.dist.Distribution passes the unfiltered collection &

[issue29098] document minimum sqlite version

2016-12-30 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker <http://bugs.python.org/issue29098> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29105] code or doc improvement for logging.handlers.RotatingFileHandler

2016-12-30 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +vinay.sajip ___ Python tracker <http://bugs.python.org/issue29105> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28518] execute("begin immediate") throwing OperationalError

2016-12-31 Thread Berker Peksag
Berker Peksag added the comment: I only did a quick review, but Aviv's latest patch looks reasonable to me. Thanks! And yes, we can add CheckVacuum back if it's not already tested. -- ___ Python tracker <http://bugs.python.o

[issue26267] UUID docs should say how to get "standard form"

2016-12-31 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Ammar. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker <http://bugs.python.or

[issue29123] CheckSqlTimestamp is fragile

2016-12-31 Thread Berker Peksag
New submission from Berker Peksag: == FAIL: CheckSqlTimestamp (sqlite3.test.types.DateTimeTests) -- Traceback (most recent call last): File "/root/buil

[issue29123] CheckSqlTimestamp is fragile

2016-12-31 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue29126] Fix comments about _PyThreadState_Current

2016-12-31 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +haypo ___ Python tracker <http://bugs.python.org/issue29126> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28911] Clarify the behaviour of assert_called_once_with

2016-12-31 Thread Berker Peksag
Changes by Berker Peksag : -- nosy: +berker.peksag, michael.foord -153957 stage: -> patch review type: enhancement -> behavior versions: -Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python.org/i

[issue28964] AST literal_eval exceptions provide no information about line number

2016-12-31 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch, Steve!. This looks like a reasonable request to me, but 1) we can only make this change in 3.7 2) we need a test case for the new message 3) you can use f-strings instead of str.format() -- nosy: +berker.peksag stage: -> pa

[issue29006] 2.7.13 _sqlite more prone to "database table is locked"

2017-01-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. I can also reproduce it with 3.5+. We may want to revert 030e100f048a for the next 2.7 and 3.5 releases if we can't come up with a solution. -- components: +Library (Lib) stage: -> needs patch type: -> behavi

[issue29024] Add Kivy entry to Graphic User Interface FAQ

2017-01-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> enhancement versions: +Python 3.5, Python 3.6 ___ Python tracker <http://

[issue29129] Copy/paste error in "8.13.14.1.1. Using auto"

2017-01-01 Thread Berker Peksag
Berker Peksag added the comment: Good catch! Thanks for the report, Michael. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: +Python 3.7 ___ Python tracker <http://

[issue29012] __bases__ is a tuple (possibly empty or a singleton)

2017-01-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Jim. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: -Python 3.3, Python 3.4 ___ Python tracker <http://bugs.python

[issue29013] zipfile: inconsistent doc for ZIP64 file size

2017-01-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report and for the analysis, Monte! -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: +Python 3.6, Python 3.7 ___ Py

[issue28985] sqlite3 authorizer codes constants not up to date

2017-01-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks, Dingyuan! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue15812] inspect.getframeinfo() cannot show first line

2017-01-01 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch Sam and thanks for the ping Peter! -- components: +Library (Lib) nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed type: -> behavior versions: +Python 3.5, Python 3.6

[issue29012] __bases__ is a tuple (possibly empty or a singleton)

2017-01-02 Thread Berker Peksag
Berker Peksag added the comment: Good point, Serhiy. Thanks for the patch, Jim. I've now removed the "possible a singleton" part. -- ___ Python tracker <http://bugs.pyt

[issue15812] inspect.getframeinfo() cannot show first line

2017-01-02 Thread Berker Peksag
Berker Peksag added the comment: You're right. Thanks for the review, Serhiy! -- ___ Python tracker <http://bugs.python.org/issue15812> ___ ___ Python-bugs-l

[issue29013] zipfile: inconsistent doc for ZIP64 file size

2017-01-02 Thread Berker Peksag
Berker Peksag added the comment: Right, that's my fault. Apparently I missed the "[...] zipfile will create [...]" part :) What do you think about Monte's suggested changes Serhiy? Should we just revert 4685cd33087b (1) or do both (1) and (2)? -- st

[issue27200] make doctest in CPython has failures

2017-01-02 Thread Berker Peksag
Berker Peksag added the comment: I agree with Ezio. -- ___ Python tracker <http://bugs.python.org/issue27200> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28961] unittest.mock._Call ignores `name` parameter

2017-01-03 Thread Berker Peksag
Berker Peksag added the comment: The patch looks good to me. There are some styling issues in the test code (e.g. no need to add trailing spaces after commas in some cases), but I can take care of them before committing the patch :) Thanks

[issue20608] 'SyntaxError: invalid token' is unfriendly

2017-01-03 Thread Berker Peksag
Changes by Berker Peksag : -- versions: +Python 3.7 -Python 3.5 ___ Python tracker <http://bugs.python.org/issue20608> ___ ___ Python-bugs-list mailing list Unsub

[issue29146] Confusing "invalid token" exception when integers have leading zero

2017-01-03 Thread Berker Peksag
Berker Peksag added the comment: Thanks for finding the duplicate. I'm closing this as a duplicate of issue 20608. -- components: -2to3 (2.x to 3.x conversion tool), Documentation nosy: +berker.peksag -docs@python resolution: -> duplicate stage: -> resolved status: ope

[issue16026] csv.DictReader argument names documented incorrectly

2017-01-03 Thread Berker Peksag
Berker Peksag added the comment: Welcome and thanks for the patch, Greg. csv.rst-patch looks good to me. I will commit it this week if there are no objections. Documentation updates can go into all active branches so I'm adding 3.5 and 3.6 back (we can pass 2.7 at this point since this

[issue29148] Inheritance behaviour ambiguos

2017-01-04 Thread Berker Peksag
Berker Peksag added the comment: You may find Raymond Hettinger's "super() considered super" article helpful to understand how Python's super() works: https://rhettinger.wordpress.com/2011/05/26/super-considered-super/ --

[issue29152] unittest subTest does not call addFailure

2017-01-04 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. That's because TestResult.addSubTest() updates TestResult.errors and TestResult.failures itself instead of calling the addError() and addFailure() methods respectively: if issubclass(err[0], test.failureException): e

[issue29162] pyshell.py: name 'sys' is not defined

2017-01-04 Thread Berker Peksag
Berker Peksag added the comment: I think the OP is talking about Lib/idlelib/pyshell.py. The relevant changeset is 76f831e4b806. "from tkinter import *" imports the sys module as a side-effect. OO O, did you notice this by reading the code or by using a tool like flake8? -

[issue29021] Custom functions in sqlite receive None on invalid UTF-8

2017-01-04 Thread Berker Peksag
Berker Peksag added the comment: We can just fallback to the current behavior (i.e. return None) if the return type of text_factory(val_str) is not str, bytes or bytearray. I think this is also somewhat similar to what we do for the return values of sqlite3_column_text(). -- nosy

[issue29162] pyshell.py: name 'sys' is not defined

2017-01-04 Thread Berker Peksag
Berker Peksag added the comment: Great, thanks for following up with us. -- resolution: -> not a bug stage: -> resolved ___ Python tracker <http://bugs.python.org/i

[issue29162] pyshell.py: name 'sys' is not defined

2017-01-04 Thread Berker Peksag
Berker Peksag added the comment: I misread your comment. I think we need to add "import sys" to that file so I'm reopening this. -- keywords: +easy resolution: not a bug -> stage: resolved -> needs patch status: closed -> op

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

2017-01-04 Thread Berker Peksag
Berker Peksag added the comment: Note: We don't officially use pull requests yet. Current way of contributing to Python is documented at https://docs.python.org/devguide/patch.html -- nosy: +berker.peksag ___ Python tracker <http://bugs.py

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

2017-01-05 Thread Berker Peksag
Berker Peksag added the comment: Yes, thanks! -- nosy: +martin.panter, xiang.zhang stage: -> patch review type: -> behavior versions: +Python 3.5, Python 3.6, Python 3.7 ___ Python tracker <http://bugs.python.org/i

[issue29163] shlex error in posix mode and empty quotes

2017-01-05 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> out of date stage: -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue29142] urllib: no_proxy variable values with leading dot not properly handled

2017-01-05 Thread Berker Peksag
Changes by Berker Peksag : -- type: -> behavior versions: +Python 3.5, Python 3.6, Python 3.7 ___ Python tracker <http://bugs.python.org/issue29142> ___ ___ Py

[issue28848] Add CopyingMock to mock.py

2017-01-05 Thread Berker Peksag
Berker Peksag added the comment: Thanks for releasing it on PyPI! It's probably better to keep it as an example in the documentation for now. We can reopen this if there's a demand for CopyingMock in the future. -- nosy: +berker.peksag resolution: -> rejected stage:

[issue28231] zipfile does not support pathlib

2017-01-05 Thread Berker Peksag
Berker Peksag added the comment: I think the next steps are: 1. Add tests for the cases Serhiy has mentioned in msg277109: > Shouldn't the ZipFile.filename attribute be converted to str? and > The file name of ZipFile is only a part of the issue. There are other uses of

[issue29170] Curses Module should check for is_keypad and not window flags

2017-01-05 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> duplicate stage: -> resolved superseder: -> Fix curses module compilation with ncurses6 ___ Python tracker <http://bugs.python.or

[issue28961] unittest.mock._Call ignores `name` parameter

2017-01-06 Thread Berker Peksag
Berker Peksag added the comment: IIRC 3.5.3rc1 is already tagged so the 3.5 branch is open for 3.5.4. Anything that needs to be in 3.5.3 should be cherry-picked by the RM at this point if I'm not mistaken (and note that I don't have time check, but 3.5.3 may be the last bugfix rele

[issue29182] Remove the warning in urllib docs that it doesn't do certificate validate by default.

2017-01-06 Thread Berker Peksag
Changes by Berker Peksag : -- stage: patch review -> commit review ___ Python tracker <http://bugs.python.org/issue29182> ___ ___ Python-bugs-list mai

[issue29189] Broken indentation in FancyURLopener documentation

2017-01-06 Thread Berker Peksag
New submission from Berker Peksag: I noticed this while taking a look at urllib docs for issue 29182. Indentation of prompt_user_passwd() is broken and it looks like it's part of the note directive: https://docs.python.org/2/library/urllib.html#urllib.FancyURLopener.prompt_user_passwd P

[issue29189] Broken indentation in FancyURLopener documentation

2017-01-06 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the review, Senthil. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <http://bugs.python.or

[issue16026] csv.DictReader argument names documented incorrectly

2017-01-06 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patches James and Greg! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: -Python 3.5 ___ Python tracker <http://bugs.python.or

<    13   14   15   16   17   18   19   20   21   22   >