Barry A. Warsaw added the comment:
On Jul 27, 2013, at 03:13 PM, Guido van Rossum wrote:
>- I think we should recommend against tabs outright. They are getting more
>- and more misunderstood.
+1
>- Regarding line length, I think it is reasonable to mention that many
>- organ
Barry A. Warsaw added the comment:
On Jul 28, 2013, at 09:48 PM, Nick Coghlan wrote:
>
>Nick Coghlan added the comment:
>
>"with statements are good", basically.
`with ExitStack() as stack` is even better :)
--
___
Barry A. Warsaw added the comment:
On Jul 28, 2013, at 04:59 AM, Raymond Hettinger wrote:
>- Regarding line length, I think it is reasonable to mention that many
>organizations are settling on 100 as a compromise. On newer laptops you
>can still fit two terminal windows (with a reason
Barry A. Warsaw added the comment:
Hah, I just ran into this too. I was perplexed why my load_tests() function
wasn't being called and ended up pdb'ing unittest's discover, and found exactly
this problem. I'm not surprised lifeless beat me to it.
(My use case was to pig
Barry A. Warsaw added the comment:
Seems like this patch does the trick for my very limited testing.
--
keywords: +patch
Added file: http://bugs.python.org/file31102/16662.diff
___
Python tracker
<http://bugs.python.org/issue16
Barry A. Warsaw added the comment:
On Aug 01, 2013, at 12:19 PM, Nick Coghlan wrote:
>I *didn't* make any changes in relation to Barry's comment about having the
>commentary intermixed with the guidelines. I quite like the notion of
>stripping PEP 8 down to just the essent
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue18709>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue17997>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue18677>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
Applied the fix to 2.6 and null merged into 2.7. This didn't need a NEWS entry
because the regression hadn't been released yet. I'll remove 2.6 from the
Versions now.
--
___
Python
Changes by Barry A. Warsaw :
--
versions: -Python 2.6
___
Python tracker
<http://bugs.python.org/issue16248>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
On Aug 21, 2013, at 11:49 AM, Christian Heimes wrote:
>I have taken care of Antoine's and Victor's reviews. The fix has landed in
>Python 2.7, 3.3 and 3.4. What about 2.6, 3.1 and 3.2? After all it's a
>security fix (although I don&#x
Barry A. Warsaw added the comment:
On Sep 03, 2013, at 07:37 AM, Stephen J. Turnbull wrote:
>I'm thinking this may be overengineering, but I may as well post it and find
>out for sure. :-) Is it worth encapsulating MIME types? They're "really"
>pairs as far as m
Barry A. Warsaw added the comment:
blocker for 2.6.9
--
nosy: +barry
priority: critical -> release blocker
___
Python tracker
<http://bugs.python.org/issu
Barry A. Warsaw added the comment:
blocker for 2.6.9
--
nosy: +larry
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org/issu
Barry A. Warsaw added the comment:
blocker for 2.6.9
--
nosy: +barry
priority: critical -> release blocker
___
Python tracker
<http://bugs.python.org/issu
Barry A. Warsaw added the comment:
blocker for 2.6.9
--
nosy: +barry
priority: critical -> release blocker
___
Python tracker
<http://bugs.python.org/issu
Barry A. Warsaw added the comment:
blocker for 2.6.9
--
priority: critical -> release blocker
___
Python tracker
<http://bugs.python.org/issue16043>
___
___
Py
Barry A. Warsaw added the comment:
blocker for 2.6.9
--
priority: critical -> release blocker
___
Python tracker
<http://bugs.python.org/issue16037>
___
___
Py
Barry A. Warsaw added the comment:
blocker for 2.6.9
--
priority: critical -> release blocker
___
Python tracker
<http://bugs.python.org/issue16042>
___
___
Py
Barry A. Warsaw added the comment:
On Sep 04, 2013, at 07:47 PM, Ethan Furman wrote:
>I'm pretty sure we don't want that.
Agreed, although a "we're all consenting adults" argument could be made.
--
___
Python trac
Barry A. Warsaw added the comment:
On Sep 04, 2013, at 08:18 PM, Eli Bendersky wrote:
>[Barry, how come your name in the tracker is linked to your website? me
>wants...]
Go to "Your Details" in the left sidebar and enter a "Homepage".
--
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue15873>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
On May 05, 2012, at 01:25 AM, R. David Murray wrote:
>I've always wondered why the code did that. If Barry doesn't have a good
>reason for it, I'll refactor it at some point.
A long time ago, Tim (IIRC) expressed an opinion that using t
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue14703>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue10530>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue14894>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
On May 23, 2012, at 10:13 PM, Éric Araujo wrote:
>
>Thanks for the report. How did you find this? According to the doc of
>LooseVersion, 'a' is not valid, so I would like a real example to accept this
>as a bug.
It works in Python
Barry A. Warsaw added the comment:
On May 24, 2012, at 03:03 PM, Éric Araujo wrote:
>> But if 'a' is invalid, then LooseVersion should refuse to accept it in its
>> constructor, right?
>It’s complicated. The doc does not say much, the docstring however clearly
>
Barry A. Warsaw added the comment:
One small test that I think is missing is a test that
sys.implementation.version and sys.implementation.hexversion are equal (modulo
format differences).
--
___
Python tracker
<http://bugs.python.org/issue14
Barry A. Warsaw added the comment:
I'm not a fan of using a module, and less of a fan of structseq, so I think
I'll discount those two. I'll play with namespace and type next.
--
___
Python tracker
<http://bugs.pyt
Barry A. Warsaw added the comment:
I'm inclined to go with the as_simple_namespace patch. As you say, the pro are
that this is a much better fit for this use case, while the con is that this
does kind of sneak in a new type. Given that the type is not exposed in the
API, that do
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue14942>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
Looking great, you're almost there! I remviewed
issue14673_as_simple_namespace_2.diff and issue14673_full.diff. Reitveld makes
it *so* much easier :)
--
___
Python tracker
<http://bugs.python.org/is
Barry A. Warsaw added the comment:
On Jun 01, 2012, at 06:53 PM, Eric Snow wrote:
>sorry, I should have been more clear. issue14673_full.diff is not simply a
>merging of the two previous patches, but rather their merger, plus
>SimpleNamespace, plus removing the "public" r
Barry A. Warsaw added the comment:
On Jun 02, 2012, at 11:33 PM, Eric Snow wrote:
>Added file: http://bugs.python.org/file25804/issue14673_full_4.diff
Hi Eric. I'm ready to do a final review and merge this in, but I just want to
be sure I'm looking at the right file. Is full_4.
Barry A. Warsaw added the comment:
On Jun 02, 2012, at 09:59 PM, R. David Murray wrote:
>I've applied this to 3.3. Because the preservation of spaces around the
>ascii parts is a visible behavior change that could cause working programs to
>break, I don't think I can back
Barry A. Warsaw added the comment:
On Jun 02, 2012, at 08:03 AM, Amaury Forgeot d'Arc wrote:
>- _PyNamespace_New should be a public API function. From Python code,
>- SimpleNamespace is public.
This is a separate discussion. I'm not opposed, but I don't think this s
Barry A. Warsaw added the comment:
I'm resolving this as Fixed since I've just committed the code to 3.3, but I'm
also leaving its status open and assigning it to mvl for verification of the
Windows build. Martin, if you'd rather not do that, please unassign it from
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue14908>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
I completely agree. As easy (but obscure) as it is, it seems quite silly to
have to go through time.mktime(dt.timetuple())
--
___
Python tracker
<http://bugs.python.org/issue14
Barry A. Warsaw added the comment:
On Jun 04, 2012, at 03:45 PM, Alexander Belopolsky wrote:
>Did you review the long discussion under issue 2736? Specifically, please
>note the part about mxDateTime, ticks() and gmticks(). I am -0 on adding
>ticks() and gmticks() and as far as I ca
Barry A. Warsaw added the comment:
On Jun 04, 2012, at 04:03 PM, Alexander Belopolsky wrote:
>That's a valuable experience. How big of a deal was the lack of
>.ticks() and .gmticks()? How did you work around it?
It was *much* less of an issue than all the magic date format parsin
Barry A. Warsaw added the comment:
On Jun 04, 2012, at 09:39 PM, Eric Snow wrote:
>presumably PEP 421 can be marked as final now?
Done.
--
___
Python tracker
<http://bugs.python.org/issu
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue9527>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
On Jun 20, 2012, at 01:58 PM, R. David Murray wrote:
>Barry: I think we should documentationally deprecate the encoders module. I
>can't see any utility in a new program calling those functions explicitly,
>especially if the program ever wa
Barry A. Warsaw added the comment:
On Jun 20, 2012, at 01:51 PM, R. David Murray wrote:
>Note that I don't *like* that the current API is that calling set_charset
>does the body encode if and only if there are no existing headers, but that
>is the way it has always worked,
Barry Alan Scott added the comment:
I'm happy to review patches or create them for you.
I see a related set of errors on Mac OS X that are down to issues in
bytes_methods.py that mirror the pyport.h issues.
In C++ isspace and friends are functions not macros.
You cannot go around def
Barry A. Warsaw added the comment:
On Jul 21, 2012, at 02:23 PM, Georg Brandl wrote:
>Ping. Barry? (It's not strictly necessary to have the docs for b2, but could
>you give me a rough estimate when you'll do this?)
Unfortunately, I lost a bunch of work with a disk crash,
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue11602>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Barry A. Warsaw :
To assist with vendor builds, Matthias has requested added a --configdir option
to the python3-config script. This would return
sysconfig.get_config_var('LIBPL'). The value is embedded in the output for
--ldflags, but not in a convenient
Changes by Barry A. Warsaw :
--
nosy: +doko
___
Python tracker
<http://bugs.python.org/issue15458>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Barry A. Warsaw :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15458>
___
___
Python-bugs-list
New submission from Barry A. Warsaw :
Very minor style nit. In general, it's not considered good style to use
mutable objects in default argument values. importlib's
_bootstrap.__import__() does just this for its globals, locals, and fromlist
arguments.
The implementation current
New submission from Barry A. Warsaw :
I think this is mostly just out of date documentation, but I want to get
Brett's feedback. The sys module has this to say about sys.path_importer_cache:
"A dictionary acting as a cache for finder objects. The keys are paths that
have been
Barry A. Warsaw added the comment:
First draft is complete, along with updates to the importlib abcs for the new
protocols. You'll see the language reference has a new importmachinery.rst
file which describes finding and loading modules. You'll see that the import
statement docs
Changes by Barry A. Warsaw :
--
priority: deferred blocker -> release blocker
stage: needs patch -> patch review
title: Document PEP 420 namespace packages -> Import machinery documentation
___
Python tracker
<http://bugs.python.or
Barry A. Warsaw added the comment:
Thanks for the review Eric. I'm slogging through these and many other
comments, but I now have the docs integrated with trunk, and will probably
land them for better or worse in the next day or so.
I'll respond just to a few of your comments. Whate
Barry A. Warsaw added the comment:
On Jul 29, 2012, at 05:10 AM, Nick Coghlan wrote:
>I would title the new section "Import system" rather than "Import machinery"
>as it is meant to be a specification documentation rather than an
>implementation description.
Barry A. Warsaw added the comment:
On Jul 29, 2012, at 06:09 AM, Nick Coghlan wrote:
>runpy, pkgutil, et al should all get "See Also" links at the top pointing to
>the new import system section.
I've put an XXX in the import.rst file for this, but I probably won't g
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue15502>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
On Jul 30, 2012, at 09:41 PM, Brett Cannon wrote:
>As for the diagram(s), I have attached the overall PDF that I still have from
>my original Omnifgraffle file (which I don't have a license to anymore) that
>I built my PyCon 2008 presentat
Barry A. Warsaw added the comment:
On Jul 31, 2012, at 12:28 AM, Eric Snow wrote:
>> You ask in [2] whether "path importer" refers specifically to the callables
>> on sys.path_hooks. Can you site a reference for this? I found one
>> reference in PEP 302 to &quo
Barry A. Warsaw added the comment:
I think I was unclear in my previous follow up. Here are the objects
involved, taken from the glossary.
import path
A list of locations (or :term:`path entries `) that are
searched by the :term:`path importer` for modules to import. During
Barry A. Warsaw added the comment:
On Jul 31, 2012, at 03:21 AM, Eric Snow wrote:
>1. default path importer (a.k.a PathFinder),
+1, although currently I am refraining from using "default" when describing
this thing.
>2. path hook (lives on sys.path_hooks),
I have called t
Changes by Barry A. Warsaw :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15295>
___
___
Python-bugs-list
Barry A. Warsaw added the comment:
On Jul 31, 2012, at 08:30 PM, Brett Cannon wrote:
>The import path definition is a little misleading as sys.path is only
>inferred when 'path' has None passed in. Otherwise 'path' is what __path__ in
>a package is set to, so te
Barry A. Warsaw added the comment:
On Jul 31, 2012, at 02:56 PM, Eric Snow wrote:
>Part of the problem with the import nomenclature is that PEP 302 doesn't
>really nail it down and mixes the terms up a bit. This is understandable
>considering it broken ground in some regard. Ho
Barry A. Warsaw added the comment:
On Jul 30, 2012, at 04:39 AM, Meador Inge wrote:
>Meador Inge added the comment:
>
>How about the attached?
What about something like:
globals = ({} if globals is None else globals)
and similarly f
Barry A. Warsaw added the comment:
I've mostly run out of time to work on the docs, but I do want to say that I
thought long and hard about all the terminology decisions. Please don't
change them lightly, and definitely don't change them until you've tried to go
through t
Barry A. Warsaw added the comment:
On Aug 01, 2012, at 10:03 PM, Nick Coghlan wrote:
>1. "path import subsystem" for that whole section of the import machinery;
>and
>2. "path import finder" specifically for the meta path finder that
>importlib calls "PathFi
Barry A. Warsaw added the comment:
On Aug 01, 2012, at 10:44 PM, Nick Coghlan wrote:
>The problem with "path importer" is it's just plain *wrong*. That object is
>not an importer and thus calling it one makes it much harder to learn the
>finder/loader/importer distincti
Barry A. Warsaw added the comment:
What about "Path Scanner"? Came to me in a dream, so it has to be perfect,
right? :)
--
___
Python tracker
<http://bugs.python.o
Barry A. Warsaw added the comment:
On Aug 02, 2012, at 11:33 AM, Nick Coghlan wrote:
>Specifically, what I did was to drop "find_module" from the Finder ABC, but
>keep the ABC itself as a way to document the common "invalidate_caches"
>API. The ABC definitio
Barry A. Warsaw added the comment:
On Aug 05, 2012, at 11:50 PM, Brett Cannon wrote:
>I went with Barry's approach but made it compatible with PEP 8 (bad, FLUFL;
>no unneeded parens!).
I actually think I picked that up from the big guy himself, but I could be
mis
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue15591>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Barry A. Warsaw:
Run the following code snippet:
-snip snip-
import argparse
parser = argparse.ArgumentParser()
parser.add_argument("--test", dest="test", type=str,
default=[], action='append')
args = parser.parse_args()
p
Changes by Barry A. Warsaw :
--
nosy: +benjamin.peterson, georg.brandl
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org/issu
Barry A. Warsaw added the comment:
Marking it as a release blocker and adding 3.3 since 3.3 hg trunk is affected.
--
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue15
Barry A. Warsaw added the comment:
On Sep 10, 2012, at 05:21 PM, Georg Brandl wrote:
>I don't see how this affects 3.3: you seem to be saying the behavior is fine
>there.
No, I thought it was because I tested the Ubuntu rc2 version, but the problem
exists in upstream hg 3
Changes by Barry A. Warsaw :
--
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue15906>
___
___
Python-bugs-list mailing list
Unsubscribe:
Barry A. Warsaw added the comment:
On Sep 10, 2012, at 05:59 PM, Georg Brandl wrote:
>But it's not a release blocker for 3.3 then.
Fair enough!
--
___
Python tracker
<http://bugs.python.org
Barry A. Warsaw added the comment:
Okay, this bug is clearly caused by the patch applied for issue 12776. Here's
the patch set url: http://hg.python.org/cpython/rev/74f6d87cd471
Now, if you look at this, I think this changes the semantics for non-string
default with a type converter, bu
Barry A. Warsaw added the comment:
On Sep 11, 2012, at 04:15 PM, Chris Jerdonek wrote:
>I haven't thought about this very long, but what would happen if the "type"
>conversion is only called on arguments and default arguments that are
>strings, and otherwise left alon
Barry A. Warsaw added the comment:
On Sep 11, 2012, at 07:00 PM, R. David Murray wrote:
>To repeat: there is no change to be made for 3.3. 3.3.0 will go out the door
>with the pre-12776 behavior. So any backward compatibility concerns that
>apply to 2.7 and 3.2 also apply to 3.3
New submission from Barry A. Warsaw:
After a fresh clone, configure && make fails due to a fairly obvious bug in the
code. Note that if you `hg revert --all`, configure && make will succeed,
probably because the timestamps get updated enough to fool make.
@resist[~/projects/
Barry A. Warsaw added the comment:
On Sep 12, 2012, at 10:57 AM, Steven Bethard wrote:
>(1) Yes, the error is that the isinstance(action.default, str) check was lost
Except that it won't work any more in the original location. I tried it and
it broke other tests. Maybe I did it w
Barry A. Warsaw added the comment:
On Sep 12, 2012, at 10:39 AM, R. David Murray wrote:
>diff --git a/Lib/argparse.py b/Lib/argparse.py
>--- a/Lib/argparse.py
>+++ b/Lib/argparse.py
>@@ -1962,7 +1962,8 @@
> # only if it was defined already i
Barry A. Warsaw added the comment:
On Sep 12, 2012, at 04:22 AM, Chris Jerdonek wrote:
>The argparse documentation makes it pretty clear that 'type' is meant to be
>applied only to strings.
Then test_type_function_call_with_non_string_default() which was added to fix
#12776
Barry A. Warsaw added the comment:
On Sep 12, 2012, at 03:03 PM, R. David Murray wrote:
>Actually, no, the test should not be removed, it should be reversed so as to
>test the documented behavior.
Good point.
--
___
Python tracker
Changes by Barry A. Warsaw :
Added file: http://bugs.python.org/file27180/15906-3.diff
___
Python tracker
<http://bugs.python.org/issue15906>
___
___
Python-bugs-list m
Barry A. Warsaw added the comment:
On Sep 12, 2012, at 02:48 PM, Steven Bethard wrote:
>We should not be converting non-string defaults, or the documentation's
>description of the type= argument doesn't make sense.
Agreed. If we also take RDM's suggestion of r
Barry A. Warsaw added the comment:
On Sep 12, 2012, at 03:40 PM, Steven Bethard wrote:
>Ok, sounds good. Let's make the test check the documented behavior, and then
>add back the isinstance(action.default, str) check.
See patch 15906-3.diff for Python 2.7. If acceptable, I wil
Barry A. Warsaw added the comment:
Oops, one small correction for 15906-3.diff: In Python 2.7, s/str/basestring/
Obviously isinstance should just check for str-y-ness in Python 3.{2,3}
--
___
Python tracker
<http://bugs.python.org/issue15
Barry A. Warsaw added the comment:
On Sep 12, 2012, at 05:19 PM, R. David Murray wrote:
>All three of those sound like good ideas (testing string conversion,
>clarifying docs, adding the no-double conversion test). Do you want to
>prepare the patch, Chris? Barry can apply his any
Barry A. Warsaw added the comment:
Chris, it's all yours. I am however going to close the bug as fixed.
--
___
Python tracker
<http://bugs.python.org/is
Changes by Barry A. Warsaw :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15906>
___
___
Python-bugs-list
Barry A. Warsaw added the comment:
Looks good to me too! Thanks; I'll apply the patch.
--
assignee: docs@python -> barry
___
Python tracker
<http://bugs.python.org
Changes by Barry A. Warsaw :
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue15935>
___
___
Python-bugs-list
Changes by Barry A. Warsaw :
--
nosy: +barry
___
Python tracker
<http://bugs.python.org/issue12014>
___
___
Python-bugs-list mailing list
Unsubscribe:
1901 - 2000 of 2726 matches
Mail list logo
