[issue12343] ssl documentation needs comments about non-blocking behaviour

2011-06-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: So let's turn this into a documentation issue, then. -- assignee: -> docs@python components: +Documentation, Library (Lib) -Extension Modules nosy: +docs@python priority: critical -> normal resolution: invalid -> status: closed -> o

[issue12328] multiprocessing's overlapped PipeConnection on Windows

2011-06-16 Thread Antoine Pitrou
Antoine Pitrou added the comment: > > Hmm, it seems to me that it should be done in _poll() instead. > > Otherwise, recv() will not be interruptible, will it? > > Or maybe WaitForMultipleObjects() should be changed to also wait on > sigint_event if called by the main thre

[issue9246] os.getcwd() hardcodes max path len

2011-06-17 Thread Antoine Pitrou
Antoine Pitrou added the comment: > From a practicality point of view, we need to make no change at all: > nobody sane ever has a current working directory path of more than > 1000 characters. Even if people have very long path names, they > don't make them the current work

[issue12367] select.error has no errno attribute

2011-06-20 Thread Antoine Pitrou
Antoine Pitrou added the comment: You can't do this outside of a PEP (see PEP 3151). -- resolution: -> rejected status: open -> closed ___ Python tracker <http://bugs.python.

[issue12326] Linux 3: tests should avoid using sys.platform == 'linux2'

2011-06-22 Thread Antoine Pitrou
Antoine Pitrou added the comment: > So people who say sys.platform shouldn't be used: what do you propose to > do with Lib/plat-linux2 (or, more generally, Lib/plat-*)? These directories look useless to me. (IIRC, putting an obvious syntax error there does not trigger any fai

[issue6721] Locks in python standard library should be sanitized on fork

2011-06-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: > If there's agreement that the general problem is unsolvable (so fork and > threads just don't get along with each other), what we could attempt is > trying to limit the side effects in the standard library, so that fewest > users as po

[issue12291] file written using marshal in 3.2 can be read by 2.7, but not 3.2 or 3.3

2011-06-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le Sun, 26 Jun 2011 19:49:03 +, Vinay Sajip a écrit : > > Added file: http://bugs.python.org/file22487/0feab4e7b27f.diff Just a nit, could you give descriptive file names to your patches? Hex numbers quickly get con

[issue12326] Linux 3: tests should avoid using sys.platform == 'linux2'

2011-06-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le Mon, 27 Jun 2011 08:05:05 +, Martin v. Löwis a écrit : > > What I'm advocating is to special-case Linux (and any other system > where major version numbers don't mean much). Actually, it would itself break compatibility, because

[issue5375] Unified locals/consts array + register-based instructions

2011-06-27 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- resolution: -> postponed status: open -> closed ___ Python tracker <http://bugs.python.org/issue5375> ___ ___ Python-bugs-

[issue10181] Problems with Py_buffer management in memoryobject.c (and elsewhere?)

2011-06-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le Mon, 27 Jun 2011 13:17:57 +, Nick Coghlan a écrit : > > The TL;DR version of the above is that I would like to see it become: > > typedef struct { > PyObject_HEAD > PyManagedBuffer source_data; // shared read-onl

[issue12407] test_subinterps fails on Windows

2011-06-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: I don't really understand why you need this. Under normal setups, the test is already properly skipped under Windows, since there's no rule to build the "Modules/_testembed" with MSVC. Or are you talking about another kind of

[issue12352] multiprocessing.Value() hangs

2011-06-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: Nice work! I also think heap_gc_deadlock_lockless.diff is good, except for Victor's reservation: is it deliberate that you reversed the following two statements in _free_pending_blocks(), compared to the code in free()? +self._free(

[issue12380] bytearray methods center, ljust, rjust don't accept a bytearray as the fill character

2011-06-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: I do agree it is a nuisance that it doesn't work with bytearray instances. After all, these methods are supposed to be homogeneous, and they are when called on a str or bytes object. -- assignee: docs@python -> stage: committed/rejected

[issue12380] bytearray methods center, ljust, rjust don't accept a bytearray as the fill character

2011-06-28 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- components: -Documentation ___ Python tracker <http://bugs.python.org/issue12380> ___ ___ Python-bugs-list mailing list Unsub

[issue10403] Use "member" consistently

2011-06-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: So I'm -1 on using "attributes" to denote methods. It will actively confuse non-expert users. If you want to ditch "members", please consider using the more explicit phrase "attributes and metho

[issue12440] test_ssl.test_options() failure on Snow Leopard: can't clear options before OpenSSL 0.9.8m

2011-06-29 Thread Antoine Pitrou
Antoine Pitrou added the comment: The OpenSSL version linked against is "OpenSSL 0.9.8r 8 Feb 2011", but apparently the source headers are still those for an earlier version, hence the apparent failure (the headers don't have the necessary API). Bill, could you please upgr

[issue12139] Add CCC command support to ftplib

2011-06-29 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- resolution: -> fixed status: pending -> open ___ Python tracker <http://bugs.python.org/issue12139> ___ ___ Python-bugs-list

[issue12442] shutil.disk_usage()

2011-06-30 Thread Antoine Pitrou
Antoine Pitrou added the comment: Why do you return a percentage? People can compute that themselves if they want to. -- ___ Python tracker <http://bugs.python.org/issue12

[issue6721] Locks in python standard library should be sanitized on fork

2011-06-30 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I was thinking about a run time warning that is emitted if you call > os.fork() while multiple threads are active. It is ugly, but at least > it tells you you are doing something that will in most cases not work > correctly. The pro

[issue9504] signal.signal/signal.alarm not working as expected

2011-06-30 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- assignee: pitrou -> stage: patch review -> needs patch versions: +Python 3.3 -Python 3.1 ___ Python tracker <http://bugs.python.org/

[issue12407] test_subinterps fails on Windows

2011-06-30 Thread Antoine Pitrou
Antoine Pitrou added the comment: Fixed, thank you. -- resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: +Python 3.2 ___ Python tracker <http://bugs.python.or

[issue12291] file written using marshal in 3.2 can be read by 2.7, but not 3.2 or 3.3

2011-06-30 Thread Antoine Pitrou
Antoine Pitrou added the comment: I think the question is: will the slowdown apply to module import, or only to explicit uses of the marshal module? If the latter, then I think we can live with it - we discourage using marshal as a general-purpose serialization scheme anyway. As for the

[issue7123] Multiprocess Process does not always exit when run from a thread.

2011-06-30 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +neologix ___ Python tracker <http://bugs.python.org/issue7123> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6721] Locks in python standard library should be sanitized on fork

2011-06-30 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I would add a big fat note that multiprocessing.Process should be > used instead today, because how about those of us who are not > sophisticated enough to be appointed to standard committees? How do you think multiprocessing.Process launches a ne

[issue12291] file written using marshal in 3.2 can be read by 2.7, but not 3.2 or 3.3

2011-06-30 Thread Antoine Pitrou
Antoine Pitrou added the comment: > > - "assertEqual = self.assertEqual" is more of a nuisance than anything > > else; > >you're making the code more complicated to read just to save a few > >keystrokes; > >same for "assertIsInstance =

[issue6721] Locks in python standard library should be sanitized on fork

2011-06-30 Thread Antoine Pitrou
Antoine Pitrou added the comment: > > How do you think multiprocessing.Process launches a new process? > > But it's a single piece of code under control and even > multi-OS/multi-architecture test-coverage, not a general purpose > "Joe, you may just go that w

[issue12459] time.sleep(-1.0) behaviour

2011-07-01 Thread Antoine Pitrou
Antoine Pitrou added the comment: I agree with the ValueError suggestion. Since it would slightly change existing behaviour, it can only be done in a feature release (3.3). According to Google Code Search, deliberate uses of sleep(-1) are almost non-existent: http://www.google.com/codesearch

[issue12462] time.sleep(1): call PyErr_CheckSignals() if the sleep was interrupted

2011-07-01 Thread Antoine Pitrou
Antoine Pitrou added the comment: You don't *need* to call PyErr_CheckSignals() explicitly, PyErr_SetFromErrno() does it for you. -- ___ Python tracker <http://bugs.python.org/is

[issue12462] time.sleep(1): call PyErr_CheckSignals() if the sleep was interrupted

2011-07-01 Thread Antoine Pitrou
Antoine Pitrou added the comment: > My new patch is more explicit: only add a special case for the select > implementation, if errno is EINTR. Looks good to me! -- ___ Python tracker <http://bugs.python.org/i

[issue12456] Hangs in concurrent.futures

2011-07-01 Thread Antoine Pitrou
Antoine Pitrou added the comment: This patch should fix the issue. Can you confirm? -- keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file22539/cfshutdown.patch ___ Python tracker <http://bugs.python.org/issu

[issue12291] file written using marshal in 3.2 can be read by 2.7, but not 3.2 or 3.3

2011-07-01 Thread Antoine Pitrou
Antoine Pitrou added the comment: Latest patch looks ok to me. -- ___ Python tracker <http://bugs.python.org/issue12291> ___ ___ Python-bugs-list mailin

[issue12213] BufferedRandom, BufferedRWPair: issues with interlaced read-write

2011-07-01 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- priority: normal -> critical type: -> behavior ___ Python tracker <http://bugs.python.org/issue12213> ___ ___ Python-bugs-

[issue10898] posixmodule.c redefines FSTAT

2011-07-01 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ah, sorry. Can you check with the changeset I've just pushed (it's on branch 2.7)? If ok, I'll port it to 3.2/3.x and close again. -- resolution: accepted -> fixed ___ Python tracker <h

[issue10898] posixmodule.c redefines FSTAT

2011-07-01 Thread Antoine Pitrou
Antoine Pitrou added the comment: Hum, can you propose something? -- ___ Python tracker <http://bugs.python.org/issue10898> ___ ___ Python-bugs-list mailin

[issue12352] multiprocessing.Value() hangs

2011-07-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: +if gc.isenabled(): +thresholds = gc.get_threshold() +self.addCleanup(gc.set_threshold, *thresholds) +else: +gc.enable() +self.addCleanup(gc.disable) It seems you won't restore the threshol

[issue10898] posixmodule.c redefines FSTAT

2011-07-02 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I've had to split the three #undef's up to just before they're used. I would really prefer to move up the offending #include rather than sprinkle those #undef's all over the place. -- __

[issue12456] Hangs in concurrent.futures

2011-07-02 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue12456] Hangs in concurrent.futures

2011-07-03 Thread Antoine Pitrou
Antoine Pitrou added the comment: Looks like I broke the OS X buildbots: http://www.python.org/dev/buildbot/all/builders/AMD64%20Snow%20Leopard%202%203.x/builds/609/steps/test/logs/stdio -- status: closed -> open ___ Python tracker &l

[issue12456] Hangs in concurrent.futures

2011-07-03 Thread Antoine Pitrou
Antoine Pitrou added the comment: Ok, qsize() can raise NotImplementedError on OS X, which explains quite a bit: Exception in thread Thread-2: Traceback (most recent call last): File "/Users/buildbot/buildarea/custom.parc-snowleopard-1/build/Lib/threading.py", line 737, in _boots

[issue12456] Hangs in concurrent.futures

2011-07-03 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue12456> ___ ___ Python-bugs-list mailing list Unsubscri

[issue12467] test_threading.test_6_daemon_threads(): Assertion failed: PyUnicode_Check(*filename), file ..\Python\_warnings.c, line 501

2011-07-03 Thread Antoine Pitrou
Antoine Pitrou added the comment: Nice diagnosis! -- stage: -> commit review ___ Python tracker <http://bugs.python.org/issue12467> ___ ___ Python-bugs-lis

[issue12467] test_threading.test_6_daemon_threads(): Assertion failed: PyUnicode_Check(*filename), file ..\Python\_warnings.c, line 501

2011-07-03 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- type: -> crash ___ Python tracker <http://bugs.python.org/issue12467> ___ ___ Python-bugs-list mailing list Unsubscri

[issue10141] SocketCan support

2011-07-04 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +neologix, rosslagerwall versions: -Python 3.2 ___ Python tracker <http://bugs.python.org/issue10141> ___ ___ Python-bug

[issue12488] multiprocessing.Connection does not communicate pipe closure between parent and child

2011-07-04 Thread Antoine Pitrou
Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file22569/unnamed ___ Python tracker <http://bugs.python.org/issue12488> ___ ___ Python-bugs-list mailin

[issue12488] multiprocessing.Connection does not communicate pipe closure between parent and child

2011-07-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: Well, I think it deserves a comment in the documentation that behaviour of Pipes and Queues when one of the process terminates is undefined and implementation-dependent. By the way, there's internal support in 3.3 to reliably detect killed children,

[issue12488] multiprocessing.Connection does not communicate pipe closure between parent and child

2011-07-04 Thread Antoine Pitrou
Antoine Pitrou added the comment: By the way, if you don't want children processes to continue running when the master exits, just make them daemonic processes (by adding "daemon=True" to the Process() constructor call). -- ___

[issue12500] support.transient_internet(): catch also Windows socket errors

2011-07-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: You don't need to add WSAECONNREFUSED, it's already there as ECONNREFUSED: >>> errno.ECONNREFUSED 10061 >>> errno.WSAECONNREFUSED 10061 As for (WSA)ENOTCONN, I don't want to add it before knowing what happens. I

[issue6721] Locks in python standard library should be sanitized on fork

2011-07-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Except for multiprocessing, does anyone know of any other module in > the standard library that uses fork() and threads at the same time? > After some grepping through the source I couldn't find any other > cases. It's quite common

[issue12500] support.transient_internet(): catch also Windows socket errors

2011-07-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Oh ok. Here is a patch for test_ssl.test_connect_ex() ignoring ECONNREFUSED > error. IMO you also want to test for the other errnos in transient_internet. Also, it should skip the test if the connection is r

[issue10181] Problems with Py_buffer management in memoryobject.c (and elsewhere?)

2011-07-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I'm slightly confused about the implication chain in the flags. PyBUF_STRIDES > seem to allow for discontiguous arrays, yet STRIDES -> ND -> C_CONTIGUOUS. To be honest I have never understood anything about these flags, and I doubt anyon

[issue10181] Problems with Py_buffer management in memoryobject.c (and elsewhere?)

2011-07-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Regarding the Reitveld cc field: I tend not to add anyone to that and > instead post comments to the tracker item to say that I've finished a > review in Reitveld. If people want to see details they can go look at > the review itself (or

[issue10181] Problems with Py_buffer management in memoryobject.c (and elsewhere?)

2011-07-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I don't think that's a bug, it's a missing feature in the integration > (there's a request on the metatracker to add automatic notifications > of new reviews on the bug itself). It is a bug, actually. People on the nosy list are

[issue10181] Problems with Py_buffer management in memoryobject.c (and elsewhere?)

2011-07-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: (and so, for the record, I've added my own small review :)) -- ___ Python tracker <http://bugs.python.org/issue10181> ___ ___

[issue10181] Problems with Py_buffer management in memoryobject.c (and elsewhere?)

2011-07-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Antoine is wanting to make release() nondeterministic by having the > underlying buffer only released when all views using it either have > release() called or are no longer referenced. That's not "nondeterministic" if everyone calls

[issue10181] Problems with Py_buffer management in memoryobject.c (and elsewhere?)

2011-07-05 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I thought the rationale for the release() method was to allow sequences like: > > b = bytearray() > m1 = memoryview(b) > m1.release() -> must call releasebuffer instantly. > b.resize(10) -> this might fail otherwise if the garbage c

[issue12502] 100% cpu usage when using asyncore with UNIX socket

2011-07-05 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +giampaolo.rodola ___ Python tracker <http://bugs.python.org/issue12502> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue10181] Problems with Py_buffer management in memoryobject.c (and elsewhere?)

2011-07-06 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le mercredi 06 juillet 2011 à 12:39 +, Stefan Krah a écrit : > Antoine, was this roughly your suggestion? I think so (!), but I also agree with Nick that raising BufferError when calling release() on a memoryview with exports is a reasonable alternat

[issue12167] test_packaging reference leak

2011-07-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: > To fix it, I don’t find the monkey-patching approach very good, I’d > prefer properly using the logging API to remove handlers upon cleanup. I don't think such stuff exists. -- ___ Python tra

[issue12167] test_packaging reference leak

2011-07-07 Thread Antoine Pitrou
Antoine Pitrou added the comment: > See http://hg.python.org/cpython/file/tip/Lib/packaging/tests/support.py#l81 AFAIU, the problem is that 2to3 creates a whole new logger for each different file. So it's not about cleaning the handlers, but cleaning up the loggers as well. And

[issue11512] adding test suite for cgitb

2011-07-08 Thread Antoine Pitrou
Antoine Pitrou added the comment: Not sure this is related, but test_robotparser has started failing on one of the buildbots after this change: http://www.python.org/dev/buildbot/all/builders/AMD64%20Gentoo%20Wide%203.x/builds/2070 -- nosy: +pitrou

[issue12440] test_ssl.test_options() failure on Snow Leopard: can't clear options before OpenSSL 0.9.8m

2011-07-08 Thread Antoine Pitrou
Antoine Pitrou added the comment: Should be fixed now. -- assignee: janssen -> resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python

[issue12440] test_ssl.test_options() failure on Snow Leopard: can't clear options before OpenSSL 0.9.8m

2011-07-08 Thread Antoine Pitrou
Antoine Pitrou added the comment: > That said, we will probably need to supply our own libssl for Python > installers in the future as there are rumors that Apple has hinted it > may no longer supply openssl in the future. What about their own Python? Will it come without an s

[issue12440] test_ssl.test_options() failure on Snow Leopard: can't clear options before OpenSSL 0.9.8m

2011-07-08 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- resolution: -> fixed stage: -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue11512] adding test suite for cgitb

2011-07-08 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Pretty sure it has nothing to do with the new cgitb test. Apparently > testPasswordProtectedSite (test.test_robotparser.NetworkTestCase) uses > website http://mueblesmoraleda.com to run it's test and that site is > currently down. Inde

[issue12520] spurious output in test_warnings

2011-07-08 Thread Antoine Pitrou
New submission from Antoine Pitrou : $ ./python -m test test_warnings [1/1] test_warnings test.test_warnings:553: UserWarning: test Also, I don't understand how test_filename_none is supposed to check for issue #12467 (it doesn't use a subprocess). -- assignee: haypo compone

[issue11863] Enforce PEP 11 - remove support for legacy systems

2011-07-08 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue12326] Linux 3: tests should avoid using sys.platform == 'linux2'

2011-07-09 Thread Antoine Pitrou
Antoine Pitrou added the comment: > while this is sorted out, I propose to apply the following workaround > not to introduce `linux3', at least for the branches: It's too late, since existing versions won't have the patch and will show "linux3" when the kern

[issue12343] ssl documentation needs comments about non-blocking behaviour

2011-07-10 Thread Antoine Pitrou
Antoine Pitrou added the comment: I'd say this is fixed now. Tell me if there are any precisions you would like to see added. -- resolution: -> fixed stage: needs patch -> committed/rejected status: open -> closed versions: -Python 2.7

[issue12523] 'str' object has no attribute 'more' [/usr/lib/python3.2/asynchat.py|initiate_send|245]

2011-07-11 Thread Antoine Pitrou
Antoine Pitrou added the comment: Actually, the error is that in Python 3 you should use bytes objects when transmitting/receiving data over the network, not (unicode) strings. That is, replace '\r\n' with b'\r\n', etc. Of course, the error message should

[issue12149] Segfault in _PyObject_GenericGetAttrWithDict

2011-07-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thank you very much! -- stage: needs patch -> patch review versions: -Python 3.1 ___ Python tracker <http://bugs.python.org/issu

[issue3565] array documentation, method names not 3.x-compliant

2011-07-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Is there still any idea/intention of renaming .from/.tounicode to > .from/.tostring? That would have to be done at least one version with > the 'string' names absent, and would have little gain as 'unicode' is > clear. Indeed

[issue12149] Segfault in _PyObject_GenericGetAttrWithDict

2011-07-12 Thread Antoine Pitrou
Antoine Pitrou added the comment: Should be fixed now. Thanks again Davide for the patch. -- resolution: -> fixed stage: patch review -> committed/rejected status: open -> closed ___ Python tracker <http://bugs.python.or

[issue12551] Provide data for TLS channel binding

2011-07-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Interestingly (from rfc5929): This definition of 'tls-unique' means that a channel's bindings data may change over time, which in turn creates a synchronization problem should the channel's bindings data change between the

[issue12545] Incorrect handling of return codes in the posix_lseek function in posixmodule.c

2011-07-13 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +haypo ___ Python tracker <http://bugs.python.org/issue12545> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12545] Incorrect handling of return codes in the posix_lseek function in posixmodule.c

2011-07-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: > In addition I would like the posix_lseek function to accept a value > larger than 2^63 as a seek offset How would it work? The C lseek() takes a signed (64-bit) offset as argument, so we would have to call it multiple times anyway. -

[issue12545] Incorrect handling of return codes in the posix_lseek function in posixmodule.c

2011-07-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Im most familiar with solaris. Atleast on solaris lseek interprets its > signed arg as the unsigned value with the same bit pattern. Only with SEEK_SET, I assume? -- ___ Python tracker <http://bugs.p

[issue11183] Finer-grained exceptions for the ssl module

2011-07-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Note: the ERR_GET_REASON() macro helps get a more precise explanation of an error. We could add a reason attribute to raised exceptions, and also provide a mnemonic-integer mapping. -- stage: -> needs pa

[issue12555] PEP 3151 implementation

2011-07-13 Thread Antoine Pitrou
New submission from Antoine Pitrou : I now have a working PEP 3151 implementation, working on various platforms (tested on Linux, Windows, FreeBSD and OpenIndiana buildbots). The implementation has all the semantic changes and additions in PEP 3151. It still lacks the deprecation mechanism

[issue12555] PEP 3151 implementation

2011-07-13 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- hgrepos: +41 ___ Python tracker <http://bugs.python.org/issue12555> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12555] PEP 3151 implementation

2011-07-13 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- keywords: +patch Added file: http://bugs.python.org/file22647/cac46b853098.diff ___ Python tracker <http://bugs.python.org/issue12

[issue12555] PEP 3151 implementation

2011-07-13 Thread Antoine Pitrou
Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file22647/cac46b853098.diff ___ Python tracker <http://bugs.python.org/issue12555> ___ ___ Python-bug

[issue12551] Provide data for TLS channel binding

2011-07-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: Thank you, this looks mostly good. A couple of nits: +#if OPENSSL_VERSION_NUMBER >= 0x0090500fL +# define HAVE_OPENSSL_FINISHED 1 +#else +# undef HAVE_OPENSSL_FINNISHED +#endif you have a typo in the #undef, also it would be more logical to have # def

[issue12555] PEP 3151 implementation

2011-07-13 Thread Antoine Pitrou
Changes by Antoine Pitrou : Added file: http://bugs.python.org/file22648/d305942126b6.diff ___ Python tracker <http://bugs.python.org/issue12555> ___ ___ Python-bug

[issue12555] PEP 3151 implementation

2011-07-13 Thread Antoine Pitrou
Antoine Pitrou added the comment: (I'm sorry for the filenames. I'm using the "create patch" feature in the hope that a code review is possible through the Rietveld integration :-)) -- ___ Python tracker <http://bug

[issue12555] PEP 3151 implementation

2011-07-13 Thread Antoine Pitrou
Changes by Antoine Pitrou : Added file: http://bugs.python.org/file22650/9bb6b71f172d.diff ___ Python tracker <http://bugs.python.org/issue12555> ___ ___ Python-bug

[issue12555] PEP 3151 implementation

2011-07-13 Thread Antoine Pitrou
Changes by Antoine Pitrou : Removed file: http://bugs.python.org/file22648/d305942126b6.diff ___ Python tracker <http://bugs.python.org/issue12555> ___ ___ Python-bug

[issue12556] Disable size checks in mmap.mmap()

2011-07-14 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +neologix, rosslagerwall versions: +Python 3.3 -Python 2.6 ___ Python tracker <http://bugs.python.org/issue12556> ___ ___

[issue12559] gzip.open() needs an optional encoding argument

2011-07-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: If we go this way, the "errors" and "newline" argument should be added as well. -- nosy: +pitrou stage: -> patch review ___ Python tracker <http://

[issue6755] Patch: new method get_wch for ncurses bindings: accept wide characters (unicode)

2011-07-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: /home/antoine/cpython/default/Modules/_cursesmodule.c: In function ‘PyCursesWindow_Get_WCh’: /home/antoine/cpython/default/Modules/_cursesmodule.c:919:9: attention : implicit declaration of function ‘wget_wch’ /home/antoine/cpython/default/Modules

[issue6755] Patch: new method get_wch for ncurses bindings: accept wide characters (unicode)

2011-07-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Also compilation warnings on some buildbots: /var/lib/buildslave/3.x.murray-gentoo-wide/build/Modules/_cursesmodule.c: In function 'PyCursesWindow_Get_WCh': /var/lib/buildslave/3.x.murray-gentoo-wide/build/Modules/_cursesmodule.c:919: warning

[issue9408] curses: Link against libncursesw instead of libncurses

2011-07-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: For the record, I filed the following bug against Mageia's libreadline: https://bugs.mageia.org/show_bug.cgi?id=2156 -- nosy: +pitrou ___ Python tracker <http://bugs.python.org/i

[issue12551] Provide data for TLS channel binding

2011-07-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: > This patch is functionally equivalent, but advertises 'tls-unique' > support in a bit different way. > > HAS_TLS_UNIQUE is not exposed in the python 'ssl' module, instead a > list 'CHANNEL_BINDING_TYPES'

[issue12167] test_packaging reference leak

2011-07-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: > I’ve also made a patch to register the caches used by > packaging.database with the regrtest unclean environment warning; can > someone review it? I would call .copy() on the original dicts rather than remembering an explicit e

[issue11343] Make errors due to full parser stack identifiable

2011-07-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: This looks like a rather good idea, although I'm not sure it deserves a new global exception type. -- nosy: +benjamin.peterson, ncoghlan, pitrou stage: -> patch review ___ Python tracker <http://bugs

[issue11824] freeze.py broken due to ABI flags

2011-07-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Barry? Additionally, if would be nice if we got some tests for the "freeze" tool, otherwise I fear we will keep breaking it. -- nosy: +pitrou priority: normal -> high stage: -> patch review __

[issue11829] inspect.getattr_static code execution with meta-metaclasses

2011-07-15 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- nosy: +ncoghlan stage: -> patch review ___ Python tracker <http://bugs.python.org/issue11829> ___ ___ Python-bugs-list mai

[issue11813] inspect.getattr_static doesn't get module attributes

2011-07-15 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- stage: -> patch review ___ Python tracker <http://bugs.python.org/issue11813> ___ ___ Python-bugs-list mailing list Unsubscri

[issue11770] inspect.dir_static

2011-07-15 Thread Antoine Pitrou
Changes by Antoine Pitrou : -- stage: needs patch -> patch review type: behavior -> feature request ___ Python tracker <http://bugs.python.org/issue11770> ___ __

[issue11321] 9th import of module _pickle always crashes

2011-07-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Should be fixed now, thank you! -- resolution: -> fixed stage: -> committed/rejected status: open -> closed versions: -Python 3.1 ___ Python tracker <http://bugs.python.or

[issue11603] Python crashes or hangs when rebinding __repr__ as __str__

2011-07-15 Thread Antoine Pitrou
Antoine Pitrou added the comment: Should be fixed, now, thank you! -- nosy: +pitrou resolution: -> fixed stage: test needed -> committed/rejected status: open -> closed versions: -Python 2.6 ___ Python tracker <http://bugs.python.or

<    5   6   7   8   9   10   11   12   13   14   >