Changes by Antoine Pitrou :
Removed file: http://bugs.python.org/file16975/surrogateescape.patch
___
Python tracker
<http://bugs.python.org/issue8438>
___
___
Python-bug
Changes by Antoine Pitrou :
--
assignee: -> jnoller
nosy: +jnoller
priority: -> normal
versions: +Python 2.7, Python 3.1, Python 3.2 -Python 2.5
___
Python tracker
<http://bugs.python.org/
Antoine Pitrou added the comment:
Should be fixed in r80194 / r80195.
--
nosy: +pitrou
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> pending
___
Python tracker
<http://bugs.python.o
Changes by Antoine Pitrou :
--
assignee: -> pitrou
status: pending -> open
___
Python tracker
<http://bugs.python.org/issue8439>
___
___
Python-bugs-list
Changes by Antoine Pitrou :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue8439>
___
___
Python-bugs-list mailing list
Unsubscri
Antoine Pitrou added the comment:
On recent trunk and py3k you can get the real version number:
http://docs.python.org/dev/library/ssl.html#ssl.OPENSSL_VERSION
So perhaps you can first build the _ssl module, then import it to get that
information.
Of course it would be much better to build
Changes by Antoine Pitrou :
--
assignee: -> ronaldoussoren
components: +Macintosh
nosy: +ronaldoussoren
___
Python tracker
<http://bugs.python.org/iss
Antoine Pitrou added the comment:
Some notes about the patch:
- NEWS blurbs generally appear antichronologically, that is newest first :-)
- you don't have to mention that "The 3.2 changes mentioned above are included
in 2.7"
- the part of the PyArg_ParseTupleAndKeywords string
Changes by Antoine Pitrou :
--
nosy: +orsenthil
priority: -> normal
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/iss
Antoine Pitrou added the comment:
> With regards to SSL_peek() blocking, you'd need to explain yourself
> better on that one. The patch has been tested with the test cases
> from Python SVN enough to be happy they run ok.
IIRC it worked with OpenSSL 1.0.0 but failed with 0.9.8k
Changes by Antoine Pitrou :
--
nosy: +benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue8459>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
Patch committed to trunk in r80215. I'm going to watch the buildbots, I suspect
OS X might dislike surrogates in the filename.
--
___
Python tracker
<http://bugs.python.org/i
Changes by Antoine Pitrou :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Antoine Pitrou added the comment:
By the way, getting rid of poll_interval for a file descriptor is easy under
Unix, but wouldn't work under Windows (where select() only takes sockets, not
arbitrary file descriptors).
--
___
Python tracker
Antoine Pitrou added the comment:
A 16KB stack buffer is tiny compared to a 8MB stack. I'm not sure removing that
buffer would really fix the problems.
Perhaps other threads get a smaller stack?
--
___
Python tracker
<http://bugs.py
Antoine Pitrou added the comment:
What's the value of MAXPATHLEN and PATH_MAX on those systems?
--
___
Python tracker
<http://bugs.python.org/issue7332>
___
___
Antoine Pitrou added the comment:
> The problem is highlighted with recursive imports:
> a module which imports another module, which imports another module,
> etc. PyMarshal_ReadLastObjectFromFile is not the only function to use
> stack-allocated buffers, there are also load_s
Antoine Pitrou added the comment:
Bill, I think we should move forward with this. Do you agree that removing the
timeout dance is the right solution?
--
nosy: +pitrou
priority: -> high
versions: +Python 2.7
___
Python tracker
&l
Antoine Pitrou added the comment:
I had never seen this issue but committed almost exactly the same feature in
r80151. The parameters is named "ciphers" rather than "cipher_list" and allows
you to override the allowed ciphers when creating an SSL object. It will be
ava
Antoine Pitrou added the comment:
Too late for 2.7 now, but looks like a good idea.
--
nosy: +pitrou
priority: -> normal
stage: -> patch review
versions: -Python 2.7
___
Python tracker
<http://bugs.python.org/
Antoine Pitrou added the comment:
The new "ciphers" argument in trunk and py3k should do the trick, shouldn't it?
Do note that starting with OpenSSL 1.0.0, SSLv2 is disabled by default when
using the "SSLv23" client method (you can re-enable it by specifying &
Antoine Pitrou added the comment:
Probably a duplicate of issue5238.
--
nosy: +pitrou
resolution: -> duplicate
status: open -> closed
superseder: -> ssl makefile never closes socket
___
Python tracker
<http://bugs.python.o
Changes by Antoine Pitrou :
--
nosy: +giampaolo.rodola
versions: +Python 3.2 -Python 3.0
___
Python tracker
<http://bugs.python.org/issue5238>
___
___
Python-bug
Antoine Pitrou added the comment:
Duplicate of issue5639.
--
nosy: +pitrou
resolution: -> duplicate
status: open -> closed
superseder: -> Support TLS SNI extension in ssl module
___
Python tracker
<http://bugs.python.o
Changes by Antoine Pitrou :
Removed file: http://bugs.python.org/file9298/unnamed
___
Python tracker
<http://bugs.python.org/issue1926>
___
___
Python-bugs-list mailin
Changes by Antoine Pitrou :
Removed file: http://bugs.python.org/file9309/unnamed
___
Python tracker
<http://bugs.python.org/issue1926>
___
___
Python-bugs-list mailin
Changes by Antoine Pitrou :
--
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue4470>
___
___
Python-bugs-list mailin
Changes by Antoine Pitrou :
--
resolution: accepted ->
versions: +Python 3.2 -Python 2.6, Python 2.7, Python 3.0, Python 3.1
___
Python tracker
<http://bugs.python.org/iss
Antoine Pitrou added the comment:
Too vague and probably outdated, closing.
--
nosy: +pitrou
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/is
Antoine Pitrou added the comment:
There's probably something wrong in the way test_httpservers sets up its own
environment (can it impact the import mechanism?). The operator module exists
and imports correctly in other conditions, e.g. test_operator passes on that
buildbot.
--
Antoine Pitrou added the comment:
Looks like you forgot your patch.
--
___
Python tracker
<http://bugs.python.org/issue8444>
___
___
Python-bugs-list mailin
Antoine Pitrou added the comment:
> I don't know if "nallocated += repsize - 4;" can overflow or not.
> If yes, how can I detect the overflow?
Sure, if they are both Py_ssize_t, just use:
if (nallocated > PY_SSIZE_T_MAX - repsize + 4) {
/* handle overflow ... */
}
Antoine Pitrou added the comment:
There's a bunch of debug stuff in that patch ("if 1", commented out lines...).
Also, the patch should not change behaviour on non-OS X platforms, which is not
obvious right now.
--
nosy: +pitrou
___
Changes by Antoine Pitrou :
--
status: pending -> closed
___
Python tracker
<http://bugs.python.org/issue8439>
___
___
Python-bugs-list mailing list
Unsubscri
Antoine Pitrou added the comment:
Here is an adapted patch for py3k. It also adds a couple of test cases.
--
nosy: +pitrou
Added file: http://bugs.python.org/file17016/sslopts.patch
___
Python tracker
<http://bugs.python.org/issue4
Antoine Pitrou added the comment:
Some comments:
- your ssl_convert_filename() function has a strange signature
- using PyByteArray_AsString() is wrong, we release the GIL later and the
buffer could be reallocated, leading to a crash; the right approach is to use
PyObject_GetBuffer() and
Antoine Pitrou added the comment:
Ok, closing then.
--
resolution: -> works for me
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Changes by Antoine Pitrou :
--
nosy: +giampaolo.rodola, janssen, pitrou
priority: -> normal
type: crash -> behavior
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/
Antoine Pitrou added the comment:
Changing OpenSSL initialization to the following seems to fix the issue (with
OpenSSL 0.9.8k and 1.0.0):
/* Init OpenSSL */
SSL_load_error_strings();
SSL_library_init();
#ifdef WITH_THREAD
/* note that this will start threading
Antoine Pitrou added the comment:
Or perhaps the bytearray can be converted to a bytes object. This is not
optimal performance-wise but is unlikely to make a difference in real-world
code (if you are passing a filename to an external API, chances are some IO
will occur which will dwarf the
Antoine Pitrou added the comment:
Due to the nature of an Event, you should in most situations wait() on it,
rather than test its value. Also, changing the boolean value of an Event would
break existing code. I therefore think this should be rejected.
--
nosy: +pitrou
Antoine Pitrou added the comment:
> Yes, I agree when Event objects are used to sync threads. But in my
> case, I'm using them like signals to terminate some server's thread
> through a proper way.
In this case, you don't have to use an Event. A boolean attribute o
Antoine Pitrou added the comment:
> Using a boolean would look almostly the same so why to reinvent the
> wheel ? :)
Hmm, /you/ are reinventing the wheel by suggesting to use an Event
instead of a simple boolean. Just loop like this:
while not self.stop_me:
# etc.
and set the s
Antoine Pitrou added the comment:
Shouldn't "My hovercraft is full of eels" be considered an original creation of
the Monty Python, and as such copyrighted?
--
nosy: +pitrou
___
Python tracker
<http://bugs.py
Antoine Pitrou added the comment:
Here is a patch. I'm not really happy about the test because it relies on an
external test site, and the certificate apparently expires in 2011.
--
keywords: +patch
Added file: http://bugs.python.org/file17025/algos.
Antoine Pitrou added the comment:
After several attempts, I've failed generating a self-signed certificate that
would reproduce the issue without relying on an external server. Perhaps
there's something else than simply the hashing algorithm. In any case I think
I'm simply
Changes by Antoine Pitrou :
--
nosy: +mark.dickinson
___
Python tracker
<http://bugs.python.org/issue5516>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
Well, this looks like a filesystem problem more than a Python problem.
The error (errno 2) comes from the mknod() system call itself.
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue8
Changes by Antoine Pitrou :
--
nosy: +exarkun
___
Python tracker
<http://bugs.python.org/issue8487>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
> "OpenSSL_add_ssl_algorithms() and SSLeay_add_ssl_algorithms() are
> synonyms for SSL_library_init()"
The patch calls OpenSSL_add_all_algorithms(), though.
(yes, it's a different one :-))
http://www.openssl.org/docs/crypto/OpenSSL_ad
Antoine Pitrou added the comment:
Here is a patch, with tests. I also had to rework the asyncore-based test
server in test_ssl, and fixed an omission in _ssl.c's do_handshake method.
(works with OpenSSL 0.9.8k and 1.0.0)
--
keywords: +patch
stage: -> patch review
Added fi
Antoine Pitrou added the comment:
Fixed in r80314 (trunk), r80316 (2.6), r80317 (py3k), r80318 (3.1). Thank you!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Antoine Pitrou added the comment:
Thank you Kees, this sounds quite likely. I will still commit the patch to
remove the stack buffer, and then close this issue.
--
___
Python tracker
<http://bugs.python.org/issue7
Antoine Pitrou added the comment:
Patch committed in trunk (r80325) and py3k (r80326). I won't backport it to
2.6/3.1 since it's not likely to fix anything in practice -- it's just a nice
simplification. Thanks everyone for comments and patches.
--
resolution: ->
Changes by Antoine Pitrou :
--
nosy: +exarkun
___
Python tracker
<http://bugs.python.org/issue8498>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
Some remarks:
- I agree with RDM's comment regarding inheritance
- you don't use use_poll in loop_waiting_for_flag()
- calling time.sleep() in loop_waiting_for_flag() looks wrong to me
- test_handle_error should check that the exception state is th
Antoine Pitrou added the comment:
I'll leave this to our numpy experts. I don't even know how to unit test this
without installing numpy.
--
assignee: -> teoliphant
priority: -> normal
stage: -> needs patch
___
Py
Changes by Antoine Pitrou :
--
nosy: +ezio.melotti
priority: low -> normal
stage: unit test needed -> patch review
versions: -Python 2.7
___
Python tracker
<http://bugs.python.org/
Antoine Pitrou added the comment:
Looks goot to me.
--
nosy: +pitrou
priority: -> normal
stage: -> patch review
versions: +Python 3.1
___
Python tracker
<http://bugs.python.org/
Antoine Pitrou added the comment:
Good, sorry.
--
___
Python tracker
<http://bugs.python.org/issue8496>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
Committed in r80369. Thanks!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Antoine Pitrou added the comment:
Surely you forgot to capitalize Python, not to mention the lack of punctuation.
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue8
Changes by Antoine Pitrou :
--
nosy: +orsenthil
priority: -> normal
versions: +Python 3.2 -Python 2.6
___
Python tracker
<http://bugs.python.org/iss
Antoine Pitrou added the comment:
> Probably test case will fail is sha256 module is not loaded - openssl
> versions before 0.9.8
Yes, this has been fixed in r80375.
--
___
Python tracker
<http://bugs.python.org/
Changes by Antoine Pitrou :
--
priority: -> high
stage: -> patch review
versions: +Python 3.1, Python 3.2 -Python 3.0
___
Python tracker
<http://bugs.python.org/
Antoine Pitrou added the comment:
Not sure why this was assigned to me.
--
assignee: pitrou ->
___
Python tracker
<http://bugs.python.org/issue8465>
___
_
Changes by Antoine Pitrou :
--
nosy: -pitrou
___
Python tracker
<http://bugs.python.org/issue8465>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
The request to allow 0 looks reasonable to me. Now if someone wants to propose
a patch (+ tests if there's any way of testing for this).
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/i
Changes by Antoine Pitrou :
--
priority: -> low
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue8498>
___
___
Py
Antoine Pitrou added the comment:
Patch committed to r80392 (trunk) and r80394 (py3k). Am pondering a partial
backport of the SSL shutdown fixes to 2.6 and 3.1 (test_ftplib doesn't need any
backport since it doesn't support TLS in these branches).
--
assignee: -> pitr
Antoine Pitrou added the comment:
> key_file and cert_file are mandatory
No, they are not. Not for a client connection, at least.
Also, please add at least a simple test.
--
___
Python tracker
<http://bugs.python.org/iss
Changes by Antoine Pitrou :
--
priority: -> normal
versions: +Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue8507>
___
_
Antoine Pitrou added the comment:
Ok, I've backported the shutdown fixes to 2.6 (r80419) and 3.1 (r80420). Thanks
again everyone.
--
status: pending -> closed
versions: +Python 2.6, Python 3.1
___
Python tracker
<http://bugs.python.or
Antoine Pitrou added the comment:
New patch fixing test_poplib failures.
--
Added file: http://bugs.python.org/file17058/ssltimeout2.patch
___
Python tracker
<http://bugs.python.org/issue5
Antoine Pitrou added the comment:
Committed with test in r80423 (trunk) and r80425 (2.6).
Also ported the test to py3k/3.1. Thanks!
--
nosy: +pitrou
resolution: -> fixed
stage: unit test needed -> committed/rejected
status: open -&g
Antoine Pitrou added the comment:
The makefile issue is fixed in r80428 (trunk) and r80431 (2.6). Also ported the
additional test to py3k and 3.1.
The other issue pointed out by Marcin Bachry doesn't seem fixable without
breaking backwards compatibility, for applications which close(
Antoine Pitrou added the comment:
I think it would be overkill to add special markup for positional-only
arguments. I think we should just close the issue as invalid.
--
___
Python tracker
<http://bugs.python.org/issue8
Antoine Pitrou added the comment:
The tests should probably check all three types of I/O (raw, buffered, text).
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/iss
New submission from Antoine Pitrou :
In 3.x, SSL sockets are created by dup()ing the original socket and then
closing it. No attempt is made to conserve the socket's characteristics, such
as the timeout and probably other flags.
I understand that it may be too late to change the d
Antoine Pitrou added the comment:
It is actually a little funnier. dup() preserves the
blocking/non-blocking nature of the underlying OS socket, but not the
"timeout" of the Python socket. As such, a "blocking-with-timeout"
Python socket gets replaced with a truely
Antoine Pitrou added the comment:
Another consequence is that the following check in __init__:
timeout = self.gettimeout()
if timeout == 0.0:
# non-blocking
raise ValueError("do_handshake_on_connect s
Changes by Antoine Pitrou :
--
priority: normal -> high
type: -> behavior
___
Python tracker
<http://bugs.python.org/issue8524>
___
___
Python-bugs-list
Antoine Pitrou added the comment:
Fixed in trunk (r80452) and 2.6 (r80453). Also ported relevant parts to 3.x
(one half of the test had to be disabled because or #8524).
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -&g
Antoine Pitrou added the comment:
I committed a fix+tests for the timeout value in r80456 (py3k) and r80457
(3.1). Apparently the socket objects' own dup() method doesn't try to retain
anything else than the timeout.
I'm leaving this issue as "pending" in case critic
Changes by Antoine Pitrou :
--
components: +Interpreter Core
nosy: +flox
priority: -> normal
stage: -> needs patch
type: -> behavior
versions: +Python 2.6, Python 2.7, Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.o
Antoine Pitrou added the comment:
I can't manage to trigger any crash on a Linux machine, so I think we'll live
without a test.
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.
Antoine Pitrou added the comment:
Of course your patch might slow down the loop, so perhaps you want to run some
benchmarks.
--
___
Python tracker
<http://bugs.python.org/issue8
Changes by Antoine Pitrou :
--
versions: -Python 2.6, Python 3.1
___
Python tracker
<http://bugs.python.org/issue8530>
___
___
Python-bugs-list mailing list
Unsub
Antoine Pitrou added the comment:
Well, in 2.x you didn't even have the choice. The dict of an extension module
was always copied, becoming essentially immortal. In 3.x you can use an
m_size>=0 so as to disable this behaviour.
--
nosy: +pitrou
versions: +Py
Antoine Pitrou added the comment:
It could read into an invalid page and segfault. It depends on specifics of the
memory allocator.
--
___
Python tracker
<http://bugs.python.org/issue8
Antoine Pitrou added the comment:
Fixed with a test in r80484 (trunk), r80486 (2.6), r80487 (py3k), r80491 (3.1).
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Antoine Pitrou added the comment:
What happens if you remove the call to settimeout()?
Also, it would be nice if you could try with the latest py3k checkout. There's
a couple of fixes for do_handshake there (including timeout issues).
--
nosy: +pitrou
priority: -> normal
Antoine Pitrou added the comment:
I don't think asking Python extensions to be safe in the face of brutal DLL
unloading is wise. I don't think any of our C extensions tries to respect such
an use case. We could still try to support the use case of some application
registeri
Changes by Antoine Pitrou :
--
resolution: -> duplicate
status: open -> closed
superseder: -> Convoy effect with I/O bound threads and New GIL
___
Python tracker
<http://bugs.python.o
Antoine Pitrou added the comment:
Dave,
> In the current implementation, threads perform a timed-wait on a
> condition variable. If time expires and no thread switches have
> occurred, the currently running thread is forced to drop the GIL.
A problem, as far as I can see, is t
Antoine Pitrou added the comment:
> That's what I thought at first too. But the user's sockets were set to
> blocking.
If you set a timeout on a socket, it is really non-blocking internally (from
the OS' point of view). So perhaps this is what you are witnessing.
By
Antoine Pitrou added the comment:
What is the mnemonic corresponding to errno 35 under OS X?
(under Linux I get EDEADLOCK, which probably isn't the right one)
--
___
Python tracker
<http://bugs.python.org/i
Antoine Pitrou added the comment:
Ok, so I think we can close the issue then. Thank you!
--
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Antoine Pitrou added the comment:
Actually, DNS resolution should be disabled by default, as in most HTTP servers
probably.
--
nosy: +pitrou
stage: -> unit test needed
___
Python tracker
<http://bugs.python.org/iss
Antoine Pitrou added the comment:
> And for this specific request, it fdqn is looked up only for "logging"
> to sys.stderr. Either removing the fqdn call or just caching per
> connection it as the patch does is both fine. I doubt if someone is
> relying this logging anyw
4901 - 5000 of 16792 matches
Mail list logo
