[issue3668] "s*" argument parser marker leaks memory

2008-08-25 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3668> ___ ___ Python

[issue3668] "s*" argument parser marker leaks memory

2008-08-25 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- assignee: -> pitrou ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3668> ___ ___

[issue3668] "s*" argument parser marker leaks memory

2008-08-25 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is a patch. Please review. -- keywords: +needs review, patch type: -> resource usage Added file: http://bugs.python.org/file11243/argleak.patch ___ Python tracker <[EMAIL PROTE

[issue3668] "s*" argument parser marker leaks memory

2008-08-25 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Ok, here is a new patch addressing Amaury's comments. Added file: http://bugs.python.org/file11244/argleak2.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue3668] "s*" argument parser marker leaks memory

2008-08-25 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: By the way, this bug affects 2.6 as well, although not in binascii since it has not been converted to use "s*": >>> codecs.latin_1_decode(b"", 0) Traceback (most recent call last): File "", lin

[issue3668] "s*" argument parser marker leaks memory

2008-08-25 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is a patch for 2.6. Added file: http://bugs.python.org/file11245/argleak-2.6.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3668] "s*" argument parser marker leaks memory

2008-08-25 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Actually, here is a better patch for py3k. Added file: http://bugs.python.org/file11246/argleak3.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3668] "s*" argument parser marker leaks memory

2008-08-25 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: And a similarly better patch for 2.6. -- versions: +Python 2.6 Added file: http://bugs.python.org/file11248/argleak2-2.6.patch ___ Python tracker <[EMAIL PROTECTED]> <http://

[issue2534] Restore isinstance and issubclass speed in 2.6

2008-08-25 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: By the way, py3k suffers from this problem too, so a similar patch should be applied if possible. -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2534] Restore isinstance and issubclass speed in 2.6

2008-08-25 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- versions: +Python 3.0 ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2534> ___ __

[issue3675] Python 2.6 can't read sets pickled with Python 3.0

2008-08-25 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- nosy: +alexandre.vassalotti priority: -> critical type: -> behavior ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue2534] Restore isinstance and issubclass speed in 2.6

2008-08-25 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: I'm currently doing the port to py3k. It makes me find interesting flaws in the current isinstance/issubclass implementation :-)) ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue2534] Restore isinstance and issubclass speed in 2.6

2008-08-25 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Ok, here is the patch for py3k. As I said it fixes some interesting bugs (when the second argument was a tuple, isinstance() and issubclass() were trying to get __instancecheck__ / __subclasscheck__ on the tuple rather than on each

[issue2534] Restore isinstance and issubclass speed in 2.6

2008-08-25 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: New patch with a couple of tiny fixes. Added file: http://bugs.python.org/file11257/isinstance3k-2.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2415] bytes() should respect __bytes__

2008-08-26 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > Should __bytes__ support be backported to 2.6? Isn't it already there in __str__? Or do you mean just add support for the alternate method name? ___ Python tracker <[EMAIL

[issue3685] Crash while compiling Python 3000 in OpenBSD 4.4

2008-08-26 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- components: +Interpreter Core priority: -> release blocker type: -> crash ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue2534] Restore isinstance and issubclass speed in 2.6

2008-08-26 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is the same patch, but backported to 2.6. Added file: http://bugs.python.org/file11261/isinstance26-2.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3548] subprocess.pipe function

2008-08-26 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- priority: -> normal versions: +Python 2.7, Python 3.1 -Python 2.6, Python 3.0 ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3651] eval() leaks 1 reference every time

2008-08-26 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Amaury, assuming you have tested it :-), the patch is ok to me. You can commit. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3149] multiprocessing build fails on Solaris 10

2008-08-26 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: This is a duplicate of #3110. -- nosy: +pitrou resolution: -> duplicate status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3110] Multiprocessing package build problem on Solaris 10

2008-08-26 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: FWIW, this is what I find on a Solaris box. ./sys/param.h:#define _SEM_VALUE_MAX INT_MAX ./sys/sysconfig.h:#define _CONFIG_SEM_VALUE_MAX 21 /* max. value a semaphore may have */ ./sys/unistd.h:#

[issue3663] Extra DECREF on syntax errors

2008-08-26 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Committed in r66041. Thanks everyone. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue2534] Restore isinstance and issubclass speed in 2.6

2008-08-26 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Committed in r66042 and r66043. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3697] "Fatal Python error: Cannot recover from stack overflow" on Windows buildbots

2008-08-27 Thread Antoine Pitrou
New submission from Antoine Pitrou <[EMAIL PROTECTED]>: This error appears more or less regularly on the Windows py3k buildbots. Today it has appeared following my changes to isinstance() / issubclass(), but it had already appeared before, e.g. http://www.python.org/dev/buildbot/3.0.stab

[issue3697] "Fatal Python error: Cannot recover from stack overflow" on Windows buildbots

2008-08-27 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: It is because of the USE_STACKCHECK macro, which is only defined in debug mode with Microsoft compilers. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3697] "Fatal Python error: Cannot recover from stack overflow" on Windows buildbots

2008-08-27 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Patch uploaded to http://codereview.appspot.com/3276, verified to fix the problem on a Windows XP virtual machine. Please review. -- keywords: +needs review, patch priority: critical -> releas

[issue3699] test_bigaddrspace broken

2008-08-27 Thread Antoine Pitrou
New submission from Antoine Pitrou <[EMAIL PROTECTED]>: ./python3 Lib/test/regrtest.py -v -M 2.1Gb test_bigaddrspace test_bigaddrspace test_concat (test.test_bigaddrspace.StrTest) ... ERROR test_optimized_concat (test.test_bigaddrspace.StrTest) ...

[issue3700] test_bigmem broken

2008-08-27 Thread Antoine Pitrou
New submission from Antoine Pitrou <[EMAIL PROTECTED]>: ./python3 Lib/test/regrtest.py -v -M 2.1Gb test_bigmem test_bigmem [snip skipped tests] == ERROR: test_center_unicode (test.test_bigmem.S

[issue3700] test_bigmem broken

2008-08-27 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: It would be nice if at least one of the buildbots could run the bigmem tests. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3701] test_ntpath.test_relpath fails when launched from a different Windows drive

2008-08-27 Thread Antoine Pitrou
New submission from Antoine Pitrou <[EMAIL PROTECTED]>: C:\>z:PCbuild\python_d.exe z:Lib\test\regrtest.py -uall -v test_ntpath test_ntpath test_abspath (test.test_ntpath.TestNtpath) ... ok test_commonprefix (test.test_ntpath.TestNtpath) ... ok test_expandvars (test.test_ntpath.TestNtpat

[issue3702] test_urllib2.test_trivial fails when run from another Windows drive

2008-08-27 Thread Antoine Pitrou
New submission from Antoine Pitrou <[EMAIL PROTECTED]>: == ERROR: test_trivial (test.test_urllib2.TrivialTests) -- Traceback (most recent call last): F

[issue3702] test_urllib2.test_trivial fails when run from another Windows drive

2008-08-27 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: What I forgot to say is that the test was launched from the C: drive: C:\>z:PCbuild\python_d.exe z:Lib\test\regrtest.py -uall -v test_urllib2 ___ Python tracker <[EMAIL PROTECTED]> <http

[issue3705] py3k aborts if "-c" or "-m" is given a non-ascii value

2008-08-27 Thread Antoine Pitrou
New submission from Antoine Pitrou <[EMAIL PROTECTED]>: The explanation is quite simple: in Py_Main, the arguments are converted from wide to byte strings, but the required length of the byte string is assumed equal to that of the wide string. Which gives: $ ./python -c "print(

[issue3696] Error parsing arguments on OpenBSD <= 4.4

2008-08-27 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The patch looks fine and harmless to me (but I'm a configure newbie too). +1 for committing it and seeing if the OpenBSD buildbot feels better. In the process of testing this patch, I've found another bug: #3705.

[issue3696] Error parsing arguments on OpenBSD <= 4.4

2008-08-27 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Mmh, in Modules/python.c and Python/frozenmain.c, the return value of the second call to mbstowcs() should be checked as well (since the first one is sometimes replaced by a call to strlen(), which never

[issue3705] py3k aborts if "-c" or "-m" is given a non-ascii value

2008-08-27 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is a patch which works under Linux. Under Windows it doesn't choke when converting arguments anymore, but it fails later in the process (in the parser for '-c', in the importing logic for '-m'). Here is an

[issue3611] invalid exception context

2008-08-27 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > Can this patch go in? I'm ok for it. ___ Python tracker <[EMAIL PROTECTED]> <http://bu

[issue3660] reference leaks in 3.0

2008-08-27 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: As of r66047, I get the following results (without "-uall", though): test_unittest leaked [124, 124] references, sum=248 test_binascii leaked [1, 1] references, sum=2 test_distutils leaked [141, 142] references, sum=283 tes

[issue3710] Reference leak in thread._local

2008-08-27 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Hmm, rather than the while loop in your proposal, the proper idiom would be: PyObject *olddict = self->dict; Py_INCREF(ldict); self->dict = ldict; Py_XDE

[issue3705] py3k aborts if "-c" or "-m" is given a non-ascii value

2008-08-27 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- keywords: +needs review nosy: +loewis ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3710] Reference leak in thread._local

2008-08-27 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > But then if there is a context switch during the last Py_XDECREF, then > it could be the case that self->dict is not set properly on return from > _ldict(). Well, C code is effectively locked in a single thread until t

[issue3014] file_dealloc() assumes errno is set when EOF is returned

2008-08-28 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The title of your bug report might be misleading. Is the problem that errno is misinterpreted in the error message, or that there is an error message at all? -- nosy: +pitrou priority: -> normal versions: +Python 2.7 -P

[issue3708] os.urandom(1.1): infinite loop

2008-08-28 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The explicit int() conversion looked saner to me, rather than passing a float argument to read(). By the way, is there a reason this code still uses os.open rather than the builtin io.open? -- nosy: +

[issue3660] reference leaks in 3.0

2008-08-28 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > str(memoryview(b'character buffers are decoded to unicode'), 'utf-8') > I tried another patch, but I'm not sure: I get lost between all these > buffers... a Py_DECREF(self->view.obj) in memory_re

[issue3696] Error parsing arguments on OpenBSD <= 4.4

2008-08-28 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > Yes; but here, the symbol (HAVE_BROKEN_MBSTOWC) has a negative meaning. > I tried to put the optimistic (=not broken) case first. > However, if this makes the code more difficult to read, I'll change i

[issue3712] memoryview leaks references

2008-08-28 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is a patch. I feel a bit unsafe with the intended semantics of getting a buffer on a memoryview object, but it fixes the leak. -- components: +Interpreter Core keywords: +needs review, patch nosy: +pitrou, teoliphan

[issue3712] memoryview leaks references

2008-08-28 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: (I forgot to say, the patch is for the first problem only) ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3712] memoryview leaks references

2008-08-28 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is an aggregate patch addressing both problems. Please review. Added file: http://bugs.python.org/file11290/memleak2.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3616] shutil.rmtree() fails on invalid filename

2008-08-28 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Selon STINNER Victor <[EMAIL PROTECTED]>: > > Python 2.5 has the same problem (at least, on Linux). rmtree( directory name>) fails if the directory contains invalid unicode > string. Backtrace: Well, I'm not su

[issue3014] file_dealloc() assumes errno is set when EOF is returned

2008-08-28 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Selon johansen <[EMAIL PROTECTED]>: > > The problem is present in Python 2.4.4, the version that we're using > here. I'm not familiar with the versions keyword that's used here, but > that's the ve

[issue3014] file_dealloc() assumes errno is set when EOF is returned

2008-08-28 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- nosy: -pitrou ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3014> ___ __

[issue3708] os.urandom(1.1): infinite loop

2008-08-28 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Le jeudi 28 août 2008 à 19:30 +, Gregory P. Smith a écrit : > if i did > > n = int(n) > > that would change the API to allow bytes/unicode to be passed in which > is not something i want. Ok, I hadn&#

[issue3668] "s*" argument parser marker leaks memory

2008-08-29 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Amaury, are these patches ok to check in? ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3731] import warning in multiprocessing

2008-08-29 Thread Antoine Pitrou
New submission from Antoine Pitrou <[EMAIL PROTECTED]>: I get the following when running "regrtest.py -uall" under trunk: /home/antoine/cpython/__svn__/Lib/multiprocessing/__init__.py:82: ImportWarning: Not importing directory '/home/antoine/cpython/__svn__/Modules/_mult

[issue3668] "s*" argument parser marker leaks memory

2008-08-29 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Committed in r66057 and r66058. -- resolution: accepted -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3660] reference leaks in 3.0

2008-08-29 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Amaury, I believe the first part of encode-leak.patch is wrong, you should Py_DECREF the bytearray after it has been converted to bytes, not before. Here is an alternate patch. Added file: http://bugs.python.org/file11309/encode-leak2

[issue3660] reference leaks in 3.0

2008-08-29 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: With the two patches applied, we are now at: test_unittest leaked [124, 124] references, sum=248 test_distutils leaked [141, 142] references, sum=283 test_docxmlrpc leaked [85, -85] references, sum=0 test_logging leaked [366

[issue3660] reference leaks in 3.0

2008-08-29 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Ok, after the two patches plus the patch in #3667, I get the following: test_asyncore leaked [84, -84] references, sum=0 test_distutils leaked [141, 142] references, sum=283 test_docxmlrpc leaked [-85, 0] references, sum=-85 test_l

[issue2548] Undetected error in exception handling

2008-08-29 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The crashers which were deleted in rev58032 should at least have been turned into unittests... well. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3675] Python 2.6 can't read sets pickled with Python 3.0

2008-08-29 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: > Was it really intended that 3.0 pickles unpickle on 2.6? He used protocol 2, so he explicitly asked for something inpickleable with 2.6. If it's not the intended behaviour, then protocols < 3 should be deprecated. ---

[issue2548] Undetected error in exception handling

2008-08-29 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Ok, here is a patch which seems to cover all bases. It fixes the present bug, adds tests for the aforementioned ex-crashers, backports the somewhat smarter recursion checking from py3k, and improves the latter by fixing a nasty recursi

[issue2548] Undetected error in exception handling

2008-08-29 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue2548> ___ _

[issue2548] Undetected error in exception handling

2008-08-29 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: Removed file: http://bugs.python.org/file11313/excrecurse.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2548] Undetected error in exception handling

2008-08-29 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Ouch, there were a couple of useless lines in ceval.h. New patch. Added file: http://bugs.python.org/file11314/excrecurse.patch ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2548] Undetected error in exception handling

2008-08-29 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: After thinking about it a bit, I think the whole recursion checking thing has gone a bit mad. It probably deserves proper discussion on the mailing-list. In the meantime, I'm downgrading this bug to critical. -- priori

[issue3707] help('finally') behaves bizarrely

2008-08-30 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Patch is ok on trunk. It should also be merged to py3k. -- nosy: +pitrou resolution: -> accepted versions: +Python 2.6 ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.py

[issue3160] Building a Win32 binary installer crashes

2008-09-01 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Hi Viktor I believe no installer was released for beta3 because Martin von Löwis was on holidays and couldn't handle it. Now we are in release candidate phase, the patch needs another revi

[issue3160] Building a Win32 binary installer crashes

2008-09-01 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- nosy: +ocean-city ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3160> ___ __

[issue3697] "Fatal Python error: Cannot recover from stack overflow" on Windows buildbots

2008-09-01 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- nosy: +ocean-city ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3697> ___ __

[issue3750] test_bsddb3 skipped -- cannot import name test_support

2008-09-01 Thread Antoine Pitrou
New submission from Antoine Pitrou <[EMAIL PROTECTED]>: This is what I get with the current py3k branch: test_bsddb3 skipped -- cannot import name test_support In py3k test/test_support.py has been renamed to test/support.py. The fix should be simple enough :) -- assignee

[issue3752] test_bsddb broken

2008-09-01 Thread Antoine Pitrou
New submission from Antoine Pitrou <[EMAIL PROTECTED]>: Since the latest bsddb merge, test_bsddb is basically broken, all tests fail with the same error (see also the buildbots): == ERROR: test_

[issue3712] memoryview leaks references

2008-09-01 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Fixed in r66111. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3751] str.rpartition fails silently with unicode argument

2008-09-01 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Adding a few tests wouldn't hurt :) -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.

[issue3753] bytearray incompatible with y#

2008-09-01 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Yes, you must use y* instead: see http://docs.python.org/dev/3.0/c-api/arg.html y# would not be safe to use with bytearray since another thread could mutate the bytearray in-between, possibly reallocating the internal buffer (to shr

[issue3731] import warning in multiprocessing

2008-09-01 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Indeed. _multiprocessing.so compiles fine but afterwards I get: *** WARNING: importing extension "_multiprocessing" failed with : 'module' object has no attribute 'SemLock' And if I try manually: &

[issue3731] import warning in multiprocessing

2008-09-01 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Mmmh, after doing "svn up" again and recompiling, the extension imports fine and the ImportWarning disappears. -- resolution: -> out of date status: open -> closed ___

[issue3589] Misleading names for multiprocessing "convenience" functions

2008-09-01 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Le lundi 01 septembre 2008 à 21:22 +, Nick Coghlan a écrit : > As Fredrik noted in the python-dev thread, the threading versions of > these are already explicitly documented as being factory functions > rather than cl

[issue3757] threading.local doesn't support cyclic garbage collecting

2008-09-02 Thread Antoine Pitrou
New submission from Antoine Pitrou <[EMAIL PROTECTED]>: tp_traverse and tp_clear on threading.local are defined, but the Py_TPFLAGS_HAVE_GC flag is not set. As a result, cycles are not collected: >>> import threading, weakref >>> o = threading.local() >>> cla

[issue1868] threading.local doesn't free attrs when assigning thread exits

2008-09-02 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The patch is basically fine with me. While reviewing it I've found out that threading.local doesn't have cyclic garbage collecting enabled. I've opened a new issue for it in #3757. ---

[issue2690] Precompute range length

2008-09-02 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: It looks like your range_subscript() forgets to compute the length field... ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue2690] Precompute range length

2008-09-02 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: By the way, why is this release blocker? do we have performance numbers? ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3660] reference leaks in 3.0

2008-09-02 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3660> ___ _

[issue1638033] Add httponly to Cookie module

2008-09-02 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Well, I'm sorry but this a feature request and must be delayed for 2.7/3.1, since 2.6/3.0 are now in the release candidate phase. :-( (as for the patch, it would be nice if it added an unit test for the new feature) -- no

[issue3697] "Fatal Python error: Cannot recover from stack overflow" on Windows buildbots

2008-09-02 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- nosy: +loewis ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3697> ___ ___ Python

[issue3594] PyTokenizer_FindEncoding() never succeeds

2008-09-03 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: I don't understand the whole decoding machinery in the tokenizer, but the patch looks ok to me. (tested in debug mode under Linux and Windows) -- nosy: +pitrou ___ Python tracker <[E

[issue3696] Error parsing arguments on OpenBSD <= 4.4

2008-09-03 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Amaury, as long as you fix the small quirk mentioned above (checking the return value of the second call to mbstowcs()), I think this patch can go in, since it does no harm on already working pla

[issue3658] fix for pychecker property complaints

2008-09-03 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: If it's only to please pychecker, then I don't think we should make this change. It's potential gratuitous breakage, especially if people subclass those classes. -- nosy: +pitrou _

[issue3110] Multiprocessing package build problem on Solaris 10

2008-09-03 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: I suggest committing a patch which falls back to _SEM_VALUE_MAX and see how the Solaris buildbot reacts. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3110] Multiprocessing package build problem on Solaris 10

2008-09-03 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: I recompiled and tested multiprocessing both under Windows and Linux with this patch, no problems detected. +1 for applying it. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3697] "Fatal Python error: Cannot recover from stack overflow" on Windows buildbots

2008-09-03 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Committed in r66186 after review by Amaury on IRC. -- resolution: -> fixed status: open -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

[issue3696] Error parsing arguments on OpenBSD <= 4.4

2008-09-03 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Committed in r66187. Henry, could you confirm it fixes the problem on your side? -- priority: release blocker -> critical resolution: -> accepted status: open -> pending ___

[issue3626] python3.0 interpreter on Cygwin ignores all arguments

2008-09-03 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: The mbstowcs problem should be fixed in r66187. What is the state of the other problems? Is this issue still a release blocker? -- nosy: +pitrou ___ Python tracker <[EMAIL PROTECTE

[issue3763] Python 3.0 beta 2 : json and urllib not working together?

2008-09-03 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: If you look at the headers of HTTP response, the encoding is utf-8. You should also be able to get this information by calling the info() method on the return value of urlopen(). -- nosy: +

[issue3492] Zlib compress/decompress functions returning bytearray

2008-09-04 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: +1 for committing. ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3492> ___ ___ Python

[issue3618] possible deadlock in IO library (Lib/io.py)

2008-09-04 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: We might as well bite the bullet and include a short, minimalist RLock implementation in io.py (so as not to pull threading and all its dependencies at startup). The C version of RLock will wait f

[issue3618] possible deadlock in IO library (Lib/io.py)

2008-09-04 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: Here is a patch. The RLock implementation is naive and as simple as possible. It doesn't solve Haypo's case, probably because the tracing func kicks in in the RLock code itself. I don't want to make a decision on t

[issue3618] possible deadlock in IO library (Lib/io.py)

2008-09-04 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- keywords: +needs review ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.python.org/issue3618> ___ _

[issue3756] re.escape() does not work with bytes()

2008-09-04 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: I don't think there are cases where re.escape is performance critical - are there any? By the way, it seems to me the simplest way to write re.escape() would be to use a regexp to do the replacement. It might or might not be

[issue3618] possible deadlock in IO library (Lib/io.py)

2008-09-04 Thread Antoine Pitrou
Antoine Pitrou <[EMAIL PROTECTED]> added the comment: (I have to add that the patch makes small reads about 60-80% slower) ___ Python tracker <[EMAIL PROTECTED]> <http://bugs.pytho

[issue3696] Error parsing arguments on OpenBSD <= 4.4

2008-09-04 Thread Antoine Pitrou
Changes by Antoine Pitrou <[EMAIL PROTECTED]>: -- resolution: accepted -> fixed status: pending -> closed ___ Python tracker <[EMAIL PROTECTED]> <http://bugs

<    39   40   41   42   43   44   45   46   47   48   >