Changes by Antoine Pitrou :
Added file: http://bugs.python.org/file23680/debugblocks2.patch
___
Python tracker
<http://bugs.python.org/issue13390>
___
___
Python-bug
Changes by Antoine Pitrou :
Added file: http://bugs.python.org/file23681/debugblocks3.patch
___
Python tracker
<http://bugs.python.org/issue13390>
___
___
Python-bug
Antoine Pitrou added the comment:
And the latest patch (debugblocks3.patch) adds said heuristic.
--
___
Python tracker
<http://bugs.python.org/issue13
Antoine Pitrou added the comment:
Good idea, IMO.
+cum = set()
+for i in range(100):
+val = getbytes(span)
+cum |= set(i for i in range(span) if val[i])
+self.assertEqual(len(cum), span)
I find this test a bit strange. Also
Antoine Pitrou added the comment:
Thanks for the patch. You should add the same tests for sys.version_info and
sys.getwindowsversion.
--
nosy: +pitrou
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issu
Antoine Pitrou added the comment:
Thank you for the patch. I only applied it to 3.3, since 3.2 doesn't have the
additional header files.
--
resolution: -> invalid
stage: patch review -> committed/rejected
status: open -> closed
versions
Antoine Pitrou added the comment:
> The problem is that we need an API that will accommodate other random
> number generators and not be specific to the MersenneTwister. Right
> now, the starting point for everything in the random module is an
> underlying generator supplying a ran
Changes by Antoine Pitrou :
--
nosy: +flox, loewis
___
Python tracker
<http://bugs.python.org/issue13397>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
Well, the sentinels argument, right now, is meant to be used internally. I
don't think it's a good thing to document it, since I don't think it's a very
clean API (I know, I introduced it :-)) - it's just so that concurrent.futures
Antoine Pitrou added the comment:
> Wouldn't a better alternative be to have a wait function which can
> deal with readable pipe connections and integer handles?
>
> On Unix this would just delegate to select().
>
> On Windows it could work as follows:
> * initiate
Changes by Antoine Pitrou :
--
nosy: +Garen, belopolsky, chrismiles, danchr, dhduvall, dmalcolm, fche, glyph,
hazmat, jbaker, laca, mjw, movement, neologix, pitrou, rhettinger, robert.kern,
ronaldoussoren, serverhorror, sirg3, twleung, wsanchez
Antoine Pitrou added the comment:
Here is a patch.
--
keywords: +patch
stage: -> patch review
Added file: http://bugs.python.org/file23686/utf7.patch
___
Python tracker
<http://bugs.python.org/issu
Changes by Antoine Pitrou :
--
nosy: +flox, loewis
___
Python tracker
<http://bugs.python.org/issue13404>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Antoine Pitrou :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue13401>
___
___
Python-bugs-list mailing list
Unsubscri
Changes by Antoine Pitrou :
--
nosy: +neologix, sbt
___
Python tracker
<http://bugs.python.org/issue13393>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Antoine Pitrou :
Now that the unicode-internal codec is deprecated, the test suite spouts some
warning (in test_codecs, test_codeccallbacks and test_unicode). Example:
[344/361] test_codecs
/home/antoine/cpython/default/Lib/test/test_codecs.py:1024: DeprecationWarning
Changes by Antoine Pitrou :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Antoine Pitrou added the comment:
It's a patch for 3.2.
--
___
Python tracker
<http://bugs.python.org/issue1>
___
___
Python-bugs-list mailing list
Antoine Pitrou added the comment:
Here is a non-git diff then :)
--
Added file: http://bugs.python.org/file23688/utf7-nogit.patch
___
Python tracker
<http://bugs.python.org/issue13
Antoine Pitrou added the comment:
I made a little fix to the patch for wide unicode builds and then committed it.
Thank you!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python track
Antoine Pitrou added the comment:
> Valgrind does a much better job at this: it will also show you where
> the leaked blocks were allocated.
> OTOH, Valgrind is Linux-only and slow, but since I haven't used the
> '-R' option much, I don't know how usable this
Antoine Pitrou added the comment:
Thanks again. Just a nit: the tests should be in MiscIOTest, since they don't
directly instantiate the individual classes. Also, perhaps it would be nice to
check that the exception's "errno" attribute is EAGAIN.
--
stage: needs p
Antoine Pitrou added the comment:
Ok, done. Let's see if that fixes the sporadic failures on the buildbots.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http:
Antoine Pitrou added the comment:
The patch looks good to me.
--
___
Python tracker
<http://bugs.python.org/issue13380>
___
___
Python-bugs-list mailin
Antoine Pitrou added the comment:
> LD_LIBRARY_PATH=current_path
> export LD_LIBRARY_PATH
Why do you need LD_LIBRARY_PATH?
> If you are inside a Solaris/OpenIndiana Zone, the zone *MUST* have
> dtrace usermode permissions. If not, you can not use dtrace inside the
> zone and,
New submission from Antoine Pitrou :
This patch allows hashing of memoryviews, as discussed on python-dev.
--
components: Interpreter Core
files: memhash.patch
keywords: patch
messages: 147714
nosy: ncoghlan, pitrou, skrah
priority: normal
severity: normal
stage: patch review
status
Changes by Antoine Pitrou :
--
nosy: +brian.curtin, tim.golden
___
Python tracker
<http://bugs.python.org/issue13412>
___
___
Python-bugs-list mailing list
Unsub
Antoine Pitrou added the comment:
> Then it appears to me that Sandro's patch is good and can be committed.
The doc patch is good. However, if you start exposing SimpleQueue at the
top package level, you have to do it in 3.3 only (since that's a new
API), and also mention it someh
Changes by Antoine Pitrou :
--
nosy: +belopolsky, lemburg
___
Python tracker
<http://bugs.python.org/issue13413>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Antoine Pitrou :
--
nosy: +barry, r.david.murray -BreamoreBoy
___
Python tracker
<http://bugs.python.org/issue1481032>
___
___
Python-bugs-list mailin
Antoine Pitrou added the comment:
What is the status on this, Nadeem? It would be lovely to get the feature in
the stdlib.
--
___
Python tracker
<http://bugs.python.org/issue6
Antoine Pitrou added the comment:
Closing this bug as PEP 393 is now implemented and makes so-called "narrow
builds" obsolete. Python now has an adaptative internal representation that is
able to fit all unicode characters.
--
resolution: -> out of date
stage: -> co
New submission from Antoine Pitrou :
PEP 393 and the need for a two-pass decoding process has made utf-8 decoding
much slower, especially with the current generic implementation. Attached patch
makes utf-8 more than twice faster, which means we're around 10-20% slower than
3.2 on non-tr
Antoine Pitrou added the comment:
Apparently you forgot to upload the patch...
--
___
Python tracker
<http://bugs.python.org/issue13215>
___
___
Python-bug
Antoine Pitrou added the comment:
I've tested under 64-bit Windows and it worked fine.
--
___
Python tracker
<http://bugs.python.org/issue6715>
___
___
Pytho
Changes by Antoine Pitrou :
--
nosy: +loewis
___
Python tracker
<http://bugs.python.org/issue13405>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
> Does memory_hash() reject non-contiguous memory?
It should, since it checks the strides array.
> _Py_HashBytes() might be reused by unicode_hash() for PyUnicode_1BYTE_KIND.
I don't really see how unicode hashing should be related to bytes
ha
Antoine Pitrou added the comment:
> I'm not sure that the "register" storage class specifier is still
> relevant with modern compilers: I'm pretty sure gcc ignores it unless
> -O0, and I think I've read somewhere Microsoft's compiler ignores it
> t
Antoine Pitrou added the comment:
Ok for me. Nice to see that piece of ugliness removed.
--
___
Python tracker
<http://bugs.python.org/issue13215>
___
___
Pytho
Antoine Pitrou added the comment:
You can use functools.partial for similar effect. Not sure what a dedicated
curry() primitive would improve.
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue13
Antoine Pitrou added the comment:
> However, here an example less confusional
>
> >>> adder = curry(lambda (x, y): (x + y))
> >>> adder3 = adder(3)
> >>> adder3(4)
> 7
> >>> adder3(5)
> 8
>
> Currying let you defining new fu
Antoine Pitrou added the comment:
Thanks Stefan. I'm leaving the issue open since the original topic is a bit
different.
--
___
Python tracker
<http://bugs.python.org/is
Antoine Pitrou added the comment:
Thanks. Who should I credit? "sbt"?
--
___
Python tracker
<http://bugs.python.org/issue13322>
___
___
Python-bugs-l
Antoine Pitrou added the comment:
This issue is obsolete, there are no 64-bit warnings in _pickle.c anymore.
See issue 11564.
--
resolution: -> out of date
stage: patch review -> committed/rejected
status: open -> closed
___
Python track
Antoine Pitrou added the comment:
> Sure, it's common `defining new functions on other functions`... more
> times. Here a stupid example with fold (our reduce).
>
> @curry
> def fold(function, start, sequence):
> if len(sequence) == 0:
> return start
&g
Antoine Pitrou added the comment:
I've committed a slightly modified patch. Not a huge improvement, but makes
sense nevertheless (and it's really short).
--
resolution: -> fixed
stage: patch review -> committed/rejected
status
Changes by Antoine Pitrou :
--
nosy: +haypo
versions: -Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/issue7695>
___
___
Python-bugs-list m
New submission from Antoine Pitrou :
time.xmlrpc.com seems dead (no DNS entry), which leads to failures on one of
the stable buildbots (redirecting DNS catchall?):
==
ERROR: test_current_time
Changes by Antoine Pitrou :
--
nosy: -pitrou
___
Python tracker
<http://bugs.python.org/issue13441>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Antoine Pitrou :
--
nosy: +ghaering
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue13445>
___
___
Python-bugs-list mailin
Antoine Pitrou added the comment:
> Firstly, I don't think it makes any sense to set encoding information
> globally for the Popen object. As a simple example, consider using
> Python to write a test suite for the iconv command line tool: there's
> only one Popen instan
Antoine Pitrou added the comment:
Thanks for the review, patch committed now (with bogus comments removed).
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bug
Antoine Pitrou added the comment:
Fixed, thanks.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Antoine Pitrou added the comment:
I've re-added the fast uncontended path in semaphore.c and committed
sigint_event.patch. Now I'm gonna take a look at pipe_poll_fix.patch...
--
stage: -> patch review
versions: -Python 2.6, Python 2.7, Python 3.
New submission from Antoine Pitrou :
Here is an issue covering PEP 3155 implementation. Hopefully a "review" link
will appear in front of the hg repo URL.
--
components: Interpreter Core
hgrepos: 91
messages: 148087
nosy: ncoghlan, pitrou
priority: normal
severity: normal
st
Changes by Antoine Pitrou :
--
keywords: +patch
Added file: http://bugs.python.org/file23744/baec10c6dcd4.diff
___
Python tracker
<http://bugs.python.org/issue13
Antoine Pitrou added the comment:
I think this would be better served by a separate method. You could call it
e.g. run_nowait().
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue13
Changes by Antoine Pitrou :
--
nosy: +eric.smith, rhettinger
___
Python tracker
<http://bugs.python.org/issue13450>
___
___
Python-bugs-list mailing list
Unsub
Antoine Pitrou added the comment:
I think the reason these docs are scattered is that the devguide is a guide,
not a reference manual. I don't think this patch makes sense: if the tracker
really needed so much text to explain how it works, then the tracker would have
a severe UI pr
Antoine Pitrou added the comment:
I think closing stdout is a legitimate desire so, yes, I would consider it a
bug if we print an error in that case.
A patch could either first check the "closed" attribute, or silence the
ValueError.
--
stage: -> needs patch
type:
Antoine Pitrou added the comment:
> Here is an updated patch (pipe_poll_fix.patch) which should be applied
> on top of sigint_event.patch.
>
> It fixes the problems with PipeConnection.poll() and Queue.empty() and
> makes PipeListener.accept() use overlapped I/O. This should
Antoine Pitrou added the comment:
Patch committed, thank you.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: +Python 3.3
___
Python tracker
<http://bugs.python.or
Antoine Pitrou added the comment:
> There are three "expected" error conditions:
>
> ERROR_OPERATION_ABORTED: operation stopped by CancelIo(Ex)()
> ERROR_MORE_DATA: operation complete, but only got part of the message
> ERROR_IO_INCOMPLETE: operation still has not f
Antoine Pitrou added the comment:
Ping.
--
___
Python tracker
<http://bugs.python.org/issue13125>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Antoine Pitrou :
Added file: http://bugs.python.org/file23766/942ba1e2f8c1.diff
___
Python tracker
<http://bugs.python.org/issue13448>
___
___
Python-bug
Antoine Pitrou added the comment:
New patch addressing Benjamin's and Victor's comments.
--
___
Python tracker
<http://bugs.python.org/issue13448>
___
___
Antoine Pitrou added the comment:
> This is true, however different people can figure out a different
> amount of things just by using and experiment with something. While
> most of the tasks should be obvious, some are a bit more advanced, and
> even the "obvious" onc
Antoine Pitrou added the comment:
> Why an upper P in "PyFunction_NewWithQualName"? If you use an upper P,
> it should use an underscore in Python: __qual_name__ to be consistent.
__getattr__ / PyObject_GetAttr.
--
___
Pytho
Antoine Pitrou added the comment:
> > It seems to me that ERROR_OPERATION_ABORTED is a "true" error, and so
> > should raise an exception.
>
> I guess so, although we do expect it whenever poll() times out. What
> exception would be appropriate? BlockingIOEr
Antoine Pitrou added the comment:
Uh, rather -1 on this. I would suggest Jython gets its own devguide (which can
of course copy stuff from CPython's), since Jython and CPython are distinct
projects. No need to confuse readers by mixing instructions for two different
projects in a s
Antoine Pitrou added the comment:
> Hosting "docs.python.org/devguide/jython" doesn't seem like an
> unreasonable idea at all to me, and what's the benefit to CPython in
> making the Jython team go to the effort of building out independent
> deployment and s
Antoine Pitrou added the comment:
> Just a thought: Would this change be worthy for the "What's new in 3.3"
> list?
I think so.
--
___
Python tracker
<http://bu
Antoine Pitrou added the comment:
"they" is right and "she" is actually right too.
See http://en.wikipedia.org/wiki/Singular_they
--
nosy: +pitrou
resolution: -> works for me
status: open -> pending
___
Python tracke
Changes by Antoine Pitrou :
--
nosy: +vinay.sajip
type: -> behavior
versions: +Python 2.7, Python 3.2, Python 3.3 -Python 2.6
___
Python tracker
<http://bugs.python.org/issu
Antoine Pitrou added the comment:
As the name implies, _setup_queues is a private method. It feels a bit weird to
recommend overriding it in a subclass.
--
nosy: +pitrou
stage: test needed -> needs patch
versions: +Python 3.3 -Python 3.2
___
Pyt
Antoine Pitrou added the comment:
Well, it's a quick start. The link to "build Python" actually tells you about
dependencies.
--
nosy: +pitrou
___
Python tracker
<http://bugs.pyt
Antoine Pitrou added the comment:
What if you replace:
PyObject *decoded = PyObject_CallMethod(
self->decoder, "decode", "s#", input, 1);
with:
PyObject *decoded = PyObject_CallMethod(
self->decoder, "decode", "s#&q
Antoine Pitrou added the comment:
Looks ok to me as well. I think this is a new feature, so 3.3-only IMHO.
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue9
Antoine Pitrou added the comment:
For the record, this seems to make large allocations slower:
-> with patch:
$ ./python -m timeit "b'x'*20"
1 loops, best of 3: 27.2 usec per loop
-> without patch:
$ ./python -m timeit "b'x'*20"
10
Antoine Pitrou added the comment:
> Is it intended that pickle will use __qualname__?
That's part of the plan for PEP 3154, yes.
--
___
Python tracker
<http://bugs.python.org
Antoine Pitrou added the comment:
More surprising is that, even ignoring the allocation cost, other operations on
the memory area seem more expensive:
$ ./python -m timeit -s "b=bytearray(50)" "b[:] = b"
-> python 3.3:
1000 loops, best of 3: 367 usec per loop
-&g
Antoine Pitrou added the comment:
> I see you're comparing 3.2 and default: could you run the same
> benchmark on default with and without the patch ?
Same results:
-> default branch:
1000 loops, best of 3: 364 usec per loop
-> default branch with patch reverted:
1 loop
Antoine Pitrou added the comment:
Ah, sorry, false alarm. "b[:] = b" actually makes a temporary copy of the
bytearray when assigning to itself (!).
However, there's still another strange regression:
$ ./python -m timeit \
-s "n=30; f=open('10MB.bin',
Antoine Pitrou added the comment:
> The distutils changes will not happen, we’re under a feature freeze.
> Cross-compilation support would need to be added to packaging, and we
> need to port Python’s build process to packaging too for 3.4 or 3.5.
Why 3
Changes by Antoine Pitrou :
--
versions: +Python 3.2, Python 3.3
___
Python tracker
<http://bugs.python.org/issue13461>
___
___
Python-bugs-list mailing list
Unsub
Changes by Antoine Pitrou :
--
priority: normal -> high
type: -> crash
___
Python tracker
<http://bugs.python.org/issue13461>
___
___
Python-bugs-list
Antoine Pitrou added the comment:
Committed, thank you. By the way, Ryan, we now use Mercurial for developing,
the Subversion repository is obsolete (see the devguide for more info).
--
___
Python tracker
<http://bugs.python.org/issue9
Antoine Pitrou added the comment:
Now committed together with docs and a what's new entry. Thanks for the reviews!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http:
Antoine Pitrou added the comment:
LGTM too.
You could also add a test to test_sys ensuring that sys.executable is always
executable.
--
___
Python tracker
<http://bugs.python.org/issue13
Antoine Pitrou added the comment:
> > You could also add a test to test_sys ensuring that sys.executable
> > is always executable.
>
> And that sys.executable is absolute?
Er, yes, that's what I meant. Sorry.
--
__
Antoine Pitrou added the comment:
Patch committed, thank you!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Antoine Pitrou added the comment:
> On my box:
> default:
> $ ./python -m timeit -s "n=30; f=open('/tmp/10MB.bin', 'rb');
> b=bytearray(n)" "f.seek(0);f.readinto(b)"
> 1000 loops, best of 3: 640 usec per loop
>
> default wi
Antoine Pitrou added the comment:
This broke several Gentoo buildbots.
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue12567>
___
___
Python-bug
New submission from Antoine Pitrou :
This patch uses an accurate POSIX clock if possible in the timeit module.
--
components: Library (Lib)
files: timeit_clock.patch
keywords: patch
messages: 148369
nosy: georg.brandl, pitrou
priority: normal
severity: normal
stage: patch review
status
Antoine Pitrou added the comment:
> There are some callables which are missing __qualname__:
>
> method_descriptor
> wrapper_descriptor
> builtin_function_or_method
>
> For the descriptors, at least, obj.__qualname__ should be equivalent to
>
> ob
Antoine Pitrou added the comment:
Well, you only call the clock at the begining and end of a timing run, not at
each iteration.
--
___
Python tracker
<http://bugs.python.org/issue13
Antoine Pitrou added the comment:
> With CLOCK_PROCESS_CPUTIME_ID:
> - depending on the platform, we'll measure either wall-clock time or
> CPU time
Indeed. I thought CPU time would be more useful (and that's the point of
the patch) but perhaps it breaks the spec.
>
Antoine Pitrou added the comment:
> > But does it include kernel CPU time for the given process?
>
> Yes. But it won't be reliable, for example, to measure the performance
> of a new readinto() implentation, since time spent by the process in
> 'S' or '
New submission from Antoine Pitrou :
Similar to issue #11849, this patch proposes to use VirtualAlloc/VirtualFree to
allocate the Python allocator's memory arenas (rather than malloc() / free()).
It might help release more memory if there is some fragmentation, although I
don'
Antoine Pitrou added the comment:
The tests break on the Windows buildbots:
==
ERROR: test_relative_path (test.test_py_compile.PyCompileTests)
--
Traceback
301 - 400 of 16792 matches
Mail list logo