Changes by Antoine Pitrou :
Removed file: http://bugs.python.org/file21875/unnamed
___
Python tracker
<http://bugs.python.org/issue6721>
___
___
Python-bugs-list mailin
Antoine Pitrou added the comment:
Thanks for the explanations. This sounds like an interesting path.
> Each thread implementation (thread_pthread.h, thread_nt.h)
> would provide a new PyThread_reinit_lock function that would do the
> right thing (pthread_mutex_destroy/init, sem_des
Antoine Pitrou added the comment:
Ok, here's a patch for the new approach.
CancelIoEx is loaded dynamically and, if unavailable, CancelIo is used instead.
I take care to cancel or complete the I/O in the same method call where it is
initiated, meaning there's no thread-specific
Antoine Pitrou added the comment:
> Updated patch.
>
> Note: I tried to keep the same enum values for py_ssl_version, it's
> maybe useless and so "=1" can be removed.
Thank you! PROTOCOL_NAMES should stay private and therefore be named
_PROTOCOL_NAMES, IMHO.
Keep
Antoine Pitrou added the comment:
> New changeset 5296c3e2f166 by Victor Stinner in branch 'default':
> Issue #12012: ssl.PROTOCOL_SSLv2 becomes optional
> http://hg.python.org/cpython/rev/5296c3e2f166
Since it's a bugfix, it should proba
Antoine Pitrou added the comment:
> It would be nice if you can also patch _pyio. I read sometimes _pyio
> to check how _io is implemented.
Well, _pyio implements the same APIs but it doesn't necessarily use the
same algorithms.
--
___
Antoine Pitrou added the comment:
Now checked in, hopefully there will be no buildbot failures.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> pending
___
Python tracker
<http://bugs.python.or
Changes by Antoine Pitrou :
--
nosy: +mark.dickinson
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue8305>
___
___
Python-bugs-list mailin
Antoine Pitrou added the comment:
In the mean time I had to resort to dirty hacks in 1ac03e071d65 (such as using
io.BytesIO.write(), which I know is implemented in C and doesn't care about
item size).
At the minimum, a memoryview.getflatview() function would be nice (and probably
easi
Changes by Antoine Pitrou :
--
stage: patch review -> needs patch
___
Python tracker
<http://bugs.python.org/issue5231>
___
___
Python-bugs-list mailing list
Un
Changes by Antoine Pitrou :
--
status: pending -> closed
___
Python tracker
<http://bugs.python.org/issue11743>
___
___
Python-bugs-list mailing list
Unsubscri
New submission from Antoine Pitrou :
The title says it all. Ideally (!), changing .hgignore should be enough to fix
this issue.
(NB: I have only tested the default branch)
==
FAIL: test_byte_message_rfc822_only
New submission from Antoine Pitrou :
>>> tc.assertEqual("x\n" * 40 + "\n", "x\n" * 40 + "\r\n")
Traceback (most recent call last):
File "", line 1, in
File "/home/antoine/cpython/default/Lib/unittest/case.py", line 6
New submission from Antoine Pitrou :
This patch exposes a new read-only property of multiprocessing.Process objects,
named "sentinel".
As the doc indicates, this is a file descriptor undex Unix, and a handle under
Windows. Both are suitable for flexible polling/waiting with the appr
Antoine Pitrou added the comment:
Part of the patch submitted standalone in issue12040.
--
dependencies: +Expose a Process.sentinel property (and fix polling loop in
Process.join())
___
Python tracker
<http://bugs.python.org/issue9
Antoine Pitrou added the comment:
What seems to happen is that test_ctypes runs a lot of ldconfig processes, and
the 10 retries in fork_wait are not enough to consume them all.
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue12
New submission from Antoine Pitrou :
I find it a bit strange that Popen.__exit__ closes all standard file
descriptors leading to the child process, but doesn't wait for process end
afterwards.
(context management support was added in issue10554)
--
messages: 135635
nosy: brian.c
Antoine Pitrou added the comment:
This should be fixed, can you confirm?
PS: I've opened issue12044 as one of the root causes.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> pending
___
Python
Antoine Pitrou added the comment:
> Seems like it would be enough to add a wait() at the end?
Probably, perhaps with a try/finally?
I'm not entirely sure this is a good idea, by the way. May there be some
drawbacks?
--
___
Python tracke
Antoine Pitrou added the comment:
> If you care about security, you should not use the Python random
> module because it is not cryptographic. Oh oh, ssl doesn't expose
> RAND_bytes().
Feel free to open a separate issue and even p
Antoine Pitrou added the comment:
> Actually, I don't think the wait() is a good idea. If you want to
> block and infinitely wait on the process to close, you should do so
> explicitly.
Ok.
> It's probably better that we try to use terminate() or kill() and raise if
New submission from Antoine Pitrou :
It seems `cmd` is executed twice, for no obvious reason, in the following code:
http://hg.python.org/cpython/file/2d4ef202d4ed/Lib/ctypes/util.py#l129
--
components: Library (Lib)
messages: 135650
nosy: pitrou
priority: normal
severity: normal
stage
Antoine Pitrou added the comment:
> I'm thinking there's not a lot we can do here, but also not a lot that
> we should do here. We don't want to wait, and we don't want to close,
> so maybe we should just document that the usage should be limited only
> to
Antoine Pitrou added the comment:
Well, no, looks ok for me then :)
--
resolution: -> rejected
status: pending -> closed
___
Python tracker
<http://bugs.python.org/i
Antoine Pitrou added the comment:
> Based on the above I think you are right about using the internal buffer
> regardless (revision attached). You pay a price with larger buffer sizes but
> on
> balance it seems to be a much better general purpose solution. The java-like
> sol
Antoine Pitrou added the comment:
By the way, the Java-like version actually seems quite interesting.
--
___
Python tracker
<http://bugs.python.org/issue9
Antoine Pitrou added the comment:
> Patch: signal.signal() and signal.siginterrupt() raise an OSError,
> instead of a RuntimeError: OSError has an errno attribute.
>
> --
> keywords: +patch
> Added file: http://bugs.python.org/file21939/signal_oserror.patch
Antoine Pitrou added the comment:
Committed, thanks for the patch and review!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: +Python 3.3 -Python 2.6, Python 3.1
___
Python tracker
<http://bug
Antoine Pitrou added the comment:
> Also, while we're at it, would it be worthwhile for me to make a patch
> for the prefech() method you proposed? Should a separate issue be
> created for that? I know there was no definitive answer in the email
> thread but it may be fun to e
Antoine Pitrou added the comment:
An obvious one indeed, thank you :)
--
nosy: +pitrou
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: +Python 3.2, Python 3.3
___
Python tracker
<http://bug
Antoine Pitrou added the comment:
> On Linux 32 bits, size_t is 32 bits, off_t is 64 bits. If the file size
> is 4 GB, the downcast may truncate the size of 0 byte.
We are not talking about the file size here.
--
___
Python tracker
Changes by Antoine Pitrou :
--
nosy: +georg.brandl
___
Python tracker
<http://bugs.python.org/issue12056>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
I've committed a minimally modified version of the patch, thank you!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.pyt
Antoine Pitrou added the comment:
Comments:
- I don't like the fact that skip_unless_cjson() uses unittest internals. Why
can't you write something like:
skip_unless_cjson = skipUnless(...)
- instead of "self.mod", "self.json" would be nicer
- you
Changes by Antoine Pitrou :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue12059>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
Is it a theoretical concern or does it affect real software?
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue12
Antoine Pitrou added the comment:
Here is a patch with assorted tests.
--
keywords: +patch
nosy: +barry, benjamin.peterson, georg.brandl, pitrou
priority: normal -> release blocker
stage: -> patch review
versions: +Python 2.7, Python 3.1, Python 3.3
Added file: http://bugs.pyth
Changes by Antoine Pitrou :
--
nosy: +haypo
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue12048>
___
___
Python-bugs-list mailin
Antoine Pitrou added the comment:
Here is a new patch addressing Gregory's comment (retry select() on EINTR).
--
Added file: http://bugs.python.org/file21983/process_sentinel2.patch
___
Python tracker
<http://bugs.python.org/is
Changes by Antoine Pitrou :
--
nosy: +pitrou
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue12065>
___
___
Python-bugs-list mailin
Antoine Pitrou added the comment:
Judging by ssl.connect_ex's source code, this can only mean that socket.connect
raised a socket error with a "None" errno...
--
___
Python tracker
<http://bugs.pyt
Antoine Pitrou added the comment:
Which probably means it was a socket.timeout. When called on a non-SSL socket,
connect_ex() returns 11 (EAGAIN) for timeout errors:
>>> s = socket.socket()
>>> s.settimeout(0.1)
>>> s.connect_ex(("svn.python.org", 443
Antoine Pitrou added the comment:
> class TestSomething(TestCase):
> def test_something(self): ...
> class TestPySomething(TestSomething, PyTest): pass
> class TestCSomething(TestSomething, CTest): pass
I was thinking about that. That looks clean and ex
New submission from Antoine Pitrou :
This has started popping up on several buildbots:
==
FAIL: test_rollover (test.test_logging.TimedRotatingFileHandlerTest
Antoine Pitrou added the comment:
Should be fixed now. Again, thank you reporting this bug!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Antoine Pitrou added the comment:
> With this approach is necessary to exclude the base class from the
> tests, either by listing all the Python/C tests explicitly or doing
> some automatic check to find these base classes.
It just needs a small change then:
class PyTest
Antoine Pitrou added the comment:
> Antoine, I've got a couple questions concerning your patch:
> - IIUC, the principle is to create a pipe for each worker process, so
> that when the child exits the read-end - sentinel - becomes readable
> (EOF) from the parent, so you know th
Antoine Pitrou added the comment:
> ...so how can we establish correct (cross library) locking order
> during prepare stage?
That sounds like a lost battle, if it requires the libraries'
cooperation. I think resetting locks is the best we can do. It might not
work ok in all cases
Antoine Pitrou added the comment:
> But Lib/multiprocessing/connection.py does:
>
> def _send_bytes(self, buf):
> # For wire compatibility with 3.2 and lower
> n = len(buf)
> self._send(struct.pack("=i", len(buf)))
> # The
Antoine Pitrou added the comment:
> Just a detail, but with the last version, select is retried with the
> full timeout (note that the signal you're the most likely to receive
> is SIGCHLD and since it's ignored by default it won't cause EINTR, so
> this shouldn'
Antoine Pitrou added the comment:
> I think that threading._get_ident() is more reliable than
> threading.current_thread().ident because Thread.ident can be None in
> some cases.
In which case can it be None?
--
___
Python track
Antoine Pitrou added the comment:
> Thus,
> Connection.recv_bytes() will be called:
>
> def _recv_bytes(self, maxsize=None):
> buf = self._recv(4)
> size, = struct.unpack("=i", buf.getvalue())
> if maxsize is not None and size >
Antoine Pitrou added the comment:
"posixcap" sounds ok to me.
--
___
Python tracker
<http://bugs.python.org/issue1615158>
___
___
Python-bugs-l
Antoine Pitrou added the comment:
Yes, it should be trivial to fix.
I've stumbled on this simply because I needed to write similar code for another
patch, so studied how it was done in posixmodule.c.
--
___
Python tracker
<http://bugs.py
Changes by Antoine Pitrou :
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue12091>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
Sorry to reopen, but do these methods really have to return *byte strings* for
interface names?
In Python 3, we usually take the position that textually meaningful data should
be str, not bytes (even filenames under POSIX). The usual way to do this is to
use
Antoine Pitrou added the comment:
> I've dropped wet-her!
> I hope now you're satisfied!
> So the buffer cache is all which remains hot.
> How deserted!
I'm not sure I'm always understanding your messages well (I'm not a
native English speaker), b
Changes by Antoine Pitrou :
--
type: behavior -> feature request
versions: +Python 3.3 -Python 2.6
___
Python tracker
<http://bugs.python.org/issue12098>
___
_
Antoine Pitrou added the comment:
We already have some logic for that:
http://hg.python.org/cpython/file/default/Lib/test/support.py#l1398
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue12
Antoine Pitrou added the comment:
Thank you Kasun. I did a couple of minor style fixes (whitespace at end of
line, and spaces around the '=' assignment sign). I also added a test for
starttls(), since it turns out gmail.com supports it on port 25.
--
resolution: ->
Antoine Pitrou added the comment:
Here is a patch.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file22023/ssl_connect_ex.patch
___
Python tracker
<http://bugs.python.org/issu
Antoine Pitrou added the comment:
Still happens sometimes:
http://www.python.org/dev/buildbot/all/builders/x86%20Gentoo%203.x/builds/133/steps/test/logs/stdio
Traceback (most recent call last):
File "/var/lib/buildslave/3.x.murray-gentoo/buil
Changes by Antoine Pitrou :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Antoine Pitrou :
--
nosy: pitrou
priority: normal
severity: normal
status: open
title: test_packaging monkeypatches httplib
___
Python tracker
<http://bugs.python.org/issue12
New submission from Antoine Pitrou :
==
ERROR: test_https (test.test_urllib2_localnet.TestUrlopen)
--
Traceback (most recent call last):
File
"D:\Build
New submission from Antoine Pitrou :
==
ERROR: test_https (test.test_urllib2_localnet.TestUrlopen)
--
Traceback (most recent call last):
File
"D:\Build
Changes by Antoine Pitrou :
--
resolution: -> duplicate
status: open -> closed
superseder: -> test_packaging monkeypatches httplib
___
Python tracker
<http://bugs.python.or
Changes by Antoine Pitrou :
--
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue12108>
___
___
Python-bugs-
Antoine Pitrou added the comment:
$ grep -r https_conn_wrapper *
Lib/packaging/tests/test_command_upload_docs.py:146:def
https_conn_wrapper(*args):
Lib/packaging/tests/test_command_upload_docs.py:152:
upload_docs_mod.http.client.HTTPSConnection = https_conn_wrapper
New submission from Antoine Pitrou :
$ ./python -m test -Fv -unetwork test_packaging
[...]
==
ERROR: test_download (packaging.tests.test_pypi_dist.TestDistInfo
Antoine Pitrou added the comment:
Looks good here, thank you :)
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Antoine Pitrou added the comment:
Still fails on test_download.
--
___
Python tracker
<http://bugs.python.org/issue12113>
___
___
Python-bugs-list mailin
Antoine Pitrou added the comment:
+if not isinstance(fileobject, StringIO):
+encoding = codecs.lookup(fileobject.encoding).name
IMO you should try to get the "encoding" attribute and silence the
AttributeError instead.
(also, I'm not even sure why you'
Antoine Pitrou added the comment:
Also, the hash value is different every time:
packaging.pypi.errors.HashDoesNotMatch: got 043840092b5baf155fc94a77319c5f44
instead of fe18804c5b722ff024cabdf514924fc4
--
___
Python tracker
<http://bugs.python.
Antoine Pitrou added the comment:
This is by design.
--
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
New submission from Antoine Pitrou :
I get the following failure under a fresh checkout:
==
ERROR: test_file_from_empty_string_dir
(importlib.test.source.test_file_loader.SimpleTest
New submission from Antoine Pitrou :
I get the following failure under a fresh checkout:
==
ERROR: test_issue5604 (test.test_imp.ImportTests)
--
Traceback
New submission from Antoine Pitrou :
I get the following failure under a fresh checkout:
==
FAIL: test_package_data (distutils.tests.test_build_py.BuildPyTestCase
Changes by Antoine Pitrou :
--
nosy: +alexis
___
Python tracker
<http://bugs.python.org/issue12119>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Antoine Pitrou :
I get the following failure under a fresh checkout:
==
FAIL: test_package_data (packaging.tests.test_command_build_py.BuildPyTestCase
New submission from Antoine Pitrou :
I get the following failure when the ssl module is not available:
==
ERROR: test_https_connection
(packaging.tests.test_command_upload_docs.UploadDocsTestCase
New submission from Antoine Pitrou :
I get the following failures in a fresh checkout:
==
ERROR: test_explicit_relative_import (test.test_runpy.RunModuleTest
New submission from Antoine Pitrou :
I get the following failures under a fresh checkout:
==
ERROR: test_file_to_source (test.test_import.ImportTests
Antoine Pitrou added the comment:
Simple: you are not supposed to use the raw file if you wrapped it inside a
buffered file.
--
___
Python tracker
<http://bugs.python.org/issue12
Antoine Pitrou added the comment:
> I cannot reproduce this. there's exactly the same test in distutils,
> so I am wondering why it passes there and not in packaging for you.
It doesn't. Have you seen http://bugs.python.org/issue12119 ?
> Any special way to run the tes
Antoine Pitrou added the comment:
Indeed, PYTHONDONTWRITEBYTECODE seems set by default on this Linux install...
Ouch.
--
___
Python tracker
<http://bugs.python.org/issue12
Antoine Pitrou added the comment:
This is due to PYTHONDONTWRITEBYTECODE being set. Not sure this is worth fixing.
--
___
Python tracker
<http://bugs.python.org/issue12
Antoine Pitrou added the comment:
This is due to PYTHONDONTWRITEBYTECODE being set. Not sure this is worth fixing.
--
___
Python tracker
<http://bugs.python.org/issue12
Antoine Pitrou added the comment:
This is due to PYTHONDONTWRITEBYTECODE being set. Not sure this is worth fixing.
--
___
Python tracker
<http://bugs.python.org/issue12
Antoine Pitrou added the comment:
This is due to PYTHONDONTWRITEBYTECODE being set. Not sure this is worth fixing.
--
___
Python tracker
<http://bugs.python.org/issue12
Antoine Pitrou added the comment:
This is due to PYTHONDONTWRITEBYTECODE being set. Not sure this is worth fixing.
--
___
Python tracker
<http://bugs.python.org/issue12
Antoine Pitrou added the comment:
> a well, we can skip that pyc test in case PYTHONDONTWRITEBYTECODE is set,
> thanks !
It's better to test sys.flags.dont_write_bytecode, actually.
--
___
Python tracker
<http://bugs.python.
Changes by Antoine Pitrou :
--
nosy: +charles-francois.natali, gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue12107>
___
___
Python-bugs-list m
Antoine Pitrou added the comment:
Honestly, now that it's been established that it has to do with a bogus system
default (on Mageia/Mandriva installs), I'm not sure it's worth fixing if it
means adding more logic to the tests.
--
assigne
Antoine Pitrou added the comment:
> My first commit :-)
> What's the next step?
> Can this issue be closed, or should I wait until the tests pass on
> some buildbot?
You can close the issue nevertheless (as "fixed" /
"committed/rejected"). It can be reopene
Antoine Pitrou added the comment:
Thanks for the patches.
One comment: I'm not sure a frozen interpreter can take regular Python flags.
As for the test, you could run a function returning sys.flags from the child to
the parent, and check that the returned value is equal to the par
Changes by Antoine Pitrou :
Removed file: http://bugs.python.org/file22038/unnamed
___
Python tracker
<http://bugs.python.org/issue12107>
___
___
Python-bugs-list mailin
Antoine Pitrou added the comment:
The socket HOWTO looks so stupid, obscure and badly written that it should IMO
be deleted.
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue12
Antoine Pitrou added the comment:
Well, my main issue with this document is that it doesn't seem to have a
well-defined destination:
- people who know sockets won't learn anything from it
- but people who don't know sockets will probably find it clear as mud (for
example, what
Changes by Antoine Pitrou :
--
assignee: -> tarek
components: +Distutils2
nosy: +alexis, eric.araujo
___
Python tracker
<http://bugs.python.org/issu
2901 - 3000 of 16792 matches
Mail list logo
