Antoine Pitrou added the comment:
Issue fixed in r84239 (trunk), r84240 (2.7) and r84241 (3.1).
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Antoine Pitrou added the comment:
> Of course, I'd be all for changing local_getattro/local_setattro
> to not need _ldict to make that guarantee! _ldict always *returns*
> the correct pointer; it would be nice to make use of that somehow.
Indeed. Therefore, perhaps we could bre
Antoine Pitrou added the comment:
The original patch won't apply anymore, because of changes in the thread._local
implementation.
Instead, here is a new patch, which also adds tests for the __dict__ behaviour,
and two new private API functions: _PyObject_Generic{Get,Set}AttrWithDict.
Antoine Pitrou added the comment:
Ok, then let's continue in #1868.
--
resolution: -> duplicate
status: open -> closed
superseder: -> threading.local doesn't free attrs when assigning thread exits
___
Python tracker
<
Antoine Pitrou added the comment:
It should be noted that the original reason for this issue is already gone in
SVN (as part of the reimplementation alluded to above), but the timing
fragility is still there since there can be a thread switch between the moment
the "dict" member
Changes by Antoine Pitrou :
--
nosy: +haypo
___
Python tracker
<http://bugs.python.org/issue7415>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Antoine Pitrou :
--
nosy: +haypo
___
Python tracker
<http://bugs.python.org/issue1027206>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
> It would be good if the test timed out rather than deadlocking in the
> face of a broken import lock.
I could do that indeed. I'm not sure it would be much better, though, because
the lock will still be held and posterior tests may freeze m
Antoine Pitrou added the comment:
> Was I meant to still be looking at mtimport or threadimp, or have both
> of those been applied?
threadimp has already been committed.
As for mtimport, I'll try to refactor it into a prope
Antoine Pitrou added the comment:
The new patch was committed in r84258, thanks Nick.
--
___
Python tracker
<http://bugs.python.org/issue9251>
___
___
Python-bug
Changes by Antoine Pitrou :
Removed file: http://bugs.python.org/file17995/threadimp.patch
___
Python tracker
<http://bugs.python.org/issue9251>
___
___
Python-bugs-list m
Changes by Antoine Pitrou :
Removed file: http://bugs.python.org/file18003/threadimp2.patch
___
Python tracker
<http://bugs.python.org/issue9251>
___
___
Python-bug
Changes by Antoine Pitrou :
Removed file:
http://bugs.python.org/file18605/issue9251_threadimp_py3k_head.patch
___
Python tracker
<http://bugs.python.org/issue9
Changes by Antoine Pitrou :
Removed file: http://bugs.python.org/file17828/tofrombytes.diff
___
Python tracker
<http://bugs.python.org/issue8990>
___
___
Python-bug
Antoine Pitrou added the comment:
>From a quick glance, the latest patch looks ok.
--
___
Python tracker
<http://bugs.python.org/issue8990>
___
___
Python-
Antoine Pitrou added the comment:
Thank you Nick! I've committed the patch in r84268 (py3k) and r84269 (3.1).
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: +Python 3.1
___
Python
Antoine Pitrou added the comment:
> >> Think of e.g. embedded Python interpreters or py2exe-style applications
> >> running on Linux or other systems that don't use Unicode APIs
> >> for FS-interaction or have fixed FS-encodings.
> >
> > Wha
Antoine Pitrou added the comment:
> But I can tell you that I've never had another FTP program fail like
> Python 3 is failing for me trying to what seems like a simple transfer
> of a text file (expecting the line endings to be adjusted).
Python 3 is not failing, you are jus
Antoine Pitrou added the comment:
This is not a failure, it just indicates that the tests get skipped.
While I agree that ideally the tests should be able to run on all systems, it
should also be noted that the pickle protocols are (supposed to be)
platform-agnostic and, therefore, it is not
Antoine Pitrou added the comment:
Thank you Gregory. I've committed the patch in r84344 (py3k), r84345 (3.1) and
r84346 (2.7).
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http:
New submission from Antoine Pitrou :
This is a reworked reference implementation of _threading_local without the
__del__ quirks. The _patch() ugliness is unfortunately still needed because of
a doctest checking that derived __slots__ attributes aren't actually
thread-local.
Note that
Antoine Pitrou added the comment:
Committed in r84347 (py3k) and r84348 (3.1).
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: -Python 2.7
___
Python tracker
<http://bugs.python.o
Antoine Pitrou added the comment:
> SSLError: _ssl.c:296: Both the key & certificate files must be
> specified for server-side operation
>
> I would change this behavior in SSLSocket constructor and raise
> ValueError if server_side is True and certfile is None.
Good
Antoine Pitrou added the comment:
> The only idea which comes to mind is try to open() the file before calling
> load_cert_chain().
> That would automatically also take care of permission errors, etc..
> Not very clean, but... :-\
It's vulnerable to various issues such as rac
Antoine Pitrou added the comment:
> >>> ctx = ssl.SSLContext(ssl.PROTOCOL_SSLv23)
> >>> ctx.wrap_socket(socket.socket(), server_side=1)
>
> >>>
>
> I'm not sure how to raise ValueError("certfile must be specified")
> here as SSL
Antoine Pitrou added the comment:
> @Antoine: ok, thanks.
>
> This is now committed in r84352.
I don't think it's ok to test for the IOError message ("No such file"),
because it comes from the OS and can therefore change from platform to
platform. Instead, you
New submission from Antoine Pitrou :
This is an improvement patch for the :mod:`io` documentation.
It adds an user-friendly overview, and makes a couple of other
fixes/improvements.
There's a problem where I want to make a link to a glossary term while using
the plural form ("abs
Changes by Antoine Pitrou :
Removed file: http://bugs.python.org/file18679/iodoc.patch
___
Python tracker
<http://bugs.python.org/issue9715>
___
___
Python-bugs-list m
Changes by Antoine Pitrou :
Added file: http://bugs.python.org/file18680/iodoc.patch
___
Python tracker
<http://bugs.python.org/issue9715>
___
___
Python-bugs-list mailin
Antoine Pitrou added the comment:
Ok, committed in r84357 (py3k) and r84358 (3.1). Backporting to 2.7 would be
too much work.
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: -P
Antoine Pitrou added the comment:
> "The default mode is ``'r'`` (open for reading text, synonym of
> ``'rt'``)". I liked the original wording better.
Well, people use "r" in practice, and "rt" is a somewhat rarer
a
Antoine Pitrou added the comment:
> File I/O and memory I/O would have more uniform in their APIs and thus be
> easier to document, describe and use. Currently, one class is used to do
> file I/O.
That's wrong. Various classes are used for file I/O: FileIO,
Buffered{Reader
Antoine Pitrou added the comment:
Patch committed in r84366 (py3k), r84367 (3.1), r84368 (2.7). Thanks for your
contribution!
--
nosy: +pitrou
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: -Python 2.6, P
Antoine Pitrou added the comment:
Good catch. keyfile without certfile should be forbidden, and raise a
ValueError.
--
components: +Library (Lib)
stage: -> needs patch
type: -> behavior
versions: +Python 3.2
___
Python tracker
Antoine Pitrou added the comment:
Not really, but in previous versions it would fail as soon as you try to
connect:
>>> s = ssl.wrap_socket(socket.socket(), keyfile="XXX")
>>> s.connect(("svn.python.org", 443))
Traceback (most recent call last):
File
Antoine Pitrou added the comment:
I don't think there's any point in including DJGPP support in the Python tree
(DJGPP targets MS-DOS, which is completely marginal today). Furthermore, the
patch has no chance of applying cleanly on the current source tree. I would
suggest t
Antoine Pitrou added the comment:
Some comments:
- the signature in the doc is not the same as in the code: (fun, args, kwds)
instead of (fun, *args, **kwds)
- I don't understand what _Callable is used for; why not just a tuple?
(or a function if you prefer)
- if you use _Callable, the
Antoine Pitrou added the comment:
This seems to be a pyodbc problem, you should post the issue to them.
When an extension module written in C (pyodbc.so) has an issue, there's nothing
Python can do to prevent it from crashing the whole process, since C is an
insecure lan
Antoine Pitrou added the comment:
The patch shouldn't remove the tests for tostring()/fromstring() (they might be
deprecated, but they are still supported).
--
___
Python tracker
<http://bugs.python.org/i
Antoine Pitrou added the comment:
In dynamic builds, there seem to be lots of messages such as:
ld: 0711-224 WARNING: Duplicate symbol: .PyLong_FromString
ld: 0711-224 WARNING: Duplicate symbol: PyLong_FromString
Are you sure this is normal?
In any case, if you find a way to cleanup
Antoine Pitrou added the comment:
> > - why override __bool__??
>
> I did that for performance.
> Considering that initiate_send() method is called many times, and that
> it is almost always used to send data rather than firing functions I
> wanted to avoid to call isinst
Antoine Pitrou added the comment:
Note that 3.x will give you the expected error message:
>>> s = socket.socket()
>>> wrapped = ssl.wrap_socket(s)
>>> wrapped.recv(1)
Traceback (most recent call last):
File "", line 1, in
File "/home/antoine/p
Antoine Pitrou added the comment:
I've added a "_Py" prefix in r84391, and also made the `shape` argument const.
If numpy people want this to be an official public API, they'll have to
contribute. Thanks.
--
resolution: -> fixed
stage: -> committed/rejec
Antoine Pitrou added the comment:
+1 on the principle. This could help things like pydoc, especially on modern
Web frameworks which do incredibly ugly things (per-thread global variables,
descriptors executing tons of code etc.).
--
nosy: +pitrou
Changes by Antoine Pitrou :
--
nosy: +haypo
___
Python tracker
<http://bugs.python.org/issue9549>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
I'm not sure which commit it is, but test_ssl has started failing on some
buildbots:
==
ERROR: test_errors (test.test_ssl.BasicSocket
Antoine Pitrou added the comment:
Thinking about it, I'm not sure this would be a good idea to do this by
default. There is an ambiguity where it's not obvious if the buffer would
contain the whole data or only the bytes after the current position.
I think perhaps an expli
Antoine Pitrou added the comment:
Actually, it started failing exactly after r84352 (issue #9706).
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/iss
Antoine Pitrou added the comment:
Some buildbots have started failing exactly after this commit:
==
ERROR: test_errors (test.test_ssl.BasicSocketTests
Antoine Pitrou added the comment:
Patch committed in r84394 (py3k) and r84396 (3.1). Thank you Stefan!
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
versions: -Python 2.7
___
Python track
Antoine Pitrou added the comment:
> I would consider reviewing and possibly apply this change, but I don't
> want to invade anyone's territory.
I don't think there would be any invasion. I think the patch is simple enough,
and seems to p
Antoine Pitrou added the comment:
Done in r84397.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
versions: -Python 3.3
___
Python tracker
<http://bugs.python.o
New submission from Antoine Pitrou :
The Misc/cheatsheet file is totally outdated (the title “Python 2.3 Quick
Reference” already gives you a hint).
It is also not clear if it is meant for plain text viewing, or should be
formatted using an external program...
--
assignee: d...@python
Changes by Antoine Pitrou :
--
assignee: -> jnoller
nosy: +jnoller
stage: -> needs patch
type: -> behavior
versions: +Python 3.1, Python 3.2 -Python 2.6
___
Python tracker
<http://bugs.python.o
Antoine Pitrou added the comment:
It is certainly still a problem with 3.x, but I don't find a way to exhibit it
here.
--
nosy: +pitrou
versions: +Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/i
Antoine Pitrou added the comment:
The patches were committed in r84403. Thank you very much!
--
resolution: -> fixed
stage: unit test needed -> committed/rejected
status: open -> closed
versions: -Python 3.1
___
Python track
Antoine Pitrou added the comment:
Nice catch, thank you. I've fixed it in r84408 (py3k), r84410 (3.1) and r84411
(2.7).
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/i
Changes by Antoine Pitrou :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: +Python 3.2
___
Python tracker
<http://bugs.python.o
Antoine Pitrou added the comment:
Do you think you could provide a patch?
--
nosy: +orsenthil, pitrou
stage: -> needs patch
versions: -Python 3.3
___
Python tracker
<http://bugs.python.org/iss
Antoine Pitrou added the comment:
New features can only go in 3.2. From a quick look, the patch looks ok.
--
nosy: +pitrou
versions: -Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/issue1673
New submission from Antoine Pitrou :
Similar to assertRaises and assertRaisesRegexp, unittest should provide
assertWarns and assertWarnsRegexp, to check that a given callable (or piece of
code) triggers a particular warning.
Currently, you have to do that manually using a mixture of
Antoine Pitrou added the comment:
The __warningregistry__ stuff looks horrible.
--
___
Python tracker
<http://bugs.python.org/issue9754>
___
___
Python-bug
Antoine Pitrou added the comment:
Here is a patch. The approach is different from support.check_warnings(), and
tries to mimic assertRaises* instead.
--
keywords: +patch
Added file: http://bugs.python.org/file18727/assertwarns.patch
___
Python
Antoine Pitrou added the comment:
There was some dead code in the patch.
--
Added file: http://bugs.python.org/file18728/assertwarns.patch
___
Python tracker
<http://bugs.python.org/issue9
Changes by Antoine Pitrou :
Removed file: http://bugs.python.org/file18727/assertwarns.patch
___
Python tracker
<http://bugs.python.org/issue9754>
___
___
Python-bug
New submission from Antoine Pitrou :
This adds the context manager protocol to memoryview objects, as proposed on
python-dev. Once the `with` block has finished, the underlying buffer is
released and any operation on the memoryview raises a ValueError.
--
components: Interpreter Core
Antoine Pitrou added the comment:
+#undef HAVE_USABLE_CHAR_T
Isn't it HAVE_USABLE_WCHAR_T?
+struct PY_UNICODE_STRUCT;
+typedef struct PY_UNICODE_STRUCT Py_UNICODE_STRUCT;
+#define Py_UNICODE Py_UNICODE_STRUCT
Why not simply `typedef struct PY_UNICODE_STRUCT Py_UNICODE`?
Antoine Pitrou added the comment:
> Patch looks good. However tests do not pass with -Werror (while test_warnings
> and others pass).
>
>
> Is there a way to catch multiple warnings on a single logical line?
I thought we could beef up the API with additional arguments.
That
Antoine Pitrou added the comment:
> Why not accepting a tuple of warnings?
It already does (and there's a test!).
> That doesn't make sense for assertWarnsRegexp of course.
True.
--
___
Python tracker
<http://bugs.p
Antoine Pitrou added the comment:
Here is a patch implementing getbuffer(), together with tests.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file18731/bytesiobuf2.patch
___
Python tracker
&l
Antoine Pitrou added the comment:
Guido expressed skepticism at the idea:
http://mail.python.org/pipermail/python-dev/2010-September/103442.html
--
___
Python tracker
<http://bugs.python.org/issue9
Antoine Pitrou added the comment:
There was an unused "weakreflist" member.
--
Added file: http://bugs.python.org/file18732/bytesiobuf2.patch
___
Python tracker
<http://bugs.python.
Changes by Antoine Pitrou :
Removed file: http://bugs.python.org/file18731/bytesiobuf2.patch
___
Python tracker
<http://bugs.python.org/issue5506>
___
___
Python-bug
Changes by Antoine Pitrou :
--
components: +IO
nosy: +amaury.forgeotdarc, benjamin.peterson
___
Python tracker
<http://bugs.python.org/issue5506>
___
___
Pytho
Antoine Pitrou added the comment:
Cleanup done in r84464 (py3k), r84465 (3.1).
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: +Python 3.1, Python 3.2 -Python 3.0
___
Python tracker
<http://bug
New submission from Antoine Pitrou :
After a `make distclean` and a whole recompile I still get these:
building 'crypt' extension
gcc -pthread -fPIC -g -O0 -Wall -Wstrict-prototypes -I. -I./Include
-I/usr/local/include -IInclude -I/home/antoine/py3k/debug -c
/home/antoine/py3k/deb
Antoine Pitrou added the comment:
Here is a patch.
--
keywords: +patch
Added file: http://bugs.python.org/file18733/unsupported.patch
___
Python tracker
<http://bugs.python.org/issue9
Antoine Pitrou added the comment:
The normal build lines for the crypt and nis modules contain additional library
linkage ("normal", that is before your commit :-)):
gcc -pthread -shared
build/temp.linux-x86_64-3.2/home/antoine/py3k/__svn__/Modules/cryptmodule.o
-L/home/antoine/py
New submission from Antoine Pitrou :
The warnings module has both "onceregistry" and "once_registry", while
_warnings only has the latter. There's probably a typo.
--
assignee: brett.cannon
components: Library (Lib)
messages: 115505
nosy: brett.cannon, pitrou
Antoine Pitrou added the comment:
> That means the _warnings versions should simply be renamed to
> "_onceregistry" and "_defaultaction" instead of their current names.
> Work for you?
Certainly.
--
___
Python tra
Antoine Pitrou added the comment:
> Generally: +1 on making sure examples in the docs are up to date. If
> someone wants to do the tedious work of making sure that a "make
> doctest" succeeds, I'm all for it, it may involve adding a few (in
> HTML output invisible)
Antoine Pitrou added the comment:
See #9293, where there's a patch.
--
resolution: -> duplicate
status: open -> closed
superseder: -> Unsupported IO operations should raise UnsupportedOperation
___
Python tracker
<http://bugs.pyt
Changes by Antoine Pitrou :
--
nosy: +skrah, stutzbach
___
Python tracker
<http://bugs.python.org/issue9293>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Antoine Pitrou :
--
nosy: +brian.curtin, tim.golden
versions: -Python 2.6
___
Python tracker
<http://bugs.python.org/issue2122>
___
___
Python-bug
Changes by Antoine Pitrou :
--
components: +Interpreter Core -Extension Modules
nosy: +gregory.p.smith
stage: -> patch review
versions: +Python 3.1, Python 3.2 -Python 2.5, Python 2.6
___
Python tracker
<http://bugs.python.org/iss
Antoine Pitrou added the comment:
Should this be checked in?
--
nosy: +pitrou
versions: +Python 3.1, Python 3.2
___
Python tracker
<http://bugs.python.org/issue8
Changes by Antoine Pitrou :
--
assignee: josiahcarlson -> giampaolo.rodola
stage: -> patch review
versions: -Python 3.0, Python 3.1
___
Python tracker
<http://bugs.python.org/
Changes by Antoine Pitrou :
--
assignee: -> giampaolo.rodola
___
Python tracker
<http://bugs.python.org/issue8594>
___
___
Python-bugs-list mailing list
Un
Changes by Antoine Pitrou :
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue8597>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Antoine Pitrou :
--
stage: unit test needed -> patch review
versions: -Python 2.6
___
Python tracker
<http://bugs.python.org/issue8401>
___
___
Py
Changes by Antoine Pitrou :
--
nosy: +brian.curtin, tim.golden
stage: -> patch review
versions: +Python 3.2 -Python 2.7
___
Python tracker
<http://bugs.python.org/iss
Changes by Antoine Pitrou :
--
components: +Extension Modules, Windows -Interpreter Core
nosy: +brian.curtin, tim.golden
stage: -> patch review
versions: +Python 3.2 -Python 2.7
___
Python tracker
<http://bugs.python.org/iss
Changes by Antoine Pitrou :
--
nosy: +belopolsky
___
Python tracker
<http://bugs.python.org/issue4379>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
This has been integrated long ago.
--
nosy: +pitrou
resolution: -> out of date
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Antoine Pitrou added the comment:
Do you think there is a simple, generic way to test for this (see
Lib/test/test_ioctl.py)?
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue9
Antoine Pitrou added the comment:
Oh, I just noticed that many other modules weren't built either: _ssl,
_hashlib, _sqlite, _tkinter. Apparently setup.py cannot find the relevant
"bits" anymore.
Bisecting shows that this happened with the PEP 3149 commit.
--
nosy
Antoine Pitrou added the comment:
I've committed a workaround in r84488. Feel free to improve.
--
___
Python tracker
<http://bugs.python.org/issue9762>
___
___
Changes by Antoine Pitrou :
--
nosy: -pitrou
___
Python tracker
<http://bugs.python.org/issue9762>
___
___
Python-bugs-list mailing list
Unsubscribe:
Antoine Pitrou added the comment:
Committed in r84489 (3.x), r84490 (3.1) and r84491 (2.7). Thank you!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: -Python 2.6
___
Python track
Antoine Pitrou added the comment:
I've committed modified patches for 3.x, 3.1 and 2.7. Thanks again George.
--
assignee: ronaldoussoren -> nobody
nosy: +nobody
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
versi
1401 - 1500 of 16792 matches
Mail list logo
