[issue36983] typing.__all__ has drifted from actual contents

2019-05-29 Thread Anthony Sottile
Change by Anthony Sottile : -- pull_requests: +13554 pull_request: https://github.com/python/cpython/pull/13663 ___ Python tracker <https://bugs.python.org/issue36

[issue37089] `import Lib.os` works on windows (but shouldn't)

2019-05-29 Thread Anthony Sottile
New submission from Anthony Sottile : Additionally, virtualenvs have the root of their directory on `sys.path` -- this is unlike posix behaviour For example: $ python Python 3.7.3 (v3.7.3:ef4ec6ed12, Mar 25 2019, 22:22:05) [MSC v.1916 64 bit (AMD6 4)] on win32 Type "help",

[issue37089] `import Lib.os` works on windows (but shouldn't)

2019-05-29 Thread Anthony Sottile
Anthony Sottile added the comment: sys.prefix isn't on sys.path on other platforms -- why is it on windows? -- ___ Python tracker <https://bugs.python.org/is

[issue37089] `import Lib.os` works on windows (but shouldn't)

2019-05-29 Thread Anthony Sottile
Anthony Sottile added the comment: If I'm reading this correctly this is the relevant line for python3: https://github.com/python/cpython/blob/29cb21ddb92413931e473eb799a02e2d8cdf4a45/PC/getpathp.c#L1068 it was added in 4d0d471a8031de90a2b1ce99c4ac4780e60b3bc9 python2 seems to do the

[issue5028] tokenize.generate_tokens doesn't always return logical line

2019-05-30 Thread Anthony Sottile
Change by Anthony Sottile : -- pull_requests: +13574 pull_request: https://github.com/python/cpython/pull/13686 ___ Python tracker <https://bugs.python.org/issue5

[issue37162] new importlib dependencies csv, email and zipfile

2019-06-05 Thread Anthony Sottile
Anthony Sottile added the comment: at least for debian, the motivation is to provide a `pythonX.X-minimal` and a `pythonX.X` package -- the former ~mostly just contains the interpreter and the latter includes the stdlib (I'm interested as well, hit this packaging 3.8 for deads

[issue36853] inconsistencies in docs builds (Sphinx 2)

2019-06-09 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +13799 stage: -> patch review pull_request: https://github.com/python/cpython/pull/13579 ___ Python tracker <https://bugs.python.org/issu

[issue36853] inconsistencies in docs builds (Sphinx 2)

2019-06-09 Thread Anthony Sottile
Change by Anthony Sottile : -- nosy: +Anthony Sottile ___ Python tracker <https://bugs.python.org/issue36853> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37219] empty set difference does not check types of values

2019-06-10 Thread Anthony Sottile
New submission from Anthony Sottile : This is a regression from python2.x behaviour: $ python2 Python 2.7.15rc1 (default, Nov 12 2018, 14:31:15) [GCC 7.3.0] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>>

[issue23014] Don't have importlib.abc.Loader.create_module() be optional

2019-06-25 Thread Anthony Sottile
Anthony Sottile added the comment: Hi! just stumbled on this as I was updating pytest's import hook. I notice in PEP 451 this is still marked as optional (then again, I don't know whether PEPs are supposed to be living standards or not, or if there was a PEP which supersedes tha

[issue23014] Don't have importlib.abc.Loader.create_module() be optional

2019-06-26 Thread Anthony Sottile
Anthony Sottile added the comment: Where can I find up to date best practices / docs for the import machinery? I couldn't find a mention of this in docs.python.org -- ___ Python tracker <https://bugs.python.org/is

[issue23014] Don't have importlib.abc.Loader.create_module() be optional

2019-06-26 Thread Anthony Sottile
Anthony Sottile added the comment: Mostly looking for something that says how `create_module` should / shouldn't be implemented (and why `return None` is necessary) -- ___ Python tracker <https://bugs.python.org/is

[issue23014] Don't have importlib.abc.Loader.create_module() be optional

2019-06-26 Thread Anthony Sottile
Anthony Sottile added the comment: yeah I guess I'm just curious why this bug (seemingly intentionally) made the implementation diverge from PEP 451 and require an empty `create_module` (and where I would have found that except by searching bugs.python.org) Everyone I've shown t

[issue37433] syntax error in f-string in multiline string produces ~40k spaces of output

2019-06-27 Thread Anthony Sottile
New submission from Anthony Sottile : For instance this file: foo = f"""{} foo""" $ python3.8 --version --version Python 3.8.0b1 (default, Jun 6 2019, 03:44:52) [GCC 7.4.0] $ python3.8 t.py | wc -c File "t.py", line 1 <>

[issue37433] syntax error in f-string in multiline string produces ~40k spaces of output

2019-06-27 Thread Anthony Sottile
Anthony Sottile added the comment: I can also trigger this with: ``` 1+ """\q """ ``` And `python -Werror` so it seems not necessarily related to fstrings -- ___ Python tracker <h

[issue37433] syntax error in f-string in multiline string produces ~40k spaces of output

2019-06-27 Thread Anthony Sottile
Anthony Sottile added the comment: Debugging further, there's a token with a `multi_line_start` pointing at uninitialized memory -- let's see if I can't track down where that gets set and fix it :) -- ___ Python tracker <https

[issue37433] syntax error in f-string in multiline string produces ~40k spaces of output

2019-06-27 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +14250 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14433 ___ Python tracker <https://bugs.python.org/issu

[issue23014] Don't have importlib.abc.Loader.create_module() be optional

2019-06-27 Thread Anthony Sottile
Anthony Sottile added the comment: I suspect it would be closed since it's essentially just a revert of this issue :S -- ___ Python tracker <https://bugs.python.org/is

[issue37433] syntax error in multiline f-string produces ~40k spaces output

2019-06-28 Thread Anthony Sottile
Anthony Sottile added the comment: just an f-string doesn't trigger this, there needs to be tokens before it -- ___ Python tracker <https://bugs.python.org/is

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2019-07-03 Thread Anthony Sottile
Anthony Sottile added the comment: This has regressed again -- I'll make another patch -- ___ Python tracker <https://bugs.python.org/issue35605> ___ ___

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2019-07-03 Thread Anthony Sottile
Change by Anthony Sottile : -- pull_requests: +14395 pull_request: https://github.com/python/cpython/pull/14576 ___ Python tracker <https://bugs.python.org/issue35

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2019-07-03 Thread Anthony Sottile
Anthony Sottile added the comment: yes, as was the original PR -- ___ Python tracker <https://bugs.python.org/issue35605> ___ ___ Python-bugs-list mailin

[issue37616] [3.10 prep] zip path incorrect

2019-07-17 Thread Anthony Sottile
New submission from Anthony Sottile : In an effort to try and fix some of the ecosystem before python3.10 (or 4.0) is a thing, I figured I'd set up a build where the version is bumped and see what's broken. If you're interested in reproducing my findings, I've inc

[issue37617] [3.10 prep] site.py uses `sys.version[:3]`

2019-07-17 Thread Anthony Sottile
New submission from Anthony Sottile : In an effort to try and fix some of the ecosystem before python3.10 (or 4.0) is a thing, I figured I'd set up a build where the version is bumped and see what's broken. If you're interested in reproducing my findings, I've inc

[issue37617] [3.10 prep] site.py uses `sys.version[:3]`

2019-07-17 Thread Anthony Sottile
Anthony Sottile added the comment: disregard, this appears to be due to debian's patching -- stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.

[issue37636] Deprecate slicing and ordering operations on sys.version

2019-07-20 Thread Anthony Sottile
Change by Anthony Sottile : -- nosy: +Anthony Sottile ___ Python tracker <https://bugs.python.org/issue37636> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37695] Incorrect error message for `unget_wch(bytes_object)`

2019-07-27 Thread Anthony Sottile
New submission from Anthony Sottile : For example: curses.unget_wch(b'x') TypeError: expect bytes or str of length 1, or int, got bytes -- components: Extension Modules messages: 348570 nosy: Anthony Sottile priority: normal severity: normal status: open title: Incor

[issue37695] Incorrect error message for `unget_wch(bytes_object)`

2019-07-27 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +14754 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14986 ___ Python tracker <https://bugs.python.org/issu

[issue37433] syntax error in multiline f-string produces ~40k spaces output

2019-07-29 Thread Anthony Sottile
Anthony Sottile added the comment: sure! the only other case I could come up with involves multi-line strings and invalid escape sequences + Werror let me see if I can fold that in as well -- ___ Python tracker <https://bugs.python.

[issue37433] syntax error in multiline f-string produces ~40k spaces output

2019-07-29 Thread Anthony Sottile
Change by Anthony Sottile : -- pull_requests: +14769 pull_request: https://github.com/python/cpython/pull/15003 ___ Python tracker <https://bugs.python.org/issue37

[issue37433] syntax error in multiline f-string produces ~40k spaces output

2019-08-03 Thread Anthony Sottile
Anthony Sottile added the comment: seems unrelated and does the same on older versions of python: ``` $ python3.5 t.py File "t.py", line 4 ^ SyntaxError: EOF while scanning triple-quoted string literal ``` I'd suggest a new issue or f

[issue37810] ndiff reports incorrect location when diff strings contain tabs

2019-08-10 Thread Anthony Sottile
New submission from Anthony Sottile : Here's an example from difflib import ndiff def main(): x = '\tx\t=\ty\n\t \t \t^' y = '\tx\t=\ty\n\t \t \t^\n' print('\n'.join( line.rstrip('\n') for line in ndiff(x.splitlines(Tr

[issue37810] ndiff reports incorrect location when diff strings contain tabs

2019-08-10 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +14930 stage: -> patch review pull_request: https://github.com/python/cpython/pull/15201 ___ Python tracker <https://bugs.python.org/issu

[issue37810] ndiff reports incorrect location when diff strings contain tabs

2019-08-11 Thread Anthony Sottile
Anthony Sottile added the comment: That's actually a good point, I don't think this should land in python3.7 since it changes outuput -- I'm removing that from the versions (though the bug does affect every version I have access to) -- version

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

2017-07-09 Thread Anthony Sottile
Anthony Sottile added the comment: pypy seems to have this right (though I don't know enough about their internals to know if cpython can benefit from their patch) $ venvpypy/bin/pythonPython 2.7.10 (3260adbeba4a, Apr 19 2016, 17:42:20) [PyPy 5.1.0 with GCC 4.8.4] on linux2 Type

[issue26510] [argparse] Add required argument to add_subparsers

2017-08-08 Thread Anthony Sottile
Changes by Anthony Sottile : -- pull_requests: +3061 ___ Python tracker <http://bugs.python.org/issue26510> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31204] Support __fspath__ in shlex.quote

2017-08-14 Thread Anthony Sottile
New submission from Anthony Sottile: Given shlex.quote often is used closely with calls in `subprocess`, should it also support quoting __fspath__ objects? I'll write up a quick patch for this -- components: Library (Lib) messages: 300270 nosy: Anthony Sottile priority: n

[issue31204] Support __fspath__ in shlex.quote

2017-08-14 Thread Anthony Sottile
Anthony Sottile added the comment: Ah oops, I'm incorrect here, the __fspath__ object I was dealing with supported __str__ and that's how subprocess was converting it -- not via __fspath__. -- stage: -> resolved status: open -> closed __

[issue26510] [argparse] Add required argument to add_subparsers

2017-08-14 Thread Anthony Sottile
Anthony Sottile added the comment: I've added a patch for this https://github.com/python/cpython/pull/3027 Would love to get a review so it could be included -- nosy: +Anthony Sottile ___ Python tracker <http://bugs.python.org/is

[issue9253] argparse: optional subparsers

2017-08-14 Thread Anthony Sottile
Anthony Sottile added the comment: I've attempted to address some of the backward/forward compatibility issue with subparsers becoming optional by default (vs required by default in python2) with this pull request: https://github.com/python/cpython/pull/3027 (would love to get a revi

[issue9253] argparse: optional subparsers

2017-09-15 Thread Anthony Sottile
Anthony Sottile added the comment: My patch mainly addresses the regression pointed out by mike bayer (zzzeek)'s comment. -- ___ Python tracker <https://bugs.python.org/i

[issue29298] argparse fails with required subparsers, un-named dest, and empty argv

2017-09-20 Thread Anthony Sottile
Changes by Anthony Sottile : -- keywords: +patch pull_requests: +3669 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue29298> ___ ___ Py

[issue31550] Inconsistent error message for TypeError with subscripting

2017-09-21 Thread Anthony Sottile
New submission from Anthony Sottile: There's a bit of history I don't understand and couldn't find the appropriate trail for. The original error message from the 2.6 era: $ python2.6 -c 0[0] Traceback (most recent call last): File "", line 1, in TypeError: '

[issue31550] Inconsistent error message for TypeError with subscripting

2017-09-21 Thread Anthony Sottile
Changes by Anthony Sottile : -- keywords: +patch pull_requests: +3679 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue31550> ___ ___ Py

[issue31550] Inconsistent error message for TypeError with subscripting

2017-09-22 Thread Anthony Sottile
Anthony Sottile added the comment: All I'm really looking for is consistency -- should the change to 2.7 be reverted instead? -- ___ Python tracker <https://bugs.python.org/is

[issue35311] exception unpickling error causes `multiprocessing.Pool` to hang forever

2018-11-25 Thread Anthony Sottile
New submission from Anthony Sottile : ``` import multiprocessing class E(Exception): def __init__(self, a1, a2): Exception.__init__(self, '{}{}'.format(a1, a2)) def f(_): raise E(1, 2) multiprocessing.Pool(1).map(f, (1,)) ``` Running this causes a hang: ``` $ py

[issue35311] exception unpickling error causes `multiprocessing.Pool` to hang forever

2018-11-25 Thread Anthony Sottile
Anthony Sottile added the comment: `concurrent.futures` is affected as well: ``` import concurrent.futures class E(Exception): def __init__(self, a1, a2): Exception.__init__(self, '{}{}'.format(a1, a2)) def f(_): raise E(1, 2) with concurrent.futures.ProcessPool

[issue35312] lib2to3.pgen2.parser.ParseError is not roundtrip pickleable

2018-11-25 Thread Anthony Sottile
New submission from Anthony Sottile : related to https://bugs.python.org/issue35311 encountered here: https://gitlab.com/pycqa/flake8/issues/473 minimal reproduction: class TestPickleableException(unittest.TestCase): def test_ParseError(self): err = ParseError('msg', 2

[issue35312] lib2to3.pgen2.parse.ParseError is not roundtrip pickleable

2018-11-25 Thread Anthony Sottile
Change by Anthony Sottile : -- title: lib2to3.pgen2.parser.ParseError is not roundtrip pickleable -> lib2to3.pgen2.parse.ParseError is not roundtrip pickleable ___ Python tracker <https://bugs.python.org/issu

[issue35312] lib2to3.pgen2.parse.ParseError is not roundtrip pickleable

2018-11-25 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +9960 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35312> ___ ___ Py

[issue35328] Set a environment variable for venv prompt

2018-11-27 Thread Anthony Sottile
Anthony Sottile added the comment: The current prompt works fine for me on zsh -- what's the bug here? zsh $ virtualenv venv --prompt '(wat)' Using real prefix '/usr/local/Cellar/python/3.7.0/Frameworks/Python.framework/Versions/3.7' New python executable in /priva

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

2018-12-10 Thread Anthony Sottile
Change by Anthony Sottile : -- pull_requests: +10317 ___ Python tracker <https://bugs.python.org/issue26704> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

2018-12-10 Thread Anthony Sottile
Anthony Sottile added the comment: I've opened a PR with the test included: https://github.com/python/cpython/pull/11085 -- ___ Python tracker <https://bugs.python.org/is

[issue26704] unittest.mock.patch: Double patching instance method: AttributeError: Mock object has no attribute '__name__'

2018-12-10 Thread Anthony Sottile
Anthony Sottile added the comment: to be honest, I don't recall exactly given it's been 2 and a half years since the original report with no activity. if I recall correctly, this was encountered while upgrading the `mock` backport in yelp's monolithic repository. I want to

[issue35507] multiprocessing: seg fault when creating RawArray from numpy ctypes

2018-12-16 Thread Anthony Sottile
Anthony Sottile added the comment: This appears to be a bug with numpy, I've made a PR for them: https://github.com/numpy/numpy/pull/12566 -- nosy: +Anthony Sottile ___ Python tracker <https://bugs.python.org/is

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Anthony Sottile
New submission from Anthony Sottile : Noticed this while packaging 3.6.8 for deadsnakes (ubuntu ppa) This patch: https://github.com/python/cpython/pull/11251 Requires a version of sphinx where `sphinx.util.logging.getLogger` is available. It appears that the first version which that was

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Anthony Sottile
Anthony Sottile added the comment: oops, pressed the button too quickly, meant to mention that sphinx 1.6 was released 2017-05 -- ___ Python tracker <https://bugs.python.org/issue35

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Anthony Sottile
Anthony Sottile added the comment: If I add a patch which is essentially: try: # sphinx>=1.6 from sphinx.util.logging import getLogger except ImportError: # sphinx<1.6 from logging import getLogger will that be fine? and should I open that against 3.7 to be backported o

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-28 Thread Anthony Sottile
Anthony Sottile added the comment: I assume that means I should only target 3.6 -- does the patch look like the right approach? I can make a PR -- ___ Python tracker <https://bugs.python.org/issue35

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-30 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch, patch pull_requests: +10704, 10705 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-30 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +10704 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35605> ___ _

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2018-12-30 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch, patch, patch pull_requests: +10704, 10705, 10706 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35629] hang and/or leaked processes with multiprocessing.Pool(...).imap(...)

2018-12-31 Thread Anthony Sottile
New submission from Anthony Sottile : This simple program causes a hang / leaked processes (easiest to run in an interactive shell): import multiprocessing tuple(multiprocessing.Pool(4).imap(print, (1, 2, 3))) $ python3.6 Python 3.6.7 (default, Oct 22 2018, 11:32:17) [GCC 8.2.0] on linux

[issue35650] cygwin treats X and X.exe as the same file

2019-01-03 Thread Anthony Sottile
New submission from Anthony Sottile : >>> with open('f.exe', 'w') as f: ... f.write('hi') ... >>> with open('f') as f: ... print(f.read()) ... hi `os.path.exists(...)` and others treat them as the same file as well. It seems

[issue35650] cygwin treats X and X.exe as the same file

2019-01-03 Thread Anthony Sottile
Anthony Sottile added the comment: ah yes, I should include more version information IEUser@IE11WIN7 ~ $ python --version Python 2.7.14 IEUser@IE11WIN7 ~ $ python3 --version --version Python 3.6.4 (default, Jan 7 2018, 17:45:56) [GCC 6.4.0] IEUser@IE11WIN7 ~ $ uname -a CYGWIN_NT-6.1

[issue35650] cygwin treats X and X.exe as the same file

2019-01-03 Thread Anthony Sottile
Anthony Sottile added the comment: hmmm probably nothing in that case -- didn't realize this also happened in the cygwin shell. insanity. feel free to close! thanks! -- ___ Python tracker <https://bugs.python.org/is

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2019-01-03 Thread Anthony Sottile
Anthony Sottile added the comment: I also had to update the patch for sphinx.util.status_iterator which was also introduced in sphinx 1.6 -- ___ Python tracker <https://bugs.python.org/issue35

[issue35312] lib2to3.pgen2.parse.ParseError is not roundtrip pickleable

2019-01-03 Thread Anthony Sottile
Anthony Sottile added the comment: Looks like this was merged and can be marked as resolved -- should this be backported to 3.7? -- ___ Python tracker <https://bugs.python.org/issue35

[issue35629] hang and/or leaked processes with multiprocessing.Pool(...).imap(...)

2019-01-04 Thread Anthony Sottile
Anthony Sottile added the comment: If you see the bottom of my issue, I've suggested (nearly) the same thing -- though I require python2.x compatibility so I'm using `contextlib.closing` -- ___ Python tracker <https://bugs.python.o

[issue16806] col_offset is -1 and lineno is wrong for multiline string expressions

2019-01-12 Thread Anthony Sottile
Anthony Sottile added the comment: I agree -- probably safer to not backport to 3.7 in case someone is relying on this behaviour. -- ___ Python tracker <https://bugs.python.org/issue16

[issue35733] isinstance(ast.Constant(value=True), ast.Num) should be False

2019-01-13 Thread Anthony Sottile
New submission from Anthony Sottile : Noticing this in pyflakes https://github.com/PyCQA/pyflakes/pull/408 -- messages: 333579 nosy: Anthony Sottile priority: normal severity: normal status: open title: isinstance(ast.Constant(value=True), ast.Num) should be False versions: Python 3.8

[issue35733] isinstance(ast.Constant(value=True), ast.Num) should be False

2019-01-13 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch, patch pull_requests: +11165, 11166 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35733] isinstance(ast.Constant(value=True), ast.Num) should be False

2019-01-13 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch, patch, patch pull_requests: +11165, 11166, 11167 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35733] isinstance(ast.Constant(value=True), ast.Num) should be False

2019-01-13 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +11165 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35733> ___ _

[issue35507] multiprocessing: seg fault when creating RawArray from numpy ctypes

2019-01-19 Thread Anthony Sottile
Anthony Sottile added the comment: yes, please do -- ___ Python tracker <https://bugs.python.org/issue35507> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35766] Merge typed_ast back into CPython

2019-01-19 Thread Anthony Sottile
Change by Anthony Sottile : -- nosy: +Anthony Sottile ___ Python tracker <https://bugs.python.org/issue35766> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue35766] Merge typed_ast back into CPython

2019-01-19 Thread Anthony Sottile
Anthony Sottile added the comment: Seems also related to https://bugs.python.org/issue24119 with python2 / python3.5 (hopefully) rapidly falling off in usage I would assume the specialized treatment of `# type: ...` comments would become less and less necessary Though I guess there's

[issue35785] argparse crashes in gettext when processing missing arguments

2019-01-19 Thread Anthony Sottile
Anthony Sottile added the comment: Can you provide a reproducer? I'm having difficulty reproducing with this script: import argparse p = argparse.ArgumentParser() p.add_argument('--foo', nargs=None) args = p.parse_args() $ python3.7 --version Python 3.7.2 $ python3.7 t

[issue35766] Merge typed_ast back into CPython

2019-01-19 Thread Anthony Sottile
Anthony Sottile added the comment: > You’d be surprised how tenacious old versions are. heh that's true, at my last job we finally got rid of python2.6 in 2016 :'( anyway -- I don't mean to discourage this, definitely seems valuable to the m

[issue35802] os.stat / os.lstat always present, but code checks hastattr(os, 'stat') / hasattr(os, 'lstat')

2019-01-21 Thread Anthony Sottile
New submission from Anthony Sottile : Unless I'm reading incorrectly: https://github.com/python/cpython/blob/7a2368063f25746d4008a74aca0dc0b82f86ff7b/Modules/clinic/posixmodule.c.h#L30-L31 https://github.com/python/cpython/blob/7a2368063f25746d4008a74aca0dc0b82f86ff7b/Modules/c

[issue35802] os.stat / os.lstat always present, but code checks hastattr(os, 'stat') / hasattr(os, 'lstat')

2019-01-21 Thread Anthony Sottile
Anthony Sottile added the comment: looks true for os.chmod as well: https://github.com/python/cpython/blob/7a2368063f25746d4008a74aca0dc0b82f86ff7b/Modules/clinic/posixmodule.c.h#L327-L328 -- ___ Python tracker <https://bugs.python.org/issue35

[issue35802] os.stat / os.lstat always present, but code checks hastattr(os, 'stat') / hasattr(os, 'lstat')

2019-01-21 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch, patch pull_requests: +11422, 11423 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35802] os.stat / os.lstat always present, but code checks hastattr(os, 'stat') / hasattr(os, 'lstat')

2019-01-21 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +11422 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35802> ___ _

[issue35803] Test and document that `dir=...` in tempfile may be PathLike

2019-01-21 Thread Anthony Sottile
New submission from Anthony Sottile : This appears to be true in 3.6+ -- I'd like to add a test and documentation ensuring that going forward. Related: https://github.com/python/typeshed/issues/2749 -- assignee: docs@python components: Documentation, Tests messages: 334188

[issue35803] Test and document that `dir=...` in tempfile may be PathLike

2019-01-21 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +11424 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35803> ___ _

[issue35803] Test and document that `dir=...` in tempfile may be PathLike

2019-01-21 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch, patch, patch pull_requests: +11424, 11425, 11426 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35803] Test and document that `dir=...` in tempfile may be PathLike

2019-01-21 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch, patch pull_requests: +11424, 11425 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35802] os.stat / os.lstat always present, but code checks hastattr(os, 'stat') / hasattr(os, 'lstat')

2019-01-22 Thread Anthony Sottile
Anthony Sottile added the comment: yep! did my due diligence there, you can check my work on https://github.com/python/cpython/pull/11643 all platforms have these functions since `posixmodule.c` is always compiled and the functions in question are not guarded by preprocessor directives in

[issue35843] importlib.util docs for namespace packages innaccurate

2019-01-28 Thread Anthony Sottile
New submission from Anthony Sottile : For instance: # `a` is an empty directory, a PEP 420 namespace package >>> import importlib.util >>> importlib.util.find_spec('a') ModuleSpec(name='a', loader=None, origin='namespace', submodule_search

[issue35843] importlib.util docs for namespace packages innaccurate

2019-01-28 Thread Anthony Sottile
Anthony Sottile added the comment: Hmmm, it appears this was changed in python3.7 to have `None` for the origin instead of `'namespace'` -- however the `submodule_search_locations` is still not indexable: >>> importlib.util.find_spec('a') Mod

[issue35843] importlib.util docs for namespace packages innaccurate

2019-01-28 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch, patch, patch pull_requests: +11529, 11530, 11531 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue35843] importlib.util docs for namespace packages innaccurate

2019-01-28 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +11529 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue35843> ___ _

[issue35843] importlib.util docs for namespace packages innaccurate

2019-01-28 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch, patch pull_requests: +11529, 11530 stage: -> patch review ___ Python tracker <https://bugs.python.org/issu

[issue34652] never enable lchmod on Linux

2019-02-10 Thread Anthony Sottile
Anthony Sottile added the comment: I believe this also closes https://bugs.python.org/issue31940 and https://bugs.python.org/issue28627 -- nosy: +Anthony Sottile ___ Python tracker <https://bugs.python.org/issue34

[issue36007] python3.8 a1 - docs build requires sphinx 1.7 but uses a 1.8 feature

2019-02-15 Thread Anthony Sottile
New submission from Anthony Sottile : doctest `:skipif:` was added in https://github.com/sphinx-doc/sphinx/issues/5273 Used here: https://github.com/python/cpython/blame/36433221f06d649dbd7e13f5fec948be8ffb90af/Doc/library/turtle.rst#L252-L253 Sphinx minimum version configured here: https

[issue36007] python3.8 a1 - docs build requires sphinx 1.7 but uses a 1.8 feature

2019-02-15 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +11917 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue36007> ___ _

[issue30338] LC_ALL=en_US + io.open() => LookupError: (osx)

2017-05-10 Thread Anthony Sottile
New submission from Anthony Sottile: Originally seen here: https://github.com/Microsoft/vscode/issues/26227 ``` $ LC_ALL=en_US python -c 'import io; io.open("/dev/null")' Traceback (most recent call last): File "", line 1, in LookupError: unknown encoding:

[issue35802] os.stat / os.lstat always present, but code checks hastattr(os, 'stat') / hasattr(os, 'lstat')

2019-02-25 Thread Anthony Sottile
Change by Anthony Sottile : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue35802> ___ ___ Pyth

[issue36130] Pdb(skip=[...]) + module without __name__ => TypeError

2019-02-26 Thread Anthony Sottile
New submission from Anthony Sottile : Here's the simplest example I could come up with -- hit this while debugging pytest (which uses attrs which uses similar code to this to make classes) import pdb; pdb.Pdb(skip=['django.*']).set_trace() eval(compile("1", &

[issue36130] Pdb(skip=[...]) + module without __name__ => TypeError

2019-02-26 Thread Anthony Sottile
Change by Anthony Sottile : -- keywords: +patch pull_requests: +12088 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue36130> ___ _

<    1   2   3   4   5   >