Changes by Alexandre Vassalotti :
--
assignee: -> alexandre.vassalotti
resolution: -> duplicate
stage: patch review -> committed/rejected
status: open -> closed
superseder: -> Implement PEP 3154 (pickle protocol 4)
___
Python
Changes by Alexandre Vassalotti :
--
Removed message: http://bugs.python.org/msg204785
___
Python tracker
<http://bugs.python.org/issue19726>
___
___
Python-bug
Changes by Alexandre Vassalotti :
--
assignee: -> alexandre.vassalotti
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Alexandre Vassalotti added the comment:
I have reviewed the patch in the review tool. Please take a look!
--
___
Python tracker
<http://bugs.python.org/issue19
Changes by Alexandre Vassalotti :
--
assignee: -> docs@python
components: +Documentation -Interpreter Core
keywords: -64bit
nosy: +docs@python
stage: -> needs patch
type: resource usage -> enhancement
versions: +Python 3.4, Python 3.5 -Python 3.2, P
Changes by Alexandre Vassalotti :
Removed file: http://bugs.python.org/file26617/pickle_sizeof-2.7.patch
___
Python tracker
<http://bugs.python.org/issue15513>
___
___
Changes by Alexandre Vassalotti :
Removed file: http://bugs.python.org/file26616/pickle_sizeof-3.2.patch
___
Python tracker
<http://bugs.python.org/issue15513>
___
___
Changes by Alexandre Vassalotti :
Removed file: http://bugs.python.org/file26588/stringio_sizeof-2.7.patch
___
Python tracker
<http://bugs.python.org/issue15490>
___
___
Changes by Alexandre Vassalotti :
Removed file: http://bugs.python.org/file26587/stringio_sizeof-3.2.patch
___
Python tracker
<http://bugs.python.org/issue15490>
___
___
Changes by Alexandre Vassalotti :
Removed file: http://bugs.python.org/file26810/stringio_sizeof-3.3_2.patch
___
Python tracker
<http://bugs.python.org/issue15
Changes by Alexandre Vassalotti :
Removed file: http://bugs.python.org/file26586/stringio_sizeof-3.3.patch
___
Python tracker
<http://bugs.python.org/issue15490>
___
___
Changes by Alexandre Vassalotti :
Removed file: http://bugs.python.org/file26811/stringio_sizeof-3.2_2.patch
___
Python tracker
<http://bugs.python.org/issue15
Changes by Alexandre Vassalotti :
Removed file: http://bugs.python.org/file26812/stringio_sizeof-2.7_2.patch
___
Python tracker
<http://bugs.python.org/issue15
Changes by Alexandre Vassalotti :
Removed file: http://bugs.python.org/file27241/stringio_sizeof-3.2_3.patch
___
Python tracker
<http://bugs.python.org/issue15
Alexandre Vassalotti added the comment:
Looks good to me! Feel free to commit.
--
___
Python tracker
<http://bugs.python.org/issue17897>
___
___
Python-bugs-list m
Changes by Alexandre Vassalotti :
--
assignee: -> alexandre.vassalotti
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Alexandre Vassalotti :
--
priority: low -> normal
stage: needs patch -> patch review
versions: +Python 3.5 -Python 2.7, Python 3.2
___
Python tracker
<http://bugs.python.org/
Changes by Alexandre Vassalotti :
--
priority: normal -> low
versions: +Python 3.5 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue2281>
___
___
Py
Changes by Alexandre Vassalotti :
--
priority: normal -> low
versions: +Python 3.5 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue2281>
___
___
Py
Changes by Alexandre Vassalotti :
--
priority: normal -> low
versions: +Python 3.5 -Python 3.2
___
Python tracker
<http://bugs.python.org/issue2281>
___
___
Py
Alexandre Vassalotti added the comment:
With PEP 393 implemented, there doesn't seem to anything left to be done here.
Closing as fixed.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Changes by Alexandre Vassalotti :
--
assignee: docs@python -> alexandre.vassalotti
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.pytho
Alexandre Vassalotti added the comment:
Would you be okay with removing the static declaration of PyNotImplemented_Type
and PyNone_Type if we prefix their name with an underscore? There isn't any
other way to fix this without making the types linkable.
I might revert the 2.7 change anyw
Alexandre Vassalotti added the comment:
Antoine, are you okay with applying this fix to 2.7? Or should we just mark
this as a won't fix?
--
keywords: +patch
priority: low -> normal
resolution: fixed ->
stage: committed/rejected -> patch review
versions: -Python 3
Alexandre Vassalotti added the comment:
I thought it over. I don't think the fix is appropriate for 2.x, as it seems
closer to being an extra feature than a bug fix.
Thanks Antoine for calling me out on this one.
--
resolution: -> wont fix
stage: patch review -> committ
Alexandre Vassalotti added the comment:
This was fixed in 3.4 with the introduction of method pickling. I don't think
it would be appropriate to backport this to 2.7. Thus, I am closing this as a
won't fix for 2.x.
--
assignee: -> alexandre.vassalotti
resolution: ->
Alexandre Vassalotti added the comment:
I agree that there is a maintenance cost associated with C extension modules.
However, I would certainly be glad if it allowed us to eliminate uses of ctypes
in this module because ctypes is quite unsafe and doesn't work well across
platforms (thou
Alexandre Vassalotti added the comment:
Thank you for the patch!
--
assignee: -> alexandre.vassalotti
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
versions: +Python 3.4 -Python 3.1, Python 3.2
__
Changes by Alexandre Vassalotti :
--
assignee: -> alexandre.vassalotti
priority: normal -> high
stage: -> needs patch
type: -> behavior
versions: +Python 3.4
___
Python tracker
<http://bugs.python
Alexandre Vassalotti added the comment:
Allowing generators to be deepcopied via their code object should be fine.
--
stage: test needed -> needs patch
title: Allow deepcopying and pickling paused generators -> Allow deepcopying
paused generators
versions: +Python 3.5 -Pyth
Changes by Alexandre Vassalotti :
--
nosy: -alexandre.vassalotti
stage: -> needs patch
versions: +Python 3.5 -Python 3.0
___
Python tracker
<http://bugs.python.org/iss
Alexandre Vassalotti added the comment:
We can't fix this without a working test case. Feel free to re-open if you find
one.
--
assignee: docs@python -> alexandre.vassalotti
components: -Documentation
resolution: -> works for me
status: open -> closed
versions: +Pyth
Alexandre Vassalotti added the comment:
I have implemented PEP 3121 module finalization for _pickle in 64c6d52793be.
--
assignee: -> alexandre.vassalotti
nosy: +alexandre.vassalotti
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open
Alexandre Vassalotti added the comment:
I have implemented PEP 3121 module finalization for _pickle in 64c6d52793be. I
don't see the use case for implementing PEP 384 stable ABI, since _pickle is
only distributed with Python.
--
assignee: -> alexandre.vassalo
Alexandre Vassalotti added the comment:
PEP 3154 implemented support for pickling classes taking keyword-only arguments.
The copy module should be updated to use __getnewargs_ex__ when available
through object.__reduce__(4).
--
nosy: +alexandre.vassalotti
superseder: -> Implement
Changes by Alexandre Vassalotti :
--
superseder: Implement PEP 3154 (pickle protocol 4) ->
___
Python tracker
<http://bugs.python.org/issue4727>
___
___
Py
Alexandre Vassalotti added the comment:
Without a reproducible test case, I am afraid there is nothing we can do here.
--
assignee: -> alexandre.vassalotti
components: +Library (Lib) -None
nosy: +alexandre.vassalotti
resolution: -> works for me
stage: -> test needed
sta
Alexandre Vassalotti added the comment:
Look like I isolated the problem. It seems multiprocessing is using cPickle
which cannot be extended with ForkingPickler, unlike the Python version of the
pickle module.
15:09:29 [ ~/pythondev/python2.7 ]$ ./python.exe issue10717.py
Traceback (most
Changes by Alexandre Vassalotti :
--
title: Multiprocessing module Pickling unPickling issues -> Multiprocessing
module cannot call instance methods across processes
___
Python tracker
<http://bugs.python.org/issu
Alexandre Vassalotti added the comment:
Now, pickletools.optimize doesn't do anything on protocol 4. :)
--
assignee: -> alexandre.vassalotti
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Pyth
Alexandre Vassalotti added the comment:
Yeah, let's close this. It is much simpler to just double the frame size target
if the extra reads ever become a performance issue.
--
status: pending -> closed
___
Python tracker
<http://bugs
New submission from Alexandre Vassalotti:
PEP 3154 introduced the MEMOIZE opcode which lowered the overhead of
memoization compared to the PUT opcodes which were previously used.
We should update pickletools.optimize to remove superfluous uses of this new
opcode.
--
components
Alexandre Vassalotti added the comment:
Feel free to commit once you have addressed the remaining comments.
--
assignee: -> doerwalter
___
Python tracker
<http://bugs.python.org/issu
Changes by Alexandre Vassalotti :
--
assignee: -> alexandre.vassalotti
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Changes by Alexandre Vassalotti :
--
nosy: -alexandre.vassalotti
___
Python tracker
<http://bugs.python.org/issue19835>
___
___
Python-bugs-list mailin
Alexandre Vassalotti added the comment:
Well, that can only happen if MEMOIZE and PUT are both used together, which
won't happen with the Pickler classes we support. The easiest thing to do here
is to disable pickletools.optimize on proto
Alexandre Vassalotti added the comment:
MEMOIZE and PUT can be used together. They just need to not step on each other
toes when they write to the memo table. As specified by PEP 3154, the memo
index used by MEMOIZE is the number of elements currently in the memo table.
This obviously means
New submission from Alexandre Vassalotti:
The bigmem tests for pickle are currently failing for protocol 4. The tests are
broken because of an assumption rendered invalid by the frame header. Fixing
the tests caught a legitimate bug in the save_bytes function of cpickle.
--
assignee
Changes by Alexandre Vassalotti :
Added file: http://bugs.python.org/file32982/fix_bigmem_pickle_2.patch
___
Python tracker
<http://bugs.python.org/issue19881>
___
___
Changes by Alexandre Vassalotti :
Added file: http://bugs.python.org/file33001/fix_bigmem_pickle_3.patch
___
Python tracker
<http://bugs.python.org/issue19881>
___
___
Changes by Alexandre Vassalotti :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Alexandre Vassalotti added the comment:
Could you provide a single patch with the implementation and the tests
together? I will try to find some time this week to review this.
--
assignee: docs@python -> alexandre.vassalotti
priority: normal -> high
stage: -> patch review
Alexandre Vassalotti added the comment:
Ah, I almost forgot! I did implement the verification in pickletools.dis() for
MEMOIZE:
http://hg.python.org/cpython/file/2612ea573ff7/Lib/pickletools.py#l2420
--
___
Python tracker
<http://bugs.python.
Alexandre Vassalotti added the comment:
Looks good to me!
--
___
Python tracker
<http://bugs.python.org/issue19900>
___
___
Python-bugs-list mailing list
Unsub
Changes by Alexandre Vassalotti :
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Alexandre Vassalotti :
--
title: Error pickling a dict -> Error pickling objects with mutating
__getstate__
___
Python tracker
<http://bugs.python.org/issu
Changes by Alexandre Vassalotti :
--
nosy: +alexandre.vassalotti
stage: -> patch review
type: -> enhancement
___
Python tracker
<http://bugs.python.org/i
Alexandre Vassalotti added the comment:
I cleaned up the patch. I will submit it tonight if there is no major
objections.
--
Added file: http://bugs.python.org/file33019/pickle_python2_str_as_bytes.diff
___
Python tracker
<http://bugs.python.
Alexandre Vassalotti added the comment:
I fixed up the last few review comments and submitted the patch. Thank you for
the help!
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
___
Python track
Changes by Alexandre Vassalotti :
--
nosy: -alexandre.vassalotti
___
Python tracker
<http://bugs.python.org/issue6673>
___
___
Python-bugs-list mailing list
Unsub
Changes by Alexandre Vassalotti :
--
assignee: -> docs@python
components: +Documentation -Library (Lib)
nosy: +docs@python
stage: -> patch review
versions: +Python 3.4 -Python 2.6, Python 2.7, Python 3.1, Python 3.2, Python
3.3
___
Python t
Changes by Alexandre Vassalotti :
--
versions: +Python 2.7, Python 3.3
___
Python tracker
<http://bugs.python.org/issue12290>
___
___
Python-bugs-list mailin
Alexandre Vassalotti added the comment:
Adding a special type is not a bad idea. We have to keep the code for loading
BINSTRING opcodes anyway, so we might as well use it. It could be helpful for
unit-testing our Python 2 compatibility support for pickle.
We should still fix array in 2.7 to
Alexandre Vassalotti added the comment:
The issue here is copy.deepcopy will raise an exception whenever it encounters
a generator. We would like to do better here. Unfortunately, using
itertools.tee is not a solution here because it does not preserve the type of
the object
Alexandre Vassalotti added the comment:
The patch is good. I am not sure if you need the freefunc cast though.
The example in the PEP 3121 should updated if freefunc is actually required. I
didn't define freefunc because of this ex
Alexandre Vassalotti added the comment:
+1 from me as well for a separate file.
--
___
Python tracker
<http://bugs.python.org/issue20395>
___
___
Python-bug
New submission from Alexandre Vassalotti:
The _Py_open function in Python/fileutils.c cannot be given correctly the flag
O_CREAT. According to the POSIX spec, open(2) _must_ be given an additional
mode argument when O_CREAT is used.
_Py_open should be fixed to either to use a reasonable
Alexandre Vassalotti added the comment:
> What is the current behaviour?
I don't think the behaviour is defined. At least, I know it causes recent
GCC/glibc combination to throw a compilation error when _FORTIFY_SOURCE is
defined:
http://www.eglibc.org/cgi-bin/viewvc.cgi/trunk
Alexandre Vassalotti added the comment:
Tim Gordon wrote:
> __add__ is non-commutative for lists, tuples, strings etc. - perhaps
> non-commutative wasn't quite what you were looking for :p.
Yeah, I was not clear in my explanation.
The thing is for lists, tuples, string and ot
Changes by Alexandre Vassalotti :
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue6410>
___
___
Python-bugs-list mailing list
Un
Alexandre Vassalotti added the comment:
New patch with the superfluous macros stripped out. However, I still
like my original patch better, since it is a bit more consistent.
Anyway, is anyone opposed to this change?
--
___
Python tracker
<h
Alexandre Vassalotti added the comment:
Committed the warning patch in r73846 (with a minor correction in
r73847), the 2to3 fixer in r73849.
Thanks!
--
assignee: collinwinter ->
nosy: +alexandre.vassalotti
resolution: -> accepted
stage: -> committed/rejected
status: open
Alexandre Vassalotti added the comment:
Fixed the array bug in r73850. Is there any bug left to fixed that were
reported in this issue?
--
nosy: +alexandre.vassalotti
___
Python tracker
<http://bugs.python.org/issue4
Alexandre Vassalotti added the comment:
Committed in r73856.
--
nosy: +alexandre.vassalotti
resolution: -> accepted
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Alexandre Vassalotti added the comment:
Here is an attempt to add a Py3K warning when sys.exitfunc is modified.
--
nosy: +alexandre.vassalotti
Added file: http://bugs.python.org/file14453/sys_exitfunc_warning.diff
___
Python tracker
<h
Alexandre Vassalotti added the comment:
I would like to commit my patch later this week. So if you see any issue
with the patch, please speak up.
--
___
Python tracker
<http://bugs.python.org/issue2
Changes by Alexandre Vassalotti :
Removed file: http://bugs.python.org/file11096/fix_array_pickling.patch
___
Python tracker
<http://bugs.python.org/issue2389>
___
___
New submission from Alexandre Vassalotti :
Running 2to3 with the default options on the following code:
from __future__ import print_function
x,y = 1,2
print(x, y)
produces the following diff:
--- future_print.py (original)
+++ future_print.py (refactored)
@@ -1,5 +1,5 @@
-from
Alexandre Vassalotti added the comment:
> I'm not sure what the "new patch" is since you haven't uploaded it
Oh silly me. Here's the new patch.
--
Added file: http://bugs.python.org/file14459/strict-aliasing-pydescr-2.diff
_
New submission from Alexandre Vassalotti :
It looks like either array's 'w' support got lost in a merge, or the
documentation is just wrong.
>>> import array
>>> array.array('w', "hello")
Traceback (most recent call last):
File "&quo
Alexandre Vassalotti added the comment:
I know believe that arrays should be pickled as a list of values on
Python 2.x. Doing otherwise makes it impossible to unpickle arrays
coming from Python 2.x using Python 3.x, since pickle on Python 3
decodes all the strings from 2.x to Unicode.
However
Alexandre Vassalotti added the comment:
Can you provide a patch?
--
nosy: +alexandre.vassalotti
priority: -> low
stage: -> needs patch
versions: +Python 3.2 -Python 2.4, Python 2.5, Python 2.6, Python 3.0, Python
3.1
___
Python tracker
Alexandre Vassalotti added the comment:
Here's an updated version of my lsprof.py module. I fixed a few bugs,
includes the awful reference leak that was present in the previous
version (i.e., the profiler code was keeping a reference to every frame
executed).
I consider the lsprof.py
Changes by Alexandre Vassalotti :
Removed file: http://bugs.python.org/file14376/lsprof.py
___
Python tracker
<http://bugs.python.org/issue2919>
___
___
Python-bugs-list m
Alexandre Vassalotti added the comment:
I don't see why you want to pickle NoneType. Do you have a proper
use-case for this, or are you just playing around with pickle?
--
nosy: +alexandre.vassalotti
priority: -> low
___
Python tracke
Alexandre Vassalotti added the comment:
Committed fix for 3.x in r74013 and for 2.x in r74014.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Alexandre Vassalotti added the comment:
I agree with Nick.
And if you really want to, you could hack a Pickler subclass to support
NoneType:
import io
import pickle
class XPickler(pickle.Pickler):
def persistent_id(self, obj):
if obj is type(None):
return "NoneType"
Alexandre Vassalotti added the comment:
Patch committed in r74155 (branches/py3k).
--
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Alexandre Vassalotti added the comment:
Patch committed in r74156 (branches/py3k).
--
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Alexandre Vassalotti added the comment:
Committed in r74157 (branches/py3k).
--
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Alexandre Vassalotti added the comment:
Committed in r74158 (branches/py3k).
--
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Alexandre Vassalotti added the comment:
Committed in r74159 (branches/py3k).
--
resolution: -> accepted
stage: patch review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.o
Alexandre Vassalotti added the comment:
Oh, nice catch. That patch looks fine. However, I would probably add a
comment why the fstat checks are required.
--
nosy: +alexandre.vassalotti
___
Python tracker
<http://bugs.python.org/issue6
Alexandre Vassalotti added the comment:
Closing as I don't see any other bugs in this issue to fix.
--
resolution: -> fixed
stage: needs patch -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.pyt
Changes by Alexandre Vassalotti :
Added file: http://bugs.python.org/file14549/testcase3.py
___
Python tracker
<http://bugs.python.org/issue6551>
___
___
Python-bug
Changes by Alexandre Vassalotti :
Added file: http://bugs.python.org/file14550/testcase4.py
___
Python tracker
<http://bugs.python.org/issue6551>
___
___
Python-bug
Changes by Alexandre Vassalotti :
Added file: http://bugs.python.org/file14547/testcase1.py
___
Python tracker
<http://bugs.python.org/issue6551>
___
___
Python-bug
New submission from Alexandre Vassalotti :
For some yet unknown reason, test_codecs fails when it is run after
test_zipimport and subsequently test_mailbox:
./python Lib/test/regrtest.py -w test_zipimport test_mailbox test_codecs
[SNIP
Changes by Alexandre Vassalotti :
Added file: http://bugs.python.org/file14548/testcase2.py
___
Python tracker
<http://bugs.python.org/issue6551>
___
___
Python-bug
Alexandre Vassalotti added the comment:
The patch was merged to 3.x in r74132.
--
assignee: jyasskin ->
nosy: +alexandre.vassalotti
resolution: -> accepted
status: open -> closed
___
Python tracker
<http://bugs.python.o
301 - 400 of 602 matches
Mail list logo
