Alex Gaynor added the comment:
Attached patch now includes documentation and should be complete.
--
keywords: +needs review
Added file: http://bugs.python.org/file35122/compare_digest.diff
___
Python tracker
<http://bugs.python.org/issue21
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue21470>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue20115>
___
___
Python-bugs-list mailing list
Unsubscribe:
Alex Gaynor added the comment:
I have not started on this patch yet, I'd wanted to get the other, smaller,
backports done first. Unless someone else is planning on getting to this, I
think 2.7.8 is more realistic.
--
___
Python tracker
Alex Gaynor added the comment:
New patch includes the documentation as well.
--
keywords: +needs review
Added file: http://bugs.python.org/file35242/pbkdf2.diff
___
Python tracker
<http://bugs.python.org/issue21
Alex Gaynor added the comment:
I'm still concerned about the unicode issue, but I'm not sure what the right
way to fix it is.
--
___
Python tracker
<http://bugs.python.o
Alex Gaynor added the comment:
Sorry, I wasn't concerned from a timing attack perspective here, I was
concerned from an "oh my god implicit coercion is terrible" perspective :-)
--
___
Python tracker
<http://bugs.pyt
Alex Gaynor added the comment:
Will that implementation cause a memory leak? Won't the lru_cache have a dict
mapping {self: result}, meaning that `self` will live forever, instead of
storing result in self.__dict__, where the lifetimes are correct.
--
nosy:
New submission from Alex Gaynor:
Attached patch is against the default branch, and fixes a number of typos.
--
assignee: docs@python
components: Documentation
files: typos.diff
keywords: needs review, patch
messages: 218769
nosy: alex, docs@python
priority: normal
severity: normal
Alex Gaynor added the comment:
Updated patch applies all of MAL's suggestions. Except the buffer() one, the
purpose of the buffer() call is to make it an error to pass a list (or random
other types) since you can call bytes() on any object.
--
Added file: http://bugs.pytho
Alex Gaynor added the comment:
As a note, the current code is basically identical to the code in Christain's
backport, without the py3k compat.
--
___
Python tracker
<http://bugs.python.org/is
Alex Gaynor added the comment:
New patch removes the pdb nonsense in the test.
--
Added file: http://bugs.python.org/file35375/pbkdf2.diff
___
Python tracker
<http://bugs.python.org/issue21
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue21569>
___
___
Python-bugs-list mailing list
Unsubscribe:
Alex Gaynor added the comment:
I ran the script (modified very slightly for python 2 support) under PyPy 2.3:
$ pypy select.py
== Single call mode ==
Nsort select7 select23 select47 select97 select select2
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue21671>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue20188>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue14621>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Alex Gaynor added the comment:
Since the paste is dead:
i = filter(bool, range(5))
for _ in range(100):
i = filter(bool, i)
for p in i:
print(p)
--
___
Python tracker
<http://bugs.python.org/issue14
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue16575>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue16576>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue16612>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue16619>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Alex Gaynor added the comment:
Nick, None was a constant even in 2k
--
___
Python tracker
<http://bugs.python.org/issue16619>
___
___
Python-bugs-list mailin
Alex Gaynor added the comment:
For what it's worth, I'm not as concerned with the process of the PEP, as
having a single document we can review and discuss.
--
___
Python tracker
<http://bugs.python.o
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue16651>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Alex Gaynor added the comment:
A lot of builtins :)
--
___
Python tracker
<http://bugs.python.org/issue16651>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue16894>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue16991>
___
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.pyth
New submission from Alex Gaynor:
Use case:
Alexanders-MacBook-Pro:pypy alex_gaynor$ python3.3
Python 3.3.2 (default, May 29 2013, 14:03:57)
[GCC 4.2.1 Compatible Apple LLVM 4.2 (clang-425.0.28)] on darwin
Type "help", "copyright", "credits" or "licens
New submission from Alex Gaynor:
select.epoll should expose an api such as `iterpoll` which returns an iterator
over the ready events, rather than a list. Allocating a list is wasteful in
many cases (e.g. twisted's event loop) and it'd be nice to have an API that was
les
Alex Gaynor added the comment:
Using locals() in this fashion is a serious anti-pattern, I'm -∞ on the docs
suggesting it.
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/is
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue19904>
___
___
Python-bugs-list mailing list
Unsubscribe:
Alex Gaynor added the comment:
I just wanted to note that I've been actively working on this, but it's being
difficult in ways I hadn't predicted :-) Will send an update to python-dev in
the next week or so.
--
___
Python
New submission from Alex Gaynor:
If one invokes some distutils code too early, this function will try to read
``_config_vars`` before it is initialized.
http://bpaste.net/show/1DOGhL8sdnkPyLTL06AZ/ is an example traceback that
results.
The attached patch uses the public API which guarantees
Alex Gaynor added the comment:
Test looks reasonable to me.
--
___
Python tracker
<http://bugs.python.org/issue21923>
___
___
Python-bugs-list mailing list
Unsub
Alex Gaynor added the comment:
Danek, you might find https://github.com/dreid/posix_spawn/ useful, it provides
bindings and a public API over posix_spawn (it's not complete yet, but if
there's stuff missing, feel free to fil
New submission from Alex Gaynor:
This makes things slower than they need to be (yes, even on CPython :-)), and
is slightly confusing since usually inner classes are only used when a closure
is needed.
Attached patch simply moves the class definition.
--
components: Library (Lib
Alex Gaynor added the comment:
I think this is likely to make timeit less representative of how code actually
performs in the real world on systems with a JIT. This is because of the cost
of sequential operations is not strictly "additive" on PyPy.
If you have statements `a` and `b
Changes by Alex Gaynor :
--
keywords: +needs review
___
Python tracker
<http://bugs.python.org/issue21990>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Alex Gaynor:
This can be seen at
https://docs.python.org/3.4/library/ssl.html#ssl.SSLContext.check_hostname
It looks like the colon should be omitted, and the next line un-indented.
--
assignee: docs@python
components: Documentation
keywords: easy
messages: 223291
New submission from Alex Gaynor:
http://hg.python.org/cpython/file/2.7/Objects/unicodeobject.c#l840
Specifically it calls "PyObject_Str", which will return a PyStringObject *
(cast to a PyObject *), and then calls "PyUnicode_GET_SIZE", which is of course
totally incor
Alex Gaynor added the comment:
It's worth noting that this function is replete with incorrect assumptions
about unicode vs. strings that came from the backport, the one I initially
pointed out was merely the first.
The motivation for this issue is the SSL module backport (issue21308) fo
Alex Gaynor added the comment:
Hi Victor, thanks for working on this. I don't know the Unicode codebase that
well, but this looks like an obvious improvement to me (much less broken :-)).
--
___
Python tracker
<http://bugs.python.org/is
Alex Gaynor added the comment:
Reviewed more closely today, I think the docs probably need updating, but
otherwise this LGTM, massive improvement! Thanks!
--
___
Python tracker
<http://bugs.python.org/issue22
Alex Gaynor added the comment:
I've tested in my local dev with my SSL patches applied, and I've confirmed
that it fixes the segfaults.
--
___
Python tracker
<http://bugs.python.o
Alex Gaynor added the comment:
The attached patch (drafted by myself, and David Reid) backports all of the SSL
module (and tests!!!) to Python 2.7. All tests pass on my machine (OS X 10.9),
I haven't tested against other platforms.
I /suspect/ the best way to review this patch will
Alex Gaynor added the comment:
New version of this patch fixes a bunch of versionadded and changeds in the
docs that referred to the wrong version.
--
Added file: http://bugs.python.org/file36089/ssl-backport.diff
___
Python tracker
<h
Alex Gaynor added the comment:
If you're going to fix the semantics of the method lookup to go via the type,
can you please do that for the pure python version as well? When the C and
Python versions diverge on semantics, it becomes a real pain for alternate
implementations whic
New submission from Alex Gaynor:
Attached patch fixes a pair of typos.
--
assignee: docs@python
components: Documentation
files: ssl-docs.diff
keywords: easy, needs review, patch
messages: 223982
nosy: alex, docs@python
priority: normal
severity: normal
status: open
title: Fix typos in
New submission from Alex Gaynor:
Specifically, the links in the "Acknowledgements" section
http://legacy.python.org/dev/peps/pep-0466/#acknowledgements
--
messages: 223985
nosy: alex, ncoghlan
priority: normal
severity: normal
status: open
title: Reference links in PEP466
Alex Gaynor added the comment:
Try #3: This fixes a bug with NPN (I hadn't tested with an OpenSSL that
supports NPN, I have now), and cherry-picks the typo fixes from 967311e6c0d2
--
Added file: http://bugs.python.org/file36092/ssl-backport
New submission from Alex Gaynor:
This is on default:
$ python3 Lib/test/make_ssl_certs.py
creating cert for localhost
Generating a 1024 bit RSA private key
.++
++
writing new private key to
'/var/folde
Changes by Alex Gaynor :
--
nosy: +christian.heimes, dstufft, giampaolo.rodola, janssen, pitrou
___
Python tracker
<http://bugs.python.org/issue22074>
___
___
Alex Gaynor added the comment:
Personally I don't think it is (or should) be against policy to change reprs,
there's not really any way to improve them otherwise.
That said, my excitement level about this issue is pretty low, so I won't argue
Alex Gaynor added the comment:
New patch cherry pick's the fix from issue22074.
--
Added file: http://bugs.python.org/file36113/ssl-backport.diff
___
Python tracker
<http://bugs.python.org/is
Alex Gaynor added the comment:
Yup.
--
___
Python tracker
<http://bugs.python.org/issue22079>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
Alex Gaynor added the comment:
Ned, did you apply the patch from http://bugs.python.org/issue22023 first? That
bt looks like what you'd see without it.
--
___
Python tracker
<http://bugs.python.org/is
Alex Gaynor added the comment:
Investigations:
The test_poplib failures are caused by the backporting of
http://bugs.python.org/issue20951, does anyone have opinions on whether we
should backport Antoine's fix for poplib, or revert that particular change?
I'm not sure how t
Alex Gaynor added the comment:
Latest patch makes the needed change to Makefile.pre.in
--
Added file: http://bugs.python.org/file36142/ssl-backport.diff
___
Python tracker
<http://bugs.python.org/issue21
Alex Gaynor added the comment:
`self.int.to_bytes(16, byteorder='big')` looks to be even faster (about 3x on
my machine)
--
nosy: +alex
___
Python tracker
<http://bugs.python.o
Changes by Alex Gaynor :
--
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issue22131>
___
___
Python-bugs-list mailing list
Unsubscribe:
Alex Gaynor added the comment:
What I said only applies to the Python3 version of this patch.
Thanks for submitting this.
--
___
Python tracker
<http://bugs.python.org/issue22
Alex Gaynor added the comment:
Latest patch does as Donald suggests and rolls back the WantWrite changes,
fixing poplib.
--
Added file: http://bugs.python.org/file36255/ssl-backport.diff
___
Python tracker
<http://bugs.python.org/issue21
Alex Gaynor added the comment:
Patch LGTM.
--
nosy: +alex
versions: +Python 3.5
___
Python tracker
<http://bugs.python.org/issue22146>
___
___
Python-bugs-list m
New submission from Alex Gaynor:
https://www.openssl.org/news/secadv_20140806.txt
--
components: Interpreter Core, Library (Lib)
keywords: security_issue
messages: 224976
nosy: alex, benjamin.peterson, steve.dower
priority: normal
severity: normal
status: open
title: Windows installers
Alex Gaynor added the comment:
I've been doing this work in a git repo, do you know how to generate an
hg-formated diff with git?
--
___
Python tracker
<http://bugs.python.org/is
Alex Gaynor added the comment:
New patch should be in the "mercurial" diff format.
--
Added file: http://bugs.python.org/file36301/ssl-backport.diff
___
Python tracker
<http://bugs.python.o
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue22181>
___
___
Python-bugs-list mailing list
Unsubscribe:
Alex Gaynor added the comment:
Thanks for testing this out Robert! The attached patch fixes the error you saw.
--
Added file: http://bugs.python.org/file36407/ssl-backport.diff
___
Python tracker
<http://bugs.python.org/issue21
New submission from Alex Gaynor:
Based on a reading of the code:
https://github.com/python/cpython/blob/master/Lib/wsgiref/simple_server.py#L88-L90
is where REMOTE_HOST is set.
However, `address_string` always returns `self.client_address[0]`
(https://github.com/python/cpython/blob/master
Alex Gaynor added the comment:
New patch additionally backports the Tools/ssl/ directory from Python3, which
has two utilities for generating some of the code used. Thanks to Benjamin for
catching this.
--
Added file: http://bugs.python.org/file36418/ssl-backport.diff
Alex Gaynor added the comment:
Last version had some stray stuff due to the fact that I don't know how to use
version control. New version should resolve that.
--
Added file: http://bugs.python.org/file36419/ssl-backport.diff
___
Python tr
Alex Gaynor added the comment:
On what platform?
--
___
Python tracker
<http://bugs.python.org/issue21308>
___
___
Python-bugs-list mailing list
Unsubscribe:
Alex Gaynor added the comment:
Latest patch fixes both the issues Benjamin noted.
--
Added file: http://bugs.python.org/file36423/ssl-backport.diff
___
Python tracker
<http://bugs.python.org/issue21
Alex Gaynor added the comment:
Thanks for the report, I've filed: http://bugs.python.org/issue22244 to track
that issue.
--
___
Python tracker
<http://bugs.python.org/is
New submission from Alex Gaynor:
Details of the issue are here: http://bugs.python.org/msg225613
I'm not sure what the correct API to use is there, perhaps the encoding can be
folded into the PyArg_ParseTupleAndKeywords() call.
--
components: Extension Modules
messages: 225614
Alex Gaynor added the comment:
Uploaded patch adds the algorithm availability constants to the hashlib module.
--
components: +Extension Modules
keywords: +needs review, patch
Added file: http://bugs.python.org/file36436/backport-hashlib.diff
Alex Gaynor added the comment:
Attached patch backports the persistent FD for urandom.
--
components: +Extension Modules, Interpreter Core
keywords: +needs review, patch
Added file: http://bugs.python.org/file36437/backport-urandom.diff
___
Python
Alex Gaynor added the comment:
Attached patch resolves the issue, includes a test.
--
keywords: +needs review, patch
Added file: http://bugs.python.org/file36438/t22244.diff
___
Python tracker
<http://bugs.python.org/issue22
Alex Gaynor added the comment:
New patch uses PyString_FromString.
To the other two points:
1) Python3 uses a mutable set for both of these, any reason for Python2 to be
inconsistent?
2) The docs in Python3 don't have this link either, I'm trying to minimize the
delta; if you t
Alex Gaynor added the comment:
Unfortunately no, the API accepts explicit Nones (in addition to simply not
passing the argument), and et errors on those.
--
___
Python tracker
<http://bugs.python.org/issue22
Alex Gaynor added the comment:
It's not clear to me that that's better, and it makes the diff with the Python3
version larger.
--
___
Python tracker
<http://bugs.python.o
Alex Gaynor added the comment:
Attached patch adds an additional test for a more interesting unicode path.
--
Added file: http://bugs.python.org/file36441/t22244.diff
___
Python tracker
<http://bugs.python.org/issue22
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue22265>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue22266>
___
___
Python-bugs-list mailing list
Unsubscribe:
Alex Gaynor added the comment:
Perhaps these should use the gc_collect function in test_support?
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue22
Alex Gaynor added the comment:
Ok, this was landed, 3.3 is no longer open so closing this.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Alex Gaynor added the comment:
Pinging on this, since the SSL backport landed, concerns about an inability to
change this behavior on python2 are no longer there. At a minimum I think we
should include this flag in the default and stdlib contexts
Changes by Alex Gaynor :
--
nosy: +alex
___
Python tracker
<http://bugs.python.org/issue21965>
___
___
Python-bugs-list mailing list
Unsubscribe:
Alex Gaynor added the comment:
This patch adds the finalizer to the backport -- not sure how I missed this the
first time.
--
Added file: http://bugs.python.org/file36496/backport-urandom.diff
___
Python tracker
<http://bugs.python.org/issue21
Alex Gaynor added the comment:
Victor -- new patch is in `hg` format.
--
Added file: http://bugs.python.org/file36497/backport-urandom.diff
___
Python tracker
<http://bugs.python.org/issue21
Alex Gaynor added the comment:
This is resolved now.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Alex Gaynor added the comment:
Attached patch fixes this up.
--
keywords: +needs review, patch
nosy: +alex
Added file: http://bugs.python.org/file36505/t22301.diff
___
Python tracker
<http://bugs.python.org/issue22
Alex Gaynor added the comment:
Should this be backported to 2.7.9?
--
___
Python tracker
<http://bugs.python.org/issue20421>
___
___
Python-bugs-list mailin
Alex Gaynor added the comment:
Attached patch backports it (only change is the use of `closing()` and
resolving the conflict in Misc/NEWS). I'll leave it up to benjamin whether he
wants to commit (input from others welcome). My view is to prefer backporting
stuff since it helps keep the
Alex Gaynor added the comment:
Patch looks good to me.
--
___
Python tracker
<http://bugs.python.org/issue22131>
___
___
Python-bugs-list mailing list
Unsub
Changes by Alex Gaynor :
--
nosy: +alex, christian.heimes, dstufft, giampaolo.rodola, janssen, pitrou
___
Python tracker
<http://bugs.python.org/issue22
New submission from Alex Gaynor:
Instead of the ca* arguments it currently takes, these can all be encapsulated
into an SSLContext argument, which the underlying http.client already supports.
--
components: Library (Lib)
messages: 226594
nosy: alex, christian.heimes, dstufft
Alex Gaynor added the comment:
Attached patch against the default branch adds support for this.
--
keywords: +needs review, patch
Added file: http://bugs.python.org/file36573/urlopen-context.diff
___
Python tracker
<http://bugs.python.org/issue22
Alex Gaynor added the comment:
Added a versionchanged directive to the docs.
--
Added file: http://bugs.python.org/file36576/urlopen-context.diff
___
Python tracker
<http://bugs.python.org/issue22
201 - 300 of 465 matches
Mail list logo
