Éric Araujo added the comment:
I read again the part of the PEP about __file__ and decided the code is a dead
branch, so I removed it.
--
keywords: +needs review, patch
stage: -> commit review
Added file:
http://bugs.python.org/file22150/dead-code-importlib-test-main-3.3.d
Éric Araujo added the comment:
I don’t know if we should go out of our way to support running tests in
interactive mode. Running them from regrtest is the recommended way.
--
title: Test_argparse failure but only in interactive mode -> test_argparse
failure in interactive m
Éric Araujo added the comment:
I think I’d better leave this one to Terry or Raymond.
--
___
Python tracker
<http://bugs.python.org/issue11948>
___
___
Python-bug
Éric Araujo added the comment:
> email (silently) failed to encode a string
Is this silent error another bug to fix?
--
___
Python tracker
<http://bugs.python.org/iss
Éric Araujo added the comment:
I made a few comments and asked two questions on the review page. (I should
have said so here.)
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue1
Éric Araujo added the comment:
> Since *parts* is a list, the above can be replaced with simply "if parts:"
Heh, I always use implied truth values and one disagreed with Tarek about this,
but here if felt more natural to spell out my mind with an explicit > 0
comparison :)
Éric Araujo added the comment:
FYI, you can upload versions of the same patch with the same name and remove
old versions. The code review tool will remember versions, and it’s easier for
human if there’s only one patch.
--
versions: +Python 3.3 -Python 3.2
Changes by Éric Araujo :
Removed file: http://bugs.python.org/file22141/unnamed
___
Python tracker
<http://bugs.python.org/issue12042>
___
___
Python-bugs-list mailin
Éric Araujo added the comment:
As a general rule, rewrapping is not done in patches, it can make review less
easy. The committer can do it, sometimes in a second commit.
I commented on the review page.
--
nosy: +eric.araujo
title: Shutil - add chown() in order to allow to use user
Éric Araujo added the comment:
> Interactive mode is an approved method of running Python code, along
> with batch mode. The core interpreter and stdlib modules should run
> correctly in both modes. So the entire test suite should pass in both
> modes too.
You are right.
> That
Éric Araujo added the comment:
Now fixed, thanks for the report.
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
versions: +Python 3.3
___
Python tracker
<http://bugs.python.o
Éric Araujo added the comment:
Hi David, I made this patch to port the improvements you made to 2.7. The new
usage message looks like this:
usage: python compileall.py [-l] [-f] [-q] [-d destdir] [-x regexp] [-i list]
[directory|file ...]
arguments: zero or more file and directory names to
Changes by Éric Araujo :
Added file: http://bugs.python.org/file22174/compileall-help-3.x.diff
___
Python tracker
<http://bugs.python.org/issue10454>
___
___
Python-bug
Éric Araujo added the comment:
The python-dev discussion talked about chowntree vs. os.walk:
http://mail.python.org/pipermail/python-dev/2011-May/111667.html
http://mail.python.org/pipermail/python-dev/2011-May/111673.html
http://mail.python.org/pipermail/python-dev/2011-May/111674.html
I find
Éric Araujo added the comment:
If you’re logged into Roundup, you should automatically be logged into our
Rietveld instance. You can file a bug on the meta-tracker (link in the left
sidebar) if this does not work.
--
___
Python tracker
<h
Éric Araujo added the comment:
This request is not feasible with Mercurial and the useful info is already
available. Closing.
--
resolution: -> works for me
stage: -> committed/rejected
status: open -> closed
___
Python track
Éric Araujo added the comment:
I found “bitwise OR-ed” in library/fcntl.rst library/functions.rst
library/os.rst library/winsound.rst (using grep, not Sphinx :)
--
___
Python tracker
<http://bugs.python.org/issue12
Éric Araujo added the comment:
Again, changing the role :func: to :class: adds zero value to the tools or the
human readers. What’s needed are class *directives* that will provide a target
for those links, e.g.:
.. class:: list
.. method:: append
Then :func:`list` and :meth
Éric Araujo added the comment:
Thanks for explaining.
> a) NoneType object is not iterable. If the function don't return empty list
> later distutil will fail
Possible fix: self.dll_libraries = get_msvcr() or []
> method for detection of a msvc runtime is not correct. If the m
New submission from Éric Araujo :
Title says it all.
--
assignee: docs@python
components: Documentation
files: document-pycf-only-ast.diff
keywords: needs review, patch
messages: 137203
nosy: docs@python, eric.araujo
priority: normal
severity: normal
stage: patch review
status: open
New submission from Éric Araujo :
I found a bug in email.policy.rst (Msg instead of msg) and did other touch-ups
in the file. Please review.
--
assignee: docs@python
components: Documentation
files: email.policy-markup-glitches.diff
keywords: patch
messages: 137204
nosy: docs@python
New submission from Éric Araujo :
I made some grammar fixes in faulthandler.rst and tweaked the example to better
show what the module does.
I’d like to fix the synopsis too: “dump the Python traceback” is not very clear
to me. It is the traceback or the stack trace? Why is it called “the
Éric Araujo added the comment:
This is my current patch, FYI.
--
keywords: +patch
Added file:
http://bugs.python.org/file22178/versionadded-3.2-json-indent-str.diff
___
Python tracker
<http://bugs.python.org/issue11
Éric Araujo added the comment:
See #11964 for a documentation problem with this change.
--
___
Python tracker
<http://bugs.python.org/issue5729>
___
___
Pytho
Éric Araujo added the comment:
Would storing len(self._buffer) in the instance be premature optimization?
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue968
Changes by Éric Araujo :
--
status: open -> pending
___
Python tracker
<http://bugs.python.org/issue11751>
___
___
Python-bugs-list mailing list
Unsubscri
Éric Araujo added the comment:
Could you make an effort to accept our word that using :class: instead of
:func: would bring zero value to the indexing system nor to human readers?
--
versions: -Python 3.1
___
Python tracker
<h
Éric Araujo added the comment:
> faulthandler prints the Python trace, not the C trace, so I prefer to
> call it a "traceback" than "stack trace".
Okay. What do you think about this synopsis then: dumping the tra
Éric Araujo added the comment:
Looks good. One remark: instead of using keys() + getitem in Lib/netrc.py:109,
you can use this: for host, attrs in self.allhosts.items()
--
___
Python tracker
<http://bugs.python.org/issue11
Éric Araujo added the comment:
I would not document 'parsers'.
--
___
Python tracker
<http://bugs.python.org/issue10772>
___
___
Python-bugs-l
Éric Araujo added the comment:
Okay. I’ll make another patch to remove mentions of this flag then.
--
versions: -Python 3.1
___
Python tracker
<http://bugs.python.org/issue12
Éric Araujo added the comment:
> I'm already doing;
Thanks.
> but I don't see anyone having made a good point against my preference
> of using ".. class::" to document classes.
We have agreed it is needed (I think it’s on another b
Éric Araujo added the comment:
Due to implementation details and history of CPython, it is not “more correct”
to say that int is a function and a class. You could argue either. The
question is however moot; when you mark up something with a mod, func, class or
meth role, Sphinx will find
Éric Araujo added the comment:
Okay, I understand now that the traceback always exists, not only during
exceptions. The module gives control over the display of that traceback. Am I
right?
--
___
Python tracker
<http://bugs.python.
Éric Araujo added the comment:
Exactly, minus the parens (not needed).
--
versions: -Python 3.1
___
Python tracker
<http://bugs.python.org/issue11416>
___
___
Éric Araujo added the comment:
I’m surprised self.assert_ does not produce a DeprecationWarning (in favor of
assertTrue). The tests should use assertEqual(expected, computed) anyway, to
let developers see a useful diff when the test fails. Could you change this in
the tests
Éric Araujo added the comment:
FTR, doko applied this patch for Debian and Ubuntu:
http://patch-tracker.debian.org/patch/series/view/python3.2/3.2.1~rc1-1/platform-lsbrelease.diff
--
versions: +Python 3.3 -Python 3.1
___
Python tracker
<h
Éric Araujo added the comment:
Ah, okay. Your patch needs to apply to 2.7 or 3.2, which use assertEqual and
not assert_.
--
___
Python tracker
<http://bugs.python.org/issue11
Changes by Éric Araujo :
Removed file: http://bugs.python.org/file21444/netrc.patch
___
Python tracker
<http://bugs.python.org/issue11416>
___
___
Python-bugs-list mailin
Changes by Éric Araujo :
Removed file: http://bugs.python.org/file22193/netrc.patch
___
Python tracker
<http://bugs.python.org/issue11416>
___
___
Python-bugs-list mailin
Changes by Éric Araujo :
Removed file: http://bugs.python.org/file22194/netrc.patch
___
Python tracker
<http://bugs.python.org/issue11416>
___
___
Python-bugs-list mailin
Éric Araujo added the comment:
Great! Could you expand the docstrings and reST documentation to mention the
new behavior?
--
___
Python tracker
<http://bugs.python.org/issue11
Éric Araujo added the comment:
I suggest we move the discussion to #6490.
--
nosy: +eric.araujo
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> os.popen documentation in 2.6 is probably wrong
__
New submission from Éric Araujo :
haypo suggested linking between traceback.print_tb and
faulthandler.dump_traceback(). See also links between pdb and faulthandler
could also be nice, if they explain briefly how the modules differ.
--
assignee: docs@python
components: Documentation
Éric Araujo added the comment:
>From IRC: too late for 3.1.
--
resolution: -> out of date
stage: commit review -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python
Éric Araujo added the comment:
Jonas, I owe you an apology: when I abruptly asked “Could you make an effort to
accept” etc., I had misread your message and thought you were asking to change
the roles, but you were speaking of directives, so my comment was out of line.
Sorry
Éric Araujo added the comment:
Agreed.
I experimented with tuple and tuple.count and it turns out that it’s not easily
solved: the count method is documented in the table describing all sequences
methods, which should not be duplicated IMO; I tried adding a .. method::
tuple.append
Éric Araujo added the comment:
I cannot review the patch (I don’t know C), but I will trust you. Could you
add a test to prevent regressions?
--
versions: -Python 3.4
___
Python tracker
<http://bugs.python.org/issue12
Éric Araujo added the comment:
Looks good, thanks.
--
___
Python tracker
<http://bugs.python.org/issue11416>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Éric Araujo :
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue12170>
___
___
Python-bugs-list mailing list
Unsubscribe:
Éric Araujo added the comment:
> I was just asking given the "unusual" situation 2.7 is (i.e. a very
> long support series)
Support means bug fixes. Long-term means that the bugfix period (before going
into security mode) is extended, not that it can get new features: that’s
Éric Araujo added the comment:
Hi, thanks for the report and patch. I think the code should not find
byte-compiled files if sys.dont_write_bytecode is true, and it should not find
pyo files when sys.flags.optimize has a certain value (I don’t remember if it’s
1 or 2). It also requires
New submission from Éric Araujo :
I am working on a patch to document manifest.Manifest methods and list all
exceptions defined in errors.
--
assignee: eric.araujo
components: Distutils2, Documentation
messages: 137522
nosy: alexis, eric.araujo
priority: normal
severity: normal
status
Changes by Éric Araujo :
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue11197>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Éric Araujo :
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue1669349>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Éric Araujo :
--
title: Add support for PEP 381 -- Mirror Authenticity -> Add support for PEP
381 Mirror Authenticity
versions: +Python 3.3 -3rd party
___
Python tracker
<http://bugs.python.org/issu
Éric Araujo added the comment:
How about reusing unittest discovery in regrtest?
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue12
Éric Araujo added the comment:
This sounds non-trivial to implement. Do you have any concrete ideas or a
proof of concept?
--
nosy: +eric.araujo, ezio.melotti, michael.foord
versions: +Python 3.3 -Python 2.7
___
Python tracker
<h
Éric Araujo added the comment:
Hello. This tracker is used to report bugs and file feature requests for
Python itself, not request help (mailing list such as
http://mail.python.org/pipermail/python-list/ are appropriate venues to ask for
for help). I’m changing your question to a bug
Éric Araujo added the comment:
I can’t see why not. Would you like to work on a patch?
--
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue12
Éric Araujo added the comment:
+1 to what David said. See also #5753.
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue12238>
___
___
Pytho
Éric Araujo added the comment:
Yes, it’s unclear whether Unix in the docs included Mac OS X or not.
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue12
Éric Araujo added the comment:
This looks like an invalid bug to me; Python itself creates the site-packages
directory, with a README file if I remember correctly. If the sysadmin removes
the directory, it’s their problem, not a Python bug. Do you agree
Éric Araujo added the comment:
Your patch adds the cd before running make, but other examples and filenames
(for example :file:`tools/sphinx`) are also relative to Doc. How about adding
something like this after the very first paragraph:
All commands in this document should be run from the
Éric Araujo added the comment:
If it’s not too much hassle for you and if it doesn’t improve maintenance
costs, we’d feel safer with a test.
Martin, could you review this patch?
--
nosy: +loewis
___
Python tracker
<http://bugs.python.
Changes by Éric Araujo :
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue12248>
___
___
Python-bugs-list mailing list
Unsubscribe:
Éric Araujo added the comment:
Hm, in my dev environment (checkout of 3.3), site-packages exists.
--
___
Python tracker
<http://bugs.python.org/issue12
Éric Araujo added the comment:
Hi! I cleaned up your patch and fixed a bug: you have to call sort before
calling remove_duplicates (the result in your patch had two 'a' entries).
> One line was marked as excluded because it was a "this cannot happen"
> error, and I
Changes by Éric Araujo :
Added file: http://bugs.python.org/file22231/packaging-manifest.diff
___
Python tracker
<http://bugs.python.org/issue11751>
___
___
Python-bug
Changes by Éric Araujo :
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue3974>
___
___
Python-bugs-list mailing list
Unsubscribe:
Éric Araujo added the comment:
I ported the patch to packaging. Please test.
--
components: +Distutils2
nosy: +alexis
status: closed -> open
versions: -Python 2.7, Python 3.2
Added file: http://bugs.python.org/file22232/darwin-target-sysconfig-p7g.d
Éric Araujo added the comment:
Fair enough. If you think it’s enough to let people know that all paths in
:file: roles are relative to Doc, then I can commit it.
--
title: add missing command -> Document working dir for “make html”
versions: +Python 2.7, Python
Éric Araujo added the comment:
Ah, I understand; I have a $srcdir/Lib/site-packages directory, but packaging
wants to install into $prefix/site-packages, which does not exist. +1 to
adding a nice message. Tshepang, would you like to update your patch
Éric Araujo added the comment:
Patch needs to update the default server in packaging too.
--
___
Python tracker
<http://bugs.python.org/issue12226>
___
___
Pytho
Éric Araujo added the comment:
Thanks for the patch. Please join the discussion on the other bug report.
--
nosy: +eric.araujo
resolution: -> duplicate
stage: -> committed/rejected
status: open -> closed
superseder: -> Add support for ArchLinux to platform.linux_d
Éric Araujo added the comment:
For the resolution problem, see #11457.
--
___
Python tracker
<http://bugs.python.org/issue11993>
___
___
Python-bugs-list mailin
Éric Araujo added the comment:
Can you test this patch?
--
keywords: +patch
Added file: http://bugs.python.org/file22233/fix-newer-mtime.diff
___
Python tracker
<http://bugs.python.org/issue11
New submission from Éric Araujo :
When compiling with --enable-shared, the libpython file is not ignored by
Mercurial (or Bazaar, I guess). Any objection to the attached patch? I used a
wildcard, but could also hard-code the full filename with a fixed shared lib
number.
--
assignee
Éric Araujo added the comment:
A note sounds good.
--
assignee: -> docs@python
components: +Documentation -Interpreter Core, Unicode
nosy: +docs@python, eric.araujo
versions: +Python 2.7 -Python 3.1
___
Python tracker
<http://bugs.pyth
Éric Araujo added the comment:
All func_* attributes in 2.x have been given __*__ names in 3.x.
--
nosy: +eric.araujo
resolution: -> invalid
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
New submission from Éric Araujo :
Doc/library/functions.rst does not talk about how ABC interact with isinstance
or issubclass. This simple patch adds a link.
--
assignee: eric.araujo
components: Documentation
files: link-isinstance-to-abc.diff
keywords: needs review, patch
messages
Éric Araujo added the comment:
Thanks for catching this. Is this the only instance of the typo, or are there
any others in reference/datamodel or library/operator?
--
nosy: +eric.araujo
___
Python tracker
<http://bugs.python.org/issue12
New submission from Éric Araujo :
packaging still uses the DISTUTILS_USE_SDK environment variable to tweak
compilation on Windows. Do we want to change the name? Pro: separates
distutils and packaging, con: requires users to set one more var during the
transition period.
I don’t know if
New submission from Éric Araujo :
get_compiler_versions uses string regexes to match bytes streams returned by
subprocess. The test did not catch this because they mock subprocess output
with strings in self._exes.
We have to decide whether we propagate the bytes object up (and fix two
New submission from Éric Araujo :
When working on the docs for new_compiler, I read that it was possible to get
an msvc compiler on Unix. I tried it, even wrote a unit test to make sure it
worked, and found out that not all compiler classes can be instantiated on my
platform. This should be
New submission from Éric Araujo :
Now that we can break compat in distutils2/packaging, we can change the default
install dir to use PEP 370 user site-packages. For users without root,
copy-pasting “pysetup run install_dist” from the docs would Just Work™. This
would also avoid the dreadful
Éric Araujo added the comment:
Thank you for the report and patch!
--
resolution: -> fixed
stage: -> committed/rejected
status: open -> closed
___
Python tracker
<http://bugs.python.or
Éric Araujo added the comment:
> I think there should be a warning that the connection is
> unauthenticated (i.e. not secure). Users tend to be upset if they see
> 'https' and later find out that no certificates were verified.
Thanks Stephan, that was on my mind but I fo
Éric Araujo added the comment:
We do not want to create a directory under $prefix before installation. This
would be a sort of dirty half-installation. When you have an uninstalled,
unconfigured Python, you cannot install modules without giving a prefix option:
this sounds good to me
Éric Araujo added the comment:
File name, class name, method name unless I misremember.
--
___
Python tracker
<http://bugs.python.org/issue12231>
___
___
Pytho
Éric Araujo added the comment:
Agreed. Thanks for the insight.
--
title: Use PYPACKAGING_USE_SDK envvar instead of DISTUTILS_USE_SDK ->
Rework/replace use of DISTUTILS_USE_SDK in packaging
___
Python tracker
<http://bugs.python.org/issu
Éric Araujo added the comment:
Here’s my try at making the spec more explicit about str subclasses.
--
keywords: +patch
Added file: http://bugs.python.org/file22244/pep--no-subclasses.diff
___
Python tracker
<http://bugs.python.org/issue10
Éric Araujo added the comment:
I saw this commit pass by and noticed a few instances of non-idiomatic unittest
code, like unnecessary lambdas or overuse of assertEqual where other methods
would give more useful messages in case of failure. Here’s a patch to better
it.
--
assignee
Changes by Éric Araujo :
--
assignee: trentm -> vinay.sajip
nosy: -trentm
___
Python tracker
<http://bugs.python.org/issue11557>
___
___
Python-bugs-list mai
Éric Araujo added the comment:
There is a simple way to fix this: change one line in sdist to catch
ValueErrors in addition to DistutilsTemplateError. Users will get a on-line
warning message with the ill-formed manifest line number instead of a wall of
traceback.
This is clearly a bug fix
Éric Araujo added the comment:
a one-line*
I’ll have a patch up for review shortly.
--
___
Python tracker
<http://bugs.python.org/issue8286>
___
___
Python-bug
Éric Araujo added the comment:
Isn’t zlib built by setup.py anyway?
--
nosy: +eric.araujo
resolution: invalid ->
status: pending -> open
___
Python tracker
<http://bugs.python.org/i
Éric Araujo added the comment:
Is this minor cleanup, non-bugfix okay for 3.2?
--
___
Python tracker
<http://bugs.python.org/issue12019>
___
___
Python-bug
Éric Araujo added the comment:
Can you check if this is covered in test_database?
--
___
Python tracker
<http://bugs.python.org/issue10884>
___
___
Python-bug
Éric Araujo added the comment:
>> Thanks Stephan, that was on my mind but I forgot it. I’m -1 on
>> using https if no validation is performed.
> It will be more professional if you could also explain why.
If you make an HTTPS connection without checking the certificate, what se
901 - 1000 of 7440 matches
Mail list logo
