[issue37425] Using Pyinstaller with (Anaconda) Python 3.7.3 needs PyQt5 even if not imported in code

2019-06-27 Thread Steve Dower
Steve Dower added the comment: In any case, it's definitely pyinstaller and not CPython. Please report it on their issue tracker. -- status: open -> closed ___ Python tracker <https://bugs.python.org

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-27 Thread Steve Dower
Steve Dower added the comment: So I have a fix for 3.9 for this, I believe (involves making sys.base_executable configurable via PyConfig and overriding it and config->home when we know we're inside an app container). For 3.8 I can apply the same fix and make sys.base_executable pu

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-27 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +14244 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14428 ___ Python tracker <https://bugs.python.org/issu

[issue37390] Generate table of audit events for docs

2019-06-27 Thread Steve Dower
Steve Dower added the comment: New changeset 44f91c388a6f4da9ed3300df32ca290b8aa104ea by Steve Dower in branch 'master': bpo-37390: Add audit event table to documentations (GH-14406) https://github.com/python/cpython/commit/44f91c388a6f4da9ed3300df32ca29

[issue37390] Generate table of audit events for docs

2019-06-27 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-28 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +14266 pull_request: https://github.com/python/cpython/pull/14450 ___ Python tracker <https://bugs.python.org/issue37

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-28 Thread Steve Dower
Steve Dower added the comment: New changeset db4d7ddb012ef8f087a8eb2a5b8a672d04a48e1a by Steve Dower in branch '3.7': bpo-37369: Fixes path for sys.executable when running from the Microsoft Store (GH-14450) https://github.com/python/cpython/commit/db4d7ddb012ef8f087a8eb2a5b8a67

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-28 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +14273 pull_request: https://github.com/python/cpython/pull/14456 ___ Python tracker <https://bugs.python.org/issue37

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-28 Thread Steve Dower
Steve Dower added the comment: New changeset ed4657bd28432ace671a9e6ae38a3d485c69213d by Steve Dower in branch '3.7': bpo-37369: Fix venv and test symlinking (GH-14456) https://github.com/python/cpython/commit/ed4657bd28432ace671a9e6ae38a3d

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-28 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +14278 pull_request: https://github.com/python/cpython/pull/14461 ___ Python tracker <https://bugs.python.org/issue37

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-28 Thread Steve Dower
Steve Dower added the comment: New changeset db4eb2c57dbfca402a539184c966c449cb1aa8e3 by Steve Dower in branch '3.7': bpo-37369: Fix path handling when python.exe is used as a symlink (GH-14461) https://github.com/python/cpython/commit/db4eb2c57dbfca402a539184c966c4

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-29 Thread Steve Dower
Steve Dower added the comment: New changeset 9048c49322a5229ff99610aba35913ffa295ebb7 by Steve Dower in branch 'master': bpo-37369: Fix initialization of sys members when launched via an app container (GH-14428) https://github.com/python/cpyt

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-29 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +14284 pull_request: https://github.com/python/cpython/pull/14467 ___ Python tracker <https://bugs.python.org/issue37

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-29 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +14285 pull_request: https://github.com/python/cpython/pull/14468 ___ Python tracker <https://bugs.python.org/issue37

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-29 Thread Steve Dower
Steve Dower added the comment: New changeset ac14632c756fec561e4b868b8793334bd7b22241 by Steve Dower in branch 'master': bpo-37369: Fixes crash when reporting fatal error (GH-14468) https://github.com/python/cpython/commit/ac14632c756fec561e4b868b879333

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-29 Thread Steve Dower
Steve Dower added the comment: New changeset 323e743d4879f1cd861d0b252775797fb7938755 by Steve Dower in branch '3.8': bpo-37369: Fix initialization of sys members when launched via an app container (GH-14467) https://github.com/python/cpython/commit/323e743d4879f1cd861d0b25277579

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-29 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37369] Issue with pip in venv on Powershell in Windows

2019-06-29 Thread Steve Dower
Steve Dower added the comment: > I'm not sure of the purpose of sys._base_executable. Maybe open a separated > issue to make the attribute public? I'm not sure if multiprocessing (for > example) should use it, or if sys.executble should be used. Yeah, it's a bit more

[issue37452] Microsoft store package has an invalid ExecutablePath registry entry

2019-06-30 Thread Steve Dower
Steve Dower added the comment: Unfortunately, we don't control that path - it comes from a parameter substitution. I'll have to see whether there's another parameter we can use. All of this stuff is in undocumented territory

[issue37369] Issue with pip in venv on Powershell in Windows

2019-07-01 Thread Steve Dower
Change by Steve Dower : -- assignee: -> steve.dower ___ Python tracker <https://bugs.python.org/issue37369> ___ ___ Python-bugs-list mailing list Unsubscrib

[issue37412] os.getcwdb() doesn't implement PEP 528 (UTF-8) on Windows

2019-07-01 Thread Steve Dower
Steve Dower added the comment: This is fixed now, right? The buildbots seem happy at least. I'll close. -- assignee: -> vstinner resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Pytho

[issue37436] os.path.isfile() with big number cause OverflowError: fd is greater than maximum

2019-07-01 Thread Steve Dower
Steve Dower added the comment: You use this by getting the file descriptor/fileno for an open file, and then testing whether it's a file or not: >>> f=open("python.bat") >>> f.fileno() 3 >>> import os >>> os.path.isfile(3) True T

[issue33408] Enable AF_UNIX support in Windows

2019-07-01 Thread Steve Dower
Change by Steve Dower : -- title: AF_UNIX is now supported in Windows -> Enable AF_UNIX support in Windows ___ Python tracker <https://bugs.python.org/issu

[issue37363] Additional PEP578 hooks

2019-07-01 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +14337 pull_request: https://github.com/python/cpython/pull/14524 ___ Python tracker <https://bugs.python.org/issue37

[issue37390] Generate table of audit events for docs

2019-07-01 Thread Steve Dower
Steve Dower added the comment: The page is not generating correctly at https://docs.python.org/dev/library/audit_events.html Adding the documentation team, where hopefully someone will know what needs poking. -- nosy: +eric.araujo, ezio.melotti, mdk, willingc resolution: fixed

[issue37363] Additional PEP578 hooks

2019-07-01 Thread Steve Dower
Steve Dower added the comment: New changeset e226e83d36dfc7220d836fb7a249ce18e70cb4a6 by Steve Dower in branch 'master': bpo-37363: Add audit events on startup for the run commands (GH-14524) https://github.com/python/cpython/commit/e226e83d36dfc7220d836fb7a249ce

[issue37390] Generate table of audit events for docs

2019-07-01 Thread Steve Dower
Steve Dower added the comment: I can't repro this. It looks like Doc/makefile#L196 passes -Ea which ought to deal with any old files (and it certainly does on my Ubuntu machine), so it's likely not that. The table contents is simply not in the file on docs.p.o, so I guess there&#x

[issue37363] Additional PEP578 hooks

2019-07-01 Thread Steve Dower
Steve Dower added the comment: All that's left here right now is some xmlrpc events, unless we can think of any more stdlib modules that should have them? -- ___ Python tracker <https://bugs.python.org/is

[issue37481] Deprecate bdist_wininst: use bdist_wheel instead

2019-07-02 Thread Steve Dower
Steve Dower added the comment: For the record, I am 100% in favor of deprecating and removing bdist_wininst and bdist_msi from distutils as soon as possible, as they are maintenance burdens and bdist_wininst in particular often attracts AV false positives. setuptools is welcome to either do

[issue37490] poor documentation for .startswith, .endswith

2019-07-03 Thread Steve Holden
Steve Holden added the comment: "Is the same as" is a little misleading - "gives the same result as" would be better, since there is little doubt actually slicing the subject strings would be massively less efficient in looping contexts. The re module offers the start

[issue35605] backported patch requires new sphinx, minimum sphinx version was not bumped

2019-07-03 Thread Steve Dower
Steve Dower added the comment: Your PR is against 3.6 - is that intentional? -- resolution: fixed -> stage: resolved -> status: closed -> open ___ Python tracker <https://bugs.python.or

[issue37505] Early auditing broken

2019-07-05 Thread Steve Dower
Steve Dower added the comment: Yeah, at some point we had to add an initialization check to the audit calls because of the tuple, so it essentially became a subinterpreter event but not the main one. But I thought the dtrace call happened before that check? Looking through the linked

[issue37506] os.mkdir creates invalid folder when path string has trailing space and slash

2019-07-05 Thread Steve Dower
Steve Dower added the comment: Yeah, I'd rather not do this level of validation in Python. If Windows decides to reject or automatically correct this, fine, but Python is just being a thin layer over the operating system here. We shouldn't try and prevent things that the

[issue37369] Issue with pip in venv on Powershell in Windows

2019-07-05 Thread Steve Dower
Steve Dower added the comment: > I'm pretty sure there is code in the wild that expects / > python.exe to be the Python executable (when you're not in a virtual > environment) ... for example, when getting > sys.prefix from the registry (um, I don't think that&#

[issue36085] Enable better DLL resolution

2019-07-07 Thread Steve Dower
Steve Dower added the comment: Heh, and I was so sure I'd copy pasted the right number after getting it wrong so often. Just tag it against this bug. -- ___ Python tracker <https://bugs.python.org/is

[issue37390] Generate table of audit events for docs

2019-07-09 Thread Steve Dower
Steve Dower added the comment: Anyone from the docs team have any ideas here? We're going to present on this at EuroPython tomorrow and it'd be great to be able to point people at the docs. -- ___ Python tracker <https://bu

[issue37517] Improve error messages for Windows reserved file names

2019-07-09 Thread Steve Dower
Steve Dower added the comment: Presumably this is linked to issue37515 (why not just repurpose that one?), but I'm inclined to think this is okay provided: * if the operation succeeds, no error/message is displayed * if the operation fails, we only update the error message if one o

[issue37505] Early auditing broken

2019-07-09 Thread Steve Dower
Steve Dower added the comment: Passing a NULL format string there means the same as passing NULL to PyObject_CallFunction(func, NULL) - no arguments, which results in an empty tuple being passed to the hooks. Perhaps in the early cases we can pass NULL instead of a tuple? Maybe even assert

[issue37556] Launcher help does not mention configuration options

2019-07-10 Thread Steve Barnes
New submission from Steve Barnes : py[w] --help on Windows launchers do not currently mention the options to configure versions used - just state latest. This leads some people to struggle with things like testing beta versions, etc. as they end up defaulting to the beta which is undesirable

[issue37556] Launcher help does not mention configuration options

2019-07-10 Thread Steve Barnes
Change by Steve Barnes : -- keywords: +patch pull_requests: +14500 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14701 ___ Python tracker <https://bugs.python.org/issu

[issue37587] JSON loads performance improvement for long strings

2019-07-14 Thread Steve Dower
Change by Steve Dower : -- nosy: +steve.dower ___ Python tracker <https://bugs.python.org/issue37587> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue18049] Re-enable threading test on macOS

2019-07-14 Thread Steve Dower
Steve Dower added the comment: I believe this is acceptable to include in 3.8, provided it makes sense for 3.9, so I added the backport tag on the PR. That said, I'm not making any comment on whether it's appropriate at all :) For Windows we found some ways to reduce the stac

[issue36261] email examples should not gratuitously mess with preamble

2019-07-14 Thread Steve Dower
Change by Steve Dower : -- versions: +Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue36261> ___ ___ Python-bugs-list mailing list Unsub

[issue36261] email examples should not gratuitously mess with preamble

2019-07-14 Thread Steve Dower
Steve Dower added the comment: New changeset 8efade91b12a13102a09a3856179021e579da5e9 by Steve Dower (Carl Bordum Hansen) in branch 'master': bpo-36261: Improve example of the preamble field in email docs (GH-14751) https://github.com/python/cpyt

[issue36261] email examples should not gratuitously mess with preamble

2019-07-14 Thread Steve Dower
Steve Dower added the comment: Merged, and I am assuming the backports will merge fine too. Thanks for the patch! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bug

[issue37571] Incorrect use of c_char_p in example code

2019-07-14 Thread Steve Dower
Steve Dower added the comment: New changeset 6b929580eb018cfef386db7f7f66b3a58532eada by Steve Dower (Michele Angrisano) in branch 'master': bpo-37571: Add 'b' to prevent the TypeError exception. (GH-14721) https://github.com/python/cpython/commit/6b929580eb018cfef386

[issue37571] Incorrect use of c_char_p in example code

2019-07-14 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +14559 pull_request: https://github.com/python/cpython/pull/14764 ___ Python tracker <https://bugs.python.org/issue37

[issue37571] Incorrect use of c_char_p in example code

2019-07-14 Thread Steve Dower
Steve Dower added the comment: New changeset 68c74d05c1fdaf59d8711431884af975ac2ac5f8 by Steve Dower in branch 'master': bpo-37571: Remove extra space in ctypes docs (GH14764) https://github.com/python/cpython/commit/68c74d05c1fdaf59d8711431884af9

[issue37571] Incorrect use of c_char_p in example code

2019-07-14 Thread Steve Dower
Steve Dower added the comment: Thanks for the patch! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37590] Remove redundant docs of PyEval_EvalFrameEx

2019-07-14 Thread Steve Dower
Steve Dower added the comment: I agree. This isn't important information for the documentation anyway. -- nosy: +steve.dower versions: +Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/is

[issue37553] SendfileUsingSendTest tests timeout too short for Windows ARM32

2019-07-14 Thread Steve Dower
Steve Dower added the comment: New changeset 52c8c090870c4e45dc48d1991d7ef7de2e40b2a8 by Steve Dower (Paul Monson) in branch 'master': bpo-37553: SendfileUsingSendTest tests timeout too short for Windows ARM32 (GH-14716) https://github.com/python/cpyt

[issue36044] PROFILE_TASK for PGO build is not a good workload

2019-07-14 Thread Steve Dower
Steve Dower added the comment: Looking at PR 14702, I would much rather update what `-m test --pgo` does than make this exclusive to Makefile. Back when we added the --pgo flag, the intent was always to move toward an equivalently good profile, but for practical reasons we settled at the

[issue37590] Remove redundant docs of PyEval_EvalFrameEx

2019-07-14 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37590] Remove redundant docs of PyEval_EvalFrameEx

2019-07-14 Thread Steve Dower
Steve Dower added the comment: New changeset 7a430109b983806c57babf229c60d0245d0b541c by Steve Dower (Miss Islington (bot)) in branch '3.8': bpo-37590: Remove redundant docs of PyEval_EvalFrameEx (GH-14765) https://github.com/python/cpython/commit/7a430109b983806c57babf229c60d0

[issue37590] Remove redundant docs of PyEval_EvalFrameEx

2019-07-14 Thread Steve Dower
Steve Dower added the comment: The commit to master succeeded, but we missed the bpo number in the message, which is why it didn't appear here. -- ___ Python tracker <https://bugs.python.org/is

[issue22121] Start IDLE from icon in a better place.

2019-07-14 Thread Steve Dower
Steve Dower added the comment: > Steve, there is a problem in both lines of this suggestion. The only problem is that you ran from your own build. Once running from an installed layout (which you can now easily generate with `python.bat PC\layout --preset-default --copy `), the compari

[issue22121] Start IDLE from icon in a better place.

2019-07-14 Thread Steve Dower
Steve Dower added the comment: > NameError: name 'get_default_location' is not defined Also, this was a hypothetical function that you would implement in IDLE to determine whatever the default location ought to be. I'm personally happy to stay out of that pa

[issue37597] audit event table breaks PDF sphinx build

2019-07-16 Thread Steve Dower
Steve Dower added the comment: Guess we need a real Sphinx expert to help out here. Somehow we need to get explicit backlinks, but I couldn't figure out how to resolve them normally through an extension. If we can do that, this will probably go

[issue37587] JSON loads performance improvement for long strings

2019-07-23 Thread Steve Dower
Steve Dower added the comment: Marco has a newer patch with better performance that we came up with at the sprints, but apparently it hasn't been pushed yet. Hopefully he'll get that up soon and we can review it instead - the current PR wasn't as reliably good as initial te

[issue30237] Access violation due to CancelSynchronousIo of console read

2019-07-23 Thread Steve Dower
Steve Dower added the comment: Yep, thanks for the ping! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue31546] PyOS_InputHook is not called when waiting for input() in Windows

2019-07-23 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37664] Update bundled pip and setuptools

2019-07-23 Thread Steve Dower
New submission from Steve Dower : Can we have a newer bundled version of pip for 3.8/3.9? In particular, I'd really like to be able to use the new location for a pip.ini inside of sys.prefix, as it will fix the problems with "python3 -m pip" on Windows when obtained from th

[issue37664] Update bundled pip and setuptools

2019-07-24 Thread Steve Dower
Steve Dower added the comment: Oh that's a nasty issue... but it sounds like you're reaching some kind of agreement. 3.8b3 is scheduled for this week, so perhaps we can take the current release for now and then update it when you make the next release? (Also Pradyun, would you

[issue37659] subprocess.list2cmdline() should not escape wrapping single/double quotes

2019-07-24 Thread Steve Dower
Steve Dower added the comment: Maybe we need to finally make shlex.split() at least be consistent with list2cmdline() on Windows so it can round-trip, perhaps with a "windows=True" parameter. I don't think it's unreasonable to aim for round-tripability. That is

[issue37664] Update bundled pip and setuptools

2019-07-24 Thread Steve Dower
Steve Dower added the comment: New changeset 5380def8269b24a8a3bc46396373a1dc91b1dd1a by Steve Dower (Pradyun Gedam) in branch 'master': bpo-37664: Update bundled pip to 19.2.1 and setuptools to 41.0.1 (GH-14934) https://github.com/python/cpyt

[issue37664] Update bundled pip and setuptools

2019-07-24 Thread Steve Dower
Steve Dower added the comment: Leaving this open until 3.8b4 in case we want to take another update. -- ___ Python tracker <https://bugs.python.org/issue37

[issue37672] Switch Windows Store package to use pip.ini for user mode

2019-07-24 Thread Steve Dower
New submission from Steve Dower : Currently we set PIP_USER environment variable in the pip.exe redirector, which is not ideal. Now that we have the latest release of pip, we can use a pip.ini file to set the option by default. -- assignee: steve.dower components: Windows messages

[issue37672] Switch Windows Store package to use pip.ini for user mode

2019-07-24 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +14711 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14939 ___ Python tracker <https://bugs.python.org/issu

[issue37672] Switch Windows Store package to use pip.ini for user mode

2019-07-24 Thread Steve Dower
Steve Dower added the comment: New changeset 123536fdab7b8def15c859aa70232bc55ec73096 by Steve Dower in branch 'master': bpo-37672: Switch Windows Store package to use pip.ini for user mode (GH-14939) https://github.com/python/cpython/commit/123536fdab7b8def15c859aa70232b

[issue37672] Switch Windows Store package to use pip.ini for user mode

2019-07-24 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue37679] test_with_pip fails on FreeBSD 10 bot

2019-07-25 Thread Steve Dower
Steve Dower added the comment: Guessing this is a new warning in pip? Can we just disable the cache explicitly for these tests? Or should we reconfigure the buildbot to suppress the warning. -- nosy: +Marcus.Smith, dstufft, ncoghlan, paul.moore, pradyunsg, steve.dower

[issue37641] Embeddable distribution pyc filenames show build machine location

2019-07-25 Thread Steve Dower
Steve Dower added the comment: New changeset c4cda4369f4b8f33082890d16dfc364a90658ef6 by Steve Dower (Bill Collins) in branch 'master': bpo-37641 preserve relative file location in embeddable zip (GH-14884) https://github.com/python/cpython/commit/c4cda4369f4b8f33082890d16dfc36

[issue37679] test_with_pip fails on FreeBSD 10 bot

2019-07-26 Thread Steve Dower
Steve Dower added the comment: Could you please nosy yourself on the other issue and help us address it then? The only change was upgrading pip, and the error is just a new warning message, but unless someone knows how bad it is then we'll "fix" it by ignori

[issue37664] Update bundled pip and setuptools

2019-07-26 Thread Steve Dower
Steve Dower added the comment: Actually, we're already ignoring this message, but now it includes "WARNING: " at the start and doesn't match the existing regex. So we can just continue to ignore it. -- ___ Python tracker <

[issue37664] Update bundled pip and setuptools

2019-07-26 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +14728 pull_request: https://github.com/python/cpython/pull/14960 ___ Python tracker <https://bugs.python.org/issue37

[issue37664] Update bundled pip and setuptools

2019-07-26 Thread Steve Dower
Steve Dower added the comment: New changeset b1eb20e68e30c8ab128f9d63d622f0a8b49dcf34 by Steve Dower in branch 'master': bpo-37664: Update regex for ignoring cache warning on some buildbots (GH-14960) https://github.com/python/cpython/commit/b1eb20e68e30c8ab128f9d63d622f0

[issue37664] Update bundled pip and setuptools

2019-07-26 Thread Steve Dower
Steve Dower added the comment: Hey Ned, would you like a bundled pip update for 3.7? We haven't gone that far back. -- nosy: +ned.deily ___ Python tracker <https://bugs.python.org/is

[issue36529] Python from WindowsStore: can't install package using "-m pip"

2019-07-26 Thread Steve Dower
Steve Dower added the comment: Resolved by issue37672 (because I didn't find this issue when I was looking for it, so I created a new one) -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Switch Windows Store package to use pip.

[issue32409] venv activate.bat is UTF-8 encoded but uses current console codepage

2019-07-26 Thread Steve Dower
Steve Dower added the comment: This appears to be completely resolved now, but if it's not, please ping with the details and we'll reopen. -- stage: patch review -> resolved status: open -> closed ___ Python tracker <http

[issue12989] Consistently handle path separator in Py_GetPath on Windows

2019-07-26 Thread Steve Dower
Steve Dower added the comment: This code has been significantly rewritten since this bug, and I believe it's no longer an issue. -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python t

[issue34011] Default preference not given to venv DLL's

2019-07-26 Thread Steve Dower
Change by Steve Dower : -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.org/issue34011> ___ ___ Pyth

[issue35524] using/windows launcher image might be deprecated

2019-07-26 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +14734 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14966 ___ Python tracker <https://bugs.python.org/issu

[issue35524] using/windows launcher image might be deprecated

2019-07-26 Thread Steve Dower
Steve Dower added the comment: I made a fake 3.8.0 installer and made the screenshot, so we'll only backport it to 3.8. I think 3.7 is fine with what it has. -- versions: +Python 3.8, Python 3.9 -Python 3.7 ___ Python tracker &

[issue35524] using/windows launcher image might be deprecated

2019-07-26 Thread Steve Dower
Steve Dower added the comment: New changeset 9d9893a1c85e07f7369c848acb0aed3b8fe6c3af by Steve Dower in branch 'master': bpo-35524: Update Windows installer image in docs (GH-14966) https://github.com/python/cpython/commit/9d9893a1c85e07f7369c848acb0aed

[issue35524] using/windows launcher image might be deprecated

2019-07-26 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +14738 pull_request: https://github.com/python/cpython/pull/14969 ___ Python tracker <https://bugs.python.org/issue35

[issue35524] using/windows launcher image might be deprecated

2019-07-26 Thread Steve Dower
Steve Dower added the comment: New changeset 886e66d111b6b865e582d8cc7974d5c0b398da99 by Steve Dower in branch '3.8': bpo-35524: Update Windows installer image in docs (GH-14966) https://github.com/python/cpython/commit/886e66d111b6b865e582d8cc7974d5

[issue35524] using/windows launcher image might be deprecated

2019-07-26 Thread Steve Dower
Change by Steve Dower : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32910] venv: Deactivate.ps1 is not created when Activate.ps1 was used

2019-07-26 Thread Steve Dower
Steve Dower added the comment: New changeset 91e49575095ca16d1b67dd8822deeb7885e421da by Steve Dower (Derek Keeler) in branch 'master': bpo-32910: Remove implementation detail in venv documentation. (GH-14968) https://github.com/python/cpython/commit/91e49575095ca16d1b67dd8822deeb

[issue36044] PROFILE_TASK for PGO build is not a good workload

2019-07-27 Thread Steve Dower
Steve Dower added the comment: I just ran this on Windows and noticed that there is no data for _msi.pyd, winsound.pyd or _sqlite3.pyd. The first two don't matter - we should just suppress PGO on those projects to avoid the warnings (add a false property). That's a note to myse

[issue36044] PROFILE_TASK for PGO build is not a good workload

2019-07-27 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +14753 pull_request: https://github.com/python/cpython/pull/14985 ___ Python tracker <https://bugs.python.org/issue36

[issue36044] PROFILE_TASK for PGO build is not a good workload

2019-07-27 Thread Steve Dower
Steve Dower added the comment: I also added test_bz2 and test_lzma into the PGO profile, as the extension modules for those on Windows were barely being covered (they get imported, apparently, but that seems to be it). -- ___ Python tracker

[issue36044] PROFILE_TASK for PGO build is not a good workload

2019-07-29 Thread Steve Dower
Steve Dower added the comment: > What matters there is compiling the underlying lzma, bz2, and sqlite3 > libraries with PGO. that isn't done as part of our build system. On Windows they are linked in as source files, which is why it matters for us. On platforms where we rel

[issue36044] PROFILE_TASK for PGO build is not a good workload

2019-07-29 Thread Steve Dower
Steve Dower added the comment: Thanks for approving my PR, Greg! -- ___ Python tracker <https://bugs.python.org/issue36044> ___ ___ Python-bugs-list mailin

[issue37549] os.dup() fails for standard streams on Windows 7

2019-07-29 Thread Steve Dower
Steve Dower added the comment: > What 3.7.3 does is to skip calling _Py_set_inheritable for all files of type > FILE_TYPE_CHAR It sounds like we should probably revert to the middle ground, and skip _raising the error_ if _Py_set_inheritable for files of type FILE_TYPE_CHAR. As

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

2019-07-29 Thread Steve Dower
Steve Dower added the comment: I just chatted with Derek about this, and while we identified some potential regressions (previously we were injecting str(prompt) into Activate.ps1, and now we're showing repr(prompt)), I don't think they're widely used. For example, if you

[issue37587] JSON loads performance improvement for long strings

2019-07-30 Thread Steve Dower
Steve Dower added the comment: While you're testing patches, can you try this version too? Py_UCS4 c = 0, minc = 0x20; for (next = end; next < len; next++) { c = PyUnicode_READ(kind, buf, next); if (c == '"' || c == '

[issue37587] JSON loads performance improvement for long strings

2019-07-30 Thread Steve Dower
Steve Dower added the comment: Oh, we also need to capture "next"... but then again, since the success case is far more common, I'd be okay with scanning again to find it. -- ___ Python tracker <https://bugs.pyt

[issue36670] test suite broken due to cpu usage feature on win 10/ german

2019-07-30 Thread Steve Dower
Change by Steve Dower : -- stage: -> needs patch versions: +Python 3.8, Python 3.9 ___ Python tracker <https://bugs.python.org/issue36670> ___ ___ Python-

[issue37587] JSON loads performance improvement for long strings

2019-07-30 Thread Steve Dower
Steve Dower added the comment: > compiler stores the `c` to stack every time The disassembly we looked at didn't do this, so it may just be certain compilers. Perhaps we can actually use the register keyword to help them out? :) Here's a slightly altered one that doesn't

[issue37734] Registry keys for Windows Store package have wrong executable

2019-07-31 Thread Steve Dower
New submission from Steve Dower : The next update to Windows will prevent launching executables from within the package install folder, and require you to launch from the user's local symlink to the executable (see issue37369). Currently, the only value we can put into the registry

<    23   24   25   26   27   28   29   30   31   32   >