New submission from Steve Dower :
In future releases, we won't be advertising the web-based installers anymore.
They never got much use, and the shorter list of downloads will be more
beneficial to users than saving 10-20MB worth of bandwidth. The web site change
has already been made
Steve Dower added the comment:
This looks like the smallest change I can make to fix it:
diff --git a/Include/internal/pycore_pystate.h
b/Include/internal/pycore_pystate.h
index 0cd5550cfd..9ff740b87b 100644
--- a/Include/internal/pycore_pystate.h
+++ b/Include/internal/pycore_pystate.h
Change by Steve Dower :
--
keywords: +patch
pull_requests: +22168
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23271
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +22167
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23271
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
pull_requests: -22167
___
Python tracker
<https://bugs.python.org/issue42339>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 9b6934230c35e24d8582ea8c58456fa8eab72ae2 by Steve Dower in branch
'master':
bpo-40754: Adds _testinternalcapi to Windows installer for test suite (GH-23271)
https://github.com/python/cpython/commit/9b6934230c35e24d8582ea8c58456f
Steve Dower added the comment:
Sorry about the PR mess - copied the wrong issue number down, though I am
looking at this one right now.
My suspicion is something in the newer vcruntime140_1.dll is to blame - does it
work with Python 3.9?
You might need to update to KB3118401 [1], though I
Change by Steve Dower :
--
assignee: -> steve.dower
nosy: -miss-islington
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Change by Steve Dower :
--
keywords: +patch
pull_requests: +22171
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23275
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I hope you'll find that PR suitable ambitious :)
It would really be nice to have proper Powershell scripts for these, but that
would be a more significant rewrite (and probably require changing argument
names...). I'm not *that*
Steve Dower added the comment:
We can backport it, but the latest version always wins. I deliberately designed
the installer (which has multiple embedded MSIs in it) to make sure this
worked, so that earlier versions won't overwrite the launcher (anymore).
Besides, this is a purely cos
Steve Dower added the comment:
It's cosmetic in the sense that it *only* affect usability, and not correctness.
If it had no impact at all, I'd be calling it "pointless" ;)
--
___
Python tracker
<https://bug
Change by Steve Dower :
--
pull_requests: +22214
pull_request: https://github.com/python/cpython/pull/23322
___
Python tracker
<https://bugs.python.org/issue42
Steve Dower added the comment:
New changeset fa86614078f1f700f350f98486dddf83587ab69e by Steve Dower in branch
'3.8':
bpo-42339: Adds note about KB2533623 to embeddable package docs (GH-23322)
https://github.com/python/cpython/commit/fa86614078f1f700f350f98486dddf
Steve Dower added the comment:
I added a note to the 3.8 docs.
Pretty sure there's another open issue about improving FormatMessage, and if
not, one can be opened.
Thanks for the report, Jelle, and for helping us figure it out!
--
components: +Documentation
resolution: -&g
Steve Dower added the comment:
New changeset f62dad16b8e540486a0a0fed41e723d36986f860 by Zackery Spytz in
branch 'master':
bpo-38506: Fix the Windows py.exe launcher's misordering of 3.10 (GH-18307)
https://github.com/python/cpython/commit/f62dad16b8e540486a0a0fed4
Steve Dower added the comment:
Just left a blocking review on the PR - I don't want to rely on the shell being
able to use an already open file.
There's at least one other issue about making NamedTemporaryFile work for this
case. Once that is done, this can be ma
Steve Dower added the comment:
Thanks for the patch, Zackery!
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Change by Steve Dower :
--
pull_requests: +22215
pull_request: https://github.com/python/cpython/pull/23325
___
Python tracker
<https://bugs.python.org/issue42
Change by Steve Dower :
--
keywords: +patch
pull_requests: +22216
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23326
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Turns out a straight delete is fine, as both names are defined in UCRT. I think
it's safe to backport as well, since it's only going to affect other people's
code poorly (and they'll need to recompile to see any change anyway).
Steve Dower added the comment:
New changeset 9cc9e277254023c0ca08e1a9e379fd89475ca9c2 by Steve Dower in branch
'master':
bpo-42120: Remove macro defining copysign to _copysign on Windows (GH-23326)
https://github.com/python/cpython/commit/9cc9e277254023c0ca08e1a9e379fd
Steve Dower added the comment:
New changeset 2156d964a12285280c533af1c96eb273c58451e6 by Steve Dower in branch
'master':
bpo-42336: Improve PCbuild batch files (GH-23275)
https://github.com/python/cpython/commit/2156d964a12285280c533af1c96eb2
Steve Dower added the comment:
New changeset 8b1f4cc4644869812ff7f210a7fcbe872d88846e by Steve Dower in branch
'3.8':
bpo-42336: Improve PCbuild batch files (GH-23325)
https://github.com/python/cpython/commit/8b1f4cc4644869812ff7f210a7fcbe
Change by Steve Dower :
--
pull_requests: +22266
pull_request: https://github.com/python/cpython/pull/23373
___
Python tracker
<https://bugs.python.org/issue42
Steve Dower added the comment:
Firstly, msvc9compiler.py is very deprecated, we don't touch that one at all or
use it in distutils.
Second, _msvccompiler.py is weakly deprecated (and likely soon fully
deprecated), so you'd be better to make the fix in the setuptools project
ins
Steve Dower added the comment:
Yeah, this will be our fault.
Someone is looking into automatically generating the .def file so that this
stops happening. Last time we tried that there was a lot of pushback because
"too many APIs will become stable", but this time I think we'r
Steve Dower added the comment:
There is no ARM64 release of Python for Windows right now, so unfortunately
this doesn't constitute any kind of bugfix. We don't have a buildbot, and
nobody out there has CI, so it's not a supported platform.
I get that it's easier to c
Steve Dower added the comment:
We also updated the buildbot config to use the new options.
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve McConnel :
The Python27.lib file shipped with the 64-bit Windows installer (.msi) has
several symbols with improper values. The problem appears to be a single
underscore instead of a double underscore between __imp and Py in the symbol.
Attempting to build our
Steve Dower added the comment:
I think this should be opt-in, not opt-out.
Imagine you're an existing application and you want to embed Python. Why would
you ever want it to suddenly change your global settings like this?
As a general rule, an embedded Python runtime should deal wit
New submission from Steve Dower :
This spoils the output of our test suite when there are dangling threads, as
the basic "print" doesn't show anything useful.
--
messages: 342734
nosy: steve.dower
priority: normal
severity: normal
stage: needs patch
status: open
Steve Dower added the comment:
> I have a very good news for you :-) Slowly but steadily, we converge on a
> agreement ;-)
Yay! :)
> I added 2 functions …
Nice, these will be helpful. Probably a good thing to try out with some
embedders too, to see whether they're intuiti
Steve Dower added the comment:
> * customized Python interpreter: behaves as the "regular Python"
For this, why wouldn't we say "start by copying all the code in
Programs/python.c"? Is there any reason why that file needs to only be one
single call into Py_Mai
Steve Dower added the comment:
New changeset f96e7fd9240c1ce13f52bd3ba81f58b2511d89c3 by Steve Dower (Paul
Monson) in branch 'master':
bpo-36941: Windows build changes for Windows ARM64 (GH-13365)
https://github.com/python/cpython/commit/f96e7fd9240c1ce13f52bd3ba81f58
Steve Dower added the comment:
New changeset 3ea702eca17c4ab5209d823fac2463307dde0633 by Steve Dower (Paul
Monson) in branch 'master':
bpo-36942 Windows build changes for Windows ARM64 (GH-13366)
https://github.com/python/cpython/commit/3ea702eca17c4ab5209d823fac2463
Steve Dower added the comment:
> I suggest to move this discussion on the WIP PR of 4th version of my PEP
I prefer to keep it on the issue tracker where it doesn't disappear when merged
and I get proper notifications. (I want to make the most of getting good
notifications of new
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
I've received a detailed response from the UCRT team, and there are a few
pieces here.
* the fact that tzname is cached in ACP is known and will be fixed
* the decoding bug is real, but it's due to the experimental UTF-8 support
* the experimental UTF
Steve Dower added the comment:
Is including just "winnt.h" sufficient?
It's very hard to tell which Windows headers are "public" vs "internal", but
winternl.h is certainly one of the internal ones (according to the big warn
Steve Dower added the comment:
New changeset 5ae1c84bcd13b766989fc3f1e1c851e7bd4c1faa by Steve Dower (Batuhan
Taşkaya) in branch 'master':
bpo-36949: Implement __repr__ on WeakSet (GH-13415)
https://github.com/python/cpython/commit/5ae1c84bcd13b766989fc3f1e1c851
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Some people say "windows.h" is the only one you're ever supposed to include, so
if that works best, let's go with that :)
--
___
Python tracker
<https://bug
Steve Dower added the comment:
New changeset cfb241bd29a94fd825a317a78322e3cdba0e75a7 by Steve Dower (Paul
Monson) in branch 'master':
bpo-36941: Project file fixups for Windows ARM64 (GH-13477)
https://github.com/python/cpython/commit/cfb241bd29a94fd825a317a78322e3
Steve Dower added the comment:
Is it worth also implementing if_nameindex() using (I assume) GetIfTable2Ex
[1]? Or maybe just the simpler GetIfTable is sufficient - I'm not sure exactly
what semantics Unix if_nameindex() has, whether it includes all logical
adapters.
[1]:
Steve Dower added the comment:
New changeset b82e17e626f7b1cd98aada0b1ebb65cb9f8fb184 by Steve Dower in branch
'master':
bpo-36842: Implement PEP 578 (GH-12613)
https://github.com/python/cpython/commit/b82e17e626f7b1cd98aada0b1ebb65
Steve Dower added the comment:
test_gdb failed on the Debian PGO buildbot
https://buildbot.python.org/all/#builders/47/builds/2854
I'm going to do what I can to investigate, but I may be out of my depth here!
--
stage: patch review -> commi
Steve Dower added the comment:
Is it just expecting builtin_id() to have been inlined? That seems risky.
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
Ah no, it's expecting `builtin_id (self=..., v=...)` but getting `builtin_id
()` instead.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Well, the good news is I can repro it on a PGO build in WSL. So now I just need
to go learn all about gcc's PGO build, debug info, and how gdb renders it!
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
I confirmed earlier that removing the new code from builtins_id fixes this
issue, which I suspect means that PGO is deciding to make different
optimizations and produce different output.
Other functions in the same stack also do not show their arguments, so I
Steve Dower added the comment:
New changeset 51394b8c3d42e6e6d368251ff6f0612495724fc0 by Steve Dower (Paul
Monson) in branch 'master':
bpo-36511: Ensure error code propagates out of batch files (GH-13529)
https://github.com/python/cpython/commit/51394b8c3d42e6e6d368251ff6f061
New submission from Steve Dower :
I'd like to be able to build libpython and have it already have the install
path stripped out so I can use rpath instead. This libpython is going to be
distributed with other applications.
Right now, I'm running `install_name_tool -
Steve Dower added the comment:
Okay, fixing the regex isn't an option, as most of the tests (just not the one
copy-pasted above) rely on verifying the parameter value.
I'll figure out how to skip the test on PGO build instead.
--
Change by Steve Dower :
--
keywords: +patch
pull_requests: +13466
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue37023>
___
___
Py
Steve Dower added the comment:
Since hooks can't be removed, it probably looks like a leak when some are added
for the tests.
I'll update all the tests to run in new processes.
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
New changeset 6de4574c6393b9cf8d7dfb0dc6ce53ee5b9ea841 by Steve Dower in branch
'master':
bpo-37023: Skip test_gdb under PGO (GH-13555)
https://github.com/python/cpython/commit/6de4574c6393b9cf8d7dfb0dc6ce53
Steve Dower added the comment:
Test is now skipped if PGO was used.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 9ddc416e9f6635376312c3615193f19480ac772a by Steve Dower in branch
'master':
bpo-36842: Fix reference leak in tests by running out-of-proc (GH-13556)
https://github.com/python/cpython/commit/9ddc416e9f6635376312c3615193f1
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Great, thanks Zackery! (And thanks for the ping - I don't notice GitHub
notifications.)
Had a few comments about error handling, but it looks great.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
I don't think we can change the assumption that sys.prefix is in sys.path at
this point, though technically it's not required (certainly not in 3.7).
Maybe we could create a new marker file that means "never treat this directory
as a na
Steve Dower added the comment:
New changeset 8f96c9f8ed2a4795e34b333411451e24f28f74d2 by Steve Dower (Zackery
Spytz) in branch 'master':
bpo-37007: Implement socket.if_nametoindex(), if_indextoname() and
if_nameindex() on Windows (GH-13522)
https://github.com/python/cpyt
Steve Dower added the comment:
Honestly, no idea. Because it always has been :)
If you can find when it was added, we may be able to answer that.
--
___
Python tracker
<https://bugs.python.org/issue37
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset c8d5bf6c3fa09b43f6a5ee779d493d251dbcc53c by Steve Dower (Zackery
Spytz) in branch 'master':
bpo-12639: msilib.Directory.start_component() fails if *keyfile* is not None
(GH-13688)
https://github.com/python/cpyt
Steve Dower added the comment:
Thanks, Zackery!
The backports are running CI now and should merge if everything passes.
--
stage: patch review -> backport needed
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Looks like the tests need to be customized for 2.7 and 3.6:
Traceback (most recent call last):
File "D:\a\1\s\lib\test\test_msilib.py", line 64, in
test_directory_start_component_keyfile
self.addCleanup(db.Close)
AttributeError: '_msi.Datab
Change by Steve Dower :
--
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset bfc1f605609218b9734d3cf3eab3531a2f4624e1 by Steve Dower (Miss
Islington (bot)) in branch '2.7':
[2.7] bpo-12639: msilib.Directory.start_component() fails if *keyfile* is not
None (GH-13688)
https://github.com/python/cpyt
Steve Dower added the comment:
I agree with Paul. Consistency with open() is the most important aspect here,
and when we investigated changing that to UTF-8 it was decided to be too
disruptive.
That said, I'm not opposed to adding encoding/errors to basicConfig if someone
wants to do
Steve Dower added the comment:
I have no idea. I don't ever use msilib, but there are a few people who do that
don't have any way to get bugs fixed, so I'll help merge.
If it's just the test leak, probably it's in the test. I don't recall the
change having any
Change by Steve Dower :
--
pull_requests: +13698
pull_request: https://github.com/python/cpython/pull/13812
___
Python tracker
<https://bugs.python.org/issue36
Change by Steve Dower :
--
pull_requests: +13701
pull_request: https://github.com/python/cpython/pull/13815
___
Python tracker
<https://bugs.python.org/issue36
Steve Dower added the comment:
New changeset f61599b050c621386a3fc6bc480359e2d3bb93de by Steve Dower in branch
'2.7':
bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812)
https://github.com/python/cpython/commit/f61599b050c621386a3fc6bc480359
New submission from Steve Dower :
Mostly a note to self to fix the tag. Right now the x64 build gets an extra
suffix, which is incorrect and causes installer builds to fail.
--
assignee: steve.dower
components: Windows
messages: 344638
nosy: paul.moore, steve.dower, tim.golden
Steve Dower added the comment:
The reason I'd prefer sys.platform in most cases is because it's a compile-time
constant, based on the one that includes/excludes APIs near completely, and
most of our tests ought to be switching on these.
I personally don't see any need to sw
Steve Dower added the comment:
> How does select() know the FD_SETSIZE?
It doesn't have to. The actual number of descriptors is passed in, and the API
presumably assumes that FD_SETSIZE is bigger than that (or else the caller
would have crashed writing to invalid memory).
I don&#
Steve Dower added the comment:
There are certainly people relying on sys.prefix being in sys.path (for .pth
files and embedding), but probably not so many that we couldn't remove it in a
major release. It is a bit strange in a venv, where there's typically nothing
in the r
Steve Dower added the comment:
> So it's really FD_SETSIZE that matters, and it's a compile-time constant.
The only way this constant can matter is if the array has to end with an empty
slot, which doesn't appear to be the case. The pre-compiled function can't tell
ho
Change by Steve Dower :
--
keywords: +patch
pull_requests: +13742
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/13866
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset e0c0c7e8c9f8153a54b92e43aa3d09e69a9fd0c0 by Steve Dower in branch
'master':
bpo-37156: Fix libssl DLL tag in MSI sources (GH-13866)
https://github.com/python/cpython/commit/e0c0c7e8c9f8153a54b92e43aa3d09
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Changing our policy here (from "no policy" to "here's a recommendation")
probably deserves a python-dev discussion first.
--
___
Python tracker
<https:
New submission from Steve Dower :
New changeset e7e5039d6940e41839dcef0433262ff363408dad by Steve Dower (Paul
Monson) in branch 'master':
bpo-37181: Fix test_regrtest failures on Windows arm64 (GH-13872)
https://github.com/python/cpython/commit/e7e5039d6940e41839dcef0433262f
Steve Dower added the comment:
Guessing Victor may have touched something in this area.
Was it exported before? Or did we just have a macro for it? Maybe the macro was
moved to an internal header by mistake?
--
nosy: +vstinner
___
Python tracker
Steve Dower added the comment:
This is due to how the pip.exe launcher is generated, which is part of pip
itself (actually distlib, I think, but someone over there can redirect).
Please report this at https://github.com/pypa/pip
--
resolution: -> third party
stage: -> re
Steve Dower added the comment:
I'm with Petr here. ensurepip/venv should only go as far as we support, which
is the version of the wheels included in our bundle. We should continue having
the stdlib pretend that PyPI doesn't exist.
External network access would justify the longer
Steve Dower added the comment:
This is intended behavior.
When a variable has an assignment anywhere in a function, it becomes a local.
Once a local variable exists, it will shadow the non-local variable.
So by having the "n =", you are marking "n" as a local variab
Steve Dower added the comment:
New changeset 04856c2193eb72d72c46b57fa08095235d732a73 by Steve Dower (Paul
Monson) in branch 'master':
bpo-37238: Enable building for Windows using Visual Studio 2019 (GH-13988)
https://github.com/python/cpython/commit/04856c2193eb72d72c46b57fa08095
Steve Dower added the comment:
Not a whole lot of process, really. It's done now :)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
Steve Dower added the comment:
Why is this different from the nuget package? Should we just add more things
into that package?
--
___
Python tracker
<https://bugs.python.org/issue37
Steve Dower added the comment:
"tp_print" has been marked as reserved for all of Python 3. To me, that means
deprecated and do not use. (But perhaps that ought to have been properly
defined in the docs?)
Cython should not be using this field directly. If all they're doing is
Steve Dower added the comment:
> Jeroen Demeyer proposed PR 14009 to fix the source compatibility:
>
> #define tp_print tp_vectorcall
This is a terrible idea, FWIW. Please don't do this.
--
nosy: +ncoghlan
___
Python t
Steve Dower added the comment:
New changeset daf62627518ad97ce66a48c49496aa0573cf0731 by Steve Dower (Paul
Monson) in branch 'master':
bpo-37201: fix test_distutils failures for Windows ARM64 (GH-13902)
https://github.com/python/cpython/commit/daf62627518ad97ce66a48c49496aa
Steve Dower added the comment:
In fact, any reason you can't use "--preset-nuget --include-..."? to add in
whatever else you need? They are designed to compose like this deliberately.
--
___
Python tracker
<https://bugs.pyt
Steve Dower added the comment:
New changeset ff6bb0aa95259413f359d42410526ff0b4dccfb7 by Steve Dower (Paul
Monson) in branch 'master':
bpo-37236: pragma optimize off for _Py_c_quot on Windows arm64 (GH-13983)
https://github.com/python/cpython/commit/ff6bb0aa95259413f359d42410526f
Steve Dower added the comment:
> Any solution that we apply in Cython will require users to regenerate their
> .c sources with a new Cython version in order to make it compile in Py3.8.
> The main decision point in this ticket is: should they need to or not?
Considering Cython
2501 - 2600 of 6138 matches
Mail list logo
