Steve Dower added the comment:
(Created from issue26903)
Yeah, that looks like a reasonable fix :)
--
title: Follow on bug from https://bugs.python.org/issue26903 (ValueError
exception on _winapi.WaitForMultipleObjects) -> ValueError exception on
_winapi.WaitForMultipleObje
Change by Steve Dower :
--
pull_requests: +18851
pull_request: https://github.com/python/cpython/pull/19500
___
Python tracker
<https://bugs.python.org/issue40
Steve Dower added the comment:
> I don't understand what's going on here if %PATH% is interfering.
Yeah, as shown by the fact my fix didn't fix it :)
I'm going to try adding some more diagnostics around this to find out exactly
where it's failing. I suspect it
Steve Dower added the comment:
So I collected more info, and it seems the search order we're getting for
_sqlite3.dll (.pyd) is:
* app directory
* SQL server install directory (?)
* Windows/System32
* Windows
* %PATH% (which is truncated at 2190 chars)
And then we never look in C
Steve Dower added the comment:
Okay, I've wasted enough time on this. Let's just disable the test permanently
and say that the winmode=0 behaviour is system-specific and is not tested.
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
You mean the CI agent is doing it? Because there's nowhere in Python that
should be doing it.
I'd rather not blanket change this option in the test suite (except to turn it
on :) ), so that code snippet probably needs to shrink down into a one-liner
Steve Dower added the comment:
If it's easy to set up, it might be interesting to see if there's a difference
if (e.g.) all interned strings are marked as immortal, or all small ints. Or
type objects. Maybe set a flag during initialization and treat everything
created befo
Steve Dower added the comment:
> There is a trend right now to try to remove immortal objects (started by
> Victor and others) like static types and transforming them to heap types.
This isn't actually about removing immortal objects, but removing *mutable*
objects that woul
Steve Dower added the comment:
>> This isn't actually about removing immortal objects, but removing *mutable*
>> objects that would be shared between subinterpreters. Making some objects
>> immortal, such as interned strings or stateless singletons, would actually
>&g
Change by Steve Dower :
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue39511>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
There hasn't been much said about which kind of objects would be immortal.
Could this be a creation-time option? Or a type object (similar to a no-op
tp_dealloc)?
If it's something that is known when the object is created, then some of the
"inf
Change by Steve Dower :
--
nosy: +dino.viehland
___
Python tracker
<https://bugs.python.org/issue40255>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Thanks, Barry!
I tweaked your NEWS entry a little, so once CI completes I'll merge and
backport.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
New changeset d42e5820631cd66ee1eab8f610d4b58f3dfdd81c by Barry in branch
'master':
bpo-40260: Update modulefinder to use io.open_code() and respect coding
comments (GH-19488)
https://github.com/python/cpython/commit/d42e5820631cd66ee1eab8f610d4b5
Steve Dower added the comment:
I agree it's worth improving the error message (and probably the docs too).
It's never made clear that relative_to only looks deeper (won't ever generate
leading ".." parts) - the closest hint in the docs is that os.path.relpath is
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
In master, we build against the latest build out of that repo, which comes from
the libffi branch (not the 3.3.0 RC).
In 3.8 (and 3.7? I forget) we use the 3.3.0 RC build. There's no later release
from libffi (last I checked), and no important fixes since
Steve Dower added the comment:
To save the clicks, here's the URL that will get the latest sources from the
libffi branch: https://github.com/python/cpython-source-deps/archive/libffi.zip
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
When we make a beta release, you can have a release artifact. Until then, if
you're building against the master branch, you can use the dependency's
"master" branch.
I've renamed the issue so it can serve as a reminder to tag whatever
Steve Dower added the comment:
Go ahead and fix it against this one.
--
resolution: fixed ->
stage: resolved -> needs patch
status: closed -> open
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Would be ideal to add a test that hits this case as well.
--
___
Python tracker
<https://bugs.python.org/issue40260>
___
___
Pytho
Steve Dower added the comment:
The 3.8 behaviour is clearly broken, so backporting is fine. Also,
io.open_code() is a security feature.
The core of the issue is that apparently load_module() is a public API, and the
file_info parameter used to be a 3-tuple and is now a 2-tuple.
AFAICT, the
Steve Dower added the comment:
Sorry, misready. They're monkeypatching the API. It isn't documented, but it's
also not clearly internal.
We don't have a strong need to change the meaning of that argument though, so
best to leave it as it was
Steve Dower added the comment:
> What problem do you have in mind that the fork server would solve?
My understanding is that the fork server solves the *general* problem of
running arbitrary code before fork by making sure that only
CPython/multiprocessing gets to run code before fork.
Steve Dower added the comment:
Presumably you have something else on your system accessing the file.
Can you try disabling any file sync, anti-malware or indexing tools and see if
that helps?
--
___
Python tracker
<https://bugs.python.
Steve Dower added the comment:
I posted a workaround right above your post for when you want to resolve
executables against PATH instead of using Windows's normal rules.
I'm not sure we reached any good approach for launching sys.executable in a
venv and automatically byp
Steve Dower added the comment:
> I would expect that the negative impact on branch predictability would easily
> outweigh the cost of the memory write (A guaranteed L1 hit)
If that were true then Spectre and Meltdown wouldn't have been so interesting :)
Pipelining processors a
Steve Dower added the comment:
Thanks! I deleted the NEWS file (we've already got one for this issue in this
release) and skipped the check instead. Once CI passes, I'll merge it.
--
___
Python tracker
<https://bugs.python.o
Steve Dower added the comment:
> But micro-benchmarks may tell you things which are not true in the real-world
> (for example an easily-predicted branch)
This is true, though this branch should be more easily predictable because
INCREF/DECREF are inlined. If there were only one fu
Steve Dower added the comment:
New changeset 9b0b5d2baebd0b6a545317200c313a6a7408731e by Barry in branch
'master':
bpo-40260: Revert breaking changes made in modulefinder (GH-19595)
https://github.com/python/cpython/commit/9b0b5d2baebd0b6a545317200c313a
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
That'll teach me for being so quick on this...
Are we even impacted by the issue though? I don't see any calls to
SSL_check_chain() in our code or the SSL sources.
Advisory: https://www.openssl.org/news/secadv/20200421.txt
Full diff:
https://
Change by Steve Dower :
--
pull_requests: +18978
pull_request: https://github.com/python/cpython/pull/19652
___
Python tracker
<https://bugs.python.org/issue40
Steve Dower added the comment:
New changeset 9b498939009f49b8c772c89e8fc80efbfd8afcb5 by Steve Dower in branch
'master':
bpo-40214: Fix ctypes WinDLL test with insecure flags (GH-19652)
https://github.com/python/cpython/commit/9b498939009f49b8c772c89e8fc80e
Steve Dower added the comment:
Looks like that fix has done it. Thanks, Eryk!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Your best bet is to repair the Python 3.7.2 install first (through Programs and
Features, if possible), and then uninstall it.
Any idea why it's interfering with Python 3.8? That shouldn't be the case
(unless it's PATH related, in which case ye
Steve Dower added the comment:
If we want to be strictly correct here, the fix should check the "mode"
variable to determine the type. And given the fragility of the code being used
here, there's no doubt some reliance on a trailing newline somewhere too.
I haven't bumpe
Steve Dower added the comment:
Okay, no problems then.
We'll have to close that other PR now. Too bad nobody noticed it (or
knew where to send it - I doubt modulefinder has an obvious owner).
--
___
Python tracker
<https://bugs.py
Steve Dower added the comment:
New changeset 39652cd8bdf7c82b7c6055089a4ed90ee546a448 by Anthony Sottile in
branch 'master':
bpo-40260: Remove unnecessary newline in compile() call (GH-19641)
https://github.com/python/cpython/commit/39652cd8bdf7c82b7c6055089a4ed9
Steve Dower added the comment:
You're welcome! We're all involved - apart from a little bit of startup code,
it's exactly the same as the regular install.
Right now, I'd say you have a case that needs the regular installer, in order
to avoid the appdata redirection.
As
Steve Dower added the comment:
Thanks for including logs!
It looks like pip ran into an issue during install:
C:\Users\\AppData\Local\Temp\tmpppkvx8p2\pip-19.2.3-py2.py3-none-any.whl\pip\_vendor\ipaddress.py:1106:
SyntaxWarning: 'str' object is not callable; perhaps you missed
Steve Dower added the comment:
As a secondary issue, why didn't the installer fail on the pip failure? Did we
decide at some point not to fail the whole thing just because of pip? (It's
probably the most unreliable part, as it's a custom action rather than simpl
Steve Dower added the comment:
Yes, the only thing that should be in your Scripts folder after install is pip.
Python itself never puts anything there - it's for other things that you may
install.
Could you try running these environment commands and then try installing pip
again?
Steve Dower added the comment:
Bugs in Python should continue to be reported here.
Requests to change the workflow should be discussed on one of the core-workflow
groups (I think Discourse is the primary one now, right?). Once an action is
agreed upon, it gets tracked on the core-workflow
Steve Dower added the comment:
Oh, and Victor, you should probably email python-dev to let everyone know you
requested this change and it's been made. Otherwise people may be surprised
that it changed without any discussion or notification.
This is especially important if we have to di
New submission from Steve Dower :
The Windows CI machines on Azure Pipelines run additional tests to check an
"installed" layout and with the UWP entry point that's used for the Windows
Store package.
These tests have been failing intermittently (though regularly) with a
Steve Dower added the comment:
> FWIW, I took a quick look at it and, with nothing to go on in the way of
> visible messages, the best guess I could come up with is that the test run
> step is hitting a time out and that, in that case, no status is shown. Anyone
> know
Steve Dower added the comment:
> I'm not sure of what you mean by "no discussion", this issue has many
> comments.
Let's say, no consensus. There were three votes cast in this discussion - yours
(+1), mine (-1) and Brett's (I'll assume +0 because he
Steve Dower added the comment:
New changeset 831d58d7865cb98fa09227dc614f4f3ce6af968b by Shantanu in branch
'master':
bpo-39691: Clarify io.open_code behavior (GH-19824)
https://github.com/python/cpython/commit/831d58d7865cb98fa09227dc614f4f
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
keywords: +patch
pull_requests: +19163
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/19845
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Turns out the stack reservation was different, which is why it was crashing.
As part of diagnosing it, I added the recursion count to faulthandler's output
on Windows, but couldn't see if/where to do it for other platforms - Victor,
any s
Steve Dower added the comment:
Also, it was really test_bad_getattr that was crashing.
--
title: test_attribute_name_interning crashes on APPX test -> test_bad_getattr
crashes on APPX test
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I assume the Bootcamp side of this is irrelevant and it's just an issue with
Windows.
Yusuf, can you open Powershell and run "py" on its own?
If you've been going there and running "python" and you didn't select to update
P
Steve Dower added the comment:
Yeah, I already got that part. If you check the PR, I added some better
diagnostics to faulthandler for this case, but I don't see where I can add it
for other platforms?
--
___
Python tracker
&
New submission from Steve Dower :
The uuid module uses ctypes to try and load likely system libraries to provide
some functionality of the uuid module.
This is a security risk (depending on your sensitivity to DLL hijacking), but
it also seems to be not very necessary? It would be nice to
Steve Dower added the comment:
There are three scenarios where ctypes is used in this module:
* get libuuid.uuid_generate_time_safe and uuid_generate_time (if _uuid was not
compiled)
* get rpcrt4.UuidCreateSequential (on Windows, depending on how the libuuid
lookup failed
Steve Dower added the comment:
Do you think either need a deprecation cycle? I'd say not for the Windows
change, but I'm not sure whether people could be relying on libuuid showing up
after build.
--
___
Python tracker
<https://bu
Steve Dower added the comment:
New changeset ac4bf424119d1300f57929120968e216a85d3a25 by Steve Dower in branch
'master':
bpo-40458: Increase reserved stack space to prevent overflow crash on Windows
(GH-19845)
https://github.com/python/cpython/commit/ac4bf424119d1300f57929120968e2
Steve Dower added the comment:
Merged without the improved diagnostics. I might add that later if I get time.
Łukasz - this is a fairly trivial crash fix that'd be nice (and safe) to pull
into 3.8.3, but not critical. Your call.
--
assignee: -> steve.dower
nosy: +lukasz.lan
Change by Steve Dower :
--
keywords: +patch
pull_requests: +19263
stage: test needed -> patch review
pull_request: https://github.com/python/cpython/pull/19948
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Thanks Ned.
There are some platform.version() checks in there that I'm basically ignoring
right now - are those unnecessary? Shall I clean them up too?
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Yes, it is bad behaviour, but it is very upsetting for many people to not have
the option. This is why it's disabled by default, and why I regularly
discourage people from selecting the option (and quite often get abused for
taking the trouble... oh
Steve Dower added the comment:
Thanks for the ping - sorry, I've been largely offline while I'm between
internet providers.
The change is fine, but I wonder whether we should document it somewhere? Most
likely in the devguide, which is in a separate repo, but perhaps a mention i
Steve Dower added the comment:
Sounds like a good opportunity for someone to make their first contribution.
Post a message if you'd like to work on this (and a test), and we can help get
through the PR process.
--
keywords: +easy, newcomer fri
Steve Dower added the comment:
New changeset d6b727e2c947240804b8e434b305ba2890122550 by Steve Dower in branch
'master':
bpo-40501: Replace ctypes code in uuid with native module (GH-19948)
https://github.com/python/cpython/commit/d6b727e2c947240804b8e434b305ba
Steve Dower added the comment:
Really, we shouldn't be using any environment variables on Windows here,
because they open up too many security risks. There are API calls that are
canonical, but the environment vars are compatibility helpers.
Breakage due to HOME being overridden is se
Steve Dower added the comment:
Haven't looked at your logs yet (on my phone), but make sure you have as recent
an install of the Windows SDK as you can handle. That's typically what our
build files check version numbers on.
--
___
Pyth
New submission from Steve Dower :
So I'm totally sick of being abused on the internet about the whole PATH issue,
and want to put this up as an alternative. I'm willing to do the work, but I'm
worried that my emotional state about the whole thing is blinding me to obvious
is
Steve Dower added the comment:
Yeah, that looks like a version of .NET that pre-dates Version being made
comparable, which probably means you're not getting the MSBuild installed with
VS.
Check out "where MSBuild" or %MSBUILD% to see if there's something obvious
overri
Steve Dower added the comment:
This is only an issue for broken symlinks, right? (More precisely, those that
cannot be resolved, which may include very long paths on some machines.)
Fixing copy is my preferred option.
Also Jason, what do you need to be able to test against prerelease? It
Steve Dower added the comment:
Ah right, it's realpath() that has the final step to remove an unnecessary \\?\
prefix.
Firstly, I still think fixing copy is more important and more valuable.
Given the possibility that the print name won't point to the real target, I'd
much
Steve Dower added the comment:
> Presumably, I'll be able to add a pre-release of Python 3.9 to the pipelines
> config at jaraco/skeleton - that will ensure that all projects I maintain
> going forward will get tested on the pre-release.
I don't have a straightforward tas
Steve Dower added the comment:
The self-name checking is not something I'm volunteering to write, btw, nor any
new options. But feel free to put those up as separate issues.
I'm also not getting into symbolic links here - WiX doesn't support them
natively, and custom actions
Steve Dower added the comment:
Oh, and there certainly won't be a python2.exe :)
--
___
Python tracker
<https://bugs.python.org/issue40667>
___
___
Pytho
Steve Dower added the comment:
New changeset 7f21c9ac872acc2114aee3313d132b016550ff42 by Minmin Gong in branch
'master':
bpo-40653: Move _dirnameW out of #ifdef HAVE_SYMLINK/#endif (GH-20144)
https://github.com/python/cpython/commit/7f21c9ac872acc2114aee3313d132b
Steve Dower added the comment:
Thanks! Nice catch.
Closing this, but I'll keep an eye on the backports.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
Steve Dower added the comment:
Missing piece of information, it's also _documented_ as being part of the
winsock headers:
https://docs.microsoft.com/en-us/windows/win32/api/winsock/ns-winsock-timeval
Plenty of things get included inadvertently, but they can't be relied upon. In
Steve Dower added the comment:
New changeset f660567937277cc3a2cd53af77bbb18e905427e8 by Minmin Gong in branch
'master':
bpo-40650: Include winsock2.h in pytime.c, instead of a full windows.h
(GH-20137)
https://github.com/python/cpython/commit/f660567937277cc3a2cd53af77bbb1
Change by Steve Dower :
--
nosy: -miss-islington
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Also, for future reference, compile-only changes typically don't require a NEWS
entry (since users are not going to be interested in reading it in the
changelog, and we have commit messages for developers). We have the ability to
skip the requirement on t
Steve Dower added the comment:
Thanks for the additional cleanup. In future, we'd still like a separate issue
for new changes (that aren't fixing up something caused by the earlier change).
--
___
Python tracker
<https://bu
Steve Dower added the comment:
New changeset 98e42d1f882b9b59f587d538c562dbc7d11c64c3 by Minmin Gong in branch
'master':
bpo-35890: Use RegQueryInfoKeyW and CryptAcquireContextW explicitly (GH-19974)
https://github.com/python/cpython/commit/98e42d1f882b9b59f587d538c562db
Change by Steve Dower :
--
pull_requests: +19491
pull_request: https://github.com/python/cpython/pull/20190
___
Python tracker
<https://bugs.python.org/issue35
Steve Dower added the comment:
New changeset 930badd414dd2376b1875e1775cb40855a87e180 by Steve Dower in branch
'3.7':
bpo-35890: Use RegQueryInfoKeyW and CryptAcquireContextW explicitly (GH-19974)
https://github.com/python/cpython/commit/930badd414dd2376b1875e1775cb40
New submission from Steve Carll :
I'm having a problem with an application that uses threads and TKinter.
Sometimes everything works fine but there are 2 errors that I can't seem to
figure out why they are happening. The first error is the GUI completely
locking up with no text cur
Steve Carll added the comment:
Thank you to epaine for the quick reply.
IMHO this should be elevated and addressed.
TKinter not working well with threads appears to be a well known problem that a
lot of developers have encountered and have had to work around.
The use of threads is not
Steve Dower added the comment:
This is covered by issue26227
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> Windows: socket.gethostbyaddr(name) fails for non-ASCII hostname
___
Python tra
New submission from Steve Dower :
We have a lot of stdlib code that looks like:
try:
nm_tpl.__module__ = sys._getframe(2).f_globals.get('__name__',
'__main__')
except (AttributeError, ValueError):
pass
While technically it handles sys._getframe bei
Change by Steve Dower :
--
components: +Interpreter Core
stage: -> test needed
type: -> enhancement
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/i
Steve Dower added the comment:
There really shouldn't be any difference between those two paths, apart from
skipping the compile step in the second case.
It sounds like you're pretty well set up for testing, so would you be able to
try the test while running under either the Vis
Steve Dower added the comment:
New changeset db68544122f5a0c7b80f69c0e643049efa6699c6 by Zackery Spytz in
branch 'master':
bpo-42523: Fix supported versions in "Using Python on Windows" (GH-23603)
https://github.com/python/cpython/commit/db68544122f5a0c7b80f
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
If the GIL is not held, no exception should be raised, so the fact that you've
got one there means that the GIL is held and the main.c-specific error message
is the bit that's wrong.
So it should be, "if they fail and you're in a context
Steve Stagg added the comment:
Reproducible on master, but doesn't occur with a debug build.
My configure:
> ./configure --prefix=$PREFIX --exec-prefix=$EPREFIX
> --cache-file=../config.cache --without-ensurepip > /dev/null
> PYTHONMALLOC=pymalloc_debug $EPREFIX/bin/p
Steve Stagg added the comment:
Something seems to be: breaking alignment, changing the allocator used, or
trashing that memory.
In my case, the address of the mutex is: 0x5603a330 (*1) below
and the surrounding memory:
0x5603a310:
n\0\0\03\0\0\0\0\0\0\0(*2)\xdd\xdd\xdd\xdd\xdd\xdd
Steve Stagg added the comment:
So, I'm not an allocator/init/teardown expert, but it looks like: When you
fork, PyRuntimeState creates a new mutex, explicitly using the default
allocator (without the debug allocator active)..
#ifdef HAVE_FORK
/* This function is called
Steve Dower added the comment:
Can you try disabling any security/anti-malware software you have running?
That's normally the only thing (besides a user) that will cause this error.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Good point, we can make it set errno as well. Any generic error is fine (I
don't know them off the top of my head), because it will chain up to the one
set by the hook.
--
___
Python tracker
&
Steve Dower added the comment:
New changeset c0afb7fa0ebd1c0e95c0760bbe75a99a8dd12ea6 by Matti Picus in branch
'master':
bpo-39825: Fixes sysconfig.get_config_var('EXT_SUFFIX') on Windows to match
distutils (GH-22088)
https://github.com/p
1701 - 1800 of 6138 matches
Mail list logo
