Steve Dower added the comment:
Thanks Terry!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
We currently have no audit events for unhandled exceptions.
While these can be recorded by sys.excepthook or sys.unraisablehook in Python
code, there is no way to intercept them from C code set up before running
Python code. There's also no way to co
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16874
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/17392
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
assignee: -> steve.dower
___
Python tracker
<https://bugs.python.org/issue38920>
___
___
Python-bugs-list mailing list
Unsubscrib
Steve Dower added the comment:
> But then I need two separate workflows based on what is passed in. For py.exe
> I need to run it and get sys.executable. But for python.exe I *cannot* use
> sys.executable because that’s the base interepeter, not the venv path I want.
> And `if Pa
Change by Steve Dower :
--
pull_requests: +16875
pull_request: https://github.com/python/cpython/pull/17393
___
Python tracker
<https://bugs.python.org/issue38
New submission from Steve Dower :
Because code.replace() manually creates a new code object (that is, with
arbitrary co_code rather than via the compiler), it should raise code.__new__
with its arguments.
--
assignee: steve.dower
messages: 357529
nosy: steve.dower
priority: normal
Steve Dower added the comment:
+Victor in case you'd like to check my changes to the unraisable hook
implementation.
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/is
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16876
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/17394
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset c7c01ab1e5415b772c68e15f1aba51e520010830 by Steve Dower in branch
'master':
bpo-38922: Raise code.__new__ audit event when code object replace() is called
(GH-17394)
https://github.com/python/cpyt
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset b74a6f14b94d36fb72b1344663e81776bf450847 by Steve Dower in branch
'3.8':
bpo-38920: Add audit hooks for when sys.excepthook and sys.unraisablehook are
invoked (GH-17392)
https://github.com/python/cpyt
Steve Dower added the comment:
New changeset bea33f5e1db6e4a554919a82894f44568576e979 by Steve Dower in branch
'master':
bpo-38920: Add audit hooks for when sys.excepthook and sys.unraisable hooks are
invoked (GH-17392)
https://github.com/python/cpyt
Change by Steve Dower :
--
stage: patch review -> commit review
___
Python tracker
<https://bugs.python.org/issue38920>
___
___
Python-bugs-list mai
Steve Dower added the comment:
It looks like you had a previous install that wasn't cleaned up properly (all
the packages are still registered). Any idea what may have caused that?
The easiest workaround will be to use Programs and Features to find and repair
the previous install (&q
Steve Dower added the comment:
ntpath.ismount() is using a name-only check here, it never tries to resolve the
path if splitdrive() returns (anything, one_of("", "/", "\\"))
Now it's not clear whether handling "" is intended there, but that&#
Steve Dower added the comment:
Traditionally we handle exceptions in os.path.is* functions and return False.
--
keywords: +easy, newcomer friendly
stage: -> test needed
type: -> behavior
versions: +Python 3.8, Python 3.9
___
Python t
Change by Steve Dower :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
The intent is that you'd build from source and then copy the binaries into the
libffi directory (the *real* intent is that very few people should have to
build libffi from source).
Can you tell us a bit more about what you were trying to achieve when yo
Steve Dower added the comment:
Processor type is far less likely than a shell extension.
Do you have anything like DropBox/Tortoise???/etc. installed?
--
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
Potentially. I don't have it installed, so I can't test, but I know in the past
it added a shell extension that would display overlays over files it controlled.
That shell extension will be loaded into most system file picker dialogs, and
at various
Steve Dower added the comment:
Temporarily uninstalling your Dropbox client is the easiest way.
--
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
> The main problem that I see here is that, in Windows (not POSIX),
> ntpath.ismount fails to verify that a potential mount point is an existing
> directory via os.stat and stat.S_ISDIR. ... This would be a breaking change,
> but I think it's
Change by Steve Dower :
--
pull_requests: +16959
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/17480
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset c9f480d2ccda9de46584cabe086f0acfa45f2faf by Steve Dower in branch
'3.8':
bpo-33125: Add support for building and releasing Windows ARM64 packages
(GH-17480)
https://github.com/python/cpython/commit/c9f480d2ccda9de46584cabe086f0a
Steve Dower added the comment:
Closing this as the work we need for support is now added. Whether we start
releasing binaries from python.org is a discussion to have on python-dev and
with the broader community.
Right now, I don't think the ecosystem is ready to add support (mainly be
Steve Dower added the comment:
This site seems like a pretty good aggregation of news around Windows on ARM64
devices: https://www.windows-arm.com/
Short story is, it's a real thing, but for (what I consider) obvious reasons
the OSS developer experience isn't
New submission from Steve Dower :
The winreg module should have hooks added.
--
assignee: steve.dower
components: Windows
messages: 358119
nosy: christian.heimes, paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
stage: needs patch
status: open
title: Add
New submission from Steve Dower :
Currently, calls to PySys_Audit() that use "#" format strings will raise a
deprecation warning because Python/sysmodule.c is not PY_SSIZE_T_CLEAN
Since PySys_Audit is a new API, we should just define it as always requiring
Py_ssize_t.
(Discov
Change by Steve Dower :
--
keywords: +patch
pull_requests: +17016
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/17540
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +17017
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/17541
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
> maybe you have some relevant context
Nothing you haven't figured out yourself. As you say, they're both private
functions, and as we investigated adding a "get_target_platform" function, it
turned out that nearly all users were expect
Steve Dower added the comment:
New changeset b8cbe74c3498c617f0e73fd0cdc5c07f2c532092 by Steve Dower in branch
'master':
bpo-39008: Require Py_ssize_t for PySys_Audit formats rather than raise a
deprecation warning (GH-17540)
https://github.com/python/cpyt
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset ee17e3735634c5fe15a43f897707de8011618627 by Steve Dower in branch
'master':
bpo-39007: Add auditing events to functions in winreg (GH-17541)
https://github.com/python/cpython/commit/ee17e3735634c5fe15a43f897707de
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
Should be rc1
--
assignee: steve.dower
components: Windows
messages: 358163
nosy: paul.moore, steve.dower, tim.golden, zach.ware
priority: normal
severity: normal
stage: needs patch
status: open
title: nuget package published at 3.8.1-c1 instead of rc1
Change by Steve Dower :
--
title: nuget package published at 3.8.1-c1 instead of rc1 -> nuget package
published as 3.8.1-c1 instead of rc1
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +17036
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/17564
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset d0802d07d2c864b95480a9b24c7cc050e19189d5 by Steve Dower in branch
'master':
bpo-39012: Fix RC version suffix for nuget release files (GH-17564)
https://github.com/python/cpython/commit/d0802d07d2c864b95480a9b24c7cc0
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
> Moreover, some of these C++ exectuables depends on DLL which are only in the
> Scripts directory and it might not work.
In this case, perhaps these tools should be in a separate directory? A simple
.py script could be added to Scripts that works wi
Steve Dower added the comment:
> Create a pyscript launcher, which would work like py but would take as
> command-line the name of the script to run ...
This is spelled "py [-x.y] -m [script]", but it's up to the libraries to
support it. We can't force them to
Steve Dower added the comment:
> This makes it simple for users to intervene via the PATH (which is the whole
> point of /usr/bin/env) and launch whatever they want.
That's one point of view, but the other is that the whole point of the shebang
line is for users to be able to run
Steve Dower added the comment:
> Do you mean all shebangs, including those with a native file path?
I like the idea as a whole, but ultimately end up disliking all the available
options (in the context of py.exe, that is).
* Unix/virtual shebangs don't work reliably on Windows (a
New submission from Steve Dower :
Enable support for GitHub Actions CI to do PR build and test runs.
Once stable, we can deprecate Azure Pipelines PR builds.
The only regression right now is that test results are not collected in a nice
view like AP has. But I think that view is not widely
Steve Dower added the comment:
New changeset a76ba362c4d86adf5e7f8254398135d12d7afd25 by Steve Dower in branch
'master':
bpo-39041: Add GitHub Actions support (GH-17594)
https://github.com/python/cpython/commit/a76ba362c4d86adf5e7f8254398135
Steve Dower added the comment:
Have merged the core support. Now that checks are enabled, any updates to the
workflow files can be tested in PRs, so that will be much easier.
Other things to do:
* badges
* disable Azure Pipelines for PR builds
* ...? What have I missed
Change by Steve Dower :
--
keywords: +patch
pull_requests: +17097
pull_request: https://github.com/python/cpython/pull/17628
___
Python tracker
<https://bugs.python.org/issue39
Change by Steve Dower :
--
nosy: -steve.dower
___
Python tracker
<https://bugs.python.org/issue39059>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
New changeset 6a263cf1adfc18cdba65c788dd76d35997a89acf by Steve Dower in branch
'master':
bpo-39041: Add GitHub Actions badge to README.rst (GH-17628)
https://github.com/python/cpython/commit/6a263cf1adfc18cdba65c788dd76d3
Steve Dower added the comment:
Hi tuijatuulia
In your %TEMP% directory there should be a few sets of log files for Python.
Would you be able to zip them up and attach them to this issue? That will help
us figure out what hasn't worked fo
Steve Dower added the comment:
New changeset 9e36589d49c1d6b06c0239fa69e8274d7e89e375 by Steve Dower (Anthony
Shaw) in branch 'master':
bpo-36500: Add --regen option to PCbuild/build.bat so Windows users can regen
grammar, opcodes, tokens and symbols (GH-12654)
https://github.
Change by Steve Dower :
--
pull_requests: +17112
pull_request: https://github.com/python/cpython/pull/17644
___
Python tracker
<https://bugs.python.org/issue36
Steve Dower added the comment:
Adding just a couple of minor touch-ups in PR 17644, but otherwise thanks
Anthony!
--
___
Python tracker
<https://bugs.python.org/issue36
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9 -Python 3.8
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset a9d0a6a1b932752873e04714c5dda707729078e4 by Steve Dower in branch
'master':
bpo-36500: Simplify PCbuild/build.bat and prevent path separator changing in
comments (GH-17644)
https://github.com/python/cpyt
Steve Dower added the comment:
It will be in your user TEMP directory: C:\Users\\AppData\Local\Temp (or
just type "%TEMP%" into the File Explorer address bar and it will take you
there)
They should all start with "Python" and end with ".log" (or be marked as te
Steve Dower added the comment:
The only issue I see in that log is an apparent failure communicating between
the unelevated and the elevated components of the uninstaller. But that doesn't
seem to have interfered with the rest of the process, so I'm at a bit of a loss.
Possi
Steve Dower added the comment:
> It looks like there has been a regression in the fix for this issue.
You're right. Care to create a pull request to fix it?
--
___
Python tracker
<https://bugs.python.org
Steve Dower added the comment:
Agreed, we should add events for all of these. They can go into the next 3.8
release.
Ideally, the lowest level operations (typically os module) should raise events.
Where it's convenient to also audit operations at a higher level (shutil,
subprocess
Steve Dower added the comment:
I think this is specific to the interactive prompt. Under normal circumstances,
any error in calling the hook at the point where an event is being audited
(which is immediate when using interactive mode) needs to propagate.
Probably the best way to handle it
Steve Dower added the comment:
Right, IDLE doesn't call exec/compile until _after_ the code is submitted,
while the regular prompt calls it first and passes stdin as the source file
(which then does a buffered read).
The loop occurs because the next action after an invalid input is to
Steve Dower added the comment:
I haven't looked into _why_ yet, but the first PYD I grabbed from the GitHub
link above has had the CRT statically linked. This is not the default (or it
should not be), because when we made it the default this exact issue occurred :)
If somehow the de
Steve Dower added the comment:
New changeset acf5e5f3f42a3d2985499df82331705edbe717be by Steve Dower (Miss
Islington (bot)) in branch '3.7':
bpo-39041: Add GitHub Actions support (GH-17594)
https://github.com/python/cpython/commit/acf5e5f3f42a3d2985499df8233170
Steve Dower added the comment:
New changeset 0048833e1308d39dc9c6489da7872ade0f14486f by Steve Dower (Miss
Islington (bot)) in branch '3.8':
bpo-39041: Add GitHub Actions support (GH-17594)
https://github.com/python/cpython/commit/0048833e1308d39dc9c6489da7872a
Steve Dower added the comment:
New changeset 7b79dc9200a19ecbac667111dffd58e314be02a8 by Steve Dower (Anthony
Wee) in branch 'master':
bpo-29778: Fix incorrect NULL check in _PyPathConfig_InitDLLPath() (GH-17818)
https://github.com/python/cpyt
Steve Dower added the comment:
Thanks, Anthony! And congratulations on becoming a CPython contributor!
--
___
Python tracker
<https://bugs.python.org/issue29
Change by Steve Dower :
--
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/issue29778>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
pull_requests: +17289
pull_request: https://github.com/python/cpython/pull/17873
___
Python tracker
<https://bugs.python.org/issue39
Steve Dower added the comment:
I started creating an example of improving the skip cases, and ended up just
making a PR. It should:
* expect a helpful error on Windows
* work fine on other platforms with crypt
* skip all tests on other platforms without crypt
Change by Steve Dower :
--
pull_requests: +17297
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/17881
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
keywords: +easy, newcomer friendly
___
Python tracker
<https://bugs.python.org/issue39243>
___
___
Python-bugs-list mailing list
Unsub
Steve Dower added the comment:
Good catch.
We should probably make the line 351 check "if name and ('/' in name ..." like
the others in the same function.
--
keywords: +3.8regression
___
Python tracker
<https://bug
Steve Dower added the comment:
In that case, we should refactor the init method to check whether handle has
been specified earlier, so that it's obvious that the two conditional blocks
are never executed in that case.
--
___
Python tr
Steve Dower added the comment:
These links are controlled by Microsoft, and not by us. (Though just to make
things confusing, I am the person at Microsoft who can get them updated.)
We've been waiting for the ecosystem to be ready. Too many packages have been
failing to install on P
Steve Dower added the comment:
We can stop using --junit-xml if we want. GitHub Actions doesn't support
displaying test results anyway, so once Azure Pipelines is switched off we'll
just be reading the console all the time anyway (unless Buildbot has a way of
rendering test resu
Steve Dower added the comment:
> I think it would be cleaner to split out the platform-specific work into a
> separate _load_library method
SGTM
--
___
Python tracker
<https://bugs.python.org/i
Steve Dower added the comment:
My guess would be that the reference tracking needs some kind of awareness for
logging results. The results are collected as regular Python objects and
formatted later, as we need to calculate totals before writing the XML file.
I guess keeping those objects
Steve Dower added the comment:
Agreed it's not a bug.
The best we could do is display a warning that fork is not portable (won't work
on macOS anymore either, IIRC) and you should at least verify that spawn
behaves the same.
--
Steve Dower added the comment:
New changeset 5907e61a8d4da6d0f11bf1062d6d17484560a15e by Steve Dower (An Long)
in branch 'master':
bpo-35292: Avoid calling mimetypes.init when http.server is imported (GH-17822)
https://github.com/python/cpython/commit/5907e61a8d4da6d0f11bf1062d6d17
Steve Dower added the comment:
Thanks for the patch!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.9 -Python 3.8
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
For reference, I'm going to wait for protobuf, simplejson and Tornado to
provide Python 3.8 wheels before switching the default version. Ideally I'd
like markupsafe to have wheels as well, but they have a fallback so it's okay.
Everything else
Steve Dower added the comment:
You could have chosen the "Customize installation" button (see the screenshot
at https://docs.python.org/3.8/using/windows.html#installation-steps). The
description says "Choose location and features".
--
__
Steve Dower added the comment:
You may have already had a previous install that was being upgraded. In that
case, you should uninstall the old one and then install it to a new location
(or else you may end up with some subtle corruption
Steve Dower added the comment:
New changeset ed367815eeb9329c48a86a8a7fa3186e27a10f2c by Steve Dower in branch
'master':
bpo-25172: Reduce scope of crypt import tests (GH-17881)
https://github.com/python/cpython/commit/ed367815eeb9329c48a86a8a7fa318
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Holden added the comment:
Verified. Methododology:
1. Copied test_localise.py from the PR into a master checkout.
2. Added a null locale.localize.
3. Verified that all new tests failed.
.. code-block::
Ran 64 tests in 0.023s
FAILED (errors=4, skipped=4)
(base) blockhead:cpython
Steve Dower added the comment:
Have you read PEP 514? Does that help?
If not, can you provide specific suggestions in terms of that standard to help
us understand what you are suggesting?
--
___
Python tracker
<https://bugs.python.org/issue39
Steve Dower added the comment:
You should read the version number from the Version or SysVersion values,
rather than from the tag.
Having -32 in the key name is a compatibility requirement. Without it, if you
installed 32-bit and 64-bit versions for the current user (which is now the
Steve Dower added the comment:
Can you show some of these errors?
Certainly any existing console windows (cmd/PowerShell) will not have their
PATH variables updated - that's by design - but there should not be anything
else in Python 3.8 that requires a r
Steve Dower added the comment:
Given the minimum version requirement, I'd rather this support go into a
third-party library. (Seems like a great candidate for a context manager, too.)
Recalling our debates about symlinks, I'd have to say that nothing about
placeholder files qual
Steve Dower added the comment:
More precisely, make sure the libcrypto-1_1.dll and libssl-1_1.dll files are in
the same directory as your _ssl.pyd, but _not_ inside your Python38.zip file
(zip import does not support native modules, they have to be outside of the
zip
Change by Steve Dower :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue39412>
___
___
Steve Dower added the comment:
It's also a little bit historical - there was no way to *remove* the Python 3.4
launcher (always in C:\Windows), and it wasn't going to find many 3.5 installs,
so we stomp on it.
At this stage, it's potentially safe to turn it into a per-
Steve Dower added the comment:
Agreed, we can just search System32 for this. Thanks for doing the patch!
For future reference, and for anyone else reading this, we generally prefer
unavoidable DLL hijacking bugs to come to the Python Security Response Team
first (secur...@python.org
New submission from Steve C :
When running unit tests with the --verbose flag test descriptions are run using
the first line of the test case's docstring. If the first character of the
docstring is a newline, no description is printed.
Examples:
Current code expects docstrings to look
Change by Steve C :
--
keywords: +patch
pull_requests: +17559
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/18175
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset c45a2aa9e255b5c7c211faa79f6b23895b64ab27 by Steve Dower
(Christoph Reiter) in branch 'master':
bpo-38883: Don't use POSIX `$HOME` in `pathlib.Path.home/expanduser` on Windows
(GH-17961)
https://github.com/python
Steve Dower added the comment:
New changeset c45a2aa9e255b5c7c211faa79f6b23895b64ab27 by Steve Dower
(Christoph Reiter) in branch 'master':
bpo-38883: Don't use POSIX `$HOME` in `pathlib.Path.home/expanduser` on Windows
(GH-17961)
https://github.com/python
1401 - 1500 of 6138 matches
Mail list logo
