Gregory P. Smith added the comment:
I'll just reuse this issue, I started that work just to try and clean up the
new API and docs added in this one to be more modern. Thanks for the code
review, good suggestions!
--
assignee: -> gregory.p.smith
stage: resolved -> co
Gregory P. Smith added the comment:
New changeset 163468a766e16604bdea04a1ab808c0d3e729e5d by Gregory P. Smith in
branch 'master':
bpo-16500: Don't use string constants for os.register_at_fork() behavior (#1834)
https://github.com/python/cpython/commit/163468a766e16604bdea04a1a
Changes by Gregory P. Smith :
--
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue16500>
___
___
Pyth
Gregory P. Smith added the comment:
This may also allow us to do something reasonable for
http://bugs.python.org/issue6721 as well.
--
___
Python tracker
<http://bugs.python.org/issue16
Gregory P. Smith added the comment:
http://bugs.python.org/issue16500 added the os.register_at_fork() API which may
be usable for this.
--
___
Python tracker
<http://bugs.python.org/issue6
Changes by Gregory P. Smith :
--
versions: +Python 3.7 -Python 3.5
___
Python tracker
<http://bugs.python.org/issue6721>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
New changeset 1f29cefc87c4c2ee629367ebe97a287d8e0b3e29 by Gregory P. Smith
(Hanno Schlichting) in branch '2.7':
bpo-29766: Do not force --with-lto to true for --enable-optimizations (#1858)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
indeed, my mistake in the original backport. thanks!
--
assignee: -> gregory.p.smith
resolution: -> fixed
stage: -> resolved
status: open -> closed
type: -> compile error
___
Python
Changes by Gregory P. Smith :
--
pull_requests: +1954
___
Python tracker
<http://bugs.python.org/issue12383>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset b351248c1fa74277b886b0c9a2e1c2f65fabe9ef by Gregory P. Smith in
branch 'master':
bpo-12383: Refactor subprocess test_empty_env (#1874)
https://github.com/python/cpython/commit/b351248c1fa74277b886b0c9a2e1c2
Gregory P. Smith added the comment:
I am not a Windows person... but is there a reason that handle_list must be an
attribute of a STARTUPINFO class rather than just a special case of pass_fds
such that people could supply windows handles in the pass_fds parameter rather
than using STARTUPINFO
Gregory P. Smith added the comment:
i wondered if that might happen. the test skipping logic that wasn't correct
was added for macos; probably needs to be written another way. i've got a mac
today, i'll figure it out.
--
___
Python
Changes by Gregory P. Smith :
--
pull_requests: +1957
___
Python tracker
<http://bugs.python.org/issue12383>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
fixed in
https://github.com/python/cpython/commit/85aba238e49abd2d5a604102981d28a50f305443
--
___
Python tracker
<http://bugs.python.org/issue12
Changes by Gregory P. Smith :
--
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Gregory P. Smith :
--
pull_requests: +2009
___
Python tracker
<http://bugs.python.org/issue27448>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +12029
___
Python tracker
<https://bugs.python.org/issue1054041>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
New changeset 06babb24225d41a76e4aee975380294ca1ee1d7c by Gregory P. Smith in
branch 'master':
bpo-1054041: Add What's New docs. (GH-11999)
https://github.com/python/cpython/commit/06babb24225d41a76e4aee975
Gregory P. Smith added the comment:
I think it'd be worth doing on POSIX systems for some 3.8 alpha/beta release
cycles before making a final call there.
--
___
Python tracker
<https://bugs.python.org/is
Gregory P. Smith added the comment:
I like the separate parameters. :)
--
___
Python tracker
<https://bugs.python.org/issue36046>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +12459
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
2.7 was closed to new features eons ago.
While subprocess32 backport might be a plausible home for this, I really can't
handle doing anything significant for Windows within the confines of that
project (it already makes me nervous that anyone is
Gregory P. Smith added the comment:
New changeset 7a2e84c3488cfd6c108c6b41ff040825f1757566 by Gregory P. Smith in
branch 'master':
bpo-33319: Clarify subprocess call docs. (GH-12508)
https://github.com/python/cpython/commit/7a2e84c3488cfd6c108c6b41ff0408
Change by Gregory P. Smith :
--
nosy: -miss-islington
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
We need a small test case that can reproduce your problem. I believe
https://github.com/python/cpython/commit/3b699932e5ac3e76031bbb6d700fbea07492641d
to be correct.
acquiring locks before fork in the thread doing the forking and releasing them
Gregory P. Smith added the comment:
I'd start with faulthandler.register with all_threads=True and see if that
gives you what you need.
https://docs.python.org/3/library/faulthandler.html
--
___
Python tracker
<https://bugs.python.org/i
New submission from Gregory P. Smith :
The codecs module has public decode_encode() and encode_decode() functions.
They have never been documented, but are recommended for some uses such as:
https://stackoverflow.com/questions/14820429/how-do-i-decodestring-escape-in-python3/23151714
Change by Gregory P. Smith :
--
superseder: -> Missing documentation for codecs.escape_decode
___
Python tracker
<https://bugs.python.org/issue36530>
___
_
Change by Gregory P. Smith :
--
resolution: -> duplicate
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
We can't change it or remove it, it is public by virtue of its name. We should
document it.
Removing or renaming it to be _private requires a PendingDeprecationWarning ->
DeprecationWarning -> removal cycle. it is well known and u
Change by Gregory P. Smith :
--
stage: -> needs patch
___
Python tracker
<https://bugs.python.org/issue30588>
___
___
Python-bugs-list mailing list
Unsubscrib
New submission from Gregory P. Smith :
I'm spawning a dicussion buried in the way too long thread of
https://bugs.python.org/issue6721 over here into its own specific issue to
treat as a 3.7 release blocker for a rollback or repair decision before 3.7.4.
https://github.com/python/cp
Gregory P. Smith added the comment:
Thanks for the debugging details! I've filed
https://bugs.python.org/issue36533 to specifically track this potential
regression in the 3.7 stable branch. lets carry on there where the discussion
thread isn't too long for bug trac
Gregory P. Smith added the comment:
That custom DebugHandler's emit() implementation that calls into one or more
sub-handlers suggests that libreswan _might_ be able to fix it in the custom
DebugHandler by implementing custom acquire() and release() methods... BUT that
is a fundamen
Gregory P. Smith added the comment:
Within the logging module we could go beyond using a WeakSet and maintain an
ordering. But we'd need to allow a way for Handler subclasses to indicate what
order matters; that'd require a new API (not suitable for 3.7)
An ordering its
Gregory P. Smith added the comment:
A stdlib alternative to this whole mess would be to avoid acquiring the logging
locks before fork() as we currently do and just blindly re-initialize all of
them afterwards under the assumption that they "can't" be protecting anything
in
Gregory P. Smith added the comment:
Now to back up: Why was this application using fork() in a threaded
application at all? That is a fundamental flaw. Should we be doing work to
support things that so far merely _happen_ to work on such broken designs?
Another alternative for the
New submission from Gregory P. Smith :
In Python 2.7 our threading implementation was so poor that a thread join
ultimately called our lock wait implementation that busy looped polling and
sleeping to check for a lock acquisition success. calling
thread.interrupt_main() which is just
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +12628
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36533>
___
_
Gregory P. Smith added the comment:
Here's a PR that goes the re-initialization route rather than attempting to
acquire/release anything other than the single module _lock.
--
nosy: +lukasz.langa
versions: +Python 3.8
___
Python tracker
&
Gregory P. Smith added the comment:
The logging library has never guaranteed that it wouldn't interleave or
duplicate buffered io output when fork() in involved. We should not start
trying to claim that it does. Too complicated and fragile. It can't. Users
who want that should
Change by Gregory P. Smith :
--
pull_requests: +12683
___
Python tracker
<https://bugs.python.org/issue36276>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +12682
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue14826>
___
___
Python-bugs-lis
Gregory P. Smith added the comment:
> """
Since the documentation seems to be silent the guarantee (or expectation) is
implied - logging systems emit records atomically - if this isn't true across
fork() then the exception should be documented.
"""
Change by Gregory P. Smith :
--
pull_requests: +12687
___
Python tracker
<https://bugs.python.org/issue14826>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
urllib.request.URLopener() and FancyURLopener() automatically quote() URLs for
the user. Those APIs are marked deprecated since 3.3 but have no timeline for
removal.
urllib.request.urlopen() does not use those, so URLs passed in are not
auto-quoted
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +12688
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue30458>
___
_
Gregory P. Smith added the comment:
New changeset 2fb2bc81c3f40d73945c6102569495140e1182c7 by Gregory P. Smith in
branch 'master':
bpo-14826: document that URLopener quotes fullurl. (GH-12758)
https://github.com/python/cpython/commit/2fb2bc81c3f40d73945c6102569495
Gregory P. Smith added the comment:
Martin claimed "Actually, the CRLF + space can be injected via percent encoding"
I am unable to reproduce that behavior using urllib.request.urlopen() or
urllib.request.URLopener.open() in my master/3.8 tree.
--
nosy: +grego
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue30458>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
my fix proposed in issue30458 fixes this issue.
i do not think this one deserved its own CVE; at least
https://nvd.nist.gov/vuln/detail/CVE-2019-9947's current text also points to
the other one.
--
nosy: +gregory.p.smith
resolution: -> d
Change by Gregory P. Smith :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue35906>
___
___
Pyth
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue36587>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
yeah i saw that bug buried in there, this weakset goes away with my proposed PR.
--
___
Python tracker
<https://bugs.python.org/issue36
Gregory P. Smith added the comment:
The problem i am fixing is merely making Python's logging library not the
source of this deadlock because it was not the source in the past. I am
solving a regression in CPython behavior between 3.7.0 and 3.7.1 that led to a
logging.Handler lock re
Gregory P. Smith added the comment:
> *Maybe* we need to provide a way to allow to pass junk characters in an URL?
> (disable URL validation)
We should not do this in our http protocol stack code. Anyone who _wants_ that
is already intentionally violating the http protocol which d
Gregory P. Smith added the comment:
While altering the environment to not use the system default openssl config is
an option to make this green again today very easily. That'd "solve" the red
bot problem and nothing else. :/
Doing that just kicks the can down the road as
Gregory P. Smith added the comment:
We can remove ancient Irix and LinuxThreads hacks from our codebase.
The best way to shake issues of this sort out is to remove it and watch for
issues on supported buildbots and during beta releases. I don't expect any
fallout from this one.
Change by Gregory P. Smith :
--
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue27987>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
Even if you check for -fmax-type-align compiler support at configure time,
there is a potential problem:
Nothing guarantees that extension modules are built by the same compiler that
CPython is. If CPython used an old clang without support for that flag
Gregory P. Smith added the comment:
I believe -fno-max-type-align is also an option.
--
___
Python tracker
<https://bugs.python.org/issue36618>
___
___
Pytho
Change by Gregory P. Smith :
--
pull_requests: +12752
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue16079>
___
___
Python-bugs-lis
Change by Gregory P. Smith :
--
keywords: +easy
versions: +Python 3.7, Python 3.8 -Python 3.3, Python 3.4
___
Python tracker
<https://bugs.python.org/issue16
Change by Gregory P. Smith :
--
components: +Tests
___
Python tracker
<https://bugs.python.org/issue16079>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset cd466559c4a312b3c1223a774ad4df19fc4f0407 by Gregory P. Smith in
branch 'master':
bpo-16079: fix duplicate test method name in test_gzip. (GH-12827)
https://github.com/python/cpython/commit/cd466559c4a312b3c1223a774ad4df
Change by Gregory P. Smith :
--
type: enhancement -> behavior
___
Python tracker
<https://bugs.python.org/issue16079>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
Agreed, making duplicate method definitions a CI failure is the desired end
state once our test suite is cleaned up and it doesn't have false positives.
FYI - pylint also implements this check quite reliably as function-redefined
vi
Gregory P. Smith added the comment:
Please do not blindly revert that. See my PR in
https://bugs.python.org/issue36533 which is specific to this "issue" with
logging.
--
versions: +Python 3.8
___
Python tracker
<https://bu
Gregory P. Smith added the comment:
I'd appreciate it if someone with an application running into the issue could
be tested with my PR from issue36533
(https://github.com/python/cpython/pull/12704) applied.
--
___
Python tracker
&
Gregory P. Smith added the comment:
I am unable to get cf-deadlock.py to hang on my own builds of pure CPython
3.7.2+ d7cb2034bb or 3.6.8+ be77fb7a6e (versions i had in a local git clone).
which specific python builds are seeing the hang using? Which specific
platform/distro version
Gregory P. Smith added the comment:
concurrent.futures.ProcessPoolExecutor uses both multiprocessing and threading.
multiprocessing defaults to using os.fork().
--
___
Python tracker
<https://bugs.python.org/issue35
Gregory P. Smith added the comment:
> "the single-threaded ProcessPoolExecutor test program"
I doubt it is single threaded, the .submit() method appears to spawn a thread
internally.
--
___
Python tracker
<https://bugs.pytho
New submission from Gordon P. Hemsley :
The last commit available on codecov.io is from a week ago
(d28aaa7df8bcd46f4135d240d041b0b171b664cc):
https://codecov.io/gh/python/cpython
And the widget on the README is showing a status of "unknown".
--
messages: 340588
nosy:
Gordon P. Hemsley added the comment:
Taking a step back, I want to make sure I understand the action items for
resolving this:
* Add copy() as an alias to __copy__() in the C implementation to match the
Python implementation.
* Deprecate copy() in favor of copy.copy() in both the Python and
New submission from Gordon P. Hemsley :
In the process of investigating and writing tests for issue32424, I discovered
that the C implementation of xml.etree.ElementTree does not make a copy of the
attrib argument when creating a new element, allowing the attributes of the
element to be
Gordon P. Hemsley added the comment:
My proposed solution to this was to make a copy of the attrib dictionary in the
create_new_element() method in the C implementation, which solves the problem.
However, this was apparently objected to on the grounds of performance.
Not knowing C very well
Gordon P. Hemsley added the comment:
Opened issue36685 for discussion of the attrib copy issue.
--
___
Python tracker
<https://bugs.python.org/issue32
Gordon P. Hemsley added the comment:
In fact, it seems the last commit on master was
962b028b0c20abcf39594f08b1e5f8c36c4e5f6f 3 months ago, which doesn't even have
valid report.
The previous commit, 9932a22897ef9905161dac7476e6976370e13515, was the last to
have a functioning r
Gordon P. Hemsley added the comment:
It looks like this may be the result of the code coverage being provided by the
optional gcc build, which has been failing for quite a while.
--
___
Python tracker
<https://bugs.python.org/issue36
Gordon P. Hemsley added the comment:
I'm not sure when the gcc build started failing, but it looks like the commits
at the boundary failed due to max build time. Something is apparently too slow
to run.
--
___
Python tracker
&
Change by Gordon P. Hemsley :
--
pull_requests: +12822
___
Python tracker
<https://bugs.python.org/issue32424>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gordon P. Hemsley :
--
keywords: +patch
pull_requests: +12823
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Change by Gordon P. Hemsley :
--
pull_requests: +12918
___
Python tracker
<https://bugs.python.org/issue32424>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset c4e671eec20dfcb29b18596a89ef075f826c9f96 by Gregory P. Smith in
branch 'master':
bpo-30458: Disallow control chars in http URLs. (GH-12755)
https://github.com/python/cpython/commit/c4e671eec20dfcb29b18596a89ef07
Gregory P. Smith added the comment:
backports to older releases will need to be done manually and take care
depending on how much of a concern tightening the existing abusive lenient
behavior of the http.client API to enforce what characters are allowed in URLs
is to stable releases.
I
Change by Gregory P. Smith :
--
assignee: gregory.p.smith ->
stage: patch review -> backport needed
___
Python tracker
<https://bugs.python.org/i
Change by Gregory P. Smith :
--
stage: patch review -> backport needed
___
Python tracker
<https://bugs.python.org/issue30458>
___
___
Python-bugs-list mai
Change by Gregory P. Smith :
--
pull_requests: +12964
stage: backport needed -> patch review
___
Python tracker
<https://bugs.python.org/issue30458>
___
___
Py
Gregory P. Smith added the comment:
New changeset b7378d77289c911ca6a0c0afaf513879002df7d5 by Gregory P. Smith in
branch 'master':
bpo-30458: Use InvalidURL instead of ValueError. (GH-13044)
https://github.com/python/cpython/commit/b7378d77289c911ca6a0c0afaf5138
Gregory P. Smith added the comment:
for reference, the discourse thread:
https://discuss.python.org/t/f-string-debug-conversion/99/14
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue36
Gregory P. Smith added the comment:
Steven: We shouldn't block this immediately useful feature from going in for
f-strings on waiting for some much broader first class access to expressions
feature. !d would be practical today.
--
___
P
Gregory P. Smith added the comment:
hallway conversation with Eric: neither of us have immediately good thoughts on
a spelling other than !d for this. !! or != seem esoteric and/or unparseable,
using a capital letter like !D could be new and odd and might be useful to
differentiate types
Gregory P. Smith added the comment:
regarding issue28307 - It is not always correct to convert a %d %u %i used to
render v into f'{int(v)}'. That'd lose the TypeError when v is not an integer.
If you are looking at making internal private conversions for the purposes of
that
Gregory P. Smith added the comment:
A note from the urllib3 fixes to this: They chose to go the route of
auto-%-encoding the offending characters in URLs instead. I do not think the
stdlib should do this.
One thing to note though is that they claim URLs with spaces embedded in them
are
Change by Gregory P. Smith :
--
versions: +Python 3.7, Python 3.8 -Python 3.2, Python 3.3
___
Python tracker
<https://bugs.python.org/issue11001>
___
___
Pytho
Gordon P. Hemsley added the comment:
Testing has shown that the gcc build itself runs fine. The problem appears to
be with how the coverage tests are run.
--
___
Python tracker
<https://bugs.python.org/issue36
Gordon P. Hemsley added the comment:
It seems the final open question on this is whether the mismatch between the
Python and C implementations is enough to bypass PendingDeprecationWarning for
copy() in favor of jumping straight to DeprecationWarning
Gordon P. Hemsley added the comment:
It seems the primary cause of the problem is simply that testing crossed the
boundary of maximum execution time allotted by Travis CI.
I'm experimenting now with ways to speed up testing without losing granularity.
However, given how long code cov
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue36793>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
type: -> enhancement
___
Python tracker
<https://bugs.python.org/issue36793>
___
___
Python-bugs-list mailing list
Unsubscrib
2101 - 2200 of 3453 matches
Mail list logo
