Change by Gregory P. Smith :
--
pull_requests: +10745, 10746, 10748
___
Python tracker
<https://bugs.python.org/issue35225>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
pull_requests: +10745, 10746, 10747, 10748
___
Python tracker
<https://bugs.python.org/issue35225>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
New changeset e5796c42c687e1454e84dcc50e6f67db48ff69a0 by Gregory P. Smith in
branch 'master':
bpo-35214: Skip test_io tests that'd cause a huge malloc under msan (#11385)
https://github.com/python/cpython/commit/e5796c42c687e1454e84dcc50
Gregory P. Smith added the comment:
Status on my upcoming buildbot host after today's changes:
== Tests result: FAILURE ==
375 tests OK.
11 tests failed:
test_asyncio test_builtin test_code test_ctypes test_ioctl
test_openpty test_os test_posix test_pty test_shutil test_uui
Gregory P. Smith added the comment:
https://buildbot.python.org/all/#/builders/135/builds/1110
== Tests result: SUCCESS ==
404 tests OK.
10 slowest tests:
- test_tokenize: 3 min 43 sec
- test_concurrent_futures: 3 min 28 sec
- test_multiprocessing_spawn: 3 min 20 sec
- test_tools: 2 min 59
Change by Gregory P. Smith :
--
pull_requests: +10755
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +10755, 10756, 10757
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
pull_requests: +10755, 10756
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
New changeset 1d300ce1d8238136595c8fea76266a4755cd73a2 by Gregory P. Smith in
branch 'master':
bpo-35214: Annotate posix calls for clang MSan. (#11389)
https://github.com/python/cpython/commit/1d300ce1d8238136595c8fea76266a
Change by Gregory P. Smith :
--
pull_requests: +10758, 10759, 10760
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailin
Change by Gregory P. Smith :
--
pull_requests: +10758
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +10758, 10759
___
Python tracker
<https://bugs.python.org/issue35214>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
New changeset efcf08d8ca9084d8248715f0634c21b705f02ca2 by Gregory P. Smith in
branch '3.7':
[3.7] bpo-35214: Annotate posix calls for clang MSan. (GH-11389) (GH-11391)
https://github.com/python/cpython/commit/efcf08d8ca9084d8248715f0634c21
Gregory P. Smith added the comment:
New changeset 47a2fced84605a32b79aa3ebc543533ad1a976a1 by Gregory P. Smith
(Harmandeep Singh) in branch 'master':
bpo-31450: Remove documentation mentioning that subprocess's child_traceback is
available with the parent process (
Change by Gregory P. Smith :
--
assignee: gregory.p.smith ->
___
Python tracker
<https://bugs.python.org/issue35550>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
ntpath and macpath appear to have the same potential issue.
They've basically had this defpath value forever.
keep following it and you find a commit from 1994
https://github.com/python/cpython/commit/2979b01ff88ac4c5b316d9bf98edbaaaffac8e24
Changing
Gregory P. Smith added the comment:
I'm not arguing against this change, just trying to figure out where it came
from in the first place. We should fix the value on all OSes.
It would be a behavior change so probably only good fo
Gregory P. Smith added the comment:
Lets move forward with this as a SyntaxWarning in 3.8 and see if anyone
complains during the betas.
--
___
Python tracker
<https://bugs.python.org/issue34
Gregory P. Smith added the comment:
I'm re-opening this. The original intent of the PR was missed even though the
change in the PR as is was not how we want to do this in the CPython VM.
Background: We build our default non-production test interpreter in `#undef
NDEBUG` mode at G
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue35766>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I suspect these conditionals are very old and came from times when we supported
some platforms that did not have these APIs.
Are they present on all CPython supported platforms today?
Windows is probably the only one left to verify.
BSD/Linux/Un*xes and
Gregory P. Smith added the comment:
Thanks for your _extremely detailed_ analysii of the (often sad) state of
posix_spawn() on platforms in the world today.
My first reaction to this was "but then we'll be owning our own custom
posix_spawn-like implementation as if we'll
Change by Gregory P. Smith :
--
pull_requests: +11523
___
Python tracker
<https://bugs.python.org/issue35537>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
pull_requests: +11523, 11524
___
Python tracker
<https://bugs.python.org/issue35537>
___
___
Python-bugs-list mailing list
Unsub
Change by Gregory P. Smith :
--
pull_requests: +11523, 11524, 11525
___
Python tracker
<https://bugs.python.org/issue35537>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
> * Decide whether "setxid problem"[5] is important enough to worry about.
> [5] https://ewontfix.com/7
This is a scary issue. But I think a reasonable approach could be to never use
vfork when running as whatever we choose to define a
Change by Gregory P. Smith :
--
versions: +Python 3.8 -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.org/issue28494>
___
___
Python-bugs-list m
Gregory P. Smith added the comment:
it's a bugfix, it seems reasonable for 3.7 to me. I agree that the previous
is_zipfile check is too lenient. I'll follow up on jjolly's PR for any
specific concerns I have with the implementation.
--
assignee: serhiy.storchaka -&g
Change by Gregory P. Smith :
--
keywords: +easy
versions: +Python 3.8 -Python 3.4
___
Python tracker
<https://bugs.python.org/issue18765>
___
___
Python-bug
Gregory P. Smith added the comment:
FYI - the name of this bot is misleading. It is now Debian testing as of 18
hours ago instead of obsolete Ubuntu 14.04. I finally upgraded it.
Opens version says 1.1.1a.
--
blame half the typos on my phone.
On Wed, Feb 6, 2019, 5:45 PM Pablo Galindo
Change by Gregory P. Smith :
--
nosy: +christian.heimes
___
Python tracker
<https://bugs.python.org/issue35925>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
I had emailed Christian around the same time you filed this.
"""
The problem likely not related to your hardware. I guess it's caused by
tightened crypto polices. OpenSSL 1.1.1 has disabled some weak crypto.
Some platforms like Debian a
Change by Gregory P. Smith :
--
title: test_httplib test_nntplib test_ssl fail on ARMv7 buster/sid buildbots ->
test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster buildbot
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
versions: +Python 3.8 -Python 3.3
___
Python tracker
<https://bugs.python.org/issue1054041>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
Taking a renewed look at this 8 years later... I agree, re-triggering the
signal with the SIG_DFL handler would prevent us from doing the existing
interpreter shutdown cleanup if we did it too early which would be a behavior
change other than the exit
Change by Gregory P. Smith :
--
stage: patch review -> needs patch
___
Python tracker
<https://bugs.python.org/issue1054041>
___
___
Python-bugs-list mai
Gregory P. Smith added the comment:
I expect that'll work as desired and avoids the re-raising of the signal.
Unless told otherwise I assume this should be a POSIX specific platform
behavior. ie: no return value alteration due to an uncaught KeyboardInterrupt
on the Windows API
Gregory P. Smith added the comment:
jwilk: Confirmed. The exit code is not enough, we must trigger the SIG_DFL
handler.
to reproduce:
while true; do ./sig.py ; done
with the attached sig.py.
pass a parameter to sig.py to have it exit 130 instead of triggering SIG_DFL
Change by Gregory P. Smith :
--
pull_requests: +11895
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue1054041>
___
___
Py
Change by Gregory P. Smith :
--
superseder: -> test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster
buildbot
___
Python tracker
<https://bugs.python.org/issu
Change by Gregory P. Smith :
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
The buildbot was only offline for a few days while I upgraded the OS. do not
look at the _delta_ between builds in the buildbot to determine a failure
across that change as it went from ubuntu 14.04 to debian buster.
2.7 doesn't change
Gregory P. Smith added the comment:
i duped this to the existing issue that was filed after the OS upgrade under
the assumption it is the same thing.
--
___
Python tracker
<https://bugs.python.org/issue36
Gregory P. Smith added the comment:
Not on this debian buster bot. look back a couple comments, there is a
workaround. it seems to be an OpenSSL configuration issue / test expectations
issue.
I think we should ultimately get our test suite so that it passes in default OS
distro OpenSSL
Change by Gregory P. Smith :
--
nosy: +benjamin.peterson, ned.deily
priority: normal -> release blocker
stage: -> needs patch
type: -> behavior
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
title: test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster buildbot
-> test_httplib test_nntplib test_ssl fail on ARMv7 Debian buster bot (OpenSSL
1.1.1a)
___
Python tracker
<https://bugs.pyth
Gregory P. Smith added the comment:
release managers are free to defer this blocker. i'm just marking it as such
for the purposes of making sure it is a conscious decision.
The problem is more likely with our test suite vs the environment than it is
with CPython i
Gregory P. Smith added the comment:
FWIW I've just manually confirmed that running Python 2.7's test_ssl with
OPENSSL_CONF=/invalid-path set passes on the debian buster buildbot host.
--
___
Python tracker
<https://bugs.python.o
Gregory P. Smith added the comment:
New changeset 38f11cc3f62db11a4a24354bd06273322ac91afa by Gregory P. Smith in
branch 'master':
bpo-1054041: Exit properly after an uncaught ^C. (#11862)
https://github.com/python/cpython/commit/38f11cc3f62db11a4a24354bd06273
Gregory P. Smith added the comment:
This is in for 3.8.
On earlier or unpatched Python versions: application owners have a workaround f
they do not mind skipping a clean application shutdown (destructors) on posix
platforms:
catch KeyboardInterrupt, reset SIGINT to SIG_DFL, kill(getpid
Gregory P. Smith added the comment:
This means either that the bash minimum version needs upping to a patch level
or that the test is actually flaky and both I and all of the CI got lucky when
running it (i'm not actually sure if any of the CI actually ran this test or
just skipped it
Gregory P. Smith added the comment:
testing on my end with various bash versions shows that bash 4.3.0 and 4.4.0
and 5.0.0 all work fine on my linux and macos systems. caveat, i'm launching
regrtest from a login shell (in case that influences child bash processes
behavior).
i'
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +11928
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset 414c625a7ea58943f0b1bc79d095d667d78db013 by Gregory P. Smith in
branch 'master':
bpo-36013: delete fragile interactive shell SIGINT test (GH-11902)
https://github.com/python/cpython/commit/414c625a7ea58943f0b1bc79d095d6
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
versions: +Python 3.8 -Python 3.5, Python 3.6
___
Python tracker
<https://bugs.python.org/issue29515>
___
___
Python-bugs-list m
Gregory P. Smith added the comment:
i'm curious if this _ever_ comes up so i'd like to leave it in at least through
some betas. I don't believe it should be possible. If it is, it'd probably be
a restricted execution environment that fails all signal() calls. all per
Change by Gregory P. Smith :
--
pull_requests: +11989
___
Python tracker
<https://bugs.python.org/issue1054041>
___
___
Python-bugs-list mailing list
Unsub
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue36046>
___
___
Python-
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue29639>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
I think someone wanting this will need to put forward a patch adding it to be
reviewed and mulled over. As Alex mentioned in msg22571 -
https://github.com/dreid/posix_spawn/ exists as does the code Danek pointed at
in the next comment. try those.
I
Gregory P. Smith added the comment:
All I'm really saying is that someone who wants this should provide a
patch/PR with unittests. :) I can help review and go from there.
It does make sense to me for it to be available as part of the subprocess
API if it is available at all, like
Gregory P. Smith added the comment:
I like your patch, raising an exception is indeed the right thing to do. i'll
get this patch in.
whether or not the built-in non-openssl based _md5 and _sha1 module exist in
"fips" mode is a separate build time issue - lets keep this one jus
Changes by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue23894>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
nice find. did anyone's code actually run into this issue?
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/is
Gregory P. Smith added the comment:
Note that https://pypi.python.org/pypi/re2 exists today as well and offers a re
module compatible interface. I haven't tried it.
--
___
Python tracker
<http://bugs.python.org/issu
Changes by Gregory P. Smith :
--
versions: +Python 3.7 -Python 3.4
___
Python tracker
<http://bugs.python.org/issue1662581>
___
___
Python-bugs-list mailin
New submission from Gregory P. Smith:
https://github.com/python/cpython/blob/master/Modules/faulthandler.c#L240
faulthandler_dump_traceback() is called from the signal handler
faulthandler_fatal_error() which needs to be async signal safe and only call
async signal safe things...
but
Gregory P. Smith added the comment:
This report is based on manual code inspection in CPython head after we
encountered a deadlock using pytracemalloc on Python 2.7.12 where it _appeared_
to be the scenario I've described.
I see now that I missed noticing the "#ifndef Py_HAVE_
Gregory P. Smith added the comment:
So... it looks like this could and does happen only on the 2.7 backport of
faulthandler. 2.7 is missing the following commit to use pthreads native TLS
instead of our lock filled non-async signal safe implementation:
https://github.com/python/cpython
Gregory P. Smith added the comment:
Based on the ideas thread it isn't obvious that chunk size means "per byte". I
suggest either specifying the number of base digits per delimiter. Or using a
name other than chunk that indicates it means bytes.
If we're going to do thi
Gregory P. Smith added the comment:
re-opening since, though released, this behavior change broke existing code.
--
nosy: +gregory.p.smith
resolution: fixed ->
stage: resolved -> commit review
status: closed -> open
___
Python track
Gregory P. Smith added the comment:
release managers need to decide.
--
priority: normal -> release blocker
___
Python tracker
<http://bugs.python.org/issu
Changes by Gregory P. Smith :
--
nosy: +jcea -gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue30257>
___
___
Python-bugs-list mailing list
Unsub
Gregory P. Smith added the comment:
Please DO NOT REMOVE select.poll() on MacOS. It is still useful.
Apple needs to live with their bug that they refuse to acknowledge by forcing
developers to learn the special case that it now breaks in (0 fds). We should
not pretend that poll() does not
Gregory P. Smith added the comment:
The only thing CPython should do is apply workarounds to any standard library
internal uses of poll with 0 fds guarded by a MacOS platform check.
--
___
Python tracker
<http://bugs.python.org/issue28
Changes by Gregory P. Smith :
--
assignee: gregory.p.smith ->
___
Python tracker
<http://bugs.python.org/issue6931>
___
___
Python-bugs-list mailing list
Un
Changes by Gregory P. Smith :
--
nosy: -gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue6931>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
I'm rejecting this one as low value / infeasible.
--
assignee: gregory.p.smith ->
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.p
Gregory P. Smith added the comment:
Do we need to work around this issue at all?
Apple appears to have fixed it already:
https://github.com/opensource-apple/xnu/commit/0cccba1c831cfe36f0d67d672f8aa67b4a7d4b6a#diff-e61c2932bb9d5cea2dd0732acd8ec626R1783
A comment in https://github.com/curl
Gregory P. Smith added the comment:
you can list me as a oss-fuzz contact. use my work email address.
simplejson is worthy but as both it and the python standard library ship
separately people use both so they both ultimately deserve fuzzing and fixing
on their own so I'd add it to CP
Gregory P. Smith added the comment:
Follow up note:
Note that even with POSIX TLS in use, it isn't entirely safe.
pthread_getspecific() as used by the posix thread code is not required to be
async signal safe by the POSIX standard. :(
The Linux glibc implementation thankfully does no
Gregory P. Smith added the comment:
Yes, this appears true.
I'm okay with it because I've always considered the make, test, and install as
different command invocations. The package building automation I am aware of
tends to do the same. Our buildbots keep the steps separate.
B
Gregory P. Smith added the comment:
I think adding these parameters to the zlib.compress() function is a fine
addition for 3.7. They are more convenient for those (few) who do need them.
I'd go ahead and turn it into a cpython PR.
--
nosy: +gregory.p.
Gregory P. Smith added the comment:
re: Paul's "I'm not sure I see why you'd want to run lib2to3 with the embedded
distribution anyway. Surely you'd do any 2to3 conversion in a normal
development installation"
lib2to3 is a library useful for doing things with P
Gregory P. Smith added the comment:
You cannot safely use Python's os.fork() in a process that has threads.
Because of POSIX.
The CPython interpreter is by definition not async signal safe so no Python
code may safely be executed after the fork() system call if the process
contained
Changes by Gregory P. Smith :
--
pull_requests: +1843
___
Python tracker
<http://bugs.python.org/issue29335>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
New changeset 56bc3b768c3cc3817031b56d5e7a279aa1296bc9 by Gregory P. Smith in
branch 'master':
bpo-29335 - apply suggested test_subprocess simplifications from haypo and
Zach: (#1757)
https://github.com/python/cpyt
Changes by Gregory P. Smith :
--
pull_requests: +1859
___
Python tracker
<http://bugs.python.org/issue9146>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
Fixed applied to subprocess32 in
https://github.com/google/python-subprocess32/commit/0f1958e982bf44db569470def7281bcafa2a8b0e
--
stage: commit review -> resolved
status: open -> closed
___
Python tracker
Gregory P. Smith added the comment:
Would PyThread_free_lock (effectively sem_destroy()) work without (additional)
problems?
--
___
Python tracker
<http://bugs.python.org/issue30
Gregory P. Smith added the comment:
New changeset 07244a83014fad42da937c17d98474b47a570bf7 by Gregory P. Smith in
branch 'master':
bpo-9146: Raise a ValueError if OpenSSL fails to init a hash func. (#1777)
https://github.com/python/cpython/commit/07244a83014fad42da937c17d98474
Gregory P. Smith added the comment:
Another alternative *might* be to check if the lock is locked (non-blocking
acquire?) and release it if so. Under the normal assumption that we are the
only thread running immediately post-fork().
I'm not sure that can be guaranteed reliable given
Gregory P. Smith added the comment:
Resolved for 3.7, assigning to christian to deal with the backports as I
believe he has employer motivation to see those in (should be trivial).
--
assignee: gregory.p.smith -> christian.heimes
resolution: -> fixed
stage: patch review ->
New submission from Gregory P. Smith:
I never do in-tree builds anymore because they make me feel dirty and leave
build artifacts cluttering up my source tree.
make clinic does not work for out of tree builds.
To reproduce:
~$ git clone ...cpython repo...
~$ mkdir build && cd build
Changes by Gregory P. Smith :
--
pull_requests: +1917
___
Python tracker
<http://bugs.python.org/issue16500>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
The Makefile knows where the source tree is, I think we can make it tell
clinic.py. Let me whip something up.
--
___
Python tracker
<http://bugs.python.org/issue30
Changes by Gregory P. Smith :
--
pull_requests: +1920
___
Python tracker
<http://bugs.python.org/issue30492>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
My PR doesn't address the potential issue of needing to have done a make all
before doing a make clinic. I'll leave that for something else, there could be
bootstrapping issues in that situation depending on what the developer is doing.
In that l
Gregory P. Smith added the comment:
New changeset 178418ad6791b6ef5ba610ed93fab75fc1567ad2 by Gregory P. Smith in
branch 'master':
bpo-30492: Allow make clinic to work out of tree. (#1836)
https://github.com/python/cpython/commit/178418ad6791b6ef5ba610ed93fab7
2001 - 2100 of 3453 matches
Mail list logo
