New submission from Gregory P. Smith:
This makes all existing bytesobject.c methods use the buffer API rather
than explicitly requiring bytes objects as input. It also fixes input
to append() and remove() that was not strict enough and improves a few
unit tests in that area.
NOTE: this patch
Changes by Gregory P. Smith:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Gregory P. Smith added the comment:
> > Patch updated. It now implements the is*() methods for PyBytes. It
> > moves common code into a shared bytes_ctype.c and .h file so that
> > stringobject.c and bytesobject.c can share as much as possible.
>
> Did you move
Changes by Gregory P. Smith:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Changes by Gregory P. Smith:
--
nosy: -gps
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubs
Gregory P. Smith added the comment:
heh yep that does look like a bug. Laughing at that one goes well with
this comment currently in test_dbshelve.py:
# TODO: Add test cases for a DBShelf in a RECNO DB.
i'll fix it. :)
__
Tracker <[EMAIL PROTECTED
New submission from Gregory P. Smith:
If a bsddb.db.DB object is closed before any DBCursor objects
referencing it are closed, python will crash when the cursors are closed
or deleted.
Workaround: never close a database with open cursors. this is annoying
in unittest code where a tearDown
Gregory P. Smith added the comment:
Fixed in python trunk r58434, release25-maint r58435, py3k r58438
--
resolution: -> fixed
status: open -> closed
versions: +Python 2.6, Python 3.0
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Gregory P. Smith:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
New submission from Gregory P. Smith:
The PyBytes (pep3137 buffer) .extend() method currently only accepts as
input something supporting the pep3118 buffer API. It also needs to
accept an iterable of ints in the 0..255 range.
--
keywords: py3k
messages: 56478
nosy: gregory.p.smith
Changes by Gregory P. Smith:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Changes by Gregory P. Smith:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
Gregory P. Smith added the comment:
Committed revision 58493
--
resolution: -> accepted
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
Changes by Gregory P. Smith:
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1261>
__
___
Python-bugs-list mailing list
Unsubscribe:
http://mail.python.org/mai
New submission from Stephen P. Schaefer:
The following fails with python 2.5 as built by Fedora 7:
t2.py:
import sys, Tkinter
Tkinter.Button(text=u"").pack( )
Tkinter.mainloop( )
$ python t2.py
python: ./Modules/_tkinter.c:941: AsObj: Assertion `size < size *
sizeof(Tcl_Uni
Changes by Gregory P. Smith:
--
nosy: +gregory.p.smith
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1247>
__
___
Python-bugs-list mailing list
Unsubs
Gregory P. Smith added the comment:
This should be fixed in py3k revision 58761.
--
keywords: +py3k
resolution: -> fixed
status: open -> closed
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.pytho
New submission from Gregory P. Smith:
I'm attaching the patch to add this method here just as a place to track
it for now. It compiles and it looks right, but it causes a crash
within BerkeleyDB when the test case runs using BerkeleyDB 4.6.21. It
passes as expected when using 4.4.20 or 4
Gregory P. Smith added the comment:
option 1 sounds best. i'll take care of this. thanks for noticing this
and providing suggestions and a patch.
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python
Changes by Gregory P. Smith:
--
components: +Library (Lib) -None
versions: +Python 2.5, Python 2.6
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/issue1385>
__
__
Gregory P. Smith added the comment:
Fixed in trunk (2.6) svn revision 58868 with rfc 4231 unit tests and
tests for the new warnings.
The fix parts of that diff should be backported to 2.5. I'm leaving the
Python 2.5 flag on the bug until that happens.
I'm leaving Python 3.0 and py
Gregory P. Smith added the comment:
Fixed in release25-maint branch in svn r58870.
--
versions: -Python 2.5
__
Tracker <[EMAIL PROTECTED]>
<http://bugs.python.org/
Gregory P. Smith added the comment:
yeah i've seen this at random times as well. I don't believe its
related to py3k or the pep3137 branch at all, i believe seen it on trunk
but its rare.
For reference, what platform (OS) and BerkeleyDB version did you build
python with when thi
Gregory P. Smith added the comment:
release25-maint and trunk (2.6) appear to do the correct thing when
testing on my ubuntu gutsy linux x86 box. test script and file attached.
The problem is reproducable in a release24-maint build compiled 2007-11-05.
--
nosy: +gregory.p.smith
Added
Gregory P. Smith added the comment:
attaching the test input file. use od -x or similar to compare the
new.csv output with issue1511.csv to see if the problem happened.
its 2.4.. that may be old enough to be considered dead
Added file: http://bugs.python.org/file8817/issue1511.csv
Gregory P. Smith added the comment:
If the server failed to close a transaction the protocol stream is over
unless you mime relying on hope and luck. Poplib has a nasty set of server
implementation bugs to work around here.
Readline as defined today no longer suits its needs but I still
Gregory P. Smith added the comment:
This looks like a bug in your daemon not in subprocess. Your daemon is
intentionally not closing its inherited stderr fd.
--
nosy: +gregory.p.smith
resolution: -> invalid
status: open -> closed
___
Gregory P. Smith added the comment:
+1 nice! A couple minor comments on the code review.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue13
Gregory P. Smith added the comment:
Why make this decision ourselves at all? Copy what Mozilla and Chromium do
by default.
--
___
Python tracker
<http://bugs.python.org/issue13
Michael P. Reilly added the comment:
I'm seeing that shutdown does have a race condition just using
BaseHTTPServer.HTTPServer. See the attached simple script. Then access
http://localhost:8081. This is using both Python 2.6.6 (r266:84292, May 22
2011, 16:47:42) on Oracle Linux Serve
Gregory P. Smith added the comment:
http://pypi.python.org/pypi/unittest2 says
"There are several places in unittest2 (and unittest) that call str(...) on
exceptions to get the exception message. This can fail if the exception was
created with non-ascii unicode. This is rare and I
Gregory P. Smith added the comment:
We're on python 2.6, otherwise this would be a moot point. but you might want
to include something like that in a new unittest2 backport release.
--
___
Python tracker
<http://bugs.python.org/i
Michael P. Reilly added the comment:
Here is a patch to socketserver.py which can be applied to 2.6, 2.7 and 3.2.
The fix is for BaseServer, ForkingMixIn and ThreadingMixIn. All three now
correctly respond to the shutdown method. I have no way of testing Windows or
MacOSX (based on docs
Michael P. Reilly added the comment:
An update test program. Execute with appropriate PYTHONPATH (to dir to patched
module and explicit interpreter executable: PYTHONPATH=$PWD/2.7/b/Lib python2.7
$PWD/simpletest.py
--
Added file: http://bugs.python.org/file24094/simpletest.py
Gregory P. Smith added the comment:
I just nuked the pure Python POSIX subprocess implementation in
70467:75ca834df824. No need for both implementations. _posixsubprocess is now
the only option.
--
___
Python tracker
<http://bugs.python.
Gregory P. Smith added the comment:
Include an appropriate Version Added annotation in the pipe2 documentation.
Otherwise the current patches look good to me.
--
___
Python tracker
<http://bugs.python.org/issue12
Gregory P. Smith added the comment:
I added comments in the code review.
this patch is looking good once the comments are addressed. thanks for your
contribution!
As for talk of support for recursion... thats what os.walk() is for. it
doesn't belong as part of any particular indiv
Gregory P. Smith added the comment:
This was fixed in the other bug in 2.6 and 2.7.
--
dependencies: +socket.readline() interface doesn't handle EINTR properly
nosy: +gregory.p.smith
resolution: -> fixed
status: open -> closed
___
Pyt
New submission from Gregory P. Smith :
The file object readline() and readlines() methods can lose data when an
underlying read system call is interrupted. They will abort with an IOError in
this case but any incomplete line data they have read will be discarded.
readline() and readlines
Gregory P. Smith added the comment:
3.x has the same issue. unittest & patch forthcoming that addresses that as
well.
2.6 also has the issue but it is in security fix only mode so I won't backport
to that.
--
versions: +Python 3.1, Python 3.2, P
Gregory P. Smith added the comment:
.readall() and the equivalent unbounded .read() also have this problem.
--
title: file readline & readlines methods can lose data on EINTR -> file
readline, readlines & readall methods can lose da
Changes by Gregory P. Smith :
Added file: http://bugs.python.org/file22261/test_fileio_readers_3.2-gps01.diff
___
Python tracker
<http://bugs.python.org/issue12
Gregory P. Smith added the comment:
I haven't looked beyond the reading methods it is possible that some of the
write implementations have a similar issue. Patch gps02 for 3.2 attached.
I'll use that as the basis for a stand alone test_file_eintr.py targeted at 2.7.
--
Changes by Gregory P. Smith :
Removed file:
http://bugs.python.org/file22261/test_fileio_readers_3.2-gps01.diff
___
Python tracker
<http://bugs.python.org/issue12
Changes by Gregory P. Smith :
--
nosy: +pitrou
___
Python tracker
<http://bugs.python.org/issue12268>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
This makes sense, I'll add it to 3.3.
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
That failure is likely due to the environment being empty causing the
subprocess to be unable to run. Notice this error message further up:
test_empty_env (test.test_subprocess.ContextManagerTests) ...
/srv/buildbot/buildarea/3.2.bolen-ubuntu/build/python
Gregory P. Smith added the comment:
No Python thread is ever fork safe because the Python interpreter itself can
never be made fork safe. Nor should anyone try to make the interpreter itself
safe. It is too complex and effectively impossible to guarantee.
There is no general solution to this
Gregory P. Smith added the comment:
The fact that it called __get_builtin_constructor implies that the ssl backed
_hashlib module was not available. It looks like the non-openssl standalone
_sha256 module (and likely the _sha512 module) both failed to be compiled.
I would not expect that to
Gregory P. Smith added the comment:
Being able to set which behavior you want in a (?XXX) flag at the start of the
regex is valuable so that applications that take a regex can support the new
syntax automatically when the python version they are running on is updated.
The (?XXX) should
Gregory P. Smith added the comment:
Are there any applications out there that actually rely on forking during
import?
(someone discovered this bug... i'd like to know why. i think its a disgusting
thing to do but never explicitly disallowed it in the
Gregory P. Smith added the comment:
Agreed on the explicit exception and documentation. :)
--
___
Python tracker
<http://bugs.python.org/issue9573>
___
___
Pytho
Gregory P. Smith added the comment:
your updated patch looks good to me. i've posted it here for easy review if
anyone else wants to take a look:
http://codereview.appspot.com/1995049/
--
assignee: gregory.p.smith -> pitrou
___
Python
Gregory P. Smith added the comment:
closing because it is too late to backport this to 2.7. It is available as a
backport in http://code.google.com/p/python-subprocess32/.
As for the idea of not using SIG_IGN and installing a default no-op handler,
that is another approach
Gregory P. Smith added the comment:
Sounds like a good idea. frozensets for both.
--
___
Python tracker
<http://bugs.python.org/issue7418>
___
___
Python-bug
Gregory P. Smith added the comment:
Implemented in py3k r84554.
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue7418>
___
___
Python-
Gregory P. Smith added the comment:
libtomcrypt is a _great_ library. That is what hashlib uses for the hash
algorithms when OpenSSL is not available.
But the _primary_ reason for using OpenSSL is that it is the defacto open
source location for the best architecture specific implementations
Gregory P. Smith added the comment:
Overall I like the approach.
A few questions / clarifications:
is errno.EMFILE portable? will that errno test work on both posix and
windows?
should the is_resource_enabled('subprocess') stuff be preserved (why was it
there to begin with? b
Gregory P. Smith added the comment:
looks good to me. commit it. :)
--
Added file: http://bugs.python.org/file18924/unnamed
___
Python tracker
<http://bugs.python.org/issue9895>
___looks good to me. Â com
Gregory P. Smith added the comment:
This bug has turned into a bikeshed.
Lets stop that please.
I _DON'T_ care about performance when it comes to someone submitting an
actual working implementation of a crypto library for inclusion with the
standard library. The first priority needs to
Gregory P. Smith added the comment:
thanks Antoine!
--
Added file: http://bugs.python.org/file19042/unnamed
___
Python tracker
<http://bugs.python.org/issue9950>
___thanks A
Gregory P. Smith added the comment:
can i have you do another experiment here?
after you "ssh r...@testbox /tmp/test.{py,sh}" can you:
1) login to testbox, run pstree -p
2) run an strace -p pid_of_python_or_bash >strace_for_foo.out (for each of the
test.py and test.sh
Gregory P. Smith added the comment:
Ah right, thanks. I added a restore_signals=True argument to Popen in Python
3.2's subprocess module that does what you want:
http://docs.python.org/dev/library/subprocess.html
The way to emulate that in earlier versions is to use a preexec_fn to re
Gregory P. Smith added the comment:
A workaround for those still having problems with this:
stub out subprocess._cleanup with a no-op method.
It it only useful if your app is ever using subprocess and forgetting to call
wait() on Popen objects before they are deleted. If you are, you can
Gregory P. Smith added the comment:
looks harmless to me. though i think issue812369 looks okay as well at first
glance.
--
___
Python tracker
<http://bugs.python.org/issue1545
Gregory P. Smith added the comment:
0001-update-GC-shutdown-patch.patch looks sane to me at first glance. any
other opinions?
--
___
Python tracker
<http://bugs.python.org/issue812
Gregory P. Smith added the comment:
I don't see this issue on netbsd 5.0.2 i386 in the py3k branch.
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issu
Gregory P. Smith added the comment:
netbsd-wizs-mod.patch applied in 85587.
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
resolution: -> accepted
stage: -> committed/rejected
status: open -> closed
___
Python tr
Gregory P. Smith added the comment:
fyi - for information on using gdb 7 with python see
http://bugs.python.org/issue8032
I'm looking at the .gdbinit improvements regardless as not everyone has gdb 7
(notably OS X).
--
resolution: out of date ->
status: closed
Gregory P. Smith added the comment:
everything except the lineno change from gdbinit_python26.patch has been
committed in r85646.
--
___
Python tracker
<http://bugs.python.org/issue3
Gregory P. Smith added the comment:
and the py_decref in there isn't quite right, fixing...
--
___
Python tracker
<http://bugs.python.org/issue3631>
___
___
Gregory P. Smith added the comment:
do we have official python docs on this that I should point to?
--
___
Python tracker
<http://bugs.python.org/issue3
Gregory P. Smith added the comment:
I updated the note in gdbinit to point to Tools/gdb/libpython.py for py3k (3.2)
and 2.7.
Thomas: I didn't do anything with your version of pystack because the existing
versions in 3.2 and 2.7 appear to work fine for me.
--
resolution: ->
Gregory P. Smith added the comment:
This is an application specific optimization that I'd like to see as its own
library or a feature added to NSS or OpenSSL. Regardless if you want this for
python, write an extension module and put it on pypy before aiming for the
stdlib. I understan
Gregory P. Smith added the comment:
fyi - while I still need to update it now that 3.2 final has been released, the
http://code.google.com/p/python-subprocess32/ project has a backport of the
_posixsubprocess stuff from python 3.2 for use on Python 2.x
Gregory P. Smith added the comment:
There is no OS API call to provide a *safe* way to get a list of all open file
descriptors as part of POSIX in general that can be called after the fork() and
before the exec(). It must be async signal safe. The closefrom() call
available in Solaris and
Gregory P. Smith added the comment:
According to http://www.unix.com/man-page/All/3c/closefrom/ closefrom() is not
async-signal-safe. :(
--
___
Python tracker
<http://bugs.python.org/issue11
Gregory P. Smith added the comment:
subprocess in 3.2 bug from the looks of it. not sure if 2.7 or 3.1 are
impacted at all, i'll remove them from the list after confirming.
--
assignee: -> gregory.p.smith
___
Python tracke
Gregory P. Smith added the comment:
Could you add me as a member or admin on the mrab-regex-hg project? I've got a
few things I want to fix in the code as I start looking into the state of this
module. gpsmith at gmail dot com is my google account.
There are some fixes in the ups
Gregory P. Smith added the comment:
Okay. Can you push your setup.py and README and such as well? Your pypi
release tarballs should match the hg repo and ideally include a mention of
what hg revision they are generated from. :)
-gps
On Mon, Mar 14, 2011 at 5:25 PM, Matthew Barnett wrote
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
keywords: +patch
nosy: +gregory.p.smith
Added file: http://bugs.python.org/file21215/_cursesmodule.c.diff
___
Python tracker
<http://bugs.python.org/iss
Changes by Gregory P. Smith :
--
assignee: gregory.p.smith ->
nosy: +loewis
___
Python tracker
<http://bugs.python.org/issue1006238>
___
___
Python-bugs-lis
Changes by Gregory P. Smith :
--
assignee: gregory.p.smith ->
nosy: +loewis
___
Python tracker
<http://bugs.python.org/issue3718>
___
___
Python-bugs-list mai
Gregory P. Smith added the comment:
a test would still be a good thing but this should be fixed regardless.
--
resolution: -> accepted
status: open -> closed
___
Python tracker
<http://bugs.python.org/
Gregory P. Smith added the comment:
assertCountEqual has been released in 3.2 as the new name. close this?
--
___
Python tracker
<http://bugs.python.org/issue10
Changes by Gregory P. Smith :
--
resolution: -> fixed
status: open -> closed
versions: -Python 2.7, Python 3.1
___
Python tracker
<http://bugs.python.org/i
Gregory P. Smith added the comment:
I added some comments on the review for 10812_v5.patch. not sure why v6
doesn't have a review link. Overall, very nice after addressing the few
comments I had.
btw, can you sync this up with the hg tip (3.3) now while addressing the above?
I'
Gregory P. Smith added the comment:
ross's patch looks good to me.
Isn't the behavior just plain broken in 3.1 and 3.2? The docs say that the
default bufsize=0 is unbuffered in Popen but the implementation has that nasty
XXX to make it line buffered instead of unbuffered in
Gregory P. Smith added the comment:
to get that behavior, change the =1 default to =io.DEFAULT_BUFFER_SIZE in
ross's patch.
--
___
Python tracker
<http://bugs.python.org/is
Gregory P. Smith added the comment:
yeah i figured importing io from os at the top level might be a problem. it is
not important for the default to be that exact value, even something safely on
the small side like 512 will work. but we could just have the default be set
in the code by doing
Gregory P. Smith added the comment:
not yet, thanks for the reminder. if any other committers feel like jumping on
this and doing it before I get around to it, feel free.
--
___
Python tracker
<http://bugs.python.org/issue11
Gregory P. Smith added the comment:
heh yeah. while all hash functions do have internal state and someone
could conceivably want to store such a state (it basically amounts to
queued up partial block of input data if any and the current starting
IV) there are not consistent APIs to expose that
Gregory P. Smith added the comment:
Adding that check with an exception to selectmodule.c is a good idea.
i like your patch.
--
___
Python tracker
<http://bugs.python.org/issue11
Gregory P. Smith added the comment:
Those tests make sense to me.
--
Added file: http://bugs.python.org/file21875/unnamed
___
Python tracker
<http://bugs.python.org/issue6721>
___Those tests make sense
Gregory P. Smith added the comment:
I didn't initially like the idea of __exit__ blocking on another
process... but the zombie issue is real does make me think we should
reconsider this and have it wait().
It is a backwards incompatible change if anyone has started using the
Popen co
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue12044>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
did my commits in the reverse order (default before 3.2), oops. this is fixed.
this wasn't ever in 2.7 so no need for the documentation note. i'm not
worried about adding a note about 3.2.0 vs 3.2.1 beyond the mention in
Misc/NEWS as this
Gregory P. Smith added the comment:
That looks better. :)
btw, that eintr_retry utility probably deserves to be in a more
prominent place in the stdlib but I don't have a good suggestion as to
where at the moment. I believe similar code exists in many places in
the code base.
If it i
Changes by Gregory P. Smith :
--
assignee: -> gregory.p.smith
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.or
Gregory P. Smith added the comment:
if you used the pipe approach you'd need to deal with the case of the write
blocking (or failing if nonblocking) when the pipe buffer is full. also you'd
need to block signals around a fork and reinitialize the pipe in the child
before reenabli
201 - 300 of 3452 matches
Mail list logo
