Change by Gregory P. Smith :
--
pull_requests: -2
___
Python tracker
<https://bugs.python.org/issue36533>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
The gps-* bots have been updated.
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue41642>
___
___
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue29988>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
On POSIX systems, keeping the file open means you will keep a handle to the
original file in the case where something moves a new file into it's place (as
is normal during software package updates) or otherwise unlinks the original.
That is the situ
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: backport needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
stage: backport needed -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue9146>
___
___
Gregory P. Smith added the comment:
It's a known issue and has been outlined very well and still comes up from time
to time in real world applications, which tend to see this issue and Dave's
presentation and just work around it in any way possible for their system and
move on
Gregory P. Smith added the comment:
looks like it, thanks!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.9
___
Python tracker
<https://bugs.python.org/issue40423>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
for reference, very recent Linux kernels appear to have gained a close_range
syscall. http://lkml.iu.edu/hypermail/linux/kernel/2008.0/02649.html
Your diff isn't quite sufficient as is. When depending on a syscall that has a
function provided by
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue40422>
___
___
Python-
Change by Gregory P. Smith :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue40422>
___
___
Pyth
Gregory P. Smith added the comment:
Ah, yeah ENOSYS is it. I had to do this trick in older subprocess versions for
something else. Still visible here in the old 2.7 backport:
https://github.com/google/python-subprocess32/blob/main/_posixsubprocess.c#L801
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue40423>
___
___
Python-bugs-list mailing list
Un
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
Just reuse this bpo issue. I'll mark the PRs as "skip news"; don't worry about
a new news blurb entry as it's all tied to the original one.
--
status: closed -> open
___
Python track
Gregory P. Smith added the comment:
New changeset 64eb259cc1e42a5f74b5911a518d2c50daa8d50b by Kyle Evans in branch
'master':
bpo-40422: Move _Py_*_SUPPRESS_IPH bits into _Py_closerange (GH-22672)
https://github.com/python/cpython/commit/64eb259cc1e42a5f74b5911a518d2c
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue41972>
___
___
Python-bugs-list mailing list
Unsubscribe:
Gregory P. Smith added the comment:
FWIW I think your numbers look good, a small needle cut-off is likely a good
idea.
--
___
Python tracker
<https://bugs.python.org/issue41
Gregory P. Smith added the comment:
Another potential algorithm to consider in large needle situations is a
Rabin-Karp rolling hash string search.
If used, it's the kind of algorithm that I'd probably bail out to an alternate
method on if a run of Rabin-Karp started having a high
Gregory P. Smith added the comment:
I assume a rolling hash is linear at best, even if you do add some skip ahead
checks.
--
___
Python tracker
<https://bugs.python.org/issue41
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue38693>
___
___
Python-bugs-list m
Gregory P. Smith added the comment:
Status: Waiting until after the importlib.metadata and importlib.resources
backports drop support for both Python 2.7 and 3.5 as keeping them in sync
would be a pain for maintainers (per jaraco on our sprint importlib-any chat
today
Gregory P. Smith added the comment:
thanks Kyle!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Gregory P. Smith :
--
assignee: gregory.p.smith ->
stage: patch review ->
___
Python tracker
<https://bugs.python.org/issue40360>
___
___
Pyth
Gregory P. Smith added the comment:
status: lib2to3 PendingDeprecationWarning shipped in 3.9. Since we don't have
a specific release planned for the final deprecation, I'll leave this issue
open while we figure that out. Once we do, we should promote this to a regular
Deprecat
Gregory P. Smith added the comment:
New changeset 23c0fb8edd16fe6d796df2853a5369fd783e05b7 by Ruben Vorderman in
branch 'master':
bpo-41586: Add pipesize parameter to subprocess & F_GETPIPE_SZ and F_SETPIPE_SZ
to fcntl. (GH-21921)
https://github.com/python/
Gregory P. Smith added the comment:
Thanks Ruben!
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
type: -> enhancement
___
Python tracker
<https://bugs.python
Gregory P. Smith added the comment:
Parsing support for `f(**mapping)` support is indeed still missing.
as lib2to3 is pending deprecation at this point, i'm not going to work on this.
anyone is welcome to pick it up. modifying the lib2to3 grammar, and any
related code, and adding a
Gregory P. Smith added the comment:
based on the reaction from those who own mock at this point, i'm going to close
this. shipping more handy mock matchers with mock makes sense to me as they
belong together. but i'm not willing to argue it if anyone thinks it'll be a
mai
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.8
___
Python tracker
<https://bugs.python.org/issue13501>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
2.7 is end of life.
if you have regular expression performance issues with something in 3, please
open a new issue.
--
nosy: +gregory.p.smith
resolution: -> wont fix
stage: -> resolved
status: pending -&g
Gregory P. Smith added the comment:
since the time this was filed, subprocess has evolved a lot and third party
options for child process have appeared as well as modern things like:
https://docs.python.org/3/library/asyncio-subprocess.html (stdlib)
https://trio.readthedocs.io/en/stable
Change by Gregory P. Smith :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
the slowest tests on Linux today (with number of seconds prepended on my system
that runs the suite serially in 34 seconds on a debug build):
3.01 test_check_output_stdout_arg (test.test_subprocess.ProcessTestCaseNoPoll)
... ok
3.01
Gregory P. Smith added the comment:
fyi - handy command to get that
python -m test.regrtest -v test_subprocess | ts '.%s'
then process that using whatever you want to compute deltas and sort. i fed
the output of that into:
```
#!/usr/bin/python3
"""Parse `python
Gregory P. Smith added the comment:
this caused a variety of buildbot failures. investigating.
--
resolution: fixed ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/i
Change by Gregory P. Smith :
--
pull_requests: +21793
stage: commit review -> patch review
pull_request: https://github.com/python/cpython/pull/22839
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset 786addd9d07b6c712b8ea9ee06e1f9f41c1b67a1 by Gregory P. Smith in
branch 'master':
bpo-41586: Attempt to make the pipesize tests more robust. (GH-22839)
https://github.com/python/cpython/commit/786addd9d07b6c712b8ea9ee06e1f9
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
If you use os.fork() or any of the multiprocessing start methods that call
os.fork() with a process involving threads, this is expected behavior.
os.fork() cannot be used in processes that have threads without potential for
deadlock.
Specifically, make
Gregory P. Smith added the comment:
New changeset 976da903a746a5455998e9ca45fbc4d3ad3479d8 by Alexey Izbyshev in
branch 'master':
bpo-35823: subprocess: Use vfork() instead of fork() on Linux when safe
(GH-11671)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
now waiting to see how happy all of the buildbots are...
We currently have a `__linux__` check in the code deciding VFORK_USABLE.
>From what I can tell, vfork probably also works on macOS (darwin).
Lets let this run for a bit on Linux and it can b
Gregory P. Smith added the comment:
> * To avoid repeating long parameter lists in several functions, we can move
> them to a struct. The downside is that we'd need to convert child_exec() to
> use that struct all over the place. I don't have a strong preference here.
A
Gregory P. Smith added the comment:
Thank you for taking this on! I'm calling it fixed for now as the buildbots
are looking happy with it. If issues with it arise we can address them.
--
resolution: -> fixed
stage: commit review -> resolved
status: ope
Gregory P. Smith added the comment:
New changeset 473db47747bb8bc986d88ad81799bcbd88153ac5 by Alexey Izbyshev in
branch 'master':
bpo-35823: subprocess: Fix handling of pthread_sigmask() errors (GH-22944)
https://github.com/python/cpython/commit/473db47747bb8bc986d88ad81799bc
Gregory P. Smith added the comment:
regarding excluding the setsid() case: I was being conservative as I couldn't
find a reference of what was and wasn't allowed after vfork.
I found one thing suggesting that on macOS setsid() was not safe after vfork().
But that appeared to b
Change by Gregory P. Smith :
--
pull_requests: +21863
pull_request: https://github.com/python/cpython/pull/22945
___
Python tracker
<https://bugs.python.org/issue35
Gregory P. Smith added the comment:
for what it's worth: false positives are always going to be possible in any
such "magic" check as is_zipfile is.
we don't check the start of the file because zip files are defined by their end
of file central directory which contains l
Gregory P. Smith added the comment:
New changeset be3c3a0e468237430ad7d19a33c60d306199a7f2 by Gregory P. Smith in
branch 'master':
bpo-35823: Allow setsid() after vfork() on Linux. (GH-22945)
https://github.com/python/cpython/commit/be3c3a0e468237430ad7d19a33c60d
Gregory P. Smith added the comment:
Nice links. LOL, yes, musl source was going to be my next stop if the larger
libc sources proved impossible for a mere mortal to reason about. :)
regarding macOS, agreed. If someone needs vfork() to work there, I believe it
could be made to.
Options
Gregory P. Smith added the comment:
Performance improvement measured on a 1.4Ghz quad aarch64 A57 (nvidia jetson
nano):
#define VFORK_USABLE 1
test_subprocess: 36.5 seconds
#undef VFORK_USABLE
test_subprocess: 45 seconds
Nice. I really didn't expect a 20% speedup on its testsuite
Gregory P. Smith added the comment:
New changeset c0590c0033e86f98cdf5f2ca6898656f98ab4053 by Alexey Izbyshev in
branch 'master':
bpo-42146: Fix memory leak in subprocess.Popen() in case of uid/gid overflow
(GH-22966)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
ZipFile.open() is not the code for opening a zip file. :)
That's the code for opening a file embedded within an already constructed
mode='r' archive as done the ZipFile.__init__() constructor. By the time
you've gotten to the open() m
Gregory P. Smith added the comment:
The first four bytes of the file do not identify a zip file. A zip file is
identified by the end of file central directory. Which you then must read
entries of to determine where the start of the archive may be... often not at
position zero
New submission from Gregory P. Smith :
The opcodes generated for the closure defining a class body looks like they
might be suboptimal. It seems stuck using the generic LOAD_NAME and STORE_NAME
opcodes rather than the LOAD_GLOBAL and STORE_FAST and friends as one would
expect and as happens
Gregory P. Smith added the comment:
New changeset d3b4e068077dd26927ae7485bd0303e09d962c02 by Alexey Izbyshev in
branch 'master':
bpo-42146: Unify cleanup in subprocess_fork_exec() (GH-22970)
https://github.com/python/cpython/commit/d3b4e068077dd26927ae7485bd0303
Change by Gregory P. Smith :
--
resolution: -> fixed
stage: patch review -> commit review
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
at a glance, it looks like the PR needs updating.
--
___
Python tracker
<https://bugs.python.org/issue13501>
___
___
Pytho
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue41877>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue41877>
___
___
Python-bugs-list mailing list
Un
Change by Gregory P. Smith :
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue24651>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.6
___
Python tracker
<https://bugs.python.org/issue24651>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
New changeset 4662fa9bfe4a849fe87bfb321d8ef0956c89a772 by vabr-g in branch
'master':
bpo-41877 Check for asert, aseert, assrt in mocks (GH-23165)
https://github.com/python/cpython/commit/4662fa9bfe4a849fe87bfb321d8ef0
Gregory P. Smith added the comment:
Thanks for the patch! I'm leaving this open as dealing with the other aspect:
* Wrong attribute names around asserts: autospect/auto_spec -> autospec,
set_spec -> spec_set
is still a possibility. (given you also found a number of those in ou
Gregory P. Smith added the comment:
I suspect so. If any modern supported python 3.x version runs into an issue
like this I think opening a fresh bugreport is good.
Closing as not reproducable / obsolete.
--
resolution: -> out of date
stage: test needed -> resolved
status
Gregory P. Smith added the comment:
my bad :)
--
resolution: -> not a bug
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
This bug was introduced into the Python 3.6.8 "bugfix" release.
https://github.com/python/cpython/pull/23231 will fix it if anyone needs that
on modern 3.6.
--
nosy: +gregory.p.smith
versions: +
New submission from Gregory P. Smith :
Python 3.7-3.10a1:
```
>>> List.__name__
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib/python3.8/typing.py", line 760, in __getattr__
raise AttributeError(attr)
AttributeError: __name__
>
Gregory P. Smith added the comment:
Not a big deal if we don't, I just found it odd so I figured I'd pose the
question. That it's been in three releases and only just now come up is
pretty telling that isn't critical.
The code in question was trying to identify public func
Gregory P. Smith added the comment:
working as intended, they aren't classes.
--
resolution: -> rejected
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
New submission from Gregory P. Smith :
A well known anti-pattern in Python is use of re.match when you meant to use
re.search.
re.fullmatch was added in 3.4 via https://bugs.python.org/issue16203 for
similar reasons.
re.prefixmatch would be similar: we want the re.match behavior, but want
Gregory P. Smith added the comment:
My point is that re.match is a common bug when people really want re.search.
re.prefixmatch makes it explicit and non-confusing and thus unlikely to be used
wrong or misunderstood when read or reviewed.
The term "match" when talking abo
New submission from Gregory P. Smith :
os.makedirs used to pass its mode argument on down recursively so that every
level of directory it created would have the specified permissions.
That was removed in Python 3.7 as https://bugs.python.org/issue19930 as if it
were a mis-feature. Maybe it
Gregory P. Smith added the comment:
This API change was not strictly a bugfix, it removed a feature existing code
was relying on.
https://bugs.python.org/issue42367 opened to reconcile the two.
--
nosy: +gregory.p.smith
___
Python tracker
<ht
Change by Gregory P. Smith :
--
type: behavior -> enhancement
___
Python tracker
<https://bugs.python.org/issue42367>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
For consistency, pathlib.Path.mkdir should also gain this option.
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
nosy: +gregory.p.smith
versions: +Python 3.10, Python 3.9
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
New changeset 31729366e2bc09632e78f3896dbce0ae64914f28 by Devin Jeanpierre in
branch 'master':
bpo-40791: Make compare_digest more constant-time. (GH-20444)
https://github.com/python/cpython/commit/31729366e2bc09632e78f3896dbce0
Gregory P. Smith added the comment:
I expect your overall logic is sound in the PR. But this is a public API
change, and while we've typically exempted lib2to3 from needing to concern
itself about deprecations and API changes by leaving it undocumented and
explicitly promising not to
Change by Gregory P. Smith :
--
resolution: -> wont fix
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Gregory P. Smith added the comment:
New changeset 01a202ab6b0ded546e47073db6498262086c52e9 by Filipe Laíns in
branch 'master':
bpo-40550: Fix time-of-check/time-of-action issue in
subprocess.Popen.send_signal. (GH-20010)
https://github.com/python/cpyt
Gregory P. Smith added the comment:
Thanks for the patch!
PRs are in or on their way in for 3.10 and 3.9.
The 3.8 auto-backport failed, if anyone wants it on a future 3.8.x please
follow up with a manual cherry pick to make a PR for the 3.8 branch.
--
resolution: -> fixed
st
Change by Gregory P. Smith :
--
versions: +Python 3.10 -Python 3.9
___
Python tracker
<https://bugs.python.org/issue36906>
___
___
Python-bugs-list mailin
Gregory P. Smith added the comment:
(assigning to me as I want to help remi.lapeyre's .dedent() method PR move
forward)
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org
Gregory P. Smith added the comment:
I expect several phases here:
(1) add a .dedent() method to str (and bytes?) - behaviors to consider
mirroring are textwrap.dedent() and inspect.cleandoc(). Given their utility
and similarities, it makes sense to offer both behaviors; behavior could be
Change by Gregory P. Smith :
--
keywords: +patch
pull_requests: +22357
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23467
___
Python tracker
<https://bugs.python.org/issu
Gregory P. Smith added the comment:
It was a mere oversight that this didn't handle text= the same as
universal_newlines=. I made a PR to keep their behavior consistent and match
the documentation.
--
___
Python tracker
<https://bugs.py
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue42388>
___
___
Python-bugs-list mailing list
Un
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue42443>
___
___
Python-bugs-list mailing list
Un
Change by Gregory P. Smith :
--
components: +Library (Lib)
___
Python tracker
<https://bugs.python.org/issue42443>
___
___
Python-bugs-list mailing list
Unsub
Change by Gregory P. Smith :
--
assignee: -> gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue42468>
___
___
Python-bugs-list mailing list
Un
Gregory P. Smith added the comment:
My concern with this as an API change is if anyone is returning or passing a
CompletedProcess instance around it may well be used in a context where None is
a potential value. Existing code in that situation would ordinarily be doing a
bare `if cp:` test
Gregory P. Smith added the comment:
Thanks for the suggestion though ThatXliner. It is good for us to keep these
things in mind for future API designs. That __bool__ exists and could be
meaningful in some contexts is often overlooked.
--
resolution: -> rejected
st
Gregory P. Smith added the comment:
Given that pickle is documented as:
"""
Warning The pickle module is not secure. Only unpickle data you trust.
It is possible to construct malicious pickle data which will execute arbitrary
code during unpickling.
"""
htt
New submission from Gregory P. Smith :
gzip.GzipFile accepts a fileobj parameter with an open file object.
Unfortunately gzip requires a filename be embedded in the gzip file and the
gzip module code uses fileobj.name to get that.
This results in the fake "" name from posixmodu
Gregory P. Smith added the comment:
A new lock type will NOT solve this. It is ALWAYS okay to clear all
thread/threading module locks after a fork.
They are and always have been process-local by definition so they are also by
definition 100% invalid to any child process.
Anyone who has
Gregory P. Smith added the comment:
Reopening. Comments added to the code review.
This issue is independent of the subprocess module issue in #8052. The
_posixsubprocess.c has its own fd closing loop.
http://hg.python.org/cpython/file/050c07b31192/Modules/_posixsubprocess.c#l118
1601 - 1700 of 3453 matches
Mail list logo
