[issue38435] Start the deprecation cycle for subprocess preexec_fn

2021-08-28 Thread Gregory P. Smith
Gregory P. Smith added the comment: A worthwhile general suggestion on a new path forward for the mess of things between (v)fork+exec from Victor is over in https://bugs.python.org/issue42736#msg383869 TL;DR creating a subprocess.Preexec() recording object with specific interfaces for

[issue40360] Deprecate lib2to3 (and 2to3) for future removal

2021-09-01 Thread Gregory P. Smith
Gregory P. Smith added the comment: I think we just forgot to make the change in time. 3.11 is fine. We're not _maintaining_ lib2to3 or describing it as fit for any modern purpose regardless. It's just code that'll sit around in the back of the 3.10 stdlib but not be ab

[issue44091] traceback & inspect modules should verify that the .py source file matches the one that the running process is using

2021-09-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: FWIW I don't remember the context that led me to just file the issue this year. The most serious frequent instances of this I remember happening were all many years ago when a less capable software distribution mechanism was in use. A scenario wh

[issue45196] macOS. ./configure --with-address-sanitizer; make test; cause test case crash.

2021-09-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset b668cdfa09e9bdfcfddaadd23dbd455d5f667383 by junyixie in branch 'main': bpo-45196: prevent unittest crash on address sanitizer builds (GH-28331) https://github.com/python/cpython/commit/b668cdfa09e9bdfcfddaadd23dbd45

[issue45196] macOS. ./configure --with-address-sanitizer; make test; cause test case crash.

2021-09-14 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith versions: +Python 3.10, Python 3.9 ___ Python tracker <https://bugs.python.org/issue45196> ___ _

[issue45196] macOS. ./configure --with-address-sanitizer; make test; cause test case crash.

2021-09-14 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue40746] test_gdb failing on 32-bit armv7l when built with GCC -Og: Cannot access memory at address 0xfffffedc

2021-09-15 Thread Gregory P. Smith
Gregory P. Smith added the comment: fwiw I updated my arm raspbian buildbot from raspbian Buster to raspbian Bullseye in the last few days. That could also explain the difference. More recent toolchain versions. -- ___ Python tracker <ht

[issue40746] test_gdb failing on 32-bit armv7l when built with GCC -Og: Cannot access memory at address 0xfffffedc

2021-09-15 Thread Gregory P. Smith
Gregory P. Smith added the comment: although it looks like the 3.10 failure you linked to ran after that. so... the upgrade may not explain things. -- ___ Python tracker <https://bugs.python.org/issue40

[issue45021] concurrent.futures race condition

2021-09-20 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 0bfa1106acfcddc03590e1f5d6789dbad3affe70 by nullptr in branch 'main': bpo-45021: Fix a hang in forked children (GH-28007) https://github.com/python/cpython/commit/0bfa1106acfcddc03590e1f5d6789dbad3affe70 -- nosy: +grego

[issue45021] concurrent.futures race condition

2021-09-20 Thread Gregory P. Smith
Gregory P. Smith added the comment: I expect the unittest for this might causes hangs on some platforms in the future as it mixes fork and threads which is a posix-nono. If so, we should just disable it on all but specific known-to-pass build configs as a future PR. 3.9 and 3.10 PRs will

[issue42969] pthread_exit & PyThread_exit_thread from PyEval_RestoreThread etc. are harmful

2021-09-22 Thread Gregory P. Smith
Gregory P. Smith added the comment: I believe jbms is right that pausing the threads is the only right thing to do when they see tstate_must_exit. The PR is likely correct. -- versions: +Python 3.11, Python 3.9 ___ Python tracker <ht

[issue42969] pthread_exit & PyThread_exit_thread from PyEval_RestoreThread etc. are harmful

2021-09-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: A PR adding a `Py_SetThreadExitCallback(func)` API guaranteeing the callback is called before `pthread_exit()` would allow anyone wanting to deal with their deadlocks to register `abort()` or `while(1) pause();` as their exit callback. I'd be okay

[issue42969] pthread_exit & PyThread_exit_thread from PyEval_RestoreThread etc. are harmful

2021-09-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: **If** we add a callback API for this, I agree with vstinner's https://bugs.python.org/issue42969#msg402558 commentary on the other callback APIs. We can do this one similarly and keep it simple. - Why? It's the initial simplicity that prov

[issue38435] Start the deprecation cycle for subprocess preexec_fn

2021-10-01 Thread Gregory P. Smith
Gregory P. Smith added the comment: Another use case someone had for preexec_fn popped up today: prctl(PR_SET_PDEATHSIG, SIGTERM) -- ___ Python tracker <https://bugs.python.org/issue38

[issue32307] Bad assumption on thread stack size makes python crash with musl libc

2021-10-04 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue32307> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32307] Bad assumption on thread stack size makes python crash with musl libc

2021-10-04 Thread Gregory P. Smith
Gregory P. Smith added the comment: I left some comments on the PR. We can at least make it detect musl libc and improve its default behavior there. FWIW CPython's recursionlimit and the C stack have long been a thorn in the side of many things. Even when Python's thread_pt

[issue45408] [fuzzer] Weird input with continuation and newlines causes null deref in parser

2021-10-07 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.10, Python 3.9 ___ Python tracker <https://bugs.python.org/issue45408> ___ ___ Python-bugs-list mailin

[issue45408] [fuzzer] Weird input with continuation and newlines causes null deref in parser

2021-10-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: (unable to reproduce on 3.9) -- nosy: +gregory.p.smith versions: -Python 3.9 ___ Python tracker <https://bugs.python.org/issue45

[issue45408] [fuzzer] Weird input with continuation and newlines causes null deref in parser

2021-10-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: Marking release blocker as a crash is bad for a function that is documented as safe for use on untrusted input so long as it isn't large enough to overflow the stack. https://docs.python.org/3/library/ast.html#ast.literal_eval -- priority: n

[issue45353] sys.modules: dictionary changed size during iteration

2021-10-09 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +27154 stage: test needed -> patch review pull_request: https://github.com/python/cpython/pull/28842 ___ Python tracker <https://bugs.python.org/issu

[issue45353] sys.modules: dictionary changed size during iteration

2021-10-09 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 3d1ca867ed0e3ae343166806f8ddd9739e568ab4 by Gregory P. Smith in branch 'main': bpo-45353: Remind sys.modules users to copy when iterating. (GH-28842) https://github.com/python/cpython/commit/3d1ca867ed0e3ae343166806f8ddd9

[issue45353] sys.modules: dictionary changed size during iteration

2021-10-09 Thread Gregory P. Smith
Gregory P. Smith added the comment: While arguably unnecessary as it is documented as a dictionary and this is a normal Python dict behavior, it is a global dict and it can be modified at times that are unintuitive to users of all experience levels. A note in the documentation makes sense

[issue45494] [fuzzer] Parser null deref with continuation characters and generator parenthesis error

2021-10-16 Thread Gregory P. Smith
Gregory P. Smith added the comment: I confirmed that 3.9 does NOT seem to have the problem: Python 3.9.5 (default, May 19 2021, 11:32:47) [GCC 9.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> x = r&#

[issue45494] [fuzzer] Parser null deref with continuation characters and generator parenthesis error

2021-10-16 Thread Gregory P. Smith
Change by Gregory P. Smith : -- priority: normal -> high versions: +Python 3.9 ___ Python tracker <https://bugs.python.org/issue45494> ___ ___ Python-bugs-lis

[issue39423] Process finished with exit code -1073741819 (0xC0000005) when trying to access data from a pickled file

2021-10-17 Thread Gregory P. Smith
Gregory P. Smith added the comment: As your problem involves numpy and PyQt, both of which are very complicated third party extension module code, chances are there is a bug within those that is leading to memory corruption. -- nosy: +gregory.p.smith resolution: -> third pa

[issue30570] issubclass segfaults on objects with weird __getattr__

2021-10-17 Thread Gregory P. Smith
Gregory P. Smith added the comment: This is a stack overflow in Objects/abstract.c because we infinitely recurse within abstract_issubclass(). We should probably do some validity checking on the bases tuple that abstract_get_bases returns (ideally within abstract_get_bases?). The tuple

[issue30570] issubclass segfaults on objects with weird __getattr__

2021-10-17 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker <https://bugs.python.org/issue30570> ___ ___ Python-bugs-list mailing list Un

[issue30570] issubclass segfaults on objects with weird __getattr__

2021-10-17 Thread Gregory P. Smith
Gregory P. Smith added the comment: Python metaprogramming allows type-like things to be bases, not just things that pass PyType_Check(). so being that strict isn't going to work. The other classic way to prevent this is to track what you're recursing on to avoid a loop. i.e.

[issue30570] issubclass segfaults on objects with weird __getattr__

2021-10-17 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +27291 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29017 ___ Python tracker <https://bugs.python.org/issu

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

2021-10-18 Thread Gregory P. Smith
New submission from Gregory P. Smith : The behavior is odd, I don't really know how to characterize it other than something serious has gone wrong. Memory corruption thus differing failures perhaps? it seems like maybe a race condition? on the main branch (i cannot reproduce this on

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

2021-10-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: for easy pasting: git clone https://github.com/python/cpython.git upstream && \ mkdir b-u && cd b-u && \ ../upstream/configure --with-pydebug && make -j3 && \ ./python -m test.regrtest test_importlib [change pyth

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

2021-10-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: further down in the tracebacks in that situation: ``` File "/Users/greg/oss/python/upstream/Lib/importlib/_bootstrap.py", line 887, in _fix_up_module assert module.__file__ == __file__, (module.__file__

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

2021-10-18 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +eric.snow ___ Python tracker <https://bugs.python.org/issue45506> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue45020] Freeze all modules imported during startup.

2021-10-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: could changes related to this be the cause of https://bugs.python.org/issue45506 ? out of tree builds in main usually cannot pass key tests today. they often hang or blow up with strange exceptions. -- nosy: +gregory.p.smith

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

2021-10-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: git bisect on Linux yielded this culprit change: ``` 79cf20e48d0b5d69d9fac2a0204b5ac2c366066a is the first bad commit commit 79cf20e48d0b5d69d9fac2a0204b5ac2c366066a Author: Eric Snow Date: Thu Oct 14 15:32:18 2021 -0600 bpo-21736: Set __file__ on

[issue21736] Add __file__ attribute to frozen modules

2021-10-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: That appears to have caused https://bugs.python.org/issue45506 -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue21

[issue45493] str() and repr() of enum different in Python 3.11 from Python <= 3.10

2021-10-19 Thread Gregory P. Smith
Gregory P. Smith added the comment: We just need https://github.com/python/cpython/pull/27010 to be done on main to roll it back. str and repr changes are quite painful to foist upon users existing code and tests. -- nosy: +gregory.p.smith

[issue40360] Deprecate lib2to3 (and 2to3) for future removal

2021-10-19 Thread Gregory P. Smith
Change by Gregory P. Smith : -- pull_requests: +27331 pull_request: https://github.com/python/cpython/pull/29064 ___ Python tracker <https://bugs.python.org/issue40

[issue42092] test_host_resolution_bad_address does not always fail as expected

2021-10-20 Thread Gregory P. Smith
Gregory P. Smith added the comment: Rule #1 for home users: Never use your ISPs DNS. Always configure a reputable one in your router. If you can't control your router, configure your computer to ignore the router's DNS. Classic best in breed non-ISP servers exist: 8.8.8

[issue36313] error: [Errno 13] Permission denied: '/usr/local/lib/python3.7/lib2to3/Grammar3.7.2.final.0.pickle'

2021-10-20 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> duplicate stage: -> resolved status: open -> closed superseder: -> Source installation sets incorrect permissions for Grammar3.2.3.final.0.pickle ___ Python tracker <https://

[issue15317] Source installation sets incorrect permissions for Grammar3.2.3.final.0.pickle

2021-10-20 Thread Gregory P. Smith
Gregory P. Smith added the comment: workaround: don't run make as root. run configure & make in a user account and only run your final make install as root after that. (sudo make install or whatnot) 2to3 and lib2to3 are deprecated so this won't be getting fixed (though i

[issue31000] Test failure in resource module on ZFS

2021-10-21 Thread Gregory P. Smith
Gregory P. Smith added the comment: this is probably somewhat of an edge case. filesystems are presumably free to have their own concepts of granularity on size limit enforcement. zfs may become more popular in future ubuntu versions as they're offering it as a supported primary

[issue43592] test_importlib: test_multiprocessing_pool_circular_import() fails with "Too many open files" error on os.pipe()

2021-10-21 Thread Gregory P. Smith
Gregory P. Smith added the comment: macOS often has an unreasonably low default max number of file descriptors. This is easy to raise from user code, it's a soft limit. https://github.com/python/cpython/pull/29127 is out to try that from regrtest itself. -- ass

[issue43592] test_importlib: test_multiprocessing_pool_circular_import() fails with "Too many open files" error on os.pipe()

2021-10-21 Thread Gregory P. Smith
Change by Gregory P. Smith : -- keywords: +patch pull_requests: +27414 pull_request: https://github.com/python/cpython/pull/29127 ___ Python tracker <https://bugs.python.org/issue43

[issue31000] Test failure in resource module on some ZFS systems

2021-10-21 Thread Gregory P. Smith
Gregory P. Smith added the comment: It doesn't happen on the zfs ubuntu 20.04 machine i've got. Figuring out an appropriate workaround when refactoring the test for this is best done by someone with a system it fails on. It'd be guesswork otherwise. -- title:

[issue43592] test_importlib: test_multiprocessing_pool_circular_import() fails with "Too many open files" error on os.pipe()

2021-10-21 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 843b890334ca30cf6af27dffe29cecd06b49f7d9 by Gregory P. Smith in branch 'main': bpo-43592: Raise RLIMIT_NOFILE in test.libregrtest (GH-29127) https://github.com/python/cpython/commit/843b890334ca30cf6af27dffe29cec

[issue43592] test_importlib: test_multiprocessing_pool_circular_import() fails with "Too many open files" error on os.pipe()

2021-10-21 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue30570] issubclass segfaults on objects with weird __getattr__

2021-10-22 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 423fa1c1817abfa8c3d1bc308ddbbd8f28b69d68 by Dennis Sweeney in branch 'main': bpo-30570: Use Py_EnterRecursiveCall() in issubclass() (GH-29048) https://github.com/python/cpython/commit/423fa1c1817abfa8c3d1bc308ddbbd

[issue45506] Out of source tree builds failing on main - test_importlib others unreliable

2021-10-22 Thread Gregory P. Smith
Gregory P. Smith added the comment: i'm considering this fixed based on my testing. we still lack buildbots using out of tree setup. i'll ponder that. But this issue need not track that infrastructure. -- assignee: -> eric.snow resolution: -> fixed sta

[issue33439] python-config.py should be part of the stdlib

2021-10-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: `Misc/python-config.in` ultimately becomes a Python script that prints things to stdout. It isn't written to be a module as is. Any work to make it one is effectively writing entirely new code to do what it does. To keep a single source of trut

[issue11477] Incorrect operand precedence when implementing sequences in C

2021-10-25 Thread Gregory P. Smith
Gregory P. Smith added the comment: Given that a lot of code is presumably relying on this (see the notes from 2015)... I wouldn't be surprised if this turns into a wart we document but not actually fix. :/ Or a conditional behavior we control via a `from __future__ i

[issue42367] Restore os.makedirs ability to apply mode to all directories created

2021-10-26 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.11 -Python 3.10 ___ Python tracker <https://bugs.python.org/issue42367> ___ ___ Python-bugs-list mailin

[issue45695] Out-of-tree builds are not tested.

2021-11-02 Thread Gregory P. Smith
Gregory P. Smith added the comment: I always do out of tree builds _(I find people who build anything in tree to be very weird - it makes a mess)_. I intend to look into making sure a Linux buildbot runs this way but don't let that stop anyone else from doi

[issue45695] Out-of-tree builds are not tested.

2021-11-02 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith ___ Python tracker <https://bugs.python.org/issue45695> ___ ___ Python-bugs-list mailing list Un

[issue45780] dict. keys view behavious diverges from set()

2021-11-10 Thread Gregory P. Smith
Change by Gregory P. Smith : -- components: Interpreter Core nosy: gregory.p.smith priority: normal severity: normal stage: needs patch status: open title: dict. keys view behavious diverges from set() type: behavior versions: Python 3.11 ___ Python

[issue45780] dict. keys view behavious diverges from set()

2021-11-10 Thread Gregory P. Smith
New submission from Gregory P. Smith : Python 3.9.7 (default, Sep 24 2021, 09:43:00) [GCC 10.3.0] on linux Type "help", "copyright", "credits" or "license" for more information. >>> dict(a=3,b=5).keys() dict_keys(['a', 'b']

[issue45780] dict. keys view behaviour diverges from set()

2021-11-10 Thread Gregory P. Smith
Change by Gregory P. Smith : -- title: dict. keys view behavious diverges from set() -> dict. keys view behaviour diverges from set() ___ Python tracker <https://bugs.python.org/issu

[issue45780] dict. keys view behaviour diverges from set()

2021-11-10 Thread Gregory P. Smith
Gregory P. Smith added the comment: Joshua pointed out that https://bugs.python.org/issue26973 appears to cover this. we rejected the idea of changing it at the time. it'd still be nice. -- ___ Python tracker <https://bugs.python.org/is

[issue43526] Programmatic management of BytesWarning doesn't work for native triggers.

2021-11-15 Thread Gregory P. Smith
Gregory P. Smith added the comment: fwiw, at work we modified our interpreter to treat PYTHONBYTESWARNING=1 or 2 as if -b or -bb were passed. All of our tests run by default with a PYTHONBYTESWARNING=2 in their environment. -- nosy: +gregory.p.smith

[issue43526] Programmatic management of BytesWarning doesn't work for native triggers.

2021-11-15 Thread Gregory P. Smith
Gregory P. Smith added the comment: clarification after poking around: s/all/a lot/ - YouTube used it to help their Python 3 migration. Regardless, the env. var has been useful. -- ___ Python tracker <https://bugs.python.org/issue43

[issue41735] Thread locks in zlib module may go wrong in rare case

2021-11-17 Thread Gregory P. Smith
Change by Gregory P. Smith : -- assignee: -> gregory.p.smith resolution: later -> stage: resolved -> patch review ___ Python tracker <https://bugs.python.or

[issue34592] cdll.LoadLibrary allows None as an argument

2021-11-18 Thread Gregory P. Smith
Gregory P. Smith added the comment: We do need to document this in ctypes.rst. Quite a bit of code depends on ctypes.CDLL(None) and similar to get at symbols linked into the interpreter or already dlopened into the process these days. It works on Linux; I'm assuming it likely do

[issue42367] Restore os.makedirs ability to apply mode to all directories created

2021-11-22 Thread Gregory P. Smith
Gregory P. Smith added the comment: A new `intermediate_mode=` kwarg can't _default_ to `mode=` as that would flip flop the API's default behavior again and no doubt disrupt someone elses 3.7-3.10 authored code depending on it. :( Regardless I do somewhat like `intermediate_mode=`

[issue41735] Thread locks in zlib module may go wrong in rare case

2021-11-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 7edb6270a78c695e4c2ae2432797dc18105374fc by Ma Lin in branch 'main': bpo-41735: Fix thread lock in zlib.Decompress.flush() may go wrong (GH-29587) https://github.com/python/cpython/commit/7edb6270a78c695e4c2ae2432797dc

[issue41735] Thread locks in zlib module may go wrong in rare case

2021-11-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset 86c1265cdc64030c8921e0da5fcae2ac64299c26 by Ma Lin in branch '3.9': [3.9] bpo-41735: Fix thread lock in zlib.Decompress.flush() may go wrong (GH-29588) https://github.com/python/cpython/commit/86c1265cdc64030c8921e0da5fcae2

[issue41735] Thread locks in zlib module may go wrong in rare case

2021-11-26 Thread Gregory P. Smith
Gregory P. Smith added the comment: Thanks malin! -- resolution: -> fixed stage: patch review -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue45902] Bytes and bytesarrays can be sorted with a much faster count sort.

2021-11-27 Thread Gregory P. Smith
Gregory P. Smith added the comment: General consensus: There isn't a common need for this. -- nosy: +gregory.p.smith resolution: -> rejected stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.pyth

[issue45695] Out-of-tree builds are not tested.

2021-12-03 Thread Gregory P. Smith
Gregory P. Smith added the comment: Nice trick with that RO bind mount. tests... yes we do have some writable source tree messes in there to be dealt with. -- ___ Python tracker <https://bugs.python.org/issue45

[issue22910] test_pydoc test_synopsis_sourceless is a flaky test

2021-12-07 Thread Gregory P. Smith
Change by Gregory P. Smith : -- resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue38884] __import__ is not thread-safe on Python 3

2021-12-08 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue38884> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue33695] Have shutil.copytree(), copy() and copystat() use cached scandir() stat()s

2019-11-09 Thread Bruno P. Kinoshita
Change by Bruno P. Kinoshita : -- pull_requests: +16605 pull_request: https://github.com/python/cpython/pull/17098 ___ Python tracker <https://bugs.python.org/issue33

[issue38688] Python 3.8 regression: endless loop in shutil.copytree

2019-11-09 Thread Bruno P. Kinoshita
Change by Bruno P. Kinoshita : -- keywords: +patch pull_requests: +16604 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/17098 ___ Python tracker <https://bugs.python.org/issu

[issue38688] Python 3.8 regression: endless loop in shutil.copytree

2019-11-09 Thread Bruno P. Kinoshita
Bruno P. Kinoshita added the comment: Hi, I did a quick `git bisect` using the example provided, and looks like this regression was added in the fix for bpo-33695, commit 19c46a4c96553b2a8390bf8a0e138f2b23e28ed6. It looks to me that the iterator returned by with os.scandir(...) is

[issue38688] Python 3.8 regression: endless loop in shutil.copytree

2019-11-21 Thread Bruno P. Kinoshita
Bruno P. Kinoshita added the comment: Hi Giampaolo, I think it is more or less the same as the previous code, which was using os.list to return a list in memory. My first tentative fix was: def copytree(src, ...): entries = os.list(src) return _copytree(entries=entries

[issue38688] Python 3.8 regression: endless loop in shutil.copytree

2019-11-21 Thread Bruno P. Kinoshita
Bruno P. Kinoshita added the comment: I really liked that improvement, and didn't think it needed to be removed. That's why the PR reverts it partially. I think the os.stat improvements were in the other methods changed, and should not be changed in my PR - unless I changed it b

[issue38688] Python 3.8 regression: endless loop in shutil.copytree

2019-11-21 Thread Bruno P. Kinoshita
Bruno P. Kinoshita added the comment: Done. Rebased on master too, and edited commit message & GH PR title. Thanks Giampaolo! -- ___ Python tracker <https://bugs.python.org/iss

[issue38500] Provide a way to get/set PyInterpreterState.frame_eval without needing to access interpreter internals

2019-11-21 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue38500> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue38500] Provide a way to get/set PyInterpreterState.frame_eval without needing to access interpreter internals

2019-11-21 Thread Gregory P. Smith
Gregory P. Smith added the comment: +1 to re-exposing a way to do PEP-523. PEP-523 added a public API, we unintentionally hid it behind the mask of Py_BUILD_CORE_MODULE in 3.8. We shouldn't remove PEP-523's abilities without a deprecation cycle. But given the use cases tend t

[issue33387] Simplify bytecodes for try-finally, try-except and with blocks.

2019-11-21 Thread Gregory P. Smith
Gregory P. Smith added the comment: sweet! =) -- versions: +Python 3.9 -Python 3.8 ___ Python tracker <https://bugs.python.org/issue33387> ___ ___ Python-bug

[issue38688] Python 3.8 regression: endless loop in shutil.copytree

2019-11-26 Thread Bruno P. Kinoshita
Change by Bruno P. Kinoshita : -- pull_requests: +16878 stage: commit review -> patch review pull_request: https://github.com/python/cpython/pull/17397 ___ Python tracker <https://bugs.python.org/issu

[issue38720] Logging failure with timestamp messages

2019-12-01 Thread Bruno P. Kinoshita
Bruno P. Kinoshita added the comment: I think this needs a script to reproduce the problem. Tested first with Anaconda Python 3.7.1 on Win10 Pro. Not able to reproduce the issue. Smae with the latest version. Using Python master and Win10Pro and timezone set to NZ (not that really matter

[issue38868] Shutil cannot delete a folder that contains an .ini file

2019-12-01 Thread Bruno P. Kinoshita
Bruno P. Kinoshita added the comment: I think eryksun is correct. Reproduced it locally. Setting to read-only initially did not raise the issue, but then as administrator I removed the inherited permissions and set it to read-only for my user, then it raised the exact same WinError 5

[issue35981] shutil make_archive create wrong file when base name contains dots at end

2019-12-01 Thread Bruno P. Kinoshita
Change by Bruno P. Kinoshita : -- keywords: +patch pull_requests: +16914 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17435 ___ Python tracker <https://bugs.python.org/issu

[issue35981] shutil make_archive create wrong file when base name contains dots at end

2019-12-01 Thread Bruno P. Kinoshita
Change by Bruno P. Kinoshita : -- keywords: +patch, patch pull_requests: +16914, 16915 stage: -> patch review pull_request: https://github.com/python/cpython/pull/17435 ___ Python tracker <https://bugs.python.org/issu

[issue35981] shutil make_archive create wrong file when base name contains dots at end

2019-12-01 Thread Bruno P. Kinoshita
Bruno P. Kinoshita added the comment: Tested locally on Win10 pro, and both suggestions of steve.dower worked. I've put a PR (https://github.com/python/cpython/pull/17435) based on his second suggestion. The rationale being that that way, the format function (zip/bztar/etc) will get

[issue38991] Remove test.support.strip_python_stderr()

2019-12-06 Thread Gregory P. Smith
Gregory P. Smith added the comment: do we have any buildbots using -X showrefcount? -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue38

[issue38981] better name for re.error Exception class.

2019-12-07 Thread Gregory P. Smith
Gregory P. Smith added the comment: Strictly speaking not all of those _need_ to be touched given the old name is always going to exist for backwards compatibility. But I agree that we should update them as part of this regardless. I'd go forward with a PR. The only fallout I exp

[issue38576] CVE-2019-18348: CRLF injection via the host part of the url passed to urlopen()

2019-12-08 Thread Gregory P. Smith
Change by Gregory P. Smith : -- priority: normal -> high ___ Python tracker <https://bugs.python.org/issue38576> ___ ___ Python-bugs-list mailing list Un

[issue30458] [security][CVE-2019-9740][CVE-2019-9947] HTTP Header Injection (follow-up of CVE-2016-5699)

2019-12-08 Thread Gregory P. Smith
Gregory P. Smith added the comment: i believe new work will be done via the new issue. marking this closed. if there is something not covered by issue38576 that remains, please open a new issue for it. new discussion on this long issue is easy to get lost in. -- resolution

[issue13501] Make libedit support more generic; port readline / libedit to FreeBSD

2019-12-08 Thread Gregory P. Smith
Change by Gregory P. Smith : -- versions: +Python 3.9 -Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7 ___ Python tracker <https://bugs.python.org/issue13

[issue28254] Add C API for gc.enable, gc.disable, and gc.isenabled

2019-12-11 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +gregory.p.smith ___ Python tracker <https://bugs.python.org/issue28254> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37218] Default hmac.new() digestmod has not been removed from documentation

2019-12-18 Thread Gregory P. Smith
Change by Gregory P. Smith : -- nosy: +christian.heimes ___ Python tracker <https://bugs.python.org/issue37218> ___ ___ Python-bugs-list mailing list Unsub

[issue37958] Adding get_profile_dict to pstats

2020-01-15 Thread Gregory P. Smith
Gregory P. Smith added the comment: Thanks Daniel! -- nosy: +gregory.p.smith resolution: -> fixed stage: -> commit review status: open -> closed ___ Python tracker <https://bugs.python.or

[issue39375] Document os.environ[x] = y and os.putenv() as thread unsafe

2020-01-17 Thread Gregory P. Smith
New submission from Gregory P. Smith : The underlying API calls made by os.putenv() and os.environ[name] = value syntax are not thread safe on POSIX systems. POSIX _does not have_ any thread safe way to access the process global environment. In a pure Python program, the GIL prevents this

[issue39375] Document os.environ[x] = y and os.putenv() as thread unsafe

2020-01-17 Thread Gregory P. Smith
Gregory P. Smith added the comment: https://bugs.python.org/issue39376 tracks possible interpreter behavior changes. -- ___ Python tracker <https://bugs.python.org/issue39

[issue39376] Avoid modifying the process global environment (not thread safe)

2020-01-17 Thread Gregory P. Smith
New submission from Gregory P. Smith : For more context, see https://bugs.python.org/issue39375 which seeks to document the existing caveats. POSIX lacks any APIs to access the process global environment in a thread safe manner. Given this, we could _consider_ preventing os.putenv() and

[issue39375] Document os.environ[x] = y and os.putenv() as thread unsafe

2020-01-21 Thread Gregory P. Smith
Gregory P. Smith added the comment: fwiw, no need to remove that message. We'll want to make the docs clear that this does not apply to Windows. :) -- ___ Python tracker <https://bugs.python.org/is

[issue35182] Popen.communicate() breaks when child closes its side of pipe but not exits

2020-01-22 Thread Gregory P. Smith
Gregory P. Smith added the comment: New changeset d3ae95e1e945ed20297e1c38ba43a18b7a868ab6 by Gregory P. Smith (Alex Rebert) in branch 'master': bpo-35182: fix communicate() crash after child closes its pipes (GH-17020) (GH-18117) https://github.com/python/cpyt

[issue35182] Popen.communicate() breaks when child closes its side of pipe but not exits

2020-01-22 Thread Gregory P. Smith
Gregory P. Smith added the comment: backport automation appears unhappy at the moment. I'm keeping this open and assigned to me to manually run cherry_picker on this for 3.8 and 3.7 (if still open for non-security fixes). -- assignee: -> gregory.p.smith stage: patc

[issue35182] Popen.communicate() breaks when child closes its side of pipe but not exits

2020-01-23 Thread Gregory P. Smith
Gregory P. Smith added the comment: thanks everyone! -- resolution: -> fixed stage: patch review -> commit review status: open -> closed versions: +Python 3.9 ___ Python tracker <https://bugs.python.or

<    9   10   11   12   13   14   15   16   17   18   >