[issue7543] RFE: introduce "enum Py_Opcode"

2009-12-19 Thread Dave Malcolm
Dave Malcolm added the comment: > Are you doing anything specific which requires this change? No. I was looking for ways of making CPython easier to debug, and I experimented with this. It didn't help with debuggability as much as I hoped. Given that CPython's performance i

[issue7647] Add statvfs flags to the posix module

2010-01-06 Thread Dave Malcolm
Changes by Dave Malcolm : -- nosy: +dmalcolm ___ Python tracker <http://bugs.python.org/issue7647> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

2010-01-12 Thread Dave Malcolm
Dave Malcolm added the comment: Attaching a probably over-simplistic attempt at this patch, against the py3k branch. This patch attempts to extend the replacement of LOAD_CONST, , LOAD_CONST, BUILD_LIST, COMPARE_OP(in) with LOAD_CONST(tuple), COMPAREOP(in) so that it also replaces

[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

2010-01-12 Thread Dave Malcolm
Dave Malcolm added the comment: Alex: good point - thanks! Attaching updated version of the patch (again, against py3k, likewise, I'm somewhat new to this code, so I may have missed things) With this: >>> dis.dis(lambda o: o in {1,2,3}) 1 0 LOAD_FAST

[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

2010-01-12 Thread Dave Malcolm
Dave Malcolm added the comment: Thanks for looking at the patch. Attached is an updated version (again against py3k) which adds tests to Lib/test/test_peepholer.py, for both the new folding away of BUILD_SET, and for the pre-existing folding of BUILD_LIST (which didn't seem to have

[issue1634034] Show "expected" token on syntax error

2010-01-13 Thread Dave Malcolm
Dave Malcolm added the comment: I'm attaching a new version of the patch, based on Oliver's (from 3 years ago). This patch is against the py3k branch. I've introduced a new table of (const) strings: _PyParser_TokenDescs, giving descriptions of each token type, so t

[issue4555] Smelly exports

2010-01-13 Thread Dave Malcolm
Dave Malcolm added the comment: Re: msg #77350: > I propose to simply filter out init[_a-z]+ from the set of "bad" > symbols. I'm attaching a patch (to trunk) to Makefile.pre.in which filters out such symbols. Relevant part of output of "make smelly" on my s

[issue6690] BUILD_SET followed by COMPARE_OP (in) can be optimized if all items are consts

2010-01-15 Thread Dave Malcolm
Dave Malcolm added the comment: Thanks for the suggestions. Attached is a revised version of the patch. - I believe I've fixed all tab/space issues in this version of the patch, though I may have missed some (http://www.python.org/dev/tools/ doesn't recommend an automated way o

[issue5803] email/quoprimime: encode and decode are very slow on large messages

2009-04-20 Thread Dave Baggett
New submission from Dave Baggett : The implementation of encode and decode are slow, and scale nonlinearly in the size of the message to be encoded/decoded. A simple fix is to use an array.array('c') and append to it, rather than using string concatenation. This change makes the code

[issue5803] email/quoprimime: encode and decode are very slow on large messages

2009-04-20 Thread Dave Baggett
Changes by Dave Baggett : -- type: -> performance ___ Python tracker <http://bugs.python.org/issue5803> ___ ___ Python-bugs-list mailing list Unsubscri

[issue5806] MySQL crash on machine startup....

2009-04-21 Thread Dave Fliger
New submission from Dave Fliger : I recently (in the last 5 days) downloaded and installed Python 2.6.x. Upon startup of this machine I noticed a Windows warning that "mysqld.exe could not start...". I really didn't pay attention to it until today since I had no plans to u

[issue5803] email/quoprimime: encode and decode are very slow on large messages

2009-04-21 Thread Dave Baggett
Dave Baggett added the comment: I can certainly generate a patch for you. What form would you like it in, and against what source tree? Also, do you have a preference between the use of array.array vs. standard arrays? (I don't know whether it's good or bad to depend on "i

[issue5803] email/quoprimime: encode and decode are very slow on large messages

2009-04-21 Thread Dave Baggett
Dave Baggett added the comment: Yes, sorry, I meant "built-in list type" not "array". Your point about using lists this way is valid, and is why I used array.array('c'). I will do as you suggest and try all three methods. I did time the array.array approach vs. the

[issue5806] MySQL crash on machine startup....

2009-04-21 Thread Dave Fliger
Dave Fliger added the comment: Thanks for the response. I wasn't sure what the deal was, and sort of intuitively knew it wasn't the problem. I wouldn't have mentioned it with the exception that uninstalling solved the problem. That's a bit odd, don't you think?

[issue5806] MySQL crash on machine startup....

2009-04-21 Thread Dave Fliger
Dave Fliger added the comment: Thank you, sir. I'll try that later in the day. I just don't want to "break" what I have. I'm eager to look under the hood of Python.   Dave Fliger Webmaster Rogers Sporting Goods 1760 N. Church Road Liberty, M

[issue5806] MySQL crash on machine startup....

2009-04-21 Thread Dave Fliger
Dave Fliger added the comment: True enough, my friend. I really didn't know if it had been reported before. If I go over the sequence of events tat I performed here on this machine, then my only conclusion was the installation of Python because everything worked prior to that. I know th

[issue917120] imaplib: incorrect quoting in commands

2009-05-12 Thread Dave Baggett
Dave Baggett added the comment: I'm not sure this causes the behavior reported here, but I believe there really is a bug in imaplib. In particular, it seems wrong to me that this line: mustquote = re.compile(r"[^\w!#$%&'*+,.:;<=>?^`|~-]") has \w in it. Should th

[issue917120] imaplib: incorrect quoting in commands

2009-05-12 Thread Dave Baggett
Dave Baggett added the comment: OK, I missed the initial caret in the regex. The mustquote regex is listing everything that needn't be quoted, and then negating. I still think it's wrong, though. According to BNF given in the Formal Syntax section of RFC 3501, you must must quote ato

[issue8557] subprocess PATH semantics and portability

2010-05-16 Thread Dave Abrahams
Dave Abrahams added the comment: New data point: in some contexts on Windows (not sure of the exact cause but I was dealing with multiple drives), even this workaround isn't enough. I ended up having to do something like this (i.e. manually search the path) on win32:

[issue8732] Should urrllib2.urlopen send an Accept-Encoding header?

2010-05-16 Thread Dave Abrahams
New submission from Dave Abrahams : According to the RFC, the server is allowed to send back any encoding it likes when no Accept-Encoding header is supplied, but all the examples I can find of urllib2.urlopen usage assume they're getting plain text back. I think it would be better to i

[issue5753] CVE-2008-5983 python: untrusted python modules search path

2010-05-17 Thread Dave Malcolm
Dave Malcolm added the comment: Attempting to summarize IRC discussion about this. PySys_SetArgv is used to set up sys.argv There is plenty of code which assumes that this is a list containing at least a zeroth string element; for example warnings.warn (see msg89688). It seems reasonable

[issue8732] Should urrllib2.urlopen send an Accept-Encoding header?

2010-05-18 Thread Dave Abrahams
Dave Abrahams added the comment: How many tests did you run? My two tests were minutes apart. I have the feeling that this has something to do with cacheing behavior on the server. -- ___ Python tracker <http://bugs.python.org/issue8

[issue1621] Do not assume signed integer overflow behavior

2010-05-21 Thread Dave Malcolm
Changes by Dave Malcolm : -- nosy: +dmalcolm ___ Python tracker <http://bugs.python.org/issue1621> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8892] 2to3 fails with assertion failure on "from itertools import *"

2010-06-03 Thread Dave Malcolm
New submission from Dave Malcolm : fix_itertools_imports.py fails on a "*" import 2to3 fails on this code: from itertools import * with a traceback: File "/home/david/coding/python-svn/trunk-2to3-issues/Lib/lib2to3/tests/test_fixers.py", line 3680, in test_star

[issue8892] 2to3 fails with assertion failure on "from itertools import *"

2010-06-03 Thread Dave Malcolm
Dave Malcolm added the comment: I'm attaching a reproducer for the test suite (though not a fix) -- keywords: +patch Added file: http://bugs.python.org/file17540/itertools_import_star_reproducer.patch ___ Python tracker <http://bugs.py

[issue8927] Cannot handle complex requirement resolution

2010-06-06 Thread Dave Abrahams
New submission from Dave Abrahams : [This looks like a bug report against PIP because Tarek told me distutils2 would be responsible for this kind of thing and that there was an open ticket for it. However, I can't find any such ticket so I'm posting it here] Not only does pip not

[issue8941] utf-32be codec failing on 16-bit python build for 32-bit value

2010-06-08 Thread Dave Opstad
New submission from Dave Opstad : The utf-32 little-endian codec works fine, but the big-endian codec is producing incorrect results: Python 3.1.2 (r312:79360M, Mar 24 2010, 01:33:18) [GCC 4.0.1 (Apple Inc. build 5493)] on darwin Type "help", "copyright", "credi

[issue8946] PyBuffer_Release signature in 3.1 documentation is incorrect

2010-06-08 Thread Dave Opstad
New submission from Dave Opstad : According to the 3.1 documentation, the prototype for PyBuffer_Release is: void PyBuffer_Release(PyObject *obj, Py_buffer *view); However, abstract.h has this prototype: PyAPI_FUNC(void) PyBuffer_Release(Py_buffer *view); The documentation's referen

[issue9054] pyexpat configured with "--with-system-expat" is incompatible with expat 2.0.1

2010-06-21 Thread Dave Malcolm
New submission from Dave Malcolm : pyexpat configured with "--with-system-expat" segfaults in one selftest when built against expat 2.0.1 SVN trunk: $ ./configure --with-system-expat (with expat-2.0.1) $ make $ ./python Lib/test/test_pyexpat.py [snip] test_parse_only_xml_data

[issue9054] pyexpat configured with "--with-system-expat" is incompatible with expat 2.0.1

2010-06-21 Thread Dave Malcolm
Dave Malcolm added the comment: With the attached patch all of Lib/test/test_pyexpat.py passes. -- keywords: +patch Added file: http://bugs.python.org/file17734/fix-issue-9054.patch ___ Python tracker <http://bugs.python.org/issue9

[issue9054] pyexpat configured with "--with-system-expat" is incompatible with expat 2.0.1

2010-06-21 Thread Dave Malcolm
Changes by Dave Malcolm : -- stage: -> patch review type: -> crash versions: +Python 2.7 ___ Python tracker <http://bugs.python.org/issue9054> ___ ___ Pyth

[issue9054] pyexpat configured with "--with-system-expat" is incompatible with expat 2.0.1

2010-06-21 Thread Dave Malcolm
Dave Malcolm added the comment: For reference, I'm tracking this downstream here: https://bugzilla.redhat.com/show_bug.cgi?id=583931 -- ___ Python tracker <http://bugs.python.org/i

[issue9057] Needs a home page

2010-06-22 Thread Dave Abrahams
New submission from Dave Abrahams : This project needs a home page. I want to link to it from Ryppl docs, but anyone following a link to, e.g. the bitbucket wiki would think this project was weak at best. -- assignee: tarek components: Distutils2 messages: 108390 nosy: dabrahams

[issue9057] Needs a home page

2010-06-22 Thread Dave Abrahams
Dave Abrahams added the comment: Distutils2, sorry. -- ___ Python tracker <http://bugs.python.org/issue9057> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9057] Distutils2 needs a home page

2010-06-22 Thread Dave Abrahams
Dave Abrahams added the comment: Yes, I understand it's not ready for users. However, even a project in process can benefit from having a home page, to boost awareness and link connectivity. ATM there's no reasonably stable URL I can link to from http://ryppl.org/technology.htm

[issue9058] PyUnicodeDecodeError_Create asserts that various arguments are less than INT_MAX

2010-06-22 Thread Dave Malcolm
New submission from Dave Malcolm : Running this code (seen via http://bugs.python.org/file10013/python-2.5.2-unicode_resize-utf16.py for issue 2620): >>> msg = 'A'*2147483647 ; msg.decode('utf16') leads to the python process exiting with an assertion failure: pyth

[issue9058] PyUnicodeDecodeError_Create asserts that various arguments are less than INT_MAX

2010-06-22 Thread Dave Malcolm
Dave Malcolm added the comment: Patch to remove the restriction that the fields be < INT_MAX Tested on x86_64 on a machine with > 12GB of RAM, leads to this exception, rather than the python process bailing out: Traceback (most recent call last): File "", line 1, in Fil

[issue9058] PyUnicodeDecodeError_Create asserts that various arguments are less than INT_MAX

2010-06-22 Thread Dave Malcolm
Dave Malcolm added the comment: >>> Actually, you should be able to just remove the asserts. Aha, thanks! Yes: #define PY_SSIZE_T_CLEAN is defined at the top of Objects/exceptions.c, so yes, Py_VaBuildValue is redirected to _Py_VaBuildValue_SizeT, so that PyEval_CallFunct

[issue5673] Add timeout option to subprocess.Popen

2010-07-01 Thread Dave Malcolm
Dave Malcolm added the comment: The patch has bitrotted somewhat; I've had a go at reworking it so it applies against the latest version of trunk (r82429). All tests pass (or are skipped) on this x86_64 Linux box --with-pydebug (Fedora 13) There are still some TODOs in the code: Popen

[issue9146] Segfault in hashlib in OpenSSL FIPS mode using non-FIPS-compliant hashes, if "ssl" imported before "hashlib"

2010-07-02 Thread Dave Malcolm
New submission from Dave Malcolm : Having run: prelink --undo --all the following works OK: OPENSSL_FORCE_FIPS_MODE=1 python -c "import hashlib; m = m = hashlib.md5(); m.update('abc')" but the following segfaults: OPENSSL_FORCE_FIPS_MODE=1 python -c "import s

[issue9146] Segfault in hashlib in OpenSSL FIPS mode using non-FIPS-compliant hashes, if "ssl" imported before "hashlib"

2010-07-02 Thread Dave Malcolm
Dave Malcolm added the comment: Thanks > First, is it only with 2.7 or 2.6? I've seen this with both 2.6 tarball builds and SVN trunk; in both cases against openssl-1.0.0-1.[ > Second, I don't really get the point of the FIPS mode. The PDF you linked to > seems full of

[issue9146] Segfault in hashlib in OpenSSL FIPS mode using non-FIPS-compliant hashes, if "ssl" imported before "hashlib"

2010-07-02 Thread Dave Malcolm
Dave Malcolm added the comment: Attached patch checks for errors in the initialization of _hashlib, and only registers the names that are actually available. It also contains the ssl init from the first patch. I added a _hashlib._errors dict, containing errors, so that you can examine them

[issue9146] Segfault in hashlib in OpenSSL FIPS mode using non-FIPS-compliant hashes, if "ssl" imported before "hashlib"

2010-07-02 Thread Dave Malcolm
Dave Malcolm added the comment: Not quite ready yet: Named methods work: $ OPENSSL_FORCE_FIPS_MODE=1 ./python -c "import hashlib; m = hashlib.md5(); m.update('abc\n'); print m.hexdigest()"0bee89b07a248e27c83fc3d5951213c1 [15741 refs] but lookup by name still fails: OPENS

[issue9146] Segfault in hashlib in OpenSSL FIPS mode using non-FIPS-compliant hashes, if "ssl" imported before "hashlib"

2010-07-06 Thread Dave Malcolm
Dave Malcolm added the comment: I'm attaching an updated patch which: - adds error checking to the various places where EVP_DigestInit is called - adds a test to test_hashlib to ensure that hashlib still works gracefully when OPENSSL_FORCE_FIPS_MODE=1 is set in the environment Note

[issue9163] test_gdb fails

2010-07-06 Thread Dave Malcolm
Dave Malcolm added the comment: Deciphering the output from the assertion, the stdout from gdb when running the test was: --- BEGIN --- Breakpoint 1, PyObject_Print (op=42, fp=0x401cf4e0, flags=1) at Objects/object.c:329 329 { #3 Frame 0x81e322c, for file /home/mike/workspace/Python-2.7

[issue8605] test_gdb can fail with compiler opts

2010-07-06 Thread Dave Malcolm
Dave Malcolm added the comment: Thanks. The patch looks good to me, and appears to also fix issue 8482 and issue 9163: compiler optimization across all different compilers and configurations can somewhat arbitrarily break the ability for the debugger to work, and skipping the test in the

[issue9163] test_gdb fails

2010-07-06 Thread Dave Malcolm
Dave Malcolm added the comment: Thanks. Just to clarify, what's the output of: ./python -c "import sysconfig; print sysconfig.get_config_vars()['PY_CFLAGS']" -- ___ Python tracker <http

[issue9163] test_gdb fails

2010-07-06 Thread Dave Malcolm
Dave Malcolm added the comment: Thanks for the info. The final optimization option passed to gcc is the "-O3", so the build was done with optimization. It's not going to be possible to determine if and when gdb will be able to work in an optimized build across all differen

[issue8605] test_gdb can fail with compiler opts

2010-07-07 Thread Dave Malcolm
Dave Malcolm added the comment: Oops, my bad. Patch looks good as is. -- ___ Python tracker <http://bugs.python.org/issue8605> ___ ___ Python-bugs-list mailin

[issue9146] Segfault in hashlib in OpenSSL FIPS mode using non-FIPS-compliant hashes, if "ssl" imported before "hashlib"

2010-07-07 Thread Dave Malcolm
Dave Malcolm added the comment: Thanks. The relevant code in setup.py is all wrapped with --pydebug: if COMPILED_WITH_PYDEBUG or not have_usable_openssl: All of my testing had been --with-pydebug. Rebuilding without --with-pydebug leads to some interesting failures; as you say, if

[issue9188] test_gdb fails for UCS2 builds with UCS2 gdb

2010-07-07 Thread Dave Malcolm
Dave Malcolm added the comment: The traceback is Traceback (most recent call last): File "/home/antoine/cpython/27/python-gdb.py", line 1084, in to_string return pyop.get_truncated_repr(MAX_OUTPUT_LEN) File "/home/antoine/cpython/27/python-gdb.py", line 183, i

[issue9193] Versioned .so files

2010-07-07 Thread Dave Malcolm
Changes by Dave Malcolm : -- nosy: +dmalcolm ___ Python tracker <http://bugs.python.org/issue9193> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue8482] test_gdb, gdb/libpython.py: Unable to read information on python frame

2010-07-08 Thread Dave Malcolm
Dave Malcolm added the comment: > test_gdb fails (Unable to read information on python frame) on my i386 > computer (32 bits) with -O1 (but it doesn't with -O0). I'm using Debian > Sid: gcc 4.4.3 and gdb 7.1. This should be fixed now that issue 8605 is resolved: we now sk

[issue9163] test_gdb fails

2010-07-08 Thread Dave Malcolm
Dave Malcolm added the comment: This should be fixed now that issue 8605 is resolved: we now skip test_gdb if the compiler optimization level is above -O0 -- resolution: -> fixed stage: -> committed/rejected ___ Python tracker

[issue9163] test_gdb fails

2010-07-08 Thread Dave Malcolm
Changes by Dave Malcolm : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue9163> ___ ___ Python-bugs-list mailing list Unsubscri

[issue8482] test_gdb, gdb/libpython.py: Unable to read information on python frame

2010-07-08 Thread Dave Malcolm
Changes by Dave Malcolm : -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue8482> ___ ___ Python-bugs-list mailing list Unsubscri

[issue9216] FIPS support for hashlib

2010-07-09 Thread Dave Malcolm
New submission from Dave Malcolm : (taking the liberty of adding gregory.p.smith to the "nosy" list; hope that's OK) This is a higher-level take on issue 9146. Some versions of OpenSSL have a FIPS mode that can refuse the use of non-certified hashes. The idea is that F

[issue9146] Segfault in hashlib in OpenSSL FIPS mode using non-FIPS-compliant hashes, if "ssl" imported before "hashlib"

2010-07-09 Thread Dave Malcolm
Dave Malcolm added the comment: I've filed issue 9216 to discuss this at a higher level, with an API proposal -- ___ Python tracker <http://bugs.python.org/i

[issue9216] FIPS support for hashlib

2010-07-12 Thread Dave Malcolm
Dave Malcolm added the comment: Attached is a patch against the py3k branch which implements this. I've checked that it builds against openssl-0.9.8o.tar.gz, openssl-1.0.0a.tar.gz, and against Fedora 12 and 13's heavily-patched openssl-1.0.0. The bulk of my testing has been agains

[issue9235] missing "import sys" in Tools/gdb/libpython.py

2010-07-12 Thread Dave Malcolm
Changes by Dave Malcolm : -- nosy: +dmalcolm ___ Python tracker <http://bugs.python.org/issue9235> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9263] Try to print repr() when an C-level assert fails (in the garbage collector, beyond?)

2010-07-14 Thread Dave Malcolm
New submission from Dave Malcolm : Modules/gcmodule.c contains various assertions which can fail due to reference counting errors elsewhere in either python, or an extension module. These can be difficult to track down. In the hope of maximizing the information from crash reports, the

[issue2454] sha and md5 fixer

2010-07-19 Thread Dave Malcolm
Dave Malcolm added the comment: The 'u' prefix went away in Python 3, use an unadorned '' or "" for a unicode value. $ python3 Python 3.1.2 (r312:79147, May 25 2010, 12:21:57) [GCC 4.4.3 20100422 (Red Hat 4.4.3-18)] on linux2 Type "help", &quo

[issue4555] Smelly exports

2010-07-20 Thread Dave Malcolm
Dave Malcolm added the comment: py3k is much cleaner than python 2, due to the change in the module API. Here's "make smelly"'s output on a recent py3k checkout: nm -p libpython3.2.a | \ sed -n "/ [TDB] /s/.* //p" | grep -v "^_*Py

[issue4555] Smelly exports (global symbols in python not prefixed with Py or _Py)

2010-07-20 Thread Dave Malcolm
Dave Malcolm added the comment: Patch to py3k which adds the "_Py" prefix to the four listed symbols. With this, the output from "make smelly" is clean (odorless, perhaps?). However, adding _Py does seem to go against this comment in Include/asdl.h: /* It would be nice i

[issue8912] `make patchcheck` should check the whitespace of .c/.h files

2010-07-21 Thread Dave Malcolm
Changes by Dave Malcolm : -- nosy: +dmalcolm ___ Python tracker <http://bugs.python.org/issue8912> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9324] signal.signal(bogus_signal, handler) segfaults on Windows

2010-07-21 Thread Dave Fugate
New submission from Dave Fugate : Using Python 2.7 (r27:82525, Jul 4 2010, 09:01:59; 32-bit Intel) on 64-bit Windows Server 2008 R2, python.exe (interactive sessions and files) crashes when it encounters the following snippet: >>> import signal >>> signal.signal(7, lambda

[issue9326] Error message for incorrect number of (function) args is incorrect

2010-07-21 Thread Dave Fugate
New submission from Dave Fugate : The error message below should state something along the lines of "f() takes at least 1 non-keyword argument (0 given)". Regardless, this is a regression from 2.6 which would have emitted "f() takes at least 1 argument (0 given)" which w

[issue9326] Error message for incorrect number of (function) args is incorrect

2010-07-21 Thread Dave Fugate
Dave Fugate added the comment: Actually CPython 2.6 emits precisely what I'd expect: D:\rft\vsl\dlr\Languages\IronPython\Tests>26 Python 2.6.2 (r262:71605, Apr 14 2009, 22:40:02) [MSC v.1500 32 bit (Intel)] on win32 Type "help", "copyright", "credits" or &

[issue9259] Python 2.7 breaks assigned __exit__s

2010-07-26 Thread Dave Malcolm
Changes by Dave Malcolm : -- nosy: +dmalcolm ___ Python tracker <http://bugs.python.org/issue9259> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue9386] Bad indentation in urllib import fixer with multipe imports

2010-07-26 Thread Dave Malcolm
New submission from Dave Malcolm : Running 2to3 on lxml-2.2.6 failed with broken indentation. This fragment from lxml/html/__init__.py: > def open_http_urllib(method, url, values): > ## FIXME: should test that it's not a relative URL or something > try: >f

[issue9386] Bad indentation in urllib import fixer with multiple imports

2010-07-26 Thread Dave Malcolm
Changes by Dave Malcolm : -- title: Bad indentation in urllib import fixer with multipe imports -> Bad indentation in urllib import fixer with multiple imports ___ Python tracker <http://bugs.python.org/iss

[issue5504] ctypes should work with systems where mmap can't be PROT_WRITE and PROT_EXEC

2010-07-28 Thread Dave Malcolm
Dave Malcolm added the comment: FWIW, the patch for this that I'm currently applying to Fedora's python 2.7 rpms can be seen at: http://cvs.fedoraproject.org/viewvc/devel/python/python-2.7rc1-ctypes-noexecmem.patch?revision=1.1&content-type=text%2Fplain&view=co It doesn&#x

[issue9518] PyModuleDef_HEAD_INIT does not explicitly initial all fields of m_base

2010-08-04 Thread Dave Malcolm
New submission from Dave Malcolm : Attempting to compile Python 3 extension modules on GCC with "-Wmissing-field-initializers" enabled leads to warnings from the PyModuleDef_HEAD_INIT macro Seen attempting to build SELinux python bindings against python 3.1 with "-W -W

[issue9518] PyModuleDef_HEAD_INIT does not explicitly initialize all fields of m_base

2010-08-04 Thread Dave Malcolm
Changes by Dave Malcolm : -- title: PyModuleDef_HEAD_INIT does not explicitly initial all fields of m_base -> PyModuleDef_HEAD_INIT does not explicitly initialize all fields of m_base ___ Python tracker <http://bugs.python.org/iss

[issue917120] imaplib: incorrect quoting in commands

2010-08-05 Thread Dave Baggett
Dave Baggett added the comment: Piers Lauder, author of imaplib, emailed me the following comment about this bug: The regex for "mustquote_cre" looks bizarre, and I regret to say I can no longer remember its genesis. Note however, that the term CTL in the RFC definition

[issue29261] Missing venv/scripts/common after "make install"

2017-01-13 Thread Dave Jones
New submission from Dave Jones: While attempting to diagnose something (unrelated to this issue) under python 3.6, I used the following steps to clone and build a non-root python installation: $ mkdir py36 $ hg clone https://hg.python.org/cpython $ cd cpython $ hg update 3.6

[issue29270] super call in ctypes sub-class fails in 3.6

2017-01-13 Thread Dave Jones
New submission from Dave Jones: While investigating a bug report in one of my libraries (https://github.com/waveform80/picamera/issues/355) I've come across a behaviour that appears in Python 3.6 but not prior versions. Specifically, calling super() in a sub-class of a ctypes scalar

[issue29270] super call in ctypes sub-class fails in 3.6

2017-01-14 Thread Dave Jones
Dave Jones added the comment: I confess I'm going to have to read a bit more about Python internals before I can understand Eryk's analysis (this is my first encounter with "cell objects"), but many thanks for the rapid analysis and patch! I'm not too concerned abo

[issue29443] Re-running Windows installer should have option to set PATH

2017-02-04 Thread Dave Brondsema
New submission from Dave Brondsema: If you miss the checkbox to set the "PATH" when installing Python for the first time, there isn't any easy way to set it again. (And for new programmers, having it set automatically is extremely useful). Uninstalling and re-installing d

[issue29443] Re-running Windows installer should have option to set PATH

2017-02-04 Thread Dave Brondsema
Dave Brondsema added the comment: A colleague has pointed out to me that this is available in the 2nd step within "Modify". I didn't realize there were more options after the first "Modify" screen. So perhaps the UI could be improved, but t

[issue29443] Re-running Windows installer should have option to set PATH

2017-02-04 Thread Dave Brondsema
Dave Brondsema added the comment: Yes, exactly. -- ___ Python tracker <http://bugs.python.org/issue29443> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue29574] python-3.6.0.tgz permissions borked

2017-02-15 Thread Dave Anderson
New submission from Dave Anderson: Downloaded https://www.python.org/ftp/python/3.6.0/Python-3.6.0.tgz Extracted on CentOS6 with sudo tar -xf Python-3.6.0.tgz Result: [vagrant@developer tmp]$ ls -l Python-3.6.0 ls: cannot access Python-3.6.0/Tools: Permission denied ls: cannot access Python

[issue29574] python-3.6.0.tgz permissions borked

2017-02-15 Thread Dave Anderson
Dave Anderson added the comment: Sorry, should have shown sudo ls -l output for 3.6: [vagrant@developer tmp]$ sudo ls -l Python-3.6.0 total 1016 -rw-r--r-- 1 caturra games 10910 Dec 22 18:21 aclocal.m4 -rwxr-xr-x 1 caturra games 42856 Dec 22 18:21 config.guess -rwxr-xr-x 1 caturra games

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-05-29 Thread Dave Sawyer
Dave Sawyer added the comment: The revised patch says "connections" plural for true and "connection" singular for false. How about "the connection" since the method returns a connection. I'm wondering though about the lack of explanation or WHY for this param

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-02 Thread Dave Sawyer
Dave Sawyer added the comment: The user probably has a recent enough version. This is guaranteed on Windows since Python bundles 3.6 or later. On mac or Linux it will use the version installed on the machine. I'll make a separate patch to check the version in sqlite3.py so it will gi

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-02 Thread Dave Sawyer
Dave Sawyer added the comment: Changed doc to note that not only must it be used on 1 thread if true, but that thread must be the thread that created it. -- ___ Python tracker <http://bugs.python.org/issue27

[issue27188] sqlite3 execute* methods return value not documented

2016-06-02 Thread Dave Sawyer
New submission from Dave Sawyer: The three execute methods of the connection object return the created cursor. The term "intermediate" implies the cursor is totally handled by the execute method, not that the user will get ownership of the object. When the user doesn't call

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-02 Thread Dave Sawyer
Dave Sawyer added the comment: Hi Thomas and Senthil, for the serialized setting I mentioned earlier "The serialized mode is default on both Mac and Windows so we can probably skip validating that. I did like mentioning the user needs to serialize the writes. They could use one threa

[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-02 Thread Dave Sawyer
New submission from Dave Sawyer: Starting in sqlite version 3.3.1 (Jan 2006) multiple threads can share the same connection. Python allows you do use this with the check_same_thread parameter of sqlite3.connect() method. It's almost certain users have a late enough version of sqlite that

[issue27190] Check sqlite3_version before allowing check_same_thread = False

2016-06-03 Thread Dave Sawyer
Dave Sawyer added the comment: This can go into bugfix branches. In fact, it's most likely to be helpful there because they are more likely to be running with a version of sqlite 10 years old. I use the sqlite3_libversion_number() call because I'm testing against the version

[issue27113] sqlite3 connect parameter "check_same_thread" not documented

2016-06-03 Thread Dave Sawyer
Dave Sawyer added the comment: hurray! My first commit -- ___ Python tracker <http://bugs.python.org/issue27113> ___ ___ Python-bugs-list mailing list Unsub

[issue27188] sqlite3 execute* methods return value not documented

2016-06-06 Thread Dave Sawyer
Dave Sawyer added the comment: Updated optional parameters. Fixed executescript which takes a single parameter. The English is correct - one needs to looks at the verbs to be sure they match in tense and number. Like "He OPENS the fridge, GRABS the milk, and DRINKS it." This method

[issue27188] sqlite3 execute* methods return value not documented

2016-06-06 Thread Dave Sawyer
Dave Sawyer added the comment: No problem. I did a pull and reposted with additional fixes suggested by Berker and one copy/paste error I spotted. On Sat, Jun 4, 2016 at 11:34 PM, SilentGhost wrote: > > SilentGhost added the comment: > > Thanks for the patch, Dave. For whatev

[issue17206] Py_XDECREF() expands its argument multiple times

2013-02-14 Thread Dave Malcolm
New submission from Dave Malcolm: When running my refcount static analyzer [1] on a large corpus of real-world C extension code for Python, I ran into the following construct in various places: Py_XDECREF(PyObject_CallObject(callable, args)); This is bogus code: Py_XDECREF expands its

[issue17258] multiprocessing.connection challenge implicitly uses MD5

2013-02-20 Thread Dave Malcolm
New submission from Dave Malcolm: Within multiprocessing.connection, deliver_challenge() and answer_challenge() use hmac for a challenge/response. hmac implicitly defaults to using MD5. MD5 should no longer be used for security purposes. See e.g. http://www.kb.cert.org/vuls/id/836068 This

[issue17366] os.chdir win32

2013-03-05 Thread Dave Humphries
New submission from Dave Humphries: os.chdir missed a back slash in rewriting a file path see example below (the extra backslash was missing from the trunk directory). Modifying the path with an extra slash enabled this to work for some reason. (os windows 8 64 bit Python 2.7.3 (default, Apr

[issue17366] os.chdir win32

2013-03-06 Thread Dave Humphries
Dave Humphries added the comment: Hi Amaury, As I can't reopen the bug I will have to add it here (or open a new bug report). The issue was about the string used in os.chdir() particularly. While this is expected behaviour in a python string it is not expected behaviour from a well formed

[issue16754] Incorrect shared library extension on linux

2013-03-06 Thread Dave Malcolm
Dave Malcolm added the comment: For reference, quoting PEP 3149: >>> sysconfig.get_config_var('SO') '.cpython-32mu.so' -- nosy: +dmalcolm ___ Python tracker <h

[issue17366] os.chdir win32

2013-03-07 Thread Dave Humphries
Dave Humphries added the comment: Thanks for the thoughtful response Tim, I am obviously not being clear with the way I express this. os.chdir uses a common string but these strings represent a special subset of strings. I'm not sure about mac and linux but windows has arrange of characters

[issue17449] dev guide appears not to cover the benchmarking suite

2013-03-17 Thread Dave Malcolm
New submission from Dave Malcolm: Does the devguide document the benchmarking suite anywhere? I can't see it anywhere in the index on http://docs.python.org/devguide/ and google doesn't seem to show anything. suggested content: * how to run the benchmarks for a Python 2 impl

<    1   2   3   4   5   6   7   >