[issue32591] Deprecate sys.set_coroutine_wrapper and replace it with more focused API(s)

Yury Selivanov added the comment: > OK. I hope both of you keep an eye on this and actively try to test and break it! That's the plan! -- ___ Python tracker <https://bugs.python.org

[issue32662] Implement Server.serve_forever and corresponding APIs

Yury Selivanov added the comment: I think these failures were on the previous version of the test; i've fixed it last night and it shouldn't timeout this way anymore. -- ___ Python tracker <https://bugs.python.o

[issue32571] Speed up and clean up getting optional attributes in C code

Yury Selivanov added the comment: Closing this one now. Thanks Serhiy and Inada-san! -- nosy: +yselivanov resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32670] Enforce PEP 479—StopIteration and generators—in Python 3.7 by default

Yury Selivanov added the comment: New changeset 43c47fe09640c579462978ec16f81295f5857cde by Yury Selivanov in branch 'master': bpo-32670: Enforce PEP 479. (#5327) https://github.com/python/cpython/commit/43c47fe09640c579462978ec16f812

[issue32670] Enforce PEP 479—StopIteration and generators—in Python 3.7 by default

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32630] Migrate decimal to use PEP 567 context variables

Yury Selivanov added the comment: > However, I could not find any tests for the added feature (safe > use with async) though. We would be adding a new feature without > tests. This is no problem, I can add a few async/await tests. > I'm getting a large slowdown: > ./pyt

[issue32436] Implement PEP 567

Change by Yury Selivanov : -- pull_requests: +5197 ___ Python tracker <https://bugs.python.org/issue32436> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32630] Migrate decimal to use PEP 567 context variables

Yury Selivanov added the comment: Sorry Stefan, I never wanted this to look like "I'm pushing this without listening to Stefan". I apologize if it looked that way. I ran bm_telco on my machine before submitting the PR, and I indeed did not see any performance impact. I&#

[issue32436] Implement PEP 567

Yury Selivanov added the comment: New changeset 226e50049da43097d89e9e99f9c55f212d1f7bd5 by Yury Selivanov in branch 'master': bpo-32436: Make PyContextVar_Get a little bit faster (#5350) https://github.com/python/cpython/commit/226e50049da43097d89e9e99f9c55f

[issue32436] Implement PEP 567

Change by Yury Selivanov : -- pull_requests: +5207 ___ Python tracker <https://bugs.python.org/issue32436> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32436] Implement PEP 567

Yury Selivanov added the comment: New changeset bc4123b0b380edda774b8bff2fa1bcc96453b440 by Yury Selivanov in branch 'master': bpo-32436: Use PyThreadState_GET() in all hot paths (GH-5363) https://github.com/python/cpython/commit/bc4123b0b380edda774b8bff2fa1bc

[issue32630] Migrate decimal to use PEP 567 context variables

Yury Selivanov added the comment: Thank you, Stefan. I've updated the PR with an asyncio+decimal test and run tests in refleak mode to make sure there's no regression there. If during the beta/rc period we see that contextvars isn't stable enough or something I'll rever

[issue32630] Migrate decimal to use PEP 567 context variables

Yury Selivanov added the comment: New changeset f13f12d8daa587b5fcc66fe3ed1090a5dadab289 by Yury Selivanov in branch 'master': bpo-32630: Use contextvars in decimal (GH-5278) https://github.com/python/cpython/commit/f13f12d8daa587b5fcc66fe3ed1090

[issue32630] Migrate decimal to use PEP 567 context variables

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32622] Implement loop.sendfile

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <https://bugs.python

[issue32622] Implement loop.sendfile

Change by Yury Selivanov : -- pull_requests: +5208 ___ Python tracker <https://bugs.python.org/issue32622> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32622] Implement loop.sendfile

Yury Selivanov added the comment: New changeset b1a6ac4c4026d648b3d948945b734a4d0f175a3c by Yury Selivanov in branch 'master': bpo-32622: Enforce sendfile fallback policy for FALLBACK transports (#5364) https://github.com/python/cpython/commit/b1a6ac4c4026d648b3d948945b734a

[issue32622] Implement loop.sendfile

Change by Yury Selivanov : -- pull_requests: +5212 ___ Python tracker <https://bugs.python.org/issue32622> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32622] Implement loop.sendfile

Yury Selivanov added the comment: > AttributeError: 'NoneType' object has no attribute 'SSLContext' We've just pushed a fix for this. -- ___ Python tracker <htt

[issue32622] Implement loop.sendfile

Yury Selivanov added the comment: New changeset ee72ac0683e685b134f67cb0c6612c664ecadb65 by Yury Selivanov (Elvis Pranskevichus) in branch 'master': bpo-32622: Fix AbstractEventLoop.sendfile signature in documentation. (GH-5368) https://github.com/python/cpyt

[issue32221] Converting ipv6 address to string representation using getnameinfo() is wrong.

Yury Selivanov added the comment: New changeset 47c0b1f7d4115e6f15e6776c1f91d28e7d96fe0c by Yury Selivanov (Коренберг Марк) in branch 'master': bpo-32221: makeipaddr(): remove interface part + speedup (GH-4724) https://github.com/python/cpython/commit/47c0b1f7d4115e6f15e6776c1f91d2

[issue32221] Converting ipv6 address to string representation using getnameinfo() is wrong.

Yury Selivanov added the comment: Merged. Thanks, Mark! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32622] Implement loop.sendfile

Yury Selivanov added the comment: New changeset 2a2247ce5e1984eb2f2c41b269b38dbb795a60cf by Yury Selivanov in branch 'master': bpo-32622: Normalize ENOTCONN to ConnectionError on macOS (GH-5369) https://github.com/python/cpython/commit/2a2247ce5e1984eb2f2c41b269b38d

[issue32622] Implement loop.sendfile

Yury Selivanov added the comment: I think we've fixed everything. Closing this for now, Victor please reopen if buildbots misbehave. -- resolution: -> fixed status: open -> closed ___ Python tracker <https://bugs.python.

[issue32436] Implement PEP 567

Change by Yury Selivanov : -- pull_requests: +5213 ___ Python tracker <https://bugs.python.org/issue32436> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32694] macos/configure: Discover OpenSSL when installed with MacPorts

Change by Yury Selivanov : -- components: Cross-Build nosy: Alex.Willmer, christian.heimes, ned.deily, yselivanov priority: normal severity: normal status: open title: macos/configure: Discover OpenSSL when installed with MacPorts type: enhancement versions: Python 3.7

[issue32694] macos/configure: Discover OpenSSL when installed with MacPorts

New submission from Yury Selivanov : Not sure if we should do it or not: 1. MacPorts maintainers will create a port file for Python 3.7 and they will just configure it with `configure --with-openssl=$PREFIX", where PREFIX is /opt/local by default. 2. This, however, would certainly im

[issue32694] macos/configure: Discover OpenSSL when installed with MacPorts

Change by Yury Selivanov : -- keywords: +patch pull_requests: +5223 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue32694> ___ ___ Py

[issue26219] implement per-opcode cache in ceval

Yury Selivanov added the comment: > With the 3.7 beta deadline just around the corner, 3.8 will be the next > opportunity to reconsider this idea. Nick, Ned, Guido, Would it be OK if we add this to 3.7beta2? I feel kind of bad about this one... few thoughts: 1. The speedup is abou

[issue26219] implement per-opcode cache in ceval

Yury Selivanov added the comment: > It's up to the release manager, but personally it feels like you're pushing too hard. Since you've done that frequently in the past I think we should help you by declining your request. NP, I totally understand. > Now maybe we'

[issue32694] macos/configure: Discover OpenSSL when installed with MacPorts

Yury Selivanov added the comment: > The good news is that, since Christian's recent enhancements in Issue32598 to > have autoconf use pkg-config to detect OpenSSL header and lib files, > configure will now automatically find the MacPorts OpenSSL as long as the > MacPo

[issue32694] macos/configure: Discover OpenSSL when installed with MacPorts

Yury Selivanov added the comment: OK, so the trick is to first install pkg-config: sudo port install pkgconfig ./configure make python -m ssl # works I'll close the PR then, but we need to document this trick with pkg-config some

[issue32327] Make asyncio methods documented as coroutines - coroutines.

Change by Yury Selivanov : -- pull_requests: +5227 ___ Python tracker <https://bugs.python.org/issue32327> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32690] Return function locals() in order of creation?

Yury Selivanov added the comment: Why did this fix go to 3.6? -- nosy: +yselivanov ___ Python tracker <https://bugs.python.org/issue32690> ___ ___ Python-bug

[issue32327] Make asyncio methods documented as coroutines - coroutines.

Yury Selivanov added the comment: New changeset bec2372b7e1da5dfdbadaf242aa8e994b164cace by Yury Selivanov in branch 'master': bpo-32327: Revert loop.run_in_executor behaviour: return a Future. (#5392) https://github.com/python/cpython/commit/bec2372b7e1da5dfdbadaf242aa8e9

[issue32697] Guarantee that Python preserves the order of kwonly parameters

Yury Selivanov added the comment: > Today we've all collectively made Python a better programming language. Literally can't stop doing that for some reason... :) -- ___ Python tracker <https://bugs.pytho

[issue32221] Converting ipv6 address to string representation using getnameinfo() is wrong.

Change by Yury Selivanov : -- pull_requests: +5229 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue32221> ___ ___ Python-bugs-list mai

[issue32221] Converting ipv6 address to string representation using getnameinfo() is wrong.

Yury Selivanov added the comment: Mark, Two tests fail on MacOS X now (newly added tests). I'm reverting the change for now. If you figure this out, please re-submit a PR for a quick approval. ==

[issue32221] Converting ipv6 address to string representation using getnameinfo() is wrong.

Yury Selivanov added the comment: New changeset 0ceb717689b04c0540d78c1ba93c0572c66c0994 by Yury Selivanov in branch 'master': Revert "bpo-32221: makeipaddr(): remove interface part + speedup (GH-4724)" (#5394) https://github.com/python/cpython/commit/0ceb717689b04c0540d7

[issue31333] Implement ABCMeta in C

Yury Selivanov added the comment: > Let's try to get it in as soon as we can, please! Thank you, Ned! We'll get it merged in the next few days. -- ___ Python tracker <https://bugs.pytho

[issue32251] Add asyncio.BufferedProtocol

Yury Selivanov added the comment: New changeset 631fd38dbf04dbf0127881f3977982e401a849e4 by Yury Selivanov in branch 'master': bpo-32251: Implement asyncio.BufferedProtocol. (#4755) https://github.com/python/cpython/commit/631fd38dbf04dbf0127881f3977982

[issue32690] Return function locals() in order of creation?

Yury Selivanov added the comment: I don't have a strong opinion on this, but I worry a bit that while the change is trivial, it still might break something (doctests? some obscure code?) in the next 3.6 point release. -- ___ Python tracker &

[issue32251] Add asyncio.BufferedProtocol

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <https://bugs.python

[issue32221] Converting ipv6 address to string representation using getnameinfo() is wrong.

Yury Selivanov added the comment: Mark, I think this still land in beta-2. Please try to figure out what's going on on Mac OS (I have no time to take care of this myself). -- ___ Python tracker <https://bugs.python.org/is

[issue32373] Add socket.getblocking() method

Yury Selivanov added the comment: New changeset f11b460d8717fc3a5810684713b8b818f68789e8 by Yury Selivanov in branch 'master': bpo-32373: Add socket.getblocking() method. (#4926) https://github.com/python/cpython/commit/f11b460d8717fc3a5810684713b8b8

[issue32373] Add socket.getblocking() method

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32650] Debug support for native coroutines is broken

Yury Selivanov added the comment: New changeset c7ab581db216aeeb1c2aa7af2f2198d2b7516383 by Yury Selivanov (Pablo Galindo) in branch 'master': bpo-32650 Add support for async generators and more test for coroutines in pdb (#5403) https://github.com/python/cpyt

[issue32650] Debug support for native coroutines is broken

Change by Yury Selivanov : -- pull_requests: +5239 ___ Python tracker <https://bugs.python.org/issue32650> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32650] Debug support for native coroutines is broken

Yury Selivanov added the comment: New changeset 9ee1bf9ab5af8233ed8ec5c53d12a29dc1bd9c9d by Yury Selivanov in branch 'master': bpo-32650: Add an asyncgen pdb test (#5406) https://github.com/python/cpython/commit/9ee1bf9ab5af8233ed8ec5c53d12a2

[issue32650] Debug support for native coroutines is broken

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <https://bugs.python

[issue32703] 'async with' somehow suppresses unawaited coroutine warnings

Change by Yury Selivanov : -- components: +Interpreter Core -asyncio nosy: +ncoghlan ___ Python tracker <https://bugs.python.org/issue32703> ___ ___ Python-bug

[issue32251] Add asyncio.BufferedProtocol

Change by Yury Selivanov : -- pull_requests: +5241 ___ Python tracker <https://bugs.python.org/issue32251> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32251] Add asyncio.BufferedProtocol

Yury Selivanov added the comment: New changeset 07627e9a6a5f418354ff3dc99a0f36bc5b79dcd8 by Yury Selivanov in branch 'master': bpo-32251: Fix docs (#5408) https://github.com/python/cpython/commit/07627e9a6a5f418354ff3dc99a0f36

[issue23749] asyncio missing wrap_socket (starttls)

Change by Yury Selivanov : -- pull_requests: +5242 stage: resolved -> patch review ___ Python tracker <https://bugs.python.org/issue23749> ___ ___ Python-

[issue23749] asyncio missing wrap_socket (starttls)

Yury Selivanov added the comment: New changeset 1e5b25b8c0c45ccfd58da2cb82fdf231c6823fef by Yury Selivanov in branch 'master': bpo-23749: Make start-tls tests more stable on win7 buildbot (GH-5409) https://github.com/python/cpython/commit/1e5b25b8c0c45ccfd58da2cb82fdf2

[issue32703] 'async with' somehow suppresses unawaited coroutine warnings

Yury Selivanov added the comment: Changing async def main(): async with open_file(): pass to async def main(): c = open_file() async with c: pass also makes it print the warning :) Also I've made a test out of this snippet and running tests in refleak

[issue32703] 'async with' somehow suppresses unawaited coroutine warnings

Yury Selivanov added the comment: The difference between these two functions is two extra opcodes: STORE_FAST/LOAD_FAST before BEFORE_ASYNC_WITH. With them we have a warning. -- ___ Python tracker <https://bugs.python.org/issue32

[issue32703] 'async with' somehow suppresses unawaited coroutine warnings

Yury Selivanov added the comment: So refactoring it into "c = open_file(); async with c" just prolongs the life of the coroutine so that it's GCed outside of WITH_CLEANUP_START/WITH_CLEANUP_FINISH block. Something weird is going on

[issue32703] 'async with' somehow suppresses unawaited coroutine warnings

Yury Selivanov added the comment: Ah, we should never really get to WITH_CLEANUP_START; the exception should be raised in BEFORE_ASYNC_WITH -- ___ Python tracker <https://bugs.python.org/issue32

[issue32703] 'async with' somehow suppresses unawaited coroutine warnings

Change by Yury Selivanov : -- keywords: +patch pull_requests: +5243 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue32703> ___ ___ Py

[issue32703] 'async with' somehow suppresses unawaited coroutine warnings

Yury Selivanov added the comment: So the problem was that _PyGen_Finalize wasn't issuing any warnings if there's any error set in the current tstate. And in Nathaniel's case, the current error was an AttributeError('__aexit__'). This check is weird, because right b

[issue32591] Deprecate sys.set_coroutine_wrapper and replace it with more focused API(s)

Yury Selivanov added the comment: Nathaniel, test_coroutines raises a bunch of Runtime and Deprecation warnings after this PR. Could you please make a PR to silence them? /Users/yury/dev/pydev/cpython/Lib/test/test_coroutines.py:1032: RuntimeWarning: coroutine 'CoroutineTest.test_awa

[issue32605] Should we really hide unawaited coroutine warnings when an exception is pending?

Yury Selivanov added the comment: So in issue 32703 we consider removing the check. I'll try to figure out what to do with "coroutine ... was never awaited" warnings in test_coroutines -- probably just silence them. -- ___ Python

[issue32591] Deprecate sys.set_coroutine_wrapper and replace it with more focused API(s)

Yury Selivanov added the comment: Specifically "DeprecationWarning: get_coroutine_wrapper is deprecated" needs to be silenced as part of this issue. -- ___ Python tracker <https://bugs.python.o

[issue27968] test_coroutines generates some warnings

Change by Yury Selivanov : -- pull_requests: +5245 ___ Python tracker <https://bugs.python.org/issue27968> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32703] 'async with' somehow suppresses unawaited coroutine warnings

Yury Selivanov added the comment: I knew about that "if", but it never fully registered to me why it's there and what it is protecting us from ;) So I had to debug half of ceval loop before I stumbled upon it again ;) -- ___ Python

[issue23749] asyncio missing wrap_socket (starttls)

Yury Selivanov added the comment: I have a feeling that using threads+IO+asyncio makes the test too unstable on some Windows buildbots. I'll rewrite start-tls tests without using threads. -- ___ Python tracker <https://bugs.python.org/is

[issue32710] test_asyncio leaked [4, 4, 3] memory blocks, sum=11 on AMD64 Windows8.1 Refleaks 3.x

Yury Selivanov added the comment: Andrew, please take a look. I'll have very limited (to no at all) time to work on Python in the next 2 weeks. -- ___ Python tracker <https://bugs.python.org/is

[issue32707] Python/hamt.c warnings

Change by Yury Selivanov : -- keywords: +patch pull_requests: +5265 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue32707> ___ ___ Py

[issue32707] Python/hamt.c warnings

Yury Selivanov added the comment: > IMHO it's a real bug, No. HAMT bitmap and array nodes can only store up to 32 pointers, so we use Py_ssize_t & Py_SIZE only because those nodes are PyObject_VAR_HEAD objects. -- stage:

[issue32707] Python/hamt.c warnings

Yury Selivanov added the comment: New changeset b647d7039d396b1da71ab33b101a78b53d4e6834 by Yury Selivanov in branch 'master': bpo-32707: Fix warnings in hamt.c (#5430) https://github.com/python/cpython/commit/b647d7039d396b1da71ab33b101a78

[issue32707] Python/hamt.c warnings

Change by Yury Selivanov : -- components: -asyncio ___ Python tracker <https://bugs.python.org/issue32707> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32707] Python/hamt.c warnings

Yury Selivanov added the comment: Hopefully the warnings will be fixed. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32703] 'async with' somehow suppresses unawaited coroutine warnings

Yury Selivanov added the comment: New changeset 2a2270db9be9bdac5ffd2d50929bf905e7391a06 by Yury Selivanov in branch 'master': bpo-32703: Fix coroutine resource warning in case where there's an error (GH-5410) https://github.com/python/cpython/commit/2a2270db9be9bdac5ffd2d509

[issue32703] 'async with' somehow suppresses unawaited coroutine warnings

Yury Selivanov added the comment: Merged; closing this issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue32605] Should we really hide unawaited coroutine warnings when an exception is pending?

Yury Selivanov added the comment: With PR https://github.com/python/cpython/pull/5410 being merged I believe this issue can be now closed. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracke

[issue32605] Should we really hide unawaited coroutine warnings when an exception is pending?

Change by Yury Selivanov : -- components: +Interpreter Core -asyncio ___ Python tracker <https://bugs.python.org/issue32605> ___ ___ Python-bugs-list mailin

[issue24325] Speedup types.coroutine()

Yury Selivanov added the comment: Closing this one now--there's no point in speeding up types.coroutine anymore. -- resolution: -> rejected stage: patch review -> resolved status: open -> closed ___ Python tracker <https:

[issue20104] expose posix_spawn(p)

Yury Selivanov added the comment: FYI New defect(s) Reported-by: Coverity Scan Showing 2 of 2 defect(s) ** CID 1428733: Memory - illegal accesses (RETURN_LOCAL) /Modules/posixmodule.c: 5281 in os_posix_spawn_impl

[issue20104] expose posix_spawn(p)

Change by Yury Selivanov : -- nosy: -yselivanov ___ Python tracker <https://bugs.python.org/issue20104> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28099] Drop Mac OS X Tiger support in Python 3.6

Yury Selivanov added the comment: TBH I don't think we need to care about OS X Tiger. I mean Apple itself doesn't care about it anymore, the last release was 10 years ago. How about we drop its buildbot? -- nosy: +yselivanov ___ Pyth

[issue29915] Drop Mac OS X Tiger support in Python 3.7?

Yury Selivanov added the comment: Duplicating my message to issue 28099 here: TBH I don't think we need to care about OS X Tiger. I mean Apple itself doesn't care about it anymore, the last release was 10 years ago. How about we drop its buildbot? I don't see any point in

[issue29915] Drop Mac OS X Tiger support in Python 3.7?

Yury Selivanov added the comment: > Unless there's a burning issue, let's revisit this after beta 1. There're no burning issues currently, last fixes to asyncio made the buildbot happy. I'm totally fine to revisit this later. -- ___

[issue32715] Make create_unix_server for SOCK_DGRAM work

Yury Selivanov added the comment: SOCK_DGRAM is never reliable, even for AF_UNIX. It might appear reliable to your test code, but there's no guarantee for that under any OS in Posix standard AFAIK. -- resolution: -> rejected stage: -> resolved status: ope

[issue32715] Make create_unix_server for SOCK_DGRAM work

Yury Selivanov added the comment: Hm, maybe I'm mistaken here, but I have no time right now to confirm. I'll reopen the issue so that we can consider this (and especially SEQPACKET) for 3.8. Sorry for insta-reject :) -- resolution: rejected -> stage: resolved ->

[issue32604] Expose the subinterpreters C-API in Python for testing use.

Yury Selivanov added the comment: A couple defects reported by coverity: ** CID 1428758: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /Modules/_xxsubinterpretersmodule.c: 45 in _coerce_id

[issue31356] Add context manager to temporarily disable GC

Change by Yury Selivanov : -- resolution: fixed -> stage: resolved -> status: closed -> open ___ Python tracker <https://bugs.python.org/issue31356> ___ ___

[issue31356] Add context manager to temporarily disable GC

Yury Selivanov added the comment: A bug found by coverity: (PyErr_WarnEx might error out; please update the code to handle that) *** CID 1428756: Error handling issues (CHECKED_RETURN

[issue31356] Add context manager to temporarily disable GC

Change by Yury Selivanov : -- pull_requests: +5288 ___ Python tracker <https://bugs.python.org/issue31356> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue31356] Add context manager to temporarily disable GC

Yury Selivanov added the comment: Just noting here: the original PR was a little bit under-reviewed: return values of C functions were not checked, and the code style was very far from PEP 7. -- ___ Python tracker <https://bugs.python.

[issue31356] Add context manager to temporarily disable GC

Yury Selivanov added the comment: IMO this needs to be pulled from 3.7. Ned? -- ___ Python tracker <https://bugs.python.org/issue31356> ___ ___ Python-bug

[issue31356] Add context manager to temporarily disable GC

Yury Selivanov added the comment: > The style issues and missing error checks are easy to address. We're at > 3.7beta1 stage, it is normal to have issues to be cleaned up in a beta > release. I don't understand the code. Please t

[issue31356] Add context manager to temporarily disable GC

Yury Selivanov added the comment: A few thoughts: 1. The merged PR releases GIL for any Python code run in `with gc.ensure_disabled()`. This is just plain wrong. 2. The merged PR crashes on debug build of CPython. 3. I don't actually understand this feature. Our GC is not per OS t

[issue31356] Add context manager to temporarily disable GC

Yury Selivanov added the comment: > But, more importantly, this is a new feature so it doesn't break any existing > code. I imagine you're almost done with the beta-1 release, Ned, so I'd hate to create more work for you here. Let's release beta-1 as is. >

[issue32733] test_coroutines is failed when run with -We

Yury Selivanov added the comment: Nathaniel, this seems to be related to coro-origin-tracking. -- nosy: +njs ___ Python tracker <https://bugs.python.org/issue32

[issue32734] Asyncio Lock safety issue (unlimited acquire)

Change by Yury Selivanov : -- priority: normal -> high stage: -> needs patch type: security -> behavior versions: -Python 3.4, Python 3.5 ___ Python tracker <https://bugs.python.or

[issue32733] test_coroutines is failed when run with -We

Yury Selivanov added the comment: I think assertWarns just handles it. Maybe the test should be converted to use it? -- ___ Python tracker <https://bugs.python.org/issue32

[issue32733] test_coroutines is failed when run with -We

Yury Selivanov added the comment: Or to use assertWarnsRegex -- ___ Python tracker <https://bugs.python.org/issue32733> ___ ___ Python-bugs-list mailin

[issue32741] Add asyncio.TimerHandle.when() function

Yury Selivanov added the comment: How will such test look like? I'm still not sure we need it. -- ___ Python tracker <https://bugs.python.org/issue32741> ___ ___

[issue32741] Add asyncio.TimerHandle.when() function

Yury Selivanov added the comment: OK, makes sense. Can you submit a PR? -- ___ Python tracker <https://bugs.python.org/issue32741> ___ ___ Python-bugs-list mailin

<    2   3   4   5   6   7   8   9   10   11   >