[issue34762] Change contextvars C API to use PyObject

2018-09-21 Thread Yury Selivanov
Yury Selivanov added the comment: Fixed in master and 3.7. Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ Python tracker <https://bugs.python

[issue33649] asyncio docs overhaul

2018-09-21 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset db1a80e97aa7217c561fb3627f70be1882de9534 by Yury Selivanov in branch 'master': bpo-33649: Fix gather() docs; fix title; few other nits. (GH-9475) https://github.com/python/cpython/commit/db1a80e97aa7217c561fb3627f70be

[issue33649] asyncio docs overhaul

2018-09-21 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset e45662c28bfc84aa3674463a2995e45da4d63793 by Yury Selivanov (Miss Islington (bot)) in branch '3.7': bpo-33649: Fix gather() docs; fix title; few other nits. (GH-9475) (GH-9481) https://github.com/python/cpyt

[issue34037] asyncio: BaseEventLoop.close() shutdowns the executor without waiting causing leak of dangling threads

2018-09-21 Thread Yury Selivanov
Yury Selivanov added the comment: > Yury, Andrew: Do you know if the executor doesn't wait on purpose? Would it > be possible to change that in Python 3.8? Maybe. At least we need to add a "timeout" argument to asyncio.run() to let it wait for executor jobs. I'm

[issue34776] Postponed annotations break inspection of dataclasses

2018-09-23 Thread Yury Selivanov
Change by Yury Selivanov : -- keywords: +patch pull_requests: +8923 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue34776> ___ ___ Py

[issue34776] Postponed annotations break inspection of dataclasses

2018-09-23 Thread Yury Selivanov
Yury Selivanov added the comment: > See this for Yury's self-described "hack-ish fix we can use" until we do > something better: Actually, I think I found a better solution that doesn't require any changes to anything besides dataclasses. Currently, dataclasses

[issue34776] Postponed annotations break inspection of dataclasses

2018-09-23 Thread Yury Selivanov
Yury Selivanov added the comment: And FWIF I don't think we need to use lambdas for annotations to solve issues like this one. -- ___ Python tracker <https://bugs.python.org/is

[issue34788] ipaddress module fails on rfc4007 scoped IPv6 addresses

2018-09-24 Thread Yury Selivanov
Change by Yury Selivanov : -- nosy: +pmoody ___ Python tracker <https://bugs.python.org/issue34788> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34790] Deprecate passing coroutine objects to asyncio.wait()

2018-09-24 Thread Yury Selivanov
New submission from Yury Selivanov : asyncio.wait() accepts coroutines, wraps them into Tasks, and later returns those implicitly created Tasks in (done, pending) sets. This is very confusing to new asyncio users and it's almost impossible to figure out what is going on. See the fir

[issue34790] Deprecate passing coroutine objects to asyncio.wait()

2018-09-24 Thread Yury Selivanov
Change by Yury Selivanov : -- keywords: +patch pull_requests: +8945 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue34790> ___ ___ Py

[issue34790] Deprecate passing coroutine objects to asyncio.wait()

2018-09-24 Thread Yury Selivanov
Yury Selivanov added the comment: > 4.0 is too far. Why not disallow them in 3.10? What's the current plan? I thought it's going to be 3.8, 3.9, 4.0. Is there a PEP detailing this? -- ___ Python tracker <https://bugs.pytho

[issue32528] Change base class for futures.CancelledError

2018-09-24 Thread Yury Selivanov
Yury Selivanov added the comment: > Closing this issue as I, personally, don't see this happening and there's no > point in keeping it open. Actually, Andrew and I changed our opinion on this, so I'm re-opening the issue. After visiting three conferences this summer a

[issue34793] Raise DeprecationWarning for "with (await lock):"

2018-09-24 Thread Yury Selivanov
Change by Yury Selivanov : -- components: asyncio nosy: asvetlov, yselivanov priority: normal severity: normal status: open title: Raise DeprecationWarning for "with (await lock):" versions: Python 3.8 ___ Python tracker <https://bu

[issue34793] Remove support for "with (await asyncio.lock):"

2018-09-24 Thread Yury Selivanov
New submission from Yury Selivanov : Never mind, we do this already. The question is then should we just remove the support for this syntax entirely in 3.8, or we should wait until 3.9? -- title: Raise DeprecationWarning for "with (await lock):" -> Remove support for

[issue34795] loop.sock_recv failure because of delayed callback handling

2018-09-24 Thread Yury Selivanov
Yury Selivanov added the comment: Can you reproduce this with uvloop? Andrew: I think we need to "lock" sockets from closing in sock_recv and friends the same way we do it in uvloop. -- ___ Python tracker <https://bugs.python.o

[issue30064] BaseSelectorEventLoop.sock_{recv, sendall}() don't remove their callbacks when canceled

2018-09-24 Thread Yury Selivanov
Yury Selivanov added the comment: See also https://bugs.python.org/issue34795 -- nosy: +asvetlov versions: +Python 3.8 -Python 3.5, Python 3.6 ___ Python tracker <https://bugs.python.org/issue30

[issue34776] Postponed annotations break inspection of dataclasses

2018-09-24 Thread Yury Selivanov
Yury Selivanov added the comment: NP, Eric, take your time. I agree that the PR isn't simple and needs a very careful review. -- ___ Python tracker <https://bugs.python.org/is

[issue34687] asyncio: is it time to make ProactorEventLoop as the default event loop?

2018-09-25 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 6ea29c5e90dde6c240bd8e0815614b52ac307ea1 by Yury Selivanov (Victor Stinner) in branch 'master': bpo-34687: Make asynico use ProactorEventLoop by default (GH-9538) https://github.com/python/cpython/commit/6ea29c5e90dde6c240bd8e0815614b

[issue34790] Deprecate passing coroutine objects to asyncio.wait()

2018-09-25 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 996859a90df51f84eab47351702cb59c6db4428a by Yury Selivanov in branch 'master': bpo-34790: [docs] Passing coroutines to asyncio.wait() can be confusing. (GH-9543) https://github.com/python/cpython/commit/996859a90df51f84eab47351702cb5

[issue34790] Deprecate passing coroutine objects to asyncio.wait()

2018-09-25 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue34790] Deprecate passing coroutine objects to asyncio.wait()

2018-09-25 Thread Yury Selivanov
Yury Selivanov added the comment: Actually, since Andrew also agrees that we need to deprecate passing coroutines to wait(), I'll keep this issue open until we add an actual DeprecationWarning in 3.8. -- resolution: fixed -> stage: resolved -> status: clo

[issue34790] Deprecate passing coroutine objects to asyncio.wait()

2018-09-25 Thread Yury Selivanov
Yury Selivanov added the comment: PendingDeprecationWarning -- ___ Python tracker <https://bugs.python.org/issue34790> ___ ___ Python-bugs-list mailin

[issue34824] _ssl.c: Possible null pointer dereference

2018-09-27 Thread Yury Selivanov
Change by Yury Selivanov : -- nosy: +yselivanov ___ Python tracker <https://bugs.python.org/issue34824> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Yury Selivanov
Yury Selivanov added the comment: Right, I'll make a PR. -- ___ Python tracker <https://bugs.python.org/issue34762> ___ ___ Python-bugs-list mailing list

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Yury Selivanov
Change by Yury Selivanov : -- pull_requests: +9007 stage: resolved -> patch review ___ Python tracker <https://bugs.python.org/issue34762> ___ ___ Python-

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 994269ccee5574f03cda6b018399347fc52bf330 by Yury Selivanov in branch 'master': bpo-34762: Update PyContext* to PyObject* in asyncio and decimal (GH-9609) https://github.com/python/cpython/commit/994269ccee5574f03cda6b01839934

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Yury Selivanov
Change by Yury Selivanov : -- pull_requests: +9008 ___ Python tracker <https://bugs.python.org/issue34762> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 24cb7de15d3a5979425b281ab4f600f7c2b401f2 by Yury Selivanov in branch '3.7': [3.7] bpo-34762: Update PyContext* refs to PyObject* in asyncio and decimal (GH-9610) https://github.com/python/cpython/commit/24cb7de15d3a5979425b281ab4f600

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Yury Selivanov
Yury Selivanov added the comment: Thank you Serhiy, for re-opening this! I've pushed fixes to 3.7 and master branches. -- stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-27 Thread Yury Selivanov
Change by Yury Selivanov : -- keywords: +patch pull_requests: +9009 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue34802> ___ ___ Py

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-27 Thread Yury Selivanov
Yury Selivanov added the comment: I'll make a simple fix for the asyncio.coroutine decorator docs. > I would suggest below for #coroutines : >> Coroutines declared with async/await syntax is the preferred way of writing >> asyncio applications but asyncio also suppo

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-27 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 59ee5b12938efbf534f2a19300a847bf6b23a77d by Yury Selivanov in branch 'master': bpo-34802: Fix asyncio.iscoroutine() docs (GH-9611) https://github.com/python/cpython/commit/59ee5b12938efbf534f2a19300a847

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-27 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-28 Thread Yury Selivanov
Change by Yury Selivanov : -- pull_requests: +9023 ___ Python tracker <https://bugs.python.org/issue34802> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34831] Asyncio Tutorial

2018-09-28 Thread Yury Selivanov
Yury Selivanov added the comment: I like this, great job! Couple of thoughts on how we should organize this: * I think we should stick to your structure and push things to docs.python.org as soon as every next section is somewhat ready. * Every big section should probably have its own

[issue34769] _asyncgen_finalizer_hook running in wrong thread

2018-10-01 Thread Yury Selivanov
Yury Selivanov added the comment: Wow. Thanks so much for figuring this out, I know how hard it is to debug issues like this. Now I see it clearly: _asyncgen_finalizer_hook should be using loop.call_soon_threadsafe. Interestingly, I used _write_to_self there, so I knew about the issue

[issue34769] _asyncgen_finalizer_hook running in wrong thread

2018-10-01 Thread Yury Selivanov
Yury Selivanov added the comment: Rereading your first message: > When testing my happy eyeballs library, I occasionally run into issues with > async generators seemingly not finalizing. After setting > loop.set_debug(True), I have been seeing log entries like these: The bug we a

[issue34430] Symmetrical chaining futures in asyncio.future.wrap_future

2018-10-01 Thread Yury Selivanov
Yury Selivanov added the comment: The PR needs a very careful review, but in general I'm OK with the idea. I'm also curious why do you want to fix wrap_future -- how are you using it? -- ___ Python tracker <https://bugs.python.o

[issue34014] loop.run_in_executor should propagate current contextvars

2018-10-01 Thread Yury Selivanov
Yury Selivanov added the comment: So we're deprecating passing non-ThreadPoolExecutor instances to loop.set_default_executor. In 3.9 that will trigger an error. For this issue we have basically the next few options: (1) Do nothing; (2) Fix "run_in_executor" to start copying

[issue34014] loop.run_in_executor should propagate current contextvars

2018-10-01 Thread Yury Selivanov
Yury Selivanov added the comment: One problem with (3) is what will happen if someone uses "retain_context=True" and a ProcessPoolExecutor. It has to fail in a graceful and obvious way. -- ___ Python tracker <https://bugs.python.o

[issue34728] deprecate *loop* argument for asyncio.sleep

2018-10-01 Thread Yury Selivanov
Yury Selivanov added the comment: > On python-committers, it has been said that 3.10 will follow Python 3.9, no? Victor, you're looking at an outdated comment on this issue. This is what's in the master branch: https://github.com/python/cpython/blob/d4c76d960b8b286b75c93378041

[issue34728] deprecate *loop* argument for asyncio.sleep

2018-10-01 Thread Yury Selivanov
Change by Yury Selivanov : -- pull_requests: +9054 stage: needs patch -> patch review ___ Python tracker <https://bugs.python.org/issue34728> ___ ___ Python-

[issue34728] deprecate *loop* argument for asyncio.sleep

2018-10-02 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 9012a0fb4c4ec1afef9efb9fdb0964554ea17983 by Yury Selivanov in branch 'master': bpo-34728: Fix asyncio tests to run under "-Werror" (GH-9661) https://github.com/python/cpython/commit/9012a0fb4c4ec1afef9e

[issue34728] deprecate *loop* argument for asyncio.sleep

2018-10-02 Thread Yury Selivanov
Yury Selivanov added the comment: [victor] > Why does it not make sense to pass the loop to sleep? "it makes no sense > anymore" something changes? [andrew] `loop` argument passed to sleep should be always the same as returned from `get_running_loop()`. What Andrew said

[issue34872] investigate task/future cancellation in asynciomodule.c

2018-10-02 Thread Yury Selivanov
New submission from Yury Selivanov : Vladimir Matveev has discovered that C and Python implementation of asyncio.Task diverge: * asynciomodule.c: https://github.com/python/cpython/blob/9012a0fb4c4ec1afef9efb9fdb0964554ea17983/Modules/_asynciomodule.c#L2716 * tasks.py: https://github.com

[issue34872] investigate task/future cancellation in asynciomodule.c

2018-10-02 Thread Yury Selivanov
Yury Selivanov added the comment: Elvis, please take a look at this. -- ___ Python tracker <https://bugs.python.org/issue34872> ___ ___ Python-bugs-list mailin

[issue34872] investigate task/future cancellation in asynciomodule.c

2018-10-02 Thread Yury Selivanov
Yury Selivanov added the comment: Ned, will we have 3.7.1rc2? If so, would it be possible to include the fix for this one? -- nosy: +ned.deily ___ Python tracker <https://bugs.python.org/issue34

[issue34885] asyncio documention has lost its paragraph about cancellation

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: The cancellation is now discussed in this section:https://docs.python.org/3/library/asyncio-task.html (search for "cancel") and in particular in the Task subsection. Is there any important detail that was covered in the old documentation and is

[issue34872] investigate task/future cancellation in asynciomodule.c

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 0c797a6aca1c293e530e18c5e9fa02c670a9a4ed by Yury Selivanov (Elvis Pranskevichus) in branch 'master': bpo-34872: Fix self-cancellation in C implementation of asyncio.Task (GH-9679) https://github.com/python/cpyt

[issue34014] loop.run_in_executor should propagate current contextvars

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: [Andrew] > I vote on not changing `run_in_executor` behavior if we cannot make it work > with `ProcessPoolExecutor`. > If a new API will solve the problem -- that's fine. Until it landed the explicit context propagation is the satisfactory s

[issue34831] Asyncio Tutorial

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: > I too have bashed my head for many hours over the years trying to get Tkinter > to work on Mac, but a lot of work has gone into this recently and the newer > (release) Python's have bundled Tk 8.6: > https://www.python.org/download/mac/tcl

[issue34014] loop.run_in_executor should propagate current contextvars

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: > It is a new feature for Python 3.8 anyway, no need to rush Yep, I agree. Let's see if we end up having a new nice high-level API in 3.8; if not we go for (3). -- resolution: -> postponed status: open -> pending type:

[issue34014] loop.run_in_executor should propagate current contextvars

2018-10-03 Thread Yury Selivanov
Change by Yury Selivanov : -- status: pending -> open versions: -Python 3.7 ___ Python tracker <https://bugs.python.org/issue34014> ___ ___ Python-bugs-lis

[issue34872] investigate task/future cancellation in asynciomodule.c

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: Ned, elevating this to "release blocker", see https://bugs.python.org/msg326928 Feel free to close this issue. -- priority: normal -> release blocker ___ Python tracker <https://bugs.pytho

[issue34872] investigate task/future cancellation in asynciomodule.c

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: > What's your assessment of the risk of option 2? Let's not rush it in without testing, for sure. Having 3.7.1rc2 would be great, but really up to you. -- ___ Python tracker <https://bugs.pytho

[issue34822] Simplify AST for slices

2018-10-03 Thread Yury Selivanov
Change by Yury Selivanov : -- nosy: -yselivanov ___ Python tracker <https://bugs.python.org/issue34822> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue2506] Add mechanism to disable optimizations

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: Having properly working coverage tooling is simply invaluable to pretty much every serious Python user. I support Ned's idea of adding an option to disable peephole optimizer (and similar other optimization passes). Why is this even de

[issue2506] Add mechanism to disable optimizations

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: > I would suggest -X noopt and use "noopt" in .pyc filenames. That's what I > proposed in my PEP 511. Sounds good to me. -- ___ Python tracker <https://b

[issue34888] Python3.8 optimizes away a "while" line

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: While I agree with you that we need a flag to disable optimizations, this particular change isn't related to AST or peephole optimizers. See the bpo-17611 for more details (or https://github.com/python/cpython/commit/520b7ae27e39d1c77ea74ccd1b184d7cb43

[issue34888] Python3.8 optimizes away a "while" line

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: It's more complicated than that: there's no more SETUP_LOOP opcode anymore. The ceval and compiler parts responsible for evaluating and compiling loops were rewritten. FWIW the goal was more about simplifying the needlessly complicated implemen

[issue34888] Python3.8 optimizes away a "while" line

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: > I assume there is some place that notices that the while condition is a > constant, and therefore doesn't need to be explicitly evaluated? Ah, I see what you're asking about. I'll need

[issue2506] Add mechanism to disable optimizations

2018-10-03 Thread Yury Selivanov
Change by Yury Selivanov : -- keywords: +patch pull_requests: +9080 stage: -> patch review ___ Python tracker <https://bugs.python.org/issue2506> ___ ___ Py

[issue34888] Python3.8 optimizes away a "while" line

2018-10-03 Thread Yury Selivanov
Yury Selivanov added the comment: > I assume there is some place that notices that the while condition is a > constant, and therefore doesn't need to be explicitly evaluated? To answer your question: yes, and it's unrelated to both peephole optimizer and to the above

[issue34890] Support functools.partial in inspect.is*function() checks

2018-10-04 Thread Yury Selivanov
Yury Selivanov added the comment: I think the fact that `inspect.isfunction` recognizes partials is a very strong argument to enable inspect.iscoroutinefunction to do so as well. This is a backwards incompatible change though, strictly speaking

[issue34890] Support functools.partial in inspect.is*function() checks

2018-10-04 Thread Yury Selivanov
Yury Selivanov added the comment: Feel free to work on the PR. If we want to push this to 3.8 we should do that now and have enough time for it to be tested. -- ___ Python tracker <https://bugs.python.org/issue34

[issue34776] Postponed annotations break inspection of dataclasses

2018-10-04 Thread Yury Selivanov
Yury Selivanov added the comment: > Please note that postponed annotations only reveal a problem that we already > had if anybody used a string forward reference: Yeah, makes sense. It's cool that the PR fixes string forward referenc

[issue34871] test_site fails if run after test_inspect

2018-10-04 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 70a083bc46aea84e3b3ffca2c10c295917a98fec by Yury Selivanov (Miss Islington (bot)) in branch '3.6': bpo-34871: inspect: Don't pollute sys.modules (GH-9696) (GH-9702) https://github.com/python

[issue34871] test_site fails if run after test_inspect

2018-10-04 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 476c294f260ebe1b44157a168c3dfa4a43724ce3 by Yury Selivanov (Miss Islington (bot)) in branch '3.7': bpo-34871: inspect: Don't pollute sys.modules (GH-9696) (#9701) https://github.com/python/cpython/commit/476c294f260ebe1b44157a168

[issue34871] test_site fails if run after test_inspect

2018-10-04 Thread Yury Selivanov
Yury Selivanov added the comment: Thank you Inada-san for taking care of this. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue34831] Asyncio Tutorial

2018-10-07 Thread Yury Selivanov
Yury Selivanov added the comment: > Yury, based on the file paths, you appear to be running a MacPorts python3.7. > Like many other third-party distributors (but unlike the python.org > installers), MacPorts separates Tkinter support into a separately-installable > com

[issue34795] loop.sock_recv failure because of delayed callback handling

2018-10-07 Thread Yury Selivanov
Yury Selivanov added the comment: yes -- ___ Python tracker <https://bugs.python.org/issue34795> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34872] investigate task/future cancellation in asynciomodule.c

2018-10-07 Thread Yury Selivanov
Yury Selivanov added the comment: Closing it now, Ned, thanks! I assume it will make it into 3.7.1rc2, right? -- priority: release blocker -> normal resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Py

[issue34769] _asyncgen_finalizer_hook running in wrong thread

2018-10-09 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset c880ffe7d2ce2fedb1831918c8a36e3623e0fb76 by Yury Selivanov (twisteroid ambassador) in branch 'master': bpo-34769: Thread safety for _asyncgen_finalizer_hook(). (GH-9716) https://github.com/python/cpyt

[issue34769] _asyncgen_finalizer_hook running in wrong thread

2018-10-10 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset a14dda5df62369d01db6c7519e73aae71d0e7cfe by Yury Selivanov (twisteroid ambassador) in branch '3.6': [3.6] bpo-34769: Thread safety for _asyncgen_finalizer_hook(). (GH-9716) (GH-9792) https://github.com/python/cpyt

[issue34769] _asyncgen_finalizer_hook running in wrong thread

2018-10-10 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker <https://bugs.python.or

[issue34769] _asyncgen_finalizer_hook running in wrong thread

2018-10-10 Thread Yury Selivanov
Yury Selivanov added the comment: I'll close this issue now. If you find another bug in how asyncio handles async generators please open a new one. Thanks! -- ___ Python tracker <https://bugs.python.org/is

[issue26467] Add async magic method support to unittest.mock.Mock

2018-10-10 Thread Yury Selivanov
Change by Yury Selivanov : -- nosy: +yselivanov ___ Python tracker <https://bugs.python.org/issue26467> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue32052] Provide access to buffer of asyncio.StreamReader

2018-10-12 Thread Yury Selivanov
Yury Selivanov added the comment: So we have BufferedProtocol in 3.7; now we need to re-implement asyncio streams on top of it. But even after doing that I'm not that sure we want to expose the low-level buffer. -- stage: needs

[issue34970] Protect tasks weak set manipulation in asyncio.all_tasks()

2018-10-13 Thread Yury Selivanov
Yury Selivanov added the comment: >> we could consider risking cherry-picking it to 3.7.1 final. Sound OK? > Let's wait for Yuri opinion. I agree it's a pretty serious bug; basically a time bomb that can crash a perfectly fine asyncio application. The PR itself seems to

[issue34968] loop.call_soon_threadsafe should be documented to be re-entrant-safe too

2018-10-13 Thread Yury Selivanov
Yury Selivanov added the comment: > AFAICT the stdlib's implementation of call_soon_threadsafe is already > reentrant-safe What would make it not reentrant-safe? We'll need to document that for the benefit of asyncio and third-p

[issue34975] start_tls() difficult when using asyncio.start_server()

2018-10-13 Thread Yury Selivanov
Yury Selivanov added the comment: One thing: I'm -1 on adding starttls to current stream api; let's add it only to the new one (same for sendfile) -- ___ Python tracker <https://bugs.python.o

[issue34993] asyncio.streams.FlowControlMixin should be part of the API

2018-10-15 Thread Yury Selivanov
Yury Selivanov added the comment: asvetlov: need to handle this usecase with the new API; -1 on exposing FlowControlMixin though. -- ___ Python tracker <https://bugs.python.org/issue34

[issue23554] EchoServerClientProtocol class should be called EchoServerProtocol

2018-10-15 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 43a5bd7b458f0ad2d62b00b033d025689d48d591 by Yury Selivanov (Braden Groom) in branch 'master': bpo-23554: Change echo server example class name from EchoServerClientProtocol to EchoServerProtocol (GH-9859) https://github.com/pyth

[issue23554] EchoServerClientProtocol class should be called EchoServerProtocol

2018-10-15 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <https://bugs.python.or

[issue35269] A possible segfault involving a newly-created coroutine

2018-11-17 Thread Yury Selivanov
Change by Yury Selivanov : -- nosy: +njs ___ Python tracker <https://bugs.python.org/issue35269> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue13903] New shared-keys dictionary implementation

2012-04-23 Thread Yury Selivanov
Yury Selivanov added the comment: Mark, did you add the test that your patch initially was failing with? http://mail.python.org/pipermail/python-dev/2012-February/116605.html -- ___ Python tracker <http://bugs.python.org/issue13

[issue14369] make __closure__ writable

2012-04-24 Thread Yury Selivanov
Yury Selivanov added the comment: > The patch causes crashes. Yes, that's known. First, we need to check, that we can only write tuple of cell objects or None in __closure__ (that's easy to add). Secondly, perhaps, we can check __closure__ correctness each time we start eval

[issue14660] Implement PEP 420: Implicit Namespace Packages

2012-04-25 Thread Yury Selivanov
Changes by Yury Selivanov : -- nosy: +Yury.Selivanov ___ Python tracker <http://bugs.python.org/issue14660> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue12029] Catching virtual subclasses in except clauses

2012-05-11 Thread Yury Selivanov
Changes by Yury Selivanov : -- nosy: +Yury.Selivanov ___ Python tracker <http://bugs.python.org/issue12029> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15008] PEP 362 reference implementation for 3.3

2012-06-05 Thread Yury Selivanov
New submission from Yury Selivanov : This issue will track implementation of PEP 362 functionality. -- components: Library (Lib) files: pep362.1.patch hgrepos: 131 keywords: patch messages: 162377 nosy: Yury.Selivanov, brett.cannon, larry priority: normal severity: normal status: open

[issue15008] PEP 362 reference implementation for 3.3

2012-06-05 Thread Yury Selivanov
Yury Selivanov added the comment: Well, 'Signature' class is unlikely to be used very frequently. So I think it's fine. -- ___ Python tracker <http://bugs.pyt

[issue14626] os module: use keyword-only arguments for dir_fd and nofollow to reduce function count

2012-06-06 Thread Yury Selivanov
Changes by Yury Selivanov : -- nosy: +Yury.Selivanov ___ Python tracker <http://bugs.python.org/issue14626> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15008] PEP 362 "Signature Objects" reference implementation

2012-06-13 Thread Yury Selivanov
Yury Selivanov added the comment: Attaching a patch that implements the latest version of the PEP. Quick summary: 1. Ditched Signature.name & Signature.qualname 2. Added Signature.__eq__ and __ne__ 3. signature() supports classes, metaclasses, decorated stuff, partials, methods, classmet

[issue15008] PEP 362 "Signature Objects" reference implementation

2012-06-15 Thread Yury Selivanov
Yury Selivanov added the comment: Attaching the new version of the patch. Summary: 1. 'is_*' family was replaced with 'Parameter.kind' 2. 'signature()' function was updated to check for '__wrapped__' attribute in all callables 3. 'is_imple

[issue15008] PEP 362 "Signature Objects" reference implementation

2012-06-18 Thread Yury Selivanov
Yury Selivanov added the comment: New version (pep363.4.patch) Summary: 1. Removed 'Signature.implemented' 2. No more patching built-ins - no issues with shared interpreters 3. Removed 'Signature.format()'. If needed we'll reintroduce it in 3.4 (although we still ha

[issue15008] PEP 362 "Signature Objects" reference implementation

2012-06-18 Thread Yury Selivanov
Yury Selivanov added the comment: Eric, I personally prefer simple 'signature()' more than 'get_signature()'. But I'll ask this question on python-dev on the next PEP update. -- ___ Python tracker <http:

[issue15008] PEP 362 "Signature Objects" reference implementation

2012-06-19 Thread Yury Selivanov
Yury Selivanov added the comment: New patch (pep362.5.patch) Fixed a bug in BoundArguments.args & BoundArguments.kwargs -- Added file: http://bugs.python.org/file26052/pep362.5.patch ___ Python tracker <http://bugs.python.org/iss

[issue15008] PEP 362 "Signature Objects" reference implementation

2012-06-19 Thread Yury Selivanov
Yury Selivanov added the comment: New patch (pep362.6.patch) Fixed a bug in BoundArguments.args when positional arguments were partially mapped by functools.partial -- Added file: http://bugs.python.org/file26053/pep362.6.patch ___ Python tracker

[issue15008] PEP 362 "Signature Objects" reference implementation

2012-06-19 Thread Yury Selivanov
Yury Selivanov added the comment: New patch - pep362.6.patch Ezio, I've eliminated almost all '\'. Test coverage is now almost 100%. -- Added file: http://bugs.python.org/file26055/pep362.6.patch ___ Python tracker <http

[issue15008] PEP 362 "Signature Objects" reference implementation

2012-06-21 Thread Yury Selivanov
Yury Selivanov added the comment: New patch - pep362.7.patch Summary: 1. Signature & Parameter objects are now immutable 2. Signature.replace() and Parameter.replace() 3. Signature has a new default constructor, which accepts parameters list and a return_annotation; and a new 'from

<    10   11   12   13   14   15   16   17   18   19   >