Xiang Zhang added the comment:
Cheryl, It's a good remind for me. I totally forget about this issue.
> Since Xiang is a core developer, I thought he would be in the position to
> make the decision about moving forward with the patch.
Yes, I made the decision. But seems not a wise
Xiang Zhang added the comment:
New changeset 5609b78392d59c7362ef8aa5c4a4529325f01f27 by Xiang Zhang (Cheryl
Sabella) in branch 'master':
bpo-18802: Add more details to ipaddress documentation (GH-6083)
https://github.com/python/cpython/commit/5609b78392d59c7362ef8aa5c4a452
Xiang Zhang added the comment:
New changeset 10b134a07c898c2fbc5fd3582503680a54ed80a2 by Xiang Zhang in branch
'master':
bpo-27683: Fix a regression for host() of ipaddress network objects (GH-6016)
https://github.com/python/cpython/commit/10b134a07c898c2fbc5fd358250368
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.8 -Python 3.5
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
I fixed #27683 since it looks more like an oversight and regression to me
instead of a deliberate change. I'd like the behaviour to be consistent across
versions. As for "/32", it needs discussion or some expert makes a choice.
--
resolu
Change by Xiang Zhang :
--
nosy: +serhiy.storchaka
___
Python tracker
<https://bugs.python.org/issue33113>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset d8b291a74284307610946f1b5801aa95d7f1e052 by Xiang Zhang in branch
'master':
bpo-32932: More revealing error message when non-str objects in __all__
(GH-5848)
https://github.com/python/cpython/commit/d8b291a74284307610946f1b5801aa
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
New changeset e4ce9fa89cb542dced553710b05de85202bc4715 by Xiang Zhang in branch
'master':
bpo-32943: Fix confusing error message for rot13 codec (GH-5869)
https://github.com/python/cpython/commit/e4ce9fa89cb542dced553710b05de8
Change by Xiang Zhang :
--
components: +Library (Lib)
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
versions: -Python 3.6
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
It's just the right behavior. You are modifying the list while iterating over
it. It has no business of underscore.
>>> test = ['_a', 'a', '_b', 'b']
>>> for i in test: test.remove(i)
>>>
Xiang Zhang added the comment:
You may refer to stackoverflow for an explanation, for example,
https://stackoverflow.com/questions/6260089/strange-result-when-removing-item-from-a-list
--
___
Python tracker
<https://bugs.python.org/issue33
Xiang Zhang added the comment:
I like this idea. But this is a behavior change so I think it could only be
applied to master branch. But there is a problem, except dbm.gnu and dbm.ndbm,
we also get dbm.dumb. It already raises a ValueError when deleting a key in
readonly mode. Does it need to
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +6019
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33106>
___
___
Python-
Xiang Zhang added the comment:
I highly suspect you don't have gdbm installed in your environment and `import
dbm.gnu` will fail. When simply using `dbm.open`, it searches through [dbm.gnu,
dbm.ndbm, dbm.dumb]. In my environment, macOS 10.13.3, dbm.gnu works
correctly(so dbm works corr
Xiang Zhang added the comment:
Our application also runs into this error today and this is an occasional error
that we didn't encounter before and can't reproduce currently. Although our
application uses the outdated 2.7.5 but the problem looks similar. Our
exception traceback
Xiang Zhang added the comment:
I can't reproduce the failure with 2.7.13 but I do encounter the same failure
just now, much same as yours, 2.7.5 and 2.7.13. I'd like to describe my
situation.
I have one client process started by 2.7.13(I build it from source) and one
server proce
New submission from Xiang Zhang :
Recently we update our environment from Python2.7.5 to Python2.7.13. Then one
process's CPU usage grow from 15% to 70%. The cause is
urllib.proxy_bypass_environment, the commit I wrote in #26864. Our environments
get a no_proxy environment variable
Xiang Zhang added the comment:
Okay, the real performance is:
time python2 -c 'import urllib; urllib.proxy_bypass_environment("1.1.1.1")'
real0m0.661s
user0m0.654s
sys 0m0.007s
I compile it with a wrong option with the specific GCC version. But still
real
New submission from Xiang Zhang :
While debugging a problem in my job I find an odd case about import, it could
be reduced to the following tracebacks:
>>> from keystone.assignment import schema
Traceback (most recent call last):
File "", line 1, in
File "/usr/lib
Xiang Zhang added the comment:
It's fine. Let's keep this issue open for some time before close it.
--
___
Python tracker
<https://bugs.python.o
New submission from Xiang Zhang :
I propose to mention the behaviour that "if exception raised in tracefunc or
profilefunc, the handler will be unset" in the documentation of sys.settrace
and sys.setprofile. I encounter this behaviour and surprised by it since I
can't get th
Xiang Zhang added the comment:
Is there any reason not to respond to "c_call" events in trace function?
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.o
New submission from Xiang Zhang :
I'm somewhat surprised when I have code like `"hello %s".format(person)` in my
project there is no exception raised and "hello %s" returned. Have several
tries it seems `str.format` won't check argument number.
>>> &
Xiang Zhang added the comment:
Yes, this is a breaking change. A currently working piece of code suddenly
raises an exception.
But, please note Serhiy in your example you have the same bug as me, you've
gotten an oversight bug in it: it's {:d} not %s. That's why I want t
Xiang Zhang added the comment:
I could reproduce the behavior that console output doesn't match what Python
gets. I agree with Victor this may not be a Python problem. I could also
reproduce the behavior with Ruby reading Chinese characters from console.
--
nosy: +xiang.
Xiang Zhang added the comment:
Yes, it's on MacOS. libedit and GNU deadline both have the behavior. I can see
the same behavior on Ubuntu, LANG=en_US.UTF-8.
--
___
Python tracker
<https://bugs.python.org/is
Xiang Zhang added the comment:
I modified it for the feature, not maintain it. I remember at that time I get
the feeling it's somewhat strange there are two APIs, with similar
functionality resides in two modules, need to be updated.
--
nosy: -r.david.m
Change by Xiang Zhang :
--
nosy: +r.david.murray
___
Python tracker
<https://bugs.python.org/issue33687>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
After reading PEP3101 and the archived mails, I think it's by design. Even if
not, it might be too late to change.
I don't prefer either way, emitting warnings by compiler or linter. They can't
give hints for runtime retrieved patterns, and not
Change by Xiang Zhang :
--
resolution: -> wont fix
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue32479>
___
___
New submission from Xiang Zhang :
I propose to add versionchanged note about auto-numbering feature of
string.Formatter, introduced in #13598. It's quite confusing which version
could I use the feature reading the doc. Also it's better to note in 2.7 the
feature is not available.
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +7283
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issu
Xiang Zhang added the comment:
New changeset b9d8ad5130e0f77be28a3dec6d468e6470835573 by Xiang Zhang in branch
'master':
bpo-33828: Add missing versionchanged note for string.Formatter. (GH-7668)
https://github.com/python/cpython/commit/b9d8ad5130e0f77be28a3dec6d468e
Change by Xiang Zhang :
--
pull_requests: +7288
___
Python tracker
<https://bugs.python.org/issue33828>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset fc8ea20c6f8571de96791bc5f7f2d693406024c7 by Xiang Zhang in branch
'2.7':
[2.7] bpo-33828: Clarify auto-numbering is not available to string.Formatter.
(GH-7668) (GH-7676)
https://github.com/python/cpyt
Xiang Zhang added the comment:
Thanks for the review, Eric. :-)
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: -> enhancement
versions: +Python 2.7
___
Python tracker
<https://bugs.python
Xiang Zhang added the comment:
I encounter the same failure when running test_posix suite with a debug build
Python.
[root@SZX1000328166 cpython]# ./python -m test test_posix
Run tests sequentially
0:00:00 load avg: 0.91 [1/1] test_posix
Warning -- files was modified by test_posix
Before
Xiang Zhang added the comment:
I checked glibc changelog and the copy behaviour is not implemented until 2014,
glic 2.20. There is a CVE-2014-4043. My environment has glic 2.17 which seems
still suffer the problem.
--
___
Python tracker
<ht
Xiang Zhang added the comment:
Serhiy, you need to check an early version, for example 2.17:
https://github.com/bminor/glibc/blob/glibc-2.17/posix/spawn_faction_addopen.c
--
___
Python tracker
<https://bugs.python.org/issue33
Xiang Zhang added the comment:
Sorry for the absence and late response. I just reviewed it and think it's
ready. I think the change in the unicode standard is more like a bug in the
implementation than an intentional change. It's mentioned in Unicode 3.0 the
third character is out
Change by Xiang Zhang :
--
nosy: +pitrou
___
Python tracker
<https://bugs.python.org/issue33867>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset d134809cd3764c6a634eab7bb8995e3e2eff14d5 by Xiang Zhang (Wonsup
Yoon) in branch 'master':
bpo-29456: Fix bugs in unicodedata.normalize: u1176, u11a7 and u11c3 (GH-1958)
https://github.com/python/cpyt
Change by Xiang Zhang :
--
pull_requests: +7320
___
Python tracker
<https://bugs.python.org/issue29456>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset 1889c4cbd62e200fa4cde3d6219e0aadf9bd8149 by Xiang Zhang in branch
'2.7':
bpo-29456: Fix bugs in unicodedata.normalize: u1176, u11a7 and u11c3 (GH-1958)
(GH-7704)
https://github.com/python/cpython/commit/1889c4cbd62e200fa4cde3d6219e0a
Change by Xiang Zhang :
--
components: +Library (Lib) -Unicode
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
As I said, I checked Unicode 3.0 for the hangul composition algorithm. It looks
consistent with Unicode 4.1+. 3.0 only gets description but no sample
implementation. So I think the changed code also applies to Unicode 3.0
Xiang Zhang added the comment:
Thanks for your confirmation, Ma Lin. Also thanks for Wonsup!
--
components: +Unicode -Library (Lib)
___
Python tracker
<https://bugs.python.org/issue29
Xiang Zhang added the comment:
I concur with INADA. I don't prefer to add such implementation choice in
definition. As for glossary, it may be unnecessary either but since it's
already there, I don't think it needs to be removed.
--
nos
Xiang Zhang added the comment:
Considering adding gdbm version to pythoninfo? It is possible to expose version
info from gnu dbm.
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue33
Change by Xiang Zhang :
--
pull_requests: +7405
___
Python tracker
<https://bugs.python.org/issue33717>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset b2dd5f1b667b37b5d36b39adc3a3aa6ebf59ef0b by Xiang Zhang (Miss
Islington (bot)) in branch '2.7':
bpo-33717: set terse to True when calling platform.platform in test.pythoninfo
(GH-7797) (GH-7803)
https://github.com/python/cpyt
Xiang Zhang added the comment:
New changeset 6aa283a6036f80e5820db2beae98c62745fae96f by Xiang Zhang (Miss
Islington (bot)) in branch '3.6':
bpo-33717: set terse to True when calling platform.platform in test.pythoninfo
(GH-7797) (GH-7802)
https://github.com/python/cpyt
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
type: resource usage ->
versions: -Python 3.7
___
Python tracker
<https://bugs.python
Xiang Zhang added the comment:
Hi, Jiri. Could you update your PR and let's continue with this issue?
--
versions: +Python 3.8 -Python 3.7
___
Python tracker
<https://bugs.python.org/is
Xiang Zhang added the comment:
Encounter the same problem on centos7 and git version is 1.8.3. Instead of
checking the version to use -C option, maybe we could just use --git-dir for
the same purpose?
--- a/configure
+++ b/configure
@@ -2749,9 +2749,9 @@ HAS_GIT=no-repository
fi
if test
Xiang Zhang added the comment:
I don't think here is a problem. It crashes because you preallocate the type
object in a wrong way. You should not just does a malloc and then passes it to
the API. In this way, you are able to crash many APIs. For example, malloc a
dictobject and then pa
Xiang Zhang added the comment:
This is not a bug in ntpath. Raising a TypeError is a normal behavior when
passed a wrong argument and I think the error message tells good info. You
should figure out why pipenv passes a None to os.path.join.
--
nosy: +xiang.zhang
resolution: ->
Change by Xiang Zhang :
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue33742>
___
___
Change by Xiang Zhang :
--
nosy: +christian.heimes
___
Python tracker
<https://bugs.python.org/issue33936>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
> Note: the doc doesn't say that the function must only be called once, nor
> document the (current) new Python 3.7 restriction (must only be called once):
But the doc says:
This is a no-op when called for a second time (without calling
Py
Change by Xiang Zhang :
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue33978>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
nosy: +davin, pitrou, xiang.zhang
___
Python tracker
<https://bugs.python.org/issue30256>
___
___
Python-bugs-list mailing list
Unsub
New submission from Xiang Zhang :
While reviewing PR8222, I found `err_ret->text` is assigned a not malloced
string, but it will finally get freed in `err_input`.
--
keywords: easy
messages: 321381
nosy: serhiy.storchaka, xiang.zhang
priority: normal
severity: normal
status: o
Change by Xiang Zhang :
--
title: possible free statically allocated string -> possible free statically
allocated string in compiler when easter egg on
___
Python tracker
<https://bugs.python.org/issu
Change by Xiang Zhang :
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue34084>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34132>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
One thing worth a try here maybe turn `len` to `operator.length_hint`. But I am
not sure it's a good idea and just a mention here.
--
nosy: +xiang.zhang
versions: -Python 2.7, Python 3.4, Python 3.5, Python 3.6, Pytho
Change by Xiang Zhang :
--
nosy: +davin, pitrou, xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34140>
___
___
Python-bugs-list mailing list
Unsub
Xiang Zhang added the comment:
Why accessing the result outside of with block? The pool is terminated while
exiting the block before the work is done.
--
___
Python tracker
<https://bugs.python.org/issue34
Xiang Zhang added the comment:
I'm +1 for INADA's change, but not more examples trying to distinguish every
detail difference.
--
___
Python tracker
<https://bugs.python.o
Xiang Zhang added the comment:
I could not find the specific commit you mentioned on master branch. Maybe you
are on a customized branch(what is master-dirty)?
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34
Change by Xiang Zhang :
--
resolution: rejected -> not a bug
___
Python tracker
<https://bugs.python.org/issue34310>
___
___
Python-bugs-list mailing list
Un
Xiang Zhang added the comment:
New changeset 2fc46979b8c802675ca7fd51c6f2108a305001c8 by Xiang Zhang (Sergey
Fedoseev) in branch 'master':
bpo-34151: Improve performance of some list operations (GH-8332)
https://github.com/python/cpython/commit/2fc46979b8c802675ca7fd51c6f210
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Xiang Zhang :
--
keywords: +patch
pull_requests: +8227
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue30411>
___
___
Py
Change by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue30717>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Xiang Zhang :
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34410>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset 4c8555773a801f957297132a92c0acb382d640e4 by Xiang Zhang in branch
'master':
bpo-30411: Use --git-dir instead of -C to make git work under version below
1.8.5. (GH-8744)
https://github.com/python/cpyt
Change by Xiang Zhang :
--
pull_requests: +8313
___
Python tracker
<https://bugs.python.org/issue30411>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
New changeset 95f9e14e33b713f35f5368acf7be56750bbdb5a8 by Xiang Zhang in branch
'2.7':
[2.7] bpo-30411: Use --git-dir instead of -C to make git work under version
below 1.8.5. (GH-8744) (GH-8838)
https://github.com/python/cpyt
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
It seems to me the problem is tee objects might encounter race conditions while
`PyIter_Next` in `teedataobject_getitem` releases GIL. Other threads then
might get into the same branch since `tdo->numread` haven't been updated yet.
NULL slots are g
Xiang Zhang added the comment:
Ahh, the infinite iterator could also releases GIL in `PyIter_Next`.
--
___
Python tracker
<https://bugs.python.org/issue34
New submission from Xiang Zhang :
New changeset 032e85f3fb6d2e6668d4e860b40525ed6cb8dd69 by Xiang Zhang (Zackery
Spytz) in branch '2.7':
bpo-34491: Add missing Py_DECREF() in _bsddb's DB_join() (GH-8909)
https://github.com/python/cpython/commit/032e85f3fb6d2e6668d4e860b
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Xiang Zhang :
--
nosy: +vstinner, xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34486>
___
___
Python-bugs-list mailing list
Unsub
Xiang Zhang added the comment:
So this is a dupliate of #34087 and we can close it?
--
nosy: +inada.naoki, xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34
Change by Xiang Zhang :
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue34334>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
Why not just bytes(buf[:4]) before passing?
--
nosy: +xiang.zhang
___
Python tracker
<https://bugs.python.org/issue34465>
___
___
Change by Xiang Zhang :
--
nosy: +rhettinger
___
Python tracker
<https://bugs.python.org/issue34497>
___
___
Python-bugs-list mailing list
Unsubscribe:
Xiang Zhang added the comment:
I'm afraid this could break old codes so not sure it's worth or not. I've seen
code like `SIGTERM = 15; signal.signal(SIGTERM, handler)`. I won't be surprised
to see a handcraft SIG_DFL/IGN.
--
nosy: +xiang.zhang
versions: +Py
Xiang Zhang added the comment:
I miss that. So this change seems to be user transparent and make more sense
then.
--
nosy: +vstinner
___
Python tracker
<https://bugs.python.org/issue23
Xiang Zhang added the comment:
New changeset a2eefa67542c25617a58c03a27c17fd48e2a0856 by Xiang Zhang (Alexey
Izbyshev) in branch 'master':
bpo-34503: Fix refleak in PyErr_SetObject() (GH-8934)
https://github.com/python/cpython/commit/a2eefa67542c25617a58c03a27c17fd48e2a0856
-
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Xiang Zhang added the comment:
I could. But currently I don't have a good idea how to fix it elegantly. If
anyone else makes a PR, I'm willing to review it.
--
stage: -> needs patch
versions: +Python 3.8
___
Python tr
Xiang Zhang added the comment:
New changeset 3fe89dac42809a7741d50ebf595be98833b79b97 by Xiang Zhang (Louis
Sautier) in branch 'master':
bpo-34434: Update doc for bool(), float() and int() arguments (GH-8834)
https://github.com/python/cpython/commit/3fe89dac42809a7741d50ebf595be9
Change by Xiang Zhang :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Xiang Zhang :
--
resolution: -> duplicate
stage: needs patch -> resolved
status: open -> closed
superseder: -> itertools.tee not thread-safe; can segfault interpreter when
wrapped iterator releases GIL
___
Python tra
501 - 600 of 1629 matches
Mail list logo