Todd Rovito added the comment:
Over the weekend I verified the test cases are incomplete for Python 3.4.
Inside of Lib/test/test_os.py is a class FileTests that contains a single
function test_rename which seems to only check to make sure that the reference
count for the first argument is
Todd Rovito added the comment:
While writing test cases I discovered another conflict with the documentation.
The phrase "On Unix, if dst exists and is a file, it will be replaced silently
if the user has permission and src is a file." is not correct. According to
the test cases
Changes by Todd Rovito :
Removed file: http://bugs.python.org/file27804/OSRename_test_os.patch
___
Python tracker
<http://bugs.python.org/issue16278>
___
___
Python-bug
Todd Rovito added the comment:
False alarm my test case was buggy.
--
___
Python tracker
<http://bugs.python.org/issue16278>
___
___
Python-bugs-list mailin
Todd Rovito added the comment:
Ned,
I respectfully disagree that this is not a new feature. IDLE could always
copy/cut/paste from the edit menu and it had a right click menu. All this patch
does is add options to right click menu and call the same functions as the edit
menu does. I could
Todd Rovito added the comment:
Attached is a patch for 16 test cases. All 16 test cases have been tested on
Windows 7, Mac OS X, and Linux they seem to function well. Before this patch
there was only a single test case for rename. For each test case I used
"unittest.skipUnless&quo
Todd Rovito added the comment:
Chris,
That is an excellent suggestion. I modified my OSRenameCombinations.py
program and attached. This program prints a table with the src parameters as
columns and the dst as rows. Hopefully it will show up ok in the bug tracker.
For Unix
Todd Rovito added the comment:
Here is a draft suggestion for the documentation change, not all the formatting
is worked out:
.. function:: rename(src, dst, *, src_dir_fd=None, dst_dir_fd=None)
Rename the file or directory *src* to *dst*. If *src* exists as either
a file or directory
Todd Rovito added the comment:
Attached is patch with the final formatting for the documentation updates. I
fixed the :exc:`OSError` problems that I had before and used indents to denote
Unix behavior VS Windows behavior. Please let me know if I can do anything else
to help get this issue
Changes by Todd Rovito :
Removed file: http://bugs.python.org/file27640/OSRenameTest3point4.patch
___
Python tracker
<http://bugs.python.org/issue16278>
___
___
Python-bug
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue5066>
___
___
Python-bugs-list mailing list
Unsubscribe:
Todd Rovito added the comment:
This is a good patch but it is rather out of date and won't apply. I will
patch the patch and maybe somebody can apply it this time. Expect a new patch
by 11/26/2012.
--
___
Python tracker
<http://bugs.py
Todd Rovito added the comment:
This patch is an extensive refactoring of help.txt and idle.rst. The first
thing I did was merge issue5066.patch from jesstess into the current idle.rst
file, because the original patch from jesstess was so old it had to be merged
by hand into the 3.4 source
Todd Rovito added the comment:
Version 2 of the patch change include:
-help.txt removed all tabs and replaced with spaces, as suggested by Roger
-help.txt re-inserted the section on running IDLE without a subprocess as
suggested by Roger
-Added a note on line 162 (idle.rst) about how the Python
Todd Rovito added the comment:
For version 2 of the patch
-Line 340 (idle.rst) where the Emacs bindings are rendered seemed to work fine
on my computer without the spaces but I think ezio is correct spaces should be
present so I added them
**SHOULD BE**
-Line 340 (idle.rst) where the
Todd Rovito added the comment:
A "ping" on this bug since it has not had any forward movement. Can somebody
please review and or commit? Thanks.
--
___
Python tracker
<http://bugs.python.
Todd Rovito added the comment:
Thanks much appreciated!
Sent from my iPhone
On Jan 4, 2013, at 1:07 PM, Zachary Ware wrote:
>
> Zachary Ware added the comment:
>
> Hi Todd, I can't commit, but I have a review in the works for you.
>
> --
New submission from Todd Rovito:
The Python Developer Guide in section 3.3 about the life cycle of a
patch/review process makes no mention that a bug should be "pinged" first
before posting to the python-...@python.org email list requesting a review.
For more information see this
Changes by Todd Rovito :
--
components: +Devguide -Documentation
nosy: +ezio.melotti
___
Python tracker
<http://bugs.python.org/issue16868>
___
___
Python-bug
Todd Rovito added the comment:
Here is a suggested patch with help from R. David Murray:
"To begin with, please be patient! There are many more people submitting
patches than there are people capable of reviewing your patch. Getting your
patch reviewed requires a reviewer to have the
Todd Rovito added the comment:
I agree with Meador it should be a specific amount of time. As a beginner at
contributing to Python I thought "substantial amount of time" meant one month
but it depends on interpretation. I think making it very specific makes the
documentation
Todd Rovito added the comment:
Ok I changed the time to one month...now the patch reads:
"To begin with, please be patient! There are many more people submitting
patches than there are people capable of reviewing your patch. Getting your
patch reviewed requires a reviewer to have the
Changes by Todd Rovito :
Removed file:
http://bugs.python.org/file28573/16868PythonDeveloperGuidePingIssueBeforeEmailingPython-dev.patch
___
Python tracker
<http://bugs.python.org/issue16
Changes by Todd Rovito :
Removed file:
http://bugs.python.org/file28603/16868PythonDeveloperGuidePingIssueBeforeEmailingPython-devV2.patch
___
Python tracker
<http://bugs.python.org/issue16
Todd Rovito added the comment:
Zachary,
I like your idea about joining idle.rst with help.txt but I think that
should be covered under a separate bug issue. The way I see it this bug is
about fixing the current documentation. So I suggest you open up a new issue
and get people's ta
Todd Rovito added the comment:
Zachary,
Thanks for your excellent review Your feedback was very helpful for
making the patch even better.
--
Added file:
http://bugs.python.org/file28626/5066IDLEocumentationforUnixObsoleteIncorrectVersion3.patch
Todd Rovito added the comment:
Based on Zachary's comments I have uploaded a new version of the patch which is
version 3.
--
___
Python tracker
<http://bugs.python.org/i
Todd Rovito added the comment:
Thanks Senthil but I don't deserve all the credit this issue is a team effort
with lots of help from Zach, Éric, and Ezio. All of which have improved the
patch's quality a great deal. Hopefully we can address the issues then let you
make the c
Todd Rovito added the comment:
I took all the comments and created a new patch version 4 which should address
all the issues. Thanks for the excellent review and support from everybody. I
think this patch is a much higher quality now.
--
Added file:
http://bugs.python.org/file28643
Todd Rovito added the comment:
I think getting this issue fixed makes sense, it would save time and remove
duplication.
--
___
Python tracker
<http://bugs.python.org/issue16
Todd Rovito added the comment:
Andrew,
Zachary and I worked on another issue together to sync idle.rst with
help.txt here:
http://bugs.python.org/issue5066
Issue 5066 is ready for commit if you have time by the way. Thanks!
--
___
Python
New submission from Todd Thomas:
Installing Python via Homebrew on Mac OS X has build issues if the GNU
core/find utils are set as defaults on the system. OS X is very common, on it
Homebrew is very common, via Homebrew GNU utilities are among the first
installations; EG:
http://goo.gl/OodjHI
New submission from Todd Fiala:
Hi all,
In working on the LLVM/LLDB project, I've been hitting a bug in the
embedded interpreter that causes a NULL dereference in the Python
readline module. There is a call to the history_get() function with an
assumption that it returns a non-NULL value.
Changes by Todd Fiala :
--
type: -> crash
___
Python tracker
<http://bugs.python.org/issue20631>
___
___
Python-bugs-list mailing list
Unsubscrib
Todd Rovito added the comment:
Retested this patch with the latest 3.4 and made one tiny change to get it to
apply cleanly. Please provide feedback or commit. I would like to get this
committed after more than a year since the original bug report.
--
Added file: http
Todd Rovito added the comment:
I forgot to mention this patch only works on 3.4 but if it is committed I will
work on a patch for 2.7. Thanks.
--
___
Python tracker
<http://bugs.python.org/issue16
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue6143>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue20640>
___
___
Python-bugs-list mailing list
Unsubscribe:
Todd Fiala added the comment:
Cleaned up the proposed patch a bit. Moves HIST_ENTRY* into a tighter block
and removes the second call to history_get() since the value is already stashed
in the NULL-checked local.
--
Added file:
http://bugs.python.org/file34137
Todd Whiteman added the comment:
Is this a duplicate of this already fixed issue: issue5179 ?
--
nosy: +twhitema
___
Python tracker
<http://bugs.python.org/issue3
New submission from Todd Weiler :
Now that python has an ordered dictionary it would be great to have a
display sytax for creating them.
To create a dict I just use the dict display syntax:
newdict = {'fred':'flintstone', 'barney':'rubble', 'dino&#
Todd Weiler added the comment:
Let me defend my idea a little bit.
Some people hand code their UI's, some people put them into XML UI files
then load those files.
I'd like to create them using an OrderedDict. I'm using the pyQT for a gui.
Attached is a really simple examp
Changes by Todd Whiteman :
--
nosy: +twhitema
___
Python tracker
<http://bugs.python.org/issue2057>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue8536>
___
___
Python-bugs-list mailing list
Unsubscribe:
Todd Rovito added the comment:
Russell, this is excellent work I am truly amazed that within a couple of
hours I had Python built and running for the iOS simulator this is a feat I
didn't think was possible. Perspective on me I am very familiar with Linux, C,
and Python but know
Todd Goldfinger added the comment:
This crashes reliably on Win10 with the same error message. Place cursor after
the 2 in the top spin box. Type 0.
I have the following files in Anaconda3/tcl: tcl86t.lib, tcl86tg.lib,
tclstub86.lib, tk86t.lib, tk86tg.lib, tkstub86.lib.
Python 3.6.0
Todd Goldfinger added the comment:
>> cursor after the '6' follows by '0'
The max is 21. See 'to' parameter. I don't know if my code is correct, but it
seems to work more or less. Obviously the crash is an issue with tk or Python.
--
_
Todd Rovito added the comment:
This is a gentle ping of this issue. Can somebody please review and let me
know what needs to be done to get this committed? I did test the patch on
2/12/2013 and it seems to work from the latest 3.4. Thanks
Todd Rovito added the comment:
Chris,
I first verified the issue then created some wording and you pointed out
that we needed test cases so I created a bunch of test cases. As you pointed
out "I count 2*3*2=12 possibilities to check (excluding src and dst being on
different filesy
Todd Rovito added the comment:
Chris,
Thanks for the clarification. I thought you were telling me my test cases
were dry as in dry humorI will read-up on the dry concept and see what I
can do to consolidate plus I will combine the patches. Initially I am thinking
I could collapse all
Todd Rovito added the comment:
Thanks Terry and Chris you guys have supplied great feedback. I will work on
the issue and try to get a new patch updated by end of the weekend (2/18/13).
Sent from my iPhone
On Feb 13, 2013, at 11:56 PM, "Terry J. Reedy" wrote:
>
> Terry J.
Todd Rovito added the comment:
Over the weekend I caught this terrible cold and have not been able to work on
this issue much. Hopefully I can complete by next weekend 2/25/2013 thanks for
your understanding.
--
___
Python tracker
<h
Changes by Todd Rovito :
Removed file: http://bugs.python.org/file27890/OSRename_test_os_3point4.patch
___
Python tracker
<http://bugs.python.org/issue16278>
___
___
Pytho
Changes by Todd Rovito :
Removed file: http://bugs.python.org/file28071/OSRenameDocs3point4.patch
___
Python tracker
<http://bugs.python.org/issue16278>
___
___
Python-bug
Todd Rovito added the comment:
Combined the test cases and document changes into a single patch. As suggested
by Mr. Terry Reedy I used a table and removed the text. The table still needs
some work but it is a good start. As suggested by Mr. Jerdonek I tried to make
the test cases WETter
Todd Rovito added the comment:
Ezio,
Thank you or the feedback I will continue to polish the test cases. As far
as the documentation I really like the table and find it easy to read but I
could go either way. If you read the history of this issue other Python Core
Developers asked to
Todd Rovito added the comment:
Dirk,
I think this issue is already documented as an issue but I will have to find
it in the tracker.
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue17
Todd Rovito added the comment:
Version 2 of the patch includes many improvements most of which were suggested
by Ezio making the patch a much higher quality. The patch is very WET at this
point. I still need to test on Windows which I plan to do as soon as I can get
my Windows partition in
Todd Rovito added the comment:
V3 added which includes much shorter variable names and a cleanup of the patch.
I still need to test on Windows.
--
Added file: http://bugs.python.org/file29370/16278OSRenameDocsTestV3.patch
___
Python tracker
<h
Todd Rovito added the comment:
Thanks for the feedback Vitaliy Stepanov that helped alot with the version 3
patch.
--
___
Python tracker
<http://bugs.python.org/issue16
Todd Rovito added the comment:
Made some very minor changes to get patch to work on Windows. Had issues with
line ending differences between Unix and Windows. I fixed it so line endings
won't be an issue and tested patch on Windows, Linux, and OS X.
Please feel free to supply feedba
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue2704>
___
___
Python-bugs-list mailing list
Unsubscribe:
Todd Rovito added the comment:
Made minor modifications to Roger's Terminal.py to get the extension to work
with Python 3.4. This is an excellent extension as a user can toggle it on/off
from the Options menu. The up/down arrow keys now allow a user to scroll
through history but the m
Todd Rovito added the comment:
I tested the patch on Linux CentOS 6.x and it seems to work. Now if we could
only get somebody to test on Windows?
--
___
Python tracker
<http://bugs.python.org/issue2
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue17511>
___
___
Python-bugs-list mailing list
Unsubscribe:
Todd Rovito added the comment:
No problem Roger. I have attached a new patch for documentation updates to
both the IDLE help.txt file and idle.rst for the Terminal extension. Would it
be helpful if I did a diff on the idleX Terminal.py with your original patch?
In addition to doing the
Todd Rovito added the comment:
Roger,
I took Terminal.py and copied it into Lib/idlelib for the 3.4 branch. The
extension started just fine but when I toggle it off under the options menu the
arrow keys still go through history. Basically on my Mac I see no difference
between the
Todd Rovito added the comment:
If it helps I have confirmed that this patch works great on Python 3.4 and
Python 2.7 on the Mac. The code looks very clean and provides a simple fix.
--
___
Python tracker
<http://bugs.python.org/issue17
Todd Rovito added the comment:
After looking at the code some more I realized that I didn't have my
configuration file configured correctly. The toggle was not working because I
left this out of my config-extensions.def file:
[Terminal_cfgBindings]
terminal-toggle=
Now it is working
New submission from Todd Rovito:
I think it could be very helpful to add line numbers along the left side of the
editor window. The feature could be toggled on/off easily enough. This was
mentioned in the "Invent with Python" blog about IDLE so obviously other people
would like t
Changes by Todd Rovito :
--
nosy: +roger.serwy
___
Python tracker
<http://bugs.python.org/issue17535>
___
___
Python-bugs-list mailing list
Unsubscribe:
Todd Rovito added the comment:
http://bugs.python.org/issue17535 covers issue 12 Add an option to show line
numbers along the left side of the editor window, and have it enabled by
default.
--
___
Python tracker
<http://bugs.python.org/issue13
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue13802>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue17390>
___
___
Python-bugs-list mailing list
Unsubscribe:
Todd Rovito added the comment:
I got the extension from Roger Serwy's IDLEX, it is one of my favorite
extensions. In addition to adding the extension I updated the documentation
both idle.rst and help.txt. Finally I tested the patch on Mac OS X and it
works great. This patch is for 3.
Todd Rovito added the comment:
For this patch to work correctly the option menu must be present so issue 17532
http://bugs.python.org/issue17532 has to be resolved.
--
___
Python tracker
<http://bugs.python.org/issue17
Todd Rovito added the comment:
The NCSA license is very permissive I would be surprised if the PSF didn't
accept it since both are BSD based. Needless to say I am not a lawyer and I am
not sure who to speak with about this issue.
I was able to find some precedence with the PEP 3146
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue694339>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue1207613>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Todd Rovito :
--
nosy: +roger.serwy
___
Python tracker
<http://bugs.python.org/issue13802>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue6699>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue4630>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue10079>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue14146>
___
___
Python-bugs-list mailing list
Unsubscribe:
Todd Rovito added the comment:
I was going to try Python 3.4 and TK 8.6 on Windows and see what happens.
--
___
Python tracker
<http://bugs.python.org/issue14
Todd Rovito added the comment:
I tried both TCL/TK 8.5.13 and TCL/TK 8.6 with the latest Python 3.4 on Windows
7 the editor window never showed a line as I stepped through the debugger. I
am going to try in Mac/Linux to make sure I am not crazy that a line in the
editor window does indicate
Todd Rovito added the comment:
Before I forget here are the general steps I followed to get TCL/TK 8.5.13 and
8.6 to work. For TCL/TK 8.6 I had to change the actual Visual Studio 2010
project.
Generally you have to follow the steps in readme.txt located in PCBuild of the
source tree
Todd Rovito added the comment:
I have confirmed that Linux and Mac work great but Windows fails to highlight
the current line in the editor window. Next I will try and find/file a bug
with the TCL/TK folks.
--
___
Python tracker
<h
Todd Rovito added the comment:
Here is a backtrace from PDB:
-> self.sync_source_line()
/Volumes/SecurePython3/cpython/py34/Lib/idlelib/Debugger.py(211)sync_source_line()
-> self.flist.gotofileline(filename, lineno)
/Volumes/SecurePython3/cpython/py34/Lib/idlelib/FileList
Todd Rovito added the comment:
I created a small test program trying to reproduce the problem on Windows 7,
Python 3.4, and TK 8.6. Unfortunately it works fine and each line is
highlighted as a user presses ctrl-B. I got the select code straight from
IDLE. Any other ideas Roger? This
Todd Rovito added the comment:
I think it is a great idea.
The Python documentation is written with restructured text. See the Python
Developer's Guide here:
http://docs.python.org/devguide/documenting.html
Restructured text is not difficult please let me know if you need help I
Todd Rovito added the comment:
Yes I missed the link sorry. Can you add the rst file to Doc/faq in the tip of
the repository then do a hg diff and post the patch as an attachment to this
issue? At that point I will review and send any changes or edits with the
review system. Others can
Changes by Todd Rovito :
--
nosy: +Todd.Rovito
___
Python tracker
<http://bugs.python.org/issue16887>
___
___
Python-bugs-list mailing list
Unsubscribe:
Todd Rovito added the comment:
Roger,
You are a genius! The example program duplicates the bug exactly. It
works on Mac (I assume Linux but I will test on Linux) and it does not work on
correctly on Windows. On Windows as soon as the text widget looses focus then
the hi-light
Todd Rovito added the comment:
Bug report has been filed with Tk here:
https://sourceforge.net/tracker/?func=detail&aid=3609608&group_id=12997&atid=112997
--
___
Python tracker
<http://bugs.python
Todd Rovito added the comment:
Ezio,
I left a few comments on rietveld. This is a really nice start to a great
FAQ. Thanks for your contribution I think Python needs a nice FAQ on IDLE.
You might want to add some detail about the right click menu which allows a
user to cut, copy, paste
Todd Rovito added the comment:
Roger,
I reviewed and tested the patch, it does seem to fix the "bug". Now when the
on startup configure option is selected IDLE will behave as expected. I think
this makes sense to fix the bug even though it is not documented we can infer
the beha
Todd Rovito added the comment:
I added roger.serwy to the nosy list. Terry Reedy is already on the list. I
think this issue will help maintain the IDLE documentation now and in the
future. Right now it has to manually be synced between help.txt and idle.rst.
Only Python 3.4 is synced right
Todd Rovito added the comment:
Roger,
Yes I will add another issue covering the enhancement.
Ned,
Thanks for the review. I forgot to mention it but I too tested on the Mac
:-).
--
___
Python tracker
<http://bugs.python.org/issue6
New submission from Todd Rovito:
Based on enhancements from this issue:
http://bugs.python.org/issue6698
Comments from Tal Einat
The "editor-on-startup" config option should be removed. Running IDLE without
arguments should open a shell. If IDLE is asked to open any files for ed
101 - 200 of 228 matches
Mail list logo
