Tim Peters added the comment:
Noting that in a Windows debug build, at death gc is 0xdbdbdbdb, so we are in
reading up free'd memory (0xdb is pymalloc's "dead byte" marker).
--
___
Python tracker
<http://bug
Tim Peters added the comment:
Also noting that the loop "looks funny" because it appears never to process the
first element in the input list (unless the input list contains only one
element). That is, the loop starts by processing the second element in the
list, and exits as
Tim Peters added the comment:
Ah, fudge - I think I forgot that these circular lists also have dummy heads,
in which case it's A Good Thing "the first element" is skipped, and it should
be impossible for one to become physically empty (the dummy header should
always survive
Tim Peters added the comment:
Sorry for the earlier noise. I'm fighting a flu and my head is mush :-(
Anyway, this doesn't look obvious. We get to this point:
if (Py_REFCNT(op) == 1) {
/* op will be destroyed */
gc = gc-&
Tim Golden added the comment:
Thanks, eryksun: failed experiments are still useful data for future
reference!
--
___
Python tracker
<http://bugs.python.org/issue18
Tim Golden added the comment:
Use CryptReleaseContext to release Crypt handle on Windows
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Tim Golden :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Tim Golden added the comment:
Well PyBytes_GET_SIZE is documented as returning a Py_ssize_t so I'd say it's
perfectly valid.
--
___
Python tracker
<http://bugs.python.o
Tim Golden added the comment:
To be honest I can't get excited about this one. The only sensible change is to
remove the rather specific comment about ValueError and just leave the fact
that only certain signals are valid.
Because the C code defines module-level constants on the bas
Tim Golden added the comment:
Ok, so to move this forward we have essentially two proposals:
1) Add a remove_readonly flag
2) Add a doc example which shows how to use the onerror handler to remove a
recalcitrant file.
I'm -0.5 on (1) because it feels like Windows-specific clutter; and
Tim Golden added the comment:
Fixed by issue9291
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.python
Changes by Tim Golden :
--
nosy: -tim.golden
___
Python tracker
<http://bugs.python.org/issue1528593>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tim Golden added the comment:
In thread_nt.h:EnterNonRecursiveMutex the millisecond version (here: 2148000)
of the seconds you passed in are converted to microseconds (so: 214800).
This is then passed to condvar.h:PyCOND_TIMEDWAIT which expects a long, whose
32-bit limit is 2147483647. So
Tim Golden added the comment:
Fixed in 3.4 and later; 3.3 is no longer accepting patches
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
versions: +Python 3.4 -Python 3.3
___
Python tracker
<http://bugs.python.or
Tim Golden added the comment:
Closing, as no-one's come back after my -0 for 6 months.
--
resolution: -> wont fix
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyt
Tim Golden added the comment:
Zach -- you've done most of the work on the VS projects lately. Would you mind
having a look at this one to see if it's still relevant, please?
--
nosy: +zach.ware
___
Python tracker
<http://bugs.python.o
Tim Golden added the comment:
This is essentially superseded now by the work done over on distutils-sig and
by the PyPA. (Which has included considering the differeng terminology of
installation vs other paths on Windows vs Unix).
--
resolution: -> wont fix
stage: needs pa
Tim Peters added the comment:
A bit more info: recall that, when deleting a type object (for class B), the
previous (list) object's gc_next got overwritten with NULL. The new info: its
(the list object's) gc_refs also changed from GC_TENTATIVELY_UNREACHABLE to
GC_UNTRACKED,
Tim Peters added the comment:
Attaching a marginally cleaner version of the patch, with comments.
I think it's clear this addresses _some_ real fatal problems, but they're rare:
for a problem to show up, it has to be the case that finalize() reduces the
refcount of the current o
Tim Peters added the comment:
Oh, fudge. There are other failure modes in the test suite after I took out
the seemingly redundant incref/decref pair. Adding it back in finalize3.patch.
--
Added file: http://bugs.python.org/file35167/finalize3.patch
Tim Peters added the comment:
Guido, it's best if Antoine reviewed it - he wrote the relevant PEP, and the
code I'm changing. I'm sure he'll agree it's a necessary change.
About the rarity of the bug, not only do the refcounts and cyclic structure
have to be just ri
Tim Golden added the comment:
The attached patch adds an example to the shutil documentation showing how to
use an onerror handler to reattempt the removal of a read-only file. It's
deliberately low-tech and simply removes the attribute and retries. If there's
some other obstacl
Changes by Tim Golden :
--
keywords: +patch
Added file: http://bugs.python.org/file35168/issue19643-doc.patch
___
Python tracker
<http://bugs.python.org/issue19
Tim Golden added the comment:
The attached patch uses DWORD (essentially: unsigned long) in
condvar.h:PyCOND_TIMEDWAIT.
Adding Kristjan as it was his code.
--
keywords: +patch
nosy: +kristjan.jonsson
Added file: http://bugs.python.org/file35169/issue20737.condvar.patch
Changes by Tim Golden :
--
stage: -> patch review
___
Python tracker
<http://bugs.python.org/issue20737>
___
___
Python-bugs-list mailing list
Unsubscrib
Tim Golden added the comment:
I'm at least +0.5 on this: I rather like the idea of forcing these things out
into the open.
The reason I'm not +1 is the danger of relatively benign or trivial
warnings-turned-errors getting in the way of real, possibly critical,
d
Tim Golden added the comment:
eryksun: could you essay a patch? I'd be happy to review & apply it.
--
nosy: +tim.golden
___
Python tracker
<http://bugs.python.or
Tim Golden added the comment:
Thanks, Zach. Updated patch.
--
assignee: -> tim.golden
Added file: http://bugs.python.org/file35170/issue19643-doc.2.patch
___
Python tracker
<http://bugs.python.org/issu
Tim Golden added the comment:
Thanks. I'll hold off pushing until I've had a chance to run it on a
Unix system. I'm not 100% whether it will operate in the same way there.
--
___
Python tracker
<http://bugs.pyt
Tim Golden added the comment:
Thanks for the feedback, Kristjan. You're obviously correct in that we
can't account for timeouts greater than DWORD-size milliseconds and your
proposed solution looks reasonable.
However, I'd like to close off *this* particular issue which turns
Tim Golden added the comment:
Just to be clear: the change *I'm* proposing for this issue has nothing
to do with limiting the wait, artificially or otherwise. It's simply
undoing an unintended conversion from unsigned to signed and back again,
whicih currently causes any wait of
Changes by Tim Golden :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Tim Golden added the comment:
Updated patch with unsigned long applied throughout
--
Added file: http://bugs.python.org/file35173/issue20737.condvar.2.patch
___
Python tracker
<http://bugs.python.org/issue20
Tim Peters added the comment:
Antoine, the carets are a symptom of my flu. My fingers jump on the keyboard
from sneezing and coughing, and my eyes are watery so I don't see the typos.
But I believe that can be fixed ;-)
I doubt the trashcan cruft is responsible, for several reason
Tim Peters added the comment:
OK! This has nothing to do with the trashcan mechanism.
The list object whose gc_next gets stomped on is not itself in a cycle. It's
an empty list, and just happens to be a value in a dict, which in turn is a
value in another dict. Its refcount falls to
Tim Peters added the comment:
finalize4.patch repairs the comment typos, adds a new comment, and removes the
unused `old` argument. I think the code is ready to ship with this.
I still don't have a reasonably simple fails-before-works-after test case.
But that doesn't both
Tim Peters added the comment:
xxx.py provokes a closely related death on my box, in a debug build (where
0xdbdbdbdb happened to be an invalid memory address). There are no imports so
asyncio is definitely off the hook ;-)
The code is senseless, and changing just about anything makes the
Tim Golden added the comment:
+1 for Kristjan's latest patch. And thanks for working this through, Kristjan:
I'd missed the fact that the microseconds conversion could itself overflow even
an unsigned long.
--
___
Python trac
Tim Golden added the comment:
s/Py_LONG_LONG/PY_LONG_LONG/
--
___
Python tracker
<http://bugs.python.org/issue20737>
___
___
Python-bugs-list mailing list
Unsub
Tim Golden added the comment:
What effect does your patch have on a VS2010 build? VS2010 is the official
toolset for current Python 3.x versions so any changes we make must support
that.
Also: does the same problem occur on the development branch?
(De-selecting 3.2 as it's in securit
Tim Golden added the comment:
I can confirm that the attached test.py times out after 2150 seconds (ie
30+ minutes) with your (tweaked) patch applied:
python test.py 2150
Running Debug|Win32 interpreter...
2014-05-08 10:33:53.670091
Expected to time out by 2014-05-08 11:09:43.670091
Timed Out
Tim Golden added the comment:
Attached project patch seems to build successfully on VS2010. It's possible
that this failed in some way on VS2008; AFAICT it hasn't been touched since
Brian first ported it two years ago.
Adding Zach Ware for a second opinion.
--
nosy: +zach.
Changes by Tim Peters :
--
assignee: -> tim.peters
___
Python tracker
<http://bugs.python.org/issue21435>
___
___
Python-bugs-list mailing list
Unsubscrib
Changes by Tim Peters :
--
title: Segfault with cyclic reference and asyncio.Future -> Segfault in gc with
cyclic trash
___
Python tracker
<http://bugs.python.org/issu
Tim Peters added the comment:
finalize42.patch includes a test case. If nobody objects within a few hours,
I'll commit it.
--
Added file: http://bugs.python.org/file35187/finalize42.patch
___
Python tracker
<http://bugs.python.org/is
Changes by Tim Peters :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue21435>
___
Tim Golden added the comment:
Here's a patch against build_ssl which uses subprocess.check_output and very
slightly simplifies the output. It successfully finds ActivePerl and builds
from source; and uses the svn export files when it's not.
I've targetted the development branch
Tim Golden added the comment:
I've just looked at issue21141 which is a substantial rework of this
area. This change should be incorporated over there as well / instead.
--
___
Python tracker
<http://bugs.python.org/is
Tim Golden added the comment:
I'm at least +0 on this, not because I've ever been that bothered by the Perl
messages, but because it tidies things up a little smooths the way very
slightly for people trying to build Python on Windows and I'm always ready t
Tim Golden added the comment:
Thanks for the check. Committed to 3.4 & default
--
resolution: -> fixed
___
Python tracker
<http://bugs.python.org/
Changes by Tim Golden :
--
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue10752>
___
___
Pyth
Tim Golden added the comment:
Fixed. Thanks for the report
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Tim Golden added the comment:
Builds & tests ok here on a fresh checkout (of cpython & openssl-1.0.1g)
--
nosy: +tim.golden
___
Python tracker
<http://bugs.python.org
Tim Peters added the comment:
@asvetlov, glad this fixes crashes in aiohttp library tests too, but I hadn't
heard about that before. Is there an open bug report about it on this tracker
(so we can close it)?
--
___
Python tracker
Tim Golden added the comment:
Steve -- re changes to PCBuild &c.: worth liaising with Zach Ware (and, to a
lesser extent, me) as he's been working through a number of things in that area
and I know has other ideas.
Just post a patch and nosy us both (zach.ware / tim.golden)
Obvi
Tim Peters added the comment:
+1, although it could really use a comment explaining that 2500 bytes was
chosen to be >= the Twister's 19937 internal bits of state. Otherwise it looks
as arbitrary as 32 did ;-)
--
nosy: +tim.peters
__
Tim Peters added the comment:
[neologix]
> some code spawns many processes per second (see recent
> discussion on python-dev).
But that doesn't imply they're seeding the random module many times per second,
right? Seeding isn't part of Python initialization, it's part
Tim Peters added the comment:
[haypo]
> What is an uninteresting sequence? What are the problem of these
> sequences?
A sequence that would greatly surprise a user. For example, if you generate
32-bit ints from the Twister in one obvious way, there are starting places
where you'
Tim Peters added the comment:
[haypo]
> No user complained past years.
Raymond said "We've previously had this problem with MT (since resolved, where
it is was landed in a very non-random zone)." Do you believe he was wrong?
> I don't think that we should worry so m
Tim Peters added the comment:
[pitrou]
> I still find it difficult to understand where is the said danger.
The theoretical properties that make the Twister so attractive were all proved
based on mathematical analysis of its entire period. The only way to get at
the whole period is to al
Tim Peters added the comment:
> Thanks for the explanation. It's much clearer now.
Maybe, but it's also overblown - LOL ;-) That is, no matter what the starting
seed, the user will see a microscopically tiny span of the Twister's entire
period. So all those "prova
Tim Peters added the comment:
Crytpo generators are a whole different world, and I wouldn't listen to anyone
save a bona fide expert in that field. Plausible: the "hardest thing" OpenSSL
has to do is generate secure RSA keys. But the bit length of an RSA key can't
be
Tim Peters added the comment:
I suggest this needs a measurable goal, like "minimize expected-case time" or
"minimize worst-case time". "Use a state of the art implementation" isn't a
measurable goal - it's an abstract wish with no measurable mer
Tim Peters added the comment:
The gcd function is documented as taking two integer arguments:
"Return the greatest common divisor of the integers a and b."
I'm -0 on generalizing it, and also -0 on burning cycles to enforce the
restriction to integer arguments.
Tim Peters added the comment:
@pacosta, if Mark's answer is too abstract, here's a complete session showing
that the result you got for gcd(2.7, 107.3) is in fact exactly correct:
>>> import fractions
>>> f1 = fractions.Fraction(2.7)
>>> f2 = frac
Changes by Tim Golden :
--
assignee: -> tim.golden
___
Python tracker
<http://bugs.python.org/issue21652>
___
___
Python-bugs-list mailing list
Unsubscrib
Tim Golden added the comment:
Only if you have something better to put in its place! That commit was
fixing an existing problem; perhaps not your problem, but someone's. To
revert it would simply move the pain around.
I hope to be able to work on this fairly soon. If anyone else wan
Tim Golden added the comment:
+1
--
___
Python tracker
<http://bugs.python.org/issue10136>
___
___
Python-bugs-list mailing list
Unsubscribe:
https://mail.pyth
Tim Golden added the comment:
On 02/11/2012 21:00, Andrew Svetlov wrote:
> I guess to return sh if supported, cmd.exe for Windows.
FWIW the canonical approach on Windows is to return whatever %COMSPEC%
points to.
--
nosy: +tim.golden
___
Pyt
Tim Golden added the comment:
I've got a patch for this which applies cleanly to the 3.4 tip. I still need to
sort out the Windows issues (which I don't think will be difficult; it looks
like a test issue, not a code issue)
--
assignee: -&g
Tim Golden added the comment:
I'm planning to refactor the tests and the code very slightly. When I've
got a reworked patch I'll ping it back to you to ensure it matches your
intent. IIUC you're implementing comma-separated lists {abc,def} and
nested braces {a{b,c}d,efg}
Tim Golden added the comment:
Attached is a refactored version of Mathieu's patch which, when applied to tip,
passes all tests.
--
Added file: http://bugs.python.org/file27894/0003-reworked-issue9584.patch
___
Python tracker
<http://bugs.py
Tim Golden added the comment:
Something went wrong with that patch; it doesn't include all the changes to
test_glob. I'll upload a newer patch later.
--
___
Python tracker
<http://bugs.python.
Tim Golden added the comment:
Scratch that last comment: the patch does apply. I've tested it against Windows
& Ubuntu. If no one comes in with any objections I'll commit it within the next
day.
--
___
Python tracker
<http:
Tim Golden added the comment:
Must have been something I did. I'll revert the commit and re-test.
--
___
Python tracker
<http://bugs.python.org/issue9584>
___
___
Tim Golden added the comment:
Well even in the original [working] version, the scope of this change
was limited to glob.glob. os.listdir doesn't currently support any form
of expansion (at least not on Windows) and nor does os.makedirs. I don't
see any problem in restricting this cha
Tim Golden added the comment:
Sorry, I misunderstood the point you were making with the
os.listdir/makedirs examples. Fair point about backwards compatibility.
This may make this change untenable as no-one will want a series of
use_feature_xxx flags, one for each change we introduce to glob.glob
Changes by Tim Golden :
Removed file: http://bugs.python.org/file27894/0003-reworked-issue9584.patch
___
Python tracker
<http://bugs.python.org/issue9584>
___
___
Pytho
Tim Golden added the comment:
Given that this isn't going to go ahead in its current form, and will need
wider discussion on python-dev, I'm unassigning myself and I've removed the
flawed version of the patch which I'd posted.
--
Tim Golden added the comment:
I'm sorry, but I genuinely can't see what you're trying to say here. If you
believe that there's a bug in Python's standard library, can you show a
reproducible *Python* testcase for it, please (using the pywin32 modules if
that helps) a
Changes by Tim Golden :
--
nosy: +gregory.p.smith
___
Python tracker
<http://bugs.python.org/issue16458>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tim Golden added the comment:
On 13/11/2012 20:57, Karthk Rajagopalan wrote:
> I added test case using perl and python since it was easy to
> reproduce using perl socket module and show the issue happening with
> python's subprocess.py. There is definitely an action required in
&
Tim Golden added the comment:
Start here: http://docs.python.org/devguide/
In particular: http://docs.python.org/devguide/patch.html
--
___
Python tracker
<http://bugs.python.org/issue16
Tim Golden added the comment:
Karthk, if you can run up an up-to-date patch and a test I'm willing to review
and commit it, otherwise this one will lie quiet.
--
___
Python tracker
<http://bugs.python.org/is
Tim Golden added the comment:
Not Python, but Windows. See here:
http://msdn.microsoft.com/en-gb/library/windows/desktop/aa384187%28v=vs.85%29.aspx
--
nosy: +tim.golden
___
Python tracker
<http://bugs.python.org/issue16
Tim Peters added the comment:
There's actually enormous backtracking here. Try this much shorter regexp and
you'll see much the same behavior:
re_utf8 = r'^([\x00-\x7f]+)*$'
That's the original re_utf8 with all but the first alternative removed.
Looks like passing s
Tim Peters added the comment:
Yes, if you remove the first "+", the example quickly prints None (i.e.,
reports that the regexp cannot match the string).
--
___
Python tracker
<http://bugs.python.o
Tim Golden added the comment:
Does the same problem obtain if you use os.putenv (which calls the crt
putenv under the covers)?
--
nosy: +tim.golden
___
Python tracker
<http://bugs.python.org/issue16
Tim Golden added the comment:
Sorry; late to the party. I'll try to take a look at the patches.
Basically I'm sympathetic to the problem (which seems quite
straightforwardly buggish) but I want to take a look around the issue f
Changes by Tim Cuthbertson :
--
nosy: +gfxmonk
___
Python tracker
<http://bugs.python.org/issue15112>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Tim Cuthbertson :
--
nosy: +gfxmonk
___
Python tracker
<http://bugs.python.org/issue9334>
___
___
Python-bugs-list mailing list
Unsubscribe:
Tim Golden added the comment:
This code is no longer present in subprocess.py now that issue14470 has been
applied.
--
nosy: +brian.curtin, tim.golden
resolution: -> out of date
stage: -> committed/rejected
status: open -> closed
_
Tim Golden added the comment:
Reopening because there is in fact a doc issue reamining.
--
assignee: -> tim.golden
resolution: out of date ->
stage: committed/rejected ->
status: closed -> open
___
Python tracker
<http://
Tim Golden added the comment:
I can't push from work; the (trivial) doc patch is attached. If no-one gets to
it, I'll push from home this evening.
--
Added file: http://bugs.python.org/file28688/doc.diff
___
Python tracker
<http://bu
Tim Golden added the comment:
My use case is the reloader or restarter. I've initially fallen foul of this
when using the cherrypy reloader (which does an execv by building from
sys.executable + sys.argv) but I also have web services running which I'd like
to restart remotely by fo
Tim Peters added the comment:
[Senthil Kumaran]
> I am unaware of the optimization technique you refer to as
> well, it will helpful if you could point to any resource.
It's an old trick since the very first Pythons: global lookups are
much slower than local lookups (the difference
Tim Golden added the comment:
I can confirm that 2.7.2 hard-crashes as described on Windows. I'm not
sure if I have the wherewithal to build 2.7 on this laptop to see if
it's fixed in tip.
3.3 simply raises an IOError.
--
___
Python trac
Tim Peters added the comment:
Here with 2.7.5 on Windows (Vista):
C:\Python27>python.exe
Python 2.7.5 (default, May 15 2013, 22:43:36) [MSC v.1500 32 bit (Intel)] on
win32
Type "help", "copyright", "credits" or "license" for more infor
Tim Golden added the comment:
Closing as "Works for me" in the absence of any clear proposal for docs
improvement.
--
resolution: -> works for me
stage: needs patch -> committed/rejected
status: open -> closed
___
Py
Tim Golden added the comment:
It doesn't work on Python 2.x either as delivered. Usually means you
have an external readline module installed.
--
nosy: +tim.golden
___
Python tracker
<http://bugs.python.org/is
1501 - 1600 of 2346 matches
Mail list logo