Thomas Wouters added the comment:
Eh, commit a00c3fd12d421e41b769debd7df717d17b0deed5 wasn't supposed to affect
any behaviour in release builds, just in non-debug builds *with asserts
enabled*, and only in making them build.
(There is a bug in that commit that was fixed right after, c
Thomas Wouters added the comment:
For the record, this new behaviour is wrong. It's not immediately obvious from
the ZIP spec, but offsets have to be from the start of the file, not the
archive, or ZIP64 can't work. And yes, that means you can't blindly concatenate
ZIP files
Thomas Wouters added the comment:
The spec isn't very explicit about it, yes, but it does say this:
4.4.16 relative offset of local header: (4 bytes)
This is the offset from the start of the first disk on
which this file appears, to where the local header should
be
Thomas Wouters added the comment:
... and yes, the changes to issue 26293 should be reverted; the changes
attached to this issue merely revert part of issue 26293's changes.
--
___
Python tracker
<http://bugs.python.org/is
Thomas Wouters added the comment:
Well, what should the zipfile module do when you open a broken zipfile for
appending in the first place? :) There are many ways in which it could be
broken. I don't think a zipfile with incorrect offsets should be treated any
differently.
(I don't
New submission from Kyle Thomas:
Elements other than buttons which act as buttons require metadata to be
accessible. Refer to
https://www.w3.org/TR/wai-aria-practices/examples/button/button.html
--
assignee: docs@python
components: Documentation
messages: 293056
nosy: Kyle Thomas, docs
Changes by Thomas Kluyver :
--
pull_requests: +1806
___
Python tracker
<http://bugs.python.org/issue25532>
___
___
Python-bugs-list mailing list
Unsubscribe:
Thomas Kluyver added the comment:
This was just reported in IPython as well
(https://github.com/ipython/ipython/issues/10578 ).
I've prepared a pull request based on Nick's proposal:
https://github.com/python/cpython/pull/1717
--
nosy:
Thomas Kluyver added the comment:
I could go either way on that. It's not hard to imagine it as a recursive
algorithm, and using the recursion limit provides a simple configuration escape
hatch if someone has a desperate need for something wrapped 3000 times for some
strange reason. B
Changes by Thomas Wouters :
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Changes by Thomas Wouters :
--
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.org/issue17411>
___
___
Python-bugs-list
Changes by Thomas Wouters :
--
resolution: -> out of date
___
Python tracker
<http://bugs.python.org/issue17411>
___
___
Python-bugs-list mailing list
Un
Changes by Thomas Wouters :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Thomas Wouters added the comment:
This feature would also be nice to have for Python at Google: we want builds to
be as reproducible as possible, avoid third-party libraries even when they are
available on the build system, and avoid certain extension modules in any form.
We currently delete
Changes by Thomas Wouters :
--
pull_requests: +1821
___
Python tracker
<http://bugs.python.org/issue29941>
___
___
Python-bugs-list mailing list
Unsubscribe:
Changes by Thomas Wouters :
--
pull_requests: +1829
___
Python tracker
<http://bugs.python.org/issue29941>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Thomas Stevenson:
Trying to import the socket module using the embedded distribution for 3.6.1, I
get the error: : No module named '_socket'
Running with the standard interpreter works:
Python 3.6.1 (v3.6.1:69c0db5, Mar 21 2017, 17:54:52) [MSC v.1900 32 bit (I
Thomas Stevenson added the comment:
Thank you Steve and Zachary. The context you provided helped me track it down,
so I have marked this closed. In case it benefits anyone in future as well, I
ran into a subsequent topic where the C++ app was compiled in debug and hence
the actual file
New submission from Thomas Klausner:
NetBSD recently got support for CAN. The existing Linux support for CAN
partially detects this, but then fails to build. The attached patch against
3.6.1 (from Manuel Bouyer ) fixes this problem and adds
proper NetBSD support for CAN sockets
New submission from Thomas Shinnick:
Installed using python-3.6.1-amd64.exe then tried to pip install a package.
Repeatedly had to manually intervene to open up permissions on python install
subdirs, after getting these errors one at a time from pip:
PermissionError: [WinError 5] Access is
Thomas Moreau added the comment:
This fix, while preventing the Queue to crash, does not give any way to
programatically detect that the message was dropped. This is a problem as we
can no longer assume that the Queue will not drop messages. For instance, we
can no longer detect deadlocks in
Changes by Thomas Moreau :
--
pull_requests: +2001
___
Python tracker
<http://bugs.python.org/issue30414>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Thomas Perl:
In our application that embeds a Python interpreter, we had the issue that
certain system configurations (namely, a lone "libpython27.dll" without any
standard library) caused silent failures (note that this is using Python 2.7,
but Python 3.
Thomas Perl added the comment:
Quick fix for the patch: Of course, the line with abort() needs to be removed
before this block:
+if (_fatal_error_abort_func != NULL) {
+_fatal_error_abort_func(msg);
+} else {
+abort
Thomas Moreau added the comment:
I think this is a good solution as it let the user define easily the behavior
it needs in other situation too. I would recommend adding the object
responsible for the failure to the _on_queue_thread_error callback. This would
simplify the error handling
New submission from Thomas Kluyver:
This came up in IPython & Jedi: several functions in inspect end up calling
getfile(). If the object is something for which it can't find the source file,
it throws an error, the message for which contains the object's repr.
This is prob
Thomas Kluyver added the comment:
Not exactly a bug, but I think that an improvement is possible. My plan is to
delay computing the repr until the error is formatted, so that code which
catches the TypeError can carry on safely.
I think this is more relevant for inspect than for many other
Changes by Thomas Kluyver :
--
pull_requests: +2186
___
Python tracker
<http://bugs.python.org/issue30639>
___
___
Python-bugs-list mailing list
Unsubscribe:
Thomas Kluyver added the comment:
Sure, I can do that if you want. The other thing I thought of was using
object.__repr__, so the repr always shows like .
--
___
Python tracker
<http://bugs.python.org/issue30
Thomas Kluyver added the comment:
OK, I've updated the PR to do that.
--
___
Python tracker
<http://bugs.python.org/issue30639>
___
___
Python-bugs-list m
New submission from Thomas Wouters :
There is a bug in cPickle that makes it use uninitialised memory when reading a
truncated pickle from a file (an actual C FILE*, not just any file-like
object). Using MemorySanitizer:
% ./python
Python 2.7.15 (default, redacted, redacted
Change by Thomas Wouters :
--
keywords: +patch
pull_requests: +12112
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36149>
___
___
Py
New submission from Thomas Wouters :
(good first issue, I think.)
CPython currently uses a few functions that are thread-unsafe where thread-safe
version exist, at least in glibc (crypt() and ttyname(), at least). This isn't
an issue when looking at CPython in isolation because these
Thomas Wouters added the comment:
Ah, looks like I missed crypt_r getting added in 3.7. Sorry about that. Yes,
the error handling would be a behaviour change, a keyword argument may be a
good solution. As it is, crypt() returns None, throwing away the *reason* for
the failure (which is
Thomas Wouters added the comment:
New changeset d9bf7f4198871132714cfe7d702baaa02206e9f1 by T. Wouters in branch
'2.7':
[2.7] bpo-36149 Fix potential use of uninitialized memory in cPickle (#12105)
https://github.com/python/cpython/commit/d9bf7f4198871132714cfe7d702baa
Change by Thomas Wouters :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Thomas Jollans :
The file https://www.python.org/static/files/pubkeys.txt contains some bogus
GPG keys with 32-bit key IDs identical to actual release manager key IDs. (see
below) I imagine these slipped in by accident and may have been created by
someone trying to make a
Thomas Kluyver added the comment:
As a lurker on this issue: I think a lot of energy is being expended arguing
about what is and isn't legitimate use cases, when there's actually more stuff
that people agree about than not.
I think this issue should be broken down into two, neithe
New submission from Thomas Knox :
When building Python 3.7.2 on a Raspberry Pi Zero W, it takes over 6 hours to
run test_weakref, and almost 15 hours total to run through all the tests.
14:28:14 load avg: 1.00 [396/416] test_weakset -- test_weakref passed in 6 hour
24 min
Does it really
New submission from Thomas Perl :
Using: Python 3.8 (git commit ID: d5a5a33f12b60129d57f9b423b77d2fcba506834),
the following code snippet:
=
a = {0: 0}
for i in a:
del a[i]
a[i+1] = 0
print(i)
=
Prints the following output:
=
0
1
2
3
4
=
The reason for this
New submission from Thomas Perl :
On top of issue 36452, I noticed some other corner cases that are still not
handled. For one, the patch (Github PR 12596) only handles iterating over keys,
but not iterating over values or items:
==
a = {0: 0}
it = iter(a.values())
print('Length
Change by Thomas Perl :
--
keywords: +patch
pull_requests: +12554
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36473>
___
___
Py
Change by Thomas Perl :
--
pull_requests: +12555
___
Python tracker
<https://bugs.python.org/issue36452>
___
___
Python-bugs-list mailing list
Unsubscribe:
Thomas Perl added the comment:
Repurposing this as per:
https://github.com/python/cpython/pull/12619#issuecomment-478076996
--
title: Detect all dictionary changes during iteration -> dictkeysobject: Add
maximum iteration check for .values() and .it
New submission from Thomas Buhrmann :
When the Sniffer detects more than one possible delimiter, as e.g. in the
following file
"a;b;c;d,e;f;g;h"
the result will always be the ',' delimiter, independent of how "dominant"
another delimiter is. This is because th
New submission from Thomas Grainger :
The docs for
https://docs.python.org/3/library/multiprocessing.html#multiprocessing.Queue.close
read:
> Indicate that no more data will be put on this queue by the current process.
> The background thread will quit once it has flushed all buffere
Thomas Grainger added the comment:
Should the docs be:
> Indicate that no more data will be put on or got from this queue by the
> current process. The background thread will quit once it has flushed all
> buffered data to the pipe. This is called automatically when the queue is
New submission from Thomas Moreau :
The current implementation of the semaphore_tracker creates a new process for
each children.
The easy fix would be to pass the _pid to the children but the current
mechanism to check if the semaphore_tracker is alive relies on waitpid which
cannot be used
Change by Thomas Moreau :
--
keywords: +patch
pull_requests: +12805
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36668>
___
___
Py
New submission from Thomas Kluyver :
The SystemExit exception, and consequently the sys.exit() function, take a
single parameter which is either an integer exit status for the process, or a
message to print to stderr before exiting - in which case the exit status is
implicitly 1.
In
Thomas Kluyver added the comment:
It's not obvious to me why that change to finding the source file related to
the warning should affect the format of the warning message printed. It might
be something that could be fixed in the warning module. But I don't understand
where it
Thomas Kluyver added the comment:
I'm still a bit confused why it gets escaped - as far as I know, the escaping
only happens when you repr() a string, as the displayhook does automatically:
>>> a = """ a ' single and " double quote """
&
Thomas Kluyver added the comment:
The 'single' option to compile() means it's run like at a REPL, calling
displayhook if it's an expression returning a value.
But warnings shouldn't go through the displayhook, as far as I know:
>>> from contextlib impor
Thomas Kluyver added the comment:
D'oh, yes. I missed that the failing example was displaying the captured string
through displayhook. It makes sense now. Thanks for patiently explaining. :-)
--
___
Python tracker
<https://bugs.py
New submission from Reuben Thomas :
"It is possible to defined" → "It is possible to define"
--
assignee: docs@python
components: Documentation
messages: 341419
nosy: docs@python, rrt
priority: normal
severity: normal
status: open
title: Typo in ctypes documentation
Reuben Thomas added the comment:
No, as I'm not an active Python contributor, do not aspire to be one, and don't
really want to have to learn yet another contribution system to a major project
just to fix a trivial typo. Sorry!
--
New submission from Thomas Grainger :
Currently it's quite easy for these errors to go unnoticed.
I'd like a way to easily detect these in CI.
nedbat suggested piping the process output to another tool, and looking for
'Exception ignored in:' but this
Thomas Grainger added the comment:
> this option should be used exclusively for debugging user extension modules.
I have a very large codebase that fires the odd ResourceWarning, and after
fixing them all I'd like to ensure that they do not reoccur. When using `-W
error` it still wo
Thomas Grainger added the comment:
The point for me is that CI will fail if it happens, then I can use gdb to
find out the cause
On Thu, 9 May 2019, 23:17 STINNER Victor, wrote:
>
> STINNER Victor added the comment:
>
> Ok, let me come back to the initial issue:
>
&g
Thomas Grainger added the comment:
> I'm not comfortable with forcing users to use a low-level debugger to
debug "unraisable exceptions".
Defaulting to noop when the hook fails means I'll never notice the failure
to be able to debug it
On Fri, 10 May 2019, 00:42
New submission from Thomas Moreau :
In the std lib, the semaphore_tracker and the Manager rely on daemonized
processes that are launched with server like loops. The cleaning of such
processes is made complicated by the fact that there is no cannonical way to
check that the parent process is
Change by Thomas Moreau :
--
keywords: +patch
pull_requests: +13158
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue36888>
___
___
Py
Change by Thomas Moreau :
--
pull_requests: +5025
___
Python tracker
<https://bugs.python.org/issue31310>
___
___
Python-bugs-list mailing list
Unsubscribe:
Thomas Moreau added the comment:
With this fix, the semaphore_tracker is not shared with the children anymore
and each process launches its own tracker.
I opened a PR to try to fix it. Let me know if I should open a new ticket.
--
nosy: +tomMoral
Thomas Moreau added the comment:
For new processes created with spawn or forkserver, only the
semaphore_tracker._fd is send and shared to the child. Thus, as the _pid
argument is None in the new process, it launches a new tracker if it needs to
create a new Semaphore, regardless of crashes
Thomas Moreau added the comment:
> Is it an optimization problem, or does it risk leaking semaphores?
I do not think it risks leaking semaphores as the clean-up is performed by the
process which created the Semaphore. So I would say it is more an optimization
issue.
It is true that I do
New submission from Reuben Thomas :
I have just been trying to use Valgrind (in my case, to debug code in a library
being tested via a Cython module).
It is working fine, but there seem to be some discrepancies between the
documentation in README.valgrind and valgrind-python.supp on the one
New submission from Thomas Kluyver :
Nicholas Tollervey has been getting Pynsist to use the new pythonXY._pth file
to assemble sys.path. However, I'm not clear on how this behaves with .pth
files. The docs on this
(https://docs.python.org/3/using/windows.html#finding-modules ) appe
Thomas Kluyver added the comment:
I'd reword the second sentence like this:
> Note that .pth files (without leading underscore) will be processed only if
> this file specifies ``import site``.
The current wording sounds (to me) like a guarantee that .pth files will still
be handl
Thomas Kluyver added the comment:
Thanks Steve, that looks good.
--
___
Python tracker
<https://bugs.python.org/issue32699>
___
___
Python-bugs-list mailin
New submission from Thomas Heller :
ctypes Structure fields of type c_char_p or c_wchar_p used to accept strings
with embedded null characters. I noticed that Python 3.6.4 does refuse them.
It seems this has been changed in recent version(s).
There ARE use-cases for this: The Windows-API
Thomas Wouters added the comment:
FWIW, yes, this is because zipimport doesn't support ZIP64, and doesn't even
flag it as an error when the ZIP requires it. Instead it skips files; the ZIP64
format works by setting the fields that would overflow to the maximum value as
a signal tha
New submission from Thomas Wouters :
This is a continuation, of sorts, of issue16421; adding most of that issue's
audience to the noisy list.
When importing the same extension module under multiple names that share the
same basename, Python 3 will call the extension module's ini
New submission from Thomas Nyberg :
The `_PyFrame_Init()` and `PyByteArray_Init()` functions are called in these
two locations in the `_Py_InitializeCore()` function:
https://github.com/python/cpython/blob/master/Python/pylifecycle.c#L693-L694
https://github.com/python
Change by Thomas Nyberg :
--
keywords: +patch
pull_requests: +5719
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue32980>
___
___
Py
Change by Thomas Nyberg :
--
pull_requests: +5732
___
Python tracker
<https://bugs.python.org/issue32980>
___
___
Python-bugs-list mailing list
Unsubscribe:
Thomas Nyberg added the comment:
ince I originated this issue and I think I understand the concerns, I figured I
could speed up the back and forth in this thread by opening this new PR which
removes the `_PyFrame_Init()` function. I couldn't find any `_PyFrame_Fini()`
function in the s
Thomas Wouters added the comment:
Re: Petr: we can't expect extension module authors to retroactively fix
released modules. We can't even expect everyone to fix this for future
releases; moving away from globals (which may not be specific to the Python
extension module) may b
Thomas Kluyver added the comment:
> Why not just bless the existing generate_tokens() function as a public API
We're actually using generate_tokens() from IPython - we wanted a way to
tokenize unicode strings, and although it's undocumented, it's been there for a
number of
Thomas Kluyver added the comment:
Do you know what tool created the zip file? I can't find anything in the spec
(https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT ) to say whether 0
is a valid value for the number of disks.
--
nosy: +takl
Thomas Kluyver added the comment:
I found source code for some other projects handling the same data. They all
seem to agree that it should be 1:
- Golang's zip reading code:
https://github.com/golang/go/blob/f7ac70a56604033e2b1abc921d3f0f6afc85a7b3/src/archive/zip/reader.go#L536-L538
New submission from Thomas Moreau :
The recent changes introduced by https://github.com/python/cpython/pull/3895
leaks some file descriptors (the Pipe open in _ThreadWakeup).
They should be properly closed at shutdown.
--
components: Library (Lib)
messages: 313656
nosy: tomMoral
Thomas Kluyver added the comment:
If every Windows 7 computer is generating zipfiles which are invalid in this
way, that would be a pretty strong argument for Python (and other tools) to
accept it. But if that was the case, I would also expect that there would be
many more issues about it
New submission from Thomas Moreau :
The fix for the Queue._feeder does not properly handle the size of the Queue.
This can lead to a situation where the Queue is considered as Full when it is
empty. Here is a reproducing script:
```
import multiprocessing as mp
q = mp.Queue(1)
class
Change by Thomas Moreau :
--
keywords: +patch
pull_requests: +5883
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33078>
___
___
Py
Change by Thomas Moreau :
--
pull_requests: +5929
stage: needs patch -> patch review
___
Python tracker
<https://bugs.python.org/issue33078>
___
___
Python-
Thomas Wouters added the comment:
We ran into this at work, with Python 3.6, where it involved extension types
with a reference to files, with the (open) files being deallocated during
interpreter exit and raising ResourceWarnings because of that. I tried to
create a simple reproducer and
Change by Thomas Wouters :
--
keywords: +patch
pull_requests: +6211
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue26153>
___
___
Py
Thomas Wouters added the comment:
Looks like this was fixed in 3.7 by checking
PyThreadState_GET()->interp->modules before trying to use it. That leaves the
crash in 3.6 and earlier, though.
--
stage: patch review ->
___
Python tracke
Change by Thomas Wouters :
--
pull_requests: +6213
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue26153>
___
___
Python-bugs-list mai
Change by Thomas Wouters :
--
pull_requests: +6231
___
Python tracker
<https://bugs.python.org/issue32591>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Thomas Wouters :
--
pull_requests: +6232
___
Python tracker
<https://bugs.python.org/issue26153>
___
___
Python-bugs-list mailing list
Unsubscribe:
Thomas Kluyver added the comment:
Time for some bug archaeology!
The reason given for not using frame.f_code.co_filename for warnings was that
it can be wrong when the path of .pyc files changes. However, it looks like
that was fixed in #1180193 (thanks for the pointer zseil), so I'd
New submission from Thomas Kluyver :
The warnings module tries to find and show the line of code which is
responsible for a warning, for the same reasons that tracebacks show a line of
code from each stack frame. However, they work in quite different ways.
Native tracebacks, the traceback
Thomas Kluyver added the comment:
Thanks Guido, the new issue is #33375.
--
___
Python tracker
<https://bugs.python.org/issue1692664>
___
___
Python-bugs-list m
Change by Thomas Kluyver :
--
keywords: +patch
pull_requests: +6318
stage: -> patch review
___
Python tracker
<https://bugs.python.org/issue33375>
___
___
Py
Change by Thomas Klausner :
--
nosy: +wiz
___
Python tracker
<https://bugs.python.org/issue33384>
___
___
Python-bugs-list mailing list
Unsubscribe:
Thomas Kluyver added the comment:
Hi Brett! If you get a moment, any review of the linked PR would be welcome. :-)
https://github.com/python/cpython/pull/6622
--
___
Python tracker
<https://bugs.python.org/issue33
Thomas Kluyver added the comment:
Thanks! No rush, I just thought I'd take the opportunity when you added
yourself to the nosy list.
--
___
Python tracker
<https://bugs.python.org/is
New submission from Thomas Kriechbaumer :
ipaddress.IPv4Address and ipaddress.IPv6Address provide a is_private function
that indicates if the address (or network) is part of a "private" IP range, as
designated by the IANA special-use registry.
The current documentation is
1001 - 1100 of 1791 matches
Mail list logo
