New submission from Steve Dower :
The change to error handling did not include ERROR_CANT_ACCESS_FILE, but this
error occurs in the Store package install.
After suppressing this error, it then occurs again when stripping the prefix -
we should just check for the same error here to determine
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16139
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16551
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I know what this is - in issue38133 I added support for the PEP 514
ExecutablePath key, but didn't add a check for WindowedExecutablePath for the
pyw.exe case.
I'll add it.
--
assignee: -> steve.dower
keywords: +3.8regression
versions
Change by Steve Dower :
--
nosy: +lukasz.langa
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue38359>
___
___
Python-
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16152
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16561
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 353fb1ecbfd58752dabae115c4964095e1e35e5f by Steve Dower in branch
'master':
bpo-38359: Ensures pyw.exe launcher reads correct registry key (GH-16561)
https://github.com/python/cpython/commit/353fb1ecbfd58752dabae115c49640
Steve Dower added the comment:
New changeset a0e3d27e4e3cb5b67e325df080fb18b70c2910cf by Steve Dower in branch
'master':
bpo-38355: Fix ntpath.realpath failing on sys.executable (GH-16551)
https://github.com/python/cpython/commit/a0e3d27e4e3cb5b67e325df080fb18
Steve Dower added the comment:
This is resolved as far as I'm concerned - leaving open for Łukasz to
cherrypick and close.
--
stage: patch review -> backport needed
___
Python tracker
<https://bugs.python.org
Steve Dower added the comment:
This is resolved as far as I'm concerned - leaving open for Łukasz to
cherrypick and close.
--
stage: patch review -> backport needed
___
Python tracker
<https://bugs.python.org
Steve Dower added the comment:
This doesn't apply since Python 3.5, as the HAVE_SXS preprocessor variable is
not defined.
We should just delete this code entirely in 3.9, and patch the message in 2.7.
--
versions: -Python 3.7, Python 3.8, Pytho
Steve Dower added the comment:
Also crashes on Windows (x64 and x86), and on 3.7.5rc1, so this is likely in
our code.
--
nosy: +ned.deily, steve.dower
priority: normal -> release blocker
stage: -> test needed
versions: +Python 3.7
___
Steve Dower added the comment:
I get this assertion in a debug build:
Assertion failed: actual_type_index <= MAX_ELEMENTS, file
c:\projects\cpython\modules\_ctypes\stgdict.c, line 718
--
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Increasing MAX_ELEMENTS fixes it, but I'm not sure what other impacts there are
from doing that.
+Vinay who added the array handling that's hitting the limit.
--
nosy: +vinay.sajip
versions: +Python 3.9
Steve Dower added the comment:
Given this limit can easily be hit by user code, I'd like to see it turned into
a proper check with an exception (or a dynamic array) rather than just an
assertion. We should not segfault here.
while (length > 0) {
actual_types[actual_ty
Steve Dower added the comment:
Adding email team here, since you were pinged on the PR.
PR 16567 doesn't fix the `inited` member, which is considerably more difficult
to do, unfortunately, but it does mean that it's out of sync with the values
you hold. Arguably this is a better s
Steve Dower added the comment:
New changeset e310af9e2941c2fbb7370e003276cc37eb230f16 by Steve Dower (James
Abel) in branch 'master':
bpo-38344: Fix syntax in activate.bat (GH-16533)
https://github.com/python/cpython/commit/e310af9e2941c2fbb7370e003276cc
Steve Dower added the comment:
I've merged the fix so that it can be cherry-picked for the upcoming releases.
I'd still like to see the tests enhanced to be able to detect error output in
the scripts, but those don't need to necessarily make it into the upc
New submission from Steve Dower :
The iconUrl field has to be replaced with an icon field, and we need to include
the file in the package now.
Details at https://docs.microsoft.com/en-us/nuget/reference/nuspec#icon
--
assignee: steve.dower
components: Windows
messages: 354167
nosy
Steve Dower added the comment:
You're right, they need either your patch or PyErr_WriteUnraisable(NULL) before
returning.
Łukasz - this needs a fix in 3.8, but we don't have to necessarily change the
(internal, but exposed) ABI. For 3.9, we'll fix it properly, but for 3.8 I&#
New submission from Steve Dower :
It's documented as "os.system" but implemented as just "system".
--
assignee: steve.dower
messages: 354245
nosy: lukasz.langa, steve.dower
priority: normal
severity: normal
status: open
title: Audit event for os.system is incor
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16251
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16670
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I think you're right about that change touching the right code, but I'm pretty
sure it wasn't working before either. (Python 2.7 had totally different code,
IIRC.)
But the good news is that we should be able to use code similar to wha
New submission from Steve Dower :
The sys.addaudithook raises an audit event 'sys.addaudithook'.
The docs for the function refer to the event, as it has slightly different
semantics than most, but it is not named explicitly and does not appear in the
table of events.
-
New submission from Steve Dower :
Because the abspath() call is deferred until the end of the resolution process,
if the current working directory is not already a real path, it will not be
fully resolved.
By passing it through abspath() at the start of the function, we ensure that
the
Steve Dower added the comment:
Updating change_cwd() in Lib/test/support/__init__.py to call
chdir(realpath(path)) also fixes the test issues I was facing, but the
realpath() implementation needs fixing.
--
___
Python tracker
<ht
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16301
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16723
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
PR 16723 is just for the test fix.
The realpath() fix should get tests that chdir (without change_cwd()) into a
symlink and then realpath() on a relative path. Today, that should fail to
resolve the sections in the CWD, and with the fix it should resolve the
Steve Dower added the comment:
In that case, the fix for 3.8 should be to call PyErr_WriteUnraisable(NULL)
when an error occurs. This will report it through the new unraisable hook, and
also prevent a fatal error if the exception escapes.
--
versions: +Python 3.8
Steve Dower added the comment:
New changeset d83fc2702951f56a7339aa95d62414ed6e0fb40d by Steve Dower in branch
'master':
bpo-38453: Resolve test directories before chdir to them (GH-16723)
https://github.com/python/cpython/commit/d83fc2702951f56a7339aa95d62414
Steve Dower added the comment:
I'm okay with skipping the failing test if we detect
sys.getwindowsversion().major < 10
Windows 7 is not supported for Python 3.9, so this buildbot can be
disabled/upgraded.
Windows 8.1 will be supported for at least 3.9, so we'll have to keep
Steve Dower added the comment:
But I'm okay to defer it - this is still going to be obscure functionality for
the time being, and it's possible to avoid the issue.
--
priority: release blocker -> deferred blocker
___
Python tr
Change by Steve Dower :
--
title: ntpath.realpath() should make absolute path earlier -> ntpath.realpath()
does not fully resolve relative paths
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
pull_requests: +16351
pull_request: https://github.com/python/cpython/pull/16791
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
New changeset 4d202281c128e2026e78fc5f4cc752b1dafbf3ad by Steve Dower in branch
'master':
bpo-38133: Update docs to reflect fixes to py.exe launcher (GH-16791)
https://github.com/python/cpython/commit/4d202281c128e2026e78fc5f4cc752
Steve Dower added the comment:
I know what this is - the fix that went into the console executable didn't make
it into the windowed executable.
--
assignee: -> steve.dower
versions: +Python 3.9
___
Python tracker
<https://bugs
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16374
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16824
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 7aebbd1182bc818324656b2fb764679faf51fdff by Steve Dower in branch
'master':
bpo-38492: Remove pythonw.exe dependency on the Microsoft C++ runtime (GH-16824)
https://github.com/python/cpython/commit/7aebbd1182bc818324656b2fb76467
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
You're right that this will need fixing. But we don't really have to fix it any
earlier than 3.10 - the launcher is backwards-compatible but not necessarily
forwards-compatible. Still, we can take a fix whenever.
Probably it should just chang
Steve Dower added the comment:
If you just want to be able to import modules from the venv, and you know the
path to it, it's simpler to just do:
import sys
sys.path.append(r"path to venv\Lib\site-packages")
Updating sys.executable is only necessary if you're go
Steve Dower added the comment:
> Why this ABI is exported at all?
Great question for (probably) Yury, but it is exported and so we're stuck with
it for 3.8 at least :(
--
___
Python tracker
<https://bugs.python.org
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Steve Dower :
The include/internal directory is not being included in the packages published
to nuget.org or the Microsoft Store.
This prevents some advanced users from being able to compile against these
packages.
--
assignee: steve.dower
components: Windows
Steve Dower added the comment:
If someone wants to fix this before I do, the change goes in PC/layout/main.py
to remove the filter for directories named "internal" - we shouldn't need a
filter there at all now that we include everythin
Steve Dower added the comment:
Strange, I definitely cleaned up the externals before building 2.7.17rc1, so
not sure how it ended up with the previous one.
I'll double-check later today on my build machine, but there shouldn't have to
be any code changes to deal
Steve Dower added the comment:
Confirmed that it was a failed clean/rebuild on my build machine. The current
build for 2.7.17 has the newer version.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracke
Steve Dower added the comment:
Bumping this - it's bitten me a couple of times as one of the build/release
scripts relies on Path.glob().
--
versions: +Python 3.9 -Python 3.6
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Can you try installing https://aka.ms/vs/16/release/VC_redist.x64.exe and then
see if it makes a difference?
At least one package in 3.8 still contained a dependency on the C++ runtime,
which we do not include, and it's possible that 3.7.5 had the same
Steve Dower added the comment:
> in what's new and the installer, you've referenced KB2533625 instead of
> KB2533623. Do we have to open a new issue for this minor search and replace
> fix?
The new issue is opened now, so we can attach a PR to this one.
Contributions w
Change by Steve Dower :
--
keywords: +easy, newcomer friendly
___
Python tracker
<https://bugs.python.org/issue38534>
___
___
Python-bugs-list mailing list
Unsub
Steve Dower added the comment:
Exactly where were the DLLs installed?
If you had previously done "just for me" and then this time did "all users",
the python27.dll for 2.7.17 will be in C:\Windows\SysWow64, which has lower
priority than the one in the same directory.
Steve Dower added the comment:
New changeset 009a6928727b23344613ab6a9a52b9da56ab905c by Steve Dower (Zackery
Spytz) in branch '2.7':
bpo-37025: AddRefActCtx() shouldn't be checked for failure (GH-16897)
https://github.com/python/cpython/commit/009a6928727b23344613ab6a9
Steve Dower added the comment:
Merged the 2.7 fix. Let's just delete the whole block in master.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Yep
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
You're right, the logic to actually launch _base_executable is in there twice
now, and the second one (that never gets used) is more important.
--
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
The import audit event is also not documented.
--
___
Python tracker
<https://bugs.python.org/issue38434>
___
___
Python-bug
Steve Dower added the comment:
I agree this would be better, though it may not be that easy to do.
If you're running Windows Python from WSL, then your "bash style" path should
be "/mnt/c/some/path", not "/c/some/path". So the answer isn't as simple as
Steve Dower added the comment:
> FWIW, the very first thing that I checked was the dependencies of pythonw.exe
The version in the Store has a different build of pythonw.exe (because it has
to be able to determine its user site-packages location differently).
Dump of file C:\Program
Fi
Steve Dower added the comment:
If you look in your %TEMP% directory, you'll find a set of log files from your
Python install (maybe sort by date).
One of these will end in "doc". Could you share that file?
--
___
Python
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16461
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16932
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 894e30ce0bcc1c509eb01c8ffa9ba6d7701aeaaf by Steve Dower in branch
'master':
bpo-38434: Fixes some audit event documentation (GH-16932)
https://github.com/python/cpython/commit/894e30ce0bcc1c509eb01c8ffa9ba6
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset edb172a87296d9359593a23cd9a09f5867ea1f0e by Steve Dower (Zackery
Spytz) in branch 'master':
bpo-38519: Internal include files missing on Windows (GH-16921)
https://github.com/python/cpython/commit/edb172a87296d9359593a23cd9a09f
Change by Steve Dower :
--
pull_requests: +16494
pull_request: https://github.com/python/cpython/pull/16967
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
PR 16967 should fix the relative path resolution property, by joining with cwd
if the original path is unprefixed and not absolute, and then joining with any
symlink directories if their link is not absolute
Steve Dower added the comment:
I also had to special-case "realpath('nul')" to maintain the behaviour that we
deliberately maintained in another bug, and I think isabs() should always
return true for "\\?\" prefixed paths (given that join() will promote a &qu
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16495
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16968
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Thanks. Turns out it's a typo that's been around forever, but is really not
obvious until you install Windows somewhere other than C:\Windows.
Apparently that's far less common than it used to be :)
We'll get it fixed in the ne
Steve Dower added the comment:
There is an implicit cap due to the C runtime (specifically vcruntime140.dll)
allocating fibre local storage on load, which seems like the one you are
hitting. However, we discovered this before the first 3.5 release and fixed it.
How are you compiling your
Steve Dower added the comment:
New changeset 794616f837c254c68d8384ab48fb78123a3c8a8b by Steve Dower
(benedwards14) in branch 'master':
bpo-38534: Replace wrong KB number references (GH-16955)
https://github.com/python/cpython/commit/794616f837c254c68d8384ab48fb78
Steve Dower added the comment:
Thanks for the fix!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
New changeset 0ac6137dd3d1e2c8f9558153ad63021f57e05e73 by Steve Dower in branch
'master':
bpo-38589: Fixes HTML Help shortcut when Windows is not installed to C drive
(GH-16968)
https://github.com/python/cpython/commit/0ac6137dd3d1e2c8f9558153ad6302
Change by Steve Dower :
--
assignee: -> steve.dower
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
The discussion on the PR has raised one scenario where our algorithm conflicts
with what we can reasonably emulate from the IO manager (which is itself not
entirely self-consistent):
If you call ntpath.realpath(r"C:\spam\eggs") where "spa
Steve Dower added the comment:
Reawakening this issue so we can finish it off - the stable ABI has been
declared "clean" on python-dev, so there shouldn't be any more concerns about
APIs leaking in now. We can assume that everything accessible from the header
files should
Steve Dower added the comment:
I've emailed some colleagues to see what they can add here.
Ultimately, the Windows CRT is just doing arithmetic, since POSIX time formats
do not resemble Windows time formats at all, so it's all emulation. So if we
replaced it with our own calculati
Steve Dower added the comment:
When you say minor version, I assume you mean 3.x vs 3.y versions.
These already install separately and should not upgrade each other. If you
think they are, could you provide some more information about what you are
seeing
Steve Dower added the comment:
We can, and we probably should, but it's not a high priority.
Technically the download page is correct, but updating it to specify Windows
Vista as the 3.8 cutoff (and for 3.9, Windows 8.1) won't hurt.
--
stage: -> needs pa
Steve Dower added the comment:
To change the install location to Program Files, you should select the "Install
for All Users" option at the top of the page where you modified the install
location. This will cause the installer to elevate.
Generic access errors should not trigger
Steve Dower added the comment:
Passing a tuple as "O" just means it gets passed as-is, without wrapping it
again. And yeah, I thought that was right here, but it's not. I didn't realise
it's a varargs argument. So yeah, it should be wrapped again so that only a
Steve Dower added the comment:
If someone offers a patch for replacing the list of per-interpreter hooks with
something not easily discoverable via gc, I'm sure we'd take it. It's all
internal, so just hiding it from the list of bases should be fine (there should
never b
Steve Dower added the comment:
Leaving the launcher behind is deliberate. Otherwise you might
install/uninstall 3.10 alpha and lose the launcher completely.
I can't trivially reproduce the ARP issue, so we'll need some more information.
If possible, can you grab the install logs
Steve Dower added the comment:
This was caused by the UCRT not installing properly. These days, the UCRT is
installed app-local for Win 8.1, and is already present on Win 10, so it can't
happen anymore.
--
resolution: -> fixed
stage: -> resolved
status: ope
Steve Dower added the comment:
The UCRT can no longer fail to install - we do an app-local install on Win 8.1,
and it's already present on Win 10.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python t
Steve Dower added the comment:
The link appears to be in the Resolution header of PEP 632?
But yes, your analysis is correct. If/when we move distutils elsewhere, we'll
probably have to update all of these sections.
Ideally we'd have a helper function to do the initial "i
Steve Dower added the comment:
Nothing has changed in platform, and all current releases return the same
version number for me (which matches the original report).
As I said, we need to find a versioned DLL that _always_ rebuilds to extract
the version number from, because that's the
Steve Dower added the comment:
Yeah, that all makes sense. 90%+ of the time, checking the version number is a
compatibility issue waiting to happen.
For the other 10% (diagnostic logging), it would be nice to have a better
option than running "cmd /c ver", but that might be t
Steve Dower added the comment:
CMD is not going to be subjected to compatibility shims that hide the version
number, and I *think* those are not inherited by child processes. So it can use
the basic APIs. (It's also likely to be the comparison that most people will
check against.)
I
Steve Dower added the comment:
Given that extra info, I'd say we're fine to document that our timeouts can't
do any better than the OS, which "for example, is typically around 15ms on
Windows", and recommend using n
Steve Dower added the comment:
Just wanted to add that the sooner we can offer a wrapper around CopyFileEx on
Windows (with no callbacks), the sooner we can take advantage of some
significant optimisations that are being done to this function (which I can't
share details of right now
Steve Dower added the comment:
Eryk is correct, the displayed version number is the one that determines
whether to update existing files or not, and the fourth field is (IIUC) not
used for this by WiX (our installer technology). We also cannot override the
displayed version using this
Steve Dower added the comment:
Unfortunately not, because we don't know where it will be installed to, and
that executable embeds the full path to its matching python.exe.
I suggest running "python.exe -m pip" instead.
--
___
Steve Dower added the comment:
FWIW, the installer change was only to forcibly warn naive users that they need
to stick with the previous version, so I wouldn't read much into it. It's
easily rolled back.
The real issue is that we need to decide how to drop support _somehow_, and
Steve Dower added the comment:
> not sure about the strategies here but maybe a better approach would be to
> kill support for unsupported version of windows in a major release
We do, but the "major" release is the second field of the version number (you
can think of the fi
Steve Dower added the comment:
> nt.spawnv[e](), nt.waitpid(), and nt.system() could also be implemented with
> subprocess.
I like the idea, but we shouldn't invert the dependencies like that. nt/os is a
lower-level library, and should provide its own implementation (t
Change by Steve Dower :
--
nosy: +anthonypjshaw, gvanrossum, lys.nikolaou, pablogsal
___
Python tracker
<https://bugs.python.org/issue43567>
___
___
Python-bug
Steve Dower added the comment:
The main motivator for the redirector was to support the Store package, which
can only be *executed* from outside its container (we can't load the DLL
directly). Given we want the two distributions to be interchangeable from a
code POV, it made the most
Steve Dower added the comment:
The main problem with adding Python to PATH is interfering with other
application's DLL and executable resolution order, as well as the inevitable
confusion when multiple PATH updates do not play well together (which they
don't).
The best thing
Steve Dower added the comment:
Assume it'll be the next scheduled release (though I haven't looked at the
details of the vulnerabilities yet, so we may decide that they're more urgent
for CPython users).
I'm starting the Windows build process now, but that only gets us f
Steve Dower added the comment:
I published the Windows OpenSSL builds and retriggered your PR builds,
Christian.
It looks like we should probably bring up the next release for this, if only
because that will cause server users to do rebuilds/updates that they may
otherwise not. I doubt
601 - 700 of 5794 matches
Mail list logo
