Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue36315>
___
___
Change by Steve Dower :
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> out of date
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Change by Steve Dower :
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.o
Change by Steve Dower :
--
resolution: -> out of date
stage: needs patch -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/
Steve Dower added the comment:
As of 3.8, it (sort of) does.
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue35898>
___
___
Change by Steve Dower :
--
resolution: -> out of date
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
We can fix this - trailing dots before an extension are supported.
Probably the best fix is to defer the "abspath" call until after the extension
has been added (or apply "abspath" to the directory and then put the base name
back on).
Change by Steve Dower :
--
keywords: +patch
pull_requests: +15584
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15949
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
pull_requests: +15586
pull_request: https://github.com/python/cpython/pull/15951
___
Python tracker
<https://bugs.python.org/issue32
Change by Steve Dower :
--
versions: +Python 3.9 -Python 3.7
___
Python tracker
<https://bugs.python.org/issue33166>
___
___
Python-bugs-list mailing list
Unsub
Steve Dower added the comment:
I'll at least make a start by updating the minimum API version.
--
title: Drop support of Windows Vista in Python 3.8 -> Drop support of Windows
Vista and 7 in Python 3.9
versions: +Python 3.9 -Python 3.8
__
New submission from Steve Dower :
The pip.ini intended for store packages is being included in the nuget package.
We should not do that.
--
assignee: steve.dower
components: Windows
keywords: 3.8regression
messages: 351900
nosy: paul.moore, steve.dower, tim.golden, zach.ware
priority
Change by Steve Dower :
--
keywords: +patch
pull_requests: +15597
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/15964
___
Python tracker
<https://bugs.python.org/issu
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
resolution: -> out of date
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue35592>
___
___
Steve Dower added the comment:
Have we seen this recently? Should we just close this?
--
___
Python tracker
<https://bugs.python.org/issue35795>
___
___
Pytho
Steve Dower added the comment:
I don't remember exactly when, but this is fixed.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.pyth
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
assignee: steve.dower ->
stage: resolved -> needs patch
versions: +Python 3.9
___
Python tracker
<https://bugs.python.org/i
New submission from Steve Dower :
The py.exe launcher cannot locate installations from the Store (unless you have
no other installations on your machine, which is unlikely).
--
assignee: steve.dower
components: Windows
messages: 352107
nosy: paul.moore, steve.dower, tim.golden
Change by Steve Dower :
--
keywords: +patch
pull_requests: +15648
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16025
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
For clarity, given Eryk's examples above, both "\\?\UNC\" and "//?/UNC/" are
okay (as are any combination of forward and backslashes in the prefix, as
normalization will be applied for any except the "\\?\" versio
Steve Dower added the comment:
I added an "exe_display" override for listing paths, since the full path to the
store app is not supposed to be used by users (it's different from
sys.executable) and is only going to work when the shorter name is on PATH
anyway (due to a limita
Steve Dower added the comment:
Sample output after this change (some paths elided):
Installed Pythons found by ...\py.exe Launcher for Windows
(venv) C:\...\env\Scripts\python.exe *
-3.8-64python3.8.exe
-3.7-32-32 C:\Python37_x86\python.exe
-3.7-64C
Steve Dower added the comment:
Ah, good catch, I didn't notice that.
Because those are special cases, we should strip it off the version string. One
day when we implement PEP 514 properly then they'll come back (and we'll
probably drop the -64 suffix for consisten
Steve Dower added the comment:
New changeset ed93a8852d120c5a3606720edc723bf5aa6a1fc2 by Steve Dower in branch
'master':
bpo-38133: Allow py.exe launcher to locate installations from the Microsoft
Store (GH-16025)
https://github.com/python/cpyt
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
nosy: +xtreak
___
Python tracker
<https://bugs.python.org/issue38149>
___
___
Python-bugs-list mailing list
Unsubscribe:
Steve Dower added the comment:
Provided it's called with different arguments each time (which it is), there
isn't a problem here. Audit hooks are supposed to be informative, not
definitive (that is, you almost always need to take the surrounding context
into consideration, which i
Steve Dower added the comment:
> when added sys.audit() for glob.glob(), should not it be added for
> Path.glob() too? And for os.walk()?
Sure, those would make sense.
They all go via scandir() which has its own event too (and will do for each
directory), but being able to see that i
Change by Steve Dower :
--
components: +Windows
nosy: +paul.moore, steve.dower, tim.golden, zach.ware
versions: +Python 3.8, Python 3.9
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
Thanks Spandan
This doesn't reproduce trivially for me, so I suspect there is some difference
in the venv.
Could you run "pip list" in both the venv and with it deactivated and share the
output? There are some packages that modify how cons
Change by Steve Dower :
--
pull_requests: +15718
pull_request: https://github.com/python/cpython/pull/16098
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
I posted a second PR with the rest of the change, as it'd be good to get this
in before the next 3.8 release.
--
versions: -Python 3.7
___
Python tracker
<https://bugs.python.org/is
Steve Dower added the comment:
Thanks for the report and partial patch!
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Steve Dower :
--
pull_requests: +15766
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16156
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I added another PR with the additional error codes listed by Eryk Sun.
Theoretically we should be able to test most of them, but I haven't written
those tests, and I'm not sure they'd prove enough to be worth the extra code.
ntpath.realpath is
Change by Steve Dower :
--
pull_requests: +15788
pull_request: https://github.com/python/cpython/pull/16178
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
I've published the sources and binaries for Windows - will get to updating the
3.9/3.8/3.7 branches later today unless someone else does first (should just
require version number changes).
--
___
Python tr
Steve Dower added the comment:
New changeset d8903416d223d01e23dfa8bffe48b1428d90d202 by Steve Dower in branch
'2.7':
bpo-38117: Updates bundled OpenSSL to 1.0.2t (GH-16178)
https://github.com/python/cpython/commit/d8903416d223d01e23dfa8bffe48b1
New submission from Steve Dower :
There remains a case in ntpath.realpath() where a (handled) ERROR_ACCESS_DENIED
or ERROR_SHARING_VIOLATION will break out of traversing a series of paths.
However, in this case (in os.stat(), for example), we could request the real
name of the file from the
Steve Dower added the comment:
See issue38081 and PR 16156 for related discussion and changes.
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Steve Dower :
--
pull_requests: +15792
pull_request: https://github.com/python/cpython/pull/16184
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
New changeset 3ab73f6bbf4ff66e7ace3c4eab25461b5c7d71d4 by Steve Dower in branch
'master':
bpo-38117: Update bundled Windows OpenSSL to 1.1.1d (GH-16184)
https://github.com/python/cpython/commit/3ab73f6bbf4ff66e7ace3c4eab2546
Change by Steve Dower :
--
pull_requests: +15794
pull_request: https://github.com/python/cpython/pull/16186
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
New changeset 89b8933bb537179f81003928786c5cc6183af591 by Steve Dower in branch
'master':
bpo-38081: Add more non-fatal error codes for ntpath.realpath (GH-16156)
https://github.com/python/cpython/commit/89b8933bb537179f81003928786c5c
Change by Steve Dower :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue38081>
___
___
Pyth
Steve Dower added the comment:
New changeset 76d8fb771659a5574604bf78eb2ee090f5c337cc by Steve Dower in branch
'3.7':
bpo-38117: Update bundled Windows OpenSSL to 1.1.1d (GH-16184)
https://github.com/python/cpython/commit/76d8fb771659a5574604bf78eb2ee0
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
The embeddable distro is meant to be a "redistributable" for end-user machines,
rather than a development kit. "Build" and "distribution" are two clearly
separated tasks (at least on Windows), and so they have different dependencie
Steve Dower added the comment:
Shouldn't this test be suppressed on LTO builds?
#0 builtin_id (self=, v=) at
Objects/longobject.c:1113
builtid_id isn't in longobject.c, so this is incorrect debug information. The
test expects to find it in bltinmodule.c:
re.match(r'.*#0
Steve Dower added the comment:
Closing as a duplicate of issue35941
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> ssl.enum_certificates() regression
___
Python tracker
<https://bugs.python
Steve Dower added the comment:
Greg seems to have done LTO related things in the past, maybe he knows? (All my
PGO contributions only apply to Windows :) )
--
nosy: +gregory.p.smith
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
Why are we keeping the DLL path around at all? It should only be being used in
1-2 places during path calculation.
--
nosy: +steve.dower
___
Python tracker
<https://bugs.python.org/issue38
Steve Dower added the comment:
> _PyPathConfig_Init() initializes _Py_dll_path global variable which is only
> used by _Py_CheckPython3().
Ah okay, maybe I'll take the time later on (in a separate issue) to get rid of
it fully. We may as well load python3.dll at startup anywa
Steve Dower added the comment:
Hey Davin - could this be related to the new tests/restart support we added at
the sprints?
--
nosy: +davin, steve.dower
___
Python tracker
<https://bugs.python.org/issue36
Steve Dower added the comment:
Um, okay then.
The test already includes this:
if ((sysconfig.get_config_var('PGO_PROF_USE_FLAG') or 'xxx') in
(sysconfig.get_config_var('PY_CORE_CFLAGS') or '')):
raise unittest.SkipTest("test_gdb is not
Steve Dower added the comment:
There shouldn't be any annoyance to users, as nobody should be using Windows 8
anymore (the update to 8.1 was free and difficult to avoid).
Updating to NTDDI_WINBLUE is fine, but not essential. Nothing about that flag
has a real impact until we need or wa
Steve Dower added the comment:
> Does it mean that a type A created in interperter 1 can be seen/accessed from
> interpreter 2?
No, but it means that a type A *knows* that it was created in interpreter 1
without relying on the current thread local storage.
What it does wit
Steve Dower added the comment:
(Continuing from the email thread, so read that for context if you haven't)
Binary compatibility of an embedding-only struct is totally unnecessary, as
posted on the thread. There's no feasible way to embed cross-Python versions on
any platform, so
Steve Dower added the comment:
The bug was probably exposed due to a change in path initialization (there's
been a few changes here recently ;) ) that stopped normalising prefix. You can
see that sys.executable in your dumped path has additional "." in the path, and
that
Steve Dower added the comment:
Please file a new issue
--
___
Python tracker
<https://bugs.python.org/issue35360>
___
___
Python-bugs-list mailing list
Unsub
Steve Dower added the comment:
This is a known issue (forgetting the number right now) - Linux-style locales
don't work on Windows, and so there's a normalization function that has to be
completely rewritten.
Also, since these seem to be on your own machine, I'm guessing your
Steve Dower added the comment:
> I checked why sys.executable is not normalized in the the "appx build".
> PC\python_uwp.cpp calls set_process_name() which sets PyConfig.executable and
> the path is not normalized. If PyConfig.executable is set explicitly, the
>
Steve Dower added the comment:
Either way, the paths in the latest tests [1] seem to be fine, and they all
passed, so I don't think this is a release blocker anymore.
Thanks, Victor!
[1]:
https://dev.azure.com/Python/cpython/_build/results?buildId=52024&view=logs&j=c8a71634-e
New submission from Steve Dower :
I noticed that when the nuget.org packages published for 3.8.0rc1, they were
given the version "3.8.0".
3.7.5rc1 was okay because it's still using the old approach to setting the
version.
This needs to be fixed before any more RCs are releas
Change by Steve Dower :
--
nosy: +lukasz.langa
___
Python tracker
<https://bugs.python.org/issue38343>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16118
stage: needs patch -> patch review
pull_request: https://github.com/python/cpython/pull/16527
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset b9a8b8296cd7be22f8b5bf92af686a788c47c7bf by Steve Dower in branch
'master':
bpo-38343: Fixes version handling for nuget packages (GH-16527)
https://github.com/python/cpython/commit/b9a8b8296cd7be22f8b5bf92af686a
Steve Dower added the comment:
I already republished correctly-versioned files and unlisted the wrong ones (as
well as contacting support to see whether they can delete them completely so
they don't impact the final release).
The change above fixes the issue. It will need cherry-pickin
Change by Steve Dower :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Steve Dower added the comment:
Should be a straightforward fix (replace the "else" with "if not defined..."),
but since it slipped through testing we probably want a regression test in
test_venv as well.
(+RM for the 3.8 regression)
--
keywords: +3.8regression
Steve Dower added the comment:
Adding this to the end of test_unicode_in_batch_file seems to be sufficient to
cause the test to fail:
self.assertEqual(err.strip(), '')
Potentially we should add that additional check throughout this test module,
but I don't think that
Steve Dower added the comment:
Also adding Ned - this made it into 3.7 as well.
--
nosy: +ned.deily
versions: +Python 3.7
___
Python tracker
<https://bugs.python.org/issue38
New submission from Steve Dower :
The change to error handling did not include ERROR_CANT_ACCESS_FILE, but this
error occurs in the Store package install.
After suppressing this error, it then occurs again when stripping the prefix -
we should just check for the same error here to determine
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16139
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16551
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I know what this is - in issue38133 I added support for the PEP 514
ExecutablePath key, but didn't add a check for WindowedExecutablePath for the
pyw.exe case.
I'll add it.
--
assignee: -> steve.dower
keywords: +3.8regression
versions
Change by Steve Dower :
--
nosy: +lukasz.langa
priority: normal -> release blocker
___
Python tracker
<https://bugs.python.org/issue38359>
___
___
Python-
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16152
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16561
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
New changeset 353fb1ecbfd58752dabae115c4964095e1e35e5f by Steve Dower in branch
'master':
bpo-38359: Ensures pyw.exe launcher reads correct registry key (GH-16561)
https://github.com/python/cpython/commit/353fb1ecbfd58752dabae115c49640
Steve Dower added the comment:
New changeset a0e3d27e4e3cb5b67e325df080fb18b70c2910cf by Steve Dower in branch
'master':
bpo-38355: Fix ntpath.realpath failing on sys.executable (GH-16551)
https://github.com/python/cpython/commit/a0e3d27e4e3cb5b67e325df080fb18
Steve Dower added the comment:
This is resolved as far as I'm concerned - leaving open for Łukasz to
cherrypick and close.
--
stage: patch review -> backport needed
___
Python tracker
<https://bugs.python.org
Steve Dower added the comment:
This is resolved as far as I'm concerned - leaving open for Łukasz to
cherrypick and close.
--
stage: patch review -> backport needed
___
Python tracker
<https://bugs.python.org
Steve Dower added the comment:
This doesn't apply since Python 3.5, as the HAVE_SXS preprocessor variable is
not defined.
We should just delete this code entirely in 3.9, and patch the message in 2.7.
--
versions: -Python 3.7, Python 3.8, Pytho
Steve Dower added the comment:
Also crashes on Windows (x64 and x86), and on 3.7.5rc1, so this is likely in
our code.
--
nosy: +ned.deily, steve.dower
priority: normal -> release blocker
stage: -> test needed
versions: +Python 3.7
___
Steve Dower added the comment:
I get this assertion in a debug build:
Assertion failed: actual_type_index <= MAX_ELEMENTS, file
c:\projects\cpython\modules\_ctypes\stgdict.c, line 718
--
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
Increasing MAX_ELEMENTS fixes it, but I'm not sure what other impacts there are
from doing that.
+Vinay who added the array handling that's hitting the limit.
--
nosy: +vinay.sajip
versions: +Python 3.9
Steve Dower added the comment:
Given this limit can easily be hit by user code, I'd like to see it turned into
a proper check with an exception (or a dynamic array) rather than just an
assertion. We should not segfault here.
while (length > 0) {
actual_types[actual_ty
Steve Dower added the comment:
Adding email team here, since you were pinged on the PR.
PR 16567 doesn't fix the `inited` member, which is considerably more difficult
to do, unfortunately, but it does mean that it's out of sync with the values
you hold. Arguably this is a better s
Steve Dower added the comment:
New changeset e310af9e2941c2fbb7370e003276cc37eb230f16 by Steve Dower (James
Abel) in branch 'master':
bpo-38344: Fix syntax in activate.bat (GH-16533)
https://github.com/python/cpython/commit/e310af9e2941c2fbb7370e003276cc
Steve Dower added the comment:
I've merged the fix so that it can be cherry-picked for the upcoming releases.
I'd still like to see the tests enhanced to be able to detect error output in
the scripts, but those don't need to necessarily make it into the upc
New submission from Steve Dower :
The iconUrl field has to be replaced with an icon field, and we need to include
the file in the package now.
Details at https://docs.microsoft.com/en-us/nuget/reference/nuspec#icon
--
assignee: steve.dower
components: Windows
messages: 354167
nosy
Steve Dower added the comment:
You're right, they need either your patch or PyErr_WriteUnraisable(NULL) before
returning.
Łukasz - this needs a fix in 3.8, but we don't have to necessarily change the
(internal, but exposed) ABI. For 3.9, we'll fix it properly, but for 3.8 I
New submission from Steve Dower :
It's documented as "os.system" but implemented as just "system".
--
assignee: steve.dower
messages: 354245
nosy: lukasz.langa, steve.dower
priority: normal
severity: normal
status: open
title: Audit event for os.system is incor
Change by Steve Dower :
--
keywords: +patch
pull_requests: +16251
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/16670
___
Python tracker
<https://bugs.python.org/issu
Steve Dower added the comment:
I think you're right about that change touching the right code, but I'm pretty
sure it wasn't working before either. (Python 2.7 had totally different code,
IIRC.)
But the good news is that we should be able to use code similar to wha
New submission from Steve Dower :
The sys.addaudithook raises an audit event 'sys.addaudithook'.
The docs for the function refer to the event, as it has slightly different
semantics than most, but it is not named explicitly and does not appear in the
table of events.
-
601 - 700 of 6138 matches
Mail list logo