[issue4755] Add function to get common path prefix

2014-09-27 Thread Skip Montanaro
Skip Montanaro added the comment: Feel free to close this ticket. I long ago gave up on it. -- ___ Python tracker <http://bugs.python.org/issue4755> ___ ___ Pytho

[issue13936] RFE: change bool(datetime.time(0, 0, 0)) to evaluate as True

2014-03-07 Thread Skip Montanaro
Skip Montanaro added the comment: > the current behaviour takes something that would be a harmless style error > for most structured data types ... I'm not sure what a "structured data type" is, but in my mind the original poster's construct is more than a style err

[issue6520] urllib.urlopen does not have timeout parameter where as urllib2.urlopen has

2009-07-19 Thread Skip Montanaro
Skip Montanaro added the comment: I suspect that was a conscious decision. Back when it was first written urllib2 was supposed to eventually replace urllib I think. Dunno if that's still true, but if so I could see why this feature wasn't added to urllib.urlopen. -

[issue6571] Help index

2009-07-25 Thread Skip Montanaro
Skip Montanaro added the comment: Seems to work as expected for me: >>> 7 >> 1 3 >>> 7 << 1 14 -- nosy: +skip.montanaro ___ Python tracker <

[issue6674] Fatal error: deallocating None

2009-08-10 Thread Skip Montanaro
Skip Montanaro added the comment: Is your mh_python module written in C/C++ or Python? If it's written in C or C++ check your Py_DECREF calls. You are probably doubly decrementing some object which at times refers to Py_None. Do that enough and you eventually try to deallocate it. In

[issue6695] PyXXX_ClearFreeList for dict, set, and list

2009-08-13 Thread Skip Montanaro
Skip Montanaro added the comment: Instead of expanding the C API for each type which supports a free list perhaps there should be a single call, say, PyObject_ClearFreeList, which takes a pointer to the appropriate type object as an argument. PyTypeObject can then grow a tp_free_list slot

[issue6708] raw_input() calls generate compile errors.

2009-08-14 Thread Skip Montanaro
Skip Montanaro added the comment: Try it at the help> prompt without the parens (you're not calling it here, just asking for the documentation on the name "raw_input". help> raw_input Help on built-in function raw_input in module __builtin__: raw_input(...) raw_inpu

[issue6695] PyXXX_ClearFreeList for dict, set, and list

2009-08-16 Thread Skip Montanaro
Skip Montanaro added the comment: >> I thought GC was expected to eliminate reference cycles. Antoine> Of course, but it's also the de facto API when wanting to Antoine> reclaim memory. When did that happen? I agree with Raymond. The cyclic gc should just recl

[issue6715] xz compression support

2009-08-17 Thread Skip Montanaro
Skip Montanaro added the comment: What is xz compression and why is it important? Skip -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue6

[issue6723] csv.writer: example does not work

2009-08-18 Thread Skip Montanaro
Skip Montanaro added the comment: Thanks for the report. Fixed for 2.6, 2.7, 3.0, 3.2. Can't seem to check out a 3.1 branch (tried release31-maint but was rebuffed by svn). -- nosy: +skip.montanaro ___ Python tracker <http://bugs.py

[issue6723] csv.writer: example does not work

2009-08-18 Thread Skip Montanaro
Skip Montanaro added the comment: figured out my checkout problem. will have 3.1 fixed shortly. -- assignee: georg.brandl -> skip.montanaro ___ Python tracker <http://bugs.python.org/iss

[issue6723] csv.writer: example does not work

2009-08-18 Thread Skip Montanaro
Skip Montanaro added the comment: 3.1 corrected as well. -- resolution: -> fixed status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue6883] OptionParser.allow_interspersed_args is undocumented

2009-09-11 Thread Skip Montanaro
New submission from Skip Montanaro : The OptionParser.allow_interspersed_args attribute is undocumented in the Sphinx documentation. (It is mentioned in the OptionParser docstring.) By its name it appears to actually part of the official API, so should at least be mentioned in the rst file

[issue6883] OptionParser.allow_interspersed_args is undocumented

2009-09-17 Thread Skip Montanaro
Skip Montanaro added the comment: Georg> The (en|dis)able_interspersed_args accessors are already Georg> documented, so I see no reason to document the attribute as Georg> well... But it is documented in the class's docstring and there are no docstrings for the methods

[issue6606] csv.Sniffer.sniff on data with doublequotes doesn't set up the dialect properly

2009-09-25 Thread Skip Montanaro
Skip Montanaro added the comment: Thanks. I don't know how to use Reitveld. What am I supposed to do with that? S -- ___ Python tracker <http://bugs.python.org/i

[issue6606] csv.Sniffer.sniff on data with doublequotes doesn't set up the dialect properly

2009-09-27 Thread Skip Montanaro
Skip Montanaro added the comment: Applied to trunk as rev 75102. -- resolution: -> accepted status: open -> closed ___ Python tracker <http://bugs.python.org/

[issue7016] .pyc files are set executable if the .py file is too

2009-09-29 Thread Skip Montanaro
Skip Montanaro added the comment: Steven> $ echo pass > test.py Steven> $ chmod u+x test.py Steven> $ python2.6 -c "import test" Steven> $ ls -l test.pyc Steven> -rwxrw-r-- 1 steve steve 94 2009-09-29 16:54 test.pyc Steven> $ ./test.pyc

[issue1759169] clean up Solaris port and allow C99 extension modules

2009-09-29 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue1759169> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue6186] test_thread occasionally reports unhandled exceptions on OS X

2009-09-30 Thread Skip Montanaro
Skip Montanaro added the comment: and on svn trunk -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue6186> ___ ___ Python-bugs-list mailin

[issue7147] Remove WITHOUT_COMPLEX from 3.x trunk

2009-10-15 Thread Skip Montanaro
New submission from Skip Montanaro : I raised the topic of the use of WITHOUT_COMPLEX in python-dev. Here's a patch to remove it from the 3.x trunk. -- components: Interpreter Core files: nocomplex.diff keywords: easy, needs review, patch, patch messages: 94113 nosy: skip.mont

[issue7147] Remove WITHOUT_COMPLEX from 3.x trunk

2009-10-18 Thread Skip Montanaro
Skip Montanaro added the comment: Committed revision 75495. -- status: open -> closed ___ Python tracker <http://bugs.python.org/issue7147> ___ ___ Python-

[issue7185] csv reader utf-8 BOM error

2009-10-22 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue7185> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue7198] csv.writer

2009-10-24 Thread Skip Montanaro
Skip Montanaro added the comment: Your output file should be opened in binary mode. Sounds like you opened it in text mode. -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue7

[issue7247] test_fcntl_64_bit from test_fcntl.py fails in Python 2.6.4

2009-11-02 Thread Skip Montanaro
Skip Montanaro added the comment: On what platform did you encounter this failure? I can't reproduce it on Mac OSX (Leopard - 10.5.8) or Solaris 10 (update 5) running from up-to-date release26-maint branches or on Ubuntu (8.10) running the 2.6.4 release code. -- nosy: +skip.mont

[issue7251] Mark expected failures of test_math, test_cmath and test_round as such.

2009-11-04 Thread Skip Montanaro
Skip Montanaro added the comment: For 2.6.4 I get a test_float failure on Solaris as well: test test_float failed -- Traceback (most recent call last): File "/home/tuba/skipm/src/python/Python-2.6.4/Lib/test/test_float.py", line 765, in test_roundtrip self.identical(-x, ro

[issue7353] Why was Include/intobject.h removed in 3.1?

2009-11-18 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue7353> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1537721] csv module: add header row to DictWriter

2009-12-07 Thread Skip Montanaro
Skip Montanaro added the comment: I'm sorry, but I don't have time to look at this right now. On the one hand, one person asks for more symmetry. Someone else wants to add a writeheader method. If you want symmetry shouldn't the DictWriter simply write the header without be

[issue1537721] csv module: add header row to DictWriter

2009-12-07 Thread Skip Montanaro
Skip Montanaro added the comment: Antoine> We can't change default behaviour because it will break Antoine> compatibility, so an additional method looks ok to me. Why can't default behavior be changed? S -- ___ Pytho

[issue1537721] csv module: add header row to DictWriter

2009-12-07 Thread Skip Montanaro
Skip Montanaro added the comment: Antoine> We can't change default behaviour because it will break Antoine> compatibility, so an additional method looks ok to me. >> Why can't default behavior be changed? Antoine> Well, because it will break assump

[issue1537721] csv module: add header row to DictWriter

2009-12-07 Thread Skip Montanaro
Skip Montanaro added the comment: >> Isn't the alpha period (2.7 and 3.2 in this case) precisely when an >> API can change? Antoine> Well, it can, but only if there are compelling reasons to do Antoine> so. It should be the exception rather than the rule. T

[issue7475] codecs missing: base64 bz2 hex zlib ...

2009-12-10 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue7475> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1644818] Allow importing built-in submodules

2009-12-19 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue1644818> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5683] Speed up cPickle's pickling generally

2010-01-09 Thread Skip Montanaro
Skip Montanaro added the comment: Updated the patch against the latest version of cPickle.c (r77393). All tests pass on my Mac. -- nosy: +skip.montanaro Added file: http://bugs.python.org/file15808/cPickle.-r77393.patch ___ Python tracker <h

[issue5671] Speed up pickling of lists in cPickle

2010-01-09 Thread Skip Montanaro
Skip Montanaro added the comment: Still applies cleanly (with a little fuzz) to the trunk after applying the issue 5683 patch. Tests all still pass (including xpickle w/ 2.4, 2.5, 2.6 available). -- nosy: +skip.montanaro ___ Python tracker <h

[issue5372] Distutils inappropriately reuses .o files between extension modules

2010-01-09 Thread Skip Montanaro
Skip Montanaro added the comment: LGTM. Nothing is quite as satisfying as simply deleting a bunch of logic/lines. -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue5

[issue5683] Speed up cPickle's pickling generally

2010-01-10 Thread Skip Montanaro
Skip Montanaro added the comment: Antoine> There were a couple of comments on the Rietveld code review Antoine> above. Indeed there are. Given that the Unladen Swallow folks were focusing on the 2.6 branch and their goal was to improve performance I don't see any reason to not

[issue5683] Speed up cPickle's pickling generally

2010-01-10 Thread Skip Montanaro
Skip Montanaro added the comment: Antoine> The main thing I'm worried about is the potentially unbounded Antoine> buffering, since it could reduce performance (or even thrash Antoine> the machine) instead of improving it. Got a test case in mind? If so, I'll code it

[issue5683] Speed up cPickle's pickling generally

2010-01-10 Thread Skip Montanaro
Skip Montanaro added the comment: Antoine> With the patch, the same command quickly swaps hopelessly and Antoine> after 5 minutes of elapsed time I finally manage to kill the Antoine> process. Verified with an Unladen Swallow test case. I'll see if I

[issue5683] Speed up cPickle's pickling generally

2010-01-13 Thread Skip Montanaro
Skip Montanaro added the comment: You can fix it if you are dumping to a file, however if you are calling dumps() you are kind of screwed if dumping large objects. There's no place to flush the buffer. I have a fix to Unladen Swallow's cPickle module. I'm run it by them bef

[issue5683] Speed up cPickle's pickling generally

2010-01-13 Thread Skip Montanaro
Skip Montanaro added the comment: Perhaps. Let's take it one step at a time though. If I change your large pickle example to use dumps() instead of dump() in an unsullied Python2.5 I get a MemoryError. In general, I think you have to be careful using dumps(). Any attempt to solve

[issue5683] Speed up cPickle's pickling generally

2010-01-13 Thread Skip Montanaro
Skip Montanaro added the comment: Oh, BTW, the proposed fix is in Rietveld: http://codereview.appspot.com/189051 -- ___ Python tracker <http://bugs.python.org/issue5

[issue7686] redundant open modes 'rbb', 'wbb', 'abb' no longer work on Windows

2010-01-13 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue7686> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue7698] pystack macro in Misc/gdbinit incorrectly uses PyEval_EvalFrame

2010-01-13 Thread Skip Montanaro
Skip Montanaro added the comment: Thanks for the heads up. Should be fixed on trunk (r77484) and py3k (r77485). -- assignee: -> skip.montanaro nosy: +skip.montanaro resolution: -> fixed status: open -> closed ___ Python track

[issue1098732] Enhance tracebacks and stack traces with vars

2009-02-16 Thread Skip Montanaro
Skip Montanaro added the comment: PyPI: http://pypi.python.org/pypi/tb ___ Python tracker <http://bugs.python.org/issue1098732> ___ ___ Python-bugs-list mailing list Unsub

[issue5332] csv sniffer

2009-02-25 Thread Skip Montanaro
Skip Montanaro added the comment: I verified the bug. I started to work on a patch (see attached), but it quickly seems to get out-of-hand with tracebacks about stuff not supporting the buffer API. I suspect the real solution might involve doing something to convert the bytes to strings read

[issue1818] Add named tuple reader to CSV module

2009-02-26 Thread Skip Montanaro
Skip Montanaro added the comment: Raymond> Barry or Skip, is this something you want in your module? Sorry, I haven't really looked at this ticket other than to notice its presence. I wrote the DictReader/DictWriter functions way back when, so I'm pretty comfortable using the

[issue1818] Add named tuple reader to CSV module

2009-02-26 Thread Skip Montanaro
Skip Montanaro added the comment: Hrm... I replied twice by email. Only one comment appears to have survived the long trip. Here's my second reply: Rob> NamedTupleReader and NamedTupleWriter should be inverses. This Rob> means that NamedTupleWriter needs to write hea

[issue1818] Add named tuple reader to CSV module

2009-02-26 Thread Skip Montanaro
Skip Montanaro added the comment: Let me be more explicit. I don't know how it implements it, but I think you really need to give the user the option of specifying the field names and not reading/writing headers. It can't be implicit as I interpreted Rob's

[issue1818] Add named tuple reader to CSV module

2009-02-26 Thread Skip Montanaro
Skip Montanaro added the comment: Rob> I agree that we should not unconditionally write headers, but I Rob> think that we should write headers by default, much like we read Rob> them by default. I don't think you should write them by default. I've worked with lots

[issue1818] Add named tuple reader to CSV module

2009-02-26 Thread Skip Montanaro
Skip Montanaro added the comment: More concretely, I don't think this is so onerous: names = ["col1", "col2", "color"] writer = csv.DictWriter(open("f.csv", "wb"), fieldnames=names, ...) writer.writerow(dict(zip(names, name

[issue1818] Add named tuple reader to CSV module

2009-02-26 Thread Skip Montanaro
Skip Montanaro added the comment: Rob> I still don't like the lack of symmetry of supporting implicit Rob> header reads, but not implicit header writes. A header is nothing more than a row in the CSV file with special interpretation applied by the user. There is nothing implic

[issue1580] Use shorter float repr when possible

2009-02-27 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker <http://bugs.python.org/issue1580> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue4308] repr of httplib.IncompleteRead is stupid

2009-03-02 Thread Skip Montanaro
Skip Montanaro added the comment: Can't be applied to 2.5 at this point. I agree it's dumb to report the entire partial read and that reporting just the number of bytes read is a much better solution. Your patch looks fine to me as well, except you call resp.close(

[issue4308] repr of httplib.IncompleteRead is stupid

2009-03-02 Thread Skip Montanaro
Changes by Skip Montanaro : -- stage: needs patch -> commit review ___ Python tracker <http://bugs.python.org/issue4308> ___ ___ Python-bugs-list mai

[issue4308] repr of httplib.IncompleteRead is stupid

2009-03-02 Thread Skip Montanaro
Skip Montanaro added the comment: Chris> Why can't it be applied to 2.5? Benjamin can correct me if I'm wrong, but I thought the last 2.5 release was the last full release planned. Certainly if another full 2.5 release is in the cards then the patch should go there a

[issue4308] repr of httplib.IncompleteRead is stupid

2009-03-02 Thread Skip Montanaro
Skip Montanaro added the comment: Martin> The Python 2.5 branch is closed for bug fixes; no further bug Martin> fix releases of Python 2.5 will be made. Only security fixes can Martin> be accepted on the 2.5 branch. So all Chris has to do to get this applied to 2.5 is craft a

[issue1818] Add named tuple reader to CSV module

2009-03-07 Thread Skip Montanaro
Skip Montanaro added the comment: Jervis> in csv.rst removed reference to reader.next() as a public method. Because? I've not seen any discussion in this issue or in any other forums (most certainly not on the c...@python.org mailing list) which would suggest that csv.reader's

[issue1818] Add named tuple reader to CSV module

2009-03-08 Thread Skip Montanaro
Skip Montanaro added the comment: I don't know how NamedTuple objects work, but in many situations you want the content of the CSV file to drive the output. I would think you would use a technique similar to my DictReader example to tell the NamedTupleReader the fieldnames. For that you

[issue1818] Add named tuple reader to CSV module

2009-03-08 Thread Skip Montanaro
Skip Montanaro added the comment: I find this aspect of the proposal disturbing: If *fieldnames* is None the values in the first row of the *csvfile* will be used as the fieldnames I don't think this should be implicit. It makes the NamedTupleReader semantically diff

[issue1818] Add named tuple reader to CSV module

2009-03-08 Thread Skip Montanaro
Changes by Skip Montanaro : -- message_count: 26.0 -> 25.0 ___ Python tracker <http://bugs.python.org/issue1818> ___ ___ Python-bugs-list mailing list Unsubscri

[issue1818] Add named tuple reader to CSV module

2009-03-08 Thread Skip Montanaro
Skip Montanaro added the comment: I retract my previous comment. I don't use the DictReader the way it operates (fieldnames==None => first row is a header) and forgot about that behavior. -- message_count: 25.0 -> 26.0 ___ Python tra

[issue5455] csv module no longer works as expected when file opened in binary mode

2009-03-08 Thread Skip Montanaro
New submission from Skip Montanaro : I just discovered that the csv module's reader class in 3.x doesn't work as expected when used as documented. The requirement has always been that the CSV file is opened in binary mode so that embedded newlines in fields are screwed up. Alas, in

[issue5455] csv module no longer works as expected when file opened in binary mode

2009-03-09 Thread Skip Montanaro
Skip Montanaro added the comment: Jervis> So the returned lineobj is a bytes type and then the Jervis> PyUnicode_Check throws the error. Right, but given that fact how do you get a Unicode string out of the bytes without an encoding? You can't open a file in binary mode a

[issue4847] csv fails when file is opened in binary mode

2009-03-09 Thread Skip Montanaro
Skip Montanaro added the comment: me> What should be the default? Scratch that. If the iterator passed to csv.reader is in a mode which will cause it to emit bytes instead of unicode objects the caller must give an encoding. The csv.reader code will then perform the necessary bytes

[issue4847] csv fails when file is opened in binary mode

2009-03-10 Thread Skip Montanaro
Skip Montanaro added the comment: This issue seems to have simply been overlooked when 3.0 was released. It should be fixed in the next round of 3.0 and 3.1 updates. Any feeback on the idea that the csv.reader constructor (and probably the DictReader and proposed NamedTupleReader constructors

[issue444582] Finding programs in PATH, addition to os

2009-03-15 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker <http://bugs.python.org/issue444582> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1157169] csv Sniffer returns bad dialect?

2009-03-24 Thread Skip Montanaro
Skip Montanaro added the comment: I'm closing this. It's my own fault that it languished for so long, but the current trunk version of Python doesn't demonstrate the behavior Neil documented four years ago. -- resolution: -> out of date stat

[issue1431091] CSV Sniffer fails to report mismatch of column counts

2009-03-24 Thread Skip Montanaro
Skip Montanaro added the comment: (I did try to clarify the return type of the iterator a bit better.) -- ___ Python tracker <http://bugs.python.org/issue1431

[issue1431091] CSV Sniffer fails to report mismatch of column counts

2009-03-24 Thread Skip Montanaro
Changes by Skip Montanaro : -- ___ Python tracker <http://bugs.python.org/issue1431091> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.pyth

[issue1431091] CSV Sniffer fails to report mismatch of column counts

2009-03-24 Thread Skip Montanaro
Skip Montanaro added the comment: Closing as won't fix. There are bound to be limits to how the Sniffer class works. I'm not sure it's worth the effort necessary to fix this corner case. (Andrew, reopen if you want to tackle this.) -- resolution: -> wont fix stat

[issue1157169] csv Sniffer returns bad dialect?

2009-03-24 Thread Skip Montanaro
Skip Montanaro added the comment: (I did try to clarify the return value of the next/__next__ method a bit.) -- ___ Python tracker <http://bugs.python.org/issue1157

[issue2578] Figure out what to do with unittest's redundant APIs

2009-03-29 Thread Skip Montanaro
Changes by Skip Montanaro : -- ___ Python tracker <http://bugs.python.org/issue2578> ___ ___ Python-bugs-list mailing list Unsubscribe: http://mail.python.org/m

[issue2578] Figure out what to do with unittest's redundant APIs

2009-03-29 Thread Skip Montanaro
Skip Montanaro added the comment: Personally, I would prefer it if unittest got rid of all the various ways to spell "assert" and just let test cases use the assert statement. I use nose for most of my stuff which supports/allows use of the assert statement. I think my test cases

[issue2578] Figure out what to do with unittest's redundant APIs

2009-03-29 Thread Skip Montanaro
Skip Montanaro added the comment: Just in case it can't be retrieved, here is Greg's text from msg84360: Oh for reference, i left these out but they may interest people for completeness sake. assert_ 15% assertTrue 9% assertFalse 5% We don&#

[issue1537721] csv module: add header row to DictWriter

2009-03-31 Thread Skip Montanaro
Skip Montanaro added the comment: I don't see a patch. Is there some reason that if you need this you can't simply subclass DictWriter? -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org

[issue1653416] print >> f, "Hello" produces no error: normal?

2009-03-31 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker <http://bugs.python.org/issue1653416> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5632] Bug - threading.currentThread().ident returns None in main thread

2009-03-31 Thread Skip Montanaro
New submission from Skip Montanaro : The main thread has an ident, but the threading module doesn't recognize that fact. I shouldn't have to "start" the main thread. Example: % python Python 2.7a0 (trunk:70084, Feb 28 2009, 20:51:51) [GCC 4.0.1 (Apple Inc. build 5490)]

[issue5632] Bug - threading.currentThread().ident returns None in main thread

2009-03-31 Thread Skip Montanaro
Skip Montanaro added the comment: Here's a test case which reveals the problem as I see it. -- keywords: +patch stage: -> needs patch Added file: http://bugs.python.org/file13525/threading.diff ___ Python tracker <http://bugs.python.or

[issue4847] csv fails when file is opened in binary mode

2009-04-02 Thread Skip Montanaro
Skip Montanaro added the comment: David> I've added some unit tests for embedded newlines, and py3k csv David> passes (on linux at least) when newline='' is used. Unless David> someone can provide a test case that fails when newline='' is

[issue4847] csv fails when file is opened in binary mode

2009-04-02 Thread Skip Montanaro
Skip Montanaro added the comment: David> I also deleted the unicode discussion (since CSV obviously David> handles unicode now) ... Maybe there should be a simple example showing use of the encoding parameter to open() to encode Unicode on write and decode to Unicode on read?

[issue2578] additional unittest type equality methods

2009-04-02 Thread Skip Montanaro
Skip Montanaro added the comment: Am I the only person who wishes all the assert* and fail* methods would simply go away in favor of simply using the assert statement? Skip -- ___ Python tracker <http://bugs.python.org/issue2

[issue2578] additional unittest type equality methods

2009-04-02 Thread Skip Montanaro
Skip Montanaro added the comment: Michael> Why do you need the assert methods to go away in order to use Michael> assert statements? You don't, but use of assert statements seems a hell of a lot more Pythonic to me than all the assert* or fail* method names which I can never r

[issue2578] additional unittest type equality methods

2009-04-02 Thread Skip Montanaro
Skip Montanaro added the comment: >> You don't, but use of assert statements seems a hell of a lot more >> Pythonic to me than all the assert* or fail* method names which I can >> never remember. Antoine> 1. they are optimized away in "-Oxxx" m

[issue5724] 2.6.2c1 fails to pass test_cmath on Solaris10

2009-04-08 Thread Skip Montanaro
New submission from Skip Montanaro : I configured and built Python 2.6.2c1 on Solaris 10 using gcc 4.2. All tests pass except cmath: % LD_LIBRARY_PATH=. ./python Lib/test/regrtest.py -v test_cmath test_cmath test_abs (test.test_cmath.CMathTests) ... ok test_cmath_matches_math

[issue5724] 2.6.2c1 fails to pass test_cmath on Solaris10

2009-04-08 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: +marketdickinson ___ Python tracker <http://bugs.python.org/issue5724> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue5724] 2.6.2c1 fails to pass test_cmath on Solaris10

2009-04-11 Thread Skip Montanaro
Skip Montanaro added the comment: Mark> Here's a patch that backports the corresponding changes from Mark> trunk. Mark> Skip, can you confirm that this fixes the issue? Indeed, your patch appears to fix the problem: % LD_LIBRARY_PATH=. ./python Lib/test/regrtest.py

[issue5724] 2.6.2c1 fails to pass test_cmath on Solaris10

2009-04-11 Thread Skip Montanaro
Skip Montanaro added the comment: FWIW, with the patch applied all tests still pass on Mac OS X 10.5.6 (Intel). S -- ___ Python tracker <http://bugs.python.org/issue5

[issue5736] Add the iterator protocol to dbm modules

2009-04-12 Thread Skip Montanaro
Skip Montanaro added the comment: Akira> Note that dbm and gdbm C API is a little different. gdbm_nextkey Akira> requires key for its argument, dbm_nextkey don't. So I had to Akira> use for gdbm an static variable that points to the current Akira> position. I do

[issue5736] Add the iterator protocol to dbm modules

2009-04-12 Thread Skip Montanaro
Skip Montanaro added the comment: skip> What's worse, even in a non-threaded environment you might want to skip> iterate over the gdbm file simultaneously from two different skip> places. Or iterate over two different gdbm files

[issue4111] Add DTrace probes

2009-04-22 Thread Skip Montanaro
Skip Montanaro added the comment: Sorry, I've been away from this issue. I was sort of hoping the Sun and Apple folks would just work things out amongst themselves and present us with a fait accompli. ;-) I'll try to mess around with this a little. Robert> $ sudo dtrace ...

[issue4111] Add DTrace probes

2009-04-23 Thread Skip Montanaro
Skip Montanaro added the comment: Robert> Is there any interest in my expanding the list of probes? Yes. Jeff Garrett (a guy I work with) added some more DTrace probes to a 2.4 source tree at work. I mentioned them in an earlier message. I'll check with him at work tomorrow and s

[issue1755841] Patch for [ 735515 ] urllib2 should cache 301 redir

2009-04-27 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker <http://bugs.python.org/issue1755841> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1511] csv input converts \r\n to \n but csv output does not when a field has internal line breaks

2009-05-12 Thread Skip Montanaro
Skip Montanaro added the comment: Daniel> Daniel Diniz added the comment: Daniel> I get different behavior in py3k compared to trunk: Daniel> ~/trunk-py$ ./python issue1511_py3k.py Daniel> [['foo', 'bar\r\nbaz\r\nbiff', 'boo']

[issue6105] json.dumps doesn't respect OrderedDict's iteration order

2009-05-26 Thread Skip Montanaro
Skip Montanaro added the comment: I can't see that the order of keys should matter for language-neutral serialization libs like json or xmlrpclib. You're quite possibly going to be communicating with something on the other end which doesn't have an OrderedDict-like class. Wh

[issue6251] c++ extension module implementation guide/example in extending/embedding documentation

2009-06-10 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: +skip.montanaro ___ Python tracker <http://bugs.python.org/issue6251> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue4007] make clean fails to delete .a and .so.X.Y files

2010-05-15 Thread Skip Montanaro
Skip Montanaro added the comment: >> Note: Using find -delete avoids the extra process spawning for rm. The -delete expression isn't universally available. For example, it is not present on Solaris. Better just to stick with the reliabl

[issue1371826] distutils is silent about multiple -I/-L/-R

2010-05-20 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker <http://bugs.python.org/issue1371826> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1109602] Need some setup.py sanity

2010-05-20 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker <http://bugs.python.org/issue1109602> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue967934] csv module cannot handle embedded \r

2010-05-20 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker <http://bugs.python.org/issue967934> ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue1072404] Bugs in _csv module - lineterminator

2010-05-20 Thread Skip Montanaro
Changes by Skip Montanaro : -- nosy: -skip.montanaro ___ Python tracker <http://bugs.python.org/issue1072404> ___ ___ Python-bugs-list mailing list Unsubscribe:

<    2   3   4   5   6   7   8   9   >