Senthil Kumaran added the comment:
Antoine - I approached it from idea that check_hostname "as a setting" is
allowed from HTTPSConnection (http/client.py) but it not controllable from
urllib. Is there a case where it is useful in HTTPSConnection, but it should
not be from urllib?
Senthil Kumaran added the comment:
> HTTPSConnection is lower-level, so it makes sense to allow more
> deviations there. That's why HTTPSConnection also takes the context
> directly.
That's okay of an explanation. HTTPSHandler in urllib module provides an option
to send
Senthil Kumaran added the comment:
I think, HTMLParseError should also be defined __all__ (all also servers as
what public classes/methods to look for sometimes and sets some expectation
while reading the code.)
There is no deprecation warning added in the class here.
--
nosy
Senthil Kumaran added the comment:
Is there a better way to reproduce the error in the first place.
On 2.7 tip,
./python -m idelib.idle
Opened and closed bigfile.py and decimal.py - and could not reproduce the
error. If I could, I could have tested the patch.
--
nosy: +orsenthil
Senthil Kumaran added the comment:
I dont have ActiveState TCL, but I could use IDLE with the default libs with my
Macbook Pro (OS X10.7), followed the steps given to reproduce the error and
unfortunately could not.
--
nosy: +orsenthil
___
Python
Senthil Kumaran added the comment:
Thanks for the patch and test coverage. LGTM. I shall verify further and commit
it.
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
I shall do it. Just for keeping it clean and it may help when future patches
can be merged across branches cleanly. There is no loss IMO.
--
___
Python tracker
<http://bugs.python.org/issue17
New submission from Senthil Kumaran:
Sometime back during an IRC conversation we realized that converting
test_urllib2 doctests to proper unittest may help in various ways.
a) Improve coverage report (?) Know what is covered and not.
b) Helps expand it further when new features are added
Senthil Kumaran added the comment:
I have pushed the changes since they are restricted to test files. If there are
review comments, I shall do make the changes.
I shall consider to to make 3.3 tests close to default branch ones so that
fixes can be backported. (Leaving the bug open for that
Senthil Kumaran added the comment:
RFC3986 bears the weightage since urlparse aims to satisfy that. As per that,
mailto should return the url as path, and current urlparse behaves properly.
$ ./python.exe
Python 3.4.0a0 (default:50164abbfc98+, Apr 8 2013, 22:19:34)
[GCC 4.2.1 (Apple Inc
Changes by Senthil Kumaran :
--
resolution: fixed -> invalid
___
Python tracker
<http://bugs.python.org/issue6640>
___
___
Python-bugs-list mailing list
Un
Senthil Kumaran added the comment:
Changed in active branches (3.3 and default).
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issu
Changes by Senthil Kumaran :
--
versions: +Python 3.3
___
Python tracker
<http://bugs.python.org/issue17648>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thanks for the patch. Realized that is_third_party method does not have test
coverage. Hence this was not detected by our test runs. Increasing the coverage
may be a TODO.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
Senthil Kumaran added the comment:
Doko: I am not strongly against the 2.7 patch. Given the last point you made
providing the context from BDFL and also some of Eric's points, going ahead
with your 2.7 patch seems OK to me. So +1
--
___
P
Changes by Senthil Kumaran :
--
resolution: -> fixed
stage: patch review -> committed/rejected
status: open -> closed
type: -> behavior
___
Python tracker
<http://bugs.pytho
Senthil Kumaran added the comment:
Incidentally I was looking at this bug in the morning and it looks like this
one is on the edge. Looks like we may not need the functionality as provided by
the patch.
The existing headers are set in "FieldStorage" for use within the FieldStorage
Senthil Kumaran added the comment:
Andrew - Please go ahead with commit. I reviewed the patch and it looks good to
me as well. It is a bug so it should be backported.
Thanks for the patch and a good test, Jeff Knupp. Agree with your reasoning /
lack of documentation on send behavior w.r.t to
Senthil Kumaran added the comment:
I am closing this as an Invalid issue. Please bring to discussion at python-dev
if someone disagrees. Thank you!
--
resolution: -> invalid
status: open -> closed
___
Python tracker
<http://bugs.p
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue17665>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Yes, RFC specifically states that "The absoluteURI form is REQUIRED when the
request is being made to a proxy." Thanks Jessica for making a note of that.
Closing this issue as Invalid.
--
dependencies: -urllib2 fails against IIS 6.0 (No s
Senthil Kumaran added the comment:
Agree with Demian Brecht. This issue is being closed in when two issues cover
the requirements discussed here.
* issue# 16901 - For Enhancing FileCookieJar
* issue# 9740 - For supporting persistant HTTP 1.1 connections.
(:-( on me)
--
nosy
Senthil Kumaran added the comment:
My suggestion for this issue is going ahead with patch2 of Mher. It does a
simple normalization and does the right thing.
The case in the question is an empty query string and behavior or Allow and
Disallow for that and patch addresses that. (I don't
Senthil Kumaran added the comment:
Can you give the full snippet that you are trying. I assume you are using
urllib2? Also If you give the same URL to your other clients like browser, does
the resolution happen properly?
--
nosy: +orsenthil
Senthil Kumaran added the comment:
I have committed the first patch which makes Request.full_url a descriptor.
As I was looking at the changes to be introduced by second patch, I noticed
that we do not have comprehensive test coverage for .full_url public attribute.
All the tests are testing
Senthil Kumaran added the comment:
I had added a note in the documentation c3656dca65e7 conveying that splittype,
splithost should not be relied upon, and urlparse should be used for parsing.
Also, Python3 does not include these in __all__ - It is in Python2 for
backwards compatibility
Senthil Kumaran added the comment:
OMG. That's a glaring mistake. Thanks for fixing it.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/is
Senthil Kumaran added the comment:
Hello zhaoqifa,
Your suggestion for the solution looks good to me. Instead of cd-ing to each
dir, you cd to target dir when ftp url is accessed.
Two things to consider.
1) Will the above change have any security implications. It does not seem to
me. But I
Senthil Kumaran added the comment:
Hello Simon,
Thanks for bringing this to attention. Since get_origin_req_host has been under
deprecation was a release, I thought it was safe to remove that. Agree that
documentation of "cookiejar" methods, which had a dependency on the change
s
Senthil Kumaran added the comment:
Here is patch with tests and docs. I see no changes to opener is required and
the selector which is sent to HTTP request is the correct one. I have added
tests for redirect url with #fragment too (For testing scenario reported in
Issue 8280).
I shall close
Senthil Kumaran added the comment:
This change is documented. Thanks for the report.
--
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
This is fixed in 3.4. I dont think backporting is a good idea just to support
assignment to .full_url. Thinking of this further, the idea of reusing request
by assigning to .full_url may not be a good idea, because if you set .full_url
to a completely
Senthil Kumaran added the comment:
Thanks for filing this. Does test cases pass after removal of those lines? (I
will be surprised) and if the tests fail, then after analyzing it, this could
only be considered a new change (thus change to made in latest python) in order
not to break
Senthil Kumaran added the comment:
Hello Julian,
Can you please provide a test case of this parsing misbehavior? It might be
easier to identify with the testcase. Better yet, the patch changing the
parsing logic will help identify if we are dealing with any regression.
Thanks
Senthil Kumaran added the comment:
On Saturday, January 3, 2015 at 12:46 AM, Julian Reschke wrote:
> An example URI for this issue is:
>
> http://example.com/;
>
> The RFC 3986 path component for this URI is "/;".
I think, a stronger argument might be desirable (so
Senthil Kumaran added the comment:
I reviewed the patch Serhiy. It looks good to me, You can go ahead and commit.
Thanks!
--
assignee: orsenthil -> serhiy.storchaka
___
Python tracker
<http://bugs.python.org/iss
Senthil Kumaran added the comment:
Ouch. Will fix this today. Strange, I think, no coverage exists for that and it
has escaped our testing.
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Demian, sure, will do.
--
___
Python tracker
<http://bugs.python.org/issue23300>
___
___
Python-bugs-list mailing list
Unsub
Senthil Kumaran added the comment:
Nikolaus, nothing might be required from your end. Just a good protocol to keep
the interested parties in CC.
--
___
Python tracker
<http://bugs.python.org/issue23
Senthil Kumaran added the comment:
Here is the patch to fix this. I have added a test case covering this change.
Please review this and if it is good to go, I will commit it. Thank you.
--
keywords: +patch
stage: needs patch -> patch review
Added file: http://bugs.python.org/file37
Senthil Kumaran added the comment:
Addressed Berker's review comments.
1) Made the TestServer a Mixin. (Thanks, that's the correct to do).
2) Changed Post to Port.
3) I went with still using a testdomain and port in the constructor. My idea of
the test is to demonstrate that the co
Senthil Kumaran added the comment:
Fixed in 2.7. Other versions do not have this bug.
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
> Would porting the tests be useful, though?
Yes, it will be useful to port the tests to 3.4 and default branch.
I will do that.
--
status: closed -> open
___
Python tracker
<http://bugs.python.org/i
Senthil Kumaran added the comment:
Actually, the same tests cannot be ported to 3.4 or default. httplib.HTTP class
has been merged to HTTPConnection in 3.x and we don't allow a host, and port in
connect().
There is good test coverage for verifying host, port in test_hort_port test in
Senthil Kumaran added the comment:
Thanks for the review comments. Updated the patch with the suggested changes.
--
Added file: http://bugs.python.org/file37844/23300-3.3-v2.patch
___
Python tracker
<http://bugs.python.org/issue23
Senthil Kumaran added the comment:
Committed the test changes in fcab9c106f2f (3.4) and a858cde113f2 (3.5)
--
status: open -> closed
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
Yup, can confirm that this is problem. As Andy recognized, there is parsing
error that fails on '/' character in the password.
The environ based proxies are used by urllib rather than urllib2. (The test
case if relies on environ proxy,
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue23334>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thanks for the tests. Reviewed the patch and looks good to me.
--
nosy: +orsenthil
stage: -> commit review
___
Python tracker
<http://bugs.python.org/issu
Senthil Kumaran added the comment:
In the initial report, I thought, it was mentioned that curl reads the same
http_proxy variable properly. It will be good to have a correct curl test case
to ascertain that.
But, at all the places, where @ character is allowed in urls (netrc, git
configs
Senthil Kumaran added the comment:
The default version was fixed in issue21528, changeset db302b88fdb6. perhaps it
simply needs to be backported.
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue24
Senthil Kumaran added the comment:
Thanks for the helpful, patch. I modified it to include only the faq.rst and
functions.rst and applied it.
--
assignee: docs@python -> orsenthil
nosy: +orsenthil
stage: patch review -> resolved
status: open -&g
Changes by Senthil Kumaran :
--
assignee: docs@python -> orsenthil
nosy: +orsenthil
resolution: -> fixed
status: open -> closed
versions: +Python 3.6
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Updated the docs as per Georg's suggestion. Thank you Ted Lemon for bringing
this up.
--
assignee: docs@python -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
vers
Senthil Kumaran added the comment:
os.environ is never changed by getproxies_environment()
Like Martin Panter, I will curious to know as how the user experienced this
issue in the place.
@Raymond Hettinger: If the dict is only read and never modified in the fuction,
does it still make sense
Senthil Kumaran added the comment:
Closing this since no further update was available from the original reporter.
If this bug is still present, please open a new issue with test case to
reproduce.
--
nosy: +orsenthil
resolution: -> not a bug
stage: -> resolved
status: p
Senthil Kumaran added the comment:
SimpleHTTPServer is never meant to be used in production.
I was of the understanding that we already inform users about it in the
documentation, but I do not find any such note. Only in wsgiref's
simple_server.py example, we state that in the module h
Senthil Kumaran added the comment:
Thanks for the report, Pankaj Sharma. Removed in 2.7.11+.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tr
Senthil Kumaran added the comment:
Hi @Berker,
This patch breaks the unit tests. Could you confirm (or reject) this?
Thanks
--
___
Python tracker
<http://bugs.python.org/issue6
Senthil Kumaran added the comment:
The bltin-file-objects was not referenced in pyspecific.py from which this data
was generated. Added it and fixed it.
Verified that it is available in 2.7 now.
--
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status
Senthil Kumaran added the comment:
Please use stackoverflow or python-tutor list to get help on this.
https://mail.python.org/pipermail/tutor/
This is unlikely a problem as you are using replace the send time on new string
object.
--
nosy: +orsenthil
resolution: -> rejected
st
Senthil Kumaran added the comment:
Thanks for patch and the work on Green Tree Snakes, Thomas.
It is a great resource. I agree that a lot could be included directly in stdlib
docs, but till then, as suggested/recommended by Andrew and Ezio, a see also
link is a good addition
Changes by Senthil Kumaran :
--
assignee: -> martin.panter
___
Python tracker
<http://bugs.python.org/issue25940>
___
___
Python-bugs-list mailing list
Un
Senthil Kumaran added the comment:
Here is the patch with the changes suggested by Brett.
Having created this patch, I had second thoughts on this change. Folks who use
pip often, usually use it without any quotes, like `pip install requests`, `pip
install CherryPy`. Pinned down versions are
Senthil Kumaran added the comment:
Here is the patch with the suggested wording.
--
keywords: +patch
nosy: +orsenthil
Added file: http://bugs.python.org/file41530/Issue23675.patch
___
Python tracker
<http://bugs.python.org/issue23
Changes by Senthil Kumaran :
--
stage: needs patch -> patch review
___
Python tracker
<http://bugs.python.org/issue23675>
___
___
Python-bugs-list mai
Senthil Kumaran added the comment:
Fixed in all branches for which documentation will be published / updated.
--
assignee: docs@python -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: patch review -> resolved
status: open
Senthil Kumaran added the comment:
This bug report can be closed as the patch, written by me is no longer valid.
The only useful addition it can bring is, exposing the BUFSIZE, but that is
used transparently by the module and I think, it need not be exposed via
documentation
Senthil Kumaran added the comment:
This was an interesting issue. Thanks for the patch, Sean to fix this bug. I
have committed it in 3.5 and 3.6.
--
assignee: -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
versi
New submission from Senthil Kumaran:
A number of old methods in trace module were deprecated in issue10371. They
should be removed in 3.6 release.
--
components: Library (Lib)
messages: 257877
nosy: belopolsky, orsenthil
priority: normal
severity: normal
stage: needs patch
status: open
Senthil Kumaran added the comment:
This patch removes the deprecated apis from 3.6. After getting a review from
one another core dev, I will commit this.
* No doc changes are required as the deprecated apis were not documented.
* README will be added during commit.
--
assignee
Senthil Kumaran added the comment:
Sorry for that. Here is the patch.
--
keywords: +patch
Added file: http://bugs.python.org/file41562/issue26069.patch
___
Python tracker
<http://bugs.python.org/issue26
Senthil Kumaran added the comment:
@Martin, thanks for the review comments. I've addressed this is version 2 of
the patch. I am submitting this change.
--
versions: +Python 2.7, Python 3.5, Python 3.6
Added file: http://bugs.python.org/file41563/Issue23675-v2.
Senthil Kumaran added the comment:
Fixed in the active documentation branches 2.7,3.5 and 3.6.
--
assignee: docs@python -> orsenthil
resolution: -> fixed
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
I reviewed the patch. It looks like the problem is not just with list functions
but with other options too. Like.
$ ./python.exe -m trace -t
$ ./python.exe -m trace -c
$ ./python.exe -m trace -T
Will throw the same error. So, any changes should address all
Senthil Kumaran added the comment:
The patch is correct and will fix the issue. It will require test coverage to
be complete so that we don't land upon similar issues in future.
--
nosy: +orsenthil
stage: -> test needed
versions: +Python 3.5, Python 3.6 -Py
Senthil Kumaran added the comment:
@SilentGhost, I agree with you. I am making the change to use argparse as part
of this issue24649. And this bug could be covered as part of the change to
argparse.
--
___
Python tracker
<http://bugs.python.
Senthil Kumaran added the comment:
Thanks for the review, matrixise. I've submitted this change.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<http://bugs.pyth
Senthil Kumaran added the comment:
Hi Berker, could you find the reference for it? It will be helpful to analyze.
IMO, the non-removal of 2.x-> 3.x APIs could be done on a case to case basis.
In this case, issue10371 made the change in (2010) of making the undocumented
public methods
Senthil Kumaran added the comment:
The patch looks good to me. The change is in the error message of the
AssertionError and don't test the error messages of Exceptions in our unittest.
This change is a good usability improvement and I will commit this patch.
--
assignee: -> o
Senthil Kumaran added the comment:
Verified the change and committed.
The new output behavior will be like this.
```
>>> from unittest.mock import Mock
>>> mock = Mock(return_value=None)
>>> for i in range(1, 10):
... mock(i)
...
>>> from unittest.mock
Senthil Kumaran added the comment:
@SilentGhost,
Thanks a lot for the quick turn around of a patch. I have left some review
comments in reitveld. Please address them.
Since this is underlying implementation change in option processing/parsing, it
should only in feature release (3.6).
Thank
Senthil Kumaran added the comment:
Simon, sure. It is just for someone, either commiters or other interested folks
to add the tests on top of your patch. Agree with you that more change is
required to add the required tests.
--
___
Python tracker
Senthil Kumaran added the comment:
Thanks for the contribution. The option handling of trace module is modernized
now.
As berker suggested in one of the review comments, this module could see an
increase in test coverage and we could deal with this as separate ticket.
--
resolution
Changes by Senthil Kumaran :
--
assignee: -> orsenthil
___
Python tracker
<http://bugs.python.org/issue25822>
___
___
Python-bugs-list mailing list
Unsubscrib
Senthil Kumaran added the comment:
Thank you, Swati.
I reviewed and committed your patch. I had to make some minor formatting
changes while keeping an eye for the maintainability of the module and doc
strings.
* Moved all the doc strings up to a single place just below the namespaces are
Senthil Kumaran added the comment:
Thanks for the report. Fixed.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Thanks for the patch, Upendra Kumar. It's fixed now. Appreciate your taking
care of other args and making the change meaningful.
--
assignee: docs@python -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> resolve
Senthil Kumaran added the comment:
Thank you for the report. Fixed in the active versions of python (3.5 and 3.6).
3.4 was in security fix mode. Although, it can see important documentation
bug-fixes, this isn't bug-fix as far as 3.4 version is concerned. So, I didn't
make the cha
Senthil Kumaran added the comment:
Thanks for the pointers, Berker. That was very helpful and I will keep in mind
when evaluating other deprecated apis.
For the trace module, I will add this removal information in
Doc/whatsnew/3.6.rst
Senthil Kumaran added the comment:
Thanks for reporting. Fixed.
--
nosy: +orsenthil
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<http://bugs.python.or
Senthil Kumaran added the comment:
Thanks for the review/comment Ezio. Agree with your suggestion and made the
change accordingly.
--
assignee: docs@python -> orsenthil
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
versions: +Python 2.7, Python
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue26134>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
@Serhiy, the patch looks good to me. This change is an excellent idea. Please
commit it.
--
assignee: berker.peksag -> serhiy.storchaka
stage: patch review -> commit review
___
Python tracker
Senthil Kumaran added the comment:
Given that we have not received any more reports on users tripping up on this
message, it seems to me that we could just ignore this report and close it.
Thoughts?
--
nosy: +orsenthil
___
Python tracker
<h
Senthil Kumaran added the comment:
Thanks for the report and the patch. I have fixed that in 3.5 and 3.6 docs. I
found it reasonable to include the full module path for TimeoutError makeing it
consist with asyncio and multiprocessing TimeoutError.
Also, Error exception is not exposed via
Senthil Kumaran added the comment:
I followed the previous discussions and reviewed the patch. With respect to the
patch, I see few drawbacks in providing links to references like this:
`fcntl <http://pubs.opengroup.org/onlinepubs/009695399/basedefs/fcntl.h.html>`_
`ioctl
Changes by Senthil Kumaran :
--
nosy: +orsenthil
___
Python tracker
<http://bugs.python.org/issue26150>
___
___
Python-bugs-list mailing list
Unsubscribe:
Senthil Kumaran added the comment:
Thanks for the report. Fixed.
--
assignee: davin -> orsenthil
nosy: +orsenthil
resolution: -> fixed
stage: needs patch -> resolved
status: open -> closed
type: enhancement -> behavior
version
Senthil Kumaran added the comment:
Thanks for the patch. I had to do some minor clarification like mention view
types apply only to dict and also remove the sentence which mentioned those
equivalent to list(o.values()) and list(o.items()) in the patch.
With those fixed, I have commited the
1901 - 2000 of 2044 matches
Mail list logo
